Skip to content

armgit / ECC

Public Imported from GitHub
0

The agent harness performance optimization system. Skills, instincts, memory, security, and research-first development for Claude Code, Codex, Opencode, Cursor and beyond.

fix(skill-stocktake): use NUL-delimited paths to avoid newline desync

Deepu S Nath981f97bff49d
diff --git a/skills/skill-stocktake/scripts/quick-diff.sh b/skills/skill-stocktake/scripts/quick-diff.sh
index a2177b39a..f929b2432 100755
--- a/skills/skill-stocktake/scripts/quick-diff.sh
+++ b/skills/skill-stocktake/scripts/quick-diff.sh
@@ -56,13 +56,15 @@ process_dir() {
# Capture find's exit status and stderr instead of discarding them: with -L,
# a broken symlink or unreadable directory makes find skip that entry AND
# exit non-zero, which would otherwise silently under-count skills.
- if ! find -L "$dir" -name "SKILL.md" -type f >"$find_out" 2>"$find_err"; then
+ # NUL-delimited (-print0 / sort -z / read -d '') so a path containing a
+ # literal newline can't desync record boundaries — paths here are untrusted.
+ if ! find -L "$dir" -name "SKILL.md" -type f -print0 >"$find_out" 2>"$find_err"; then
echo "Warning: find encountered errors while scanning $dir (broken symlinks or permission issues may cause skills to be missed):" >&2
cat "$find_err" >&2
fi
- sort -o "$find_out" "$find_out"
+ sort -z -o "$find_out" "$find_out"
- while IFS= read -r file; do
+ while IFS= read -r -d '' file; do
local mtime dp is_new
mtime=$(date -u -r "$file" +%Y-%m-%dT%H:%M:%SZ)
dp="${file/#$HOME/~}"
diff --git a/skills/skill-stocktake/scripts/scan.sh b/skills/skill-stocktake/scripts/scan.sh
index 4197fff96..76f5523dc 100755
--- a/skills/skill-stocktake/scripts/scan.sh
+++ b/skills/skill-stocktake/scripts/scan.sh
@@ -100,13 +100,15 @@ scan_dir_to_json() {
# Capture find's exit status and stderr instead of discarding them: with -L,
# a broken symlink or unreadable directory makes find skip that entry AND
# exit non-zero, which would otherwise silently under-count skills.
- if ! find -L "$dir" -name "SKILL.md" -type f >"$find_out" 2>"$find_err"; then
+ # NUL-delimited (-print0 / sort -z / read -d '') so a path containing a
+ # literal newline can't desync record boundaries — paths here are untrusted.
+ if ! find -L "$dir" -name "SKILL.md" -type f -print0 >"$find_out" 2>"$find_err"; then
echo "Warning: find encountered errors while scanning $dir (broken symlinks or permission issues may cause skills to be missed):" >&2
cat "$find_err" >&2
fi
- sort -o "$find_out" "$find_out"
+ sort -z -o "$find_out" "$find_out"
- while IFS= read -r file; do
+ while IFS= read -r -d '' file; do
local name desc mtime u7 u30 dp
name=$(extract_field "$file" "name")
desc=$(extract_field "$file" "description")