The agent harness performance optimization system. Skills, instincts, memory, security, and research-first development for Claude Code, Codex, Opencode, Cursor and beyond.
test(clv2): add coverage for instinct-cli prune, projects ops, promote dry-run, normalize-url (#2374)
Gaurav Dubeya36148fff972
diff --git a/skills/continuous-learning-v2/scripts/test_parse_instinct.py b/skills/continuous-learning-v2/scripts/test_parse_instinct.pyindex a79799863..290ff9114 100644--- a/skills/continuous-learning-v2/scripts/test_parse_instinct.py+++ b/skills/continuous-learning-v2/scripts/test_parse_instinct.py@@ -1147,3 +1147,275 @@ def test_remove_project_storage_blocks_traversal(patch_globals):def test_remove_project_storage_blocks_root_itself(patch_globals):with pytest.raises(ValueError):_remove_project_storage(".")+++# ─────────────────────────────────────────────+# Issue #2302 coverage:+# _normalize_remote_url, _promote_specific dry-run,+# projects delete/gc/merge, cmd_prune+# ─────────────────────────────────────────────++_normalize_remote_url = _mod._normalize_remote_url+_cmd_projects_delete = _mod._cmd_projects_delete+_cmd_projects_gc = _mod._cmd_projects_gc+_cmd_projects_merge = _mod._cmd_projects_merge+cmd_prune = _mod.cmd_prune+++# ── _normalize_remote_url ────────────────────++def test_normalize_remote_url_empty_returns_empty():+ assert _normalize_remote_url("") == ""+ assert _normalize_remote_url(None) == ""+++def test_normalize_remote_url_scp_form():+ # scp-style host:path -> host/path, credentials/.git stripped, lowercased+ assert _normalize_remote_url("[email protected]:Test/Repo.git") == "github.com/test/repo"+++def test_normalize_remote_url_https_strips_credentials_and_scheme():+ assert (+ _normalize_remote_url("https://user:[email protected]/test/repo.git")+ == "github.com/test/repo"+ )+++def test_normalize_remote_url_network_is_lowercased():+ assert _normalize_remote_url("https://GitHub.com/Owner/Project") == "github.com/owner/project"+++def test_normalize_remote_url_trailing_slash_and_dotgit_stripped():+ assert _normalize_remote_url("https://github.com/a/b.git/") == "github.com/a/b"+++def test_normalize_remote_url_file_scheme_preserves_case():+ # Local file paths are not network URLs: scheme is stripped but case is preserved.+ assert _normalize_remote_url("file:///srv/Repos/My-Repo/") == "/srv/Repos/My-Repo"+++def test_normalize_remote_url_idempotent():+ once = _normalize_remote_url("https://[email protected]/Test/Repo.git")+ assert _normalize_remote_url(once) == once+++# ── _promote_specific dry-run ────────────────++def test_promote_specific_dry_run_writes_nothing(patch_globals, capsys):+ """dry_run returns 0, prints [DRY RUN], and writes no global file."""+ tree = patch_globals+ project = _make_project(tree)+ (project["instincts_personal"] / "inst.yaml").write_text(SAMPLE_INSTINCT_YAML)++ ret = _promote_specific(project, "test-instinct", force=True, dry_run=True)+ assert ret == 0+ out = capsys.readouterr().out+ assert "[DRY RUN]" in out+ assert not (tree["global_personal"] / "test-instinct.yaml").exists()+ assert list(tree["global_personal"].iterdir()) == []+++# ── projects delete ──────────────────────────++def test_projects_delete_rejects_invalid_id(patch_globals, capsys):+ args = SimpleNamespace(project_id="../escape", dry_run=False, force=True)+ assert _cmd_projects_delete(args) == 1+ assert "Invalid project ID" in capsys.readouterr().err+++def test_projects_delete_not_found(patch_globals, capsys):+ args = SimpleNamespace(project_id="ghost123", dry_run=False, force=True)+ assert _cmd_projects_delete(args) == 1+ assert "not found" in capsys.readouterr().err+++def test_projects_delete_dry_run_keeps_registry_and_storage(patch_globals, capsys):+ tree = patch_globals+ _make_project(tree, pid="proj1", pname="p1")+ tree["registry_file"].write_text(json.dumps({"proj1": {"name": "p1"}}))++ args = SimpleNamespace(project_id="proj1", dry_run=True, force=False)+ assert _cmd_projects_delete(args) == 0+ assert "[DRY RUN]" in capsys.readouterr().out+ assert (tree["projects_dir"] / "proj1").exists()+ assert "proj1" in json.loads(tree["registry_file"].read_text())+++def test_projects_delete_force_removes_registry_and_storage(patch_globals, capsys):+ tree = patch_globals+ _make_project(tree, pid="proj1", pname="p1")+ tree["registry_file"].write_text(json.dumps({"proj1": {"name": "p1"}}))++ args = SimpleNamespace(project_id="proj1", dry_run=False, force=True)+ assert _cmd_projects_delete(args) == 0+ assert "Deleted project" in capsys.readouterr().out+ assert not (tree["projects_dir"] / "proj1").exists()+ assert "proj1" not in json.loads(tree["registry_file"].read_text())+++# ── projects gc ──────────────────────────────++def test_projects_gc_no_candidates(patch_globals, capsys):+ tree = patch_globals+ tree["registry_file"].write_text("{}")+ args = SimpleNamespace(dry_run=False, force=True)+ assert _cmd_projects_gc(args) == 0+ assert "No zero-value project entries" in capsys.readouterr().out+++def test_projects_gc_dry_run_keeps_entry(patch_globals, capsys):+ tree = patch_globals+ _make_project(tree, pid="empty1", pname="e1") # zero instincts/observations+ tree["registry_file"].write_text(json.dumps({"empty1": {"name": "e1"}}))++ args = SimpleNamespace(dry_run=True, force=False)+ assert _cmd_projects_gc(args) == 0+ assert "[DRY RUN]" in capsys.readouterr().out+ assert "empty1" in json.loads(tree["registry_file"].read_text())+ # dry-run must not touch storage on disk+ assert (tree["projects_dir"] / "empty1").exists()+++def test_projects_gc_force_removes_only_zero_value(patch_globals, capsys):+ tree = patch_globals+ _make_project(tree, pid="empty1", pname="e1")+ full = _make_project(tree, pid="full1", pname="f1")+ (full["instincts_personal"] / "inst.yaml").write_text(SAMPLE_INSTINCT_YAML)+ tree["registry_file"].write_text(+ json.dumps({"empty1": {"name": "e1"}, "full1": {"name": "f1"}})+ )++ args = SimpleNamespace(dry_run=False, force=True)+ assert _cmd_projects_gc(args) == 0+ reg = json.loads(tree["registry_file"].read_text())+ assert "empty1" not in reg+ assert "full1" in reg+ assert not (tree["projects_dir"] / "empty1").exists()+ assert (tree["projects_dir"] / "full1").exists()+++# ── projects merge ───────────────────────────++def test_projects_merge_rejects_same_id(patch_globals, capsys):+ args = SimpleNamespace(from_id="dup", into_id="dup", dry_run=False, force=True)+ assert _cmd_projects_merge(args) == 1+ assert "into itself" in capsys.readouterr().err+++def test_projects_merge_missing_source(patch_globals, capsys):+ tree = patch_globals+ tree["registry_file"].write_text(json.dumps({"dest": {"name": "d"}}))+ args = SimpleNamespace(from_id="src", into_id="dest", dry_run=False, force=True)+ assert _cmd_projects_merge(args) == 1+ assert "Source project" in capsys.readouterr().err+++def test_projects_merge_missing_destination(patch_globals, capsys):+ tree = patch_globals+ # Source present, destination absent — exercises the symmetric error branch.+ tree["registry_file"].write_text(json.dumps({"src": {"name": "s"}}))+ args = SimpleNamespace(from_id="src", into_id="dest", dry_run=False, force=True)+ assert _cmd_projects_merge(args) == 1+ assert "Destination project" in capsys.readouterr().err+++def test_projects_merge_dry_run_no_changes(patch_globals, capsys):+ tree = patch_globals+ src = _make_project(tree, pid="src", pname="s")+ _make_project(tree, pid="dest", pname="d")+ (src["instincts_personal"] / "i.yaml").write_text(SAMPLE_INSTINCT_YAML)+ tree["registry_file"].write_text(json.dumps({"src": {"name": "s"}, "dest": {"name": "d"}}))++ args = SimpleNamespace(from_id="src", into_id="dest", dry_run=True, force=False)+ assert _cmd_projects_merge(args) == 0+ assert "[DRY RUN]" in capsys.readouterr().out+ reg = json.loads(tree["registry_file"].read_text())+ assert "src" in reg and "dest" in reg+ assert (tree["projects_dir"] / "src").exists()+ # dry-run must not copy any instinct into the destination storage+ assert not list((tree["projects_dir"] / "dest" / "instincts" / "personal").glob("*.yaml"))+++def test_projects_merge_force_moves_and_removes_source(patch_globals, capsys):+ tree = patch_globals+ src = _make_project(tree, pid="src", pname="s")+ _make_project(tree, pid="dest", pname="d")+ (src["instincts_personal"] / "i.yaml").write_text(SAMPLE_INSTINCT_YAML)+ tree["registry_file"].write_text(json.dumps({"src": {"name": "s"}, "dest": {"name": "d"}}))++ args = SimpleNamespace(from_id="src", into_id="dest", dry_run=False, force=True)+ assert _cmd_projects_merge(args) == 0+ reg = json.loads(tree["registry_file"].read_text())+ assert "src" not in reg+ assert "dest" in reg+ assert not (tree["projects_dir"] / "src").exists()+ moved = list((tree["projects_dir"] / "dest" / "instincts" / "personal").glob("*.yaml"))+ assert len(moved) >= 1+++# ── cmd_prune ────────────────────────────────++def _pending_item(path, age_days):+ return {+ "path": path,+ "created": None,+ "age_days": age_days,+ "name": path.stem,+ "parent_dir": str(path.parent),+ }+++def test_cmd_prune_dry_run_keeps_files(monkeypatch, tmp_path, capsys):+ f_old = tmp_path / "old.yaml"+ f_old.write_text("x", encoding="utf-8")+ f_new = tmp_path / "new.yaml"+ f_new.write_text("y", encoding="utf-8")+ items = [_pending_item(f_old, 40), _pending_item(f_new, 5)]+ monkeypatch.setattr(_mod, "_collect_pending_instincts", lambda: items)++ args = SimpleNamespace(max_age=30, dry_run=True, quiet=False)+ assert cmd_prune(args) == 0+ assert "[DRY RUN]" in capsys.readouterr().out+ assert f_old.exists()+ assert f_new.exists()+++def test_cmd_prune_deletes_only_expired(monkeypatch, tmp_path, capsys):+ f_old = tmp_path / "old.yaml"+ f_old.write_text("x", encoding="utf-8")+ f_new = tmp_path / "new.yaml"+ f_new.write_text("y", encoding="utf-8")+ items = [_pending_item(f_old, 40), _pending_item(f_new, 5)]+ monkeypatch.setattr(_mod, "_collect_pending_instincts", lambda: items)++ args = SimpleNamespace(max_age=30, dry_run=False, quiet=False)+ assert cmd_prune(args) == 0+ assert not f_old.exists()+ assert f_new.exists()+ assert "Pruned 1" in capsys.readouterr().out+++def test_cmd_prune_quiet_suppresses_output(monkeypatch, tmp_path, capsys):+ f_old = tmp_path / "old.yaml"+ f_old.write_text("x", encoding="utf-8")+ items = [_pending_item(f_old, 99)]+ monkeypatch.setattr(_mod, "_collect_pending_instincts", lambda: items)++ args = SimpleNamespace(max_age=30, dry_run=False, quiet=True)+ assert cmd_prune(args) == 0+ assert not f_old.exists()+ captured = capsys.readouterr()+ assert captured.out == ""+ assert captured.err == ""+++def test_cmd_prune_empty_pending_nothing_to_do(monkeypatch, capsys):+ # Nothing pending at all: the non-dry-run, non-quiet branch must report+ # "nothing to do" (not "[DRY RUN]"), return 0, and not crash.+ monkeypatch.setattr(_mod, "_collect_pending_instincts", lambda: [])++ args = SimpleNamespace(max_age=30, dry_run=False, quiet=False)+ assert cmd_prune(args) == 0+ out = capsys.readouterr().out+ assert "No pending instincts older than 30 days." in out+ assert "[DRY RUN]" not in out