Skip to content

armgit / ECC

Public Imported from GitHub
0

The agent harness performance optimization system. Skills, instincts, memory, security, and research-first development for Claude Code, Codex, Opencode, Cursor and beyond.

fix(state-store): tolerate missing Windows lock device IDs

Yann Robertoa6ce6fbbdbc0
diff --git a/scripts/lib/state-store/file-lock.js b/scripts/lib/state-store/file-lock.js
index 6629126a6..735b9bf23 100644
--- a/scripts/lib/state-store/file-lock.js
+++ b/scripts/lib/state-store/file-lock.js
@@ -28,7 +28,11 @@ function hasCode(error, code) {
}
function sameIdentity(left, right) {
- return left.ino === right.ino && left.dev === right.dev;
+ if (left.ino !== right.ino) return false;
+ // Windows path stats can omit the volume serial (dev = 0) even when fstat
+ // reports it. Keep device checks strict elsewhere and when both are known.
+ if (process.platform === 'win32' && (left.dev === 0n || right.dev === 0n)) return true;
+ return left.dev === right.dev;
}
function lostLock(lockPath) {
diff --git a/tests/lib/state-store-persistence.test.js b/tests/lib/state-store-persistence.test.js
index ab1bea6a0..be9f88a7a 100644
--- a/tests/lib/state-store-persistence.test.js
+++ b/tests/lib/state-store-persistence.test.js
@@ -117,9 +117,12 @@ async function runSynthetic(test) {
assert.ok(replacement);
assert.strictEqual(fixture.calls.filter(call => call === 'close').length, 1);
});
- for (const platform of ['linux', 'win32']) {
- for (const replacement of [{ ino: 3n }, { dev: 9n }, { dev: 0n }, { isFile: () => false }, { isSymbolicLink: () => true }]) {
- await test(`observed lock replacement is preserved (${platform}, ${Object.keys(replacement)[0]})`, () => {
+ for (const platform of ['linux', 'darwin', 'win32']) {
+ for (const replacement of [
+ { ino: 3n }, { dev: 9n }, { isFile: () => false }, { isSymbolicLink: () => true },
+ ...(platform === 'win32' ? [{ dev: 0n, isFile: () => false }, { dev: 0n, isSymbolicLink: () => true }] : []),
+ ]) {
+ await test(`observed lock replacement is preserved (${platform}, ${Object.keys(replacement).join('+')})`, () => {
const fixture = lockFixture({ lstatSync(state) { state.calls.push('lstat'); return { ...state.identity, ...replacement }; } }, platform);
const result = thrownBy(() => fixture.run(() => {}));
assert.ok(result.failed);
@@ -129,6 +132,45 @@ async function runSynthetic(test) {
});
}
}
+ const highInode = 9007199254740992n;
+ const identityCases = [
+ { name: 'matching high inode and devices', platform: 'win32', ownedDev: 9n, pathDev: 9n, allowed: true },
+ { name: 'missing path device', platform: 'win32', ownedDev: 9n, pathDev: 0n, allowed: true },
+ { name: 'missing descriptor device', platform: 'win32', ownedDev: 0n, pathDev: 9n, allowed: true },
+ { name: 'both devices unavailable', platform: 'win32', ownedDev: 0n, pathDev: 0n, allowed: true },
+ ...['linux', 'darwin'].flatMap(platform => [
+ { name: 'missing path device', platform, ownedDev: 9n, pathDev: 0n, allowed: false },
+ { name: 'missing descriptor device', platform, ownedDev: 0n, pathDev: 9n, allowed: false },
+ ]),
+ ...[[9n, 9n], [9n, 0n], [0n, 9n], [0n, 0n]].map(([ownedDev, pathDev]) => ({
+ name: `distinct high inodes with devices ${ownedDev}/${pathDev}`,
+ platform: 'win32', ownedDev, pathDev, pathInode: highInode + 1n, allowed: false,
+ })),
+ ];
+ for (const identityCase of identityCases) {
+ await test(`lock identity handles ${identityCase.name} (${identityCase.platform})`, () => {
+ const fixture = lockFixture({
+ fstatSync(state, stat, descriptor, options) {
+ assert.strictEqual(options.bigint, true);
+ return { ...stat(), dev: identityCase.ownedDev, ino: highInode };
+ },
+ lstatSync(state, stat, lockPath, options) {
+ assert.strictEqual(options.bigint, true);
+ return { ...stat(), dev: identityCase.pathDev, ino: identityCase.pathInode ?? highInode };
+ },
+ }, identityCase.platform);
+ const result = thrownBy(() => fixture.run(() => 'done'));
+ if (identityCase.allowed) {
+ assert.strictEqual(result.failed, false, result.error && result.error.message);
+ assert.strictEqual(result.value, 'done');
+ assert.deepStrictEqual(fixture.calls, ['open', 'fstat', 'write', 'lstat', 'unlink', 'close']);
+ } else {
+ assert.strictEqual(result.failed, true);
+ assert.strictEqual(result.error.code, 'STATE_STORE_LOCK_LOST');
+ assert.deepStrictEqual(fixture.calls, ['open', 'fstat', 'write', 'lstat', 'close']);
+ }
+ });
+ }
for (const afterClose of ['missing', 'permission', 'replacement']) {
await test(`initial EPERM performs only a post-close read probe (${afterClose})`, () => {
const denied = Object.assign(new Error('denied'), { code: 'EPERM' });