Skip to content

armgit / ECC

Public Imported from GitHub
0

The agent harness performance optimization system. Skills, instincts, memory, security, and research-first development for Claude Code, Codex, Opencode, Cursor and beyond.

fix: preserve classifier parse failures through compliance grading

haelyraae4bc283ae16
diff --cc manifests/context-packs/[email protected]
index 630609901,4ab1c8a55..1d92259c4
--- a/manifests/context-packs/[email protected]
+++ b/manifests/context-packs/[email protected]
@@@ -10,7 -10,7 +10,7 @@@
"id": "hand-seeded",
"source": "manual-curation-pending-regeneration"
},
- "registryDigest": "5aa40d350c7cfdd74c4c432383b24bbdcba34dde0bf98ba04fe969a0b6a5fdd7",
- "registryDigest": "c6f543a29a359ce7738bf215886b53a5081da2cfc5b6f98d4f9416c58d0dfb36",
++ "registryDigest": "b21e33d7de6c1f8c1934a7b11d9cb9c5135abb5fd51c7db155eb393cff5fa959",
"schemaVersion": 1,
"triggers": {
"skill:agent-runtime-gateway-smoke-test": [
diff --cc skills/skill-comply/tests/test_classifier.py
index 000000000,bcc44c905..95d82ef8b
mode 000000,100644..100644
--- a/skills/skill-comply/tests/test_classifier.py
+++ b/skills/skill-comply/tests/test_classifier.py
@@@ -1,0 -1,32 +1,55 @@@
+ """Tests for scripts.classifier._parse_classification."""
+
-import pytest
++import subprocess
++from unittest.mock import patch
+
++import pytest
+ from scripts import classifier
+ from scripts.classifier import _parse_classification
++from scripts.grader import grade
++from scripts.parser import ComplianceSpec, Detector, ObservationEvent, Step
+
+
+ class TestParseClassification:
+ def test_plain_json(self):
+ assert _parse_classification('{"a": [0, 2]}') == {"a": [0, 2]}
+
+ def test_fenced_json(self):
+ assert _parse_classification('```json\n{"a": [1]}\n```') == {"a": [1]}
+
+ def test_dict_without_list_values_is_empty(self):
+ assert _parse_classification('{"a": "x"}') == {}
+
++ def test_empty_object_is_valid(self):
++ assert _parse_classification("{}") == {}
++
+ def test_garbage_raises(self):
- with pytest.raises(RuntimeError):
++ with pytest.raises(classifier.ClassifierParseError, match="failed to parse"):
+ _parse_classification("sorry, I cannot classify these")
+
+ def test_non_dict_json_raises(self):
- with pytest.raises(RuntimeError):
++ with pytest.raises(classifier.ClassifierParseError, match="non-dict"):
+ _parse_classification("[1, 2, 3]")
+
+ def test_non_integer_indices_raise(self):
- with pytest.raises(RuntimeError):
++ with pytest.raises(classifier.ClassifierParseError, match="failed to parse"):
+ _parse_classification('{"a": ["x"]}')
+
+ def test_is_runtime_error(self):
+ assert issubclass(classifier.ClassifierParseError, RuntimeError)
++
++
[email protected]("response", ["not JSON", "[]", '{"a": ["x"]}'])
++def test_grader_propagates_classifier_parse_failure(response):
++ """An invalid successful subprocess response cannot become a zero score."""
++ spec = ComplianceSpec(
++ id="fixture", name="Fixture", source_rule="fixture", version="1",
++ steps=(Step("a", "Read a file", True, Detector("Read a file")),),
++ threshold_promote_to_hook=0.6,
++ )
++ trace = [ObservationEvent("T0000", "tool_complete", "Read", "fixture", "", "")]
++ result = subprocess.CompletedProcess(["claude"], 0, stdout=response, stderr="")
++ with patch("scripts.classifier.subprocess.run", return_value=result) as execute:
++ with pytest.raises(classifier.ClassifierParseError):
++ grade(spec, trace)
++ execute.assert_called_once()