The agent harness performance optimization system. Skills, instincts, memory, security, and research-first development for Claude Code, Codex, Opencode, Cursor and beyond.
feat: salvage mysql patterns skill (#1733)
Affaan Mustafab17f8ef6a461
diff --git a/.claude-plugin/marketplace.json b/.claude-plugin/marketplace.jsonindex 35a38c590..fd15d6971 100644--- a/.claude-plugin/marketplace.json+++ b/.claude-plugin/marketplace.json@@ -11,7 +11,7 @@{"name": "ecc","source": "./",- "description": "The most comprehensive Claude Code plugin — 53 agents, 199 skills, 69 legacy command shims, selective install profiles, and production-ready hooks for TDD, security scanning, code review, and continuous learning",+ "description": "The most comprehensive Claude Code plugin — 53 agents, 200 skills, 69 legacy command shims, selective install profiles, and production-ready hooks for TDD, security scanning, code review, and continuous learning","version": "2.0.0-rc.1","author": {"name": "Affaan Mustafa",diff --git a/.claude-plugin/plugin.json b/.claude-plugin/plugin.jsonindex 3e1394f27..c7776a276 100644--- a/.claude-plugin/plugin.json+++ b/.claude-plugin/plugin.json@@ -1,7 +1,7 @@{"name": "ecc","version": "2.0.0-rc.1",- "description": "Battle-tested Claude Code plugin for engineering teams — 53 agents, 199 skills, 69 legacy command shims, production-ready hooks, and selective install workflows evolved through continuous real-world use",+ "description": "Battle-tested Claude Code plugin for engineering teams — 53 agents, 200 skills, 69 legacy command shims, production-ready hooks, and selective install workflows evolved through continuous real-world use","author": {"name": "Affaan Mustafa","url": "https://x.com/affaanmustafa"diff --git a/AGENTS.md b/AGENTS.mdindex 8af8d6351..efd163aba 100644--- a/AGENTS.md+++ b/AGENTS.md@@ -1,6 +1,6 @@# Everything Claude Code (ECC) — Agent Instructions-This is a **production-ready AI coding plugin** providing 53 specialized agents, 199 skills, 69 commands, and automated hook workflows for software development.+This is a **production-ready AI coding plugin** providing 53 specialized agents, 200 skills, 69 commands, and automated hook workflows for software development.**Version:** 2.0.0-rc.1@@ -146,7 +146,7 @@ Troubleshoot failures: check test isolation → verify mocks → fix implementat```agents/ — 53 specialized subagents-skills/ — 199 workflow skills and domain knowledge+skills/ — 200 workflow skills and domain knowledgecommands/ — 69 slash commandshooks/ — Trigger-based automationsrules/ — Always-follow guidelines (common + per-language)diff --git a/README.md b/README.mdindex 9df9d585c..6fc012e24 100644--- a/README.md+++ b/README.md@@ -350,7 +350,7 @@ If you stacked methods, clean up in this order:/plugin list ecc@ecc```-**That's it!** You now have access to 53 agents, 199 skills, and 69 legacy command shims.+**That's it!** You now have access to 53 agents, 200 skills, and 69 legacy command shims.### Dashboard GUI@@ -1338,7 +1338,7 @@ The configuration is automatically detected from `.opencode/opencode.json`.|---------|-------------|----------|--------|| Agents | PASS: 53 agents | PASS: 12 agents | **Claude Code leads** || Commands | PASS: 69 commands | PASS: 31 commands | **Claude Code leads** |-| Skills | PASS: 199 skills | PASS: 37 skills | **Claude Code leads** |+| Skills | PASS: 200 skills | PASS: 37 skills | **Claude Code leads** || Hooks | PASS: 8 event types | PASS: 11 events | **OpenCode has more!** || Rules | PASS: 29 rules | PASS: 13 instructions | **Claude Code leads** || MCP Servers | PASS: 14 servers | PASS: Full | **Full parity** |@@ -1443,7 +1443,7 @@ ECC is the **first plugin to maximize every major AI coding tool**. Here's how e|---------|------------|------------|-----------|----------|| **Agents** | 53 | Shared (AGENTS.md) | Shared (AGENTS.md) | 12 || **Commands** | 69 | Shared | Instruction-based | 31 |-| **Skills** | 199 | Shared | 10 (native format) | 37 |+| **Skills** | 200 | Shared | 10 (native format) | 37 || **Hook Events** | 8 types | 15 types | None yet | 11 types || **Hook Scripts** | 20+ scripts | 16 scripts (DRY adapter) | N/A | Plugin hooks || **Rules** | 34 (common + lang) | 34 (YAML frontmatter) | Instruction-based | 13 instructions |diff --git a/README.zh-CN.md b/README.zh-CN.mdindex 314234734..26ec9495c 100644--- a/README.zh-CN.md+++ b/README.zh-CN.md@@ -160,7 +160,7 @@ Copy-Item -Recurse rules/typescript "$HOME/.claude/rules/"/plugin list ecc@ecc```-**完成!** 你现在可以使用 53 个代理、199 个技能和 69 个命令。+**完成!** 你现在可以使用 53 个代理、200 个技能和 69 个命令。### multi-* 命令需要额外配置diff --git a/docs/zh-CN/AGENTS.md b/docs/zh-CN/AGENTS.mdindex 65ad1749e..54643bce7 100644--- a/docs/zh-CN/AGENTS.md+++ b/docs/zh-CN/AGENTS.md@@ -1,6 +1,6 @@# Everything Claude Code (ECC) — 智能体指令-这是一个**生产就绪的 AI 编码插件**,提供 53 个专业代理、199 项技能、69 条命令以及自动化钩子工作流,用于软件开发。+这是一个**生产就绪的 AI 编码插件**,提供 53 个专业代理、200 项技能、69 条命令以及自动化钩子工作流,用于软件开发。**版本:** 2.0.0-rc.1diff --git a/docs/zh-CN/README.md b/docs/zh-CN/README.mdindex 065754929..e6099ea24 100644--- a/docs/zh-CN/README.md+++ b/docs/zh-CN/README.md@@ -224,7 +224,7 @@ Copy-Item -Recurse rules/typescript "$HOME/.claude/rules/"/plugin list ecc@ecc```-**搞定!** 你现在可以使用 53 个智能体、199 项技能和 69 个命令了。+**搞定!** 你现在可以使用 53 个智能体、200 项技能和 69 个命令了。***@@ -1134,7 +1134,7 @@ opencode|---------|-------------|----------|--------|| 智能体 | PASS: 53 个 | PASS: 12 个 | **Claude Code 领先** || 命令 | PASS: 69 个 | PASS: 31 个 | **Claude Code 领先** |-| 技能 | PASS: 199 项 | PASS: 37 项 | **Claude Code 领先** |+| 技能 | PASS: 200 项 | PASS: 37 项 | **Claude Code 领先** || 钩子 | PASS: 8 种事件类型 | PASS: 11 种事件 | **OpenCode 更多!** || 规则 | PASS: 29 条 | PASS: 13 条指令 | **Claude Code 领先** || MCP 服务器 | PASS: 14 个 | PASS: 完整 | **完全对等** |@@ -1242,7 +1242,7 @@ ECC 是**第一个最大化利用每个主要 AI 编码工具的插件**。以|---------|------------|------------|-----------|----------|| **智能体** | 53 | 共享 (AGENTS.md) | 共享 (AGENTS.md) | 12 || **命令** | 69 | 共享 | 基于指令 | 31 |-| **技能** | 199 | 共享 | 10 (原生格式) | 37 |+| **技能** | 200 | 共享 | 10 (原生格式) | 37 || **钩子事件** | 8 种类型 | 15 种类型 | 暂无 | 11 种类型 || **钩子脚本** | 20+ 个脚本 | 16 个脚本 (DRY 适配器) | N/A | 插件钩子 || **规则** | 34 (通用 + 语言) | 34 (YAML 前页) | 基于指令 | 13 条指令 |diff --git a/manifests/install-modules.json b/manifests/install-modules.jsonindex 254af8d14..d0ae8ef39 100644--- a/manifests/install-modules.json+++ b/manifests/install-modules.json@@ -179,6 +179,7 @@"skills/clickhouse-io","skills/database-migrations","skills/jpa-patterns",+ "skills/mysql-patterns","skills/postgres-patterns"],"targets": [diff --git a/package.json b/package.jsonindex 426c53696..139ecf2c7 100644--- a/package.json+++ b/package.json@@ -186,6 +186,7 @@"skills/market-research/","skills/mcp-server-patterns/","skills/messages-ops/",+ "skills/mysql-patterns/","skills/nanoclaw-repl/","skills/nestjs-patterns/","skills/netmiko-ssh-automation/",diff --git a/skills/mysql-patterns/SKILL.md b/skills/mysql-patterns/SKILL.mdnew file mode 100644index 000000000..67c6d9a60--- /dev/null+++ b/skills/mysql-patterns/SKILL.md@@ -0,0 +1,412 @@+---+name: mysql-patterns+description: MySQL and MariaDB schema, query, indexing, transaction, replication, and connection-pool patterns for production backends.+origin: ECC+---++# MySQL Patterns++Use this skill when working on MySQL or MariaDB schema design, migrations,+slow-query investigation, queue-style transactions, connection pools, or+production database configuration. Prefer exact version checks before applying a+feature-specific pattern because MySQL and MariaDB have diverged in several SQL+details.++## Activation++- Designing MySQL or MariaDB tables, indexes, and constraints+- Reviewing migrations before they run on large production tables+- Debugging slow queries, lock waits, deadlocks, or connection exhaustion+- Adding keyset pagination, upserts, full-text search, JSON columns, or queues+- Configuring application connection pools, read replicas, TLS, or slow logs++## Version Check++Start by identifying the engine and version:++```sql+SELECT VERSION();+SHOW VARIABLES LIKE 'version_comment';+```++Keep MySQL and MariaDB guidance separate when syntax differs:++- MySQL documents row aliases as the replacement for `VALUES(col)` in+ `ON DUPLICATE KEY UPDATE`; `VALUES(col)` is deprecated there.+- MariaDB documents `VALUES(col)` as the supported way to reference inserted+ values in `ON DUPLICATE KEY UPDATE`; use it for cross-engine compatibility.+- `SKIP LOCKED` is appropriate for queue-like work only. It skips locked rows+ and can return an inconsistent view, so do not use it for general accounting+ or integrity-sensitive reads.++## Schema Defaults++```sql+CREATE TABLE orders (+ id BIGINT UNSIGNED NOT NULL AUTO_INCREMENT,+ account_id BIGINT UNSIGNED NOT NULL,+ status VARCHAR(32) NOT NULL,+ total DECIMAL(15, 2) NOT NULL,+ created_at DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP,+ updated_at DATETIME NOT NULL DEFAULT CURRENT_TIMESTAMP ON UPDATE CURRENT_TIMESTAMP,+ deleted_at DATETIME NULL,+ PRIMARY KEY (id),+ KEY idx_orders_account_status_created (account_id, status, created_at),+ KEY idx_orders_active (account_id, deleted_at)+) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4 COLLATE=utf8mb4_unicode_ci;+```++Default choices:++| Use Case | Prefer | Avoid |+| --- | --- | --- |+| Surrogate primary keys | `BIGINT UNSIGNED AUTO_INCREMENT` | `INT` for tables that can grow beyond 2B rows |+| UUID lookup keys | `BINARY(16)` with conversion helpers | `VARCHAR(36)` primary keys on hot tables |+| Money and exact quantities | `DECIMAL(p, s)` | `FLOAT` or `DOUBLE` |+| User-facing text | `utf8mb4` tables and indexes | MySQL `utf8` / `utf8mb3` defaults |+| Application timestamps | `DATETIME` with UTC managed by the app | Assuming `DATETIME` stores time zone metadata |+| Soft deletes | `deleted_at DATETIME NULL` plus scoped indexes | Filtering soft-deleted rows without an index |+| Extensible status values | lookup table or constrained `VARCHAR` | `ENUM` when values change often |++## Indexing++Composite index order usually follows equality predicates first, then range or+sort columns:++```sql+CREATE INDEX idx_orders_account_status_created+ ON orders (account_id, status, created_at);++SELECT id, total+FROM orders+WHERE account_id = ?+ AND status = 'pending'+ AND created_at >= ?+ORDER BY created_at DESC+LIMIT 50;+```++Use `EXPLAIN` before adding or changing an index:++```sql+EXPLAIN+SELECT id, total+FROM orders+WHERE account_id = 123 AND status = 'pending'+ORDER BY created_at DESC+LIMIT 50;+```++Signals to investigate:++| Field | Risk Signal |+| --- | --- |+| `type` | `ALL` on a large table |+| `key` | `NULL` when a selective predicate exists |+| `rows` | Very high row estimate for an interactive path |+| `Extra` | `Using temporary`, `Using filesort`, or broad `Using where` |++Avoid adding indexes blindly. Each index increases write cost, migration time,+backup size, and buffer-pool pressure.++## Query Patterns++### Upsert++Cross-engine-compatible form:++```sql+INSERT INTO user_settings (user_id, setting_key, setting_value)+VALUES (?, ?, ?)+ON DUPLICATE KEY UPDATE+ setting_value = VALUES(setting_value),+ updated_at = CURRENT_TIMESTAMP;+```++MySQL row-alias form:++```sql+INSERT INTO user_settings (user_id, setting_key, setting_value)+VALUES (?, ?, ?) AS new+ON DUPLICATE KEY UPDATE+ setting_value = new.setting_value,+ updated_at = CURRENT_TIMESTAMP;+```++Use the row-alias form only after confirming the target is MySQL. Use+`VALUES(col)` for MariaDB or mixed MySQL/MariaDB fleets.++### Keyset Pagination++```sql+SELECT id, name, created_at+FROM products+WHERE (created_at, id) < (?, ?)+ORDER BY created_at DESC, id DESC+LIMIT 50;+```++Back it with an index that matches the cursor:++```sql+CREATE INDEX idx_products_created_id ON products (created_at, id);+```++Do not use deep `OFFSET` pagination on large tables; it makes the server scan+and discard rows before returning the page.++### JSON Fields++Use JSON columns for extension data, not for fields that need heavy relational+filtering or constraints.++```sql+CREATE TABLE events (+ id BIGINT UNSIGNED AUTO_INCREMENT PRIMARY KEY,+ payload JSON NOT NULL,+ event_type VARCHAR(64)+ GENERATED ALWAYS AS (JSON_UNQUOTE(JSON_EXTRACT(payload, '$.type'))) STORED,+ KEY idx_events_type (event_type)+) ENGINE=InnoDB DEFAULT CHARSET=utf8mb4;+```++For frequently queried JSON paths, expose a generated column and index that+column. Keep foreign keys, ownership, tenancy, and lifecycle fields relational.++### Full-Text Search++```sql+ALTER TABLE articles ADD FULLTEXT KEY ft_articles_title_body (title, body);++SELECT id, title, MATCH(title, body) AGAINST (? IN NATURAL LANGUAGE MODE) AS score+FROM articles+WHERE MATCH(title, body) AGAINST (? IN NATURAL LANGUAGE MODE)+ORDER BY score DESC+LIMIT 20;+```++Use external search when you need typo tolerance, complex ranking, cross-table+facets, or language-specific analysis beyond built-in full-text behavior.++## Transactions++Keep transactions short and lock rows in a consistent order:++```sql+START TRANSACTION;++SELECT id, balance+FROM accounts+WHERE id IN (?, ?)+ORDER BY id+FOR UPDATE;++UPDATE accounts SET balance = balance - ? WHERE id = ?;+UPDATE accounts SET balance = balance + ? WHERE id = ?;++COMMIT;+```++Deadlock and lock-wait checklist:++- Lock rows in a deterministic order across code paths.+- Do external API calls before opening the transaction, not inside it.+- Add indexes for predicates used in `UPDATE`, `DELETE`, and locking reads.+- On deadlock, roll back and retry the whole transaction with a bounded retry+ budget.+- Capture `SHOW ENGINE INNODB STATUS\G` soon after a deadlock; it is overwritten+ by later events.++Queue-style worker claim:++```sql+START TRANSACTION;++SELECT id+FROM jobs+WHERE status = 'pending'+ORDER BY created_at+LIMIT 1+FOR UPDATE SKIP LOCKED;++UPDATE jobs+SET status = 'processing', started_at = CURRENT_TIMESTAMP+WHERE id = ?;++COMMIT;+```++Use `SKIP LOCKED` only for queue-like workloads where skipping a locked row is+acceptable. It is not a replacement for normal transactional consistency.++## Connection Pools++SQLAlchemy example:++```python+from sqlalchemy import create_engine++engine = create_engine(+ "mysql+mysqlconnector://app:[email protected]/app",+ pool_size=10,+ max_overflow=5,+ pool_timeout=30,+ pool_recycle=240,+ pool_pre_ping=True,+ connect_args={"connect_timeout": 5},+)+```++Node.js `mysql2` example:++```javascript+import mysql from 'mysql2/promise';++const pool = mysql.createPool({+ host: process.env.DB_HOST,+ user: process.env.DB_USER,+ password: process.env.DB_PASSWORD,+ database: process.env.DB_NAME,+ waitForConnections: true,+ connectionLimit: 10,+ queueLimit: 0,+ enableKeepAlive: true,+ keepAliveInitialDelay: 30000,+});++const [rows] = await pool.execute(+ 'SELECT id, total FROM orders WHERE account_id = ? LIMIT 50',+ [accountId],+);+```++Keep application pool recycling below the server `wait_timeout`. If the server+uses `wait_timeout = 300`, a `pool_recycle` around 240 seconds is coherent;+`pool_pre_ping` still helps recover from network and failover events.++## Diagnostics++Useful first-pass commands:++```sql+SHOW FULL PROCESSLIST;+SHOW ENGINE INNODB STATUS\G;+SHOW VARIABLES LIKE 'slow_query_log';+SHOW VARIABLES LIKE 'long_query_time';+```++Enable the slow log in a controlled environment:++```sql+SET GLOBAL slow_query_log = 'ON';+SET GLOBAL long_query_time = 1;+SET GLOBAL log_queries_not_using_indexes = 'ON';+```++Use `EXPLAIN ANALYZE` only when it is safe to execute the query. It runs the+statement and can be expensive on production-sized data.++## Replication++Read replicas can lag. Do not route read-your-own-write paths, checkout flows,+permission checks, or idempotency-key reads to a replica immediately after a+write.++```sql+-- MySQL legacy terminology, still common in existing fleets+SHOW SLAVE STATUS\G;++-- Newer terminology where supported+SHOW REPLICA STATUS\G;+```++Check the engine/version before standardizing on one command. Monitor replica+SQL thread health, IO thread health, and lag, not just whether the TCP+connection is alive.++## Security++```sql+CREATE USER 'app'@'%' IDENTIFIED BY 'use-a-secret-manager';+GRANT SELECT, INSERT, UPDATE, DELETE ON appdb.* TO 'app'@'%';++ALTER USER 'app'@'%' REQUIRE SSL;++SELECT user, host+FROM mysql.user+WHERE user = '';++DROP USER IF EXISTS ''@'localhost';+DROP USER IF EXISTS ''@'%';+```++Security review points:++- Do not grant `ALL PRIVILEGES` or `*.*` to application users.+- Require TLS for application users when traffic crosses hosts or networks.+- Store credentials in the platform secret manager, not in examples, scripts, or+ repository files.+- Separate migration/admin users from runtime application users.+- Audit public network exposure and bind addresses before tuning performance.++## Configuration++Example starting point for a dedicated database host:++```ini+[mysqld]+innodb_buffer_pool_size = 4G+innodb_flush_log_at_trx_commit = 1+sync_binlog = 1++max_connections = 300+thread_cache_size = 50++wait_timeout = 300+interactive_timeout = 300+innodb_lock_wait_timeout = 10++slow_query_log = ON+long_query_time = 1+log_queries_not_using_indexes = ON++log_bin = mysql-bin+binlog_format = ROW+binlog_expire_logs_seconds = 604800+```++Treat configuration values as a prompt for review, not a universal preset. Size+memory, connections, log retention, and durability settings from workload,+hardware, backup policy, and recovery objectives.++## Anti-Patterns++| Anti-Pattern | Risk | Better Pattern |+| --- | --- | --- |+| `SELECT *` in hot paths | Over-fetching and brittle clients | Select explicit columns |+| Deep `OFFSET` pagination | Linear scans and slow pages | Keyset pagination |+| No index on foreign-key joins | Slow joins and lock-heavy deletes | Index FK columns intentionally |+| Long transactions | Lock waits and large undo history | Commit small units of work |+| Direct DML against `mysql.user` | Grant-table corruption risk | Use `CREATE USER`, `ALTER USER`, `DROP USER` |+| Application user with admin grants | High blast radius | Least-privilege runtime user |+| Pool recycle above `wait_timeout` | Stale pooled connections | Recycle below timeout and pre-ping |+| Replica reads after writes | Stale user-facing state | Pin read-after-write flows to primary |++## Output Expectations++When this skill is used for review, return:++1. Engine/version assumptions.+2. Highest-risk correctness, lock, security, and migration issues.+3. Exact SQL or code changes for the safe path.+4. Validation plan: `EXPLAIN`, migration dry run, lock/deadlock check, and+ rollback criteria.+5. Any MySQL/MariaDB syntax differences that affect the recommendation.++## Related++- Skill: `postgres-patterns` - PostgreSQL-specific schema and query patterns+- Skill: `database-migrations` - migration planning and rollout safety+- Skill: `backend-patterns` - API and service-layer patterns+- Skill: `security-review` - secret handling, auth, and least privilege+- Agent: `database-reviewer` - broader database review workflow