The agent harness performance optimization system. Skills, instincts, memory, security, and research-first development for Claude Code, Codex, Opencode, Cursor and beyond.
Merge PR #3470: detect Dart and structurally identify Flutter dependencies
haelyrab40c9d528946
diff --cc scripts/lib/project-detect.jsindex 98308fa0a,a7f625847..2aac4afbc--- a/scripts/lib/project-detect.js+++ b/scripts/lib/project-detect.js@@@ -9,6 -9,6 +9,7 @@@const fs = require('fs');const path = require('path');++const yaml = require('js-yaml');/*** Language detection rules.@@@ -330,6 -338,27 +339,27 @@@ function getElixirDeps(projectDir)}}+ /**+ * Check whether pubspec.yaml declares the Flutter SDK as a dependency,+ * which distinguishes a Flutter app from a plain Dart package.+ * @param {string} projectDir - Project root directory+ * @returns {boolean}+ */+ function hasFlutterSdkDependency(projectDir) {+ try {+ const pubspecPath = path.join(projectDir, 'pubspec.yaml');+ if (!fs.existsSync(pubspecPath)) return false;+ const content = fs.readFileSync(pubspecPath, 'utf8');- // Matches the standard Flutter pubspec shape:- // dependencies:- // flutter:- // sdk: flutter- return /^\s*flutter:\s*$/m.test(content) && /sdk:\s*flutter/.test(content);++ const pubspec = yaml.load(content, { schema: yaml.JSON_SCHEMA });++ // Only a declared Flutter SDK dependency identifies the framework.++ // Unrelated configuration, comments, and strings must not count.++ return pubspec?.dependencies?.flutter?.sdk === 'flutter'++ || pubspec?.dev_dependencies?.flutter?.sdk === 'flutter';+ } catch {+ return false;+ }+ }+/*** Detect project languages and frameworks* @param {string} [projectDir] - Project directory (defaults to cwd)diff --cc tests/lib/project-detect.test.jsindex 30727f360,100e1c6c3..d76abbf47--- a/tests/lib/project-detect.test.js+++ b/tests/lib/project-detect.test.js@@@ -493,6 -493,57 +493,87 @@@ function runTests()}})) passed++; else failed++;+ // Dart/Flutter detection+ console.log('\nDart/Flutter Detection:');++ if (test('detects dart from pubspec.yaml and .dart files', () => {+ const dir = createTempDir();+ try {+ writeTestFile(dir, 'pubspec.yaml', 'name: test_pkg\nversion: 1.0.0\n');+ writeTestFile(dir, 'main.dart', 'void main() {}\n');+ const result = detectProjectType(dir);+ assert.ok(result.languages.includes('dart'));+ } finally {+ cleanupDir(dir);+ }+ })) passed++; else failed++;++ if (test('detects flutter framework when pubspec.yaml depends on the Flutter SDK', () => {+ const dir = createTempDir();+ try {+ writeTestFile(dir, 'pubspec.yaml', [+ 'name: halal_cosmetics_app',+ 'dependencies:',+ ' flutter:',+ ' sdk: flutter',+ ' cupertino_icons: ^1.0.2'+ ].join('\n'));+ const result = detectProjectType(dir);+ assert.ok(result.languages.includes('dart'));+ assert.ok(result.frameworks.includes('flutter'), `flutter not detected: ${JSON.stringify(result.frameworks)}`);+ assert.strictEqual(result.primary, 'flutter');+ } finally {+ cleanupDir(dir);+ }+ })) passed++; else failed++;++ if (test('does not misclassify a plain Dart package as flutter', () => {+ const dir = createTempDir();+ try {+ writeTestFile(dir, 'pubspec.yaml', [+ 'name: plain_dart_pkg',+ 'dependencies:',+ ' http: ^1.0.0'+ ].join('\n'));+ const result = detectProjectType(dir);+ assert.ok(result.languages.includes('dart'));+ assert.ok(!result.frameworks.includes('flutter'), `plain Dart package wrongly detected as flutter: ${JSON.stringify(result.frameworks)}`);+ assert.strictEqual(result.primary, 'dart');+ } finally {+ cleanupDir(dir);+ }+ })) passed++; else failed++;+++ if (test('does not combine unrelated Flutter and SDK configuration', () => {++ const dir = createTempDir();++ try {++ writeTestFile(dir, 'pubspec.yaml', 'name: plain_dart\nflutter:\n assets: []\ndependencies:\n other:\n sdk: flutter\n');++ assert.ok(!detectProjectType(dir).frameworks.includes('flutter'));++ } finally {++ cleanupDir(dir);++ }++ })) passed++; else failed++;++++ if (test('detects inline Flutter SDK dependencies', () => {++ const dir = createTempDir();++ try {++ writeTestFile(dir, 'pubspec.yaml', 'name: flutter_pkg\ndependencies: {flutter: {sdk: flutter}}\n');++ assert.ok(detectProjectType(dir).frameworks.includes('flutter'));++ } finally {++ cleanupDir(dir);++ }++ })) passed++; else failed++;++++ if (test('malformed pubspec does not claim Flutter detection', () => {++ const dir = createTempDir();++ try {++ writeTestFile(dir, 'pubspec.yaml', 'dependencies: [\nflutter:\n sdk: flutter\n');++ assert.ok(!detectProjectType(dir).frameworks.includes('flutter'));++ } finally {++ cleanupDir(dir);++ }++ })) passed++; else failed++;++// Edge casesconsole.log('\nEdge Cases:');