Skip to content

armgit / ECC

Public Imported from GitHub
0

The agent harness performance optimization system. Skills, instincts, memory, security, and research-first development for Claude Code, Codex, Opencode, Cursor and beyond.

fix: prevent IOC scanner false positives on hook filenames and scan .cursor configs (#2245)

daiki75e3f18d23765e
diff --git a/scripts/ci/scan-supply-chain-iocs.js b/scripts/ci/scan-supply-chain-iocs.js
index ad8bd529d..7b4c95698 100755
--- a/scripts/ci/scan-supply-chain-iocs.js
+++ b/scripts/ci/scan-supply-chain-iocs.js
@@ -414,6 +414,7 @@ function normalizeForMatch(value) {
function isInSpecialConfigPath(filePath) {
const normalized = normalizedPath(filePath);
return /\/\.claude\//.test(normalized)
+ || /\/\.cursor\//.test(normalized)
|| /\/\.vscode\//.test(normalized)
|| /\/\.kiro\/settings\//.test(normalized)
|| /\/Library\/LaunchAgents\//.test(normalized)
@@ -661,21 +662,26 @@ function scanFile(filePath, rootDir, findings) {
for (const indicator of CRITICAL_TEXT_INDICATORS) {
const normalizedIndicator = normalizeForMatch(indicator);
- let index = lowerText.indexOf(normalizedIndicator);
- while (index !== -1) {
- if (!indexInRanges(index, defensiveClaudeDenyRanges)) {
+ // Require a non-filename character before the indicator so legitimate
+ // names that merely end with an IOC filename (e.g. the stock Cursor hook
+ // `before-shell-execution.js` vs the payload `execution.js`) do not match.
+ const indicatorPattern = new RegExp(
+ `(?<![a-z0-9_-])${escapeRegExp(normalizedIndicator)}`,
+ 'g',
+ );
+ let match;
+ while ((match = indicatorPattern.exec(lowerText)) !== null) {
+ if (!indexInRanges(match.index, defensiveClaudeDenyRanges)) {
addFinding(
findings,
'critical',
relativePath,
- lineForIndex(text, index),
+ lineForIndex(text, match.index),
indicator,
'Known active supply-chain IOC is present',
);
break;
}
-
- index = lowerText.indexOf(normalizedIndicator, index + normalizedIndicator.length);
}
}
diff --git a/tests/ci/scan-supply-chain-iocs.test.js b/tests/ci/scan-supply-chain-iocs.test.js
index 04b983012..91a714d46 100755
--- a/tests/ci/scan-supply-chain-iocs.test.js
+++ b/tests/ci/scan-supply-chain-iocs.test.js
@@ -310,6 +310,45 @@ function run() {
});
})) passed++; else failed++;
+ if (test('does not flag legitimate hook filenames ending in an IOC filename', () => {
+ withFixture({
+ '.cursor/hooks.json': JSON.stringify({
+ hooks: {
+ beforeShellExecution: [{
+ command: 'node .cursor/hooks/before-shell-execution.js',
+ }],
+ afterShellExecution: [{
+ command: 'node .cursor/hooks/after-shell-execution.js',
+ }],
+ beforeMCPExecution: [{
+ command: 'node .cursor/hooks/before-mcp-execution.js',
+ }],
+ afterFileEdit: [{
+ command: 'node .cursor/hooks/post_execution.js',
+ }],
+ },
+ }, null, 2),
+ }, rootDir => {
+ const result = scanSupplyChainIocs({ rootDir });
+ assert.deepStrictEqual(result.findings, []);
+ });
+ })) passed++; else failed++;
+
+ if (test('still flags the bare execution.js payload after a path separator', () => {
+ withFixture({
+ '.cursor/hooks.json': JSON.stringify({
+ hooks: {
+ sessionStart: [{
+ command: 'node .cursor/hooks/execution.js',
+ }],
+ },
+ }, null, 2),
+ }, rootDir => {
+ const result = scanSupplyChainIocs({ rootDir });
+ assert.ok(result.findings.some(finding => finding.indicator === 'execution.js'));
+ });
+ })) passed++; else failed++;
+
if (test('rejects user-level VS Code task persistence when home scan is enabled', () => {
withFixture({
'home/Library/Application Support/Code/User/tasks.json': JSON.stringify({