The agent harness performance optimization system. Skills, instincts, memory, security, and research-first development for Claude Code, Codex, Opencode, Cursor and beyond.
fix(clv2): align Python _update_registry schema with shell counterpart (#2369)
Gaurav Dubeyf12b106c3ca6
diff --git a/skills/continuous-learning-v2/scripts/instinct-cli.py b/skills/continuous-learning-v2/scripts/instinct-cli.pyindex 13bc467bc..2274a852b 100755--- a/skills/continuous-learning-v2/scripts/instinct-cli.py+++ b/skills/continuous-learning-v2/scripts/instinct-cli.py@@ -430,12 +430,32 @@ def _update_registry(pid: str, pname: str, proot: str, premote: str) -> None:registry = json.load(f)except (FileNotFoundError, json.JSONDecodeError):registry = {}+ # A registry that is valid JSON but not a mapping (e.g. a list from a+ # corrupt projects.json) must not crash the update before the per-entry+ # guard below: fall back to an empty dict so the whole file is healed.+ if not isinstance(registry, dict):+ registry = {}+ # Mirror the shell counterpart in detect-project.sh: the entry carries+ # "id" and "created_at" alongside the other fields so a projects.json+ # record has the same shape regardless of which path (Python CLI or+ # shell hook) last wrote it. "created_at" is preserved from any+ # existing entry; only "last_seen" advances on update.+ now = datetime.now(timezone.utc).isoformat().replace("+00:00", "Z")+ existing = registry.get(pid, {})+ # A malformed registry (e.g. a non-dict value for this id) must not+ # crash the update: fall back to an empty dict so the corrupt entry is+ # healed by the rewrite, matching the old unconditional-overwrite+ # behavior.+ if not isinstance(existing, dict):+ existing = {}registry[pid] = {+ "id": pid,"name": pname,"root": proot,"remote": premote,- "last_seen": datetime.now(timezone.utc).isoformat().replace("+00:00", "Z"),+ "created_at": existing.get("created_at", now),+ "last_seen": now,}tmp_file = REGISTRY_FILE.parent / f".{REGISTRY_FILE.name}.tmp.{os.getpid()}"diff --git a/skills/continuous-learning-v2/scripts/test_parse_instinct.py b/skills/continuous-learning-v2/scripts/test_parse_instinct.pyindex 225dcb053..a79799863 100644--- a/skills/continuous-learning-v2/scripts/test_parse_instinct.py+++ b/skills/continuous-learning-v2/scripts/test_parse_instinct.py@@ -1047,6 +1047,70 @@ def test_update_registry_atomic_replaces_file(patch_globals):assert leftovers == []+def test_update_registry_matches_shell_schema(patch_globals):+ # Issue #2299: the Python writer must emit the same field set as the shell+ # counterpart in detect-project.sh (id, name, root, remote, created_at,+ # last_seen) so a projects.json entry has a consistent shape regardless of+ # which path wrote it.+ tree = patch_globals+ _update_registry("abc123", "demo", "/repo", "https://example.com/repo.git")+ entry = json.loads(tree["registry_file"].read_text())["abc123"]+ assert set(entry) == {"id", "name", "root", "remote", "created_at", "last_seen"}+ assert entry["id"] == "abc123"+ assert entry["name"] == "demo"+ assert entry["root"] == "/repo"+ assert entry["remote"] == "https://example.com/repo.git"+ # On the initial write both timestamps come from the same `now`, so the+ # first-write contract is created_at == last_seen.+ assert entry["created_at"]+ assert entry["created_at"] == entry["last_seen"]+++def test_update_registry_preserves_created_at(patch_globals):+ # created_at is stamped on first write and preserved on subsequent updates,+ # while last_seen advances — matching entry.get("created_at", now) in the+ # shell counterpart.+ tree = patch_globals+ _update_registry("abc123", "demo", "/repo", "https://example.com/repo.git")+ first = json.loads(tree["registry_file"].read_text())["abc123"]++ _update_registry("abc123", "demo-renamed", "/repo", "https://example.com/repo.git")+ second = json.loads(tree["registry_file"].read_text())["abc123"]++ assert second["created_at"] == first["created_at"]+ assert second["name"] == "demo-renamed"+ assert second["last_seen"] >= first["last_seen"]+++def test_update_registry_heals_malformed_entry(patch_globals):+ # Issue #2299 follow-up: a non-dict value for the project id (e.g. a+ # corrupt registry) must not crash _update_registry. The entry is healed by+ # the rewrite, preserving the old unconditional-overwrite behavior.+ tree = patch_globals+ tree["registry_file"].write_text(json.dumps({"abc123": None}), encoding="utf-8")+ _update_registry("abc123", "demo", "/repo", "https://example.com/repo.git")+ entry = json.loads(tree["registry_file"].read_text())["abc123"]+ assert isinstance(entry, dict)+ assert entry["id"] == "abc123"+ assert entry["created_at"]+ assert entry["created_at"] == entry["last_seen"]+++def test_update_registry_heals_non_dict_registry(patch_globals):+ # Issue #2299 follow-up: a top-level registry that is valid JSON but not a+ # mapping (e.g. a list or string from a corrupt projects.json) must not+ # crash _update_registry before the per-entry guard runs. The whole file is+ # healed by the rewrite, preserving the old unconditional-overwrite behavior.+ tree = patch_globals+ tree["registry_file"].write_text(json.dumps(["oops"]), encoding="utf-8")+ _update_registry("abc123", "demo", "/repo", "https://example.com/repo.git")+ registry = json.loads(tree["registry_file"].read_text())+ assert isinstance(registry, dict)+ entry = registry["abc123"]+ assert entry["id"] == "abc123"+ assert entry["created_at"] == entry["last_seen"]++def test_write_registry_atomic_no_tmp_leftovers(patch_globals):# Issue #2294: _write_registry now holds the registry lock like# _update_registry. It must still write atomically with no stray tmp files.