The agent harness performance optimization system. Skills, instincts, memory, security, and research-first development for Claude Code, Codex, Opencode, Cursor and beyond.
test: cover findFiles unreadable subdir, session-start default PM, setPreferredPM save failure
Affaan Mustafaf623e3b42902
diff --git a/tests/hooks/hooks.test.js b/tests/hooks/hooks.test.jsindex c22110926..8de08b8b5 100644--- a/tests/hooks/hooks.test.js+++ b/tests/hooks/hooks.test.js@@ -3117,6 +3117,42 @@ async function runTests() {}})) passed++; else failed++;+ // ── Round 71: session-start.js default source shows getSelectionPrompt ──+ console.log('\nRound 71: session-start.js (default source — selection prompt):');++ if (await asyncTest('shows selection prompt when no package manager preference found (default source)', async () => {+ const isoHome = path.join(os.tmpdir(), `ecc-r71-ss-default-${Date.now()}`);+ const isoProject = path.join(isoHome, 'project');+ fs.mkdirSync(path.join(isoHome, '.claude', 'sessions'), { recursive: true });+ fs.mkdirSync(path.join(isoHome, '.claude', 'skills', 'learned'), { recursive: true });+ fs.mkdirSync(isoProject, { recursive: true });+ // No package.json, no lock files, no package-manager.json — forces default source++ try {+ const result = await new Promise((resolve, reject) => {+ const env = { ...process.env, HOME: isoHome, USERPROFILE: isoHome };+ delete env.CLAUDE_PACKAGE_MANAGER; // Remove any env-level PM override+ const proc = spawn('node', [path.join(scriptsDir, 'session-start.js')], {+ env,+ cwd: isoProject, // CWD with no package.json or lock files+ stdio: ['pipe', 'pipe', 'pipe']+ });+ let stdout = '';+ let stderr = '';+ proc.stdout.on('data', data => stdout += data);+ proc.stderr.on('data', data => stderr += data);+ proc.stdin.end();+ proc.on('close', code => resolve({ code, stdout, stderr }));+ proc.on('error', reject);+ });+ assert.strictEqual(result.code, 0, 'Should exit 0');+ assert.ok(result.stderr.includes('No package manager preference'),+ `Should show selection prompt when source is default. Got stderr: ${result.stderr.slice(0, 500)}`);+ } finally {+ fs.rmSync(isoHome, { recursive: true, force: true });+ }+ })) passed++; else failed++;+// Summaryconsole.log('\n=== Test Results ===');console.log(`Passed: ${passed}`);diff --git a/tests/lib/package-manager.test.js b/tests/lib/package-manager.test.jsindex fc81cb407..12173898e 100644--- a/tests/lib/package-manager.test.js+++ b/tests/lib/package-manager.test.js@@ -1269,6 +1269,43 @@ function runTests() {}})) passed++; else failed++;+ // ── Round 71: setPreferredPackageManager save failure wraps error ──+ console.log('\nRound 71: setPreferredPackageManager (save failure):');++ if (test('setPreferredPackageManager throws wrapped error when save fails', () => {+ if (process.platform === 'win32' || process.getuid?.() === 0) {+ console.log(' (skipped — chmod ineffective on Windows/root)');+ return;+ }+ const isoHome = path.join(os.tmpdir(), `ecc-pm-r71-${Date.now()}`);+ const claudeDir = path.join(isoHome, '.claude');+ fs.mkdirSync(claudeDir, { recursive: true });++ const savedHome = process.env.HOME;+ const savedProfile = process.env.USERPROFILE;+ try {+ process.env.HOME = isoHome;+ process.env.USERPROFILE = isoHome;+ delete require.cache[require.resolve('../../scripts/lib/package-manager')];+ delete require.cache[require.resolve('../../scripts/lib/utils')];+ const freshPm = require('../../scripts/lib/package-manager');++ // Make .claude directory read-only — can't create new files (package-manager.json)+ fs.chmodSync(claudeDir, 0o555);++ assert.throws(() => {+ freshPm.setPreferredPackageManager('npm');+ }, /Failed to save package manager preference/);+ } finally {+ try { fs.chmodSync(claudeDir, 0o755); } catch { /* best-effort */ }+ process.env.HOME = savedHome;+ process.env.USERPROFILE = savedProfile;+ delete require.cache[require.resolve('../../scripts/lib/package-manager')];+ delete require.cache[require.resolve('../../scripts/lib/utils')];+ fs.rmSync(isoHome, { recursive: true, force: true });+ }+ })) passed++; else failed++;+// Summaryconsole.log('\n=== Test Results ===');console.log(`Passed: ${passed}`);diff --git a/tests/lib/utils.test.js b/tests/lib/utils.test.jsindex 224026c11..698ab7e5f 100644--- a/tests/lib/utils.test.js+++ b/tests/lib/utils.test.js@@ -1062,6 +1062,40 @@ function runTests() {'All-invalid patterns should return same result as no patterns (no filtering)');})) passed++; else failed++;+ // ── Round 71: findFiles recursive scan skips unreadable subdirectory ──+ console.log('\nRound 71: findFiles (unreadable subdirectory in recursive scan):');++ if (test('findFiles recursive scan skips unreadable subdirectory silently', () => {+ if (process.platform === 'win32' || process.getuid?.() === 0) {+ console.log(' (skipped — chmod ineffective on Windows/root)');+ return;+ }+ const tmpDir = path.join(utils.getTempDir(), `ecc-findfiles-r71-${Date.now()}`);+ const readableSubdir = path.join(tmpDir, 'readable');+ const unreadableSubdir = path.join(tmpDir, 'unreadable');+ fs.mkdirSync(readableSubdir, { recursive: true });+ fs.mkdirSync(unreadableSubdir, { recursive: true });++ // Create files in both subdirectories+ fs.writeFileSync(path.join(readableSubdir, 'found.txt'), 'data');+ fs.writeFileSync(path.join(unreadableSubdir, 'hidden.txt'), 'data');++ // Make the subdirectory unreadable — readdirSync will throw EACCES+ fs.chmodSync(unreadableSubdir, 0o000);++ try {+ const results = utils.findFiles(tmpDir, '*.txt', { recursive: true });+ // Should find the readable file but silently skip the unreadable dir+ assert.ok(results.length >= 1, 'Should find at least the readable file');+ const paths = results.map(r => r.path);+ assert.ok(paths.some(p => p.includes('found.txt')), 'Should find readable/found.txt');+ assert.ok(!paths.some(p => p.includes('hidden.txt')), 'Should not find unreadable/hidden.txt');+ } finally {+ fs.chmodSync(unreadableSubdir, 0o755);+ fs.rmSync(tmpDir, { recursive: true, force: true });+ }+ })) passed++; else failed++;+// Summaryconsole.log('\n=== Test Results ===');console.log(`Passed: ${passed}`);