Skip to content

armgit / ECC

Public Imported from GitHub
0

The agent harness performance optimization system. Skills, instincts, memory, security, and research-first development for Claude Code, Codex, Opencode, Cursor and beyond.

fix(llm/providers/claude): attach cache_control to system block, not top-level (#2515)

Thejeshfb98726d0a35
diff --git a/src/llm/providers/claude.py b/src/llm/providers/claude.py
index 1acc7e677..20b45aedc 100644
--- a/src/llm/providers/claude.py
+++ b/src/llm/providers/claude.py
@@ -67,10 +67,15 @@ class ClaudeProvider(LLMProvider):
"model": model,
"messages": api_messages,
"max_tokens": input.max_tokens if input.max_tokens else 16000,
- "cache_control": {"type": "ephemeral"},
}
if system_parts:
- params["system"] = "\n\n".join(system_parts)
+ params["system"] = [
+ {
+ "type": "text",
+ "text": "\n\n".join(system_parts),
+ "cache_control": {"type": "ephemeral"},
+ }
+ ]
if input.tools:
params["tools"] = [tool.to_anthropic_tool() for tool in input.tools]
if not _uses_adaptive_thinking_only(model):
diff --git a/tests/test_claude_provider.py b/tests/test_claude_provider.py
index 29f0256fc..7a4d54f95 100644
--- a/tests/test_claude_provider.py
+++ b/tests/test_claude_provider.py
@@ -10,8 +10,10 @@ from llm.providers.claude import ClaudeProvider
class FakeMessages:
def __init__(self, response: SimpleNamespace) -> None:
self.response = response
+ self.last_params: dict[str, Any] = {}
- def create(self, **_params: object) -> SimpleNamespace:
+ def create(self, **params: object) -> SimpleNamespace:
+ self.last_params = dict(params)
return self.response
@@ -109,3 +111,41 @@ def test_generate_text_only_has_no_tool_calls() -> None:
assert output.content == "Hello."
assert output.tool_calls is None
+
+
+def test_generate_does_not_pass_cache_control_as_top_level_param() -> None:
+ # cache_control is a per-content-block field on the Anthropic Messages API,
+ # not a top-level parameter. Passing it at the top level raises TypeError
+ # in the Anthropic Python SDK (or a 400 from the API).
+ provider = make_provider(make_response([SimpleNamespace(type="text", text="ok")]))
+
+ provider.generate(
+ LLMInput(
+ messages=[
+ Message(role=Role.SYSTEM, content="system prompt"),
+ Message(role=Role.USER, content="hi"),
+ ]
+ )
+ )
+
+ params = provider.client.messages.last_params
+ assert "cache_control" not in params
+
+ # When a system prompt is present, cache_control should ride on the last
+ # system content block so ephemeral prompt caching still works.
+ system = params.get("system")
+ assert isinstance(system, list), "system should be sent as a list of content blocks"
+ assert system, "system content-block list should not be empty"
+ assert system[-1].get("cache_control") == {"type": "ephemeral"}
+
+
+def test_generate_without_system_does_not_set_system_or_cache_control() -> None:
+ provider = make_provider(make_response([SimpleNamespace(type="text", text="ok")]))
+
+ provider.generate(LLMInput(messages=[Message(role=Role.USER, content="hi")]))
+
+ params = provider.client.messages.last_params
+ assert "cache_control" not in params
+ assert "system" not in params