VERY experimental Nintendo Switch 2 emulator
C++
device_session: Pass arguments by const-ref in relevant functions
Lioncash0bf42e31e4fe
diff --git a/src/audio_core/device/audio_buffers.h b/src/audio_core/device/audio_buffers.hindex 3ecbbb63f0..4918a61c7f 100644--- a/src/audio_core/device/audio_buffers.h+++ b/src/audio_core/device/audio_buffers.h@@ -93,7 +93,7 @@ public:** @return Is the buffer was released.*/- bool ReleaseBuffers(Core::Timing::CoreTiming& core_timing, DeviceSession& session) {+ bool ReleaseBuffers(const Core::Timing::CoreTiming& core_timing, const DeviceSession& session) {std::scoped_lock l{lock};bool buffer_released{false};while (registered_count > 0) {diff --git a/src/audio_core/device/device_session.cpp b/src/audio_core/device/device_session.cppindex c71c3a376f..6cde33f933 100644--- a/src/audio_core/device/device_session.cpp+++ b/src/audio_core/device/device_session.cpp@@ -73,7 +73,7 @@ void DeviceSession::Stop() {}}-void DeviceSession::AppendBuffers(std::span<AudioBuffer> buffers) const {+void DeviceSession::AppendBuffers(std::span<const AudioBuffer> buffers) const {for (size_t i = 0; i < buffers.size(); i++) {Sink::SinkBuffer new_buffer{.frames = buffers[i].size / (channel_count * sizeof(s16)),@@ -93,14 +93,14 @@ void DeviceSession::AppendBuffers(std::span<AudioBuffer> buffers) const {}}-void DeviceSession::ReleaseBuffer(AudioBuffer& buffer) const {+void DeviceSession::ReleaseBuffer(const AudioBuffer& buffer) const {if (type == Sink::StreamType::In) {auto samples{stream->ReleaseBuffer(buffer.size / sizeof(s16))};system.Memory().WriteBlockUnsafe(buffer.samples, samples.data(), buffer.size);}}-bool DeviceSession::IsBufferConsumed(AudioBuffer& buffer) const {+bool DeviceSession::IsBufferConsumed(const AudioBuffer& buffer) const {return played_sample_count >= buffer.end_timestamp;}diff --git a/src/audio_core/device/device_session.h b/src/audio_core/device/device_session.hindex 53b649c615..74f4dc0850 100644--- a/src/audio_core/device/device_session.h+++ b/src/audio_core/device/device_session.h@@ -62,14 +62,14 @@ public:** @param buffers - The buffers to play.*/- void AppendBuffers(std::span<AudioBuffer> buffers) const;+ void AppendBuffers(std::span<const AudioBuffer> buffers) const;/*** (Audio In only) Pop samples from the backend, and write them back to this buffer's address.** @param buffer - The buffer to write to.*/- void ReleaseBuffer(AudioBuffer& buffer) const;+ void ReleaseBuffer(const AudioBuffer& buffer) const;/*** Check if the buffer for the given tag has been consumed by the backend.@@ -78,7 +78,7 @@ public:** @return true if the buffer has been consumed, otherwise false.*/- bool IsBufferConsumed(AudioBuffer& buffer) const;+ bool IsBufferConsumed(const AudioBuffer& buffer) const;/*** Start this device session, starting the backend stream.