VERY experimental Nintendo Switch 2 emulator
C++
[audio_core] Fix audio reverb effect (#2646)
MaranBr1a5b3fb23934
diff --git a/src/audio_core/renderer/behavior/info_updater.cpp b/src/audio_core/renderer/behavior/info_updater.cppindex 48fe1f8975..20f6cda3a2 100644--- a/src/audio_core/renderer/behavior/info_updater.cpp+++ b/src/audio_core/renderer/behavior/info_updater.cpp@@ -165,12 +165,6 @@ Result InfoUpdater::UpdateEffectsVersion1(EffectContext& effect_context, const breinterpret_cast<EffectInfoBase::OutStatusVersion1*>(output), effect_count};for (u32 i = 0; i < effect_count; i++) {-#ifdef _WIN32- // There's a bug in Windows where using this effect causes extreme noise. So let's skip it.- if (in_params[i].type == EffectInfoBase::Type::Reverb) {- continue;- }-#endifauto effect_info{&effect_context.GetInfo(i)};if (effect_info->GetType() != in_params[i].type) {effect_info->ForceUnmapBuffers(pool_mapper);@@ -218,12 +212,6 @@ Result InfoUpdater::UpdateEffectsVersion2(EffectContext& effect_context, const breinterpret_cast<EffectInfoBase::OutStatusVersion2*>(output), effect_count};for (u32 i = 0; i < effect_count; i++) {-#ifdef _WIN32- // There's a bug in Windows where using this effect causes extreme noise. So let's skip it.- if (in_params[i].type == EffectInfoBase::Type::Reverb) {- continue;- }-#endifauto effect_info{&effect_context.GetInfo(i)};if (effect_info->GetType() != in_params[i].type) {effect_info->ForceUnmapBuffers(pool_mapper);diff --git a/src/audio_core/renderer/command/effect/reverb.cpp b/src/audio_core/renderer/command/effect/reverb.cppindex 46b85b8945..87eab1adda 100644--- a/src/audio_core/renderer/command/effect/reverb.cpp+++ b/src/audio_core/renderer/command/effect/reverb.cpp@@ -191,8 +191,6 @@ static void InitializeReverbEffect(const ReverbInfo::ParameterVersion2& params,const auto center_delay_time{(5 * delay).to_uint_floor()};state.center_delay_line.Initialize(center_delay_time, 1.0f);- UpdateReverbEffectParameter(params, state);-for (u32 i = 0; i < ReverbInfo::MaxDelayLines; i++) {std::ranges::fill(state.fdn_delay_lines[i].buffer, 0);std::ranges::fill(state.decay_delay_lines[i].buffer, 0);