VERY experimental Nintendo Switch 2 emulator
C++
[meta] clang-format literally all of the Qt code (#3706)
crueter8678cb06eb28
diff --git a/src/qt_common/abstract/frontend.cpp b/src/qt_common/abstract/frontend.cppindex 05eb550095..de362b253f 100644--- a/src/qt_common/abstract/frontend.cpp+++ b/src/qt_common/abstract/frontend.cpp@@ -6,17 +6,17 @@namespace QtCommon::Frontend {const QString GetOpenFileName(const QString& title, const QString& dir, const QString& filter,- QString* selectedFilter) {+ QString* selectedFilter) {return QFileDialog::getOpenFileName(rootObject, title, dir, filter, selectedFilter);}const QStringList GetOpenFileNames(const QString& title, const QString& dir, const QString& filter,- QString* selectedFilter) {+ QString* selectedFilter) {return QFileDialog::getOpenFileNames(rootObject, title, dir, filter, selectedFilter);}const QString GetSaveFileName(const QString& title, const QString& dir, const QString& filter,- QString* selectedFilter) {+ QString* selectedFilter) {return QFileDialog::getSaveFileName(rootObject, title, dir, filter, selectedFilter);}diff --git a/src/qt_common/abstract/progress.cpp b/src/qt_common/abstract/progress.cppindex c9185a756d..2141e41d44 100644--- a/src/qt_common/abstract/progress.cpp+++ b/src/qt_common/abstract/progress.cpp@@ -5,13 +5,8 @@namespace QtCommon::Frontend {-QtProgressDialog::QtProgressDialog(const QString&,- const QString&,- int,- int,- QObject* parent,+QtProgressDialog::QtProgressDialog(const QString&, const QString&, int, int, QObject* parent,Qt::WindowFlags)- : QObject(parent)-{}+ : QObject(parent) {}-}+} // namespace QtCommon::Frontenddiff --git a/src/qt_common/config/shared_translation.cpp b/src/qt_common/config/shared_translation.cppindex d1ed32134c..a0c4779b73 100644--- a/src/qt_common/config/shared_translation.cpp+++ b/src/qt_common/config/shared_translation.cpp@@ -9,24 +9,23 @@#include "shared_translation.h"+#include <map>+#include <memory>+#include <utility>#include <QCoreApplication>#include "common/settings.h"#include "common/settings_enums.h"#include "common/settings_setting.h"#include "common/time_zone.h"#include "qt_common/config/uisettings.h"-#include <map>-#include <memory>-#include <utility>namespace ConfigurationShared {-std::unique_ptr<TranslationMap> InitializeTranslations(QObject* parent)-{+std::unique_ptr<TranslationMap> InitializeTranslations(QObject* parent) {std::unique_ptr<TranslationMap> translations = std::make_unique<TranslationMap>();const auto& tr = [parent](const char* text) -> QString { return parent->tr(text); };-#define INSERT(SETTINGS, ID, NAME, TOOLTIP) \+#define INSERT(SETTINGS, ID, NAME, TOOLTIP) \translations->insert(std::pair{SETTINGS::values.ID.Id(), std::pair{(NAME), (TOOLTIP)}})// A setting can be ignored by giving it a blank name@@ -47,10 +46,9 @@ std::unique_ptr<TranslationMap> InitializeTranslations(QObject* parent)INSERT(Settings, login_share_applet_mode, tr("Login share"), QString());INSERT(Settings, wifi_web_auth_applet_mode, tr("Wifi web auth"), QString());INSERT(Settings, my_page_applet_mode, tr("My page"), QString());- INSERT(Settings,- enable_overlay,- tr("Enable Overlay Applet"),- tr("Enables Horizon\'s built-in overlay applet. Press and hold the home button for 1 second to show it."));+ INSERT(Settings, enable_overlay, tr("Enable Overlay Applet"),+ tr("Enables Horizon\'s built-in overlay applet. Press and hold the home button for 1 "+ "second to show it."));// AudioINSERT(Settings, sink_id, tr("Output Engine:"), QString());@@ -62,23 +60,16 @@ std::unique_ptr<TranslationMap> InitializeTranslations(QObject* parent)INSERT(UISettings, mute_when_in_background, tr("Mute audio when in background"), QString());// Core- INSERT(- Settings,- use_multi_core,- tr("Multicore CPU Emulation"),- tr("This option increases CPU emulation thread use from 1 to the maximum of 4.\n"- "This is mainly a debug option and shouldn't be disabled."));- INSERT(- Settings,- memory_layout_mode,- tr("Memory Layout"),- tr("Increases the amount of emulated RAM.\nDoesn't affect performance/stability but may allow HD texture "- "mods to load."));+ INSERT(Settings, use_multi_core, tr("Multicore CPU Emulation"),+ tr("This option increases CPU emulation thread use from 1 to the maximum of 4.\n"+ "This is mainly a debug option and shouldn't be disabled."));+ INSERT(Settings, memory_layout_mode, tr("Memory Layout"),+ tr("Increases the amount of emulated RAM.\nDoesn't affect performance/stability but may "+ "allow HD texture "+ "mods to load."));INSERT(Settings, use_speed_limit, QString(), QString());INSERT(Settings, current_speed_mode, QString(), QString());- INSERT(Settings,- speed_limit,- tr("Limit Speed Percent"),+ INSERT(Settings, speed_limit, tr("Limit Speed Percent"),tr("Controls the game's maximum rendering speed, but it's up to each game if it runs ""faster or not.\n200% for a 30 FPS game is 60 FPS, and for a ""60 FPS game it will be 120 FPS.\nDisabling it means unlocking the framerate to the "@@ -91,171 +82,128 @@ std::unique_ptr<TranslationMap> InitializeTranslations(QObject* parent)tr("When the Slow Speed hotkey is pressed, the speed will be limited to this ""percentage."));- INSERT(Settings,- sync_core_speed,- tr("Synchronize Core Speed"),+ INSERT(Settings, sync_core_speed, tr("Synchronize Core Speed"),tr("Synchronizes CPU core speed with the game's maximum rendering speed to boost FPS ""without affecting game speed (animations, physics, etc.).\n""Can help reduce stuttering at lower framerates."));// Cpu- INSERT(Settings,- cpu_accuracy,- tr("Accuracy:"),+ INSERT(Settings, cpu_accuracy, tr("Accuracy:"),tr("Change the accuracy of the emulated CPU (for debugging only)."));INSERT(Settings, cpu_backend, tr("Backend:"), QString());- INSERT(Settings,- fast_cpu_time,- tr("CPU Overclock"),- tr("Overclocks the emulated CPU to remove some FPS limiters. Weaker CPUs may see reduced performance, "- "and certain games may behave improperly.\nUse Boost (1700MHz) to run at the Switch's highest native "+ INSERT(Settings, fast_cpu_time, tr("CPU Overclock"),+ tr("Overclocks the emulated CPU to remove some FPS limiters. Weaker CPUs may see "+ "reduced performance, "+ "and certain games may behave improperly.\nUse Boost (1700MHz) to run at the "+ "Switch's highest native ""clock, or Fast (2000MHz) to run at 2x clock."));INSERT(Settings, use_custom_cpu_ticks, QString(), QString());- INSERT(Settings,- cpu_ticks,- tr("Custom CPU Ticks"),+ INSERT(Settings, cpu_ticks, tr("Custom CPU Ticks"),tr("Set a custom value of CPU ticks. Higher values can increase performance, but may ""cause deadlocks. A range of 77-21000 is recommended."));INSERT(Settings, cpu_backend, tr("Backend:"), QString());- INSERT(Settings, vtable_bouncing,- tr("Virtual Table Bouncing"),- tr("Bounces (by emulating a 0-valued return) any functions that triggers a prefetch abort"));+ INSERT(Settings, vtable_bouncing, tr("Virtual Table Bouncing"),+ tr("Bounces (by emulating a 0-valued return) any functions that triggers a prefetch "+ "abort"));// Cpu Debug// Cpu Unsafe- INSERT(Settings, cpuopt_unsafe_host_mmu, tr("Enable Host MMU Emulation (fastmem)"),- tr("This optimization speeds up memory accesses by the guest program.\nEnabling it causes guest memory reads/writes to be done directly into memory and make use of Host's MMU.\nDisabling this forces all memory accesses to use Software MMU Emulation."));INSERT(- Settings,- cpuopt_unsafe_unfuse_fma,+ Settings, cpuopt_unsafe_host_mmu, tr("Enable Host MMU Emulation (fastmem)"),+ tr("This optimization speeds up memory accesses by the guest program.\nEnabling it causes "+ "guest memory reads/writes to be done directly into memory and make use of Host's "+ "MMU.\nDisabling this forces all memory accesses to use Software MMU Emulation."));+ INSERT(+ Settings, cpuopt_unsafe_unfuse_fma,tr("Unfuse FMA (improve performance on CPUs without FMA)"),tr("This option improves speed by reducing accuracy of fused-multiply-add instructions on ""CPUs without native FMA support."));INSERT(- Settings,- cpuopt_unsafe_reduce_fp_error,- tr("Faster FRSQRTE and FRECPE"),+ Settings, cpuopt_unsafe_reduce_fp_error, tr("Faster FRSQRTE and FRECPE"),tr("This option improves the speed of some approximate floating-point functions by using ""less accurate native approximations."));- INSERT(Settings,- cpuopt_unsafe_ignore_standard_fpcr,+ INSERT(Settings, cpuopt_unsafe_ignore_standard_fpcr,tr("Faster ASIMD instructions (32 bits only)"),tr("This option improves the speed of 32 bits ASIMD floating-point functions by running ""with incorrect rounding modes."));- INSERT(Settings,- cpuopt_unsafe_inaccurate_nan,- tr("Inaccurate NaN handling"),+ INSERT(Settings, cpuopt_unsafe_inaccurate_nan, tr("Inaccurate NaN handling"),tr("This option improves speed by removing NaN checking.\nPlease note this also reduces ""accuracy of certain floating-point instructions."));- INSERT(Settings,- cpuopt_unsafe_fastmem_check,- tr("Disable address space checks"),+ INSERT(Settings, cpuopt_unsafe_fastmem_check, tr("Disable address space checks"),tr("This option improves speed by eliminating a safety check before every memory ""operation.\nDisabling it may allow arbitrary code execution."));INSERT(- Settings,- cpuopt_unsafe_ignore_global_monitor,- tr("Ignore global monitor"),+ Settings, cpuopt_unsafe_ignore_global_monitor, tr("Ignore global monitor"),tr("This option improves speed by relying only on the semantics of cmpxchg to ensure ""safety of exclusive access instructions.\nPlease note this may result in deadlocks and ""other race conditions."));// Renderer- INSERT(- Settings,- renderer_backend,- tr("API:"),- tr("Changes the output graphics API.\nVulkan is recommended."));- INSERT(Settings,- vulkan_device,- tr("Device:"),+ INSERT(Settings, renderer_backend, tr("API:"),+ tr("Changes the output graphics API.\nVulkan is recommended."));+ INSERT(Settings, vulkan_device, tr("Device:"),tr("This setting selects the GPU to use (Vulkan only)."));- INSERT(Settings,- resolution_setup,- tr("Resolution:"),+ INSERT(Settings, resolution_setup, tr("Resolution:"),tr("Forces to render at a different resolution.\n""Higher resolutions require more VRAM and bandwidth.\n""Options lower than 1X can cause artifacts."));INSERT(Settings, scaling_filter, tr("Window Adapting Filter:"), QString());- INSERT(Settings,- fsr_sharpening_slider,- tr("FSR Sharpness:"),+ INSERT(Settings, fsr_sharpening_slider, tr("FSR Sharpness:"),tr("Determines how sharpened the image will look using FSR's dynamic contrast."));- INSERT(Settings,- anti_aliasing,- tr("Anti-Aliasing Method:"),+ INSERT(Settings, anti_aliasing, tr("Anti-Aliasing Method:"),tr("The anti-aliasing method to use.\nSMAA offers the best quality.\nFXAA ""can produce a more stable picture in lower resolutions."));- INSERT(Settings,- fullscreen_mode,- tr("Fullscreen Mode:"),+ INSERT(Settings, fullscreen_mode, tr("Fullscreen Mode:"),tr("The method used to render the window in fullscreen.\nBorderless offers the best ""compatibility with the on-screen keyboard that some games request for ""input.\nExclusive ""fullscreen may offer better performance and better Freesync/Gsync support."));- INSERT(Settings,- aspect_ratio,- tr("Aspect Ratio:"),+ INSERT(Settings, aspect_ratio, tr("Aspect Ratio:"),tr("Stretches the renderer to fit the specified aspect ratio.\nMost games only support ""16:9, so modifications are required to get other ratios.\nAlso controls the ""aspect ratio of captured screenshots."));- INSERT(Settings,- use_disk_shader_cache,- tr("Use persistent pipeline cache"),+ INSERT(Settings, use_disk_shader_cache, tr("Use persistent pipeline cache"),tr("Allows saving shaders to storage for faster loading on following game ""boots.\nDisabling it is only intended for debugging."));- INSERT(Settings,- optimize_spirv_output,- tr("Optimize SPIRV output"),+ INSERT(Settings, optimize_spirv_output, tr("Optimize SPIRV output"),tr("Runs an additional optimization pass over generated SPIRV shaders.\n""Will increase time required for shader compilation.\nMay slightly improve ""performance.\nThis feature is experimental."));- INSERT(Settings,- nvdec_emulation,- tr("NVDEC emulation:"),+ INSERT(Settings, nvdec_emulation, tr("NVDEC emulation:"),tr("Specifies how videos should be decoded.\nIt can either use the CPU or the GPU for ""decoding, or perform no decoding at all (black screen on videos).\n""In most cases, GPU decoding provides the best performance."));- INSERT(Settings,- accelerate_astc,- tr("ASTC Decoding Method:"),+ INSERT(Settings, accelerate_astc, tr("ASTC Decoding Method:"),tr("This option controls how ASTC textures should be decoded.\n""CPU: Use the CPU for decoding.\n""GPU: Use the GPU's compute shaders to decode ASTC textures (recommended).\n""CPU Asynchronously: Use the CPU to decode ASTC textures on demand. Eliminates""ASTC decoding\nstuttering but may present artifacts."));- INSERT(- Settings,- astc_recompression,- tr("ASTC Recompression Method:"),- tr("Most GPUs lack support for ASTC textures and must decompress to an"- "intermediate format: RGBA8.\n"- "BC1/BC3: The intermediate format will be recompressed to BC1 or BC3 format,\n"- " saving VRAM but degrading image quality."));+ INSERT(Settings, astc_recompression, tr("ASTC Recompression Method:"),+ tr("Most GPUs lack support for ASTC textures and must decompress to an"+ "intermediate format: RGBA8.\n"+ "BC1/BC3: The intermediate format will be recompressed to BC1 or BC3 format,\n"+ " saving VRAM but degrading image quality."));INSERT(Settings, frame_pacing_mode, tr("Frame Pacing Mode (Vulkan only)"),- tr("Controls how the emulator manages frame pacing to reduce stuttering and make the frame rate smoother and more consistent."));- INSERT(Settings,- vram_usage_mode,- tr("VRAM Usage Mode:"),- tr("Selects whether the emulator should prefer to conserve memory or make maximum usage of available video memory for performance.\nAggressive mode may impact performance of other applications such as recording software."));- INSERT(Settings,- skip_cpu_inner_invalidation,- tr("Skip CPU Inner Invalidation"),+ tr("Controls how the emulator manages frame pacing to reduce stuttering and make the "+ "frame rate smoother and more consistent."));+ INSERT(Settings, vram_usage_mode, tr("VRAM Usage Mode:"),+ tr("Selects whether the emulator should prefer to conserve memory or make maximum usage "+ "of available video memory for performance.\nAggressive mode may impact performance "+ "of other applications such as recording software."));+ INSERT(Settings, skip_cpu_inner_invalidation, tr("Skip CPU Inner Invalidation"),tr("Skips certain cache invalidations during memory updates, reducing CPU usage and ""improving latency. This may cause soft-crashes."));- INSERT(- Settings,- vsync_mode,- tr("VSync Mode:"),- tr("FIFO (VSync) does not drop frames or exhibit tearing but is limited by the screen "- "refresh rate.\nFIFO Relaxed allows tearing as it recovers from a slow down.\n"- "Mailbox can have lower latency than FIFO and does not tear but may drop "- "frames.\nImmediate (no synchronization) presents whatever is available and can "- "exhibit tearing."));+ INSERT(Settings, vsync_mode, tr("VSync Mode:"),+ tr("FIFO (VSync) does not drop frames or exhibit tearing but is limited by the screen "+ "refresh rate.\nFIFO Relaxed allows tearing as it recovers from a slow down.\n"+ "Mailbox can have lower latency than FIFO and does not tear but may drop "+ "frames.\nImmediate (no synchronization) presents whatever is available and can "+ "exhibit tearing."));INSERT(Settings, bg_red, QString(), QString());INSERT(Settings, bg_green, QString(), QString());INSERT(Settings, bg_blue, QString(), QString());@@ -264,103 +212,74 @@ std::unique_ptr<TranslationMap> InitializeTranslations(QObject* parent)INSERT(Settings, use_asynchronous_gpu_emulation, QString(), QString());INSERT(Settings, sync_memory_operations, tr("Sync Memory Operations"),- tr("Ensures data consistency between compute and memory operations.\nThis option fixes issues in games, but may degrade performance.\nUnreal Engine 4 games often see the most significant changes thereof."));- INSERT(Settings,- async_presentation,- tr("Enable asynchronous presentation (Vulkan only)"),+ tr("Ensures data consistency between compute and memory operations.\nThis option fixes "+ "issues in games, but may degrade performance.\nUnreal Engine 4 games often see the "+ "most significant changes thereof."));+ INSERT(Settings, async_presentation, tr("Enable asynchronous presentation (Vulkan only)"),tr("Slightly improves performance by moving presentation to a separate CPU thread."));INSERT(- Settings,- renderer_force_max_clock,- tr("Force maximum clocks (Vulkan only)"),+ Settings, renderer_force_max_clock, tr("Force maximum clocks (Vulkan only)"),tr("Runs work in the background while waiting for graphics commands to keep the GPU from ""lowering its clock speed."));- INSERT(Settings,- max_anisotropy,- tr("Anisotropic Filtering:"),- tr("Controls the quality of texture rendering at oblique angles.\nSafe to set at 16x on most GPUs."));- INSERT(Settings,- gpu_accuracy,- tr("GPU Mode:"),- tr("Controls the GPU emulation mode.\nMost games render fine with Fast or Balanced modes, but Accurate is still "+ INSERT(Settings, max_anisotropy, tr("Anisotropic Filtering:"),+ tr("Controls the quality of texture rendering at oblique angles.\nSafe to set at 16x on "+ "most GPUs."));+ INSERT(Settings, gpu_accuracy, tr("GPU Mode:"),+ tr("Controls the GPU emulation mode.\nMost games render fine with Fast or Balanced "+ "modes, but Accurate is still ""required for some.\nParticles tend to only render correctly with Accurate mode."));- INSERT(Settings,- dma_accuracy,- tr("DMA Accuracy:"),- tr("Controls the DMA precision accuracy. Safe precision fixes issues in some games but may degrade performance."));- INSERT(Settings,- use_asynchronous_shaders,- tr("Enable asynchronous shader compilation"),+ INSERT(Settings, dma_accuracy, tr("DMA Accuracy:"),+ tr("Controls the DMA precision accuracy. Safe precision fixes issues in some games but "+ "may degrade performance."));+ INSERT(Settings, use_asynchronous_shaders, tr("Enable asynchronous shader compilation"),tr("May reduce shader stutter."));- INSERT(Settings,- fast_gpu_time,- tr("Fast GPU Time"),+ INSERT(Settings, fast_gpu_time, tr("Fast GPU Time"),tr("Overclocks the emulated GPU to increase dynamic resolution and render ""distance.\nUse 256 for maximal performance and 512 for maximal graphics fidelity."));- INSERT(Settings,- gpu_unswizzle_enabled,- tr("GPU Unswizzle"),+ INSERT(Settings, gpu_unswizzle_enabled, tr("GPU Unswizzle"),tr("Accelerates BCn 3D texture decoding using GPU compute.\n""Disable if experiencing crashes or graphical glitches."));- INSERT(Settings,- gpu_unswizzle_texture_size,- tr("GPU Unswizzle Max Texture Size"),+ INSERT(Settings, gpu_unswizzle_texture_size, tr("GPU Unswizzle Max Texture Size"),tr("Sets the maximum size (MiB) for GPU-based texture unswizzling.\n"- "While the GPU is faster for medium and large textures, the CPU may be more efficient for very small ones.\n"+ "While the GPU is faster for medium and large textures, the CPU may be more "+ "efficient for very small ones.\n""Adjust this to find the balance between GPU acceleration and CPU overhead."));- INSERT(Settings,- gpu_unswizzle_stream_size,- tr("GPU Unswizzle Stream Size"),+ INSERT(Settings, gpu_unswizzle_stream_size, tr("GPU Unswizzle Stream Size"),tr("Sets the maximum amount of texture data (in MiB) processed per frame.\n"- "Higher values can reduce stutter during texture loading but may impact frame consistency."));- INSERT(Settings,- gpu_unswizzle_chunk_size,- tr("GPU Unswizzle Chunk Size"),+ "Higher values can reduce stutter during texture loading but may impact frame "+ "consistency."));+ INSERT(Settings, gpu_unswizzle_chunk_size, tr("GPU Unswizzle Chunk Size"),tr("Determines the number of depth slices processed in a single dispatch.\n"- "Increasing this can improve throughput on high-end GPUs but may cause TDR or driver timeouts on weaker hardware."));+ "Increasing this can improve throughput on high-end GPUs but may cause TDR or driver "+ "timeouts on weaker hardware."));- INSERT(Settings,- use_vulkan_driver_pipeline_cache,- tr("Use Vulkan pipeline cache"),+ INSERT(Settings, use_vulkan_driver_pipeline_cache, tr("Use Vulkan pipeline cache"),tr("Enables GPU vendor-specific pipeline cache.\nThis option can improve shader loading ""time significantly in cases where the Vulkan driver does not store pipeline cache ""files internally."));+ INSERT(Settings, enable_compute_pipelines, tr("Enable Compute Pipelines (Intel Vulkan Only)"),+ tr("Required by some games.\nThis setting only exists for Intel "+ "proprietary drivers and may crash if enabled.\nCompute pipelines are always enabled "+ "on all other drivers."));INSERT(- Settings,- enable_compute_pipelines,- tr("Enable Compute Pipelines (Intel Vulkan Only)"),- tr("Required by some games.\nThis setting only exists for Intel "- "proprietary drivers and may crash if enabled.\nCompute pipelines are always enabled "- "on all other drivers."));- INSERT(- Settings,- use_reactive_flushing,- tr("Enable Reactive Flushing"),+ Settings, use_reactive_flushing, tr("Enable Reactive Flushing"),tr("Uses reactive flushing instead of predictive flushing, allowing more accurate memory ""syncing."));- INSERT(Settings,- use_video_framerate,- tr("Sync to framerate of video playback"),+ INSERT(Settings, use_video_framerate, tr("Sync to framerate of video playback"),tr("Run the game at normal speed during video playback, even when the framerate is ""unlocked."));- INSERT(Settings,- barrier_feedback_loops,- tr("Barrier feedback loops"),+ INSERT(Settings, barrier_feedback_loops, tr("Barrier feedback loops"),tr("Improves rendering of transparency effects in specific games."));- INSERT(Settings,- enable_buffer_history,- tr("Enable buffer history"),- tr("Enables access to previous buffer states.\nThis option may improve rendering quality and performance consistency in some games."));- INSERT(Settings,- fix_bloom_effects,- tr("Fix bloom effects"),- tr("Removes bloom in Burnout."));-- INSERT(Settings,- rescale_hack,- tr("Enable Legacy Rescale Pass"),- tr("May fix rescale issues in some games by relying on behavior from the previous implementation.\n"- "Legacy behavior workaround that fixes line artifacts on AMD and Intel GPUs, and grey texture flicker on Nvidia GPUs in Luigis Mansion 3."));+ INSERT(Settings, enable_buffer_history, tr("Enable buffer history"),+ tr("Enables access to previous buffer states.\nThis option may improve rendering "+ "quality and performance consistency in some games."));+ INSERT(Settings, fix_bloom_effects, tr("Fix bloom effects"), tr("Removes bloom in Burnout."));++ INSERT(Settings, rescale_hack, tr("Enable Legacy Rescale Pass"),+ tr("May fix rescale issues in some games by relying on behavior from the previous "+ "implementation.\n"+ "Legacy behavior workaround that fixes line artifacts on AMD and Intel GPUs, and "+ "grey texture flicker on Nvidia GPUs in Luigis Mansion 3."));// Renderer (Extensions)INSERT(Settings, dyna_state, tr("Extended Dynamic State"),@@ -368,59 +287,42 @@ std::unique_ptr<TranslationMap> InitializeTranslations(QObject* parent)"Higher states allow for more features and can increase performance, but may cause ""additional graphical issues."));- INSERT(Settings,- vertex_input_dynamic_state,- tr("Vertex Input Dynamic State"),+ INSERT(Settings, vertex_input_dynamic_state, tr("Vertex Input Dynamic State"),tr("Enables vertex input dynamic state feature for better quality and performance."));- INSERT(Settings,- provoking_vertex,- tr("Provoking Vertex"),+ INSERT(Settings, provoking_vertex, tr("Provoking Vertex"),tr("Improves lighting and vertex handling in some games.\n""Only Vulkan 1.0+ devices support this extension."));- INSERT(Settings,- descriptor_indexing,- tr("Descriptor Indexing"),+ INSERT(Settings, descriptor_indexing, tr("Descriptor Indexing"),tr("Improves texture & buffer handling and the Maxwell translation layer.\n""Some Vulkan 1.1+ and all 1.2+ devices support this extension."));- INSERT(Settings,- sample_shading,- tr("Sample Shading"),- tr("Allows the fragment shader to execute per sample in a multi-sampled fragment "- "instead of once per fragment. Improves graphics quality at the cost of performance.\n"- "Higher values improve quality but degrade performance."));+ INSERT(+ Settings, sample_shading, tr("Sample Shading"),+ tr("Allows the fragment shader to execute per sample in a multi-sampled fragment "+ "instead of once per fragment. Improves graphics quality at the cost of performance.\n"+ "Higher values improve quality but degrade performance."));// Renderer (Debug)// System- INSERT(Settings,- rng_seed,- tr("RNG Seed"),+ INSERT(Settings, rng_seed, tr("RNG Seed"),tr("Controls the seed of the random number generator.\nMainly used for speedrunning."));INSERT(Settings, rng_seed_enabled, QString(), QString());INSERT(Settings, device_name, tr("Device Name"), tr("The name of the console."));- INSERT(Settings,- custom_rtc,- tr("Custom RTC Date:"),+ INSERT(Settings, custom_rtc, tr("Custom RTC Date:"),tr("This option allows to change the clock of the console.\n""Can be used to manipulate time in games."));INSERT(Settings, custom_rtc_enabled, QString(), QString());- INSERT(Settings,- custom_rtc_offset,- QStringLiteral(" "),+ INSERT(Settings, custom_rtc_offset, QStringLiteral(" "),tr("The number of seconds from the current unix time"));- INSERT(Settings,- language_index,- tr("Language:"),+ INSERT(Settings, language_index, tr("Language:"),tr("This option can be overridden when region setting is auto-select"));INSERT(Settings, region_index, tr("Region:"), tr("The region of the console."));INSERT(Settings, time_zone_index, tr("Time Zone:"), tr("The time zone of the console."));INSERT(Settings, sound_index, tr("Sound Output Mode:"), QString());- INSERT(Settings,- use_docked_mode,- tr("Console Mode:"),+ INSERT(Settings, use_docked_mode, tr("Console Mode:"),tr("Selects if the console is in Docked or Handheld mode.\nGames will change ""their resolution, details and supported controllers and depending on this setting.\n""Setting to Handheld can help improve performance for low end systems."));@@ -444,31 +346,19 @@ std::unique_ptr<TranslationMap> InitializeTranslations(QObject* parent)// Ui// Ui General- INSERT(UISettings,- select_user_on_boot,- tr("Prompt for user profile on boot"),+ INSERT(UISettings, select_user_on_boot, tr("Prompt for user profile on boot"),tr("Useful if multiple people use the same PC."));- INSERT(UISettings,- pause_when_in_background,- tr("Pause when not in focus"),+ INSERT(UISettings, pause_when_in_background, tr("Pause when not in focus"),tr("Pauses emulation when focusing on other windows."));- INSERT(UISettings,- confirm_before_stopping,- tr("Confirm before stopping emulation"),+ INSERT(UISettings, confirm_before_stopping, tr("Confirm before stopping emulation"),tr("Overrides prompts asking to confirm stopping the emulation.\nEnabling ""it bypasses such prompts and directly exits the emulation."));- INSERT(UISettings,- hide_mouse,- tr("Hide mouse on inactivity"),+ INSERT(UISettings, hide_mouse, tr("Hide mouse on inactivity"),tr("Hides the mouse after 2.5s of inactivity."));- INSERT(UISettings,- controller_applet_disabled,- tr("Disable controller applet"),+ INSERT(UISettings, controller_applet_disabled, tr("Disable controller applet"),tr("Forcibly disables the use of the controller applet in emulated programs.\n"- "When a program attempts to open the controller applet, it is immediately closed."));- INSERT(UISettings,- check_for_updates,- tr("Check for updates"),+ "When a program attempts to open the controller applet, it is immediately closed."));+ INSERT(UISettings, check_for_updates, tr("Check for updates"),tr("Whether or not to check for updates upon startup."));// Linux@@ -489,9 +379,9 @@ std::unique_ptr<TranslationMap> InitializeTranslations(QObject* parent)return translations;}-std::unique_ptr<ComboboxTranslationMap> ComboboxEnumeration(QObject* parent)-{- std::unique_ptr<ComboboxTranslationMap> translations = std::make_unique<ComboboxTranslationMap>();+std::unique_ptr<ComboboxTranslationMap> ComboboxEnumeration(QObject* parent) {+ std::unique_ptr<ComboboxTranslationMap> translations =+ std::make_unique<ComboboxTranslationMap>();const auto& tr = [&](const char* text, const char* context = "") {return parent->tr(text, context);};@@ -537,15 +427,15 @@ std::unique_ptr<ComboboxTranslationMap> ComboboxEnumeration(QObject* parent)PAIR(VramUsageMode, Conservative, tr("Conservative")),PAIR(VramUsageMode, Aggressive, tr("Aggressive")),}});- translations->insert({Settings::EnumMetadata<Settings::RendererBackend>::Index(), {- PAIR(RendererBackend, Vulkan, tr("Vulkan")),+ translations->insert(+ {Settings::EnumMetadata<Settings::RendererBackend>::Index(),+ {PAIR(RendererBackend, Vulkan, tr("Vulkan")),#ifdef HAS_OPENGL- PAIR(RendererBackend, OpenGL_GLSL, tr("OpenGL GLSL")),- PAIR(RendererBackend, OpenGL_GLASM, tr("OpenGL GLASM (Assembly Shaders, NVIDIA Only)")),- PAIR(RendererBackend, OpenGL_SPIRV, tr("OpenGL SPIR-V (Experimental, AMD/Mesa Only)")),+ PAIR(RendererBackend, OpenGL_GLSL, tr("OpenGL GLSL")),+ PAIR(RendererBackend, OpenGL_GLASM, tr("OpenGL GLASM (Assembly Shaders, NVIDIA Only)")),+ PAIR(RendererBackend, OpenGL_SPIRV, tr("OpenGL SPIR-V (Experimental, AMD/Mesa Only)")),#endif- PAIR(RendererBackend, Null, tr("Null"))- }});+ PAIR(RendererBackend, Null, tr("Null"))}});translations->insert({Settings::EnumMetadata<Settings::GpuAccuracy>::Index(),{PAIR(GpuAccuracy, Low, tr("Fast")),@@ -679,58 +569,58 @@ std::unique_ptr<ComboboxTranslationMap> ComboboxEnumeration(QObject* parent)translations->insert({Settings::EnumMetadata<Settings::TimeZone>::Index(),{- {static_cast<u32>(Settings::TimeZone::Auto),- tr("Auto (%1)", "Auto select time zone")- .arg(QString::fromStdString(- Settings::GetTimeZoneString(Settings::TimeZone::Auto)))},- {static_cast<u32>(Settings::TimeZone::Default),- tr("Default (%1)", "Default time zone")- .arg(QString::fromStdString(Common::TimeZone::GetDefaultTimeZone()))},- PAIR(TimeZone, Cet, tr("CET")),- PAIR(TimeZone, Cst6Cdt, tr("CST6CDT")),- PAIR(TimeZone, Cuba, tr("Cuba")),- PAIR(TimeZone, Eet, tr("EET")),- PAIR(TimeZone, Egypt, tr("Egypt")),- PAIR(TimeZone, Eire, tr("Eire")),- PAIR(TimeZone, Est, tr("EST")),- PAIR(TimeZone, Est5Edt, tr("EST5EDT")),- PAIR(TimeZone, Gb, tr("GB")),- PAIR(TimeZone, GbEire, tr("GB-Eire")),- PAIR(TimeZone, Gmt, tr("GMT")),- PAIR(TimeZone, GmtPlusZero, tr("GMT+0")),- PAIR(TimeZone, GmtMinusZero, tr("GMT-0")),- PAIR(TimeZone, GmtZero, tr("GMT0")),- PAIR(TimeZone, Greenwich, tr("Greenwich")),- PAIR(TimeZone, Hongkong, tr("Hongkong")),- PAIR(TimeZone, Hst, tr("HST")),- PAIR(TimeZone, Iceland, tr("Iceland")),- PAIR(TimeZone, Iran, tr("Iran")),- PAIR(TimeZone, Israel, tr("Israel")),- PAIR(TimeZone, Jamaica, tr("Jamaica")),- PAIR(TimeZone, Japan, tr("Japan")),- PAIR(TimeZone, Kwajalein, tr("Kwajalein")),- PAIR(TimeZone, Libya, tr("Libya")),- PAIR(TimeZone, Met, tr("MET")),- PAIR(TimeZone, Mst, tr("MST")),- PAIR(TimeZone, Mst7Mdt, tr("MST7MDT")),- PAIR(TimeZone, Navajo, tr("Navajo")),- PAIR(TimeZone, Nz, tr("NZ")),- PAIR(TimeZone, NzChat, tr("NZ-CHAT")),- PAIR(TimeZone, Poland, tr("Poland")),- PAIR(TimeZone, Portugal, tr("Portugal")),- PAIR(TimeZone, Prc, tr("PRC")),- PAIR(TimeZone, Pst8Pdt, tr("PST8PDT")),- PAIR(TimeZone, Roc, tr("ROC")),- PAIR(TimeZone, Rok, tr("ROK")),- PAIR(TimeZone, Singapore, tr("Singapore")),- PAIR(TimeZone, Turkey, tr("Turkey")),- PAIR(TimeZone, Uct, tr("UCT")),- PAIR(TimeZone, Universal, tr("Universal")),- PAIR(TimeZone, Utc, tr("UTC")),- PAIR(TimeZone, WSu, tr("W-SU")),- PAIR(TimeZone, Wet, tr("WET")),- PAIR(TimeZone, Zulu, tr("Zulu")),- }});+ {static_cast<u32>(Settings::TimeZone::Auto),+ tr("Auto (%1)", "Auto select time zone")+ .arg(QString::fromStdString(+ Settings::GetTimeZoneString(Settings::TimeZone::Auto)))},+ {static_cast<u32>(Settings::TimeZone::Default),+ tr("Default (%1)", "Default time zone")+ .arg(QString::fromStdString(Common::TimeZone::GetDefaultTimeZone()))},+ PAIR(TimeZone, Cet, tr("CET")),+ PAIR(TimeZone, Cst6Cdt, tr("CST6CDT")),+ PAIR(TimeZone, Cuba, tr("Cuba")),+ PAIR(TimeZone, Eet, tr("EET")),+ PAIR(TimeZone, Egypt, tr("Egypt")),+ PAIR(TimeZone, Eire, tr("Eire")),+ PAIR(TimeZone, Est, tr("EST")),+ PAIR(TimeZone, Est5Edt, tr("EST5EDT")),+ PAIR(TimeZone, Gb, tr("GB")),+ PAIR(TimeZone, GbEire, tr("GB-Eire")),+ PAIR(TimeZone, Gmt, tr("GMT")),+ PAIR(TimeZone, GmtPlusZero, tr("GMT+0")),+ PAIR(TimeZone, GmtMinusZero, tr("GMT-0")),+ PAIR(TimeZone, GmtZero, tr("GMT0")),+ PAIR(TimeZone, Greenwich, tr("Greenwich")),+ PAIR(TimeZone, Hongkong, tr("Hongkong")),+ PAIR(TimeZone, Hst, tr("HST")),+ PAIR(TimeZone, Iceland, tr("Iceland")),+ PAIR(TimeZone, Iran, tr("Iran")),+ PAIR(TimeZone, Israel, tr("Israel")),+ PAIR(TimeZone, Jamaica, tr("Jamaica")),+ PAIR(TimeZone, Japan, tr("Japan")),+ PAIR(TimeZone, Kwajalein, tr("Kwajalein")),+ PAIR(TimeZone, Libya, tr("Libya")),+ PAIR(TimeZone, Met, tr("MET")),+ PAIR(TimeZone, Mst, tr("MST")),+ PAIR(TimeZone, Mst7Mdt, tr("MST7MDT")),+ PAIR(TimeZone, Navajo, tr("Navajo")),+ PAIR(TimeZone, Nz, tr("NZ")),+ PAIR(TimeZone, NzChat, tr("NZ-CHAT")),+ PAIR(TimeZone, Poland, tr("Poland")),+ PAIR(TimeZone, Portugal, tr("Portugal")),+ PAIR(TimeZone, Prc, tr("PRC")),+ PAIR(TimeZone, Pst8Pdt, tr("PST8PDT")),+ PAIR(TimeZone, Roc, tr("ROC")),+ PAIR(TimeZone, Rok, tr("ROK")),+ PAIR(TimeZone, Singapore, tr("Singapore")),+ PAIR(TimeZone, Turkey, tr("Turkey")),+ PAIR(TimeZone, Uct, tr("UCT")),+ PAIR(TimeZone, Universal, tr("Universal")),+ PAIR(TimeZone, Utc, tr("UTC")),+ PAIR(TimeZone, WSu, tr("W-SU")),+ PAIR(TimeZone, Wet, tr("WET")),+ PAIR(TimeZone, Zulu, tr("Zulu")),+ }});translations->insert({Settings::EnumMetadata<Settings::AudioMode>::Index(),{PAIR(AudioMode, Mono, tr("Mono")),@@ -803,9 +693,9 @@ std::unique_ptr<ComboboxTranslationMap> ComboboxEnumeration(QObject* parent)}});translations->insert({Settings::EnumMetadata<Settings::GameListMode>::Index(),- {- PAIR(GameListMode, TreeView, tr("Tree View")),- PAIR(GameListMode, GridView, tr("Grid View")),+ {+ PAIR(GameListMode, TreeView, tr("Tree View")),+ PAIR(GameListMode, GridView, tr("Grid View")),}});#undef PAIRdiff --git a/src/qt_common/config/shared_translation.h b/src/qt_common/config/shared_translation.hindex 6fbeb1df6e..6529c7bf40 100644--- a/src/qt_common/config/shared_translation.h+++ b/src/qt_common/config/shared_translation.h@@ -13,8 +13,8 @@#include <memory>#include <utility>#include <vector>-#include <QString>#include <QObject>+#include <QString>#include "common/common_types.h"#include "common/settings_enums.h"@@ -23,7 +23,7 @@ using TranslationMap = std::map<u32, std::pair<QString, QString>>;using ComboboxTranslations = std::vector<std::pair<u32, QString>>;using ComboboxTranslationMap = std::map<u32, ComboboxTranslations>;-std::unique_ptr<TranslationMap> InitializeTranslations(QObject *parent);+std::unique_ptr<TranslationMap> InitializeTranslations(QObject* parent);std::unique_ptr<ComboboxTranslationMap> ComboboxEnumeration(QObject* parent);@@ -39,15 +39,15 @@ static const std::map<Settings::ScalingFilter, QString> scaling_filter_texts_map{Settings::ScalingFilter::Bilinear,QStringLiteral(QT_TRANSLATE_NOOP("MainWindow", "Bilinear"))},{Settings::ScalingFilter::Bicubic, QStringLiteral(QT_TRANSLATE_NOOP("MainWindow", "Bicubic"))},- {Settings::ScalingFilter::ZeroTangent, QStringLiteral(QT_TRANSLATE_NOOP("MainWindow", "Zero-Tangent"))},+ {Settings::ScalingFilter::ZeroTangent,+ QStringLiteral(QT_TRANSLATE_NOOP("MainWindow", "Zero-Tangent"))},{Settings::ScalingFilter::BSpline, QStringLiteral(QT_TRANSLATE_NOOP("MainWindow", "B-Spline"))},- {Settings::ScalingFilter::Mitchell, QStringLiteral(QT_TRANSLATE_NOOP("MainWindow", "Mitchell"))},- {Settings::ScalingFilter::Spline1,- QStringLiteral(QT_TRANSLATE_NOOP("MainWindow", "Spline-1"))},+ {Settings::ScalingFilter::Mitchell,+ QStringLiteral(QT_TRANSLATE_NOOP("MainWindow", "Mitchell"))},+ {Settings::ScalingFilter::Spline1, QStringLiteral(QT_TRANSLATE_NOOP("MainWindow", "Spline-1"))},{Settings::ScalingFilter::Gaussian,QStringLiteral(QT_TRANSLATE_NOOP("MainWindow", "Gaussian"))},- {Settings::ScalingFilter::Lanczos,- QStringLiteral(QT_TRANSLATE_NOOP("MainWindow", "Lanczos"))},+ {Settings::ScalingFilter::Lanczos, QStringLiteral(QT_TRANSLATE_NOOP("MainWindow", "Lanczos"))},{Settings::ScalingFilter::ScaleForce,QStringLiteral(QT_TRANSLATE_NOOP("MainWindow", "ScaleForce"))},{Settings::ScalingFilter::Fsr, QStringLiteral(QT_TRANSLATE_NOOP("MainWindow", "FSR"))},@@ -68,9 +68,12 @@ static const std::map<Settings::GpuAccuracy, QString> gpu_accuracy_texts_map = {static const std::map<Settings::RendererBackend, QString> renderer_backend_texts_map = {{Settings::RendererBackend::Vulkan, QStringLiteral(QT_TRANSLATE_NOOP("MainWindow", "Vulkan"))},- {Settings::RendererBackend::OpenGL_GLSL, QStringLiteral(QT_TRANSLATE_NOOP("MainWindow", "OpenGL GLSL"))},- {Settings::RendererBackend::OpenGL_SPIRV, QStringLiteral(QT_TRANSLATE_NOOP("MainWindow", "OpenGL SPIRV"))},- {Settings::RendererBackend::OpenGL_GLASM, QStringLiteral(QT_TRANSLATE_NOOP("MainWindow", "OpenGL GLASM"))},+ {Settings::RendererBackend::OpenGL_GLSL,+ QStringLiteral(QT_TRANSLATE_NOOP("MainWindow", "OpenGL GLSL"))},+ {Settings::RendererBackend::OpenGL_SPIRV,+ QStringLiteral(QT_TRANSLATE_NOOP("MainWindow", "OpenGL SPIRV"))},+ {Settings::RendererBackend::OpenGL_GLASM,+ QStringLiteral(QT_TRANSLATE_NOOP("MainWindow", "OpenGL GLASM"))},{Settings::RendererBackend::Null, QStringLiteral(QT_TRANSLATE_NOOP("MainWindow", "Null"))},};diff --git a/src/qt_common/config/uisettings.h b/src/qt_common/config/uisettings.hindex 49205c5b84..c2a14858dd 100644--- a/src/qt_common/config/uisettings.h+++ b/src/qt_common/config/uisettings.h@@ -145,14 +145,15 @@ struct Values {// Linux/MinGW may support (requires libdl support)SwitchableSetting<bool> enable_gamemode{linkage,#ifndef _MSC_VER- true,+ true,#else- false,+ false,#endif- "enable_gamemode", Category::UiGeneral};+ "enable_gamemode", Category::UiGeneral};#ifdef __unix__SwitchableSetting<bool> gui_force_x11{linkage, false, "gui_force_x11", Category::UiGeneral};- Setting<bool> gui_hide_backend_warning{linkage, false, "gui_hide_backend_warning", Category::UiGeneral};+ Setting<bool> gui_hide_backend_warning{linkage, false, "gui_hide_backend_warning",+ Category::UiGeneral};#endif// Discord RPC@@ -210,7 +211,8 @@ struct Values {Setting<u32> folder_icon_size{linkage, 48, "folder_icon_size", Category::UiGameList};Setting<u8> row_1_text_id{linkage, 3, "row_1_text_id", Category::UiGameList};Setting<u8> row_2_text_id{linkage, 2, "row_2_text_id", Category::UiGameList};- Setting<Settings::GameListMode> game_list_mode{linkage, Settings::GameListMode::TreeView, "game_list_mode", Category::UiGameList};+ Setting<Settings::GameListMode> game_list_mode{linkage, Settings::GameListMode::TreeView,+ "game_list_mode", Category::UiGameList};Setting<bool> show_game_name{linkage, true, "show_game_name", Category::UiGameList};std::atomic_bool is_game_list_reload_pending{false};diff --git a/src/qt_common/discord/discord_impl.cpp b/src/qt_common/discord/discord_impl.cppindex 82f805b888..37b24cdd57 100644--- a/src/qt_common/discord/discord_impl.cpp+++ b/src/qt_common/discord/discord_impl.cpp@@ -70,7 +70,9 @@ std::string DiscordImpl::GetGameString(const std::string& title) {}static constexpr char DEFAULT_DISCORD_TEXT[] = "Eden is an emulator for the Nintendo Switch";-static constexpr char DEFAULT_DISCORD_IMAGE[] = "https://git.eden-emu.dev/eden-emu/eden/raw/branch/master/dist/qt_themes/default/icons/256x256/eden.png";+static constexpr char DEFAULT_DISCORD_IMAGE[] =+ "https://git.eden-emu.dev/eden-emu/eden/raw/branch/master/dist/qt_themes/default/icons/256x256/"+ "eden.png";void DiscordImpl::UpdateGameStatus(bool use_default) {const std::string url = use_default ? std::string{DEFAULT_DISCORD_IMAGE} : game_url;@@ -120,7 +122,9 @@ void DiscordImpl::Update() {return;}- s64 start_time = std::chrono::duration_cast<std::chrono::seconds>(std::chrono::system_clock::now().time_since_epoch()).count();+ s64 start_time = std::chrono::duration_cast<std::chrono::seconds>(+ std::chrono::system_clock::now().time_since_epoch())+ .count();DiscordRichPresence presence{};presence.largeImageKey = DEFAULT_DISCORD_IMAGE;presence.largeImageText = DEFAULT_DISCORD_TEXT;diff --git a/src/qt_common/gamemode.cpp b/src/qt_common/gamemode.cppindex dae6676fee..b6ce5c2ca8 100644--- a/src/qt_common/gamemode.cpp+++ b/src/qt_common/gamemode.cpp@@ -9,9 +9,9 @@#ifdef __unix__#include <gamemode_client.h>#endif-#include "qt_common/gamemode.h"#include "common/logging/log.h"#include "qt_common/config/uisettings.h"+#include "qt_common/gamemode.h"namespace Common::FeralGamemode {@@ -49,4 +49,4 @@ void Stop() noexcept {}}-} // namespace Common::Linux+} // namespace Common::FeralGamemodediff --git a/src/qt_common/gui_settings.cpp b/src/qt_common/gui_settings.cppindex 4a1506261a..8b85fe43d6 100644--- a/src/qt_common/gui_settings.cpp+++ b/src/qt_common/gui_settings.cpp@@ -1,16 +1,17 @@// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later-#include "gui_settings.h"#include "common/fs/fs.h"#include "common/fs/path_util.h"+#include "gui_settings.h"namespace FS = Common::FS;namespace GraphicsBackend {QString GuiConfigPath() {- return QString::fromStdString(FS::PathToUTF8String(FS::GetEdenPath(FS::EdenPath::ConfigDir) / "gui_config.ini"));+ return QString::fromStdString(+ FS::PathToUTF8String(FS::GetEdenPath(FS::EdenPath::ConfigDir) / "gui_config.ini"));}void SetForceX11(bool state) {diff --git a/src/qt_common/qt_common.cpp b/src/qt_common/qt_common.cppindex 8954bf09f2..e886593780 100644--- a/src/qt_common/qt_common.cpp+++ b/src/qt_common/qt_common.cpp@@ -1,8 +1,8 @@// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later-#include "qt_common.h"#include "common/fs/fs.h"+#include "qt_common.h"#include <QGuiApplication>#include <QStringLiteral>@@ -28,8 +28,7 @@ std::unique_ptr<Core::System> system = nullptr;std::shared_ptr<FileSys::RealVfsFilesystem> vfs = nullptr;std::unique_ptr<FileSys::ManualContentProvider> provider = nullptr;-Core::Frontend::WindowSystemType GetWindowSystemType()-{+Core::Frontend::WindowSystemType GetWindowSystemType() {// Determine WSI type based on Qt platform.QString platform_name = QGuiApplication::platformName();if (platform_name == QStringLiteral("windows"))@@ -51,8 +50,7 @@ Core::Frontend::WindowSystemType GetWindowSystemType()return Core::Frontend::WindowSystemType::Windows;} // namespace Core::Frontend::WindowSystemType-Core::Frontend::EmuWindow::WindowSystemInfo GetWindowSystemInfo(QWindow* window)-{+Core::Frontend::EmuWindow::WindowSystemInfo GetWindowSystemInfo(QWindow* window) {Core::Frontend::EmuWindow::WindowSystemInfo wsi;wsi.type = GetWindowSystemType();@@ -60,8 +58,8 @@ Core::Frontend::EmuWindow::WindowSystemInfo GetWindowSystemInfo(QWindow* window)// Our Win32 Qt external doesn't have the private API.wsi.render_surface = reinterpret_cast<void*>(window->winId());#elif defined(__APPLE__)- id layer = reinterpret_cast<id (*) (id, SEL)>(- objc_msgSend)(reinterpret_cast<id>(window->winId()), sel_registerName("layer"));+ id layer = reinterpret_cast<id (*)(id, SEL)>(objc_msgSend)(+ reinterpret_cast<id>(window->winId()), sel_registerName("layer"));// In Qt 6, the layer of the NSView might be a QContainerLayer.// MoltenVK needs a CAMetalLayer. We search for it in sublayers.@@ -69,15 +67,20 @@ Core::Frontend::EmuWindow::WindowSystemInfo GetWindowSystemInfo(QWindow* window)id metal_layer = nullptr;if (layer) {- if (reinterpret_cast<bool (*) (id, SEL, Class)>(objc_msgSend)(layer, sel_registerName("isKindOfClass:"), metal_layer_class)) {+ if (reinterpret_cast<bool (*)(id, SEL, Class)>(objc_msgSend)(+ layer, sel_registerName("isKindOfClass:"), metal_layer_class)) {metal_layer = layer;} else {- id sublayers = reinterpret_cast<id (*) (id, SEL)>(objc_msgSend)(layer, sel_registerName("sublayers"));+ id sublayers = reinterpret_cast<id (*)(id, SEL)>(objc_msgSend)(+ layer, sel_registerName("sublayers"));if (sublayers) {- unsigned long count = reinterpret_cast<unsigned long (*) (id, SEL)>(objc_msgSend)(sublayers, sel_registerName("count"));+ unsigned long count = reinterpret_cast<unsigned long (*)(id, SEL)>(objc_msgSend)(+ sublayers, sel_registerName("count"));for (unsigned long i = 0; i < count; ++i) {- id sublayer = reinterpret_cast<id (*) (id, SEL, unsigned long)>(objc_msgSend)(sublayers, sel_registerName("objectAtIndex:"), i);- if (reinterpret_cast<bool (*) (id, SEL, Class)>(objc_msgSend)(sublayer, sel_registerName("isKindOfClass:"), metal_layer_class)) {+ id sublayer = reinterpret_cast<id (*)(id, SEL, unsigned long)>(objc_msgSend)(+ sublayers, sel_registerName("objectAtIndex:"), i);+ if (reinterpret_cast<bool (*)(id, SEL, Class)>(objc_msgSend)(+ sublayer, sel_registerName("isKindOfClass:"), metal_layer_class)) {metal_layer = sublayer;break;}@@ -99,26 +102,22 @@ Core::Frontend::EmuWindow::WindowSystemInfo GetWindowSystemInfo(QWindow* window)return wsi;}-const QString tr(const char* str)-{+const QString tr(const char* str) {return QGuiApplication::tr(str);}-const QString tr(const std::string& str)-{+const QString tr(const std::string& str) {return QGuiApplication::tr(str.c_str());}-void Init(QWidget* root)-{+void Init(QWidget* root) {system = std::make_unique<Core::System>();rootObject = root;vfs = std::make_unique<FileSys::RealVfsFilesystem>();provider = std::make_unique<FileSys::ManualContentProvider>();}-std::filesystem::path GetEdenCommand()-{+std::filesystem::path GetEdenCommand() {std::filesystem::path command;// TODO: flatpak?diff --git a/src/qt_common/qt_common.h b/src/qt_common/qt_common.hindex 9c7816a2ed..19c09ef5d0 100644--- a/src/qt_common/qt_common.h+++ b/src/qt_common/qt_common.h@@ -4,17 +4,17 @@#ifndef QT_COMMON_H#define QT_COMMON_H+#include <memory>#include <QWindow>+#include <core/frontend/emu_window.h>#include "core/core.h"#include "core/file_sys/registered_cache.h"-#include <core/frontend/emu_window.h>-#include <memory>#include <core/file_sys/vfs/vfs_real.h>namespace QtCommon {-extern QWidget *rootObject;+extern QWidget* rootObject;extern std::unique_ptr<Core::System> system;extern std::shared_ptr<FileSys::RealVfsFilesystem> vfs;@@ -24,12 +24,12 @@ typedef std::function<bool(std::size_t, std::size_t)> QtProgressCallback;Core::Frontend::WindowSystemType GetWindowSystemType();-Core::Frontend::EmuWindow::WindowSystemInfo GetWindowSystemInfo(QWindow *window);+Core::Frontend::EmuWindow::WindowSystemInfo GetWindowSystemInfo(QWindow* window);-void Init(QWidget *root);+void Init(QWidget* root);-const QString tr(const char *str);-const QString tr(const std::string &str);+const QString tr(const char* str);+const QString tr(const std::string& str);std::filesystem::path GetEdenCommand();} // namespace QtCommondiff --git a/src/qt_common/qt_string_lookup.h b/src/qt_common/qt_string_lookup.hindex 5b7dbd5f0c..daefe20a1a 100644--- a/src/qt_common/qt_string_lookup.h+++ b/src/qt_common/qt_string_lookup.h@@ -11,8 +11,9 @@/// Small helper to look up enums./// res = the result code/// base = the base matching value in the StringKey table-#define LOOKUP_ENUM(res, base) QtCommon::StringLookup::Lookup( \- QtCommon::StringLookup::StringKey((int) res + (int) QtCommon::StringLookup::base))+#define LOOKUP_ENUM(res, base) \+ QtCommon::StringLookup::Lookup( \+ QtCommon::StringLookup::StringKey((int)res + (int)QtCommon::StringLookup::base))namespace QtCommon::StringLookup {@@ -111,16 +112,14 @@ static const constexpr frozen::map<StringKey, frozen::string, 29> strings = {QT_TR_NOOP("Would you like to migrate your data for use in Eden?\n""Select the corresponding button to migrate data from that emulator.\n""This may take a while.")},- {MigrationTooltipClearShader,- QT_TR_NOOP("Clearing shader cache is recommended for all "- "users.\nDo not uncheck unless you know what "- "you're doing.")},+ {MigrationTooltipClearShader, QT_TR_NOOP("Clearing shader cache is recommended for all "+ "users.\nDo not uncheck unless you know what "+ "you're doing.")},{MigrationTooltipKeepOld,QT_TR_NOOP("Keeps the old data directory. This is recommended if you aren't\n""space-constrained and want to keep separate data for the old emulator.")},- {MigrationTooltipClearOld,- QT_TR_NOOP("Deletes the old data directory.\nThis is recommended on "- "devices with space constraints.")},+ {MigrationTooltipClearOld, QT_TR_NOOP("Deletes the old data directory.\nThis is recommended on "+ "devices with space constraints.")},{MigrationTooltipLinkOld,QT_TR_NOOP("Creates a filesystem link between the old directory and Eden directory.\n""This is recommended if you want to share data between emulators.")},@@ -135,8 +134,7 @@ static const constexpr frozen::map<StringKey, frozen::string, 29> strings = {{RyujinxNoSaveId, QT_TR_NOOP("Title %1 not found in Ryujinx title database.")},};-static inline const QString Lookup(StringKey key)-{+static inline const QString Lookup(StringKey key) {return QObject::tr(strings.at(key).data());}diff --git a/src/qt_common/util/applet.h b/src/qt_common/util/applet.hindex 34183274ff..f88aa066b2 100644--- a/src/qt_common/util/applet.h+++ b/src/qt_common/util/applet.h@@ -5,7 +5,5 @@#define QT_APPLET_UTIL_H// TODO-namespace QtCommon::Applets {--}+namespace QtCommon::Applets {}#endif // QT_APPLET_UTIL_Hdiff --git a/src/qt_common/util/compress.cpp b/src/qt_common/util/compress.cppindex 527640cb98..c86e190bee 100644--- a/src/qt_common/util/compress.cpp+++ b/src/qt_common/util/compress.cpp@@ -10,11 +10,8 @@/** This is a modified version of JlCompress **/namespace QtCommon::Compress {-bool compressDir(QString fileCompressed,- QString dir,- const Options &options,- QtCommon::QtProgressCallback callback)-{+bool compressDir(QString fileCompressed, QString dir, const Options& options,+ QtCommon::QtProgressCallback callback) {// Create zipQuaZip zip(fileCompressed);QDir().mkpath(QFileInfo(fileCompressed).absolutePath());@@ -26,8 +23,7 @@ bool compressDir(QString fileCompressed,// See how big the overall fs structure is// good approx. of total progress// TODO(crueter): QDirListing impl... or fs::recursive_dir_iterator- QDirIterator iter(dir,- QDir::NoDotAndDotDot | QDir::Hidden | QDir::Files,+ QDirIterator iter(dir, QDir::NoDotAndDotDot | QDir::Hidden | QDir::Files,QDirIterator::Subdirectories);std::size_t total = 0;@@ -54,14 +50,8 @@ bool compressDir(QString fileCompressed,return true;}-bool compressSubDir(QuaZip *zip,- QString dir,- QString origDir,- const Options &options,- std::size_t total,- std::size_t &progress,- QtProgressCallback callback)-{+bool compressSubDir(QuaZip* zip, QString dir, QString origDir, const Options& options,+ std::size_t total, std::size_t& progress, QtProgressCallback callback) {// zip: object where to add the file// dir: current real directory// origDir: original real directory@@ -69,22 +59,20 @@ bool compressSubDir(QuaZip *zip,if (!zip)return false;- if (zip->getMode() != QuaZip::mdCreate && zip->getMode() != QuaZip::mdAppend- && zip->getMode() != QuaZip::mdAdd)+ if (zip->getMode() != QuaZip::mdCreate && zip->getMode() != QuaZip::mdAppend &&+ zip->getMode() != QuaZip::mdAdd)return false;QDir directory(dir);if (!directory.exists())return false;-QDir origDirectory(origDir);if (dir != origDir) {QuaZipFile dirZipFile(zip);std::unique_ptr<QuaZipNewInfo> qzni;- qzni = std::make_unique<QuaZipNewInfo>(origDirectory.relativeFilePath(dir)- + QLatin1String("/"),- dir);+ qzni = std::make_unique<QuaZipNewInfo>(+ origDirectory.relativeFilePath(dir) + QLatin1String("/"), dir);if (!dirZipFile.open(QIODevice::WriteOnly, *qzni, nullptr, 0, 0)) {return false;}@@ -92,18 +80,18 @@ bool compressSubDir(QuaZip *zip,}// For each subfolder- QFileInfoList subfiles = directory.entryInfoList(QDir::AllDirs | QDir::NoDotAndDotDot- | QDir::Hidden | QDir::Dirs);- for (const auto &file : std::as_const(subfiles)) {- if (!compressSubDir(- zip, file.absoluteFilePath(), origDir, options, total, progress, callback)) {+ QFileInfoList subfiles =+ directory.entryInfoList(QDir::AllDirs | QDir::NoDotAndDotDot | QDir::Hidden | QDir::Dirs);+ for (const auto& file : std::as_const(subfiles)) {+ if (!compressSubDir(zip, file.absoluteFilePath(), origDir, options, total, progress,+ callback)) {return false;}}// For each file in directoryQFileInfoList files = directory.entryInfoList(QDir::Hidden | QDir::Files);- for (const auto &file : std::as_const(files)) {+ for (const auto& file : std::as_const(files)) {// If it's not a file or it's the compressed file being createdif (!file.isFile() || file.absoluteFilePath() == zip->getZipName())continue;@@ -112,7 +100,8 @@ bool compressSubDir(QuaZip *zip,QString filename = origDirectory.relativeFilePath(file.absoluteFilePath());// Compress the file- if (!compressFile(zip, file.absoluteFilePath(), filename, options, total, progress, callback)) {+ if (!compressFile(zip, file.absoluteFilePath(), filename, options, total, progress,+ callback)) {return false;}}@@ -120,40 +109,26 @@ bool compressSubDir(QuaZip *zip,return true;}-bool compressFile(QuaZip *zip,- QString fileName,- QString fileDest,- const Options &options,- std::size_t total,- std::size_t &progress,- QtCommon::QtProgressCallback callback)-{+bool compressFile(QuaZip* zip, QString fileName, QString fileDest, const Options& options,+ std::size_t total, std::size_t& progress, QtCommon::QtProgressCallback callback) {// zip: object where to add the file// fileName: real file name// fileDest: file name inside the zip objectif (!zip)return false;- if (zip->getMode() != QuaZip::mdCreate && zip->getMode() != QuaZip::mdAppend- && zip->getMode() != QuaZip::mdAdd)+ if (zip->getMode() != QuaZip::mdCreate && zip->getMode() != QuaZip::mdAppend &&+ zip->getMode() != QuaZip::mdAdd)return false;QuaZipFile outFile(zip);if (options.getDateTime().isNull()) {- if (!outFile.open(QIODevice::WriteOnly,- QuaZipNewInfo(fileDest, fileName),- nullptr,- 0,- options.getCompressionMethod(),- options.getCompressionLevel()))+ if (!outFile.open(QIODevice::WriteOnly, QuaZipNewInfo(fileDest, fileName), nullptr, 0,+ options.getCompressionMethod(), options.getCompressionLevel()))return false;} else {- if (!outFile.open(QIODevice::WriteOnly,- QuaZipNewInfo(fileDest, fileName),- nullptr,- 0,- options.getCompressionMethod(),- options.getCompressionLevel()))+ if (!outFile.open(QIODevice::WriteOnly, QuaZipNewInfo(fileDest, fileName), nullptr, 0,+ options.getCompressionMethod(), options.getCompressionLevel()))return false;}@@ -171,7 +146,8 @@ bool compressFile(QuaZip *zip,if (!inFile.open(QIODevice::ReadOnly)) {return false;}- if (!copyData(inFile, outFile, total, progress, callback) || outFile.getZipError() != UNZ_OK) {+ if (!copyData(inFile, outFile, total, progress, callback) ||+ outFile.getZipError() != UNZ_OK) {return false;}inFile.close();@@ -181,12 +157,8 @@ bool compressFile(QuaZip *zip,return outFile.getZipError() == UNZ_OK;}-bool copyData(QIODevice &inFile,- QIODevice &outFile,- std::size_t total,- std::size_t &progress,- QtProgressCallback callback)-{+bool copyData(QIODevice& inFile, QIODevice& outFile, std::size_t total, std::size_t& progress,+ QtProgressCallback callback) {while (!inFile.atEnd()) {char buf[4096];qint64 readLen = inFile.read(buf, 4096);@@ -203,15 +175,13 @@ bool copyData(QIODevice &inFile,return true;}-QStringList extractDir(QString fileCompressed, QString dir, QtCommon::QtProgressCallback callback)-{+QStringList extractDir(QString fileCompressed, QString dir, QtCommon::QtProgressCallback callback) {// Open zipQuaZip zip(fileCompressed);return extractDir(zip, dir, callback);}-QStringList extractDir(QuaZip &zip, const QString &dir, QtCommon::QtProgressCallback callback)-{+QStringList extractDir(QuaZip& zip, const QString& dir, QtCommon::QtProgressCallback callback) {if (!zip.open(QuaZip::mdUnzip)) {return QStringList();}@@ -226,7 +196,7 @@ QStringList extractDir(QuaZip &zip, const QString &dir, QtCommon::QtProgressCall}std::size_t total = 0;- for (const QuaZipFileInfo64 &info : zip.getFileInfoList64()) {+ for (const QuaZipFileInfo64& info : zip.getFileInfoList64()) {total += info.uncompressedSize;}@@ -256,13 +226,8 @@ QStringList extractDir(QuaZip &zip, const QString &dir, QtCommon::QtProgressCallreturn extracted;}-bool extractFile(QuaZip *zip,- QString fileName,- QString fileDest,- std::size_t total,- std::size_t &progress,- QtCommon::QtProgressCallback callback)-{+bool extractFile(QuaZip* zip, QString fileName, QString fileDest, std::size_t total,+ std::size_t& progress, QtCommon::QtProgressCallback callback) {// zip: object where to add the file// filename: real file name// fileincompress: file name of the compressed file@@ -334,8 +299,7 @@ bool extractFile(QuaZip *zip,return true;}-bool removeFile(QStringList listFile)-{+bool removeFile(QStringList listFile) {bool ret = true;// For each filefor (int i = 0; i < listFile.count(); i++) {diff --git a/src/qt_common/util/compress.h b/src/qt_common/util/compress.hindex a16c6bff1a..640dcad420 100644--- a/src/qt_common/util/compress.h+++ b/src/qt_common/util/compress.h@@ -5,9 +5,9 @@#include <QDir>#include <QString>-#include "qt_common/qt_common.h"#include <quazip.h>#include <zlib.h>+#include "qt_common/qt_common.h"/** This is a modified version of JlCompress **/namespace QtCommon::Compress {@@ -15,49 +15,49 @@ namespace QtCommon::Compress {class Options {public:/**- * The enum values refer to the comments in the open function of the quazipfile.h file.- *- * The value is represented by two hexadecimal characters,- * the left character indicating the compression method,- * and the right character indicating the compression level.- *- * method == 0 indicates that the file is not compressed but rather stored as is.- * method == 8(Z_DEFLATED) indicates that zlib compression is used.- *- * A higher value of level indicates a smaller size of the compressed file,- * although it also implies more time consumed during the compression process.- */- enum CompressionStrategy- {+ * The enum values refer to the comments in the open function of the quazipfile.h file.+ *+ * The value is represented by two hexadecimal characters,+ * the left character indicating the compression method,+ * and the right character indicating the compression level.+ *+ * method == 0 indicates that the file is not compressed but rather stored as is.+ * method == 8(Z_DEFLATED) indicates that zlib compression is used.+ *+ * A higher value of level indicates a smaller size of the compressed file,+ * although it also implies more time consumed during the compression process.+ */+ enum CompressionStrategy {/// Storage without compression- Storage = 0x00, // Z_NO_COMPRESSION 0- /// The fastest compression speed- Fastest = 0x81, // Z_BEST_SPEED 1- /// Relatively fast compression speed- Faster = 0x83,+ Storage = 0x00, // Z_NO_COMPRESSION 0+ /// The fastest compression speed+ Fastest = 0x81, // Z_BEST_SPEED 1+ /// Relatively fast compression speed+ Faster = 0x83,/// Standard compression speed and ratioStandard = 0x86,/// Better compression ratio- Better = 0x87,+ Better = 0x87,/// The best compression ratio- Best = 0x89, // Z_BEST_COMPRESSION 9- /// The default compression strategy, according to the open function of quazipfile.h,- /// the value of method is Z_DEFLATED, and the value of level is Z_DEFAULT_COMPRESSION -1 (equals lvl 6)- Default = 0xff+ Best = 0x89, // Z_BEST_COMPRESSION 9+ /// The default compression strategy, according to the open function of+ /// quazipfile.h, the value of method is Z_DEFLATED, and the value of level is+ /// Z_DEFAULT_COMPRESSION -1 (equals lvl 6)+ Default = 0xff};public:- explicit Options(const CompressionStrategy& strategy)- : m_compressionStrategy(strategy) {}+ explicit Options(const CompressionStrategy& strategy) : m_compressionStrategy(strategy) {}- explicit Options(const QDateTime& dateTime = QDateTime(), const CompressionStrategy& strategy = Default)+ explicit Options(const QDateTime& dateTime = QDateTime(),+ const CompressionStrategy& strategy = Default): m_dateTime(dateTime), m_compressionStrategy(strategy) {}QDateTime getDateTime() const {return m_dateTime;}- void setDateTime(const QDateTime &dateTime) {+ void setDateTime(const QDateTime& dateTime) {m_dateTime = dateTime;}@@ -70,10 +70,11 @@ public:}int getCompressionLevel() const {- return m_compressionStrategy != Default ? m_compressionStrategy & 0x0f : Z_DEFAULT_COMPRESSION;+ return m_compressionStrategy != Default ? m_compressionStrategy & 0x0f+ : Z_DEFAULT_COMPRESSION;}- void setCompressionStrategy(const CompressionStrategy &strategy) {+ void setCompressionStrategy(const CompressionStrategy& strategy) {m_compressionStrategy = strategy;}@@ -89,34 +90,21 @@ private:* @param fileCompressed Destination file* @param dir The directory to compress* @param options Compression level, etc- * @param callback Callback that takes in two std::size_t (total, progress) and returns false if the current operation should be cancelled.+ * @param callback Callback that takes in two std::size_t (total, progress) and returns false+ * if the current operation should be cancelled.*/-bool compressDir(QString fileCompressed,- QString dir,- const Options& options = Options(),+bool compressDir(QString fileCompressed, QString dir, const Options& options = Options(),QtCommon::QtProgressCallback callback = {});// Internal //-bool compressSubDir(QuaZip *zip,- QString dir,- QString origDir,- const Options &options,- std::size_t total,- std::size_t &progress,+bool compressSubDir(QuaZip* zip, QString dir, QString origDir, const Options& options,+ std::size_t total, std::size_t& progress,QtCommon::QtProgressCallback callback);-bool compressFile(QuaZip *zip,- QString fileName,- QString fileDest,- const Options &options,- std::size_t total,- std::size_t &progress,- QtCommon::QtProgressCallback callback);--bool copyData(QIODevice &inFile,- QIODevice &outFile,- std::size_t total,- std::size_t &progress,+bool compressFile(QuaZip* zip, QString fileName, QString fileDest, const Options& options,+ std::size_t total, std::size_t& progress, QtCommon::QtProgressCallback callback);++bool copyData(QIODevice& inFile, QIODevice& outFile, std::size_t total, std::size_t& progress,QtCommon::QtProgressCallback callback);// Extract //@@ -125,20 +113,18 @@ bool copyData(QIODevice &inFile,* @brief Extract a zip file and report its progress.* @param fileCompressed Compressed file* @param dir The directory to push the results to- * @param callback Callback that takes in two std::size_t (total, progress) and returns false if the current operation should be cancelled.+ * @param callback Callback that takes in two std::size_t (total, progress) and returns false+ * if the current operation should be cancelled.*/-QStringList extractDir(QString fileCompressed, QString dir, QtCommon::QtProgressCallback callback = {});+QStringList extractDir(QString fileCompressed, QString dir,+ QtCommon::QtProgressCallback callback = {});// Internal //-QStringList extractDir(QuaZip &zip, const QString &dir, QtCommon::QtProgressCallback callback);+QStringList extractDir(QuaZip& zip, const QString& dir, QtCommon::QtProgressCallback callback);-bool extractFile(QuaZip *zip,- QString fileName,- QString fileDest,- std::size_t total,- std::size_t &progress,- QtCommon::QtProgressCallback callback);+bool extractFile(QuaZip* zip, QString fileName, QString fileDest, std::size_t total,+ std::size_t& progress, QtCommon::QtProgressCallback callback);bool removeFile(QStringList listFile);-}+} // namespace QtCommon::Compressdiff --git a/src/qt_common/util/content.cpp b/src/qt_common/util/content.cppindex dd095a40a4..4d9b324608 100644--- a/src/qt_common/util/content.cpp+++ b/src/qt_common/util/content.cpp@@ -15,17 +15,16 @@#include "qt_common/abstract/progress.h"#include "qt_common/qt_common.h"+#include <JlCompress.h>#include <QFuture>#include <QFutureWatcher>#include <QtConcurrentRun>-#include <JlCompress.h>namespace QtCommon::Content {-bool CheckGameFirmware(u64 program_id)-{- if (FirmwareManager::GameRequiresFirmware(program_id)- && !FirmwareManager::CheckFirmwarePresence(*system)) {+bool CheckGameFirmware(u64 program_id) {+ if (FirmwareManager::GameRequiresFirmware(program_id) &&+ !FirmwareManager::CheckFirmwarePresence(*system)) {auto result = QtCommon::Frontend::Warning(tr("Game Requires Firmware"),tr("The game you are trying to launch requires firmware to boot or to get past the "@@ -39,11 +38,10 @@ bool CheckGameFirmware(u64 program_id)return true;}-void InstallFirmware(const QString& location, bool recursive)-{+void InstallFirmware(const QString& location, bool recursive) {// Initialize a progress dialog.- auto progress = QtCommon::Frontend::newProgressDialog(tr("Installing Firmware..."),- tr("Cancel"), 0, 100);+ auto progress =+ QtCommon::Frontend::newProgressDialog(tr("Installing Firmware..."), tr("Cancel"), 0, 100);progress->show();QGuiApplication::processEvents();@@ -61,9 +59,7 @@ void InstallFirmware(const QString& location, bool recursive)FirmwareInstallResult result;const auto ShowMessage = [&]() {- QtCommon::Frontend::ShowMessage(icon,- failedTitle,- GetFirmwareInstallResultString(result));+ QtCommon::Frontend::ShowMessage(icon, failedTitle, GetFirmwareInstallResultString(result));};LOG_INFO(Frontend, "Installing firmware from {}", location.toStdString());@@ -88,12 +84,10 @@ void InstallFirmware(const QString& location, bool recursive)callback(100, 10);if (recursive) {- Common::FS::IterateDirEntriesRecursively(firmware_source_path,- dir_callback,+ Common::FS::IterateDirEntriesRecursively(firmware_source_path, dir_callback,Common::FS::DirEntryFilter::File);} else {- Common::FS::IterateDirEntries(firmware_source_path,- dir_callback,+ Common::FS::IterateDirEntries(firmware_source_path, dir_callback,Common::FS::DirEntryFilter::File);}@@ -106,8 +100,8 @@ void InstallFirmware(const QString& location, bool recursive)// Locate and erase the content of nand/system/Content/registered/*.nca, if any.auto sysnand_content_vdir = system->GetFileSystemController().GetSystemNANDContentDirectory();- if (sysnand_content_vdir->IsWritable()- && !sysnand_content_vdir->CleanSubdirectoryRecursive("registered")) {+ if (sysnand_content_vdir->IsWritable() &&+ !sysnand_content_vdir->CleanSubdirectoryRecursive("registered")) {result = FirmwareInstallResult::FailedDelete;icon = QtCommon::Frontend::Icon::Critical;ShowMessage();@@ -125,16 +119,14 @@ void InstallFirmware(const QString& location, bool recursive)int i = 0;for (const auto& firmware_src_path : out) {i++;- auto firmware_src_vfile = vfs->OpenFile(firmware_src_path.generic_string(),- FileSys::OpenMode::Read);- auto firmware_dst_vfile = firmware_vdir->CreateFileRelative(- firmware_src_path.filename().string());+ auto firmware_src_vfile =+ vfs->OpenFile(firmware_src_path.generic_string(), FileSys::OpenMode::Read);+ auto firmware_dst_vfile =+ firmware_vdir->CreateFileRelative(firmware_src_path.filename().string());if (!VfsRawCopy(firmware_src_vfile, firmware_dst_vfile)) {- LOG_ERROR(Frontend,- "Failed to copy firmware file {} to {} in registered folder!",- firmware_src_path.generic_string(),- firmware_src_path.filename().string());+ LOG_ERROR(Frontend, "Failed to copy firmware file {} to {} in registered folder!",+ firmware_src_path.generic_string(), firmware_src_path.filename().string());success = false;}@@ -162,14 +154,12 @@ void InstallFirmware(const QString& location, bool recursive)return progress->wasCanceled();};- auto results = ContentManager::VerifyInstalledContents(*QtCommon::system,- *QtCommon::provider,- VerifyFirmwareCallback,- true);+ auto results = ContentManager::VerifyInstalledContents(*QtCommon::system, *QtCommon::provider,+ VerifyFirmwareCallback, true);if (results.size() > 0) {- const auto failed_names = QString::fromStdString(- fmt::format("{}", fmt::join(results, "\n")));+ const auto failed_names =+ QString::fromStdString(fmt::format("{}", fmt::join(results, "\n")));progress->close();QtCommon::Frontend::Critical(tr("Firmware integrity verification failed!"),@@ -185,13 +175,11 @@ void InstallFirmware(const QString& location, bool recursive)const std::string display_version(firmware_data.display_version.data());result = FirmwareInstallResult::Success;- QtCommon::Frontend::Information(successTitle,- GetFirmwareInstallResultString(result).arg(- QString::fromStdString(display_version)));+ QtCommon::Frontend::Information(successTitle, GetFirmwareInstallResultString(result).arg(+ QString::fromStdString(display_version)));}-QString UnzipFirmwareToTmp(const QString& location)-{+QString UnzipFirmwareToTmp(const QString& location) {namespace fs = std::filesystem;fs::path tmp{fs::temp_directory_path()};@@ -216,8 +204,7 @@ QString UnzipFirmwareToTmp(const QString& location)}// Content //-void VerifyGameContents(const std::string& game_path)-{+void VerifyGameContents(const std::string& game_path) {auto progress =QtCommon::Frontend::newProgressDialog(tr("Verifying integrity..."), tr("Cancel"), 0, 100);progress->show();@@ -234,34 +221,30 @@ void VerifyGameContents(const std::string& game_path)switch (result) {case ContentManager::GameVerificationResult::Success:- QtCommon::Frontend::Information(rootObject,- tr("Integrity verification succeeded!"),+ QtCommon::Frontend::Information(rootObject, tr("Integrity verification succeeded!"),tr("The operation completed successfully."));break;case ContentManager::GameVerificationResult::Failed:- QtCommon::Frontend::Critical(rootObject,- tr("Integrity verification failed!"),+ QtCommon::Frontend::Critical(rootObject, tr("Integrity verification failed!"),tr("File contents may be corrupt or missing."));break;case ContentManager::GameVerificationResult::NotImplemented:QtCommon::Frontend::Warning(- rootObject,- tr("Integrity verification couldn't be performed"),+ rootObject, tr("Integrity verification couldn't be performed"),tr("Firmware installation cancelled, firmware may be in a bad state or corrupted. ""File contents could not be checked for validity."));}}-void InstallKeys()-{+void InstallKeys() {const QString key_source_location = QtCommon::Frontend::GetOpenFileName(tr("Select Dumped Keys Location"), {}, QStringLiteral("Decryption Keys (*.keys)"), {});if (key_source_location.isEmpty())return;- FirmwareManager::KeyInstallResult result- = FirmwareManager::InstallKeys(key_source_location.toStdString(), "keys");+ FirmwareManager::KeyInstallResult result =+ FirmwareManager::InstallKeys(key_source_location.toStdString(), "keys");system->GetFileSystemController().CreateFactories(*QtCommon::vfs);@@ -276,11 +259,10 @@ void InstallKeys()}}-void VerifyInstalledContents()-{+void VerifyInstalledContents() {// Initialize a progress dialog.- auto progress = QtCommon::Frontend::newProgressDialog(tr("Verifying integrity..."),- tr("Cancel"), 0, 100);+ auto progress =+ QtCommon::Frontend::newProgressDialog(tr("Verifying integrity..."), tr("Cancel"), 0, 100);progress->show();QGuiApplication::processEvents();@@ -289,7 +271,8 @@ void VerifyInstalledContents()auto QtProgressCallback = [&](size_t total_size, size_t processed_size) {QGuiApplication::processEvents();progress->setValue(static_cast<int>((processed_size * 100) / total_size));- return progress->wasCanceled(); };+ return progress->wasCanceled();+ };const std::vector<std::string> result = ContentManager::VerifyInstalledContents(*QtCommon::system, *QtCommon::provider, QtProgressCallback);@@ -300,17 +283,18 @@ void VerifyInstalledContents()QtCommon::Frontend::Information(tr("Integrity verification succeeded!"),tr("The operation completed successfully."));} else {- const auto failed_names = QString::fromStdString(fmt::format("{}", fmt::join(result, "\n")));+ const auto failed_names =+ QString::fromStdString(fmt::format("{}", fmt::join(result, "\n")));QtCommon::Frontend::Critical(tr("Integrity verification failed!"),tr("Verification failed for the following files:\n\n%1").arg(failed_names));}}-void FixProfiles()-{+void FixProfiles() {// Reset user save files after config is initialized and migration is done.- // Doing it at init time causes profiles to read from the wrong place entirely if NAND dir is not default+ // Doing it at init time causes profiles to read from the wrong place entirely if NAND dir is+ // not default// TODO: better solutionsystem->GetProfileManager().ResetUserSaveFile();std::vector<std::string> orphaned = system->GetProfileManager().FindOrphanedProfiles();@@ -350,28 +334,27 @@ void FixProfiles()"%2<br><br>""Click \"OK\" to open your save folder and fix up your profiles.<br>""Hint: copy the contents of the largest or last-modified folder elsewhere, "- "delete all orphaned profiles, and move your copied contents to the good profile.<br><br>"- "Still confused? See the <a href='https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/user/Orphaned.md'>help page</a>.<br>")+ "delete all orphaned profiles, and move your copied contents to the good "+ "profile.<br><br>"+ "Still confused? See the <a "+ "href='https://git.eden-emu.dev/eden-emu/eden/src/branch/master/docs/user/"+ "Orphaned.md'>help page</a>.<br>").arg(qorphaned, qgood));QtCommon::Game::OpenSaveFolder();}-void ClearDataDir(FrontendCommon::DataManager::DataDir dir, const std::string& user_id)-{+void ClearDataDir(FrontendCommon::DataManager::DataDir dir, const std::string& user_id) {using namespace QtCommon::Frontend;- auto result = Warning(tr("Really clear data?"),- tr("Important data may be lost!"),- Yes | No);+ auto result = Warning(tr("Really clear data?"), tr("Important data may be lost!"), Yes | No);if (result != Yes)return;- result = Warning(- tr("Are you REALLY sure?"),- tr("Once deleted, your data will NOT come back!\n"- "Only do this if you're 100% sure you want to delete this data."),- Yes | No);+ result = Warning(tr("Are you REALLY sure?"),+ tr("Once deleted, your data will NOT come back!\n"+ "Only do this if you're 100% sure you want to delete this data."),+ Yes | No);if (result != Yes)return;@@ -384,17 +367,13 @@ void ClearDataDir(FrontendCommon::DataManager::DataDir dir, const std::string& udialog->close();}-void ExportDataDir(FrontendCommon::DataManager::DataDir data_dir,- const std::string& user_id,- const QString& name,- std::function<void()> callback)-{+void ExportDataDir(FrontendCommon::DataManager::DataDir data_dir, const std::string& user_id,+ const QString& name, std::function<void()> callback) {using namespace QtCommon::Frontend;const std::string dir = FrontendCommon::DataManager::GetDataDirString(data_dir, user_id);- const QString zip_dump_location = GetSaveFileName(tr("Select Export Location"),- tr("%1.zip").arg(name),- tr("Zipped Archives (*.zip)"));+ const QString zip_dump_location = GetSaveFileName(+ tr("Select Export Location"), tr("%1.zip").arg(name), tr("Zipped Archives (*.zip)"));if (zip_dump_location.isEmpty())return;@@ -406,18 +385,15 @@ void ExportDataDir(FrontendCommon::DataManager::DataDir data_dir,progress->show();auto progress_callback = [=](size_t total_size, size_t processed_size) {- QMetaObject::invokeMethod(progress,- "setValue",- Qt::DirectConnection,- Q_ARG(int, static_cast<int>((processed_size * 100) / total_size)));+ QMetaObject::invokeMethod(+ progress, "setValue", Qt::DirectConnection,+ Q_ARG(int, static_cast<int>((processed_size * 100) / total_size)));return !progress->wasCanceled();};QFuture<bool> future = QtConcurrent::run([=]() {- return QtCommon::Compress::compressDir(zip_dump_location,- QString::fromStdString(dir),- QtCommon::Compress::Options(),- progress_callback);+ return QtCommon::Compress::compressDir(zip_dump_location, QString::fromStdString(dir),+ QtCommon::Compress::Options(), progress_callback);});QFutureWatcher<bool>* watcher = new QFutureWatcher<bool>(rootObject);@@ -444,37 +420,34 @@ void ExportDataDir(FrontendCommon::DataManager::DataDir data_dir,watcher->setFuture(future);}-void ImportDataDir(FrontendCommon::DataManager::DataDir data_dir,- const std::string& user_id,- std::function<void()> callback)-{+void ImportDataDir(FrontendCommon::DataManager::DataDir data_dir, const std::string& user_id,+ std::function<void()> callback) {const std::string dir = FrontendCommon::DataManager::GetDataDirString(data_dir, user_id);using namespace QtCommon::Frontend;- const QString zip_dump_location = GetOpenFileName(tr("Select Import Location"),- {},- tr("Zipped Archives (*.zip)"));+ const QString zip_dump_location =+ GetOpenFileName(tr("Select Import Location"), {}, tr("Zipped Archives (*.zip)"));if (zip_dump_location.isEmpty())return;- StandardButton button = Warning(- tr("Import Warning"),- tr("All previous data in this directory will be deleted. Are you sure you wish to "- "proceed?"),- StandardButton::Yes | StandardButton::No);+ StandardButton button =+ Warning(tr("Import Warning"),+ tr("All previous data in this directory will be deleted. Are you sure you wish to "+ "proceed?"),+ StandardButton::Yes | StandardButton::No);if (button != QtCommon::Frontend::Yes)return;- QtProgressDialog* progress = newProgressDialogPtr(- tr("Importing data. This may take a while..."), tr("Cancel"), 0, 100);+ QtProgressDialog* progress =+ newProgressDialogPtr(tr("Importing data. This may take a while..."), tr("Cancel"), 0, 100);progress->setTitle(tr("Importing"));progress->show();- // to prevent GUI mangling we have to run this in a thread as well+ // to prevent GUI mangling we have to run this in a thread as wellQFuture<bool> delete_future = QtConcurrent::run([=]() {FrontendCommon::DataManager::ClearDir(data_dir, user_id);return !progress->wasCanceled();@@ -485,17 +458,14 @@ void ImportDataDir(FrontendCommon::DataManager::DataDir data_dir,QObject::connect(delete_watcher, &QFutureWatcher<bool>::finished, rootObject, [=]() {auto progress_callback = [=](size_t total_size, size_t processed_size) {- QMetaObject::invokeMethod(progress,- "setValue",- Qt::DirectConnection,- Q_ARG(int,- static_cast<int>((processed_size * 100) / total_size)));+ QMetaObject::invokeMethod(+ progress, "setValue", Qt::DirectConnection,+ Q_ARG(int, static_cast<int>((processed_size * 100) / total_size)));return !progress->wasCanceled();};QFuture<bool> future = QtConcurrent::run([=]() {- return !QtCommon::Compress::extractDir(zip_dump_location,- QString::fromStdString(dir),+ return !QtCommon::Compress::extractDir(zip_dump_location, QString::fromStdString(dir),progress_callback).empty();});@@ -505,7 +475,7 @@ void ImportDataDir(FrontendCommon::DataManager::DataDir data_dir,QObject::connect(watcher, &QFutureWatcher<bool>::finished, rootObject, [=]() {progress->close();- // this sucks+ // this sucksif (watcher->result()) {Information(tr("Imported Successfully"), tr("Data was imported successfully."));} else if (progress->wasCanceled()) {diff --git a/src/qt_common/util/content.h b/src/qt_common/util/content.hindex c1e2e7791d..20dacf540a 100644--- a/src/qt_common/util/content.h+++ b/src/qt_common/util/content.h@@ -23,8 +23,7 @@ enum class FirmwareInstallResult {FailedCorrupted,};-inline const QString GetFirmwareInstallResultString(FirmwareInstallResult result)-{+inline const QString GetFirmwareInstallResultString(FirmwareInstallResult result) {return LOOKUP_ENUM(result, FwInstallSuccess);}@@ -33,30 +32,29 @@ inline const QString GetFirmwareInstallResultString(FirmwareInstallResult result* \param result The result code.* \return A string representation of the passed result code.*/-inline const QString GetKeyInstallResultString(FirmwareManager::KeyInstallResult result)-{+inline const QString GetKeyInstallResultString(FirmwareManager::KeyInstallResult result) {return LOOKUP_ENUM(result, KeyInstallSuccess);}-void InstallFirmware(const QString &location, bool recursive);+void InstallFirmware(const QString& location, bool recursive);-QString UnzipFirmwareToTmp(const QString &location);+QString UnzipFirmwareToTmp(const QString& location);// Keys //void InstallKeys();// Content //-void VerifyGameContents(const std::string &game_path);+void VerifyGameContents(const std::string& game_path);void VerifyInstalledContents();-void ClearDataDir(FrontendCommon::DataManager::DataDir dir, const std::string &user_id = "");-void ExportDataDir(FrontendCommon::DataManager::DataDir dir,- const std::string &user_id = "",- const QString &name = QStringLiteral("export"),+void ClearDataDir(FrontendCommon::DataManager::DataDir dir, const std::string& user_id = "");+void ExportDataDir(FrontendCommon::DataManager::DataDir dir, const std::string& user_id = "",+ const QString& name = QStringLiteral("export"),+ std::function<void()> callback = {});+void ImportDataDir(FrontendCommon::DataManager::DataDir dir, const std::string& user_id = "",std::function<void()> callback = {});-void ImportDataDir(FrontendCommon::DataManager::DataDir dir, const std::string &user_id = "", std::function<void()> callback = {});// Profiles //void FixProfiles();-}+} // namespace QtCommon::Content#endif // QT_CONTENT_UTIL_Hdiff --git a/src/qt_common/util/fs.cpp b/src/qt_common/util/fs.cppindex e171b8eaf5..b5f2844bbf 100644--- a/src/qt_common/util/fs.cpp+++ b/src/qt_common/util/fs.cpp@@ -13,8 +13,7 @@ namespace fs = std::filesystem;namespace QtCommon::FS {-void LinkRyujinx(std::filesystem::path &from, std::filesystem::path &to)-{+void LinkRyujinx(std::filesystem::path& from, std::filesystem::path& to) {std::error_code ec;// "ignore" errors--if the dir fails to be deleted, error handling later will handle it@@ -25,12 +24,12 @@ void LinkRyujinx(std::filesystem::path &from, std::filesystem::path &to)} else {QtCommon::Frontend::Critical(tr("Failed to link save data"),- tr("Could not link directory:\n\t%1\nTo:\n\t%2").arg(QString::fromStdString(from.string()), QString::fromStdString(to.string())));+ tr("Could not link directory:\n\t%1\nTo:\n\t%2")+ .arg(QString::fromStdString(from.string()), QString::fromStdString(to.string())));}}-bool CheckUnlink(const fs::path &eden_dir, const fs::path &ryu_dir)-{+bool CheckUnlink(const fs::path& eden_dir, const fs::path& ryu_dir) {bool eden_link = Common::FS::IsSymlink(eden_dir);bool ryu_link = Common::FS::IsSymlink(ryu_dir);@@ -64,7 +63,7 @@ bool CheckUnlink(const fs::path &eden_dir, const fs::path &ryu_dir)// NB: do NOT use remove_all, as Windows treats this as a remove_all to the target,// NOT the junctionfs::remove(linked);- } catch (std::exception &e) {+ } catch (std::exception& e) {QtCommon::Frontend::Critical(tr("Failed to unlink old directory"),tr("OS returned error: %1").arg(QString::fromStdString(e.what())));@@ -74,7 +73,7 @@ bool CheckUnlink(const fs::path &eden_dir, const fs::path &ryu_dir)// then COPY the other dirtry {fs::copy(orig, linked, fs::copy_options::recursive);- } catch (std::exception &e) {+ } catch (std::exception& e) {QtCommon::Frontend::Critical(tr("Failed to copy save data"),tr("OS returned error: %1").arg(QString::fromStdString(e.what())));@@ -87,8 +86,7 @@ bool CheckUnlink(const fs::path &eden_dir, const fs::path &ryu_dir)return true;}-const fs::path GetRyujinxSavePath(const fs::path &path_hint, const u64 &program_id)-{+const fs::path GetRyujinxSavePath(const fs::path& path_hint, const u64& program_id) {auto ryu_path = path_hint;auto kvdb_path = Common::FS::GetKvdbPath(ryu_path);@@ -99,10 +97,13 @@ const fs::path GetRyujinxSavePath(const fs::path &path_hint, const u64 &program_tr("Could not find Ryujinx installation"),tr("Could not find a valid Ryujinx installation. This may typically occur if you are ""using Ryujinx in portable mode.\n\nWould you like to manually select a portable "- "folder to use?"), StandardButton::Yes | StandardButton::No);+ "folder to use?"),+ StandardButton::Yes | StandardButton::No);if (res == StandardButton::Yes) {- auto selected_path = GetExistingDirectory(tr("Ryujinx Portable Location"), QDir::homePath()).toStdString();+ auto selected_path =+ GetExistingDirectory(tr("Ryujinx Portable Location"), QDir::homePath())+ .toStdString();if (selected_path.empty())return fs::path{};@@ -131,7 +132,7 @@ const fs::path GetRyujinxSavePath(const fs::path &path_hint, const u64 &program_Common::FS::IMENReadResult res = Common::FS::ReadKvdb(kvdb_path, imens);if (res == Common::FS::IMENReadResult::Success) {- for (const Common::FS::IMEN &imen : imens) {+ for (const Common::FS::IMEN& imen : imens) {if (imen.title_id == program_id)return Common::FS::GetRyuSavePath(ryu_path, imen.save_id);}diff --git a/src/qt_common/util/fs.h b/src/qt_common/util/fs.hindex ef56a361dd..5ab59e2a45 100644--- a/src/qt_common/util/fs.h+++ b/src/qt_common/util/fs.h@@ -1,19 +1,19 @@// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later-#include "common/common_types.h"#include <filesystem>#include <optional>+#include "common/common_types.h"#pragma oncenamespace QtCommon::FS {-void LinkRyujinx(std::filesystem::path &from, std::filesystem::path &to);-const std::filesystem::path GetRyujinxSavePath(const std::filesystem::path &path_hint, const u64 &program_id);+void LinkRyujinx(std::filesystem::path& from, std::filesystem::path& to);+const std::filesystem::path GetRyujinxSavePath(const std::filesystem::path& path_hint,+ const u64& program_id);/// returns FALSE if the dirs are NOT linked-bool CheckUnlink(const std::filesystem::path& eden_dir,- const std::filesystem::path& ryu_dir);+bool CheckUnlink(const std::filesystem::path& eden_dir, const std::filesystem::path& ryu_dir);} // namespace QtCommon::FSdiff --git a/src/qt_common/util/game.cpp b/src/qt_common/util/game.cppindex 3e07b9d6b5..e037fdae6c 100644--- a/src/qt_common/util/game.cpp+++ b/src/qt_common/util/game.cpp@@ -18,40 +18,34 @@#include <QUrl>#ifdef _WIN32-#include "common/scope_exit.h"-#include "common/string_util.h"#include <shlobj.h>#include <windows.h>+#include "common/scope_exit.h"+#include "common/string_util.h"#else-#include "fmt/ostream.h"#include <fstream>+#include "fmt/ostream.h"#endifnamespace QtCommon::Game {-bool CreateShortcutLink(const std::filesystem::path& shortcut_path,- const std::string& comment,+bool CreateShortcutLink(const std::filesystem::path& shortcut_path, const std::string& comment,const std::filesystem::path& icon_path,- const std::filesystem::path& command,- const std::string& arguments,- const std::string& categories,- const std::string& keywords,- const std::string& name)-try {+ const std::filesystem::path& command, const std::string& arguments,+ const std::string& categories, const std::string& keywords,+ const std::string& name) try {#ifdef _WIN32 // WindowsHRESULT hr = CoInitialize(nullptr);if (FAILED(hr)) {LOG_ERROR(Frontend, "CoInitialize failed");return false;}- SCOPE_EXIT- {+ SCOPE_EXIT {CoUninitialize();};IShellLinkW* ps1 = nullptr;IPersistFile* persist_file = nullptr;- SCOPE_EXIT- {+ SCOPE_EXIT {if (persist_file != nullptr) {persist_file->Release();}@@ -59,10 +53,7 @@ try {ps1->Release();}};- HRESULT hres = CoCreateInstance(CLSID_ShellLink,- nullptr,- CLSCTX_INPROC_SERVER,- IID_IShellLinkW,+ HRESULT hres = CoCreateInstance(CLSID_ShellLink, nullptr, CLSCTX_INPROC_SERVER, IID_IShellLinkW,reinterpret_cast<void**>(&ps1));if (FAILED(hres)) {LOG_ERROR(Frontend, "Failed to create IShellLinkW instance");@@ -142,10 +133,8 @@ try {return false;}-bool MakeShortcutIcoPath(const u64 program_id,- const std::string_view game_file_name,- std::filesystem::path& out_icon_path)-{+bool MakeShortcutIcoPath(const u64 program_id, const std::string_view game_file_name,+ std::filesystem::path& out_icon_path) {// Get path to Yuzu icons directory & icon extensionstd::string ico_extension = "png";#if defined(_WIN32)@@ -166,46 +155,38 @@ bool MakeShortcutIcoPath(const u64 program_id,return true;}-void OpenEdenFolder(const Common::FS::EdenPath& path)-{+void OpenEdenFolder(const Common::FS::EdenPath& path) {QDesktopServices::openUrl(QUrl::fromLocalFile(QString::fromStdString(Common::FS::GetEdenPathString(path))));}-void OpenRootDataFolder()-{+void OpenRootDataFolder() {OpenEdenFolder(Common::FS::EdenPath::EdenDir);}-void OpenNANDFolder()-{+void OpenNANDFolder() {OpenEdenFolder(Common::FS::EdenPath::NANDDir);}-void OpenSaveFolder()-{- const auto path = Common::FS::GetEdenPath(Common::FS::EdenPath::NANDDir)- / "user/save/0000000000000000";+void OpenSaveFolder() {+ const auto path =+ Common::FS::GetEdenPath(Common::FS::EdenPath::NANDDir) / "user/save/0000000000000000";QDesktopServices::openUrl(QUrl::fromLocalFile(QString::fromStdString(path.string())));}-void OpenSDMCFolder()-{+void OpenSDMCFolder() {OpenEdenFolder(Common::FS::EdenPath::SDMCDir);}-void OpenModFolder()-{+void OpenModFolder() {OpenEdenFolder(Common::FS::EdenPath::LoadDir);}-void OpenLogFolder()-{+void OpenLogFolder() {OpenEdenFolder(Common::FS::EdenPath::LogDir);}-static QString GetGameListErrorRemoving(QtCommon::Game::InstalledEntryType type)-{+static QString GetGameListErrorRemoving(QtCommon::Game::InstalledEntryType type) {switch (type) {case QtCommon::Game::InstalledEntryType::Game:return tr("Error Removing Contents");@@ -219,10 +200,9 @@ static QString GetGameListErrorRemoving(QtCommon::Game::InstalledEntryType type)}// Game Content //-void RemoveBaseContent(u64 program_id, InstalledEntryType type)-{- const auto res = ContentManager::RemoveBaseContent(system->GetFileSystemController(),- program_id);+void RemoveBaseContent(u64 program_id, InstalledEntryType type) {+ const auto res =+ ContentManager::RemoveBaseContent(system->GetFileSystemController(), program_id);if (res) {QtCommon::Frontend::Information(tr("Successfully Removed"),tr("Successfully removed the installed base game."));@@ -234,8 +214,7 @@ void RemoveBaseContent(u64 program_id, InstalledEntryType type)}}-void RemoveUpdateContent(u64 program_id, InstalledEntryType type)-{+void RemoveUpdateContent(u64 program_id, InstalledEntryType type) {const auto res = ContentManager::RemoveUpdate(system->GetFileSystemController(), program_id);if (res) {QtCommon::Frontend::Information(tr("Successfully Removed"),@@ -246,8 +225,7 @@ void RemoveUpdateContent(u64 program_id, InstalledEntryType type)}}-void RemoveAddOnContent(u64 program_id, InstalledEntryType type)-{+void RemoveAddOnContent(u64 program_id, InstalledEntryType type) {const size_t count = ContentManager::RemoveAllDLC(*system, program_id);if (count == 0) {QtCommon::Frontend::Warning(GetGameListErrorRemoving(type),@@ -261,8 +239,7 @@ void RemoveAddOnContent(u64 program_id, InstalledEntryType type)// Global Content //-void RemoveTransferableShaderCache(u64 program_id, GameListRemoveTarget target)-{+void RemoveTransferableShaderCache(u64 program_id, GameListRemoveTarget target) {const auto target_file_name = [target] {switch (target) {case GameListRemoveTarget::GlShaderCache:@@ -291,8 +268,7 @@ void RemoveTransferableShaderCache(u64 program_id, GameListRemoveTarget target)}}-void RemoveVulkanDriverPipelineCache(u64 program_id)-{+void RemoveVulkanDriverPipelineCache(u64 program_id) {static constexpr std::string_view target_file_name = "vulkan_pipelines.bin";const auto shader_cache_dir = Common::FS::GetEdenPath(Common::FS::EdenPath::ShaderDir);@@ -308,8 +284,7 @@ void RemoveVulkanDriverPipelineCache(u64 program_id)}}-void RemoveAllTransferableShaderCaches(u64 program_id)-{+void RemoveAllTransferableShaderCaches(u64 program_id) {const auto shader_cache_dir = Common::FS::GetEdenPath(Common::FS::EdenPath::ShaderDir);const auto program_shader_cache_dir = shader_cache_dir / fmt::format("{:016x}", program_id);@@ -329,14 +304,13 @@ void RemoveAllTransferableShaderCaches(u64 program_id)}}-void RemoveCustomConfiguration(u64 program_id, const std::string& game_path)-{+void RemoveCustomConfiguration(u64 program_id, const std::string& game_path) {const auto file_path = std::filesystem::path(Common::FS::ToU8String(game_path));- const auto config_file_name- = program_id == 0 ? Common::FS::PathToUTF8String(file_path.filename()).append(".ini")- : fmt::format("{:016X}.ini", program_id);- const auto custom_config_file_path = Common::FS::GetEdenPath(Common::FS::EdenPath::ConfigDir)- / "custom" / config_file_name;+ const auto config_file_name =+ program_id == 0 ? Common::FS::PathToUTF8String(file_path.filename()).append(".ini")+ : fmt::format("{:016X}.ini", program_id);+ const auto custom_config_file_path =+ Common::FS::GetEdenPath(Common::FS::EdenPath::ConfigDir) / "custom" / config_file_name;if (!Common::FS::Exists(custom_config_file_path)) {QtCommon::Frontend::Warning(tr("Error Removing Custom Configuration"),@@ -353,20 +327,14 @@ void RemoveCustomConfiguration(u64 program_id, const std::string& game_path)}}-void RemoveCacheStorage(u64 program_id)-{+void RemoveCacheStorage(u64 program_id) {const auto nand_dir = Common::FS::GetEdenPath(Common::FS::EdenPath::NANDDir);- auto vfs_nand_dir = vfs->OpenDirectory(Common::FS::PathToUTF8String(nand_dir),- FileSys::OpenMode::Read);-- const auto cache_storage_path- = FileSys::SaveDataFactory::GetFullPath({},- vfs_nand_dir,- FileSys::SaveDataSpaceId::User,- FileSys::SaveDataType::Cache,- 0 /* program_id */,- {},- 0);+ auto vfs_nand_dir =+ vfs->OpenDirectory(Common::FS::PathToUTF8String(nand_dir), FileSys::OpenMode::Read);++ const auto cache_storage_path = FileSys::SaveDataFactory::GetFullPath(+ {}, vfs_nand_dir, FileSys::SaveDataSpaceId::User, FileSys::SaveDataType::Cache,+ 0 /* program_id */, {}, 0);const auto path = Common::FS::ConcatPathSafe(nand_dir, cache_storage_path);@@ -400,8 +368,7 @@ void ResetMetadata(bool show_message) {// Uhhh //// Messages in pre-defined message boxes for less code spaghetti-inline constexpr bool CreateShortcutMessagesGUI(ShortcutMessages imsg, const QString& game_title)-{+inline constexpr bool CreateShortcutMessagesGUI(ShortcutMessages imsg, const QString& game_title) {int result = 0;using namespace QtCommon::Frontend;int buttons;@@ -433,13 +400,9 @@ inline constexpr bool CreateShortcutMessagesGUI(ShortcutMessages imsg, const QSt}}-void CreateShortcut(const std::string& game_path,- const u64 program_id,- const std::string& game_title_,- const ShortcutTarget& target,- std::string arguments_,- const bool needs_title)-{+void CreateShortcut(const std::string& game_path, const u64 program_id,+ const std::string& game_title_, const ShortcutTarget& target,+ std::string arguments_, const bool needs_title) {// Get path to Eden executablestd::filesystem::path command = GetEdenCommand();@@ -453,13 +416,11 @@ void CreateShortcut(const std::string& game_path,return;}- const FileSys::PatchManager pm{program_id,- QtCommon::system->GetFileSystemController(),+ const FileSys::PatchManager pm{program_id, QtCommon::system->GetFileSystemController(),QtCommon::system->GetContentProvider()};const auto control = pm.GetControlMetadata();- const auto loader = Loader::GetLoader(*QtCommon::system,- QtCommon::vfs->OpenFile(game_path,- FileSys::OpenMode::Read));+ const auto loader = Loader::GetLoader(+ *QtCommon::system, QtCommon::vfs->OpenFile(game_path, FileSys::OpenMode::Read));std::string game_title{game_title_};@@ -490,8 +451,8 @@ void CreateShortcut(const std::string& game_path,LOG_WARNING(Frontend, "Could not read icon from {:s}", game_path);}- QImage icon_data = QImage::fromData(icon_image_file.data(),- static_cast<int>(icon_image_file.size()));+ QImage icon_data =+ QImage::fromData(icon_image_file.data(), static_cast<int>(icon_image_file.size()));std::filesystem::path out_icon_path;if (QtCommon::Game::MakeShortcutIcoPath(program_id, game_title, out_icon_path)) {if (!SaveIconToFile(out_icon_path, icon_data)) {@@ -524,39 +485,32 @@ void CreateShortcut(const std::string& game_path,const std::string categories = "Game;Emulator;Qt;";const std::string keywords = "Switch;Nintendo;";- if (QtCommon::Game::CreateShortcutLink(shortcut_path,- comment,- out_icon_path,- command,- arguments,- categories,- keywords,- game_title)) {+ if (QtCommon::Game::CreateShortcutLink(shortcut_path, comment, out_icon_path, command,+ arguments, categories, keywords, game_title)) {CreateShortcutMessagesGUI(ShortcutMessages::Success, qgame_title);return;}CreateShortcutMessagesGUI(ShortcutMessages::Failed, qgame_title);}-// TODO: You want this to be constexpr? Well too bad, clang19 doesn't believe this is a string literal-std::string GetShortcutPath(ShortcutTarget target)-{+// TODO: You want this to be constexpr? Well too bad, clang19 doesn't believe this is a string+// literal+std::string GetShortcutPath(ShortcutTarget target) {{std::string shortcut_path{};if (target == ShortcutTarget::Desktop) {- shortcut_path- = QStandardPaths::writableLocation(QStandardPaths::DesktopLocation).toStdString();+ shortcut_path =+ QStandardPaths::writableLocation(QStandardPaths::DesktopLocation).toStdString();} else if (target == ShortcutTarget::Applications) {- shortcut_path- = QStandardPaths::writableLocation(QStandardPaths::ApplicationsLocation).toStdString();+ shortcut_path = QStandardPaths::writableLocation(QStandardPaths::ApplicationsLocation)+ .toStdString();}return shortcut_path;}}-void CreateHomeMenuShortcut(ShortcutTarget target)-{+void CreateHomeMenuShortcut(ShortcutTarget target) {constexpr u64 QLaunchId = static_cast<u64>(Service::AM::AppletProgramId::QLaunch);auto bis_system = QtCommon::system->GetFileSystemController().GetSystemNANDContents();if (!bis_system) {diff --git a/src/qt_common/util/game.h b/src/qt_common/util/game.hindex 16a1b7340a..0d7f03fa86 100644--- a/src/qt_common/util/game.h+++ b/src/qt_common/util/game.h@@ -29,27 +29,18 @@ enum class ShortcutTarget {Applications,};-enum class ShortcutMessages{- Fullscreen = 0,- Success = 1,- Volatile = 2,- Failed = 3-};+enum class ShortcutMessages { Fullscreen = 0, Success = 1, Volatile = 2, Failed = 3 };-bool CreateShortcutLink(const std::filesystem::path& shortcut_path,- const std::string& comment,+bool CreateShortcutLink(const std::filesystem::path& shortcut_path, const std::string& comment,const std::filesystem::path& icon_path,- const std::filesystem::path& command,- const std::string& arguments,- const std::string& categories,- const std::string& keywords,+ const std::filesystem::path& command, const std::string& arguments,+ const std::string& categories, const std::string& keywords,const std::string& name);-bool MakeShortcutIcoPath(const u64 program_id,- const std::string_view game_file_name,+bool MakeShortcutIcoPath(const u64 program_id, const std::string_view game_file_name,std::filesystem::path& out_icon_path);-void OpenEdenFolder(const Common::FS::EdenPath &path);+void OpenEdenFolder(const Common::FS::EdenPath& path);void OpenRootDataFolder();void OpenNANDFolder();void OpenSaveFolder();@@ -71,16 +62,13 @@ void RemoveCacheStorage(u64 program_id);void ResetMetadata(bool show_message = true);// Shortcuts //-void CreateShortcut(const std::string& game_path,- const u64 program_id,- const std::string& game_title_,- const ShortcutTarget& target,- std::string arguments_,- const bool needs_title);+void CreateShortcut(const std::string& game_path, const u64 program_id,+ const std::string& game_title_, const ShortcutTarget& target,+ std::string arguments_, const bool needs_title);std::string GetShortcutPath(ShortcutTarget target);void CreateHomeMenuShortcut(ShortcutTarget target);-}+} // namespace QtCommon::Game#endif // QT_GAME_UTIL_Hdiff --git a/src/qt_common/util/meta.cpp b/src/qt_common/util/meta.cppindex ead090b7a4..4607321285 100644--- a/src/qt_common/util/meta.cpp+++ b/src/qt_common/util/meta.cpp@@ -1,7 +1,6 @@// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later-#include "qt_common/util/meta.h"#include "common/common_types.h"#include "core/core.h"#include "core/frontend/applets/cabinet.h"@@ -9,11 +8,11 @@#include "core/frontend/applets/profile_select.h"#include "core/frontend/applets/software_keyboard.h"#include "core/hle/service/am/frontend/applet_web_browser_types.h"+#include "qt_common/util/meta.h"namespace QtCommon::Meta {-void RegisterMetaTypes()-{+void RegisterMetaTypes() {// Register integral and floating point typesqRegisterMetaType<u8>("u8");qRegisterMetaType<u16>("u16");@@ -72,4 +71,4 @@ void RegisterMetaTypes()qRegisterMetaType<Core::SystemResultStatus>("Core::SystemResultStatus");}-}+} // namespace QtCommon::Metadiff --git a/src/qt_common/util/meta.h b/src/qt_common/util/meta.hindex 53501591e0..ae6dbc49d8 100644--- a/src/qt_common/util/meta.h+++ b/src/qt_common/util/meta.h@@ -11,5 +11,5 @@ namespace QtCommon::Meta {//void RegisterMetaTypes();-}+} // namespace QtCommon::Meta#endif // QT_META_Hdiff --git a/src/qt_common/util/mod.cpp b/src/qt_common/util/mod.cppindex 1ab05af9b6..38bc8f5be0 100644--- a/src/qt_common/util/mod.cpp+++ b/src/qt_common/util/mod.cpp@@ -43,7 +43,8 @@ QStringList GetModFolders(const QString& root, const QString& fallbackName) {QString name = QtCommon::Frontend::GetTextInput(tr("Mod Name"), tr("What should this mod be called?"), default_name);- if (name.isEmpty()) return {};+ if (name.isEmpty())+ return {};// if std_path is empty, frontend_common could not determine mod type and/or name.// so we have to prompt the user and set up the structure ourselvesdiff --git a/src/qt_common/util/mod.h b/src/qt_common/util/mod.hindex 8bdb4bc9dd..2148bed65c 100644--- a/src/qt_common/util/mod.h+++ b/src/qt_common/util/mod.h@@ -7,8 +7,8 @@namespace QtCommon::Mod {-QStringList GetModFolders(const QString &root, const QString &fallbackName);+QStringList GetModFolders(const QString& root, const QString& fallbackName);-const QString ExtractMod(const QString &path);+const QString ExtractMod(const QString& path);-}+} // namespace QtCommon::Moddiff --git a/src/qt_common/util/path.h b/src/qt_common/util/path.hindex 7a1d74b354..aff0009f34 100644--- a/src/qt_common/util/path.h+++ b/src/qt_common/util/path.h@@ -4,9 +4,11 @@#ifndef QT_PATH_UTIL_H#define QT_PATH_UTIL_H-#include "common/common_types.h"#include <QObject>+#include "common/common_types.h"-namespace QtCommon::Path { bool OpenShaderCache(u64 program_id, QObject *parent); }+namespace QtCommon::Path {+bool OpenShaderCache(u64 program_id, QObject* parent);+}#endif // QT_PATH_UTIL_Hdiff --git a/src/qt_common/util/rom.cpp b/src/qt_common/util/rom.cppindex ef4d4e1ae4..c77fa9530d 100644--- a/src/qt_common/util/rom.cpp+++ b/src/qt_common/util/rom.cpp@@ -7,13 +7,8 @@namespace QtCommon::ROM {-bool RomFSRawCopy(size_t total_size,- size_t& read_size,- QtProgressCallback callback,- const FileSys::VirtualDir& src,- const FileSys::VirtualDir& dest,- bool full)-{+bool RomFSRawCopy(size_t total_size, size_t& read_size, QtProgressCallback callback,+ const FileSys::VirtualDir& src, const FileSys::VirtualDir& dest, bool full) {// TODO(crueter)// if (src == nullptr || dest == nullptr || !src->IsReadable() || !dest->IsWritable())// return false;@@ -75,4 +70,4 @@ bool RomFSRawCopy(size_t total_size,return true;}-}+} // namespace QtCommon::ROMdiff --git a/src/qt_common/util/rom.h b/src/qt_common/util/rom.hindex 5dd372e450..5ceadaf46b 100644--- a/src/qt_common/util/rom.h+++ b/src/qt_common/util/rom.h@@ -4,17 +4,13 @@#ifndef QT_ROM_UTIL_H#define QT_ROM_UTIL_H-#include "qt_common/qt_common.h"#include <cstddef>+#include "qt_common/qt_common.h"namespace QtCommon::ROM {-bool RomFSRawCopy(size_t total_size,- size_t& read_size,- QtProgressCallback callback,- const FileSys::VirtualDir& src,- const FileSys::VirtualDir& dest,- bool full);+bool RomFSRawCopy(size_t total_size, size_t& read_size, QtProgressCallback callback,+ const FileSys::VirtualDir& src, const FileSys::VirtualDir& dest, bool full);}#endif // QT_ROM_UTIL_Hdiff --git a/src/yuzu/about_dialog.cpp b/src/yuzu/about_dialog.cppindex 9f7597f471..2694f421cb 100644--- a/src/yuzu/about_dialog.cpp+++ b/src/yuzu/about_dialog.cpp@@ -1,29 +1,24 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later// SPDX-FileCopyrightText: Copyright 2018 yuzu Emulator Project// SPDX-License-Identifier: GPL-2.0-or-later-#include "yuzu/about_dialog.h"#include <QIcon>+#include <fmt/ranges.h>#include "common/scm_rev.h"#include "ui_aboutdialog.h"-#include <fmt/ranges.h>+#include "yuzu/about_dialog.h"AboutDialog::AboutDialog(QWidget* parent)- : QDialog(parent)- , ui{std::make_unique<Ui::AboutDialog>()}-{+ : QDialog(parent), ui{std::make_unique<Ui::AboutDialog>()} {static const std::string build_id = std::string{Common::g_build_id};- static const std::string yuzu_build = fmt::format("{} | {} | {}",- std::string{Common::g_build_name},- std::string{Common::g_build_version},- std::string{Common::g_compiler_id}- );+ static const std::string yuzu_build =+ fmt::format("{} | {} | {}", std::string{Common::g_build_name},+ std::string{Common::g_build_version}, std::string{Common::g_compiler_id});- const auto override_build = fmt::format(fmt::runtime(- std::string(Common::g_title_bar_format_idle)),- build_id);+ const auto override_build =+ fmt::format(fmt::runtime(std::string(Common::g_title_bar_format_idle)), build_id);const auto yuzu_build_version = override_build.empty() ? yuzu_build : override_build;ui->setupUi(this);diff --git a/src/yuzu/applets/qt_controller.cpp b/src/yuzu/applets/qt_controller.cppindex aa210caf77..e7fa93a793 100644--- a/src/yuzu/applets/qt_controller.cpp+++ b/src/yuzu/applets/qt_controller.cpp@@ -1,4 +1,4 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later// SPDX-FileCopyrightText: Copyright 2020 yuzu Emulator Project@@ -17,8 +17,8 @@#include "hid_core/hid_core.h"#include "hid_core/hid_types.h"#include "hid_core/resources/npad/npad.h"-#include "ui_qt_controller.h"#include "qt_common/qt_compat.h"+#include "ui_qt_controller.h"#include "yuzu/applets/qt_controller.h"#include "yuzu/configuration/configure_input.h"#include "yuzu/configuration/configure_input_profile_dialog.h"@@ -188,14 +188,15 @@ QtControllerSelectorDialog::QtControllerSelectorDialog(CheckIfParametersMet();});- connect(connected_controller_checkboxes[i], &QCheckBox::STATE_CHANGED, [this, i](int state) {- player_groupboxes[i]->setChecked(state == Qt::Checked);- UpdateControllerIcon(i);- UpdateControllerState(i);- UpdateLEDPattern(i);- UpdateBorderColor(i);- CheckIfParametersMet();- });+ connect(connected_controller_checkboxes[i], &QCheckBox::STATE_CHANGED,+ [this, i](int state) {+ player_groupboxes[i]->setChecked(state == Qt::Checked);+ UpdateControllerIcon(i);+ UpdateControllerState(i);+ UpdateLEDPattern(i);+ UpdateBorderColor(i);+ CheckIfParametersMet();+ });if (i == 0) {connect(emulated_controllers[i], qOverload<int>(&QComboBox::currentIndexChanged),diff --git a/src/yuzu/applets/qt_software_keyboard.cpp b/src/yuzu/applets/qt_software_keyboard.cppindex 0b894bf51a..41f0b85e96 100644--- a/src/yuzu/applets/qt_software_keyboard.cpp+++ b/src/yuzu/applets/qt_software_keyboard.cpp@@ -1499,22 +1499,22 @@ void QtSoftwareKeyboardDialog::StartInputThread() {input_interpreter->PollInput();HandleButtonPressedOnce<Core::HID::NpadButton::A, Core::HID::NpadButton::B, Core::HID::NpadButton::X,- Core::HID::NpadButton::Y, Core::HID::NpadButton::StickL, Core::HID::NpadButton::StickR,- Core::HID::NpadButton::L, Core::HID::NpadButton::R, Core::HID::NpadButton::Plus,- Core::HID::NpadButton::Left, Core::HID::NpadButton::Up, Core::HID::NpadButton::Right,- Core::HID::NpadButton::Down, Core::HID::NpadButton::StickLLeft,- Core::HID::NpadButton::StickLUp, Core::HID::NpadButton::StickLRight,- Core::HID::NpadButton::StickLDown, Core::HID::NpadButton::StickRLeft,- Core::HID::NpadButton::StickRUp, Core::HID::NpadButton::StickRRight,- Core::HID::NpadButton::StickRDown>();+ Core::HID::NpadButton::Y, Core::HID::NpadButton::StickL,+ Core::HID::NpadButton::StickR, Core::HID::NpadButton::L, Core::HID::NpadButton::R,+ Core::HID::NpadButton::Plus, Core::HID::NpadButton::Left, Core::HID::NpadButton::Up,+ Core::HID::NpadButton::Right, Core::HID::NpadButton::Down,+ Core::HID::NpadButton::StickLLeft, Core::HID::NpadButton::StickLUp,+ Core::HID::NpadButton::StickLRight, Core::HID::NpadButton::StickLDown,+ Core::HID::NpadButton::StickRLeft, Core::HID::NpadButton::StickRUp,+ Core::HID::NpadButton::StickRRight, Core::HID::NpadButton::StickRDown>();HandleButtonHold<Core::HID::NpadButton::B, Core::HID::NpadButton::L,- Core::HID::NpadButton::R, Core::HID::NpadButton::Left,- Core::HID::NpadButton::Up, Core::HID::NpadButton::Right,- Core::HID::NpadButton::Down, Core::HID::NpadButton::StickLLeft,- Core::HID::NpadButton::StickLUp, Core::HID::NpadButton::StickLRight,- Core::HID::NpadButton::StickLDown, Core::HID::NpadButton::StickRLeft,- Core::HID::NpadButton::StickRUp, Core::HID::NpadButton::StickRRight,- Core::HID::NpadButton::StickRDown>();+ Core::HID::NpadButton::R, Core::HID::NpadButton::Left,+ Core::HID::NpadButton::Up, Core::HID::NpadButton::Right,+ Core::HID::NpadButton::Down, Core::HID::NpadButton::StickLLeft,+ Core::HID::NpadButton::StickLUp, Core::HID::NpadButton::StickLRight,+ Core::HID::NpadButton::StickLDown, Core::HID::NpadButton::StickRLeft,+ Core::HID::NpadButton::StickRUp, Core::HID::NpadButton::StickRRight,+ Core::HID::NpadButton::StickRDown>();std::this_thread::sleep_for(std::chrono::milliseconds(50));}});diff --git a/src/yuzu/applets/qt_web_browser.cpp b/src/yuzu/applets/qt_web_browser.cppindex 2141b9d0e7..e7c50aa3fb 100644--- a/src/yuzu/applets/qt_web_browser.cpp+++ b/src/yuzu/applets/qt_web_browser.cpp@@ -63,8 +63,8 @@ QtNXWebEngineView::QtNXWebEngineView(QWidget* parent, Core::System& system,: QWebEngineView(parent), input_subsystem{input_subsystem_},url_interceptor(std::make_unique<UrlRequestInterceptor>()),input_interpreter(std::make_unique<InputInterpreter>(system)),- default_profile{QWebEngineProfile::defaultProfile()}, global_settings{- default_profile->settings()} {+ default_profile{QWebEngineProfile::defaultProfile()},+ global_settings{default_profile->settings()} {default_profile->setPersistentStoragePath(QString::fromStdString(Common::FS::PathToUTF8String(Common::FS::GetEdenPath(Common::FS::EdenPath::EdenDir) / "qtwebengine")));@@ -299,21 +299,21 @@ void QtNXWebEngineView::StartInputThread() {while (!stoken.stop_requested()) {input_interpreter->PollInput();- HandleWindowFooterButtonPressedOnce<Core::HID::NpadButton::A, Core::HID::NpadButton::B,- Core::HID::NpadButton::X, Core::HID::NpadButton::Y,- Core::HID::NpadButton::L, Core::HID::NpadButton::R>();+ HandleWindowFooterButtonPressedOnce<+ Core::HID::NpadButton::A, Core::HID::NpadButton::B, Core::HID::NpadButton::X,+ Core::HID::NpadButton::Y, Core::HID::NpadButton::L, Core::HID::NpadButton::R>();HandleWindowKeyButtonPressedOnce<- Core::HID::NpadButton::Left, Core::HID::NpadButton::Up, Core::HID::NpadButton::Right,- Core::HID::NpadButton::Down, Core::HID::NpadButton::StickLLeft,- Core::HID::NpadButton::StickLUp, Core::HID::NpadButton::StickLRight,- Core::HID::NpadButton::StickLDown>();+ Core::HID::NpadButton::Left, Core::HID::NpadButton::Up,+ Core::HID::NpadButton::Right, Core::HID::NpadButton::Down,+ Core::HID::NpadButton::StickLLeft, Core::HID::NpadButton::StickLUp,+ Core::HID::NpadButton::StickLRight, Core::HID::NpadButton::StickLDown>();HandleWindowKeyButtonHold<- Core::HID::NpadButton::Left, Core::HID::NpadButton::Up, Core::HID::NpadButton::Right,- Core::HID::NpadButton::Down, Core::HID::NpadButton::StickLLeft,- Core::HID::NpadButton::StickLUp, Core::HID::NpadButton::StickLRight,- Core::HID::NpadButton::StickLDown>();+ Core::HID::NpadButton::Left, Core::HID::NpadButton::Up,+ Core::HID::NpadButton::Right, Core::HID::NpadButton::Down,+ Core::HID::NpadButton::StickLLeft, Core::HID::NpadButton::StickLUp,+ Core::HID::NpadButton::StickLRight, Core::HID::NpadButton::StickLDown>();std::this_thread::sleep_for(std::chrono::milliseconds(50));}diff --git a/src/yuzu/applets/qt_web_browser.h b/src/yuzu/applets/qt_web_browser.hindex 6a2dd0c8ba..f6869bbb35 100644--- a/src/yuzu/applets/qt_web_browser.h+++ b/src/yuzu/applets/qt_web_browser.h@@ -169,7 +169,8 @@ private:std::unique_ptr<InputInterpreter> input_interpreter;std::jthread input_thread;std::atomic<bool> finished{};- Service::AM::Frontend::WebExitReason exit_reason{Service::AM::Frontend::WebExitReason::EndButtonPressed};+ Service::AM::Frontend::WebExitReason exit_reason{+ Service::AM::Frontend::WebExitReason::EndButtonPressed};std::string last_url{"http://localhost/"};bool is_local{};QWebEngineProfile* default_profile;diff --git a/src/yuzu/bootmanager.cpp b/src/yuzu/bootmanager.cppindex 72a5157fc4..69b3681d0a 100644--- a/src/yuzu/bootmanager.cpp+++ b/src/yuzu/bootmanager.cpp@@ -54,12 +54,12 @@#include "input_common/drivers/tas_input.h"#include "input_common/drivers/touch_screen.h"#include "input_common/main.h"+#include "qt_common/qt_common.h"#include "video_core/gpu.h"#include "video_core/rasterizer_interface.h"#include "video_core/renderer_base.h"#include "yuzu/bootmanager.h"#include "yuzu/main_window.h"-#include "qt_common/qt_common.h"class QObject;class QPaintEngine;@@ -282,8 +282,8 @@ struct NullRenderWidget : public RenderWidget {GRenderWindow::GRenderWindow(MainWindow* parent, EmuThread* emu_thread_,std::shared_ptr<InputCommon::InputSubsystem> input_subsystem_,Core::System& system_)- : QWidget(parent),- emu_thread(emu_thread_), input_subsystem{std::move(input_subsystem_)}, system{system_} {+ : QWidget(parent), emu_thread(emu_thread_), input_subsystem{std::move(input_subsystem_)},+ system{system_} {setWindowTitle(QStringLiteral("Eden %1 | %2-%3").arg(QString::fromUtf8(Common::g_build_name),QString::fromUtf8(Common::g_scm_branch),@@ -887,13 +887,14 @@ void GRenderWindow::resizeEvent(QResizeEvent* event) {std::unique_ptr<Core::Frontend::GraphicsContext> GRenderWindow::CreateSharedContext() const {#ifdef HAS_OPENGL- if (Settings::values.renderer_backend.GetValue() == Settings::RendererBackend::OpenGL_GLSL- || Settings::values.renderer_backend.GetValue() == Settings::RendererBackend::OpenGL_GLASM- || Settings::values.renderer_backend.GetValue() == Settings::RendererBackend::OpenGL_SPIRV) {+ if (Settings::values.renderer_backend.GetValue() == Settings::RendererBackend::OpenGL_GLSL ||+ Settings::values.renderer_backend.GetValue() == Settings::RendererBackend::OpenGL_GLASM ||+ Settings::values.renderer_backend.GetValue() == Settings::RendererBackend::OpenGL_SPIRV) {auto c = static_cast<OpenGLSharedContext*>(main_context.get());// Bind the shared contexts to the main surface in case the backend wants to take over// presentation- return std::make_unique<OpenGLSharedContext>(c->GetShareContext(), child_widget->windowHandle());+ return std::make_unique<OpenGLSharedContext>(c->GetShareContext(),+ child_widget->windowHandle());}#endifreturn std::make_unique<DummyContext>();@@ -940,9 +941,9 @@ bool GRenderWindow::InitRenderTarget() {OnFramebufferSizeChanged();BackupGeometry();- if (Settings::values.renderer_backend.GetValue() == Settings::RendererBackend::OpenGL_GLSL- || Settings::values.renderer_backend.GetValue() == Settings::RendererBackend::OpenGL_GLASM- || Settings::values.renderer_backend.GetValue() == Settings::RendererBackend::OpenGL_SPIRV)+ if (Settings::values.renderer_backend.GetValue() == Settings::RendererBackend::OpenGL_GLSL ||+ Settings::values.renderer_backend.GetValue() == Settings::RendererBackend::OpenGL_GLASM ||+ Settings::values.renderer_backend.GetValue() == Settings::RendererBackend::OpenGL_SPIRV)return LoadOpenGL();return true;}@@ -1050,21 +1051,23 @@ bool GRenderWindow::LoadOpenGL() {}// Display various warnings (but not fatal errors) for missing OpenGL extensions or lack of// OpenGL 4.6 support- const QString renderer = QString::fromUtf8(reinterpret_cast<const char*>(glGetString(GL_RENDERER)));+ const QString renderer =+ QString::fromUtf8(reinterpret_cast<const char*>(glGetString(GL_RENDERER)));if (!GLAD_GL_VERSION_4_6) {QMessageBox::warning(this, tr("Error while initializing OpenGL 4.6!"),- tr("Your GPU may not support OpenGL 4.6, or you do not have the "- "latest graphics driver.<br><br>GL Renderer:<br>%1")- .arg(renderer));+ tr("Your GPU may not support OpenGL 4.6, or you do not have the "+ "latest graphics driver.<br><br>GL Renderer:<br>%1")+ .arg(renderer));return false;}if (QStringList missing_ext = GetUnsupportedGLExtensions(); !missing_ext.empty()) {QMessageBox::warning(this, tr("Error while initializing OpenGL!"),tr("Your GPU may not support one or more required OpenGL extensions. Please ensure you "- "have the latest graphics driver.<br><br>GL Renderer:<br>%1<br><br>Unsupported "- "extensions:<br>%2")- .arg(renderer).arg(missing_ext.join(QStringLiteral("<br>"))));+ "have the latest graphics driver.<br><br>GL Renderer:<br>%1<br><br>Unsupported "+ "extensions:<br>%2")+ .arg(renderer)+ .arg(missing_ext.join(QStringLiteral("<br>"))));// Non fatal}return true;diff --git a/src/yuzu/configuration/addon/mod_select_dialog.cpp b/src/yuzu/configuration/addon/mod_select_dialog.cppindex e6c361b94f..467de5a764 100644--- a/src/yuzu/configuration/addon/mod_select_dialog.cpp+++ b/src/yuzu/configuration/addon/mod_select_dialog.cpp@@ -43,7 +43,8 @@ ModSelectDialog::ModSelectDialog(const QStringList& mods, QWidget* parent)width = qMax(width, item_model->item(i)->sizeHint().width());}- width += ui->treeView->contentsMargins().left() * 4 + ui->treeView->contentsMargins().right() * 4;+ width +=+ ui->treeView->contentsMargins().left() * 4 + ui->treeView->contentsMargins().right() * 4;ui->treeView->setMinimumHeight(qMin(height, 600));ui->treeView->setMinimumWidth(qMin(width, 700));adjustSize();diff --git a/src/yuzu/configuration/addon/mod_select_dialog.h b/src/yuzu/configuration/addon/mod_select_dialog.hindex d23c435e7a..ab6d4686b0 100644--- a/src/yuzu/configuration/addon/mod_select_dialog.h+++ b/src/yuzu/configuration/addon/mod_select_dialog.h@@ -14,11 +14,12 @@ class ModSelectDialog : public QDialog {Q_OBJECTpublic:- explicit ModSelectDialog(const QStringList &mods, QWidget* parent = nullptr);+ explicit ModSelectDialog(const QStringList& mods, QWidget* parent = nullptr);~ModSelectDialog();signals:- void modsSelected(const QStringList &mods);+ void modsSelected(const QStringList& mods);+private:Ui::ModSelectDialog* ui;diff --git a/src/yuzu/configuration/configure_audio.cpp b/src/yuzu/configuration/configure_audio.cppindex 10eacf39cb..65b8b16301 100644--- a/src/yuzu/configuration/configure_audio.cpp+++ b/src/yuzu/configuration/configure_audio.cpp@@ -1,4 +1,4 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later// SPDX-FileCopyrightText: Copyright 2018 yuzu Emulator Project@@ -16,12 +16,12 @@#include "common/settings.h"#include "common/settings_common.h"#include "core/core.h"+#include "qt_common/config/shared_translation.h"+#include "qt_common/config/uisettings.h"#include "ui_configure_audio.h"#include "yuzu/configuration/configuration_shared.h"#include "yuzu/configuration/configure_audio.h"-#include "qt_common/config/shared_translation.h"#include "yuzu/configuration/shared_widget.h"-#include "qt_common/config/uisettings.h"ConfigureAudio::ConfigureAudio(const Core::System& system_,std::shared_ptr<std::vector<ConfigurationShared::Tab*>> group_,@@ -188,8 +188,8 @@ void ConfigureAudio::SetOutputSinkFromSinkID() {const std::string new_sink_id = []() -> const std::string {const Settings::AudioEngine sink_id = Settings::values.sink_id.GetValue();- const auto canonicalizations- = Settings::EnumMetadata<Settings::AudioEngine>::Canonicalizations();+ const auto canonicalizations =+ Settings::EnumMetadata<Settings::AudioEngine>::Canonicalizations();for (u32 i = 0; i < canonicalizations.size(); ++i) {const Settings::AudioEngine value = canonicalizations[i].second;@@ -242,8 +242,8 @@ void ConfigureAudio::ApplyConfiguration() {const u32 new_sink_id = [this]() {const std::string sink_id = sink_combo_box->currentText().toStdString();- const auto canonicalizations- = Settings::EnumMetadata<Settings::AudioEngine>::Canonicalizations();+ const auto canonicalizations =+ Settings::EnumMetadata<Settings::AudioEngine>::Canonicalizations();for (u32 i = 0; i < canonicalizations.size(); ++i) {if (sink_id == canonicalizations[i].first)@@ -291,7 +291,8 @@ void ConfigureAudio::InitializeAudioSinkComboBox() {sink_combo_box->clear();sink_combo_box->addItem(QString::fromUtf8(AudioCore::Sink::auto_device_name));for (const auto& id : AudioCore::Sink::GetSinkIDs())- sink_combo_box->addItem(QString::fromStdString(std::string{Settings::CanonicalizeEnum(id)}));+ sink_combo_box->addItem(+ QString::fromStdString(std::string{Settings::CanonicalizeEnum(id)}));}void ConfigureAudio::RetranslateUI() {diff --git a/src/yuzu/configuration/configure_cpu.cpp b/src/yuzu/configuration/configure_cpu.cppindex bc1140d835..eee1c677b7 100644--- a/src/yuzu/configuration/configure_cpu.cpp+++ b/src/yuzu/configuration/configure_cpu.cpp@@ -1,4 +1,4 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later// SPDX-FileCopyrightText: Copyright 2020 yuzu Emulator Project@@ -76,9 +76,9 @@ void ConfigureCpu::Setup(const ConfigurationShared::Builder& builder) {} else if (setting->Id() == Settings::values.cpu_backend.Id()) {backend_layout->addWidget(widget);backend_combobox = widget->combobox;- } else if (setting->Id() == Settings::values.fast_cpu_time.Id()- || setting->Id() == Settings::values.vtable_bouncing.Id()- || setting->Id() == Settings::values.cpu_ticks.Id()) {+ } else if (setting->Id() == Settings::values.fast_cpu_time.Id() ||+ setting->Id() == Settings::values.vtable_bouncing.Id() ||+ setting->Id() == Settings::values.cpu_ticks.Id()) {ui->general_layout->addWidget(widget);} else {// Presently, all other settings here are unsafe checkboxes@@ -93,12 +93,12 @@ void ConfigureCpu::Setup(const ConfigurationShared::Builder& builder) {UpdateGroup();}-void ConfigureCpu::UpdateGroup()-{+void ConfigureCpu::UpdateGroup() {const u32 accuracy = accuracy_combobox->currentIndex();const u32 backend = backend_combobox->currentIndex();// TODO(crueter): see if this works on NCE- ui->unsafe_group->setVisible(accuracy == (u32) Settings::CpuAccuracy::Unsafe && backend == (u32) Settings::CpuBackend::Dynarmic);+ ui->unsafe_group->setVisible(accuracy == (u32)Settings::CpuAccuracy::Unsafe &&+ backend == (u32)Settings::CpuBackend::Dynarmic);}void ConfigureCpu::ApplyConfiguration() {diff --git a/src/yuzu/configuration/configure_cpu.h b/src/yuzu/configuration/configure_cpu.hindex 461ca7f85e..2b0ae890d7 100644--- a/src/yuzu/configuration/configure_cpu.h+++ b/src/yuzu/configuration/configure_cpu.h@@ -1,4 +1,4 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later// SPDX-FileCopyrightText: Copyright 2020 yuzu Emulator Project@@ -9,8 +9,8 @@#include <memory>#include <vector>#include <QWidget>-#include "yuzu/configuration/configuration_shared.h"#include "qt_common/config/shared_translation.h"+#include "yuzu/configuration/configuration_shared.h"class QComboBox;diff --git a/src/yuzu/configuration/configure_debug.cpp b/src/yuzu/configuration/configure_debug.cppindex e0bdbaeaa1..287bfbb338 100644--- a/src/yuzu/configuration/configure_debug.cpp+++ b/src/yuzu/configuration/configure_debug.cpp@@ -13,10 +13,10 @@#include "common/settings.h"#include "core/core.h"#include "core/crypto/key_manager.h"+#include "qt_common/config/uisettings.h"#include "ui_configure_debug.h"#include "yuzu/configuration/configure_debug.h"#include "yuzu/debugger/console.h"-#include "qt_common/config/uisettings.h"ConfigureDebug::ConfigureDebug(const Core::System& system_, QWidget* parent): QScrollArea(parent), ui{std::make_unique<Ui::ConfigureDebug>()}, system{system_} {@@ -60,7 +60,8 @@ void ConfigureDebug::SetConfiguration() {// Immutable after startingui->homebrew_args_edit->setEnabled(runtime_lock);- ui->homebrew_args_edit->setText(QString::fromStdString(Settings::values.program_args.GetValue()));+ ui->homebrew_args_edit->setText(+ QString::fromStdString(Settings::values.program_args.GetValue()));ui->toggle_console->setEnabled(runtime_lock);ui->toggle_console->setChecked(UISettings::values.show_console.GetValue());ui->fs_access_log->setEnabled(runtime_lock);@@ -84,7 +85,8 @@ void ConfigureDebug::SetConfiguration() {ui->disable_macro_hle->setEnabled(runtime_lock);ui->disable_macro_hle->setChecked(Settings::values.disable_macro_hle.GetValue());ui->disable_loop_safety_checks->setEnabled(runtime_lock);- ui->disable_loop_safety_checks->setChecked(Settings::values.disable_shader_loop_safety_checks.GetValue());+ ui->disable_loop_safety_checks->setChecked(+ Settings::values.disable_shader_loop_safety_checks.GetValue());ui->perform_vulkan_check->setChecked(Settings::values.perform_vulkan_check.GetValue());ui->debug_knobs_spinbox->setValue(Settings::values.debug_knobs.GetValue());#ifdef YUZU_USE_QT_WEB_ENGINE@@ -118,7 +120,8 @@ void ConfigureDebug::ApplyConfiguration() {Settings::values.enable_nsight_aftermath = ui->enable_nsight_aftermath->isChecked();Settings::values.dump_shaders = ui->dump_shaders->isChecked();Settings::values.dump_macros = ui->dump_macros->isChecked();- Settings::values.disable_shader_loop_safety_checks = ui->disable_loop_safety_checks->isChecked();+ Settings::values.disable_shader_loop_safety_checks =+ ui->disable_loop_safety_checks->isChecked();Settings::values.disable_macro_jit = ui->disable_macro_jit->isChecked();Settings::values.disable_macro_hle = ui->disable_macro_hle->isChecked();Settings::values.extended_logging = ui->extended_logging->isChecked();diff --git a/src/yuzu/configuration/configure_dialog.cpp b/src/yuzu/configuration/configure_dialog.cppindex 1107c77e8c..2e3107d3dc 100644--- a/src/yuzu/configuration/configure_dialog.cpp+++ b/src/yuzu/configuration/configure_dialog.cpp@@ -9,6 +9,7 @@#include "common/settings.h"#include "common/settings_enums.h"#include "core/core.h"+#include "qt_common/config/uisettings.h"#include "ui_configure.h"#include "vk_device_info.h"#include "yuzu/configuration/configure_applets.h"@@ -30,15 +31,14 @@#include "yuzu/configuration/configure_ui.h"#include "yuzu/configuration/configure_web.h"#include "yuzu/hotkeys.h"-#include "qt_common/config/uisettings.h"ConfigureDialog::ConfigureDialog(QWidget* parent, HotkeyRegistry& registry_,InputCommon::InputSubsystem* input_subsystem,std::vector<VkDeviceInfo::Record>& vk_device_records,Core::System& system_, bool enable_web_config)- : QDialog(parent), ui{std::make_unique<Ui::ConfigureDialog>()},- registry(registry_), system{system_}, builder{std::make_unique<ConfigurationShared::Builder>(- this, !system_.IsPoweredOn())},+ : QDialog(parent), ui{std::make_unique<Ui::ConfigureDialog>()}, registry(registry_),+ system{system_},+ builder{std::make_unique<ConfigurationShared::Builder>(this, !system_.IsPoweredOn())},applets_tab{std::make_unique<ConfigureApplets>(system_, nullptr, *builder, this)},audio_tab{std::make_unique<ConfigureAudio>(system_, nullptr, *builder, this)},cpu_tab{std::make_unique<ConfigureCpu>(system_, nullptr, *builder, this)},@@ -46,9 +46,9 @@ ConfigureDialog::ConfigureDialog(QWidget* parent, HotkeyRegistry& registry_,filesystem_tab{std::make_unique<ConfigureFilesystem>(this)},general_tab{std::make_unique<ConfigureGeneral>(system_, nullptr, *builder, this)},graphics_advanced_tab{- std::make_unique<ConfigureGraphicsAdvanced>(system_, nullptr, *builder, this)},+ std::make_unique<ConfigureGraphicsAdvanced>(system_, nullptr, *builder, this)},graphics_extensions_tab{- std::make_unique<ConfigureGraphicsExtensions>(system_, nullptr, *builder, this)},+ std::make_unique<ConfigureGraphicsExtensions>(system_, nullptr, *builder, this)},ui_tab{std::make_unique<ConfigureUi>(system_, this)},graphics_tab{std::make_unique<ConfigureGraphics>(system_, vk_device_records, [&]() { graphics_advanced_tab->ExposeComputeOption(); },@@ -113,7 +113,7 @@ ConfigureDialog::ConfigureDialog(QWidget* parent, HotkeyRegistry& registry_,adjustSize();ui->selectorList->setCurrentRow(0);- // Selects the leftmost button on the bottom bar (Cancel as of writing)+ // Selects the leftmost button on the bottom bar (Cancel as of writing)ui->buttonBox->setFocus();}@@ -172,16 +172,17 @@ Q_DECLARE_METATYPE(QList<QWidget*>);void ConfigureDialog::PopulateSelectionList() {const std::array<std::pair<QString, QList<QWidget*>>, 6> items{- {{tr("General"),- {general_tab.get(), hotkeys_tab.get(), ui_tab.get(), web_tab.get(), debug_tab_tab.get()}},- {tr("System"),- {system_tab.get(), profile_tab.get(), network_tab.get(), filesystem_tab.get(),- applets_tab.get()}},- {tr("CPU"), {cpu_tab.get()}},- {tr("Graphics"), {graphics_tab.get(), graphics_advanced_tab.get(), graphics_extensions_tab.get()}},- {tr("Audio"), {audio_tab.get()}},- {tr("Controls"), input_tab->GetSubTabs()}},- };+ {{tr("General"),+ {general_tab.get(), hotkeys_tab.get(), ui_tab.get(), web_tab.get(), debug_tab_tab.get()}},+ {tr("System"),+ {system_tab.get(), profile_tab.get(), network_tab.get(), filesystem_tab.get(),+ applets_tab.get()}},+ {tr("CPU"), {cpu_tab.get()}},+ {tr("Graphics"),+ {graphics_tab.get(), graphics_advanced_tab.get(), graphics_extensions_tab.get()}},+ {tr("Audio"), {audio_tab.get()}},+ {tr("Controls"), input_tab->GetSubTabs()}},+ };[[maybe_unused]] const QSignalBlocker blocker(ui->selectorList);diff --git a/src/yuzu/configuration/configure_dialog.h b/src/yuzu/configuration/configure_dialog.hindex 9d79e6f0ac..5c504c9a16 100644--- a/src/yuzu/configuration/configure_dialog.h+++ b/src/yuzu/configuration/configure_dialog.h@@ -10,8 +10,8 @@#include <vector>#include <QDialog>#include "configuration/shared_widget.h"-#include "yuzu/configuration/configuration_shared.h"#include "qt_common/config/shared_translation.h"+#include "yuzu/configuration/configuration_shared.h"#include "yuzu/vk_device_info.h"namespace Core {diff --git a/src/yuzu/configuration/configure_filesystem.cpp b/src/yuzu/configuration/configure_filesystem.cppindex 27af4c8055..ee1e4bbc20 100644--- a/src/yuzu/configuration/configure_filesystem.cpp+++ b/src/yuzu/configuration/configure_filesystem.cpp@@ -4,7 +4,6 @@// SPDX-FileCopyrightText: Copyright 2019 yuzu Emulator Project// SPDX-License-Identifier: GPL-2.0-or-later-#include "yuzu/configuration/configure_filesystem.h"#include <filesystem>#include <QFileDialog>#include <QMessageBox>@@ -12,10 +11,11 @@#include "common/fs/fs.h"#include "common/fs/path_util.h"#include "common/settings.h"+#include "qt_common/config/uisettings.h"#include "qt_common/qt_compat.h"#include "qt_common/util/game.h"-#include "qt_common/config/uisettings.h"#include "ui_configure_filesystem.h"+#include "yuzu/configuration/configure_filesystem.h"ConfigureFilesystem::ConfigureFilesystem(QWidget* parent): QWidget(parent), ui(std::make_unique<Ui::ConfigureFilesystem>()) {@@ -26,8 +26,7 @@ ConfigureFilesystem::ConfigureFilesystem(QWidget* parent)[this] { SetDirectory(DirectoryTarget::NAND, ui->nand_directory_edit); });connect(ui->sdmc_directory_button, &QToolButton::pressed, this,[this] { SetDirectory(DirectoryTarget::SD, ui->sdmc_directory_edit); });- connect(ui->save_directory_button, &QToolButton::pressed, this,- [this] { SetSaveDirectory(); });+ connect(ui->save_directory_button, &QToolButton::pressed, this, [this] { SetSaveDirectory(); });connect(ui->gamecard_path_button, &QToolButton::pressed, this,[this] { SetDirectory(DirectoryTarget::Gamecard, ui->gamecard_path_edit); });connect(ui->dump_path_button, &QToolButton::pressed, this,@@ -221,9 +220,9 @@ void ConfigureFilesystem::PromptSaveMigration(const QString& from_path, const QS.arg(QString::fromStdString(dest_save_dir.string()));}- QMessageBox::StandardButton reply = QMessageBox::question(- this, tr("Migrate Save Data"), message,- QMessageBox::Yes | QMessageBox::No, QMessageBox::Yes);+ QMessageBox::StandardButton reply =+ QMessageBox::question(this, tr("Migrate Save Data"), message,+ QMessageBox::Yes | QMessageBox::No, QMessageBox::Yes);if (reply != QMessageBox::Yes) {return;@@ -249,17 +248,17 @@ void ConfigureFilesystem::PromptSaveMigration(const QString& from_path, const QSprogress.close();if (ec) {- QMessageBox::warning(this, tr("Migration Failed"),- tr("Failed to migrate save data:\n%1")- .arg(QString::fromStdString(ec.message())));+ QMessageBox::warning(+ this, tr("Migration Failed"),+ tr("Failed to migrate save data:\n%1").arg(QString::fromStdString(ec.message())));return;}- QMessageBox::StandardButton deleteReply = QMessageBox::question(- this, tr("Migration Complete"),- tr("Save data has been migrated successfully.\n\n"- "Would you like to delete the old save data?"),- QMessageBox::Yes | QMessageBox::No, QMessageBox::No);+ QMessageBox::StandardButton deleteReply =+ QMessageBox::question(this, tr("Migration Complete"),+ tr("Save data has been migrated successfully.\n\n"+ "Would you like to delete the old save data?"),+ QMessageBox::Yes | QMessageBox::No, QMessageBox::No);if (deleteReply == QMessageBox::Yes) {Common::FS::RemoveDirRecursively(source_save_dir);@@ -278,7 +277,6 @@ void ConfigureFilesystem::UpdateEnabledControls() {!ui->gamecard_current_game->isChecked());}-void ConfigureFilesystem::RetranslateUI() {ui->retranslateUi(this);}diff --git a/src/yuzu/configuration/configure_general.cpp b/src/yuzu/configuration/configure_general.cppindex f628abeab3..a311765f2f 100644--- a/src/yuzu/configuration/configure_general.cpp+++ b/src/yuzu/configuration/configure_general.cpp@@ -13,11 +13,11 @@#include <QMessageBox>#include "common/settings.h"#include "core/core.h"+#include "qt_common/config/uisettings.h"#include "ui_configure_general.h"#include "yuzu/configuration/configuration_shared.h"#include "yuzu/configuration/configure_general.h"#include "yuzu/configuration/shared_widget.h"-#include "qt_common/config/uisettings.h"ConfigureGeneral::ConfigureGeneral(const Core::System& system_,std::shared_ptr<std::vector<ConfigurationShared::Tab*>> group_,diff --git a/src/yuzu/configuration/configure_graphics.cpp b/src/yuzu/configuration/configure_graphics.cppindex b0c63aff4f..475b9b60ac 100644--- a/src/yuzu/configuration/configure_graphics.cpp+++ b/src/yuzu/configuration/configure_graphics.cpp@@ -39,12 +39,12 @@#include "common/settings.h"#include "common/settings_enums.h"#include "core/core.h"+#include "qt_common/config/uisettings.h"+#include "qt_common/qt_common.h"#include "ui_configure_graphics.h"#include "yuzu/configuration/configuration_shared.h"#include "yuzu/configuration/configure_graphics.h"#include "yuzu/configuration/shared_widget.h"-#include "qt_common/qt_common.h"-#include "qt_common/config/uisettings.h"#include "yuzu/vk_device_info.h"static const std::vector<VkPresentModeKHR> default_present_modes{VK_PRESENT_MODE_IMMEDIATE_KHR,@@ -91,8 +91,7 @@ ConfigureGraphics::ConfigureGraphics(: ConfigurationShared::Tab(group_, parent), ui{std::make_unique<Ui::ConfigureGraphics>()},records{records_}, expose_compute_option{expose_compute_option_},update_aspect_ratio{update_aspect_ratio_}, system{system_},- combobox_translations{builder.ComboboxTranslations()}-{+ combobox_translations{builder.ComboboxTranslations()} {vulkan_device = Settings::values.vulkan_device.GetValue();RetrieveVulkanDevices();@@ -215,9 +214,9 @@ void ConfigureGraphics::PopulateVSyncModeSelection(bool use_setting) {const Settings::VSyncMode global_vsync_mode = Settings::values.vsync_mode.GetValue(true);vsync_restore_global_button->setEnabled(- ((backend == Settings::RendererBackend::OpenGL_GLSL- || backend == Settings::RendererBackend::OpenGL_GLASM- || backend == Settings::RendererBackend::OpenGL_SPIRV) &&+ ((backend == Settings::RendererBackend::OpenGL_GLSL ||+ backend == Settings::RendererBackend::OpenGL_GLASM ||+ backend == Settings::RendererBackend::OpenGL_SPIRV) &&(global_vsync_mode == Settings::VSyncMode::Immediate ||global_vsync_mode == Settings::VSyncMode::Fifo)) ||backend == Settings::RendererBackend::Vulkan);@@ -286,7 +285,9 @@ void ConfigureGraphics::Setup(const ConfigurationShared::Builder& builder) {api_combobox = widget->combobox;api_restore_global_button = widget->restore_button;if (!Settings::IsConfiguringGlobal()) {- api_restore_global_button->connect(api_restore_global_button, &QAbstractButton::clicked, [this](bool) { UpdateAPILayout(); });+ api_restore_global_button->connect(api_restore_global_button,+ &QAbstractButton::clicked,+ [this](bool) { UpdateAPILayout(); });// Detach API's restore button and place it where we want// Lets us put it on the side, and it will automatically scale if there's a// second combobox (vulkan_device)@@ -312,20 +313,21 @@ void ConfigureGraphics::Setup(const ConfigurationShared::Builder& builder) {widget->layout()->addWidget(restore_button);restore_button->connect(restore_button, &QAbstractButton::clicked,- [restore_button, this](bool) {- Settings::values.vsync_mode.SetGlobal(true);- PopulateVSyncModeSelection(true);+ [restore_button, this](bool) {+ Settings::values.vsync_mode.SetGlobal(true);+ PopulateVSyncModeSelection(true);- restore_button->setVisible(false);- });+ restore_button->setVisible(false);+ });std::function<void()> set_non_global = [restore_button, this]() {Settings::values.vsync_mode.SetGlobal(false);UpdateVsyncSetting();restore_button->setVisible(true);};- widget->combobox->connect(widget->combobox, QOverload<int>::of(&QComboBox::activated),- [set_non_global]() { set_non_global(); });+ widget->combobox->connect(widget->combobox,+ QOverload<int>::of(&QComboBox::activated),+ [set_non_global]() { set_non_global(); });vsync_restore_global_button = restore_button;}hold_graphics.emplace(setting->Id(), widget);@@ -364,15 +366,15 @@ void ConfigureGraphics::Setup(const ConfigurationShared::Builder& builder) {ui->bg_widget->layout()->addWidget(bg_restore_button);bg_restore_button->connect(bg_restore_button, &QAbstractButton::clicked,- [bg_restore_button, this](bool) {- const int r = Settings::values.bg_red.GetValue(true);- const int g = Settings::values.bg_green.GetValue(true);- const int b = Settings::values.bg_blue.GetValue(true);- UpdateBackgroundColorButton(QColor::fromRgb(r, g, b));+ [bg_restore_button, this](bool) {+ const int r = Settings::values.bg_red.GetValue(true);+ const int g = Settings::values.bg_green.GetValue(true);+ const int b = Settings::values.bg_blue.GetValue(true);+ UpdateBackgroundColorButton(QColor::fromRgb(r, g, b));- bg_restore_button->setVisible(false);- bg_restore_button->setEnabled(false);- });+ bg_restore_button->setVisible(false);+ bg_restore_button->setEnabled(false);+ });ui->bg_button->connect(ui->bg_button, &QAbstractButton::clicked, [bg_restore_button](bool) {bg_restore_button->setVisible(true);@@ -397,17 +399,19 @@ const QString ConfigureGraphics::TranslateVSyncMode(VkPresentModeKHR mode,Settings::RendererBackend backend) const {switch (mode) {case VK_PRESENT_MODE_IMMEDIATE_KHR:- return (backend == Settings::RendererBackend::OpenGL_GLSL- || backend == Settings::RendererBackend::OpenGL_GLASM- || backend == Settings::RendererBackend::OpenGL_SPIRV)- ? tr("Off") : QStringLiteral("Immediate (%1)").arg(tr("VSync Off"));+ return (backend == Settings::RendererBackend::OpenGL_GLSL ||+ backend == Settings::RendererBackend::OpenGL_GLASM ||+ backend == Settings::RendererBackend::OpenGL_SPIRV)+ ? tr("Off")+ : QStringLiteral("Immediate (%1)").arg(tr("VSync Off"));case VK_PRESENT_MODE_MAILBOX_KHR:return QStringLiteral("Mailbox (%1)").arg(tr("Recommended"));case VK_PRESENT_MODE_FIFO_KHR:- return (backend == Settings::RendererBackend::OpenGL_GLSL- || backend == Settings::RendererBackend::OpenGL_GLASM- || backend == Settings::RendererBackend::OpenGL_SPIRV)- ? tr("On") : QStringLiteral("FIFO (%1)").arg(tr("VSync On"));+ return (backend == Settings::RendererBackend::OpenGL_GLSL ||+ backend == Settings::RendererBackend::OpenGL_GLASM ||+ backend == Settings::RendererBackend::OpenGL_SPIRV)+ ? tr("On")+ : QStringLiteral("FIFO (%1)").arg(tr("VSync On"));case VK_PRESENT_MODE_FIFO_RELAXED_KHR:return QStringLiteral("FIFO Relaxed");default:@@ -416,7 +420,9 @@ const QString ConfigureGraphics::TranslateVSyncMode(VkPresentModeKHR mode,}int ConfigureGraphics::FindIndex(u32 enumeration, int value) const {- for (u32 i = 0; enumeration < combobox_translations.size() && i < combobox_translations.at(enumeration).size(); i++)+ for (u32 i = 0; enumeration < combobox_translations.size() &&+ i < combobox_translations.at(enumeration).size();+ i++)if (combobox_translations.at(enumeration)[i].first == u32(value))return i;return -1;@@ -432,10 +438,14 @@ void ConfigureGraphics::ApplyConfiguration() {Settings::values.vulkan_device.SetGlobal(true);auto const index = Settings::EnumMetadata<Settings::RendererBackend>::Index();- if (Settings::IsConfiguringGlobal() || (!Settings::IsConfiguringGlobal() && api_restore_global_button->isEnabled())) {- auto backend = index >= combobox_translations.size() || size_t(api_combobox->currentIndex()) >= combobox_translations.at(index).size()- ? Settings::values.renderer_backend.GetValue()- : Settings::RendererBackend(combobox_translations.at(index)[api_combobox->currentIndex()].first);+ if (Settings::IsConfiguringGlobal() ||+ (!Settings::IsConfiguringGlobal() && api_restore_global_button->isEnabled())) {+ auto backend =+ index >= combobox_translations.size() ||+ size_t(api_combobox->currentIndex()) >= combobox_translations.at(index).size()+ ? Settings::values.renderer_backend.GetValue()+ : Settings::RendererBackend(+ combobox_translations.at(index)[api_combobox->currentIndex()].first);switch (backend) {case Settings::RendererBackend::Vulkan:Settings::values.vulkan_device.SetGlobal(Settings::IsConfiguringGlobal());@@ -506,12 +516,15 @@ Settings::RendererBackend ConfigureGraphics::GetCurrentGraphicsBackend() const {auto const index = Settings::EnumMetadata<Settings::RendererBackend>::Index();if (!Settings::IsConfiguringGlobal() && !api_restore_global_button->isEnabled())return Settings::values.renderer_backend.GetValue(true);- return index >= combobox_translations.size() || size_t(api_combobox->currentIndex()) >= combobox_translations.at(index).size()- ? Settings::values.renderer_backend.GetValue()- : Settings::RendererBackend(combobox_translations.at(index).at(api_combobox->currentIndex()).first);+ return index >= combobox_translations.size() || size_t(api_combobox->currentIndex()) >=+ combobox_translations.at(index).size()+ ? Settings::values.renderer_backend.GetValue()+ : Settings::RendererBackend(+ combobox_translations.at(index).at(api_combobox->currentIndex()).first);}();- if (selected_backend == Settings::RendererBackend::Vulkan && UISettings::values.has_broken_vulkan)+ if (selected_backend == Settings::RendererBackend::Vulkan &&+ UISettings::values.has_broken_vulkan)return Settings::RendererBackend::OpenGL_GLSL;return selected_backend;}diff --git a/src/yuzu/configuration/configure_graphics_advanced.cpp b/src/yuzu/configuration/configure_graphics_advanced.cppindex 9096e3252d..2ffb3a0b30 100644--- a/src/yuzu/configuration/configure_graphics_advanced.cpp+++ b/src/yuzu/configuration/configure_graphics_advanced.cpp@@ -1,4 +1,4 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later// SPDX-FileCopyrightText: Copyright 2020 yuzu Emulator Project@@ -9,10 +9,10 @@#include <qnamespace.h>#include "common/settings.h"#include "core/core.h"+#include "qt_common/config/shared_translation.h"#include "ui_configure_graphics_advanced.h"#include "yuzu/configuration/configuration_shared.h"#include "yuzu/configuration/configure_graphics_advanced.h"-#include "qt_common/config/shared_translation.h"#include "yuzu/configuration/shared_widget.h"ConfigureGraphicsAdvanced::ConfigureGraphicsAdvanced(diff --git a/src/yuzu/configuration/configure_graphics_extensions.cpp b/src/yuzu/configuration/configure_graphics_extensions.cppindex 7334eccc97..8154dfa6ca 100644--- a/src/yuzu/configuration/configure_graphics_extensions.cpp+++ b/src/yuzu/configuration/configure_graphics_extensions.cpp@@ -1,26 +1,27 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later// SPDX-FileCopyrightText: Copyright 2020 yuzu Emulator Project// SPDX-License-Identifier: GPL-2.0-or-later#include <vector>-#include <QLabel>-#include <qnamespace.h>#include <QCheckBox>+#include <QLabel>#include <QSlider>+#include <qnamespace.h>#include "common/settings.h"#include "core/core.h"+#include "qt_common/config/shared_translation.h"#include "ui_configure_graphics_extensions.h"#include "yuzu/configuration/configuration_shared.h"#include "yuzu/configuration/configure_graphics_extensions.h"-#include "qt_common/config/shared_translation.h"#include "yuzu/configuration/shared_widget.h"ConfigureGraphicsExtensions::ConfigureGraphicsExtensions(const Core::System& system_, std::shared_ptr<std::vector<ConfigurationShared::Tab*>> group_,const ConfigurationShared::Builder& builder, QWidget* parent)- : Tab(group_, parent), ui{std::make_unique<Ui::ConfigureGraphicsExtensions>()}, system{system_} {+ : Tab(group_, parent), ui{std::make_unique<Ui::ConfigureGraphicsExtensions>()},+ system{system_} {ui->setupUi(this);@@ -44,8 +45,8 @@ void ConfigureGraphicsExtensions::Setup(const ConfigurationShared::Builder& builif (setting->Id() == Settings::values.sample_shading.Id()) {// TODO(crueter): should support this natively perhaps?return builder.BuildWidget(- setting, apply_funcs, ConfigurationShared::RequestType::Slider, true,- 1.0f, nullptr, tr("%", "Sample Shading percentage (e.g. 50%)"));+ setting, apply_funcs, ConfigurationShared::RequestType::Slider, true, 1.0f,+ nullptr, tr("%", "Sample Shading percentage (e.g. 50%)"));} else {return builder.BuildWidget(setting, apply_funcs);}@@ -64,7 +65,8 @@ void ConfigureGraphicsExtensions::Setup(const ConfigurationShared::Builder& buil#ifdef __APPLE__if (setting->Id() == Settings::values.dyna_state.Id()) {widget->setEnabled(false);- widget->setToolTip(tr("Extended Dynamic State is disabled on macOS due to MoltenVK compatibility issues that cause black screens."));+ widget->setToolTip(tr("Extended Dynamic State is disabled on macOS due to MoltenVK "+ "compatibility issues that cause black screens."));}#endif}diff --git a/src/yuzu/configuration/configure_hotkeys.cpp b/src/yuzu/configuration/configure_hotkeys.cppindex dfd3727120..9e19cb49bf 100644--- a/src/yuzu/configuration/configure_hotkeys.cpp+++ b/src/yuzu/configuration/configure_hotkeys.cpp@@ -1,4 +1,4 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later// SPDX-FileCopyrightText: 2017 Citra Emulator Project@@ -13,10 +13,10 @@#include "hid_core/hid_core.h"#include "frontend_common/config.h"+#include "qt_common/config/uisettings.h"#include "ui_configure_hotkeys.h"#include "yuzu/configuration/configure_hotkeys.h"#include "yuzu/hotkeys.h"-#include "qt_common/config/uisettings.h"#include "yuzu/util/sequence_dialog/sequence_dialog.h"constexpr int name_column = 0;diff --git a/src/yuzu/configuration/configure_input.cpp b/src/yuzu/configuration/configure_input.cppindex 1a2d36efe6..4473df901e 100644--- a/src/yuzu/configuration/configure_input.cpp+++ b/src/yuzu/configuration/configure_input.cpp@@ -1,4 +1,4 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later// SPDX-FileCopyrightText: 2016 Citra Emulator Project@@ -15,10 +15,10 @@#include "core/hle/service/sm/sm.h"#include "hid_core/frontend/emulated_controller.h"#include "hid_core/hid_core.h"+#include "qt_common/qt_compat.h"#include "ui_configure_input.h"#include "ui_configure_input_advanced.h"#include "ui_configure_input_player.h"-#include "qt_common/qt_compat.h"#include "yuzu/configuration/configure_camera.h"#include "yuzu/configuration/configure_debug_controller.h"#include "yuzu/configuration/configure_input.h"@@ -102,7 +102,7 @@ void ConfigureInput::Initialize(InputCommon::InputSubsystem* input_subsystem,};for (std::size_t i = 0; i < player_tabs.size(); ++i) {- QHBoxLayout *tab_layout = new QHBoxLayout(player_tabs[i]);+ QHBoxLayout* tab_layout = new QHBoxLayout(player_tabs[i]);tab_layout->addWidget(player_controllers[i]);connect(player_controllers[i], &ConfigureInputPlayer::Connected, [this, i](bool checked) {// Ensures that connecting a controller changes the number of players@@ -125,10 +125,11 @@ void ConfigureInput::Initialize(InputCommon::InputSubsystem* input_subsystem,&ConfigureInput::UpdateAllInputDevices);connect(player_controllers[i], &ConfigureInputPlayer::RefreshInputProfiles, this,&ConfigureInput::UpdateAllInputProfiles, Qt::QueuedConnection);- connect(connected_controller_checkboxes[i], &QCheckBox::STATE_CHANGED, [this, i](int state) {- // Keep activated controllers synced with the "Connected Controllers" checkboxes- player_controllers[i]->ConnectPlayer(state == Qt::Checked);- });+ connect(connected_controller_checkboxes[i], &QCheckBox::STATE_CHANGED,+ [this, i](int state) {+ // Keep activated controllers synced with the "Connected Controllers" checkboxes+ player_controllers[i]->ConnectPlayer(state == Qt::Checked);+ });// Remove/hide all the elements that exceed max_players, if applicable.if (i >= max_players) {diff --git a/src/yuzu/configuration/configure_input_advanced.cpp b/src/yuzu/configuration/configure_input_advanced.cppindex b1c19114bf..d8f0ab7e6c 100644--- a/src/yuzu/configuration/configure_input_advanced.cpp+++ b/src/yuzu/configuration/configure_input_advanced.cpp@@ -9,8 +9,8 @@#include "core/core.h"#include "hid_core/frontend/emulated_controller.h"#include "hid_core/hid_core.h"-#include "ui_configure_input_advanced.h"#include "qt_common/qt_compat.h"+#include "ui_configure_input_advanced.h"#include "yuzu/configuration/configure_input_advanced.h"ConfigureInputAdvanced::ConfigureInputAdvanced(Core::HID::HIDCore& hid_core_, QWidget* parent)diff --git a/src/yuzu/configuration/configure_input_per_game.h b/src/yuzu/configuration/configure_input_per_game.hindex a1b6098dca..1e389a7a69 100644--- a/src/yuzu/configuration/configure_input_per_game.h+++ b/src/yuzu/configuration/configure_input_per_game.h@@ -1,4 +1,4 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later// SPDX-FileCopyrightText: 2022 yuzu Emulator Project@@ -10,9 +10,9 @@#include <QWidget>+#include "qt_common/config/qt_config.h"#include "ui_configure_input_per_game.h"#include "yuzu/configuration/input_profiles.h"-#include "qt_common/config/qt_config.h"class QComboBox;diff --git a/src/yuzu/configuration/configure_input_player.cpp b/src/yuzu/configuration/configure_input_player.cppindex 6bc37d4347..821825f6e1 100644--- a/src/yuzu/configuration/configure_input_player.cpp+++ b/src/yuzu/configuration/configure_input_player.cpp@@ -1,4 +1,4 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later// SPDX-FileCopyrightText: 2016 Citra Emulator Project@@ -14,13 +14,13 @@#include <QTimer>#include "common/assert.h"#include "common/param_package.h"-#include "qt_common/config/qt_config.h"#include "hid_core/frontend/emulated_controller.h"#include "hid_core/hid_core.h"#include "hid_core/hid_types.h"#include "input_common/drivers/keyboard.h"#include "input_common/drivers/mouse.h"#include "input_common/main.h"+#include "qt_common/config/qt_config.h"#include "ui_configure_input_player.h"#include "yuzu/bootmanager.h"#include "yuzu/configuration/configure_input_player.h"@@ -294,11 +294,11 @@ ConfigureInputPlayer::ConfigureInputPlayer(QWidget* parent, std::size_t player_iInputCommon::InputSubsystem* input_subsystem_,InputProfiles* profiles_, Core::HID::HIDCore& hid_core_,bool is_powered_on_, bool debug_)- : QWidget(parent),- ui(std::make_unique<Ui::ConfigureInputPlayer>()), player_index{player_index_}, debug{debug_},- is_powered_on{is_powered_on_}, input_subsystem{input_subsystem_}, profiles(profiles_),- timeout_timer(std::make_unique<QTimer>()),- poll_timer(std::make_unique<QTimer>()), bottom_row{bottom_row_}, hid_core{hid_core_} {+ : QWidget(parent), ui(std::make_unique<Ui::ConfigureInputPlayer>()),+ player_index{player_index_}, debug{debug_}, is_powered_on{is_powered_on_},+ input_subsystem{input_subsystem_}, profiles(profiles_),+ timeout_timer(std::make_unique<QTimer>()), poll_timer(std::make_unique<QTimer>()),+ bottom_row{bottom_row_}, hid_core{hid_core_} {if (player_index == 0) {auto* emulated_controller_p1 =hid_core.GetEmulatedController(Core::HID::NpadIdType::Player1);@@ -1215,10 +1215,8 @@ void ConfigureInputPlayer::UpdateControllerAvailableButtons() {case Core::HID::NpadStyleIndex::Fullkey:case Core::HID::NpadStyleIndex::Handheld:layout_hidden = {- ui->buttonShoulderButtonsSLSRLeft,- ui->buttonShoulderButtonsSLSRRight,- ui->horizontalSpacerShoulderButtonsWidget2,- ui->horizontalSpacerShoulderButtonsWidget4,+ ui->buttonShoulderButtonsSLSRLeft, ui->buttonShoulderButtonsSLSRRight,+ ui->horizontalSpacerShoulderButtonsWidget2, ui->horizontalSpacerShoulderButtonsWidget4,ui->buttonMiscButtonsScreenshotGroup,};break;diff --git a/src/yuzu/configuration/configure_input_player_widget.cpp b/src/yuzu/configuration/configure_input_player_widget.cppindex 3228b5f17f..790a860002 100644--- a/src/yuzu/configuration/configure_input_player_widget.cpp+++ b/src/yuzu/configuration/configure_input_player_widget.cpp@@ -1,4 +1,4 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later// SPDX-FileCopyrightText: Copyright 2020 yuzu Emulator Project@@ -2432,7 +2432,8 @@ void PlayerControlPreview::DrawProJoystick(QPainter& p, const QPointF center, co1.0 - std::sqrt((offset.x() * offset.x()) + (offset.y() * offset.y())) * 0.1f);const float rotation =- ((offset.x() == 0.f) ? std::atan(1.f) * 2.f : std::atan(offset.y() / offset.x())) * (180.f / (std::atan(1.f) * 4.f));+ ((offset.x() == 0.f) ? std::atan(1.f) * 2.f : std::atan(offset.y() / offset.x())) *+ (180.f / (std::atan(1.f) * 4.f));p.save();p.translate(offset_center);diff --git a/src/yuzu/configuration/configure_network.cpp b/src/yuzu/configuration/configure_network.cppindex 62a097117e..b1fdd018fd 100644--- a/src/yuzu/configuration/configure_network.cpp+++ b/src/yuzu/configuration/configure_network.cpp@@ -12,10 +12,7 @@#include "yuzu/configuration/configure_network.h"ConfigureNetwork::ConfigureNetwork(const Core::System& system_, QWidget* parent)- : QWidget(parent)- , ui(std::make_unique<Ui::ConfigureNetwork>())- , system{system_}-{+ : QWidget(parent), ui(std::make_unique<Ui::ConfigureNetwork>()), system{system_} {ui->setupUi(this);for (const auto& iface : Network::GetAvailableNetworkInterfaces())ui->network_interface->addItem(QString::fromStdString(iface.name));diff --git a/src/yuzu/configuration/configure_per_game.cpp b/src/yuzu/configuration/configure_per_game.cppindex 00e0a14aa3..dcf40d678f 100644--- a/src/yuzu/configuration/configure_per_game.cpp+++ b/src/yuzu/configuration/configure_per_game.cpp@@ -29,28 +29,28 @@#include "core/file_sys/xts_archive.h"#include "core/loader/loader.h"#include "frontend_common/config.h"+#include "qt_common/config/uisettings.h"#include "ui_configure_per_game.h"#include "yuzu/configuration/configuration_shared.h"+#include "yuzu/configuration/configure_applets.h"#include "yuzu/configuration/configure_audio.h"#include "yuzu/configuration/configure_cpu.h"#include "yuzu/configuration/configure_graphics.h"#include "yuzu/configuration/configure_graphics_advanced.h"#include "yuzu/configuration/configure_graphics_extensions.h"#include "yuzu/configuration/configure_input_per_game.h"+#include "yuzu/configuration/configure_network.h"#include "yuzu/configuration/configure_per_game.h"#include "yuzu/configuration/configure_per_game_addons.h"#include "yuzu/configuration/configure_system.h"-#include "yuzu/configuration/configure_network.h"-#include "yuzu/configuration/configure_applets.h"-#include "qt_common/config/uisettings.h"#include "yuzu/util/util.h"#include "yuzu/vk_device_info.h"ConfigurePerGame::ConfigurePerGame(QWidget* parent, u64 title_id_, const std::string& file_name,std::vector<VkDeviceInfo::Record>& vk_device_records,Core::System& system_)- : QDialog(parent),- ui(std::make_unique<Ui::ConfigurePerGame>()), title_id{title_id_}, system{system_},+ : QDialog(parent), ui(std::make_unique<Ui::ConfigurePerGame>()), title_id{title_id_},+ system{system_},builder{std::make_unique<ConfigurationShared::Builder>(this, !system_.IsPoweredOn())},tab_group{std::make_shared<std::vector<ConfigurationShared::Tab*>>()} {const auto file_path = std::filesystem::path(Common::FS::ToU8String(file_name));diff --git a/src/yuzu/configuration/configure_per_game.h b/src/yuzu/configuration/configure_per_game.hindex 442daab9cb..ca973db8b0 100644--- a/src/yuzu/configuration/configure_per_game.h+++ b/src/yuzu/configuration/configure_per_game.h@@ -16,10 +16,10 @@#include "configuration/shared_widget.h"#include "core/file_sys/vfs/vfs_types.h"#include "frontend_common/config.h"-#include "vk_device_info.h"-#include "yuzu/configuration/configuration_shared.h"#include "qt_common/config/qt_config.h"#include "qt_common/config/shared_translation.h"+#include "vk_device_info.h"+#include "yuzu/configuration/configuration_shared.h"namespace Core {class System;diff --git a/src/yuzu/configuration/configure_per_game_addons.cpp b/src/yuzu/configuration/configure_per_game_addons.cppindex 1d2d358672..7d0e15accc 100644--- a/src/yuzu/configuration/configure_per_game_addons.cpp+++ b/src/yuzu/configuration/configure_per_game_addons.cpp@@ -80,7 +80,8 @@ ConfigurePerGameAddons::ConfigurePerGameAddons(Core::System& system_, QWidget* pconnect(ui->folder, &QAbstractButton::clicked, this, &ConfigurePerGameAddons::InstallModFolder);connect(ui->zip, &QAbstractButton::clicked, this, &ConfigurePerGameAddons::InstallModZip);- connect(tree_view, &QTreeView::customContextMenuRequested, this, &ConfigurePerGameAddons::showContextMenu);+ connect(tree_view, &QTreeView::customContextMenuRequested, this,+ &ConfigurePerGameAddons::showContextMenu);}ConfigurePerGameAddons::~ConfigurePerGameAddons() = default;@@ -92,10 +93,10 @@ void ConfigurePerGameAddons::OnItemChanged(QStandardItem* item) {for (auto* update_item : update_items) {if (update_item != item && update_item->checkState() == Qt::Checked) {disconnect(item_model, &QStandardItemModel::itemChanged, this,- &ConfigurePerGameAddons::OnItemChanged);+ &ConfigurePerGameAddons::OnItemChanged);update_item->setCheckState(Qt::Unchecked);connect(item_model, &QStandardItemModel::itemChanged, this,- &ConfigurePerGameAddons::OnItemChanged);+ &ConfigurePerGameAddons::OnItemChanged);}}}@@ -109,7 +110,8 @@ void ConfigurePerGameAddons::ApplyConfiguration() {const auto disabled = item.front()->checkState() == Qt::Unchecked;if (disabled) {QVariant userData = item.front()->data(Qt::UserRole);- if (userData.isValid() && userData.canConvert<quint32>() && item.front()->text() == QStringLiteral("Update")) {+ if (userData.isValid() && userData.canConvert<quint32>() &&+ item.front()->text() == QStringLiteral("Update")) {quint32 numeric_version = userData.toUInt();disabled_addons.push_back(fmt::format("Update@{}", numeric_version));} else {@@ -164,7 +166,7 @@ void ConfigurePerGameAddons::InstallMods(const QStringList& mods) {}}-void ConfigurePerGameAddons::InstallModPath(const QString& path, const QString &fallbackName) {+void ConfigurePerGameAddons::InstallModPath(const QString& path, const QString& fallbackName) {const auto mods = QtCommon::Mod::GetModFolders(path, fallbackName);if (mods.size() > 1) {@@ -203,8 +205,9 @@ void ConfigurePerGameAddons::InstallModZip() {void ConfigurePerGameAddons::AddonDeleteRequested(QList<QModelIndex> selected) {QList<QModelIndex> filtered;- for (const QModelIndex &index : selected) {- if (!index.data(PATCH_LOCATION).toString().isEmpty()) filtered << index;+ for (const QModelIndex& index : selected) {+ if (!index.data(PATCH_LOCATION).toString().isEmpty())+ filtered << index;}if (filtered.empty()) {@@ -215,10 +218,9 @@ void ConfigurePerGameAddons::AddonDeleteRequested(QList<QModelIndex> selected) {return;}-const auto header = tr("You are about to delete the following installed mods:\n");QString selected_str;- for (const QModelIndex &index : filtered) {+ for (const QModelIndex& index : filtered) {selected_str = selected_str % index.data().toString() % QStringLiteral("\n");}@@ -231,9 +233,10 @@ void ConfigurePerGameAddons::AddonDeleteRequested(QList<QModelIndex> selected) {QtCommon::Frontend::StandardButton::Yes |QtCommon::Frontend::StandardButton::No);- if (choice == QtCommon::Frontend::StandardButton::No) return;+ if (choice == QtCommon::Frontend::StandardButton::No)+ return;- for (const QModelIndex &index : filtered) {+ for (const QModelIndex& index : filtered) {std::filesystem::remove_all(index.data(PATCH_LOCATION).toString().toStdString());}@@ -252,17 +255,18 @@ void ConfigurePerGameAddons::showContextMenu(const QPoint& pos) {auto selected = tree_view->selectionModel()->selectedRows();if (index.isValid() && selected.empty()) {QModelIndex idx = item_model->index(index.row(), 0);- if (idx.isValid()) selected << idx;+ if (idx.isValid())+ selected << idx;}- if (selected.empty()) return;+ if (selected.empty())+ return;QMenu menu(this);- QAction *remove = menu.addAction(tr("&Delete"));- connect(remove, &QAction::triggered, this, [this, selected]() {- AddonDeleteRequested(selected);- });+ QAction* remove = menu.addAction(tr("&Delete"));+ connect(remove, &QAction::triggered, this,+ [this, selected]() { AddonDeleteRequested(selected); });if (selected.length() == 1) {auto loc = selected.at(0).data(PATCH_LOCATION).toString();@@ -333,9 +337,11 @@ void ConfigurePerGameAddons::LoadConfiguration() {bool patch_disabled = false;if (is_external_update) {std::string disabled_key = fmt::format("Update@{}", patch.numeric_version);- patch_disabled = std::find(disabled.begin(), disabled.end(), disabled_key) != disabled.end();+ patch_disabled =+ std::find(disabled.begin(), disabled.end(), disabled_key) != disabled.end();} else {- patch_disabled = std::find(disabled.begin(), disabled.end(), name.toStdString()) != disabled.end();+ patch_disabled =+ std::find(disabled.begin(), disabled.end(), name.toStdString()) != disabled.end();}bool should_enable = !patch_disabled;diff --git a/src/yuzu/configuration/configure_per_game_addons.h b/src/yuzu/configuration/configure_per_game_addons.hindex 20ab39541b..9dd3b06928 100644--- a/src/yuzu/configuration/configure_per_game_addons.h+++ b/src/yuzu/configuration/configure_per_game_addons.h@@ -32,10 +32,7 @@ class ConfigurePerGameAddons : public QWidget {Q_OBJECTpublic:- enum PatchData {- NUMERIC_VERSION = Qt::UserRole,- PATCH_LOCATION- };+ enum PatchData { NUMERIC_VERSION = Qt::UserRole, PATCH_LOCATION };explicit ConfigurePerGameAddons(Core::System& system_, QWidget* parent = nullptr);~ConfigurePerGameAddons() override;@@ -48,7 +45,7 @@ public:void SetTitleId(u64 id);public slots:- void InstallMods(const QStringList &mods);+ void InstallMods(const QStringList& mods);void InstallModPath(const QString& path, const QString& fallbackName = {});void InstallModFolder();diff --git a/src/yuzu/configuration/configure_profile_manager.cpp b/src/yuzu/configuration/configure_profile_manager.cppindex aa19203498..0d86fb5ef9 100644--- a/src/yuzu/configuration/configure_profile_manager.cpp+++ b/src/yuzu/configuration/configure_profile_manager.cpp@@ -106,7 +106,8 @@ ConfigureProfileManager::ConfigureProfileManager(Core::System& system_, QWidget*ui->scrollArea->setLayout(layout);- connect(tree_view, &QTreeView::customContextMenuRequested, this, &ConfigureProfileManager::showContextMenu);+ connect(tree_view, &QTreeView::customContextMenuRequested, this,+ &ConfigureProfileManager::showContextMenu);connect(tree_view, &QTreeView::clicked, this, &ConfigureProfileManager::SelectUser);@@ -229,8 +230,7 @@ void ConfigureProfileManager::showContextMenu(const QPoint& pos) {QAction* edit = menu.addAction(tr("&Edit"));QAction* remove = menu.addAction(tr("&Delete"));- QAction* chosen =- menu.exec(tree_view->viewport()->mapToGlobal(pos));+ QAction* chosen = menu.exec(tree_view->viewport()->mapToGlobal(pos));if (!chosen)return;@@ -250,7 +250,7 @@ void ConfigureProfileManager::SelectUser(const QModelIndex& index) {}void ConfigureProfileManager::AddUser() {- NewUserDialog *dialog = new NewUserDialog(this);+ NewUserDialog* dialog = new NewUserDialog(this);connect(dialog, &NewUserDialog::userAdded, this, [dialog, this](User user) {auto uuid = user.uuid;@@ -285,35 +285,37 @@ void ConfigureProfileManager::EditUser() {std::string username;username.reserve(32);- std::ranges::copy_if(profile.username, std::back_inserter(username), [](u8 byte) { return byte != 0; });+ std::ranges::copy_if(profile.username, std::back_inserter(username),+ [](u8 byte) { return byte != 0; });- NewUserDialog *dialog = new NewUserDialog(uuid.value(), username, tr("Edit User"), this);+ NewUserDialog* dialog = new NewUserDialog(uuid.value(), username, tr("Edit User"), this);- connect(dialog, &NewUserDialog::userAdded, this, [dialog, profile, user_idx, uuid, this](User user) mutable {- // TODO: MOVE UUID- // auto new_uuid = user.uuid;- auto new_username = user.username;- auto pixmap = user.pixmap;+ connect(dialog, &NewUserDialog::userAdded, this,+ [dialog, profile, user_idx, uuid, this](User user) mutable {+ // TODO: MOVE UUID+ // auto new_uuid = user.uuid;+ auto new_username = user.username;+ auto pixmap = user.pixmap;- auto const uuid_val = uuid.value();+ auto const uuid_val = uuid.value();- const auto username_std = new_username.toStdString();- std::fill(profile.username.begin(), profile.username.end(), '\0');- std::copy(username_std.begin(), username_std.end(), profile.username.begin());+ const auto username_std = new_username.toStdString();+ std::fill(profile.username.begin(), profile.username.end(), '\0');+ std::copy(username_std.begin(), username_std.end(), profile.username.begin());- profile_manager.SetProfileBase(uuid_val, profile);- profile_manager.WriteUserSaveFile();+ profile_manager.SetProfileBase(uuid_val, profile);+ profile_manager.WriteUserSaveFile();- item_model->setItem(- user_idx, 0,- new QStandardItem{pixmap,- FormatUserEntryText(QString::fromStdString(username_std), uuid_val)});+ item_model->setItem(+ user_idx, 0,+ new QStandardItem{pixmap, FormatUserEntryText(+ QString::fromStdString(username_std), uuid_val)});- saveImage(pixmap, uuid_val);- UpdateCurrentUser();+ saveImage(pixmap, uuid_val);+ UpdateCurrentUser();- dialog->deleteLater();- });+ dialog->deleteLater();+ });connect(dialog, &QDialog::rejected, dialog, &QObject::deleteLater);diff --git a/src/yuzu/configuration/configure_profile_manager.h b/src/yuzu/configuration/configure_profile_manager.hindex 6e8c762452..48cd5d215f 100644--- a/src/yuzu/configuration/configure_profile_manager.h+++ b/src/yuzu/configuration/configure_profile_manager.h@@ -47,8 +47,7 @@ public:explicit ConfigureProfileManagerDeleteDialog(QWidget* parent);~ConfigureProfileManagerDeleteDialog();- void SetInfo(const QString& username, const Common::UUID& uuid,- int index);+ void SetInfo(const QString& username, const Common::UUID& uuid, int index);signals:void deleteUser(int index);@@ -71,7 +70,7 @@ public:private slots:void saveImage(QPixmap pixmap, Common::UUID uuid);- void showContextMenu(const QPoint &pos);+ void showContextMenu(const QPoint& pos);void DeleteUser(const int index);private:diff --git a/src/yuzu/configuration/configure_ringcon.cpp b/src/yuzu/configuration/configure_ringcon.cppindex dfb1540584..4c842bd069 100644--- a/src/yuzu/configuration/configure_ringcon.cpp+++ b/src/yuzu/configuration/configure_ringcon.cpp@@ -1,4 +1,4 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later// SPDX-FileCopyrightText: Copyright 2022 yuzu Emulator Project@@ -11,12 +11,12 @@#include <QTimer>#include <fmt/ranges.h>-#include "qt_common/config/qt_config.h"#include "hid_core/frontend/emulated_controller.h"#include "hid_core/hid_core.h"#include "input_common/drivers/keyboard.h"#include "input_common/drivers/mouse.h"#include "input_common/main.h"+#include "qt_common/config/qt_config.h"#include "ui_configure_ringcon.h"#include "yuzu/bootmanager.h"#include "yuzu/configuration/configure_ringcon.h"diff --git a/src/yuzu/configuration/configure_system.cpp b/src/yuzu/configuration/configure_system.cppindex 56e3e29f90..36920b1ff9 100644--- a/src/yuzu/configuration/configure_system.cpp+++ b/src/yuzu/configuration/configure_system.cpp@@ -1,4 +1,4 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later// SPDX-FileCopyrightText: 2016 Citra Emulator Project@@ -19,8 +19,8 @@#include "common/settings.h"#include "core/core.h"-#include "ui_configure_system.h"#include "qt_common/qt_compat.h"+#include "ui_configure_system.h"#include "yuzu/configuration/configuration_shared.h"#include "yuzu/configuration/configure_system.h"#include "yuzu/configuration/shared_widget.h"@@ -87,7 +87,8 @@ ConfigureSystem::ConfigureSystem(Core::System& system_,connect(combo_language, qOverload<int>(&QComboBox::currentIndexChanged), this, locale_check);connect(combo_region, qOverload<int>(&QComboBox::currentIndexChanged), this, locale_check);- connect(checkbox_rtc, qOverload<CHECKSTATE_TYPE>(&QCheckBox::STATE_CHANGED), this, update_rtc_date);+ connect(checkbox_rtc, qOverload<CHECKSTATE_TYPE>(&QCheckBox::STATE_CHANGED), this,+ update_rtc_date);connect(date_rtc_offset, qOverload<int>(&QSpinBox::valueChanged), this, update_rtc_date);connect(date_rtc, &QDateTimeEdit::dateTimeChanged, this, update_date_offset);diff --git a/src/yuzu/configuration/configure_tas.cpp b/src/yuzu/configuration/configure_tas.cppindex 75d5a5eeaf..d737b46d2c 100644--- a/src/yuzu/configuration/configure_tas.cpp+++ b/src/yuzu/configuration/configure_tas.cpp@@ -9,9 +9,9 @@#include "common/fs/fs.h"#include "common/fs/path_util.h"#include "common/settings.h"+#include "qt_common/config/uisettings.h"#include "ui_configure_tas.h"#include "yuzu/configuration/configure_tas.h"-#include "qt_common/config/uisettings.h"ConfigureTasDialog::ConfigureTasDialog(QWidget* parent): QDialog(parent), ui(std::make_unique<Ui::ConfigureTas>()) {@@ -35,7 +35,8 @@ void ConfigureTasDialog::LoadConfiguration() {ui->tas_enable->setChecked(Settings::values.tas_enable.GetValue());ui->tas_loop_script->setChecked(Settings::values.tas_loop.GetValue());ui->tas_pause_on_load->setChecked(Settings::values.pause_tas_on_load.GetValue());- ui->tas_show_recording_dialog->setChecked(Settings::values.tas_show_recording_dialog.GetValue());+ ui->tas_show_recording_dialog->setChecked(+ Settings::values.tas_show_recording_dialog.GetValue());}void ConfigureTasDialog::ApplyConfiguration() {diff --git a/src/yuzu/configuration/configure_touch_from_button.cpp b/src/yuzu/configuration/configure_touch_from_button.cppindex 2a4ae3bc89..bbd52e4bfa 100644--- a/src/yuzu/configuration/configure_touch_from_button.cpp+++ b/src/yuzu/configuration/configure_touch_from_button.cpp@@ -1,4 +1,4 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later#include <QInputDialog>@@ -548,9 +548,8 @@ bool TouchScreenPreview::eventFilter(QObject* obj, QEvent* event) {}const auto mouse_event = static_cast<QMouseEvent*>(event);if (!drag_state.active) {- drag_state.active =- (mouse_event->globalPosition().toPoint() - drag_state.start_pos).manhattanLength() >=- QApplication::startDragDistance();+ drag_state.active = (mouse_event->globalPosition().toPoint() - drag_state.start_pos)+ .manhattanLength() >= QApplication::startDragDistance();if (!drag_state.active) {break;}diff --git a/src/yuzu/configuration/configure_ui.cpp b/src/yuzu/configuration/configure_ui.cppindex 0e91a1a9fd..af8d9fecce 100644--- a/src/yuzu/configuration/configure_ui.cpp+++ b/src/yuzu/configuration/configure_ui.cpp@@ -26,8 +26,8 @@#include "core/frontend/framebuffer_layout.h"#include "ui_configure_ui.h"-#include "qt_common/qt_compat.h"#include "qt_common/config/uisettings.h"+#include "qt_common/qt_compat.h"namespace {diff --git a/src/yuzu/configuration/configure_web.cpp b/src/yuzu/configuration/configure_web.cppindex c5e9256a48..987de5989a 100644--- a/src/yuzu/configuration/configure_web.cpp+++ b/src/yuzu/configuration/configure_web.cpp@@ -1,12 +1,12 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later// SPDX-FileCopyrightText: 2017 Citra Emulator Project// SPDX-License-Identifier: GPL-2.0-or-later-#include "yuzu/configuration/configure_web.h"#include <QIcon>#include <QMessageBox>+#include "yuzu/configuration/configure_web.h"#if QT_VERSION_MAJOR >= 6#include <QRegularExpressionValidator>@@ -16,28 +16,25 @@#include <QtConcurrentRun>#include "common/settings.h"-#include "ui_configure_web.h"#include "qt_common/config/uisettings.h"+#include "ui_configure_web.h"ConfigureWeb::ConfigureWeb(QWidget* parent)- : QWidget(parent)- , ui(std::make_unique<Ui::ConfigureWeb>())- , m_rng{QRandomGenerator::system()}-{+ : QWidget(parent), ui(std::make_unique<Ui::ConfigureWeb>()), m_rng{QRandomGenerator::system()} {ui->setupUi(this);QString user_regex = QStringLiteral(".{4,20}");QString token_regex = QStringLiteral("[a-z]{48}");#if QT_VERSION_MAJOR >= 6- QRegularExpressionValidator *username_validator = new QRegularExpressionValidator(this);- QRegularExpressionValidator *token_validator = new QRegularExpressionValidator(this);+ QRegularExpressionValidator* username_validator = new QRegularExpressionValidator(this);+ QRegularExpressionValidator* token_validator = new QRegularExpressionValidator(this);username_validator->setRegularExpression(QRegularExpression(user_regex));token_validator->setRegularExpression(QRegularExpression(token_regex));#else- QRegExpValidator *username_validator = new QRegExpValidator(this);- QRegExpValidator *token_validator = new QRegExpValidator(this);+ QRegExpValidator* username_validator = new QRegExpValidator(this);+ QRegExpValidator* token_validator = new QRegExpValidator(this);username_validator->setRegExp(QRegExp(user_regex));token_validator->setRegExp(QRegExp(token_regex));@@ -121,7 +118,8 @@ void ConfigureWeb::VerifyLogin() {ui->label_token_verified->setToolTip(tr("All Good", "Tooltip"));} else {ui->label_token_verified->setPixmap(failed);- ui->label_token_verified->setToolTip(tr("Must be 48 characters, and lowercase a-z", "Tooltip"));+ ui->label_token_verified->setToolTip(+ tr("Must be 48 characters, and lowercase a-z", "Tooltip"));}}diff --git a/src/yuzu/configuration/configure_web.h b/src/yuzu/configuration/configure_web.hindex 3da7e5eccc..d37db5c020 100644--- a/src/yuzu/configuration/configure_web.h+++ b/src/yuzu/configuration/configure_web.h@@ -1,4 +1,4 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later// SPDX-FileCopyrightText: 2017 Citra Emulator Project@@ -8,8 +8,8 @@#include <QRandomGenerator>-#include <QWidget>#include <memory>+#include <QWidget>namespace Ui {class ConfigureWeb;@@ -32,7 +32,7 @@ private:void SetConfiguration();std::unique_ptr<Ui::ConfigureWeb> ui;- QRandomGenerator *m_rng;+ QRandomGenerator* m_rng;private slots:void GenerateToken();diff --git a/src/yuzu/configuration/shared_widget.cpp b/src/yuzu/configuration/shared_widget.cppindex b663ac51ee..3b425e7200 100644--- a/src/yuzu/configuration/shared_widget.cpp+++ b/src/yuzu/configuration/shared_widget.cpp@@ -45,8 +45,8 @@#include "common/logging/log.h"#include "common/settings.h"#include "common/settings_common.h"-#include "qt_common/qt_compat.h"#include "qt_common/config/shared_translation.h"+#include "qt_common/qt_compat.h"namespace ConfigurationShared {@@ -170,7 +170,7 @@ QWidget* Widget::CreateCombobox(std::function<std::string()>& serializer,if (!Settings::IsConfiguringGlobal()) {combobox->connect(combobox, QOverload<int>::of(&QComboBox::activated),- [touch]() { touch(); });+ [touch]() { touch(); });}return combobox;@@ -413,13 +413,13 @@ QWidget* Widget::CreateDoubleSpinBox(const QString& given_suffix,};if (!Settings::IsConfiguringGlobal()) {- double_spinbox->connect(double_spinbox, QOverload<double>::of(&QDoubleSpinBox::valueChanged),- [this, touch]() {- if (double_spinbox->value() !=- std::strtod(setting.ToStringGlobal().c_str(), nullptr)) {- touch();- }- });+ double_spinbox->connect(+ double_spinbox, QOverload<double>::of(&QDoubleSpinBox::valueChanged), [this, touch]() {+ if (double_spinbox->value() !=+ std::strtod(setting.ToStringGlobal().c_str(), nullptr)) {+ touch();+ }+ });}return double_spinbox;@@ -491,11 +491,11 @@ QWidget* Widget::CreateDateTimeEdit(bool disabled, bool restrict,if (!Settings::IsConfiguringGlobal()) {date_time_edit->connect(date_time_edit, &QDateTimeEdit::editingFinished,- [this, get_clear_val, touch]() {- if (date_time_edit->dateTime() != get_clear_val()) {- touch();- }- });+ [this, get_clear_val, touch]() {+ if (date_time_edit->dateTime() != get_clear_val()) {+ touch();+ }+ });}return date_time_edit;@@ -570,7 +570,8 @@ void Widget::SetupComponent(const QString& label, std::function<void()>& load_fu}if (require_checkbox) {- QWidget* lhs = CreateCheckBox(other_setting, label, checkbox_serializer, checkbox_restore_func, touch);+ QWidget* lhs =+ CreateCheckBox(other_setting, label, checkbox_serializer, checkbox_restore_func, touch);layout->addWidget(lhs, 1);} else if (type_id != "bool") {QLabel* qt_label = CreateLabel(label);@@ -665,16 +666,16 @@ void Widget::SetupComponent(const QString& label, std::function<void()>& load_fulayout->addWidget(restore_button);restore_button->connect(restore_button, &QAbstractButton::clicked,- [this, restore_func, checkbox_restore_func](bool) {- LOG_DEBUG(Frontend, "Restore global state for \"{}\"",- setting.GetLabel());+ [this, restore_func, checkbox_restore_func](bool) {+ LOG_DEBUG(Frontend, "Restore global state for \"{}\"",+ setting.GetLabel());- restore_button->setEnabled(false);- restore_button->setVisible(false);+ restore_button->setEnabled(false);+ restore_button->setVisible(false);- checkbox_restore_func();- restore_func();- });+ checkbox_restore_func();+ restore_func();+ });load_func = [this, serializer, require_checkbox, checkbox_serializer, other_setting]() {bool using_global = !restore_button->isEnabled();@@ -766,8 +767,8 @@ Widget::Widget(Settings::BasicSetting* setting_, const TranslationMap& translatiBuilder::Builder(QWidget* parent_, bool runtime_lock_): translations{InitializeTranslations(parent_)},- combobox_translations{ComboboxEnumeration(parent_)}, parent{parent_}, runtime_lock{- runtime_lock_} {}+ combobox_translations{ComboboxEnumeration(parent_)}, parent{parent_},+ runtime_lock{runtime_lock_} {}Builder::~Builder() = default;diff --git a/src/yuzu/configuration/shared_widget.h b/src/yuzu/configuration/shared_widget.hindex b07804ac00..f687d0b20c 100644--- a/src/yuzu/configuration/shared_widget.h+++ b/src/yuzu/configuration/shared_widget.h@@ -1,4 +1,4 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later// SPDX-FileCopyrightText: Copyright 2023 yuzu Emulator Project@@ -10,10 +10,10 @@#include <memory>#include <string>#include <vector>+#include <QObject>#include <QString>#include <QStringLiteral>#include <QWidget>-#include <QObject>#include <qobjectdefs.h>#include "qt_common/config/shared_translation.h"diff --git a/src/yuzu/configuration/system/new_user_dialog.h b/src/yuzu/configuration/system/new_user_dialog.hindex 656d8d7290..e81007aefe 100644--- a/src/yuzu/configuration/system/new_user_dialog.h+++ b/src/yuzu/configuration/system/new_user_dialog.h@@ -20,15 +20,15 @@ struct User {QPixmap pixmap;};-class NewUserDialog : public QDialog-{+class NewUserDialog : public QDialog {Q_OBJECTQ_PROPERTY(bool isDefaultAvatar READ isDefaultAvatar WRITE setIsDefaultAvatar NOTIFYisDefaultAvatarChanged FINAL)public:- explicit NewUserDialog(QWidget *parent = nullptr);- explicit NewUserDialog(Common::UUID uuid, const std::string &username, const QString &title, QWidget *parent = nullptr);+ explicit NewUserDialog(QWidget* parent = nullptr);+ explicit NewUserDialog(Common::UUID uuid, const std::string& username, const QString& title,+ QWidget* parent = nullptr);~NewUserDialog();bool isDefaultAvatar() const;@@ -39,8 +39,8 @@ public:static QPixmap DefaultAvatar();private:- Ui::NewUserDialog *ui;- QGraphicsScene *m_scene;+ Ui::NewUserDialog* ui;+ QGraphicsScene* m_scene;QPixmap m_pixmap;ProfileAvatarDialog* avatar_dialog;@@ -48,12 +48,12 @@ private:bool m_isDefaultAvatar = true;bool m_editing = false;- void setup(Common::UUID uuid, const std::string &username, const QString &title);+ void setup(Common::UUID uuid, const std::string& username, const QString& title);bool LoadAvatarData();std::vector<uint8_t> DecompressYaz0(const FileSys::VirtualFile& file);public slots:- void setImage(const QPixmap &pixmap);+ void setImage(const QPixmap& pixmap);void selectImage();void setAvatar();diff --git a/src/yuzu/data_dialog.cpp b/src/yuzu/data_dialog.cppindex 8caa362bdf..bbe5d43e05 100644--- a/src/yuzu/data_dialog.cpp+++ b/src/yuzu/data_dialog.cpp@@ -1,10 +1,10 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later#include "data_dialog.h"#include "frontend_common/data_manager.h"-#include "qt_common/util/content.h"#include "qt_common/qt_string_lookup.h"+#include "qt_common/util/content.h"#include "ui_data_dialog.h"#include "util/util.h"@@ -18,18 +18,14 @@#include <applets/qt_profile_select.h>-DataDialog::DataDialog(QWidget *parent)- : QDialog(parent)- , ui(std::make_unique<Ui::DataDialog>())-{+DataDialog::DataDialog(QWidget* parent) : QDialog(parent), ui(std::make_unique<Ui::DataDialog>()) {ui->setupUi(this);// TODO: Should we make this a single widget that pulls data from a model?-#define WIDGET(label, name) \- ui->page->addWidget(new DataWidget(FrontendCommon::DataManager::DataDir::name, \- QtCommon::StringLookup::DataManager##name##Tooltip, \- QStringLiteral(#name), \- this)); \+#define WIDGET(label, name) \+ ui->page->addWidget(new DataWidget(FrontendCommon::DataManager::DataDir::name, \+ QtCommon::StringLookup::DataManager##name##Tooltip, \+ QStringLiteral(#name), this)); \ui->labels->addItem(label);WIDGET(tr("Shaders"), Shaders)@@ -53,14 +49,10 @@ DataDialog::DataDialog(QWidget *parent)DataDialog::~DataDialog() = default;DataWidget::DataWidget(FrontendCommon::DataManager::DataDir data_dir,- QtCommon::StringLookup::StringKey tooltip,- const QString &exportName,- QWidget *parent)- : QWidget(parent)- , ui(std::make_unique<Ui::DataWidget>())- , m_dir(data_dir)- , m_exportName(exportName)-{+ QtCommon::StringLookup::StringKey tooltip, const QString& exportName,+ QWidget* parent)+ : QWidget(parent), ui(std::make_unique<Ui::DataWidget>()), m_dir(data_dir),+ m_exportName(exportName) {ui->setupUi(this);ui->tooltip->setText(QtCommon::StringLookup::Lookup(tooltip));@@ -78,28 +70,24 @@ DataWidget::DataWidget(FrontendCommon::DataManager::DataDir data_dir,scan();}-void DataWidget::clear()-{+void DataWidget::clear() {std::string user_id = selectProfile();QtCommon::Content::ClearDataDir(m_dir, user_id);scan();}-void DataWidget::open()-{+void DataWidget::open() {std::string user_id = selectProfile();QDesktopServices::openUrl(QUrl::fromLocalFile(QString::fromStdString(FrontendCommon::DataManager::GetDataDirString(m_dir, user_id))));}-void DataWidget::upload()-{+void DataWidget::upload() {std::string user_id = selectProfile();QtCommon::Content::ExportDataDir(m_dir, user_id, m_exportName);}-void DataWidget::download()-{+void DataWidget::download() {std::string user_id = selectProfile();QtCommon::Content::ImportDataDir(m_dir, user_id, std::bind(&DataWidget::scan, this));}@@ -107,7 +95,7 @@ void DataWidget::download()void DataWidget::scan() {ui->size->setText(tr("Calculating..."));- QFutureWatcher<u64> *watcher = new QFutureWatcher<u64>(this);+ QFutureWatcher<u64>* watcher = new QFutureWatcher<u64>(this);connect(watcher, &QFutureWatcher<u64>::finished, this, [=, this]() {u64 size = watcher->result();@@ -120,8 +108,7 @@ void DataWidget::scan() {QtConcurrent::run([this]() { return FrontendCommon::DataManager::DataDirSize(m_dir); }));}-std::string DataWidget::selectProfile()-{+std::string DataWidget::selectProfile() {std::string user_id{};if (m_dir == FrontendCommon::DataManager::DataDir::Saves) {user_id = GetProfileIDString();diff --git a/src/yuzu/data_dialog.h b/src/yuzu/data_dialog.hindex 70714be7cb..7f988f6047 100644--- a/src/yuzu/data_dialog.h+++ b/src/yuzu/data_dialog.h@@ -1,4 +1,4 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later#ifndef DATA_DIALOG_H@@ -14,26 +14,23 @@ namespace Ui {class DataDialog;}-class DataDialog : public QDialog-{+class DataDialog : public QDialog {Q_OBJECTpublic:- explicit DataDialog(QWidget *parent = nullptr);+ explicit DataDialog(QWidget* parent = nullptr);~DataDialog();private:std::unique_ptr<Ui::DataDialog> ui;};-class DataWidget : public QWidget-{+class DataWidget : public QWidget {Q_OBJECTpublic:explicit DataWidget(FrontendCommon::DataManager::DataDir data_dir,- QtCommon::StringLookup::StringKey tooltip,- const QString &exportName,- QWidget *parent = nullptr);+ QtCommon::StringLookup::StringKey tooltip, const QString& exportName,+ QWidget* parent = nullptr);public slots:void clear();diff --git a/src/yuzu/debugger/console.cpp b/src/yuzu/debugger/console.cppindex e93a8b9265..44d4e1db7b 100644--- a/src/yuzu/debugger/console.cpp+++ b/src/yuzu/debugger/console.cpp@@ -1,4 +1,4 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later// SPDX-FileCopyrightText: Copyright 2018 yuzu Emulator Project@@ -11,8 +11,8 @@#endif#include "common/logging/backend.h"-#include "yuzu/debugger/console.h"#include "qt_common/config/uisettings.h"+#include "yuzu/debugger/console.h"namespace Debugger {void ToggleConsole() {diff --git a/src/yuzu/deps_dialog.cpp b/src/yuzu/deps_dialog.cppindex ffbd0a0e74..e490bfc163 100644--- a/src/yuzu/deps_dialog.cpp+++ b/src/yuzu/deps_dialog.cpp@@ -1,24 +1,21 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later-#include "yuzu/deps_dialog.h"#include <QAbstractTextDocumentLayout>#include <QDesktopServices>#include <QIcon>#include <QPainter>#include <QTableWidget>#include <QTextEdit>+#include <fmt/ranges.h>#include "dep_hashes.h"#include "ui_deps_dialog.h"-#include <fmt/ranges.h>+#include "yuzu/deps_dialog.h"-DepsDialog::DepsDialog(QWidget* parent)- : QDialog(parent)- , ui{std::make_unique<Ui::DepsDialog>()}-{+DepsDialog::DepsDialog(QWidget* parent) : QDialog(parent), ui{std::make_unique<Ui::DepsDialog>()} {ui->setupUi(this);- constexpr int rows = (int) Common::dep_hashes.size();+ constexpr int rows = (int)Common::dep_hashes.size();ui->tableDeps->setRowCount(rows);QStringList labels;@@ -36,8 +33,8 @@ DepsDialog::DepsDialog(QWidget* parent)std::string dependency = fmt::format("<a href=\"{}\">{}</a>", url, name);- QTableWidgetItem *nameItem = new QTableWidgetItem(QString::fromStdString(dependency));- QTableWidgetItem *shaItem = new QTableWidgetItem(QString::fromStdString(sha));+ QTableWidgetItem* nameItem = new QTableWidgetItem(QString::fromStdString(dependency));+ QTableWidgetItem* shaItem = new QTableWidgetItem(QString::fromStdString(sha));ui->tableDeps->setItem(i, 0, nameItem);ui->tableDeps->setItem(i, 1, shaItem);@@ -48,14 +45,10 @@ DepsDialog::DepsDialog(QWidget* parent)DepsDialog::~DepsDialog() = default;-LinkItemDelegate::LinkItemDelegate(QObject *parent)- : QStyledItemDelegate(parent)-{}+LinkItemDelegate::LinkItemDelegate(QObject* parent) : QStyledItemDelegate(parent) {}-void LinkItemDelegate::paint(QPainter *painter,- const QStyleOptionViewItem &option,- const QModelIndex &index) const-{+void LinkItemDelegate::paint(QPainter* painter, const QStyleOptionViewItem& option,+ const QModelIndex& index) const {auto options = option;initStyleOption(&options, index);@@ -71,8 +64,8 @@ void LinkItemDelegate::paint(QPainter *painter,painter->restore();}-QSize LinkItemDelegate::sizeHint(const QStyleOptionViewItem &option, const QModelIndex &index) const-{+QSize LinkItemDelegate::sizeHint(const QStyleOptionViewItem& option,+ const QModelIndex& index) const {QStyleOptionViewItem options = option;initStyleOption(&options, index);@@ -82,13 +75,10 @@ QSize LinkItemDelegate::sizeHint(const QStyleOptionViewItem &option, const QModereturn QSize(doc.idealWidth(), doc.size().height());}-bool LinkItemDelegate::editorEvent(QEvent *event,- QAbstractItemModel *model,- const QStyleOptionViewItem &option,- const QModelIndex &index)-{+bool LinkItemDelegate::editorEvent(QEvent* event, QAbstractItemModel* model,+ const QStyleOptionViewItem& option, const QModelIndex& index) {if (event->type() == QEvent::MouseButtonRelease) {- QMouseEvent *mouseEvent = static_cast<QMouseEvent *>(event);+ QMouseEvent* mouseEvent = static_cast<QMouseEvent*>(event);if (mouseEvent->button() == Qt::LeftButton) {QString html = index.data(Qt::DisplayRole).toString();QTextDocument doc;@@ -96,7 +86,7 @@ bool LinkItemDelegate::editorEvent(QEvent *event,doc.setTextWidth(option.rect.width());// this is kinda silly but it werks- QAbstractTextDocumentLayout *layout = doc.documentLayout();+ QAbstractTextDocumentLayout* layout = doc.documentLayout();QPoint pos = mouseEvent->pos() - option.rect.topLeft();int charPos = layout->hitTest(pos, Qt::ExactHit);diff --git a/src/yuzu/deps_dialog.h b/src/yuzu/deps_dialog.hindex f8e7f1d987..fab2f0b1ca 100644--- a/src/yuzu/deps_dialog.h+++ b/src/yuzu/deps_dialog.h@@ -1,41 +1,38 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later#pragma once+#include <memory>#include <QDialog>#include <QStyledItemDelegate>#include <QTableView>-#include <memory>-namespace Ui { class DepsDialog; }+namespace Ui {+class DepsDialog;+}-class DepsDialog : public QDialog-{+class DepsDialog : public QDialog {Q_OBJECTpublic:- explicit DepsDialog(QWidget *parent);+ explicit DepsDialog(QWidget* parent);~DepsDialog() override;private:std::unique_ptr<Ui::DepsDialog> ui;};-class LinkItemDelegate : public QStyledItemDelegate-{+class LinkItemDelegate : public QStyledItemDelegate {Q_OBJECTpublic:- explicit LinkItemDelegate(QObject *parent = 0);+ explicit LinkItemDelegate(QObject* parent = 0);protected:- void paint(QPainter *painter,- const QStyleOptionViewItem &option,- const QModelIndex &index) const override;- QSize sizeHint(const QStyleOptionViewItem &option, const QModelIndex &index) const override;- bool editorEvent(QEvent *event,- QAbstractItemModel *model,- const QStyleOptionViewItem &option,- const QModelIndex &index) override;+ void paint(QPainter* painter, const QStyleOptionViewItem& option,+ const QModelIndex& index) const override;+ QSize sizeHint(const QStyleOptionViewItem& option, const QModelIndex& index) const override;+ bool editorEvent(QEvent* event, QAbstractItemModel* model, const QStyleOptionViewItem& option,+ const QModelIndex& index) override;};diff --git a/src/yuzu/game/game_card.cpp b/src/yuzu/game/game_card.cppindex 26ab99faaf..ba60b54fcc 100644--- a/src/yuzu/game/game_card.cpp+++ b/src/yuzu/game/game_card.cpp@@ -73,9 +73,7 @@ void GameCard::paint(QPainter* painter, const QStyleOptionViewItem& option,painter->restore();} else {// if there is no icon just draw a blank rect- iconRect = QRect(cardRect.left() + padding,- cardRect.top() + padding,- _iconsize, _iconsize);+ iconRect = QRect(cardRect.left() + padding, cardRect.top() + padding, _iconsize, _iconsize);}if (UISettings::values.show_game_name.GetValue()) {diff --git a/src/yuzu/game/game_card.h b/src/yuzu/game/game_card.hindex 9fd0ec081a..86387452b6 100644--- a/src/yuzu/game/game_card.h+++ b/src/yuzu/game/game_card.h@@ -14,12 +14,10 @@ class GameCard : public QStyledItemDelegate {public:explicit GameCard(QObject* parent = nullptr);- void paint(QPainter *painter,- const QStyleOptionViewItem &option,- const QModelIndex &index) const override;+ void paint(QPainter* painter, const QStyleOptionViewItem& option,+ const QModelIndex& index) const override;- QSize sizeHint(const QStyleOptionViewItem &option,- const QModelIndex &index) const override;+ QSize sizeHint(const QStyleOptionViewItem& option, const QModelIndex& index) const override;void setSize(const QSize& newSize, const int padding);private:diff --git a/src/yuzu/game/game_list.cpp b/src/yuzu/game/game_list.cppindex c57198848f..344cff445c 100644--- a/src/yuzu/game/game_list.cpp+++ b/src/yuzu/game/game_list.cpp@@ -218,11 +218,13 @@ void GameList::OnTextChanged(const QString& new_text) {for (int i = 0; i < row_count; ++i) {QStandardItem* item = item_model->item(i, 0);- if (!item) continue;+ if (!item)+ continue;children_total++;- const QString file_path = item->data(GameListItemPath::FullPathRole).toString().toLower();+ const QString file_path =+ item->data(GameListItemPath::FullPathRole).toString().toLower();const QString file_title = item->data(GameListItemPath::TitleRole).toString().toLower();const QString file_name = file_path.mid(file_path.lastIndexOf(QLatin1Char{'/'}) + 1) +QLatin1Char{' '} + file_title;@@ -236,7 +238,8 @@ void GameList::OnTextChanged(const QString& new_text) {}search_field->setFilterResult(result_count, children_total);} else if (edit_filter_text.isEmpty()) {- hide(0, UISettings::values.favorited_ids.size() == 0, item_model->invisibleRootItem()->index());+ hide(0, UISettings::values.favorited_ids.size() == 0,+ item_model->invisibleRootItem()->index());for (int i = 1; i < item_model->rowCount() - 1; ++i) {folder = item_model->item(i, 0);const QModelIndex folder_index = folder->index();@@ -362,7 +365,8 @@ GameList::GameList(FileSys::VirtualFilesystem vfs_, FileSys::ManualContentProvidexternal_watcher = new QFileSystemWatcher(this);ResetExternalWatcher();- connect(external_watcher, &QFileSystemWatcher::directoryChanged, this, &GameList::RefreshExternalContent);+ connect(external_watcher, &QFileSystemWatcher::directoryChanged, this,+ &GameList::RefreshExternalContent);this->main_window = parent;layout = new QVBoxLayout;@@ -471,7 +475,7 @@ bool GameList::IsTreeMode() {}void GameList::ResetViewMode() {- auto &setting = UISettings::values.game_list_mode;+ auto& setting = UISettings::values.game_list_mode;bool newTreeMode = false;switch (setting.GetValue()) {@@ -678,7 +682,7 @@ void GameList::PopupContextMenu(const QPoint& menu_location) {return;QMenu blank_menu;- QAction *addGameDirAction = blank_menu.addAction(tr("&Add New Game Directory"));+ QAction* addGameDirAction = blank_menu.addAction(tr("&Add New Game Directory"));connect(addGameDirAction, &QAction::triggered, this, &GameList::AddDirectory);blank_menu.exec(m_currentView->viewport()->mapToGlobal(menu_location));@@ -1113,8 +1117,7 @@ const QStringList GameList::supported_file_extensions = {QStringLiteral("nso"), QStringLiteral("nro"), QStringLiteral("nca"),QStringLiteral("xci"), QStringLiteral("nsp"), QStringLiteral("kip")};-void GameList::RefreshGameDirectory()-{+void GameList::RefreshGameDirectory() {// Reset the externals watcher whenever the game list is reloaded,// primarily ensures that new titles and external dirs are caught.ResetExternalWatcher();@@ -1142,7 +1145,7 @@ void GameList::ResetExternalWatcher() {external_watcher->removePaths(watch_dirs);}- for (const std::string &dir : Settings::values.external_content_dirs) {+ for (const std::string& dir : Settings::values.external_content_dirs) {external_watcher->addPath(QString::fromStdString(dir));}}@@ -1286,8 +1289,8 @@ bool GameList::eventFilter(QObject* obj, QEvent* event) {horizontal_scroll_target = m_currentView->horizontalScrollBar()->value();horizontal_scroll_target -= deltaX;- horizontal_scroll_target =- qBound(0, horizontal_scroll_target, m_currentView->horizontalScrollBar()->maximum());+ horizontal_scroll_target = qBound(0, horizontal_scroll_target,+ m_currentView->horizontalScrollBar()->maximum());horizontal_scroll->stop();horizontal_scroll->setStartValue(m_currentView->horizontalScrollBar()->value());diff --git a/src/yuzu/game/game_list.h b/src/yuzu/game/game_list.hindex 7de622b714..42efcbdc3b 100644--- a/src/yuzu/game/game_list.h+++ b/src/yuzu/game/game_list.h@@ -21,10 +21,10 @@#include "common/common_types.h"#include "core/core.h"+#include "frontend_common/play_time_manager.h"#include "qt_common/config/uisettings.h"#include "qt_common/util/game.h"#include "yuzu/compatibility_list.h"-#include "frontend_common/play_time_manager.h"class QVariantAnimation;@@ -124,7 +124,7 @@ signals:void NavigateToGamedbEntryRequested(u64 program_id,const CompatibilityList& compatibility_list);void OpenPerGameGeneralRequested(const std::string& file);- void LinkToRyujinxRequested(const u64 &program_id);+ void LinkToRyujinxRequested(const u64& program_id);void OpenDirectory(const QString& directory);void AddDirectory();void ShowList(bool show);@@ -170,8 +170,8 @@ private:QVBoxLayout* layout = nullptr;QTreeView* tree_view = nullptr;- QListView *list_view = nullptr;- GameCard *m_gameCard = nullptr;+ QListView* list_view = nullptr;+ GameCard* m_gameCard = nullptr;QStandardItemModel* item_model = nullptr;std::unique_ptr<GameListWorker> current_worker;@@ -194,7 +194,7 @@ private:Core::System& system;bool m_isTreeMode = true;- QAbstractItemView *m_currentView = tree_view;+ QAbstractItemView* m_currentView = tree_view;};class GameListPlaceholder : public QWidget {diff --git a/src/yuzu/game/game_list_p.h b/src/yuzu/game/game_list_p.hindex 9bae5b9e01..004f8917ad 100644--- a/src/yuzu/game/game_list_p.h+++ b/src/yuzu/game/game_list_p.h@@ -14,10 +14,10 @@#include <QCoreApplication>#include <QFileInfo>#include <QObject>+#include <QRegularExpression>#include <QStandardItem>#include <QString>#include <QWidget>-#include <QRegularExpression>#include "common/common_types.h"#include "common/logging/log.h"@@ -77,7 +77,7 @@ public:GameListItemPath() = default;GameListItemPath(const QString& game_path, const std::vector<u8>& picture_data,const QString& game_name, const QString& game_type, u64 program_id,- u64 play_time, const QString &patch_versions) {+ u64 play_time, const QString& patch_versions) {setData(type(), TypeRole);setData(game_path, FullPathRole);setData(game_name, TitleRole);@@ -85,14 +85,15 @@ public:setData(game_type, FileTypeRole);const auto readable_play_time =- play_time > 0- ? QObject::tr("Play Time: %1").arg(QString::fromStdString(PlayTime::PlayTimeManager::GetReadablePlayTime(play_time)))- : QObject::tr("Never Played");+ play_time > 0 ? QObject::tr("Play Time: %1")+ .arg(QString::fromStdString(+ PlayTime::PlayTimeManager::GetReadablePlayTime(play_time)))+ : QObject::tr("Never Played");const auto enabled_update = [patch_versions]() -> QString {const QStringList lines = patch_versions.split(QLatin1Char('\n'));const QRegularExpression regex{QStringLiteral(R"(^Update \(([0-9\.]+)\))")};- for (const QString &line : std::as_const(lines)) {+ for (const QString& line : std::as_const(lines)) {const auto match = regex.match(line);if (match.hasMatch() && match.hasCaptured(1))return QObject::tr("Version: %1").arg(match.captured(1));@@ -100,9 +101,7 @@ public:return QObject::tr("Version: 1.0.0");}();- const auto tooltip = QStringLiteral("%1\n%2").arg(- readable_play_time,- enabled_update);+ const auto tooltip = QStringLiteral("%1\n%2").arg(readable_play_time, enabled_update);setData(tooltip, Qt::ToolTipRole);@@ -145,7 +144,7 @@ public:return row1.toLower();}- // None+ // Noneif (row2_id == 4) {return row1;}@@ -163,7 +162,6 @@ public:default:break;}-}return GameListItem::data(role);diff --git a/src/yuzu/game/game_list_worker.cpp b/src/yuzu/game/game_list_worker.cppindex 81012e4374..777122e135 100644--- a/src/yuzu/game/game_list_worker.cpp+++ b/src/yuzu/game/game_list_worker.cpp@@ -30,11 +30,11 @@#include "core/file_sys/romfs.h"#include "core/file_sys/submission_package.h"#include "core/loader/loader.h"+#include "qt_common/config/uisettings.h"#include "yuzu/compatibility_list.h"#include "yuzu/game/game_list.h"#include "yuzu/game/game_list_p.h"#include "yuzu/game/game_list_worker.h"-#include "qt_common/config/uisettings.h"namespace {@@ -198,26 +198,24 @@ QString FormatPatchNameVersions(const FileSys::PatchManager& patch_manager,return out;}-QList<QStandardItem*> MakeGameListEntry(const std::string& path,- const std::string& name,- const std::size_t size,- const std::vector<u8>& icon,- Loader::AppLoader& loader,- u64 program_id,+QList<QStandardItem*> MakeGameListEntry(const std::string& path, const std::string& name,+ const std::size_t size, const std::vector<u8>& icon,+ Loader::AppLoader& loader, u64 program_id,const CompatibilityList& compatibility_list,const PlayTime::PlayTimeManager& play_time_manager,- const FileSys::PatchManager& patch)-{+ const FileSys::PatchManager& patch) {auto const it = FindMatchingCompatibilityEntry(compatibility_list, program_id);// The game list uses 99 as compatibility number for untested games- QString compatibility = it != compatibility_list.end() ? it->second.first : QStringLiteral("99");+ QString compatibility =+ it != compatibility_list.end() ? it->second.first : QStringLiteral("99");auto const file_type = loader.GetFileType();auto const file_type_string = QString::fromStdString(Loader::GetFileTypeString(file_type));- QString patch_versions = GetGameListCachedObject(fmt::format("{:016X}", patch.GetTitleID()), "pv.txt", [&patch, &loader] {- return FormatPatchNameVersions(patch, loader, loader.IsRomFSUpdatable());- });+ QString patch_versions = GetGameListCachedObject(+ fmt::format("{:016X}", patch.GetTitleID()), "pv.txt", [&patch, &loader] {+ return FormatPatchNameVersions(patch, loader, loader.IsRomFSUpdatable());+ });u64 play_time = play_time_manager.GetPlayTime(program_id);return QList<QStandardItem*>{@@ -238,13 +236,9 @@ GameListWorker::GameListWorker(FileSys::VirtualFilesystem vfs_,const CompatibilityList& compatibility_list_,const PlayTime::PlayTimeManager& play_time_manager_,Core::System& system_)- : vfs{std::move(vfs_)}- , provider{provider_}- , game_dirs{game_dirs_}- , compatibility_list{compatibility_list_}- , play_time_manager{play_time_manager_}- , system{system_}-{+ : vfs{std::move(vfs_)}, provider{provider_}, game_dirs{game_dirs_},+ compatibility_list{compatibility_list_}, play_time_manager{play_time_manager_},+ system{system_} {// We want the game list to manage our lifetime.setAutoDelete(false);}@@ -338,15 +332,8 @@ void GameListWorker::AddTitlesToGameList(GameListDir* parent_dir) {GetMetadataFromControlNCA(patch, *control, icon, name);}- auto entry = MakeGameListEntry(file->GetFullPath(),- name,- file->GetSize(),- icon,- *loader,- program_id,- compatibility_list,- play_time_manager,- patch);+ auto entry = MakeGameListEntry(file->GetFullPath(), name, file->GetSize(), icon, *loader,+ program_id, compatibility_list, play_time_manager, patch);RecordEvent([=](GameList* game_list) { game_list->AddEntry(entry, parent_dir); });}}@@ -424,15 +411,9 @@ void GameListWorker::ScanFileSystem(ScanTarget target, const std::string& dir_paconst FileSys::PatchManager patch{id, system.GetFileSystemController(),system.GetContentProvider()};- auto entry = MakeGameListEntry(physical_name,- name,- Common::FS::GetSize(physical_name),- icon,- *loader,- id,- compatibility_list,- play_time_manager,- patch);+ auto entry = MakeGameListEntry(+ physical_name, name, Common::FS::GetSize(physical_name), icon, *loader,+ id, compatibility_list, play_time_manager, patch);RecordEvent([=](GameList* game_list) { game_list->AddEntry(entry, parent_dir); });@@ -447,15 +428,9 @@ void GameListWorker::ScanFileSystem(ScanTarget target, const std::string& dir_paconst FileSys::PatchManager patch{program_id, system.GetFileSystemController(),system.GetContentProvider()};- auto entry = MakeGameListEntry(physical_name,- name,- Common::FS::GetSize(physical_name),- icon,- *loader,- program_id,- compatibility_list,- play_time_manager,- patch);+ auto entry = MakeGameListEntry(+ physical_name, name, Common::FS::GetSize(physical_name), icon, *loader,+ program_id, compatibility_list, play_time_manager, patch);RecordEvent([=](GameList* game_list) { game_list->AddEntry(entry, parent_dir); });diff --git a/src/yuzu/game/game_list_worker.h b/src/yuzu/game/game_list_worker.hindex 76153f7917..bf67585fe6 100644--- a/src/yuzu/game/game_list_worker.h+++ b/src/yuzu/game/game_list_worker.h@@ -18,9 +18,9 @@#include "common/thread.h"#include "core/file_sys/registered_cache.h"+#include "frontend_common/play_time_manager.h"#include "qt_common/config/uisettings.h"#include "yuzu/compatibility_list.h"-#include "frontend_common/play_time_manager.h"namespace Core {class System;diff --git a/src/yuzu/hotkeys.cpp b/src/yuzu/hotkeys.cppindex 10e407402b..5ca437a597 100644--- a/src/yuzu/hotkeys.cpp+++ b/src/yuzu/hotkeys.cpp@@ -1,4 +1,4 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later// SPDX-FileCopyrightText: 2014 Citra Emulator Project@@ -10,8 +10,8 @@#include <QtGlobal>#include "hid_core/frontend/emulated_controller.h"-#include "yuzu/hotkeys.h"#include "qt_common/config/uisettings.h"+#include "yuzu/hotkeys.h"HotkeyRegistry::HotkeyRegistry() = default;HotkeyRegistry::~HotkeyRegistry() = default;diff --git a/src/yuzu/install_dialog.cpp b/src/yuzu/install_dialog.cppindex 1b772a0eba..de42297618 100644--- a/src/yuzu/install_dialog.cpp+++ b/src/yuzu/install_dialog.cpp@@ -1,4 +1,4 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later// SPDX-FileCopyrightText: Copyright 2020 yuzu Emulator Project@@ -10,8 +10,8 @@#include <QLabel>#include <QListWidget>#include <QVBoxLayout>-#include "yuzu/install_dialog.h"#include "qt_common/config/uisettings.h"+#include "yuzu/install_dialog.h"InstallDialog::InstallDialog(QWidget* parent, const QStringList& files) : QDialog(parent) {file_list = new QListWidget(this);diff --git a/src/yuzu/libqt_common.cpp b/src/yuzu/libqt_common.cppindex 6da75033af..198d1b66be 100644--- a/src/yuzu/libqt_common.cpp+++ b/src/yuzu/libqt_common.cpp@@ -1,11 +1,11 @@// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later+#include <QAbstractButton>#include <QFileDialog>#include <QInputDialog>#include <QMessageBox>#include <QProgressDialog>-#include <QAbstractButton>#include "libqt_common.h"#include "qt_common/abstract/frontend.h"@@ -14,10 +14,11 @@namespace QtCommon::Frontend {-StandardButton ShowMessage(- Icon icon, const QString &title, const QString &text, StandardButtons buttons, QObject *parent)-{- QMessageBox *box = new QMessageBox(QMessageBox::Icon(int(icon)), title, text, QMessageBox::StandardButtons(int(buttons)), (QWidget *) parent);+StandardButton ShowMessage(Icon icon, const QString& title, const QString& text,+ StandardButtons buttons, QObject* parent) {+ QMessageBox* box =+ new QMessageBox(QMessageBox::Icon(int(icon)), title, text,+ QMessageBox::StandardButtons(int(buttons)), (QWidget*)parent);return StandardButton(box->exec());}@@ -81,15 +82,15 @@ void WidgetsProgressDialog::show() {m_dialog->show();}-std::unique_ptr<QtProgressDialog> newProgressDialog(const QString& labelText, const QString& cancelButtonText,- int minimum, int maximum, Qt::WindowFlags f) {+std::unique_ptr<QtProgressDialog> newProgressDialog(const QString& labelText,+ const QString& cancelButtonText, int minimum,+ int maximum, Qt::WindowFlags f) {return std::make_unique<WidgetsProgressDialog>(labelText, cancelButtonText, minimum, maximum,(QWidget*)rootObject, f);}QtProgressDialog* newProgressDialogPtr(const QString& labelText, const QString& cancelButtonText,- int minimum, int maximum,- Qt::WindowFlags f) {+ int minimum, int maximum, Qt::WindowFlags f) {return new WidgetsProgressDialog(labelText, cancelButtonText, minimum, maximum,(QWidget*)rootObject, f);}@@ -115,5 +116,4 @@ const QString GetTextInput(const QString& title, const QString& caption,return QInputDialog::getText(rootObject, title, caption, QLineEdit::Normal, defaultText);}-} // namespace QtCommon::Frontenddiff --git a/src/yuzu/libqt_common.h b/src/yuzu/libqt_common.hindex 9fb0add154..356fd65d2b 100644--- a/src/yuzu/libqt_common.h+++ b/src/yuzu/libqt_common.h@@ -34,4 +34,4 @@ private:QProgressDialog* m_dialog;};-}+} // namespace QtCommon::Frontenddiff --git a/src/yuzu/loading_screen.cpp b/src/yuzu/loading_screen.cppindex d6550a2c81..d67667a91d 100644--- a/src/yuzu/loading_screen.cpp+++ b/src/yuzu/loading_screen.cpp@@ -4,7 +4,6 @@// SPDX-FileCopyrightText: Copyright 2019 yuzu Emulator Project// SPDX-License-Identifier: GPL-2.0-or-later-#include <ankerl/unordered_dense.h>#include <QBuffer>#include <QByteArray>#include <QGraphicsOpacityEffect>@@ -14,6 +13,7 @@#include <QPixmap>#include <QPropertyAnimation>#include <QStyleOption>+#include <ankerl/unordered_dense.h>#include "core/frontend/framebuffer_layout.h"#include "core/loader/loader.h"#include "ui_loading_screen.h"diff --git a/src/yuzu/main.cpp b/src/yuzu/main.cppindex c6b4fde83e..f8528d9671 100644--- a/src/yuzu/main.cpp+++ b/src/yuzu/main.cpp@@ -5,8 +5,8 @@#include "startup_checks.h"#if YUZU_ROOM-#include "dedicated_room/yuzu_room.h"#include <cstring>+#include "dedicated_room/yuzu_room.h"#endif#include <common/detached_tasks.h>@@ -62,9 +62,8 @@ static Qt::HighDpiScaleFactorRoundingPolicy GetHighDpiRoundingPolicy() {// Get the lower of the 2 ratios and truncate, this is the maximum integer scale.const qreal max_ratio = std::trunc(std::min(width_ratio, height_ratio));- return max_ratio > real_ratio- ? Qt::HighDpiScaleFactorRoundingPolicy::Round- : Qt::HighDpiScaleFactorRoundingPolicy::Floor;+ return max_ratio > real_ratio ? Qt::HighDpiScaleFactorRoundingPolicy::Round+ : Qt::HighDpiScaleFactorRoundingPolicy::Floor;#else// Other OSes should be better than Windows at fractional scaling.return Qt::HighDpiScaleFactorRoundingPolicy::PassThrough;@@ -174,7 +173,7 @@ int main(int argc, char* argv[]) {main_window.show();app.connect(&app, &QGuiApplication::applicationStateChanged, &main_window,- &MainWindow::OnAppFocusStateChanged);+ &MainWindow::OnAppFocusStateChanged);int result = app.exec();detached_tasks.WaitForAllTasks();diff --git a/src/yuzu/main_window.cpp b/src/yuzu/main_window.cppindex aaac46bffb..a251451bea 100644--- a/src/yuzu/main_window.cpp+++ b/src/yuzu/main_window.cpp@@ -19,8 +19,8 @@#include "ui_main.h"// Other Yuzu stuff //-#include "debugger/controller.h"#include "debugger/console.h"+#include "debugger/controller.h"#include "about_dialog.h"#include "data_dialog.h"@@ -28,18 +28,18 @@#include "install_dialog.h"#include "bootmanager.h"-#include "yuzu/game/game_list.h"#include "loading_screen.h"#include "ryujinx_dialog.h"#include "set_play_time_dialog.h"#include "util/util.h"#include "vk_device_info.h"+#include "yuzu/game/game_list.h"#include "applets/qt_amiibo_settings.h"#include "applets/qt_controller.h"+#include "applets/qt_error.h"#include "applets/qt_profile_select.h"#include "applets/qt_software_keyboard.h"-#include "applets/qt_error.h"#include "applets/qt_web_browser.h"#include "configuration/configure_dialog.h"@@ -48,8 +48,8 @@#include "configuration/configure_tas.h"#include "util/clickable_label.h"-#include "util/overlay_dialog.h"#include "util/controller_navigation.h"+#include "util/overlay_dialog.h"#include "multiplayer/state.h"@@ -60,6 +60,7 @@#include <QStyleHints>#endif+#include <QActionGroup>#include <QCheckBox>#include <QClipboard>#include <QDesktopServices>@@ -68,32 +69,32 @@#include <QFileInfo>#include <QGuiApplication>#include <QInputDialog>+#include <QMimeData>#include <QPalette>#include <QProgressDialog>#include <QScreen>#include <QShortcut>#include <QStatusBar>#include <QtConcurrentRun>-#include <QMimeData>-#include <QActionGroup>// Qt Common //-#include "qt_common/config/uisettings.h"#include "qt_common/config/shared_translation.h"+#include "qt_common/config/uisettings.h"#include "qt_common/abstract/frontend.h"#include "qt_common/qt_common.h"-#include "qt_common/util/path.h"-#include "qt_common/util/meta.h"#include "qt_common/util/content.h"#include "qt_common/util/fs.h"+#include "qt_common/util/meta.h"#include "qt_common/util/mod.h"+#include "qt_common/util/path.h"// These are wrappers to avoid the calls to CreateDirectory and CreateFile because of the Windows// defines.-static FileSys::VirtualDir VfsFilesystemCreateDirectoryWrapper(const std::string& path, FileSys::OpenMode mode) {+static FileSys::VirtualDir VfsFilesystemCreateDirectoryWrapper(const std::string& path,+ FileSys::OpenMode mode) {return QtCommon::vfs->CreateDirectory(path, mode);}@@ -122,14 +123,14 @@ static FileSys::VirtualFile VfsDirectoryCreateFileWrapper(const FileSys::Virtual#endif// Core //-#include "core/frontend/applets/software_keyboard.h"-#include "core/frontend/applets/mii_edit.h"#include "core/frontend/applets/general.h"+#include "core/frontend/applets/mii_edit.h"+#include "core/frontend/applets/software_keyboard.h"+#include "core/hle/kernel/k_process.h"#include "core/hle/service/acc/profile_manager.h"#include "core/hle/service/am/applet_manager.h"#include "core/hle/service/am/frontend/applet_web_browser_types.h"-#include "core/hle/kernel/k_process.h"#include "core/file_sys/card_image.h"#include "core/file_sys/romfs.h"@@ -142,8 +143,8 @@ static FileSys::VirtualFile VfsDirectoryCreateFileWrapper(const FileSys::Virtual#include "core/crypto/key_manager.h"// Input //-#include "hid_core/hid_core.h"#include "hid_core/frontend/emulated_controller.h"+#include "hid_core/hid_core.h"#include "input_common/drivers/virtual_amiibo.h"// Video Core //@@ -165,17 +166,17 @@ static FileSys::VirtualFile VfsDirectoryCreateFileWrapper(const FileSys::Virtual#ifdef __unix__#include <csignal>+#include <QSocketNotifier>#include <sys/socket.h>#include "qt_common/gui_settings.h"-#include <QSocketNotifier>#endif#include "qt_common/gamemode.h"#ifdef _WIN32-#include "core/core_timing.h"#include "common/windows/timer_resolution.h"+#include "core/core_timing.h"#include <QPlatformSurfaceEvent>#include <QSettings>@@ -381,7 +382,7 @@ static QString PrettyProductName() {namespace {-constexpr std::array<std::pair<u32, const char *>, 5> default_game_icon_sizes{+constexpr std::array<std::pair<u32, const char*>, 5> default_game_icon_sizes{std::make_pair(0, QT_TRANSLATE_NOOP("MainWindow", "None")),std::make_pair(32, QT_TRANSLATE_NOOP("MainWindow", "Small (32x32)")),std::make_pair(64, QT_TRANSLATE_NOOP("MainWindow", "Standard (64x64)")),@@ -393,7 +394,7 @@ QString GetTranslatedGameIconSize(size_t index) {return QCoreApplication::translate("MainWindow", default_game_icon_sizes[index].second);}-}+} // namespace#ifndef _WIN32// TODO(crueter): carboxyl does this, is it needed in qml?@@ -412,7 +413,7 @@ inline static bool isDarkMode() {MainWindow::MainWindow(bool has_broken_vulkan): ui{std::make_unique<Ui::MainWindow>()},- input_subsystem{std::make_shared<InputCommon::InputSubsystem>()}, user_data_migrator{this} {+ input_subsystem{std::make_shared<InputCommon::InputSubsystem>()}, user_data_migrator{this} {QtCommon::Init(this);Common::FS::CreateEdenPaths();@@ -423,17 +424,14 @@ MainWindow::MainWindow(bool has_broken_vulkan)using namespace Common::FS;- static constexpr const std::array<const EdenPath, 4> paths = {EdenPath::NANDDir,- EdenPath::SDMCDir,- EdenPath::DumpDir,- EdenPath::LoadDir};+ static constexpr const std::array<const EdenPath, 4> paths = {+ EdenPath::NANDDir, EdenPath::SDMCDir, EdenPath::DumpDir, EdenPath::LoadDir};for (const EdenPath& path : paths) {std::string str_path = Common::FS::GetEdenPathString(path);if (str_path.starts_with(user_data_migrator.selected_emu.get_user_dir())) {- boost::replace_all(str_path,- user_data_migrator.selected_emu.lower_name().toStdString(),- "eden");+ boost::replace_all(+ str_path, user_data_migrator.selected_emu.lower_name().toStdString(), "eden");Common::FS::SetEdenPath(path, str_path);}}@@ -531,7 +529,8 @@ MainWindow::MainWindow(bool has_broken_vulkan)std::chrono::duration_cast<std::chrono::duration<f64, std::milli>>(Common::Windows::SetCurrentTimerResolutionToMaximum()).count());- QtCommon::system->CoreTiming().SetTimerResolutionNs(Common::Windows::GetCurrentTimerResolution());+ QtCommon::system->CoreTiming().SetTimerResolutionNs(+ Common::Windows::GetCurrentTimerResolution());#endifUpdateWindowTitle();@@ -539,9 +538,8 @@ MainWindow::MainWindow(bool has_broken_vulkan)#ifdef ENABLE_UPDATE_CHECKERif (UISettings::values.check_for_updates) {- update_future = QtConcurrent::run([]() -> std::optional<UpdateChecker::Update> {- return UpdateChecker::GetUpdate();- });+ update_future = QtConcurrent::run(+ []() -> std::optional<UpdateChecker::Update> { return UpdateChecker::GetUpdate(); });update_watcher.connect(&update_watcher, &QFutureWatcher<QString>::finished, this,&MainWindow::OnEmulatorUpdateAvailable);update_watcher.setFuture(update_future);@@ -590,7 +588,8 @@ MainWindow::MainWindow(bool has_broken_vulkan)if (has_broken_vulkan) {UISettings::values.has_broken_vulkan = true;- QMessageBox::warning(this, tr("Broken Vulkan Installation Detected"), tr("Vulkan initialization failed during boot."));+ QMessageBox::warning(this, tr("Broken Vulkan Installation Detected"),+ tr("Vulkan initialization failed during boot."));#ifdef HAS_OPENGLSettings::values.renderer_backend = Settings::RendererBackend::OpenGL_GLSL;#else@@ -652,7 +651,8 @@ MainWindow::MainWindow(bool has_broken_vulkan)if (!argument_ok) {// try to look it up by username, only finds the first username that matches.std::string const user_arg_str = args[user_arg_idx].toStdString();- auto const user_idx = QtCommon::system->GetProfileManager().GetUserIndex(user_arg_str);+ auto const user_idx =+ QtCommon::system->GetProfileManager().GetUserIndex(user_arg_str);if (user_idx != std::nullopt) {selected_user = user_idx.value();} else {@@ -711,7 +711,7 @@ MainWindow::~MainWindow() {}void MainWindow::AmiiboSettingsShowDialog(const Core::Frontend::CabinetParameters& parameters,- std::shared_ptr<Service::NFC::NfcDevice> nfp_device) {+ std::shared_ptr<Service::NFC::NfcDevice> nfp_device) {cabinet_applet =new QtAmiiboSettingsDialog(this, parameters, input_subsystem.get(), nfp_device);SCOPE_EXIT {@@ -915,7 +915,7 @@ void MainWindow::SoftwareKeyboardExit() {}void MainWindow::WebBrowserOpenWebPage(const std::string& main_url,- const std::string& additional_args, bool is_local) {+ const std::string& additional_args, bool is_local) {#ifdef YUZU_USE_QT_WEB_ENGINE// Raw input breaks with the web applet, Disable web applets if enabled@@ -1072,7 +1072,8 @@ void MainWindow::InitializeWidgets() {render_window = new GRenderWindow(this, emu_thread.get(), input_subsystem, *QtCommon::system);render_window->hide();- game_list = new GameList(QtCommon::vfs, QtCommon::provider.get(), *play_time_manager, *QtCommon::system, this);+ game_list = new GameList(QtCommon::vfs, QtCommon::provider.get(), *play_time_manager,+ *QtCommon::system, this);ui->horizontalLayout->addWidget(game_list);game_list_placeholder = new GameListPlaceholder(this);@@ -1229,8 +1230,7 @@ void MainWindow::InitializeWidgets() {filter_status_button = new QPushButton();filter_status_button->setObjectName(QStringLiteral("TogglableStatusBarButton"));filter_status_button->setFocusPolicy(Qt::NoFocus);- connect(filter_status_button, &QPushButton::clicked, this,- &MainWindow::OnToggleAdaptingFilter);+ connect(filter_status_button, &QPushButton::clicked, this, &MainWindow::OnToggleAdaptingFilter);UpdateFilterText();filter_status_button->setCheckable(true);filter_status_button->setChecked(true);@@ -1369,7 +1369,7 @@ void MainWindow::InitializeRecentFileMenuActions() {}void MainWindow::LinkActionShortcut(QAction* action, const QString& action_name,- const bool tas_allowed) {+ const bool tas_allowed) {static const auto main_window = std::string("Main Window");action->setShortcut(hotkey_registry.GetKeySequence(main_window, action_name.toStdString()));action->setShortcutContext(@@ -1378,7 +1378,8 @@ void MainWindow::LinkActionShortcut(QAction* action, const QString& action_name,this->addAction(action);- auto* controller = QtCommon::system->HIDCore().GetEmulatedController(Core::HID::NpadIdType::Player1);+ auto* controller =+ QtCommon::system->HIDCore().GetEmulatedController(Core::HID::NpadIdType::Player1);const auto* controller_hotkey =hotkey_registry.GetControllerHotkey(main_window, action_name.toStdString(), controller);connect(@@ -1404,17 +1405,16 @@ void MainWindow::InitializeHotkeys() {LinkActionShortcut(ui->action_Stop, QStringLiteral("Stop Emulation"));LinkActionShortcut(ui->action_Show_Filter_Bar, QStringLiteral("Toggle Filter Bar"));LinkActionShortcut(ui->action_Show_Status_Bar, QStringLiteral("Toggle Status Bar"));- LinkActionShortcut(ui->action_Show_Performance_Overlay, QStringLiteral("Toggle Performance Overlay"));+ LinkActionShortcut(ui->action_Show_Performance_Overlay,+ QStringLiteral("Toggle Performance Overlay"));LinkActionShortcut(ui->action_Fullscreen, QStringLiteral("Fullscreen"));LinkActionShortcut(ui->action_Capture_Screenshot, QStringLiteral("Capture Screenshot"));LinkActionShortcut(ui->action_TAS_Start, QStringLiteral("TAS Start/Stop"), true);LinkActionShortcut(ui->action_TAS_Record, QStringLiteral("TAS Record"), true);LinkActionShortcut(ui->action_TAS_Reset, QStringLiteral("TAS Reset"), true);- LinkActionShortcut(ui->action_View_Lobby,- QStringLiteral("Browse Public Game Lobby"));+ LinkActionShortcut(ui->action_View_Lobby, QStringLiteral("Browse Public Game Lobby"));LinkActionShortcut(ui->action_Start_Room, QStringLiteral("Create Room"));- LinkActionShortcut(ui->action_Connect_To_Room,- QStringLiteral("Direct Connect to Room"));+ LinkActionShortcut(ui->action_Connect_To_Room, QStringLiteral("Direct Connect to Room"));LinkActionShortcut(ui->action_Show_Room, QStringLiteral("Show Current Room"));LinkActionShortcut(ui->action_Leave_Room, QStringLiteral("Leave Room"));LinkActionShortcut(ui->action_Configure, QStringLiteral("Configure"));@@ -1424,7 +1424,8 @@ void MainWindow::InitializeHotkeys() {const auto connect_shortcut = [&]<typename Fn>(const QString& action_name, const Fn& function) {const auto* hotkey =hotkey_registry.GetHotkey(main_window.toStdString(), action_name.toStdString(), this);- auto* controller = QtCommon::system->HIDCore().GetEmulatedController(Core::HID::NpadIdType::Player1);+ auto* controller =+ QtCommon::system->HIDCore().GetEmulatedController(Core::HID::NpadIdType::Player1);const auto* controller_hotkey = hotkey_registry.GetControllerHotkey(main_window.toStdString(), action_name.toStdString(), controller);connect(hotkey, &QShortcut::activated, this, function);@@ -1438,8 +1439,7 @@ void MainWindow::InitializeHotkeys() {ToggleFullscreen();}});- connect_shortcut(QStringLiteral("Change Adapting Filter"),- &MainWindow::OnToggleAdaptingFilter);+ connect_shortcut(QStringLiteral("Change Adapting Filter"), &MainWindow::OnToggleAdaptingFilter);connect_shortcut(QStringLiteral("Change Docked Mode"), &MainWindow::OnToggleDockedMode);connect_shortcut(QStringLiteral("Change GPU Mode"), &MainWindow::OnToggleGpuAccuracy);connect_shortcut(QStringLiteral("Audio Mute/Unmute"), &MainWindow::OnMute);@@ -1513,8 +1513,10 @@ void MainWindow::RestoreUIState() {ui->action_Show_Status_Bar->setChecked(UISettings::values.show_status_bar.GetValue());statusBar()->setVisible(ui->action_Show_Status_Bar->isChecked());- ui->action_Show_Performance_Overlay->setChecked(UISettings::values.show_perf_overlay.GetValue());- if (perf_overlay) perf_overlay->setVisible(ui->action_Show_Performance_Overlay->isChecked());+ ui->action_Show_Performance_Overlay->setChecked(+ UISettings::values.show_perf_overlay.GetValue());+ if (perf_overlay)+ perf_overlay->setVisible(ui->action_Show_Performance_Overlay->isChecked());Debugger::ToggleConsole();}@@ -1554,16 +1556,14 @@ void MainWindow::ConnectWidgetEvents() {connect(game_list, &GameList::GameChosen, this, &MainWindow::OnGameListLoadFile);connect(game_list, &GameList::OpenDirectory, this, &MainWindow::OnGameListOpenDirectory);connect(game_list, &GameList::OpenFolderRequested, this, &MainWindow::OnGameListOpenFolder);- connect(game_list, &GameList::OpenTransferableShaderCacheRequested, this, [this](u64 program_id) {- QtCommon::Path::OpenShaderCache(program_id, this);- });+ connect(game_list, &GameList::OpenTransferableShaderCacheRequested, this,+ [this](u64 program_id) { QtCommon::Path::OpenShaderCache(program_id, this); });connect(game_list, &GameList::RemoveInstalledEntryRequested, this,&MainWindow::OnGameListRemoveInstalledEntry);connect(game_list, &GameList::RemoveFileRequested, this, &MainWindow::OnGameListRemoveFile);connect(game_list, &GameList::RemovePlayTimeRequested, this,&MainWindow::OnGameListRemovePlayTimeData);- connect(game_list, &GameList::SetPlayTimeRequested, this,- &MainWindow::OnGameListSetPlayTime);+ connect(game_list, &GameList::SetPlayTimeRequested, this, &MainWindow::OnGameListSetPlayTime);connect(game_list, &GameList::DumpRomFSRequested, this, &MainWindow::OnGameListDumpRomFS);connect(game_list, &GameList::VerifyIntegrityRequested, this,&MainWindow::OnGameListVerifyIntegrity);@@ -1581,11 +1581,9 @@ void MainWindow::ConnectWidgetEvents() {connect(game_list, &GameList::OpenPerGameGeneralRequested, this,&MainWindow::OnGameListOpenPerGameProperties);- connect(game_list, &GameList::LinkToRyujinxRequested, this,- &MainWindow::OnLinkToRyujinx);+ connect(game_list, &GameList::LinkToRyujinxRequested, this, &MainWindow::OnLinkToRyujinx);- connect(this, &MainWindow::UpdateInstallProgress, this,- &MainWindow::IncrementInstallProgress);+ connect(this, &MainWindow::UpdateInstallProgress, this, &MainWindow::IncrementInstallProgress);connect(this, &MainWindow::EmulationStarting, render_window,&GRenderWindow::OnEmulationStarting);@@ -1652,10 +1650,11 @@ void MainWindow::ConnectMenuEvents() {for (size_t i = 0; i < default_game_icon_sizes.size(); i++) {const auto current_size = UISettings::values.game_icon_size.GetValue();const auto size = default_game_icon_sizes[i].first;- QAction *action = ui->menuGame_Icon_Size->addAction(GetTranslatedGameIconSize(i));+ QAction* action = ui->menuGame_Icon_Size->addAction(GetTranslatedGameIconSize(i));action->setCheckable(true);- if (current_size == size) action->setChecked(true);+ if (current_size == size)+ action->setChecked(true);game_size_actions->addAction(action);@@ -1687,35 +1686,38 @@ void MainWindow::ConnectMenuEvents() {connect(multiplayer_state, &MultiplayerState::SaveConfig, this, &MainWindow::OnSaveConfig);// Tools- connect_menu(ui->action_Launch_PhotoViewer, [this]{+ connect_menu(ui->action_Launch_PhotoViewer, [this] {LaunchFirmwareApplet(u64(Service::AM::AppletProgramId::PhotoViewer), std::nullopt);});- connect_menu(ui->action_Launch_MiiEdit, [this]{+ connect_menu(ui->action_Launch_MiiEdit, [this] {LaunchFirmwareApplet(u64(Service::AM::AppletProgramId::MiiEdit), std::nullopt);});- connect_menu(ui->action_Launch_Controller, [this]{+ connect_menu(ui->action_Launch_Controller, [this] {LaunchFirmwareApplet(u64(Service::AM::AppletProgramId::Controller), std::nullopt);});- connect_menu(ui->action_Launch_QLaunch, [this]{+ connect_menu(ui->action_Launch_QLaunch, [this] {LaunchFirmwareApplet(u64(Service::AM::AppletProgramId::QLaunch), std::nullopt);});// Tools (cabinet)- connect_menu(ui->action_Launch_Cabinet_Nickname_Owner, [this]{- LaunchFirmwareApplet(u64(Service::AM::AppletProgramId::Cabinet), {Service::NFP::CabinetMode::StartNicknameAndOwnerSettings});+ connect_menu(ui->action_Launch_Cabinet_Nickname_Owner, [this] {+ LaunchFirmwareApplet(u64(Service::AM::AppletProgramId::Cabinet),+ {Service::NFP::CabinetMode::StartNicknameAndOwnerSettings});});- connect_menu(ui->action_Launch_Cabinet_Eraser, [this]{- LaunchFirmwareApplet(u64(Service::AM::AppletProgramId::Cabinet), {Service::NFP::CabinetMode::StartGameDataEraser});+ connect_menu(ui->action_Launch_Cabinet_Eraser, [this] {+ LaunchFirmwareApplet(u64(Service::AM::AppletProgramId::Cabinet),+ {Service::NFP::CabinetMode::StartGameDataEraser});});- connect_menu(ui->action_Launch_Cabinet_Restorer, [this]{- LaunchFirmwareApplet(u64(Service::AM::AppletProgramId::Cabinet), {Service::NFP::CabinetMode::StartRestorer});+ connect_menu(ui->action_Launch_Cabinet_Restorer, [this] {+ LaunchFirmwareApplet(u64(Service::AM::AppletProgramId::Cabinet),+ {Service::NFP::CabinetMode::StartRestorer});});- connect_menu(ui->action_Launch_Cabinet_Formatter, [this]{- LaunchFirmwareApplet(u64(Service::AM::AppletProgramId::Cabinet), {Service::NFP::CabinetMode::StartFormatter});+ connect_menu(ui->action_Launch_Cabinet_Formatter, [this] {+ LaunchFirmwareApplet(u64(Service::AM::AppletProgramId::Cabinet),+ {Service::NFP::CabinetMode::StartFormatter});});connect_menu(ui->action_Desktop, &MainWindow::OnCreateHomeMenuDesktopShortcut);- connect_menu(ui->action_Application_Menu,- &MainWindow::OnCreateHomeMenuApplicationMenuShortcut);+ connect_menu(ui->action_Application_Menu, &MainWindow::OnCreateHomeMenuApplicationMenuShortcut);connect_menu(ui->action_Capture_Screenshot, &MainWindow::OnCaptureScreenshot);// TAS@@ -1754,15 +1756,10 @@ void MainWindow::UpdateMenuState() {};const std::array applet_actions{- ui->action_Launch_PhotoViewer,- ui->action_Launch_Cabinet_Nickname_Owner,- ui->action_Launch_Cabinet_Eraser,- ui->action_Launch_Cabinet_Restorer,- ui->action_Launch_Cabinet_Formatter,- ui->action_Launch_MiiEdit,- ui->action_Launch_QLaunch,- ui->action_Launch_Controller- };+ ui->action_Launch_PhotoViewer, ui->action_Launch_Cabinet_Nickname_Owner,+ ui->action_Launch_Cabinet_Eraser, ui->action_Launch_Cabinet_Restorer,+ ui->action_Launch_Cabinet_Formatter, ui->action_Launch_MiiEdit,+ ui->action_Launch_QLaunch, ui->action_Launch_Controller};for (QAction* action : running_actions) {action->setEnabled(emulation_running);@@ -1795,17 +1792,16 @@ void MainWindow::SetupPrepareForSleep() {const auto dbus_logind_service = QStringLiteral("org.freedesktop.login1");const auto dbus_logind_path = QStringLiteral("/org/freedesktop/login1");const auto dbus_logind_manager_if = QStringLiteral("org.freedesktop.login1.Manager");- //const auto dbus_logind_session_if = QStringLiteral("org.freedesktop.login1.Session");+ // const auto dbus_logind_session_if = QStringLiteral("org.freedesktop.login1.Session");#elseconst auto dbus_logind_service = QStringLiteral("org.freedesktop.ConsoleKit");const auto dbus_logind_path = QStringLiteral("/org/freedesktop/ConsoleKit/Manager");const auto dbus_logind_manager_if = QStringLiteral("org.freedesktop.ConsoleKit.Manager");- //const auto dbus_logind_session_if = QStringLiteral("org.freedesktop.ConsoleKit.Session");+ // const auto dbus_logind_session_if = QStringLiteral("org.freedesktop.ConsoleKit.Session");#endif- const bool success = bus.connect(- dbus_logind_service, dbus_logind_path,- dbus_logind_manager_if, QStringLiteral("PrepareForSleep"),- QStringLiteral("b"), this, SLOT(OnPrepareForSleep(bool)));+ const bool success = bus.connect(dbus_logind_service, dbus_logind_path,+ dbus_logind_manager_if, QStringLiteral("PrepareForSleep"),+ QStringLiteral("b"), this, SLOT(OnPrepareForSleep(bool)));if (!success)LOG_WARNING(Frontend, "Couldn't register PrepareForSleep signal");} else {@@ -1934,13 +1930,14 @@ bool MainWindow::LoadROM(const QString& filename, Service::AM::FrontendAppletPar/** Exec */const Core::SystemResultStatus result{- QtCommon::system->Load(*render_window, filename.toStdString(), params)};+ QtCommon::system->Load(*render_window, filename.toStdString(), params)};const auto drd_callout = (UISettings::values.callout_flags.GetValue() &static_cast<u32>(CalloutFlag::DRDDeprecation)) == 0;if (result == Core::SystemResultStatus::Success &&- QtCommon::system->GetAppLoader().GetFileType() == Loader::FileType::DeconstructedRomDirectory &&+ QtCommon::system->GetAppLoader().GetFileType() ==+ Loader::FileType::DeconstructedRomDirectory &&drd_callout) {UISettings::values.callout_flags = UISettings::values.callout_flags.GetValue() |static_cast<u32>(CalloutFlag::DRDDeprecation);@@ -2047,7 +2044,7 @@ void MainWindow::ConfigureFilesystemProvider(const std::string& filepath) {}void MainWindow::BootGame(const QString& filename, Service::AM::FrontendAppletParameters params,- StartGameType type) {+ StartGameType type) {LOG_INFO(Frontend, "Eden starting...");if (params.program_id == 0 ||@@ -2066,7 +2063,8 @@ void MainWindow::BootGame(const QString& filename, Service::AM::FrontendAppletPaConfigureFilesystemProvider(filename.toStdString());const auto v_file = Core::GetGameFileFromPath(QtCommon::vfs, filename.toUtf8().constData());- const auto loader = Loader::GetLoader(*QtCommon::system, v_file, params.program_id, params.program_index);+ const auto loader =+ Loader::GetLoader(*QtCommon::system, v_file, params.program_id, params.program_index);if (loader != nullptr && loader->ReadProgramId(title_id) == Loader::ResultStatus::Success &&type == StartGameType::Normal) {@@ -2085,11 +2083,11 @@ void MainWindow::BootGame(const QString& filename, Service::AM::FrontendAppletPaif (UISettings::values.select_user_on_boot && !user_flag_cmd_line) {const Core::Frontend::ProfileSelectParameters parameters{- .mode = Service::AM::Frontend::UiMode::UserSelector,- .invalid_uid_list = {},- .display_options = {},- .purpose = Service::AM::Frontend::UserSelectionPurpose::General,- };+ .mode = Service::AM::Frontend::UiMode::UserSelector,+ .invalid_uid_list = {},+ .display_options = {},+ .purpose = Service::AM::Frontend::UserSelectionPurpose::General,+ };if (SelectAndSetCurrentUser(parameters) == false) {return;}@@ -2246,8 +2244,9 @@ bool MainWindow::OnShutdownBegin() {}void MainWindow::OnShutdownBeginDialog() {- shutdown_dialog = new OverlayDialog(this, *QtCommon::system, QString{}, tr("Closing software..."),- QString{}, QString{}, Qt::AlignHCenter | Qt::AlignVCenter);+ shutdown_dialog =+ new OverlayDialog(this, *QtCommon::system, QString{}, tr("Closing software..."), QString{},+ QString{}, Qt::AlignHCenter | Qt::AlignVCenter);shutdown_dialog->open();}@@ -2384,7 +2383,7 @@ void MainWindow::OnGameListLoadFile(QString game_path, u64 program_id) {// TODO(crueter): Common profile selectorvoid MainWindow::OnGameListOpenFolder(u64 program_id, GameListOpenTarget target,- const std::string& game_path) {+ const std::string& game_path) {std::filesystem::path path;QString open_target;@@ -2414,8 +2413,8 @@ void MainWindow::OnGameListOpenFolder(u64 program_id, GameListOpenTarget target,case GameListOpenTarget::SaveData: {open_target = tr("Save Data");const auto save_dir = Common::FS::GetEdenPath(Common::FS::EdenPath::SaveDir);- auto vfs_save_dir =- QtCommon::vfs->OpenDirectory(Common::FS::PathToUTF8String(save_dir), FileSys::OpenMode::Read);+ auto vfs_save_dir = QtCommon::vfs->OpenDirectory(Common::FS::PathToUTF8String(save_dir),+ FileSys::OpenMode::Read);if (has_user_save) {// User save data@@ -2530,7 +2529,8 @@ static bool RomFSRawCopy(size_t total_size, size_t& read_size, QProgressDialog&// TODO(crueter): All this can be transfered to qt_common// Aldoe I need to decide re: message boxes for QML// translations_common? strings_common? qt_strings? who knows-void MainWindow::OnGameListRemoveInstalledEntry(u64 program_id, QtCommon::Game::InstalledEntryType type) {+void MainWindow::OnGameListRemoveInstalledEntry(u64 program_id,+ QtCommon::Game::InstalledEntryType type) {const QString entry_question = [type] {switch (type) {case QtCommon::Game::InstalledEntryType::Game:@@ -2570,7 +2570,7 @@ void MainWindow::OnGameListRemoveInstalledEntry(u64 program_id, QtCommon::Game::}void MainWindow::OnGameListRemoveFile(u64 program_id, QtCommon::Game::GameListRemoveTarget target,- const std::string& game_path) {+ const std::string& game_path) {const QString question = [target] {switch (target) {case QtCommon::Game::GameListRemoveTarget::GlShaderCache:@@ -2588,8 +2588,8 @@ void MainWindow::OnGameListRemoveFile(u64 program_id, QtCommon::Game::GameListRe}}();- if (!MainWindow::question(this, tr("Remove File"), question,- QMessageBox::Yes | QMessageBox::No, QMessageBox::No)) {+ if (!MainWindow::question(this, tr("Remove File"), question, QMessageBox::Yes | QMessageBox::No,+ QMessageBox::No)) {return;}@@ -2624,7 +2624,6 @@ void MainWindow::OnGameListSetPlayTime(u64 program_id) {}}-void MainWindow::OnGameListRemovePlayTimeData(u64 program_id) {if (QMessageBox::question(this, tr("Remove Play Time Data"), tr("Reset play time?"),QMessageBox::Yes | QMessageBox::No,@@ -2637,15 +2636,15 @@ void MainWindow::OnGameListRemovePlayTimeData(u64 program_id) {}void MainWindow::OnGameListDumpRomFS(u64 program_id, const std::string& game_path,- DumpRomFSTarget target) {+ DumpRomFSTarget target) {const auto failed = [this] {QMessageBox::warning(this, tr("RomFS Extraction Failed!"),tr("There was an error copying the RomFS files or the user ""cancelled the operation."));};- const auto loader =- Loader::GetLoader(*QtCommon::system, QtCommon::vfs->OpenFile(game_path, FileSys::OpenMode::Read));+ const auto loader = Loader::GetLoader(+ *QtCommon::system, QtCommon::vfs->OpenFile(game_path, FileSys::OpenMode::Read));if (loader == nullptr) {failed();return;@@ -2686,7 +2685,8 @@ void MainWindow::OnGameListDumpRomFS(u64 program_id, const std::string& game_patconst auto path = Common::FS::PathToUTF8String(dump_dir / romfs_dir);- const FileSys::PatchManager pm{title_id, QtCommon::system->GetFileSystemController(), installed};+ const FileSys::PatchManager pm{title_id, QtCommon::system->GetFileSystemController(),+ installed};auto romfs = pm.PatchRomFS(base_nca.get(), base_romfs, type, packed_update_raw, false);const auto out = VfsFilesystemCreateDirectoryWrapper(path, FileSys::OpenMode::ReadWrite);@@ -2762,7 +2762,7 @@ void MainWindow::OnGameListCopyTID(u64 program_id) {}void MainWindow::OnGameListNavigateToGamedbEntry(u64 program_id,- const CompatibilityList& compatibility_list) {+ const CompatibilityList& compatibility_list) {const auto it = FindMatchingCompatibilityEntry(compatibility_list, program_id);QString directory;@@ -2770,11 +2770,14 @@ void MainWindow::OnGameListNavigateToGamedbEntry(u64 program_id,directory = it->second.second;}- QDesktopServices::openUrl(QUrl(QStringLiteral("https://www.emuready.com/listings?emulatorIds=43bfc023-ec22-422d-8324-048a8ec9f28f") + directory));+ QDesktopServices::openUrl(QUrl(+ QStringLiteral(+ "https://www.emuready.com/listings?emulatorIds=43bfc023-ec22-422d-8324-048a8ec9f28f") ++ directory));}void MainWindow::OnGameListCreateShortcut(u64 program_id, const std::string& game_path,- const QtCommon::Game::ShortcutTarget target) {+ const QtCommon::Game::ShortcutTarget target) {// Create shortcustd::string arguments = fmt::format("-g \"{:s}\"", game_path);@@ -2846,8 +2849,7 @@ void MainWindow::OnGameListOpenPerGameProperties(const std::string& file) {OpenPerGameConfiguration(title_id, file);}-void MainWindow::OnLinkToRyujinx(const u64& program_id)-{+void MainWindow::OnLinkToRyujinx(const u64& program_id) {namespace fs = std::filesystem;fs::path ryu_dir;@@ -2862,10 +2864,12 @@ void MainWindow::OnLinkToRyujinx(const u64& program_id)// this function also prompts the user to manually specify a portable locationryu_dir = QtCommon::FS::GetRyujinxSavePath(existing_path, program_id);- if (ryu_dir.empty()) return;+ if (ryu_dir.empty())+ return;const std::string user_id = GetProfileIDString();- if (user_id.empty()) return;+ if (user_id.empty())+ return;const std::string hex_program = fmt::format("{:016X}", program_id);@@ -2873,7 +2877,6 @@ void MainWindow::OnLinkToRyujinx(const u64& program_id)FrontendCommon::DataManager::DataDir::Saves, user_id) /hex_program;-// CheckUnlink basically just checks to see if one or both are linked, and prompts the user to// unlink if this is the case.// If it returns false, neither dir is linked so it's fine to continue@@ -3008,8 +3011,8 @@ void MainWindow::OnMenuInstallToNAND() {return false;};future = QtConcurrent::run([&file, progress_callback] {- return ContentManager::InstallNSP(*QtCommon::system, *QtCommon::vfs, file.toStdString(),- progress_callback);+ return ContentManager::InstallNSP(*QtCommon::system, *QtCommon::vfs,+ file.toStdString(), progress_callback);});while (!future.isFinished()) {@@ -3220,9 +3223,8 @@ void MainWindow::OnLoadComplete() {perf_overlay = new PerformanceOverlay(this);perf_overlay->setVisible(ui->action_Show_Performance_Overlay->isChecked());- connect(perf_overlay, &PerformanceOverlay::closed, perf_overlay, [this]() {- ui->action_Show_Performance_Overlay->setChecked(false);- });+ connect(perf_overlay, &PerformanceOverlay::closed, perf_overlay,+ [this]() { ui->action_Show_Performance_Overlay->setChecked(false); });}void MainWindow::OnExecuteProgram(std::size_t program_index) {@@ -3244,8 +3246,8 @@ void MainWindow::OnSaveConfig() {}void MainWindow::ErrorDisplayDisplayError(QString error_code, QString error_text) {- error_applet = new OverlayDialog(render_window, *QtCommon::system, error_code, error_text, QString{},- tr("OK"), Qt::AlignLeft | Qt::AlignVCenter);+ error_applet = new OverlayDialog(render_window, *QtCommon::system, error_code, error_text,+ QString{}, tr("OK"), Qt::AlignLeft | Qt::AlignVCenter);SCOPE_EXIT {error_applet->deleteLater();error_applet = nullptr;@@ -3266,37 +3268,41 @@ void MainWindow::OnMenuReportCompatibility() {tr("Function Disabled"),tr("Compatibility list reporting is currently disabled. Check back later!"));-// #if defined(ARCHITECTURE_x86_64) && !defined(__APPLE__)-// const auto& caps = Common::GetCPUCaps();-// const bool has_fma = caps.fma || caps.fma4;-// const auto processor_count = std::thread::hardware_concurrency();-// const bool has_4threads = processor_count == 0 || processor_count >= 4;-// const bool has_8gb_ram = Common::GetMemInfo().TotalPhysicalMemory >= 8_GiB;-// const bool has_broken_vulkan = UISettings::values.has_broken_vulkan;--// if (!has_fma || !has_4threads || !has_8gb_ram || has_broken_vulkan) {-// QMessageBox::critical(this, tr("Hardware requirements not met"),-// tr("Your system does not meet the recommended hardware requirements. "-// "Compatibility reporting has been disabled."));-// return;-// }--// if (!Settings::values.eden_token.GetValue().empty() &&-// !Settings::values.eden_username.GetValue().empty()) {-// } else {-// QMessageBox::critical(-// this, tr("Missing yuzu Account"),-// tr("In order to submit a game compatibility test case, you must set up your web token "-// "and "-// "username.<br><br/>To link your eden account, go to Emulation > Configuration "-// "> "-// "Web."));-// }-// #else-// QMessageBox::critical(this, tr("Hardware requirements not met"),-// tr("Your system does not meet the recommended hardware requirements. "-// "Compatibility reporting has been disabled."));-// #endif+ // #if defined(ARCHITECTURE_x86_64) && !defined(__APPLE__)+ // const auto& caps = Common::GetCPUCaps();+ // const bool has_fma = caps.fma || caps.fma4;+ // const auto processor_count = std::thread::hardware_concurrency();+ // const bool has_4threads = processor_count == 0 || processor_count >= 4;+ // const bool has_8gb_ram = Common::GetMemInfo().TotalPhysicalMemory >= 8_GiB;+ // const bool has_broken_vulkan = UISettings::values.has_broken_vulkan;++ // if (!has_fma || !has_4threads || !has_8gb_ram || has_broken_vulkan) {+ // QMessageBox::critical(this, tr("Hardware requirements not met"),+ // tr("Your system does not meet the recommended hardware+ // requirements. "+ // "Compatibility reporting has been disabled."));+ // return;+ // }++ // if (!Settings::values.eden_token.GetValue().empty() &&+ // !Settings::values.eden_username.GetValue().empty()) {+ // } else {+ // QMessageBox::critical(+ // this, tr("Missing yuzu Account"),+ // tr("In order to submit a game compatibility test case, you must set up your web+ // token "+ // "and "+ // "username.<br><br/>To link your eden account, go to Emulation >+ // Configuration "+ // "> "+ // "Web."));+ // }+ // #else+ // QMessageBox::critical(this, tr("Hardware requirements not met"),+ // tr("Your system does not meet the recommended hardware+ // requirements. "+ // "Compatibility reporting has been disabled."));+ // #endif}void MainWindow::OpenURL(const QUrl& url) {@@ -3431,7 +3437,8 @@ void MainWindow::ToggleWindowMode() {}void MainWindow::ResetWindowSize(u32 width, u32 height) {- const auto aspect_ratio = Layout::EmulationAspectRatio(Settings::values.aspect_ratio.GetValue(), float(height) / width);+ const auto aspect_ratio = Layout::EmulationAspectRatio(Settings::values.aspect_ratio.GetValue(),+ float(height) / width);if (!ui->action_Single_Window_Mode->isChecked()) {render_window->resize(height / aspect_ratio, height);} else {@@ -3488,7 +3495,8 @@ void MainWindow::CheckIconSize() {for (size_t i = 0; i < default_game_icon_sizes.size(); i++) {const auto current_size = newSize;const auto size = default_game_icon_sizes[i].first;- if (current_size == size) actions.at(i)->setChecked(true);+ if (current_size == size)+ actions.at(i)->setChecked(true);}// Update this if you add anything before None.@@ -3499,7 +3507,7 @@ void MainWindow::CheckIconSize() {}void MainWindow::ToggleShowGameName() {- auto &setting = UISettings::values.show_game_name;+ auto& setting = UISettings::values.show_game_name;const bool newValue = !setting.GetValue();ui->action_Show_Game_Name->setChecked(newValue);setting.SetValue(newValue);@@ -3648,7 +3656,8 @@ void MainWindow::OnTasStartStop() {}// Disable system buttons to prevent TAS from executing a hotkey- auto* controller = QtCommon::system->HIDCore().GetEmulatedController(Core::HID::NpadIdType::Player1);+ auto* controller =+ QtCommon::system->HIDCore().GetEmulatedController(Core::HID::NpadIdType::Player1);controller->ResetSystemButtons();input_subsystem->GetTas()->StartStop();@@ -3664,7 +3673,8 @@ void MainWindow::OnTasRecord() {}// Disable system buttons to prevent TAS from recording a hotkey- auto* controller = QtCommon::system->HIDCore().GetEmulatedController(Core::HID::NpadIdType::Player1);+ auto* controller =+ QtCommon::system->HIDCore().GetEmulatedController(Core::HID::NpadIdType::Player1);controller->ResetSystemButtons();const bool is_recording = input_subsystem->GetTas()->Record();@@ -3690,8 +3700,10 @@ void MainWindow::OnTasReset() {void MainWindow::OnToggleDockedMode() {const bool is_docked = Settings::IsDockedMode();- auto* player_1 = QtCommon::system->HIDCore().GetEmulatedController(Core::HID::NpadIdType::Player1);- auto* handheld = QtCommon::system->HIDCore().GetEmulatedController(Core::HID::NpadIdType::Handheld);+ auto* player_1 =+ QtCommon::system->HIDCore().GetEmulatedController(Core::HID::NpadIdType::Player1);+ auto* handheld =+ QtCommon::system->HIDCore().GetEmulatedController(Core::HID::NpadIdType::Handheld);if (!is_docked && handheld->IsConnected()) {QMessageBox::warning(this, tr("Invalid config detected"),@@ -3861,8 +3873,8 @@ void MainWindow::OnLoadAmiibo() {// TODO(crueter): does this need to be ported to QML?bool MainWindow::question(QWidget* parent, const QString& title, const QString& text,- QMessageBox::StandardButtons buttons,- QMessageBox::StandardButton defaultButton) {+ QMessageBox::StandardButtons buttons,+ QMessageBox::StandardButton defaultButton) {QMessageBox* box_dialog = new QMessageBox(parent);box_dialog->setWindowTitle(title);box_dialog->setText(text);@@ -3914,23 +3926,19 @@ void MainWindow::OnOpenRootDataFolder() {QtCommon::Game::OpenRootDataFolder();}-void MainWindow::OnOpenNANDFolder()-{+void MainWindow::OnOpenNANDFolder() {QtCommon::Game::OpenNANDFolder();}-void MainWindow::OnOpenSDMCFolder()-{+void MainWindow::OnOpenSDMCFolder() {QtCommon::Game::OpenSDMCFolder();}-void MainWindow::OnOpenModFolder()-{+void MainWindow::OnOpenModFolder() {QtCommon::Game::OpenModFolder();}-void MainWindow::OnOpenLogFolder()-{+void MainWindow::OnOpenLogFolder() {QtCommon::Game::OpenLogFolder();}@@ -3993,7 +4001,8 @@ void MainWindow::OnInstallFirmwareFromZIP() {if (!qCacheDir.isEmpty()) {InstallFirmware(qCacheDir, true);std::error_code ec;- std::filesystem::remove_all(std::filesystem::temp_directory_path() / "eden" / "firmware", ec);+ std::filesystem::remove_all(std::filesystem::temp_directory_path() / "eden" / "firmware",+ ec);if (ec) {QMessageBox::warning(this, tr("Firmware cleanup failed"),@@ -4061,13 +4070,15 @@ void MainWindow::OnGameListRefresh() {SetFirmwareVersion();}-void MainWindow::LaunchFirmwareApplet(u64 raw_program_id, std::optional<Service::NFP::CabinetMode> cabinet_mode) {+void MainWindow::LaunchFirmwareApplet(u64 raw_program_id,+ std::optional<Service::NFP::CabinetMode> cabinet_mode) {auto const program_id = Service::AM::AppletProgramId(raw_program_id);auto result = FirmwareManager::VerifyFirmware(*QtCommon::system.get());using namespace QtCommon::StringLookup;switch (result) {case FirmwareManager::ErrorFirmwareMissing:- QMessageBox::warning(this, tr("No firmware available"), Lookup(FwCheckErrorFirmwareMissing));+ QMessageBox::warning(this, tr("No firmware available"),+ Lookup(FwCheckErrorFirmwareMissing));return;case FirmwareManager::ErrorFirmwareCorrupted:QMessageBox::warning(this, tr("Firmware Corrupted"), Lookup(FwCheckErrorFirmwareCorrupted));@@ -4076,33 +4087,58 @@ void MainWindow::LaunchFirmwareApplet(u64 raw_program_id, std::optional<Service:break;}auto bis_system = QtCommon::system->GetFileSystemController().GetSystemNANDContents();- if (auto applet_nca = bis_system->GetEntry(u64(program_id), FileSys::ContentRecordType::Program); applet_nca) {- if (auto const applet_id = [program_id] {- using namespace Service::AM;- switch (program_id) {- case AppletProgramId::OverlayDisplay: return AppletId::OverlayDisplay;- case AppletProgramId::QLaunch: return AppletId::QLaunch;- case AppletProgramId::Starter: return AppletId::Starter;- case AppletProgramId::Auth: return AppletId::Auth;- case AppletProgramId::Cabinet: return AppletId::Cabinet;- case AppletProgramId::Controller: return AppletId::Controller;- case AppletProgramId::DataErase: return AppletId::DataErase;- case AppletProgramId::Error: return AppletId::Error;- case AppletProgramId::NetConnect: return AppletId::NetConnect;- case AppletProgramId::ProfileSelect: return AppletId::ProfileSelect;- case AppletProgramId::SoftwareKeyboard: return AppletId::SoftwareKeyboard;- case AppletProgramId::MiiEdit: return AppletId::MiiEdit;- case AppletProgramId::Web: return AppletId::Web;- case AppletProgramId::Shop: return AppletId::Shop;- case AppletProgramId::PhotoViewer: return AppletId::PhotoViewer;- case AppletProgramId::Settings: return AppletId::Settings;- case AppletProgramId::OfflineWeb: return AppletId::OfflineWeb;- case AppletProgramId::LoginShare: return AppletId::LoginShare;- case AppletProgramId::WebAuth: return AppletId::WebAuth;- case AppletProgramId::MyPage: return AppletId::MyPage;- default: return AppletId::None;- }- }(); applet_id != Service::AM::AppletId::None) {+ if (auto applet_nca =+ bis_system->GetEntry(u64(program_id), FileSys::ContentRecordType::Program);+ applet_nca) {+ if (auto const applet_id =+ [program_id] {+ using namespace Service::AM;+ switch (program_id) {+ case AppletProgramId::OverlayDisplay:+ return AppletId::OverlayDisplay;+ case AppletProgramId::QLaunch:+ return AppletId::QLaunch;+ case AppletProgramId::Starter:+ return AppletId::Starter;+ case AppletProgramId::Auth:+ return AppletId::Auth;+ case AppletProgramId::Cabinet:+ return AppletId::Cabinet;+ case AppletProgramId::Controller:+ return AppletId::Controller;+ case AppletProgramId::DataErase:+ return AppletId::DataErase;+ case AppletProgramId::Error:+ return AppletId::Error;+ case AppletProgramId::NetConnect:+ return AppletId::NetConnect;+ case AppletProgramId::ProfileSelect:+ return AppletId::ProfileSelect;+ case AppletProgramId::SoftwareKeyboard:+ return AppletId::SoftwareKeyboard;+ case AppletProgramId::MiiEdit:+ return AppletId::MiiEdit;+ case AppletProgramId::Web:+ return AppletId::Web;+ case AppletProgramId::Shop:+ return AppletId::Shop;+ case AppletProgramId::PhotoViewer:+ return AppletId::PhotoViewer;+ case AppletProgramId::Settings:+ return AppletId::Settings;+ case AppletProgramId::OfflineWeb:+ return AppletId::OfflineWeb;+ case AppletProgramId::LoginShare:+ return AppletId::LoginShare;+ case AppletProgramId::WebAuth:+ return AppletId::WebAuth;+ case AppletProgramId::MyPage:+ return AppletId::MyPage;+ default:+ return AppletId::None;+ }+ }();+ applet_id != Service::AM::AppletId::None) {QtCommon::system->GetFrontendAppletHolder().SetCurrentAppletId(applet_id);if (cabinet_mode)QtCommon::system->GetFrontendAppletHolder().SetCabinetMode(*cabinet_mode);@@ -4111,10 +4147,12 @@ void MainWindow::LaunchFirmwareApplet(u64 raw_program_id, std::optional<Service:UISettings::values.roms_path = QFileInfo(filename).path().toStdString();BootGame(filename, LibraryAppletParameters(u64(program_id), applet_id));} else {- QMessageBox::warning(this, tr("Unknown applet"), tr("Applet doesn't map to a known value."));+ QMessageBox::warning(this, tr("Unknown applet"),+ tr("Applet doesn't map to a known value."));}} else {- QMessageBox::warning(this, tr("Record not found"), tr("Applet not found. Please reinstall firmware."));+ QMessageBox::warning(this, tr("Record not found"),+ tr("Applet not found. Please reinstall firmware."));}}@@ -4170,26 +4208,23 @@ void MainWindow::OnEmulatorUpdateAvailable() {update_prompt.setIcon(QMessageBox::Information);update_prompt.addButton(QMessageBox::Yes);update_prompt.addButton(QMessageBox::Ignore);- update_prompt.setText(- tr("Download %1?").arg(QString::fromStdString(version->name)));+ update_prompt.setText(tr("Download %1?").arg(QString::fromStdString(version->name)));update_prompt.exec();if (update_prompt.button(QMessageBox::Yes) == update_prompt.clickedButton()) {- auto const full_url = fmt::format("{}/{}/releases/tag/",- std::string{Common::g_build_auto_update_website},- std::string{Common::g_build_auto_update_repo}- );+ auto const full_url =+ fmt::format("{}/{}/releases/tag/", std::string{Common::g_build_auto_update_website},+ std::string{Common::g_build_auto_update_repo});QDesktopServices::openUrl(QUrl(QString::fromStdString(full_url + version->tag)));}}#endif-void MainWindow::UpdateWindowTitle(std::string_view title_name, std::string_view title_version, std::string_view gpu_vendor) {+void MainWindow::UpdateWindowTitle(std::string_view title_name, std::string_view title_version,+ std::string_view gpu_vendor) {static const std::string build_id = std::string{Common::g_build_id};- static const std::string yuzu_title = fmt::format("{} | {} | {}",- std::string{Common::g_build_name},- std::string{Common::g_build_version},- std::string{Common::g_compiler_id}- );+ static const std::string yuzu_title =+ fmt::format("{} | {} | {}", std::string{Common::g_build_name},+ std::string{Common::g_build_version}, std::string{Common::g_compiler_id});const auto override_title =fmt::format(fmt::runtime(std::string(Common::g_title_bar_format_idle)), build_id);@@ -4301,7 +4336,8 @@ void MainWindow::UpdateStatusBar() {}QString fpsText = tr("Game: %1 FPS").arg(std::round(results.average_game_fps), 0, 'f', 0);- if (!m_fpsSuffix.isEmpty()) fpsText = fpsText % QStringLiteral(" (%1)").arg(m_fpsSuffix);+ if (!m_fpsSuffix.isEmpty())+ fpsText = fpsText % QStringLiteral(" (%1)").arg(m_fpsSuffix);game_fps_label->setText(fpsText);@@ -4444,7 +4480,9 @@ void MainWindow::OnCheckGraphicsBackend() {if (platformName == QStringLiteral("xcb") || qtPlatform == "xcb")return;- const bool isWayland = platformName.startsWith(QStringLiteral("wayland"), Qt::CaseInsensitive) || qtPlatform.startsWith("wayland");+ const bool isWayland =+ platformName.startsWith(QStringLiteral("wayland"), Qt::CaseInsensitive) ||+ qtPlatform.startsWith("wayland");if (!isWayland)return;@@ -4454,9 +4492,10 @@ void MainWindow::OnCheckGraphicsBackend() {QMessageBox msgbox(this);msgbox.setWindowTitle(tr("Wayland Detected!"));- msgbox.setText(tr("Wayland is known to have significant performance issues and mysterious bugs.\n"- "It's recommended to use X11 instead.\n\n"- "Would you like to force it for future launches?"));+ msgbox.setText(+ tr("Wayland is known to have significant performance issues and mysterious bugs.\n"+ "It's recommended to use X11 instead.\n\n"+ "Would you like to force it for future launches?"));msgbox.setIcon(QMessageBox::Warning);QPushButton* okButton = msgbox.addButton(tr("Use X11"), QMessageBox::AcceptRole);@@ -4477,8 +4516,7 @@ void MainWindow::OnCheckGraphicsBackend() {if (msgbox.clickedButton() == okButton) {UISettings::values.gui_force_x11.SetValue(true);GraphicsBackend::SetForceX11(true);- QMessageBox::information(this,- tr("Restart Required"),+ QMessageBox::information(this, tr("Restart Required"),tr("Restart Eden to apply the X11 backend."));}}@@ -4530,7 +4568,7 @@ void MainWindow::SetFPSSuffix() {}bool MainWindow::SelectRomFSDumpTarget(const FileSys::ContentProvider& installed, u64 program_id,- u64* selected_title_id, u8* selected_content_record_type) {+ u64* selected_title_id, u8* selected_content_record_type) {using ContentInfo = std::tuple<u64, FileSys::TitleType, FileSys::ContentRecordType>;boost::container::flat_set<ContentInfo> available_title_ids;@@ -4809,7 +4847,7 @@ void MainWindow::OnLanguageChanged(const QString& locale) {qApp->removeTranslator(&translator);}- QList<QAction *> actions = game_size_actions->actions();+ QList<QAction*> actions = game_size_actions->actions();for (size_t i = 0; i < default_game_icon_sizes.size(); i++) {actions.at(i)->setText(GetTranslatedGameIconSize(i));}diff --git a/src/yuzu/main_window.h b/src/yuzu/main_window.hindex bb58191951..e85aadaa3d 100644--- a/src/yuzu/main_window.h+++ b/src/yuzu/main_window.h@@ -24,15 +24,15 @@#include "input_common/drivers/tas_input.h"#include "qt_common/config/qt_config.h"#include "qt_common/util/game.h"-#include "yuzu/user_data_migration.h"#include "yuzu/compatibility_list.h"#include "yuzu/hotkeys.h"+#include "yuzu/user_data_migration.h"#ifdef __unix__#include <QDBusObjectPath>+#include <QSocketNotifier>#include <QVariant>#include <QtDBus/QDBusInterface>-#include <QSocketNotifier>#endif#ifdef ENABLE_UPDATE_CHECKER@@ -218,9 +218,10 @@ signals:void WebBrowserClosed(Service::AM::Frontend::WebExitReason exit_reason, std::string last_url);void SigInterrupt();- void sizeChanged(const QSize &size);- void positionChanged(const QPoint &pos);- void statsUpdated(const Core::PerfStatsResults &results, const VideoCore::ShaderNotify &shaders);+ void sizeChanged(const QSize& size);+ void positionChanged(const QPoint& pos);+ void statsUpdated(const Core::PerfStatsResults& results,+ const VideoCore::ShaderNotify& shaders);public slots:void OnLoadComplete();@@ -317,8 +318,8 @@ private:void RequestGameExit();void changeEvent(QEvent* event) override;void closeEvent(QCloseEvent* event) override;- void resizeEvent(QResizeEvent *event) override;- void moveEvent(QMoveEvent *event) override;+ void resizeEvent(QResizeEvent* event) override;+ void moveEvent(QMoveEvent* event) override;std::string CreateTASFramesString(std::array<size_t, InputCommon::TasInput::PLAYER_NUMBER> frames) const;@@ -360,8 +361,7 @@ private slots:void OnGameListCopyTID(u64 program_id);void OnGameListNavigateToGamedbEntry(u64 program_id,const CompatibilityList& compatibility_list);- void OnGameListCreateShortcut(u64 program_id,- const std::string& game_path,+ void OnGameListCreateShortcut(u64 program_id, const std::string& game_path,const QtCommon::Game::ShortcutTarget target);void OnGameListOpenDirectory(const QString& directory);void OnGameListAddDirectory();@@ -483,7 +483,7 @@ private:*/bool question(QWidget* parent, const QString& title, const QString& text,QMessageBox::StandardButtons buttons =- QMessageBox::StandardButtons(QMessageBox::Yes | QMessageBox::No),+ QMessageBox::StandardButtons(QMessageBox::Yes | QMessageBox::No),QMessageBox::StandardButton defaultButton = QMessageBox::NoButton);std::unique_ptr<Ui::MainWindow> ui;@@ -504,7 +504,7 @@ private:LoadingScreen* loading_screen = nullptr;QTimer shutdown_timer;OverlayDialog* shutdown_dialog{};- PerformanceOverlay *perf_overlay = nullptr;+ PerformanceOverlay* perf_overlay = nullptr;GameListPlaceholder* game_list_placeholder = nullptr;@@ -551,7 +551,7 @@ private:QString startup_icon_theme;- QActionGroup *game_size_actions;+ QActionGroup* game_size_actions;// Debugger panesControllerDialog* controller_dialog = nullptr;@@ -595,12 +595,9 @@ private:std::filesystem::path GetEdenCommand();- void CreateShortcut(const std::string& game_path,- const u64 program_id,- const std::string& game_title,- QtCommon::Game::ShortcutTarget target,- std::string arguments,- const bool needs_title);+ void CreateShortcut(const std::string& game_path, const u64 program_id,+ const std::string& game_title, QtCommon::Game::ShortcutTarget target,+ std::string arguments, const bool needs_title);void InstallFirmware(const QString& location, bool recursive = false);diff --git a/src/yuzu/migration_dialog.cpp b/src/yuzu/migration_dialog.cppindex 9cc40841e8..ba6a14b156 100644--- a/src/yuzu/migration_dialog.cpp+++ b/src/yuzu/migration_dialog.cpp@@ -1,3 +1,6 @@+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project+// SPDX-License-Identifier: GPL-3.0-or-later+#include "migration_dialog.h"#include <QApplication>@@ -6,11 +9,8 @@#include <QPushButton>#include <QStyle>-MigrationDialog::MigrationDialog(- QWidget *parent)- : QDialog(parent)-{- QVBoxLayout *layout = new QVBoxLayout(this);+MigrationDialog::MigrationDialog(QWidget* parent) : QDialog(parent) {+ QVBoxLayout* layout = new QVBoxLayout(this);m_text = new QLabel(this);m_boxes = new QVBoxLayout;@@ -26,23 +26,16 @@ MigrationDialog::~MigrationDialog() {m_buttons->deleteLater();}-void MigrationDialog::setText(- const QString &text)-{+void MigrationDialog::setText(const QString& text) {m_text->setText(text);}-void MigrationDialog::addBox(- QWidget *box)-{+void MigrationDialog::addBox(QWidget* box) {m_boxes->addWidget(box);-}-QAbstractButton *MigrationDialog::addButton(- const QString &text, const bool reject)-{- QAbstractButton *button = new QPushButton(this);+QAbstractButton* MigrationDialog::addButton(const QString& text, const bool reject) {+ QAbstractButton* button = new QPushButton(this);button->setText(text);m_buttons->addWidget(button, 1);@@ -58,7 +51,6 @@ QAbstractButton *MigrationDialog::addButton(return button;}-QAbstractButton *MigrationDialog::clickedButton() const-{+QAbstractButton* MigrationDialog::clickedButton() const {return m_clickedButton;}diff --git a/src/yuzu/migration_dialog.h b/src/yuzu/migration_dialog.hindex 7123fd6b87..a2a2c80358 100644--- a/src/yuzu/migration_dialog.h+++ b/src/yuzu/migration_dialog.h@@ -1,30 +1,33 @@+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project+// SPDX-License-Identifier: GPL-3.0-or-later+#ifndef MIGRATION_DIALOG_H#define MIGRATION_DIALOG_H-#include <QMessageBox>-#include <QWidget>#include <QHBoxLayout>+#include <QMessageBox>#include <QVBoxLayout>+#include <QWidget>class MigrationDialog : public QDialog {Q_OBJECTpublic:- MigrationDialog(QWidget *parent = nullptr);+ MigrationDialog(QWidget* parent = nullptr);virtual ~MigrationDialog();- void setText(const QString &text);- void addBox(QWidget *box);- QAbstractButton *addButton(const QString &text, const bool reject = false);+ void setText(const QString& text);+ void addBox(QWidget* box);+ QAbstractButton* addButton(const QString& text, const bool reject = false);- QAbstractButton *clickedButton() const;+ QAbstractButton* clickedButton() const;private:- QLabel *m_text;- QVBoxLayout *m_boxes;- QHBoxLayout *m_buttons;+ QLabel* m_text;+ QVBoxLayout* m_boxes;+ QHBoxLayout* m_buttons;- QAbstractButton *m_clickedButton;+ QAbstractButton* m_clickedButton;};#endif // MIGRATION_DIALOG_Hdiff --git a/src/yuzu/migration_worker.cpp b/src/yuzu/migration_worker.cppindex 0149db4149..ba5e50e187 100644--- a/src/yuzu/migration_worker.cpp+++ b/src/yuzu/migration_worker.cpp@@ -1,27 +1,22 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later-#include "migration_worker.h"#include "common/fs/symlink.h"+#include "migration_worker.h"+#include <filesystem>#include <QMap>#include <boost/algorithm/string/predicate.hpp>#include <boost/algorithm/string/replace.hpp>-#include <filesystem>#include "common/fs/path_util.h"-MigrationWorker::MigrationWorker(const Emulator selected_emu_,- const bool clear_shader_cache_,+MigrationWorker::MigrationWorker(const Emulator selected_emu_, const bool clear_shader_cache_,const MigrationStrategy strategy_)- : QObject()- , selected_emu(selected_emu_)- , clear_shader_cache(clear_shader_cache_)- , strategy(strategy_)-{}--void MigrationWorker::process()-{+ : QObject(), selected_emu(selected_emu_), clear_shader_cache(clear_shader_cache_),+ strategy(strategy_) {}++void MigrationWorker::process() {namespace fs = std::filesystem;constexpr auto copy_options = fs::copy_options::update_existing | fs::copy_options::recursive;@@ -42,7 +37,7 @@ void MigrationWorker::process()try {fs::remove_all(eden_dir);- } catch (fs::filesystem_error &_) {+ } catch (fs::filesystem_error& _) {// ignore because linux does stupid crap sometimes}@@ -53,7 +48,7 @@ void MigrationWorker::process()// Windows 11 has random permission nonsense to deal with.try {Common::FS::CreateSymlink(legacy_user_dir, eden_dir);- } catch (const fs::filesystem_error &e) {+ } catch (const fs::filesystem_error& e) {emit error(tr("Linking the old directory failed. You may need to re-run with ""administrative privileges on Windows.\nOS gave error: %1").arg(tr(e.what())));@@ -74,8 +69,7 @@ void MigrationWorker::process()success_text.append(tr("\n\nNote that your configuration and data will be shared with %1.\n""If this is not desirable, delete the following files:\n%2\n%3\n%4")- .arg(selected_emu.name(),- QString::fromStdString(eden_dir.string()),+ .arg(selected_emu.name(), QString::fromStdString(eden_dir.string()),QString::fromStdString(config_dir.string()),QString::fromStdString(cache_dir.string())));diff --git a/src/yuzu/migration_worker.h b/src/yuzu/migration_worker.hindex 2db05570ea..42abedb9c8 100644--- a/src/yuzu/migration_worker.h+++ b/src/yuzu/migration_worker.h@@ -1,4 +1,4 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later#ifndef MIGRATION_WORKER_H@@ -8,7 +8,7 @@#include "common/fs/path_util.h"typedef struct Emulator {- const char *m_name;+ const char* m_name;Common::FS::EmuPath e_user_dir;Common::FS::EmuPath e_config_dir;@@ -26,14 +26,20 @@ typedef struct Emulator {return Common::FS::GetLegacyPath(e_cache_dir).string();}- const QString name() const { return QObject::tr(m_name);+ const QString name() const {+ return QObject::tr(m_name);}- const QString lower_name() const { return name().toLower();+ const QString lower_name() const {+ return name().toLower();}} Emulator;-#define STRUCT_EMU(name, enumName) Emulator{name, Common::FS::enumName##Dir, Common::FS::enumName##ConfigDir, Common::FS::enumName##CacheDir}+#define STRUCT_EMU(name, enumName) \+ Emulator { \+ name, Common::FS::enumName##Dir, Common::FS::enumName##ConfigDir, \+ Common::FS::enumName##CacheDir \+ }static constexpr std::array<Emulator, 4> legacy_emus = {STRUCT_EMU(QT_TR_NOOP("Citron"), Citron),@@ -42,8 +48,7 @@ static constexpr std::array<Emulator, 4> legacy_emus = {STRUCT_EMU(QT_TR_NOOP("Yuzu"), Yuzu),};-class MigrationWorker : public QObject-{+class MigrationWorker : public QObject {Q_OBJECTpublic:enum class MigrationStrategy {@@ -52,16 +57,15 @@ public:Link,};- MigrationWorker(const Emulator selected_emu,- const bool clear_shader_cache,+ MigrationWorker(const Emulator selected_emu, const bool clear_shader_cache,const MigrationStrategy strategy);public slots:void process();signals:- void finished(const QString &success_text, const std::string &user_dir);- void error(const QString &error_message);+ void finished(const QString& success_text, const std::string& user_dir);+ void error(const QString& error_message);private:Emulator selected_emu;diff --git a/src/yuzu/multiplayer/chat_room.h b/src/yuzu/multiplayer/chat_room.hindex a94683ef58..44ec8952d1 100644--- a/src/yuzu/multiplayer/chat_room.h+++ b/src/yuzu/multiplayer/chat_room.h@@ -6,11 +6,11 @@#pragma once#include <memory>-#include <ankerl/unordered_dense.h>#include <QDialog>#include <QSortFilterProxyModel>#include <QStandardItemModel>#include <QVariant>+#include <ankerl/unordered_dense.h>#include "network/network.h"namespace Ui {diff --git a/src/yuzu/multiplayer/direct_connect.cpp b/src/yuzu/multiplayer/direct_connect.cppindex 486ab28213..eea906f16d 100644--- a/src/yuzu/multiplayer/direct_connect.cpp+++ b/src/yuzu/multiplayer/direct_connect.cpp@@ -1,4 +1,4 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later// SPDX-FileCopyrightText: Copyright 2017 Citra Emulator Project@@ -14,6 +14,7 @@#include "core/core.h"#include "core/internal_network/network_interface.h"#include "network/network.h"+#include "qt_common/config/uisettings.h"#include "ui_direct_connect.h"#include "yuzu/main_window.h"#include "yuzu/multiplayer/client_room.h"@@ -21,7 +22,6 @@#include "yuzu/multiplayer/message.h"#include "yuzu/multiplayer/state.h"#include "yuzu/multiplayer/validation.h"-#include "qt_common/config/uisettings.h"enum class ConnectionType : u8 { TraversalServer, IP };diff --git a/src/yuzu/multiplayer/host_room.cpp b/src/yuzu/multiplayer/host_room.cppindex 3e5e42e442..65afcc3b7c 100644--- a/src/yuzu/multiplayer/host_room.cpp+++ b/src/yuzu/multiplayer/host_room.cpp@@ -18,6 +18,7 @@#include "core/core.h"#include "core/internal_network/network_interface.h"#include "network/announce_multiplayer_session.h"+#include "qt_common/config/uisettings.h"#include "ui_host_room.h"#include "yuzu/game/game_list_p.h"#include "yuzu/main_window.h"@@ -25,7 +26,6 @@#include "yuzu/multiplayer/message.h"#include "yuzu/multiplayer/state.h"#include "yuzu/multiplayer/validation.h"-#include "qt_common/config/uisettings.h"#ifdef ENABLE_WEB_SERVICE#include "web_service/verify_user_jwt.h"#endif@@ -34,8 +34,7 @@ HostRoomWindow::HostRoomWindow(QWidget* parent, QStandardItemModel* list,std::shared_ptr<Core::AnnounceMultiplayerSession> session,Core::System& system_): QDialog(parent, Qt::WindowTitleHint | Qt::WindowCloseButtonHint | Qt::WindowSystemMenuHint),- ui(std::make_unique<Ui::HostRoom>()),- announce_multiplayer_session(session), system{system_} {+ ui(std::make_unique<Ui::HostRoom>()), announce_multiplayer_session(session), system{system_} {ui->setupUi(this);// set up validation for all of the fieldsdiff --git a/src/yuzu/multiplayer/lobby.cpp b/src/yuzu/multiplayer/lobby.cppindex f28374f75f..8c435af8b6 100644--- a/src/yuzu/multiplayer/lobby.cpp+++ b/src/yuzu/multiplayer/lobby.cpp@@ -13,6 +13,7 @@#include "core/hle/service/acc/profile_manager.h"#include "core/internal_network/network_interface.h"#include "network/network.h"+#include "qt_common/config/uisettings.h"#include "ui_lobby.h"#include "yuzu/game/game_list_p.h"#include "yuzu/main_window.h"@@ -22,7 +23,6 @@#include "yuzu/multiplayer/message.h"#include "yuzu/multiplayer/state.h"#include "yuzu/multiplayer/validation.h"-#include "qt_common/config/uisettings.h"#ifdef ENABLE_WEB_SERVICE#include "web_service/web_backend.h"#endif@@ -30,8 +30,7 @@Lobby::Lobby(QWidget* parent, QStandardItemModel* list,std::shared_ptr<Core::AnnounceMultiplayerSession> session, Core::System& system_): QDialog(parent, Qt::WindowTitleHint | Qt::WindowCloseButtonHint | Qt::WindowSystemMenuHint),- ui(std::make_unique<Ui::Lobby>()),- announce_multiplayer_session(session), system{system_} {+ ui(std::make_unique<Ui::Lobby>()), announce_multiplayer_session(session), system{system_} {ui->setupUi(this);// setup the watcher for background connectionsdiff --git a/src/yuzu/multiplayer/state.cpp b/src/yuzu/multiplayer/state.cppindex c344bcb8a3..b5f2326b44 100644--- a/src/yuzu/multiplayer/state.cpp+++ b/src/yuzu/multiplayer/state.cpp@@ -11,6 +11,7 @@#include "common/announce_multiplayer_room.h"#include "common/logging/log.h"#include "core/core.h"+#include "qt_common/config/uisettings.h"#include "yuzu/game/game_list.h"#include "yuzu/multiplayer/client_room.h"#include "yuzu/multiplayer/direct_connect.h"@@ -18,7 +19,6 @@#include "yuzu/multiplayer/lobby.h"#include "yuzu/multiplayer/message.h"#include "yuzu/multiplayer/state.h"-#include "qt_common/config/uisettings.h"#include "yuzu/util/clickable_label.h"MultiplayerState::MultiplayerState(QWidget* parent, QStandardItemModel* game_list_model_,diff --git a/src/yuzu/render/performance_overlay.h b/src/yuzu/render/performance_overlay.hindex 1d7fb46f26..a0325a10a3 100644--- a/src/yuzu/render/performance_overlay.h+++ b/src/yuzu/render/performance_overlay.h@@ -34,13 +34,13 @@ protected:void mousePressEvent(QMouseEvent* event) override;void mouseMoveEvent(QMouseEvent* event) override;- void closeEvent(QCloseEvent *event) override;+ void closeEvent(QCloseEvent* event) override;private:void resetPosition(const QPoint& pos);- void updateStats(const Core::PerfStatsResults &results, const VideoCore::ShaderNotify &shaders);+ void updateStats(const Core::PerfStatsResults& results, const VideoCore::ShaderNotify& shaders);- MainWindow *m_mainWindow = nullptr;+ MainWindow* m_mainWindow = nullptr;Ui::PerformanceOverlay* ui;// colors@@ -62,11 +62,11 @@ private:QPoint m_drag_start_pos;// fps chart- QLineSeries *m_fpsSeries = nullptr;- QChart *m_fpsChart = nullptr;- QChartView *m_fpsChartView = nullptr;- QValueAxis *m_fpsX = nullptr;- QValueAxis *m_fpsY = nullptr;+ QLineSeries* m_fpsSeries = nullptr;+ QChart* m_fpsChart = nullptr;+ QChartView* m_fpsChartView = nullptr;+ QValueAxis* m_fpsX = nullptr;+ QValueAxis* m_fpsY = nullptr;signals:void closed();diff --git a/src/yuzu/ryujinx_dialog.cpp b/src/yuzu/ryujinx_dialog.cppindex 563714f6be..f52f37b297 100644--- a/src/yuzu/ryujinx_dialog.cpp+++ b/src/yuzu/ryujinx_dialog.cpp@@ -1,20 +1,16 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later+#include <filesystem>#include "qt_common/abstract/frontend.h"-#include "ryujinx_dialog.h"#include "qt_common/util/fs.h"+#include "ryujinx_dialog.h"#include "ui_ryujinx_dialog.h"-#include <filesystem>-RyujinxDialog::RyujinxDialog(std::filesystem::path eden_path,- std::filesystem::path ryu_path,- QWidget *parent)- : QDialog(parent)- , ui(new Ui::RyujinxDialog)- , m_eden(eden_path.make_preferred())- , m_ryu(ryu_path.make_preferred())-{+RyujinxDialog::RyujinxDialog(std::filesystem::path eden_path, std::filesystem::path ryu_path,+ QWidget* parent)+ : QDialog(parent), ui(new Ui::RyujinxDialog), m_eden(eden_path.make_preferred()),+ m_ryu(ryu_path.make_preferred()) {ui->setupUi(this);connect(ui->eden, &QPushButton::clicked, this, &RyujinxDialog::fromEden);@@ -22,13 +18,11 @@ RyujinxDialog::RyujinxDialog(std::filesystem::path eden_path,connect(ui->cancel, &QPushButton::clicked, this, &RyujinxDialog::reject);}-RyujinxDialog::~RyujinxDialog()-{+RyujinxDialog::~RyujinxDialog() {delete ui;}-void RyujinxDialog::fromEden()-{+void RyujinxDialog::fromEden() {accept();// Workaround: Ryujinx deletes and re-creates its directory structure???@@ -38,17 +32,17 @@ void RyujinxDialog::fromEden()fs::remove_all(m_ryu);fs::create_directories(m_ryu);fs::copy(m_eden, m_ryu, fs::copy_options::recursive);- } catch (std::exception &e) {- QtCommon::Frontend::Critical(tr("Failed to link save data"),- tr("OS returned error: %1").arg(QString::fromStdString(e.what())));+ } catch (std::exception& e) {+ QtCommon::Frontend::Critical(+ tr("Failed to link save data"),+ tr("OS returned error: %1").arg(QString::fromStdString(e.what())));}// ?plooQtCommon::FS::LinkRyujinx(m_ryu, m_eden);}-void RyujinxDialog::fromRyujinx()-{+void RyujinxDialog::fromRyujinx() {accept();QtCommon::FS::LinkRyujinx(m_ryu, m_eden);}diff --git a/src/yuzu/ryujinx_dialog.h b/src/yuzu/ryujinx_dialog.hindex 63cebe483c..c067499cc1 100644--- a/src/yuzu/ryujinx_dialog.h+++ b/src/yuzu/ryujinx_dialog.h@@ -1,22 +1,22 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later#ifndef RYUJINX_DIALOG_H#define RYUJINX_DIALOG_H-#include <QDialog>#include <filesystem>+#include <QDialog>namespace Ui {class RyujinxDialog;}-class RyujinxDialog : public QDialog-{+class RyujinxDialog : public QDialog {Q_OBJECTpublic:- explicit RyujinxDialog(std::filesystem::path eden_path, std::filesystem::path ryu_path, QWidget *parent = nullptr);+ explicit RyujinxDialog(std::filesystem::path eden_path, std::filesystem::path ryu_path,+ QWidget* parent = nullptr);~RyujinxDialog();private slots:@@ -24,7 +24,7 @@ private slots:void fromRyujinx();private:- Ui::RyujinxDialog *ui;+ Ui::RyujinxDialog* ui;std::filesystem::path m_eden;std::filesystem::path m_ryu;};diff --git a/src/yuzu/set_play_time_dialog.cpp b/src/yuzu/set_play_time_dialog.cppindex c0f1f0be22..38876abd6d 100644--- a/src/yuzu/set_play_time_dialog.cpp+++ b/src/yuzu/set_play_time_dialog.cpp@@ -1,20 +1,23 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later-#include "yuzu/set_play_time_dialog.h"#include "frontend_common/play_time_manager.h"#include "ui_set_play_time_dialog.h"+#include "yuzu/set_play_time_dialog.h"SetPlayTimeDialog::SetPlayTimeDialog(QWidget* parent, u64 current_play_time): QDialog(parent), ui{std::make_unique<Ui::SetPlayTimeDialog>()} {ui->setupUi(this);ui->hoursSpinBox->setValue(- QString::fromStdString(PlayTime::PlayTimeManager::GetPlayTimeHours(current_play_time)).toInt());+ QString::fromStdString(PlayTime::PlayTimeManager::GetPlayTimeHours(current_play_time))+ .toInt());ui->minutesSpinBox->setValue(- QString::fromStdString(PlayTime::PlayTimeManager::GetPlayTimeMinutes(current_play_time)).toInt());+ QString::fromStdString(PlayTime::PlayTimeManager::GetPlayTimeMinutes(current_play_time))+ .toInt());ui->secondsSpinBox->setValue(- QString::fromStdString(PlayTime::PlayTimeManager::GetPlayTimeSeconds(current_play_time)).toInt());+ QString::fromStdString(PlayTime::PlayTimeManager::GetPlayTimeSeconds(current_play_time))+ .toInt());connect(ui->hoursSpinBox, QOverload<int>::of(&QSpinBox::valueChanged), this,&SetPlayTimeDialog::OnValueChanged);diff --git a/src/yuzu/set_play_time_dialog.h b/src/yuzu/set_play_time_dialog.hindex 75513539e5..a66ceb7ced 100644--- a/src/yuzu/set_play_time_dialog.h+++ b/src/yuzu/set_play_time_dialog.h@@ -1,10 +1,10 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later#pragma once-#include <QDialog>#include <memory>+#include <QDialog>#include "common/common_types.h"namespace Ui {diff --git a/src/yuzu/user_data_migration.cpp b/src/yuzu/user_data_migration.cppindex bc31c99e30..da8b0847c7 100644--- a/src/yuzu/user_data_migration.cpp+++ b/src/yuzu/user_data_migration.cpp@@ -1,42 +1,41 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later// Copyright Citra Emulator Project / Azahar Emulator Project// Licensed under GPLv2 or any later version// Refer to the license.txt file included.-#include "user_data_migration.h"#include <QMessageBox>#include <QPushButton>#include <QString>#include <QTranslator>#include "common/fs/path_util.h"#include "qt_common/qt_string_lookup.h"+#include "user_data_migration.h"#include "yuzu/migration_dialog.h"// Needs to be included at the end due to https://bugreports.qt.io/browse/QTBUG-73263+#include <filesystem>#include <QButtonGroup>#include <QCheckBox>#include <QGuiApplication>#include <QProgressDialog>#include <QRadioButton>#include <QThread>-#include <filesystem>-UserDataMigrator::UserDataMigrator(QMainWindow *main_window)-{+UserDataMigrator::UserDataMigrator(QMainWindow* main_window) {// NOTE: Logging is not initialized yet, do not produce logs here.// Check migration if config directory does not exist- // TODO: ProfileManager messes with us a bit here, and force-creates the /nand/system/save/8000000000000010/su/avators/profiles.dat- // file. Find a way to reorder operations and have it create after this guy runs.+ // TODO: ProfileManager messes with us a bit here, and force-creates the+ // /nand/system/save/8000000000000010/su/avators/profiles.dat file. Find a way to reorder+ // operations and have it create after this guy runs.if (!std::filesystem::is_directory(Common::FS::GetEdenPath(Common::FS::EdenPath::ConfigDir))) {ShowMigrationPrompt(main_window);}}-void UserDataMigrator::ShowMigrationPrompt(QMainWindow *main_window)-{+void UserDataMigrator::ShowMigrationPrompt(QMainWindow* main_window) {namespace fs = std::filesystem;using namespace QtCommon::StringLookup;@@ -44,35 +43,36 @@ void UserDataMigrator::ShowMigrationPrompt(QMainWindow *main_window)migration_prompt.setWindowTitle(QObject::tr("Migration"));// mutually exclusive- QButtonGroup *group = new QButtonGroup(&migration_prompt);+ QButtonGroup* group = new QButtonGroup(&migration_prompt);// MACRO MADNESS-#define BUTTON(clazz, name, text, tooltip, checkState) \- clazz *name = new clazz(&migration_prompt); \- name->setText(text); \- name->setToolTip(Lookup(tooltip)); \- name->setChecked(checkState); \+#define BUTTON(clazz, name, text, tooltip, checkState) \+ clazz* name = new clazz(&migration_prompt); \+ name->setText(text); \+ name->setToolTip(Lookup(tooltip)); \+ name->setChecked(checkState); \migration_prompt.addBox(name);- BUTTON(QCheckBox, clear_shaders, QObject::tr("Clear Shader Cache"), MigrationTooltipClearShader, true)+ BUTTON(QCheckBox, clear_shaders, QObject::tr("Clear Shader Cache"), MigrationTooltipClearShader,+ true)u32 id = 0;-#define RADIO(name, text, tooltip, checkState) \- BUTTON(QRadioButton, name, text, tooltip, checkState) \+#define RADIO(name, text, tooltip, checkState) \+ BUTTON(QRadioButton, name, text, tooltip, checkState) \group->addButton(name, ++id);- RADIO(keep_old, QObject::tr("Keep Old Data"), MigrationTooltipKeepOld, true)+ RADIO(keep_old, QObject::tr("Keep Old Data"), MigrationTooltipKeepOld, true)RADIO(clear_old, QObject::tr("Clear Old Data"), MigrationTooltipClearOld, false)- RADIO(link_old, QObject::tr("Link Old Directory"), MigrationTooltipLinkOld, false)+ RADIO(link_old, QObject::tr("Link Old Directory"), MigrationTooltipLinkOld, false)#undef RADIO#undef BUTTONstd::vector<Emulator> found{};- for (const Emulator &emu : legacy_emus)+ for (const Emulator& emu : legacy_emus)if (fs::is_directory(emu.get_user_dir()))found.emplace_back(emu);@@ -86,10 +86,10 @@ void UserDataMigrator::ShowMigrationPrompt(QMainWindow *main_window)QString prompt_text = Lookup(MigrationPromptPrefix);// natural language processing is a nightmare- for (const Emulator &emu : found) {+ for (const Emulator& emu : found) {prompt_text = prompt_text % QStringLiteral("\n ") % emu.name();- QAbstractButton *button = migration_prompt.addButton(emu.name());+ QAbstractButton* button = migration_prompt.addButton(emu.name());// This is cursed, but it's actually the most efficient way by a milebutton->setProperty("emulator", QVariant::fromValue(emu));@@ -103,26 +103,22 @@ void UserDataMigrator::ShowMigrationPrompt(QMainWindow *main_window)migration_prompt.exec();- QAbstractButton *button = migration_prompt.clickedButton();+ QAbstractButton* button = migration_prompt.clickedButton();if (button->text() == QObject::tr("No")) {return ShowMigrationCancelledMessage(main_window);}- MigrationWorker::MigrationStrategy strategy = static_cast<MigrationWorker::MigrationStrategy>(- group->checkedId());+ MigrationWorker::MigrationStrategy strategy =+ static_cast<MigrationWorker::MigrationStrategy>(group->checkedId());selected_emu = button->property("emulator").value<Emulator>();- MigrateUserData(main_window,- clear_shaders->isChecked(),- strategy);+ MigrateUserData(main_window, clear_shaders->isChecked(), strategy);}-void UserDataMigrator::ShowMigrationCancelledMessage(QMainWindow *main_window)-{- QMessageBox::information(main_window,- QObject::tr("Migration"),+void UserDataMigrator::ShowMigrationCancelledMessage(QMainWindow* main_window) {+ QMessageBox::information(main_window, QObject::tr("Migration"),QObject::tr("You can manually re-trigger this prompt by deleting the ""new config directory:\n%1").arg(QString::fromStdString(Common::FS::GetEdenPathString(@@ -130,33 +126,27 @@ void UserDataMigrator::ShowMigrationCancelledMessage(QMainWindow *main_window)QMessageBox::Ok);}-void UserDataMigrator::MigrateUserData(QMainWindow *main_window,- const bool clear_shader_cache,- const MigrationWorker::MigrationStrategy strategy)-{+void UserDataMigrator::MigrateUserData(QMainWindow* main_window, const bool clear_shader_cache,+ const MigrationWorker::MigrationStrategy strategy) {// Create a dialog to let the user know it's migrating- QProgressDialog *progress = new QProgressDialog(main_window);+ QProgressDialog* progress = new QProgressDialog(main_window);progress->setWindowTitle(QObject::tr("Migrating"));progress->setLabelText(QObject::tr("Migrating, this may take a while..."));progress->setRange(0, 0);progress->setCancelButton(nullptr);progress->setWindowModality(Qt::WindowModality::ApplicationModal);- QThread *thread = new QThread(main_window);- MigrationWorker *worker = new MigrationWorker(selected_emu, clear_shader_cache, strategy);+ QThread* thread = new QThread(main_window);+ MigrationWorker* worker = new MigrationWorker(selected_emu, clear_shader_cache, strategy);worker->moveToThread(thread);thread->connect(thread, &QThread::started, worker, &MigrationWorker::process);- thread->connect(worker,- &MigrationWorker::finished,- progress,- [=, this](const QString &success_text, const std::string &path) {+ thread->connect(worker, &MigrationWorker::finished, progress,+ [=, this](const QString& success_text, const std::string& path) {progress->close();- QMessageBox::information(main_window,- QObject::tr("Migration"),- success_text,- QMessageBox::Ok);+ QMessageBox::information(main_window, QObject::tr("Migration"),+ success_text, QMessageBox::Ok);migrated = true;thread->quit();diff --git a/src/yuzu/user_data_migration.h b/src/yuzu/user_data_migration.hindex 1cfeda3bca..df8057eaa5 100644--- a/src/yuzu/user_data_migration.h+++ b/src/yuzu/user_data_migration.h@@ -1,4 +1,4 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later// Copyright Citra Emulator Project / Azahar Emulator Project@@ -21,7 +21,6 @@ public:private:void ShowMigrationPrompt(QMainWindow* main_window);void ShowMigrationCancelledMessage(QMainWindow* main_window);- void MigrateUserData(QMainWindow* main_window,- const bool clear_shader_cache,+ void MigrateUserData(QMainWindow* main_window, const bool clear_shader_cache,const MigrationWorker::MigrationStrategy strategy);};diff --git a/src/yuzu/util/util.cpp b/src/yuzu/util/util.cppindex 307f121a49..3e9ebc2ad2 100644--- a/src/yuzu/util/util.cpp+++ b/src/yuzu/util/util.cpp@@ -1,4 +1,4 @@-// SPDX-FileCopyrightText: Copyright 2025 Eden Emulator Project+// SPDX-FileCopyrightText: Copyright 2026 Eden Emulator Project// SPDX-License-Identifier: GPL-3.0-or-later// SPDX-FileCopyrightText: 2015 Citra Emulator Project@@ -157,11 +157,11 @@ const std::optional<Common::UUID> GetProfileID() {const auto select_profile = [] {const Core::Frontend::ProfileSelectParameters parameters{- .mode = Service::AM::Frontend::UiMode::UserSelector,- .invalid_uid_list = {},- .display_options = {},- .purpose = Service::AM::Frontend::UserSelectionPurpose::General,- };+ .mode = Service::AM::Frontend::UiMode::UserSelector,+ .invalid_uid_list = {},+ .display_options = {},+ .purpose = Service::AM::Frontend::UserSelectionPurpose::General,+ };QtProfileSelectionDialog dialog(*QtCommon::system, QtCommon::rootObject, parameters);dialog.setWindowFlags(Qt::Dialog | Qt::CustomizeWindowHint | Qt::WindowTitleHint |Qt::WindowSystemMenuHint | Qt::WindowCloseButtonHint);diff --git a/src/yuzu/vk_device_info.cpp b/src/yuzu/vk_device_info.cppindex 45faecb95d..2b87ccd3ca 100644--- a/src/yuzu/vk_device_info.cpp+++ b/src/yuzu/vk_device_info.cpp@@ -62,12 +62,13 @@ void PopulateRecords(std::vector<Record>& records, QWindow* window) try {const auto driverID = driver_properties.driverID;- bool has_broken_compute{Vulkan::Device::CheckBrokenCompute(- driverID, properties.properties.driverVersion)};+ bool has_broken_compute{+ Vulkan::Device::CheckBrokenCompute(driverID, properties.properties.driverVersion)};std::string driver_string = Vulkan::vk::GetDriverName(driver_properties);- if (driver_string.empty()) driver_string = "Unknown";+ if (driver_string.empty())+ driver_string = "Unknown";name = fmt::format("{} ({})", name, driver_string);