VERY experimental Nintendo Switch 2 emulator
C++
audio_in/out_system: Pass Initialize members by value where applicable
Lioncasha8b7993c882c
diff --git a/src/audio_core/in/audio_in_system.cpp b/src/audio_core/in/audio_in_system.cppindex 6b7e6715cf..4324cafd84 100644--- a/src/audio_core/in/audio_in_system.cpp+++ b/src/audio_core/in/audio_in_system.cpp@@ -56,7 +56,7 @@ Result System::IsConfigValid(const std::string_view device_name,return ResultSuccess;}-Result System::Initialize(std::string& device_name, const AudioInParameter& in_params,+Result System::Initialize(std::string device_name, const AudioInParameter& in_params,const u32 handle_, const u64 applet_resource_user_id_) {auto result{IsConfigValid(device_name, in_params)};if (result.IsError()) {diff --git a/src/audio_core/in/audio_in_system.h b/src/audio_core/in/audio_in_system.hindex b9dc0e60ff..1c51546381 100644--- a/src/audio_core/in/audio_in_system.h+++ b/src/audio_core/in/audio_in_system.h@@ -97,7 +97,7 @@ public:* @param applet_resource_user_id - Unused.* @return Result code.*/- Result Initialize(std::string& device_name, const AudioInParameter& in_params, u32 handle,+ Result Initialize(std::string device_name, const AudioInParameter& in_params, u32 handle,u64 applet_resource_user_id);/**diff --git a/src/audio_core/out/audio_out_system.cpp b/src/audio_core/out/audio_out_system.cppindex 48a8019232..a66208ed9c 100644--- a/src/audio_core/out/audio_out_system.cpp+++ b/src/audio_core/out/audio_out_system.cpp@@ -49,8 +49,8 @@ Result System::IsConfigValid(std::string_view device_name,return Service::Audio::ERR_INVALID_CHANNEL_COUNT;}-Result System::Initialize(std::string& device_name, const AudioOutParameter& in_params, u32 handle_,- u64& applet_resource_user_id_) {+Result System::Initialize(std::string device_name, const AudioOutParameter& in_params, u32 handle_,+ u64 applet_resource_user_id_) {auto result = IsConfigValid(device_name, in_params);if (result.IsError()) {return result;diff --git a/src/audio_core/out/audio_out_system.h b/src/audio_core/out/audio_out_system.hindex 0817b2f371..b95cb91bec 100644--- a/src/audio_core/out/audio_out_system.h+++ b/src/audio_core/out/audio_out_system.h@@ -88,8 +88,8 @@ public:* @param applet_resource_user_id - Unused.* @return Result code.*/- Result Initialize(std::string& device_name, const AudioOutParameter& in_params, u32 handle,- u64& applet_resource_user_id);+ Result Initialize(std::string device_name, const AudioOutParameter& in_params, u32 handle,+ u64 applet_resource_user_id);/*** Start this system.diff --git a/src/core/hle/service/audio/audin_u.cpp b/src/core/hle/service/audio/audin_u.cppindex 48a9a73a0e..608925dfcd 100644--- a/src/core/hle/service/audio/audin_u.cpp+++ b/src/core/hle/service/audio/audin_u.cpp@@ -17,7 +17,7 @@ using namespace AudioCore::AudioIn;class IAudioIn final : public ServiceFramework<IAudioIn> {public:explicit IAudioIn(Core::System& system_, Manager& manager, size_t session_id,- std::string& device_name, const AudioInParameter& in_params, u32 handle,+ const std::string& device_name, const AudioInParameter& in_params, u32 handle,u64 applet_resource_user_id): ServiceFramework{system_, "IAudioIn"},service_context{system_, "IAudioIn"}, event{service_context.CreateEvent("AudioInEvent")},diff --git a/src/core/hle/service/audio/audout_u.cpp b/src/core/hle/service/audio/audout_u.cppindex 49c0923016..122290c6a6 100644--- a/src/core/hle/service/audio/audout_u.cpp+++ b/src/core/hle/service/audio/audout_u.cpp@@ -24,7 +24,7 @@ using namespace AudioCore::AudioOut;class IAudioOut final : public ServiceFramework<IAudioOut> {public:explicit IAudioOut(Core::System& system_, AudioCore::AudioOut::Manager& manager,- size_t session_id, std::string& device_name,+ size_t session_id, const std::string& device_name,const AudioOutParameter& in_params, u32 handle, u64 applet_resource_user_id): ServiceFramework{system_, "IAudioOut", ServiceThreadType::CreateNew},service_context{system_, "IAudioOut"}, event{service_context.CreateEvent(