VERY experimental Nintendo Switch 2 emulator
C++
common: fix bitfield aliasing on GCC/Clang
Liamb7b77ea2ac28
diff --git a/src/common/bit_field.h b/src/common/bit_field.hindex 16d805694e..7e1df62b1c 100644--- a/src/common/bit_field.h+++ b/src/common/bit_field.h@@ -146,7 +146,16 @@ public:}constexpr void Assign(const T& value) {+#ifdef _MSC_VERstorage = static_cast<StorageType>((storage & ~mask) | FormatValue(value));+#else+ // Explicitly reload with memcpy to avoid compiler aliasing quirks+ // regarding optimization: GCC/Clang clobber chained stores to+ // different bitfields in the same struct with the last value.+ StorageTypeWithEndian storage_;+ std::memcpy(&storage_, &storage, sizeof(storage_));+ storage = static_cast<StorageType>((storage_ & ~mask) | FormatValue(value));+#endif}[[nodiscard]] constexpr T Value() const {