Skip to content

armgit / Filee

Public Imported from GitHub
0

Free, open-source file converter. Convert 263 formats offline by drag & drop — images, PDF, Word, Excel, PowerPoint, HWP/HWPX, video, audio, e-books and archives. No upload, no Office needed.

Say on the Engines card, in every language, why an MSI didn't unpack (#527)

cre8ive-marketing2da738705c18
diff --git a/src/Filee.App/Assets/i18n/ar.json b/src/Filee.App/Assets/i18n/ar.json
index 2e478d2e..47e3d707 100644
--- a/src/Filee.App/Assets/i18n/ar.json
+++ b/src/Filee.App/Assets/i18n/ar.json
@@ -82,6 +82,8 @@
"format_request.notice_title": "لا يستطيع Filee تحويل ملفات {0} بعد",
"format_request.notice_text": "أخبرنا بالصيغة التي تحتاجها.\nتساعد الطلبات في تحديد الصيغ التي سيدعمها Filee لاحقًا.\nلا يمكن تحويل الملفات المشفّرة أو المحمية من النسخ (DRM)، مهما كانت صيغتها.",
"error.no_route": "لا يوجد محرك يستطيع إجراء هذا التحويل",
+ "error.msi_busy": "يجري تثبيت آخر الآن. حاول مرة أخرى بعد انتهائه",
+ "error.msi_link": "تعذّر على Windows Installer فتح الحزمة: قد يكون أحد المجلدات في المسار رابطًا إلى محرك أقراص آخر",
"error.cannot_turn": "التدوير والانعكاس متاحان للصور فقط",
"error.images_only": "متاح للصور فقط",
"error.no_transparency": "هذا التنسيق لا يدعم الشفافية، لذا لا يوجد ما يُقص",
diff --git a/src/Filee.App/Assets/i18n/de.json b/src/Filee.App/Assets/i18n/de.json
index bd6d4181..7d375a27 100644
--- a/src/Filee.App/Assets/i18n/de.json
+++ b/src/Filee.App/Assets/i18n/de.json
@@ -82,6 +82,8 @@
"format_request.notice_title": "Filee kann {0}-Dateien noch nicht konvertieren",
"format_request.notice_text": "Sag uns, welches Format du brauchst.\nDie Anfragen bestimmen, welche Formate Filee als Nächstes unterstützt.\nVerschlüsselte oder kopiergeschützte Dateien (DRM) lassen sich unabhängig vom Format nicht konvertieren.",
"error.no_route": "Kein Modul kann diese Konvertierung ausführen",
+ "error.msi_busy": "Eine andere Installation läuft gerade. Versuche es erneut, wenn sie fertig ist",
+ "error.msi_link": "Windows Installer konnte das Paket nicht öffnen: Ein Ordner auf dem Weg ist vielleicht ein Link auf ein anderes Laufwerk",
"error.cannot_turn": "Drehen und Spiegeln ist nur bei Bildern möglich",
"error.images_only": "Nur bei Bildern möglich",
"error.no_transparency": "Dieses Format unterstützt keine Transparenz. Es gibt daher keine transparenten Ränder zum Abschneiden",
diff --git a/src/Filee.App/Assets/i18n/en.json b/src/Filee.App/Assets/i18n/en.json
index f41855fa..5270c342 100644
--- a/src/Filee.App/Assets/i18n/en.json
+++ b/src/Filee.App/Assets/i18n/en.json
@@ -88,6 +88,8 @@
"format_request.notice_title": "Filee can't convert {0} files yet",
"format_request.notice_text": "Tell us which format you need.\nRequests decide what Filee supports next.\nEncrypted or copy-protected (DRM) files can't be converted, whatever the format.",
"error.no_route": "No engine can do this conversion",
+ "error.msi_busy": "Another installation is running. Try again when it has finished",
+ "error.msi_link": "Windows Installer couldn't open the package: a folder on its way may be a link to another drive",
"error.cannot_turn": "Rotate and flip work on images only",
"error.images_only": "Works on images only",
"error.no_transparency": "This format has no transparency, so there's nothing to trim",
diff --git a/src/Filee.App/Assets/i18n/es.json b/src/Filee.App/Assets/i18n/es.json
index 18f3d58d..5c138530 100644
--- a/src/Filee.App/Assets/i18n/es.json
+++ b/src/Filee.App/Assets/i18n/es.json
@@ -82,6 +82,8 @@
"format_request.notice_title": "Filee aún no puede convertir archivos {0}",
"format_request.notice_text": "Cuéntanos qué formato necesitas.\nLas solicitudes determinan qué formatos admitirá Filee a continuación.\nLos archivos cifrados o con protección de copia (DRM) no se pueden convertir, sea cual sea su formato.",
"error.no_route": "Ningún motor puede hacer esta conversión",
+ "error.msi_busy": "Hay otra instalación en curso. Vuelve a intentarlo cuando termine",
+ "error.msi_link": "Windows Installer no pudo abrir el paquete: puede que una carpeta de la ruta sea un enlace a otra unidad",
"error.cannot_turn": "Rotar y voltear solo funcionan con imágenes",
"error.images_only": "Solo funciona con imágenes",
"error.no_transparency": "Este formato no tiene transparencia, así que no hay nada que recortar",
diff --git a/src/Filee.App/Assets/i18n/fr.json b/src/Filee.App/Assets/i18n/fr.json
index c5d243b5..03bf7ff6 100644
--- a/src/Filee.App/Assets/i18n/fr.json
+++ b/src/Filee.App/Assets/i18n/fr.json
@@ -88,6 +88,8 @@
"format_request.notice_title": "Filee ne sait pas encore convertir les fichiers {0}",
"format_request.notice_text": "Dites-nous de quel format vous avez besoin.\nLes demandes décident de ce que Filee prendra en charge ensuite.\nLes fichiers chiffrés ou protégés contre la copie (DRM) ne peuvent pas être convertis, quel que soit le format.",
"error.no_route": "Aucun moteur ne peut effectuer cette conversion",
+ "error.msi_busy": "Une autre installation est en cours. Réessayez quand elle sera terminée",
+ "error.msi_link": "Windows Installer n'a pas pu ouvrir le paquet : un dossier du chemin est peut-être un lien vers un autre lecteur",
"error.cannot_turn": "La rotation et le retournement ne s'appliquent qu'aux images",
"error.images_only": "Ne s'applique qu'aux images",
"error.no_transparency": "Ce format n'a pas de transparence : il n'y a rien à rogner",
diff --git a/src/Filee.App/Assets/i18n/hi.json b/src/Filee.App/Assets/i18n/hi.json
index a3e798a5..5d25a613 100644
--- a/src/Filee.App/Assets/i18n/hi.json
+++ b/src/Filee.App/Assets/i18n/hi.json
@@ -82,6 +82,8 @@
"format_request.notice_title": "Filee अभी {0} फ़ाइलें कन्वर्ट नहीं कर सकता",
"format_request.notice_text": "हमें बताएँ कि आपको कौन-सा फ़ॉर्मैट चाहिए।\nअनुरोधों से तय होता है कि Filee आगे क्या समर्थन करेगा।\nएन्क्रिप्टेड या कॉपी-सुरक्षित (DRM) फ़ाइलें किसी भी फ़ॉर्मैट में कन्वर्ट नहीं की जा सकतीं।",
"error.no_route": "कोई भी इंजन यह कन्वर्ज़न नहीं कर सकता",
+ "error.msi_busy": "कोई दूसरा इंस्टॉलेशन चल रहा है। उसके पूरा होने के बाद फिर से कोशिश करें",
+ "error.msi_link": "Windows Installer पैकेज नहीं खोल सका: रास्ते का कोई फ़ोल्डर किसी दूसरी ड्राइव का लिंक हो सकता है",
"error.cannot_turn": "घुमाना और पलटना केवल इमेज पर काम करता है",
"error.images_only": "केवल इमेज पर काम करता है",
"error.no_transparency": "इस फ़ॉर्मैट में पारदर्शिता नहीं है, इसलिए काटने को कुछ नहीं है",
diff --git a/src/Filee.App/Assets/i18n/ja.json b/src/Filee.App/Assets/i18n/ja.json
index b6960a36..8f964307 100644
--- a/src/Filee.App/Assets/i18n/ja.json
+++ b/src/Filee.App/Assets/i18n/ja.json
@@ -82,6 +82,8 @@
"format_request.notice_title": "Fileeはまだ{0}ファイルを変換できません",
"format_request.notice_text": "必要な形式を教えてください。\nリクエストをもとに、今後Fileeが対応する形式を決めます。\n暗号化またはコピー保護(DRM)されたファイルは、形式にかかわらず変換できません。",
"error.no_route": "この変換に対応するエンジンがありません",
+ "error.msi_busy": "別のインストールが実行中です。終わってからもう一度お試しください",
+ "error.msi_link": "Windows Installer がパッケージを開けませんでした。パスの途中のフォルダーが別のドライブへのリンクになっている可能性があります",
"error.cannot_turn": "回転と反転は画像でのみ使えます",
"error.images_only": "画像でのみ使えます",
"error.no_transparency": "この形式には透明部分がないため、切り取るものがありません",
diff --git a/src/Filee.App/Assets/i18n/ko.json b/src/Filee.App/Assets/i18n/ko.json
index 09604dda..49de80cc 100644
--- a/src/Filee.App/Assets/i18n/ko.json
+++ b/src/Filee.App/Assets/i18n/ko.json
@@ -88,6 +88,8 @@
"format_request.notice_title": "아직 {0} 파일은 변환할 수 없어요",
"format_request.notice_text": "필요한 형식을 알려주세요.\n요청을 보고 다음에 지원할 형식을 정해요.\n암호화되거나 DRM이 걸린 파일은 변환할 수 없어요.",
"error.no_route": "이 변환을 할 수 있는 엔진이 없어요",
+ "error.msi_busy": "다른 설치가 진행 중입니다. 끝난 뒤 다시 시도하세요",
+ "error.msi_link": "Windows Installer가 패키지를 열지 못했습니다. 경로의 폴더가 다른 드라이브로 연결된 링크일 수 있습니다",
"error.cannot_turn": "회전·반전은 이미지에만 할 수 있어요",
"error.images_only": "이미지에만 쓸 수 있어요",
"error.no_transparency": "이 형식에는 투명한 부분이 없어서 잘라낼 것이 없어요",
diff --git a/src/Filee.App/Assets/i18n/ne.json b/src/Filee.App/Assets/i18n/ne.json
index dade701b..a5c4053d 100644
--- a/src/Filee.App/Assets/i18n/ne.json
+++ b/src/Filee.App/Assets/i18n/ne.json
@@ -82,6 +82,8 @@
"format_request.notice_title": "Filee ले अहिलेसम्म {0} फाइलहरू रूपान्तरण गर्न सक्दैन",
"format_request.notice_text": "तपाईंले चाहेको ढाँचा समर्थित छैन? हामीलाई अनुरोध पठाउनुहोस् र हामी यसलाई थप्ने प्रयास गर्नेछौं।",
"error.no_route": "कुनै पनि इन्जिनले यो रूपान्तरण गर्न सक्दैन",
+ "error.msi_busy": "अर्को स्थापना चलिरहेको छ। त्यो सकिएपछि फेरि प्रयास गर्नुहोस्",
+ "error.msi_link": "Windows Installer ले प्याकेज खोल्न सकेन: बाटोको कुनै फोल्डर अर्को ड्राइभको लिङ्क हुन सक्छ",
"error.cannot_turn": "घुमाउने र उल्ट्याउने कार्य केवल छविहरूमा मात्र काम गर्छ",
"error.images_only": "केवल छविहरूमा मात्र काम गर्छ",
"error.ocr_language_download": "OCR भाषा डाउनलोड गर्न सकिएन",
diff --git a/src/Filee.App/Assets/i18n/pl.json b/src/Filee.App/Assets/i18n/pl.json
index 0c7af06e..935a9141 100644
--- a/src/Filee.App/Assets/i18n/pl.json
+++ b/src/Filee.App/Assets/i18n/pl.json
@@ -88,6 +88,8 @@
"format_request.notice_title": "Filee nie potrafi jeszcze konwertować plików {0}",
"format_request.notice_text": "Napisz, jakiego formatu potrzebujesz.\nNa podstawie próśb wybieramy kolejne obsługiwane formaty.\nPlików zaszyfrowanych lub chronionych przed kopiowaniem (DRM) nie da się konwertować, niezależnie od formatu.",
"error.no_route": "Żaden silnik nie wykona tej konwersji",
+ "error.msi_busy": "Trwa inna instalacja. Spróbuj ponownie, gdy się zakończy",
+ "error.msi_link": "Instalator Windows nie mógł otworzyć pakietu: folder na ścieżce może być łączem do innego dysku",
"error.cannot_turn": "Obracanie i odbicie działają tylko na obrazach",
"error.images_only": "Działa tylko na obrazach",
"error.no_transparency": "Ten format nie ma przezroczystości, więc nie ma czego przycinać",
diff --git a/src/Filee.App/Assets/i18n/pt-BR.json b/src/Filee.App/Assets/i18n/pt-BR.json
index 88d47fda..52fca17c 100644
--- a/src/Filee.App/Assets/i18n/pt-BR.json
+++ b/src/Filee.App/Assets/i18n/pt-BR.json
@@ -88,6 +88,8 @@
"format_request.notice_title": "O Filee ainda não converte arquivos {0}",
"format_request.notice_text": "Diga qual formato você precisa.\nOs pedidos decidem o que o Filee passa a aceitar.\nArquivos criptografados ou protegidos contra cópia (DRM) não podem ser convertidos, seja qual for o formato.",
"error.no_route": "Nenhum motor faz esta conversão",
+ "error.msi_busy": "Outra instalação está em andamento. Tente de novo quando ela terminar",
+ "error.msi_link": "O Windows Installer não conseguiu abrir o pacote: uma pasta no caminho pode ser um link para outra unidade",
"error.cannot_turn": "Girar e espelhar só funcionam em imagens",
"error.images_only": "Só funciona em imagens",
"error.no_transparency": "Este formato não tem transparência, então não há nada para cortar",
diff --git a/src/Filee.App/Assets/i18n/pt-PT.json b/src/Filee.App/Assets/i18n/pt-PT.json
index f89ce25c..5cd442d6 100644
--- a/src/Filee.App/Assets/i18n/pt-PT.json
+++ b/src/Filee.App/Assets/i18n/pt-PT.json
@@ -88,6 +88,8 @@
"format_request.notice_title": "O Filee ainda não consegue converter ficheiros {0}",
"format_request.notice_text": "Diz-nos de que formato precisas.\nOs pedidos ajudam a decidir os próximos formatos suportados pelo Filee.\nNão é possível converter ficheiros encriptados ou protegidos contra cópia (DRM), seja qual for o formato.",
"error.no_route": "Nenhum motor consegue fazer esta conversão",
+ "error.msi_busy": "Está a decorrer outra instalação. Tente novamente quando terminar",
+ "error.msi_link": "O Windows Installer não conseguiu abrir o pacote: uma pasta no caminho pode ser uma ligação para outra unidade",
"error.cannot_turn": "Só é possível rodar e inverter imagens",
"error.images_only": "Só funciona com imagens",
"error.no_transparency": "Este formato não admite transparência, pelo que não há nada para recortar",
diff --git a/src/Filee.App/Assets/i18n/ru.json b/src/Filee.App/Assets/i18n/ru.json
index 47f36cb2..6425bfa6 100644
--- a/src/Filee.App/Assets/i18n/ru.json
+++ b/src/Filee.App/Assets/i18n/ru.json
@@ -88,6 +88,8 @@
"format_request.notice_title": "Filee пока не умеет конвертировать файлы {0}",
"format_request.notice_text": "Напишите, какой формат вам нужен.\nОт запросов зависит, что Filee будет поддерживать дальше.\nЗашифрованные и защищённые от копирования (DRM) файлы сконвертировать нельзя, в каком бы формате они ни были.",
"error.no_route": "Нет движка для такой конвертации",
+ "error.msi_busy": "Выполняется другая установка. Повторите попытку, когда она завершится",
+ "error.msi_link": "Установщику Windows не удалось открыть пакет: возможно, одна из папок на пути — ссылка на другой диск",
"error.cannot_turn": "Поворот и отражение работают только с изображениями",
"error.images_only": "Работает только с изображениями",
"error.no_transparency": "В этом формате нет прозрачности, обрезать нечего",
diff --git a/src/Filee.App/Assets/i18n/th.json b/src/Filee.App/Assets/i18n/th.json
index ff9466b6..bbeac137 100644
--- a/src/Filee.App/Assets/i18n/th.json
+++ b/src/Filee.App/Assets/i18n/th.json
@@ -82,6 +82,8 @@
"format_request.notice_title": "Filee ยังไม่สามารถแปลงไฟล์ {0} ได้",
"format_request.notice_text": "แจ้งให้เราทราบว่าคุณต้องการฟอร์แมตใด\nคำขอของคุณจะช่วยกำหนดฟอร์แมตที่ Filee จะพัฒนาต่อไป\nไฟล์ที่เข้ารหัสหรือติดการคุ้มครองลิขสิทธิ์ (DRM) จะไม่สามารถแปลงได้ไม่ว่าจะฟอร์แมตใดก็ตาม",
"error.no_route": "ไม่มีเครื่องมือที่แปลงฟอร์แมตนี้ได้",
+ "error.msi_busy": "มีการติดตั้งอื่นกำลังทำงานอยู่ โปรดลองอีกครั้งเมื่อเสร็จแล้ว",
+ "error.msi_link": "Windows Installer เปิดแพ็กเกจไม่ได้: โฟลเดอร์บางโฟลเดอร์ในเส้นทางอาจเป็นลิงก์ไปยังไดรฟ์อื่น",
"error.cannot_turn": "การหมุนและพลิกภาพใช้ได้กับไฟล์รูปภาพเท่านั้น",
"error.images_only": "ใช้ได้กับไฟล์รูปภาพเท่านั้น",
"error.ocr_language_download": "ดาวน์โหลดภาษาสำหรับ OCR ไม่ได้",
diff --git a/src/Filee.App/Assets/i18n/tr.json b/src/Filee.App/Assets/i18n/tr.json
index ad1043c9..40f77b23 100644
--- a/src/Filee.App/Assets/i18n/tr.json
+++ b/src/Filee.App/Assets/i18n/tr.json
@@ -82,6 +82,8 @@
"format_request.notice_title": "Filee henüz {0} dosyalarını dönüştüremiyor",
"format_request.notice_text": "İhtiyacınız olan biçimi bize bildirin.\nFilee'nin sırada hangi biçimleri destekleyeceğini talepler belirler.\nŞifreli veya kopya korumalı (DRM) dosyalar, biçimi ne olursa olsun dönüştürülemez.",
"error.no_route": "Bu dönüştürmeyi yapabilen bir motor yok",
+ "error.msi_busy": "Başka bir yükleme sürüyor. Bittiğinde yeniden deneyin",
+ "error.msi_link": "Windows Installer paketi açamadı: yoldaki bir klasör başka bir sürücüye bağlantı olabilir",
"error.cannot_turn": "Döndürme ve çevirme yalnızca görsellerde çalışır",
"error.images_only": "Yalnızca görsellerde çalışır",
"error.no_transparency": "Bu biçim saydamlık içermediği için kırpılacak alan yok",
diff --git a/src/Filee.App/Assets/i18n/zh-CN.json b/src/Filee.App/Assets/i18n/zh-CN.json
index e0b384c6..30904ff3 100644
--- a/src/Filee.App/Assets/i18n/zh-CN.json
+++ b/src/Filee.App/Assets/i18n/zh-CN.json
@@ -88,6 +88,8 @@
"format_request.notice_title": "Filee 暂时无法转换 {0} 文件",
"format_request.notice_text": "告诉我们你需要的格式。\n我们会根据请求决定接下来支持哪些格式。\n加密或有复制保护 (DRM) 的文件,无论什么格式都无法转换。",
"error.no_route": "没有引擎可以完成此转换",
+ "error.msi_busy": "另一个安装正在进行。请在它完成后重试",
+ "error.msi_link": "Windows Installer 无法打开安装包:路径中的某个文件夹可能是指向其他驱动器的链接",
"error.cannot_turn": "只能旋转和翻转图片",
"error.images_only": "只能用于图片",
"error.no_transparency": "此格式没有透明部分,无需裁剪",
diff --git a/src/Filee.App/Assets/i18n/zh-TW.json b/src/Filee.App/Assets/i18n/zh-TW.json
index ae6a3806..2d3cb920 100644
--- a/src/Filee.App/Assets/i18n/zh-TW.json
+++ b/src/Filee.App/Assets/i18n/zh-TW.json
@@ -88,6 +88,8 @@
"format_request.notice_title": "Filee 暫時無法轉換 {0} 檔案",
"format_request.notice_text": "告訴我們你需要的格式。\n我們會根據請求決定接下來支援哪些格式。\n加密或有複製保護 (DRM) 的檔案,無論什麼格式都無法轉換。",
"error.no_route": "沒有引擎可以完成此轉換",
+ "error.msi_busy": "另一個安裝正在進行。請在它完成後再試一次",
+ "error.msi_link": "Windows Installer 無法開啟安裝套件:路徑中的某個資料夾可能是指向其他磁碟機的連結",
"error.cannot_turn": "只能旋轉和翻轉圖片",
"error.images_only": "只能用於圖片",
"error.no_transparency": "此格式沒有透明部分,無需裁切",
diff --git a/src/Filee.App/Services/EngineDownloadService.cs b/src/Filee.App/Services/EngineDownloadService.cs
index 2bd41056..23ba1e95 100644
--- a/src/Filee.App/Services/EngineDownloadService.cs
+++ b/src/Filee.App/Services/EngineDownloadService.cs
@@ -4,6 +4,7 @@
using System.Diagnostics;
using Avalonia.Threading;
using CommunityToolkit.Mvvm.ComponentModel;
+using Filee.App.ViewModels;
using Filee.Core.Conversion;
using Filee.Core.Localization;
using Filee.Engines.Infrastructure;
@@ -295,7 +296,7 @@ public sealed class EngineDownloadService
catch (Exception ex)
{
_logger.LogError(ex, "Installing engine package {Package} failed", state.Package.Id);
- state.Error = ex is HttpRequestException ? ex.Message : ex.GetBaseException().Message;
+ state.Error = ErrorText(_loc, ex);
state.Status = EnginePackageStatus.Failed;
}
finally
@@ -305,6 +306,12 @@ public sealed class EngineDownloadService
}
}
+ /// <summary>The reason on the Engines card: an installer's error.* reason in the user's language (#527).</summary>
+ internal static string ErrorText(ILocalizer loc, Exception ex) =>
+ ex is HttpRequestException ? ex.Message
+ : ex.GetBaseException() is ConversionRefusedException refused ? FailureText.Reason(loc, refused.ErrorKey, refused.Detail)
+ : ex.GetBaseException().Message;
+
public void Cancel(EnginePackageState state) => state.Cancellation?.Cancel();
/// <summary>
diff --git a/src/Filee.Engines/Infrastructure/EngineInstaller.cs b/src/Filee.Engines/Infrastructure/EngineInstaller.cs
index f2abe87d..90b5cf01 100644
--- a/src/Filee.Engines/Infrastructure/EngineInstaller.cs
+++ b/src/Filee.Engines/Infrastructure/EngineInstaller.cs
@@ -14,6 +14,7 @@ using System.Diagnostics;
using System.Formats.Tar;
using System.IO.Compression;
using System.Security.Cryptography;
+using Filee.Core.Conversion;
using Microsoft.Extensions.Logging;
using Microsoft.Extensions.Logging.Abstractions;
using SharpCompress.Compressors.Xz;
@@ -368,14 +369,15 @@ public sealed class EngineInstaller
throw;
}
if (process.ExitCode != 0)
- throw new InvalidOperationException(MsiFailure(id, process.ExitCode, log));
+ throw MsiFailure(id, process.ExitCode, log);
}
- internal static string MsiFailure(string id, int exitCode, string log) => exitCode switch
+ /// <summary>What the Engines card shows: the reasons a user can act on in their language (error.* keys).</summary>
+ internal static Exception MsiFailure(string id, int exitCode, string log) => exitCode switch
{
- 1618 => "Another installation is running. Try again when it has finished.",
- 1620 => $"Windows Installer couldn't open the {id} package (error 1620): a folder on its way may be a link to another drive (log: {log}).",
- _ => $"Unpacking {id} failed (msiexec exit code {exitCode}, log: {log}).",
+ 1618 => new ConversionRefusedException("error.msi_busy"),
+ 1620 => new ConversionRefusedException("error.msi_link", $"msiexec 1620, log: {log}"),
+ _ => new InvalidOperationException($"Unpacking {id} failed (msiexec exit code {exitCode}, log: {log})."),
};
/// <summary>
diff --git a/tests/Filee.App.Tests/EnginesPageTests.cs b/tests/Filee.App.Tests/EnginesPageTests.cs
index eb6f4d66..bc6df23e 100644
--- a/tests/Filee.App.Tests/EnginesPageTests.cs
+++ b/tests/Filee.App.Tests/EnginesPageTests.cs
@@ -30,6 +30,30 @@ public class EnginesPageTests
private static Point Middle(Control card, Visual to) => card.TranslatePoint(new Point(card.Bounds.Width / 2, card.Bounds.Height / 2), to)!.Value;
+ [AvaloniaFact]
+ public void A_package_Windows_Installer_cannot_open_says_why_in_the_users_language()
+ {
+ // #527: msiexec 1620, a junction on the way. The card says so in the user's language, with the log's path.
+ TestServices.EnsureInitialized("en");
+ var loc = AppHost.Get<LocalizationService>();
+ var failure = Filee.Engines.Infrastructure.EngineInstaller.MsiFailure("libreoffice", 1620, @"C:\Temp\filee-msiexec.log");
+ try
+ {
+ loc.SetLanguage("ko");
+ var text = EngineDownloadService.ErrorText(loc, failure);
+ Assert.StartsWith(loc["error.msi_link"], text);
+ Assert.NotEqual("error.msi_link", loc["error.msi_link"]);
+ Assert.EndsWith(@"(msiexec 1620, log: C:\Temp\filee-msiexec.log)", text);
+ Assert.Equal(loc["error.msi_busy"], EngineDownloadService.ErrorText(loc, Filee.Engines.Infrastructure.EngineInstaller.MsiFailure("calibre", 1618, "log")));
+ }
+ finally
+ {
+ loc.SetLanguage("en");
+ }
+ Assert.Contains("exit code 1603", EngineDownloadService.ErrorText(loc, new AggregateException(
+ Filee.Engines.Infrastructure.EngineInstaller.MsiFailure("calibre", 1603, "log"))));
+ }
+
[AvaloniaFact]
public void Dragging_a_card_below_the_next_one_moves_it_there_and_saves_the_order()
{
diff --git a/tests/Filee.Engines.Tests/RealPathTests.cs b/tests/Filee.Engines.Tests/RealPathTests.cs
index 8b5b0cb3..68980733 100644
--- a/tests/Filee.Engines.Tests/RealPathTests.cs
+++ b/tests/Filee.Engines.Tests/RealPathTests.cs
@@ -3,6 +3,7 @@
using System.Diagnostics;
using System.Runtime.Versioning;
+using Filee.Core.Conversion;
using Filee.Engines.Infrastructure;
namespace Filee.Engines.Tests;
@@ -68,10 +69,12 @@ public sealed class RealPathTests : IDisposable
[Fact]
public void An_installer_that_cannot_open_its_package_says_so()
{
- var message = EngineInstaller.MsiFailure("libreoffice", 1620, @"C:\Temp\filee-msiexec.log");
- Assert.Contains("Windows Installer couldn't open the libreoffice package (error 1620)", message);
- Assert.Contains(@"C:\Temp\filee-msiexec.log", message);
- Assert.Contains("exit code 1603", EngineInstaller.MsiFailure("calibre", 1603, "log"));
+ // In the user's language on the Engines card (error.* keys, every language file has them).
+ var link = Assert.IsType<ConversionRefusedException>(EngineInstaller.MsiFailure("libreoffice", 1620, @"C:\Temp\filee-msiexec.log"));
+ Assert.Equal("error.msi_link", link.ErrorKey);
+ Assert.Equal(@"msiexec 1620, log: C:\Temp\filee-msiexec.log", link.Detail);
+ Assert.Equal("error.msi_busy", Assert.IsType<ConversionRefusedException>(EngineInstaller.MsiFailure("calibre", 1618, "log")).ErrorKey);
+ Assert.Contains("exit code 1603", EngineInstaller.MsiFailure("calibre", 1603, "log").Message);
}
private static void Junction(string link, string target)