Skip to content

armgit / Filee

Public Imported from GitHub
0

Free, open-source file converter. Convert 263 formats offline by drag & drop — images, PDF, Word, Excel, PowerPoint, HWP/HWPX, video, audio, e-books and archives. No upload, no Office needed.

Read .ahk, .ini, .rsc and .cmd files as plain text (#536, #630, #661, #660)

KnifeLemon468a1dd04335
diff --git a/docs/ENGINES.md b/docs/ENGINES.md
index 42fdc3a0..e3e5c646 100644
--- a/docs/ENGINES.md
+++ b/docs/ENGINES.md
@@ -12,7 +12,7 @@ Filee chooses engines automatically. Settings → *Engines* shows their status,
| PDFsharp | built in (library) | images → PDF, merge, split, page ranges, page organising, lossless rotate and crop-box edits, spreadsheet print-studio assembly, **compression** (smaller PDFs, see below), PDFs without their metadata |
| PDFium | built in (library) | PDF → images (multi-page TIFF/GIF supported) |
| Unhwp | built in (library) | HWP/HWPX → TXT, Markdown, HTML (pictures in a `<name>_files` folder next to the Markdown, embedded in the HTML) |
-| Text & Markdown (Markdig) | built in (library) | **Markdown → HTML, TXT**; **TXT, LOG, PY, PAC, BAT, COMMAND, LUA, CSS, PS1, SQL → UTF-8 TXT**, preserving source text without running scripts (and → PDF / DOCX through the HWPX writer, rhwp or LibreOffice) |
+| Text & Markdown (Markdig) | built in (library) | **Markdown → HTML, TXT**; **TXT, LOG, PY, PAC, BAT, CMD, COMMAND, LUA, CSS, PS1, SQL, AHK, INI, RSC → UTF-8 TXT**, preserving source text without running scripts (and → PDF / DOCX through the HWPX writer, rhwp or LibreOffice) |
| Spreadsheets (ExcelDataReader for XLS) | built in (library) | **XLSX, XLS, ODS, CSV, TSV → XLSX, ODS, CSV, TSV** (one CSV / TSV per sheet) |
| Office Open XML | built in | **DOCM / DOTX / DOTM ↔ DOCX, XLSM / XLTX ↔ XLSX, PPTM / POTX / POTM / PPSX ↔ PPTX** (macros removed for macro-free types) |
| Fonts | built in | **TTF, OTF, WOFF, WOFF2, EOT ↔ each other**; **FON (NE monochrome FNT v2/v3, supported single-byte charsets) → TTF, OTF, WOFF, WOFF2, EOT only**; CFF (PostScript) outlines become TrueType for TTF and EOT |
diff --git a/src/Filee.Core/Formats/FormatRegistry.cs b/src/Filee.Core/Formats/FormatRegistry.cs
index 93cb0a8f..b5d77853 100644
--- a/src/Filee.Core/Formats/FormatRegistry.cs
+++ b/src/Filee.Core/Formats/FormatRegistry.cs
@@ -140,9 +140,10 @@ public static class FormatRegistry
new("sda", "SDA", FormatCategory.Presentation, ["sda", "sdd"], Writable: false),
// Plain text / markup
- // Text logs, source/proxy scripts and style sheets are read as plain text, never executed (issues #273, #284, #254,
- // #388, #368, #607).
- new("txt", "TXT", FormatCategory.Text, ["txt", "log", "py", "pac", "bat", "command", "lua", "css", "ps1", "sql"]),
+ // Text logs, source/proxy scripts, style sheets and settings files are read as plain text, never executed (issues
+ // #273, #284, #254, #388, #368, #607, #536, #630, #661, #660).
+ new("txt", "TXT", FormatCategory.Text,
+ ["txt", "log", "py", "pac", "bat", "cmd", "command", "lua", "css", "ps1", "sql", "ahk", "ini", "rsc"]),
new("md", "Markdown", FormatCategory.Text, ["md", "markdown"]),
new("html", "HTML", FormatCategory.Text, ["html", "htm", "xhtml"]),
// A web page saved with its pictures in one MIME file (Chrome, Edge, Word); read as the page it holds.
diff --git a/src/Filee.Core/Settings/AppSettings.cs b/src/Filee.Core/Settings/AppSettings.cs
index bede3d9c..b5f953c4 100644
--- a/src/Filee.Core/Settings/AppSettings.cs
+++ b/src/Filee.Core/Settings/AppSettings.cs
@@ -123,7 +123,7 @@ public sealed class DonutSettings
public sealed class AppSettings
{
/// <summary>Current schema version. Increase when the format changes and add a migration.</summary>
- public const int CurrentSchemaVersion = 48;
+ public const int CurrentSchemaVersion = 49;
public int SchemaVersion { get; set; } = CurrentSchemaVersion;
diff --git a/src/Filee.Core/Settings/UserDataStore.cs b/src/Filee.Core/Settings/UserDataStore.cs
index f9c47a37..d4ae8582 100644
--- a/src/Filee.Core/Settings/UserDataStore.cs
+++ b/src/Filee.Core/Settings/UserDataStore.cs
@@ -889,6 +889,10 @@ internal static class SettingsMigrations
// v48: fragmented MP4 pieces (.m4s) learn the video donut; custom claims stay put.
if (from < 48)
changed |= LearnExtensions(profiles, out _, ["m4s"]);
+ // v49: SQL (#607, which came without a migration), AutoHotkey, INI, RouterOS exports and .cmd batch scripts learn
+ // the text donut; custom claims stay put. (Schema 49 may be renumbered if another change takes it first.)
+ if (from < 49)
+ changed |= LearnExtensions(profiles, out _, ["sql", "ahk", "ini", "rsc", "cmd"]);
return changed;
}
diff --git a/tests/Filee.Core.Tests/ScriptTextTests.cs b/tests/Filee.Core.Tests/ScriptTextTests.cs
index 00ee33b3..7f730314 100644
--- a/tests/Filee.Core.Tests/ScriptTextTests.cs
+++ b/tests/Filee.Core.Tests/ScriptTextTests.cs
@@ -1,5 +1,5 @@
-// Lua and PowerShell scripts and CSS style sheets are plain text (issues #388, #368, #442): recognised, and learnt by
-// existing text donuts.
+// Lua, PowerShell, AutoHotkey and batch scripts, SQL, INI files, RouterOS exports and CSS style sheets are plain text
+// (issues #388, #368, #442, #607, #536, #630, #661, #660): recognised, and learnt by existing text donuts.
using Filee.Core.Formats;
using Filee.Core.Presets;
@@ -14,6 +14,11 @@ public class ScriptTextTests
[InlineData("init.lua")]
[InlineData("site.css")]
[InlineData("Backup.ps1")]
+ [InlineData("Hotkeys.AHK")]
+ [InlineData("desktop.ini")]
+ [InlineData("router-export.rsc")]
+ [InlineData("install.cmd")]
+ [InlineData("query.sql")]
public void Scripts_and_style_sheets_are_text(string name) => Assert.Equal("txt", FormatRegistry.Detect(name)?.Id);
[Fact]
@@ -46,4 +51,22 @@ public class ScriptTextTests
Assert.Contains("ps1", profiles.Single(p => p.Id == "text").Extensions);
Assert.False(SettingsMigrations.ApplyToLibrary(39, presets, profiles));
}
+
+ [Fact]
+ public void Version_48_text_donuts_learn_sql_ahk_ini_rsc_and_cmd_without_taking_custom_claims()
+ {
+ string[] added = ["sql", "ahk", "ini", "rsc", "cmd"];
+ var presets = BuiltInData.CreatePresets();
+ var profiles = BuiltInData.CreateProfiles();
+ foreach (var profile in profiles)
+ profile.Extensions.RemoveAll(added.Contains);
+ profiles.Insert(0, new ToolbarProfile { Id = "my-router", Name = "Router", Extensions = ["rsc"] });
+
+ Assert.True(SettingsMigrations.ApplyToLibrary(48, presets, profiles));
+
+ var text = profiles.Single(p => p.Id == "text").Extensions;
+ Assert.All(added.Where(e => e != "rsc"), e => Assert.Contains(e, text));
+ Assert.DoesNotContain("rsc", text); // the user's own donut has it
+ Assert.False(SettingsMigrations.ApplyToLibrary(48, presets, profiles));
+ }
}