Skip to content

armgit / Filee

Public Imported from GitHub
0

Free, open-source file converter. Convert 263 formats offline by drag & drop — images, PDF, Word, Excel, PowerPoint, HWP/HWPX, video, audio, e-books and archives. No upload, no Office needed.

Merge the contributor's latest push (their own main merge) into the review fixes

KnifeLemonbdab5885dad4
diff --cc tests/Filee.App.Tests/LocalizationTests.cs
index 905d886c,d3af3cda..77cba377
--- a/tests/Filee.App.Tests/LocalizationTests.cs
+++ b/tests/Filee.App.Tests/LocalizationTests.cs
@@@ -23,14 -23,24 +23,22 @@@ public partial class LocalizationTest
public static TheoryData<string> Languages => new(LocalizationService.Languages.Where(l => l.Code != "en").Select(l => l.Code));
+ [Fact]
+ public void Shared_language_registry_covers_every_shipped_translation_once()
+ {
+ var codes = LocalizationService.Languages.Select(l => l.Code).ToList();
+ Assert.Equal(codes.Count, codes.Distinct(StringComparer.OrdinalIgnoreCase).Count());
+ Assert.Equal(Directory.GetFiles(I18nDirectory, "*.json").Select(Path.GetFileNameWithoutExtension).Order(), codes.Order());
+ }
+
- [Theory]
- [InlineData("ar")]
- [InlineData("AR")]
- [InlineData("ar-IQ")]
- [InlineData("ar-SA")]
- public void Arabic_is_offered_under_its_own_name_and_accepts_regional_cultures(string culture)
+ [Fact]
+ public void Arabic_is_offered_under_its_own_name_and_reads_right_to_left()
{
Assert.Contains(("ar", "العربية"), LocalizationService.Languages);
- Assert.Equal("ar", LocalizationService.Resolve(culture));
- Assert.Contains("fonts:Filee#Noto Sans Arabic", ThemeService.FontFamilies(culture));
+ Assert.Equal("ar", LocalizationService.Resolve("AR"));
+ Assert.Contains("fonts:Filee#Noto Sans Arabic", ThemeService.FontFamilies("ar"));
+ Assert.True(SoftPalette.IsRightToLeft("ar"));
+ Assert.All(LocalizationService.Languages.Where(l => l.Code != "ar"), l => Assert.False(SoftPalette.IsRightToLeft(l.Code)));
}
[Theory]
diff --cc tests/Filee.Setup.Tests/SetupWindowTests.cs
index 97ef3f52,88e65689..93d11532
--- a/tests/Filee.Setup.Tests/SetupWindowTests.cs
+++ b/tests/Filee.Setup.Tests/SetupWindowTests.cs
@@@ -89,6 -89,7 +89,7 @@@ public class SetupWindowTest
{
var (model, _, runner) = Model(language);
var window = Show(model);
- Assert.Equal(FlowDirection.LeftToRight, window.FlowDirection);
++ Assert.Equal(language == "ar" ? FlowDirection.RightToLeft : FlowDirection.LeftToRight, window.FlowDirection);
Check(window, $"setup-1-welcome-{language}.png");
model.ToggleOptionsCommand.Execute(null);
@@@ -263,9 -266,10 +266,11 @@@
{
var (model, texts, _) = Model("en");
var window = Show(model);
- model.SelectedLanguage = model.Languages.Single(l => l.Code == "ko");
+ model.SelectedLanguage = model.Languages.Single(l => l.Code == language);
Pump();
- Assert.Equal("ko", texts.Language);
+ Assert.Equal(language, texts.Language);
- Assert.Equal(FlowDirection.LeftToRight, window.FlowDirection);
++ // Picking Arabic mirrors the card at once.
++ Assert.Equal(language == "ar" ? FlowDirection.RightToLeft : FlowDirection.LeftToRight, window.FlowDirection);
Assert.Equal(texts["installer.install"], model.PrimaryText);
Assert.Contains("2.0.0", model.WelcomeText);
var choices = model.Choices();