Free, open-source file converter. Convert 263 formats offline by drag & drop — images, PDF, Word, Excel, PowerPoint, HWP/HWPX, video, audio, e-books and archives. No upload, no Office needed.
C# audio-converteravaloniabatch-conversionconvertercsharpdocument-converterdocx-to-pdfdotnetdrag-and-dropfile-conversionfile-converterheic-converterhwphwpximage-converterlinuxmacospdf-convertervideo-converterwindows
feat(thumbnails): support video thumbnails via FFmpeg downscaling
gtxPrimed9757e8ad08b
diff --git a/src/Filee.App/Services/HistoryThumbnails.cs b/src/Filee.App/Services/HistoryThumbnails.csindex 6f1c36e5..c9672784 100644--- a/src/Filee.App/Services/HistoryThumbnails.cs+++ b/src/Filee.App/Services/HistoryThumbnails.cs@@ -1,12 +1,16 @@// Small square pictures of converted files for the Home page's recent conversions. Skia decodes them off the UI// thread, at a fraction of the picture's size where the format allows it (JPEG, WebP), from a copy of the file read in-// one go, so the file is held open only while it is read and others may still write, rename or delete it meanwhile. A-// small cache keeps them while the files don't change: a search lists the same conversions again at once.+// one go, so the file is held open only while it is read and others may still write, rename or delete it meanwhile.+// Video formats (MP4, MKV, WebM, etc.) have a representative frame extracted and scaled via FFmpeg off the UI thread+// without locking the file. A small cache keeps them while the files don't change: a search lists the same conversions+// again at once.using Avalonia;using Avalonia.Media.Imaging;using Avalonia.Platform;+using Filee.Core.Formats;using Filee.Core.Platform;+using Filee.Engines.Media;using SkiaSharp;namespace Filee.App.Services;@@ -16,7 +20,7 @@ internal static class HistoryThumbnails/// <summary>Width and height in pixels: the card shows it at 42, so this is sharp up to 200 % scaling.</summary>public const int Size = 96;- /// <summary>Larger files are not read: the card shows their format instead.</summary>+ /// <summary>Larger image files are not read: the card shows their format instead.</summary>internal const long MaxFileBytes = 64L * 1024 * 1024;/// <summary>@@ -38,8 +42,15 @@ internal static class HistoryThumbnailsprivate static readonly Dictionary<string, Entry> Cache = new(FileSystemPaths.Comparer);private static readonly Lock CacheLock = new();- /// <summary>Whether <paramref name="path"/> is a picture a thumbnail can be made of (by its extension only).</summary>- public static bool CanShow(string path) => Readable.Contains(Path.GetExtension(path).TrimStart('.'));+ /// <summary>Whether <paramref name="path"/> is a picture or video a thumbnail can be made of (by its extension only).</summary>+ public static bool CanShow(string path)+ {+ var ext = Path.GetExtension(path).TrimStart('.');+ return Readable.Contains(ext) || IsVideo(ext);+ }++ internal static bool IsVideo(string ext) =>+ FormatRegistry.FindByExtension(ext)?.Category == FormatCategory.Video;/// <summary>The thumbnail made last time for <paramref name="path"/>, without looking at the file.</summary>public static Bitmap? Cached(string path)@@ -50,7 +61,7 @@ internal static class HistoryThumbnails/// <summary>/// The thumbnail of <paramref name="path"/>, from the cache while the file is unchanged. Null when the file is gone,- /// too large or not a picture Skia reads. Reads the disk: never call it on the UI thread.+ /// too large or not a picture/video Filee reads. Reads the disk: never call it on the UI thread./// </summary>public static Bitmap? Load(string path){@@ -74,8 +85,14 @@ internal static class HistoryThumbnailsreturn hit.Bitmap;}+ var ext = Path.GetExtension(path).TrimStart('.');+ var isVideo = IsVideo(ext);// A file that can't be read is remembered too, so a search doesn't try it again on every key.- var bitmap = length <= MaxFileBytes ? Decode(path, MaxDecodedPixels) : null;+ // Image files larger than MaxFileBytes are skipped to conserve memory; videos are seeked by FFmpeg directly.+ var bitmap = isVideo+ ? (length > 0 ? DecodeVideo(path, MaxDecodedPixels) : null)+ : (length <= MaxFileBytes ? Decode(path, MaxDecodedPixels) : null);+lock (CacheLock){if (Cache.Count >= CacheSize)@@ -85,6 +102,68 @@ internal static class HistoryThumbnailsreturn bitmap;}+ /// <summary>+ /// Extracts a representative frame of video <paramref name="path"/> using FFmpeg, scaled directly in the filtergraph,+ /// and decodes it into a <see cref="Size"/> square. Null when FFmpeg is unavailable, video is broken, or frame decoding fails.+ /// </summary>+ internal static Bitmap? DecodeVideo(string path, long maxPixels)+ {+ var ffmpeg = FfmpegConverter.Locate()?.Ffmpeg;+ if (ffmpeg is null || !File.Exists(ffmpeg))+ return null;++ var temp = Path.Combine(Path.GetTempPath(), $"filee-thumb-{Guid.NewGuid():N}.jpg");+ try+ {+ // One seek to 1s (or nearest keyframe) with FFmpeg scaling to min(Size, Size) to avoid huge 8K frame buffers.+ var arguments = new[]+ {+ "-hide_banner",+ "-nostdin",+ "-v", "error",+ "-ss", "1",+ "-i", Path.GetFullPath(path),+ "-frames:v", "1",+ "-vf", $"scale={Size}:{Size}:force_original_aspect_ratio=increase,crop={Size}:{Size}",+ "-y",+ temp+ };++ var result = FfmpegRunner.RunBriefly(ffmpeg, arguments, TimeSpan.FromSeconds(5));+ if (result.ExitCode != 0 || !File.Exists(temp))+ return null;++ using var stream = new FileStream(temp, FileMode.Open, FileAccess.Read, FileShare.ReadWrite | FileShare.Delete);+ using var data = SKData.Create(stream);+ if (data is null)+ return null;++ using var codec = SKCodec.Create(data);+ if (codec is null || codec.Info.Width <= 0 || codec.Info.Height <= 0)+ return null;++ var info = new SKImageInfo(codec.Info.Width, codec.Info.Height, SKColorType.Bgra8888, SKAlphaType.Premul);+ using var decoded = new SKBitmap(info);+ if (codec.GetPixels(info, decoded.GetPixels()) is not (SKCodecResult.Success or SKCodecResult.IncompleteInput))+ return null;++ return Square(decoded, codec.EncodedOrigin);+ }+ catch (Exception)+ {+ return null;+ }+ finally+ {+ try+ {+ if (File.Exists(temp))+ File.Delete(temp);+ }+ catch { }+ }+ }+/// <summary>/// Decodes <paramref name="path"/> into a <see cref="Size"/> square: upright (the EXIF orientation applied) and/// cropped from the middle. Null when it can't, or would have to decode more than <paramref name="maxPixels"/>.diff --git a/src/Filee.Engines/Filee.Engines.csproj b/src/Filee.Engines/Filee.Engines.csprojindex a0219929..ca144acd 100644--- a/src/Filee.Engines/Filee.Engines.csproj+++ b/src/Filee.Engines/Filee.Engines.csproj@@ -38,6 +38,7 @@<ItemGroup><InternalsVisibleTo Include="Filee" /><InternalsVisibleTo Include="Filee.Engines.Tests" />+ <InternalsVisibleTo Include="Filee.App.Tests" /></ItemGroup><ItemGroup>diff --git a/tests/Filee.App.Tests/RecentConversionTests.cs b/tests/Filee.App.Tests/RecentConversionTests.csindex 2cad57ef..13f2ee3d 100644--- a/tests/Filee.App.Tests/RecentConversionTests.cs+++ b/tests/Filee.App.Tests/RecentConversionTests.cs@@ -94,7 +94,15 @@ public class RecentConversionTestsFile.WriteAllBytes(broken, [0x89, 0x50, 0x4E, 0x47, 1, 2, 3]);Assert.Null(HistoryThumbnails.Load(broken));+ var brokenVideo = Path.Combine(folder, "broken.mp4");+ File.WriteAllBytes(brokenVideo, [0, 0, 0, 0x18, 0x66, 0x74, 0x79, 0x70]);+ Assert.Null(HistoryThumbnails.Load(brokenVideo));+Assert.True(HistoryThumbnails.CanShow(@"C:\a\photo.JPG"));+ Assert.True(HistoryThumbnails.CanShow(@"C:\a\clip.mp4"));+ Assert.True(HistoryThumbnails.CanShow(@"C:\a\movie.MKV"));+ Assert.True(HistoryThumbnails.CanShow(@"C:\a\sample.webm"));+ Assert.True(HistoryThumbnails.CanShow(@"C:\a\phone.MOV"));Assert.False(HistoryThumbnails.CanShow(@"C:\a\report.pdf"));Assert.False(HistoryThumbnails.CanShow(@"C:\a\folder"));}@@ -104,6 +112,52 @@ public class RecentConversionTests}}+ [AvaloniaFact]+ public void A_video_generates_a_thumbnail_when_ffmpeg_is_available()+ {+ var tools = Filee.Engines.Media.FfmpegConverter.Locate();+ if (tools is null)+ return;++ var folder = Directory.CreateTempSubdirectory("filee-videothumbs-").FullName;+ try+ {+ var video = Path.Combine(folder, "sample.mp4");+ var psi = new System.Diagnostics.ProcessStartInfo(tools.Value.Ffmpeg)+ {+ UseShellExecute = false,+ CreateNoWindow = true,+ };+ psi.ArgumentList.Add("-hide_banner");+ psi.ArgumentList.Add("-nostdin");+ psi.ArgumentList.Add("-v");+ psi.ArgumentList.Add("error");+ psi.ArgumentList.Add("-y");+ psi.ArgumentList.Add("-f");+ psi.ArgumentList.Add("lavfi");+ psi.ArgumentList.Add("-i");+ psi.ArgumentList.Add("testsrc=duration=2:size=320x240:rate=10");+ psi.ArgumentList.Add("-pix_fmt");+ psi.ArgumentList.Add("yuv420p");+ psi.ArgumentList.Add(video);++ using var process = System.Diagnostics.Process.Start(psi);+ Assert.NotNull(process);+ Assert.True(process.WaitForExit(20_000));+ if (process.ExitCode != 0 || !File.Exists(video))+ return;++ var thumbnail = HistoryThumbnails.Load(video);+ Assert.NotNull(thumbnail);+ Assert.Equal(new PixelSize(HistoryThumbnails.Size, HistoryThumbnails.Size), thumbnail.PixelSize);+ Assert.Same(thumbnail, HistoryThumbnails.Cached(video));+ }+ finally+ {+ Directory.Delete(folder, true);+ }+ }+[AvaloniaTheory][InlineData(true)][InlineData(false)]