Skip to content

armgit / Filee

Public Imported from GitHub
0

Free, open-source file converter. Convert 263 formats offline by drag & drop — images, PDF, Word, Excel, PowerPoint, HWP/HWPX, video, audio, e-books and archives. No upload, no Office needed.

test: dispose remaining render models and cover Portuguese zoom

Blackspiritse7101aba97f4
diff --git a/docs/PORTUGUESE-LOCALIZATION.md b/docs/PORTUGUESE-LOCALIZATION.md
index ce640a7d..b484ded5 100644
--- a/docs/PORTUGUESE-LOCALIZATION.md
+++ b/docs/PORTUGUESE-LOCALIZATION.md
@@ -1,15 +1,15 @@
# Portuguese localization
Phase 1 adds European Portuguese and refines regional integration with the Brazilian translation already merged
-in #322. The current baseline is upstream `a97a07cd2eea20dbf80f03332d2710b874eb09f9` (23 October 2026).
+in #322. The current baseline is upstream `e3c6536ad020bfa92e0a16bca1c704554c9bbdf3` (23 October 2026).
French, Traditional Chinese, Nepali, Thai, Material You, OCR, palette tabs and the other merged upstream changes
are retained.
Phase 2 has not started.
## Coverage and wording
-Both Portuguese catalogs contain all **1,025 English keys**, in English key order: 1,003 upstream entries,
-18 descriptive engine names and four compact donut labels. Three native macOS strings per variant are additional
+Both Portuguese catalogs contain all **1,034 English keys**, in English key order: 1,011 upstream entries,
+19 descriptive engine names and four compact donut labels. Three native macOS strings per variant are additional
to those JSON entries. There are fifteen registered languages. The twelve non-Portuguese translations retain
English for the new engine names pending maintainer review; compact labels reuse their existing full translations.
This preserves their earlier metadata-based display rather than claiming unreviewed native translations.
@@ -118,6 +118,16 @@ local automated results, headless PNGs and partial real Windows interaction. It
the historical successful run below must not be treated as validation of the new head. The earlier head remained
a draft. See the current integration report for readiness.
+## Submission integration: UI scale and PDF tables — 23 October 2026
+
+Upstream main advanced to `e3c6536a` while the full native matrix was running. This integration preserves the
+new UI-scale controls and PDF-table converter, translates their eight new source keys in pt-PT, and adds the
+nineteenth descriptive engine name (`Tabelas PDF` / `Tabelas de PDF`) under the existing fallback policy. All
+fifteen catalogs contain 1,034 keys. No existing translation value is rewritten, including the upstream Brazilian
+messages. Fifteen adjacent JSON/Theme-page conflicts retain both the upstream functionality and this
+contribution's scrolling/layout changes. The existing UI-scale Theme-page test also runs in both Portuguese
+variants and produces independent captures. Additional theme packs and Phase 2 remain separate future work.
+
## Final upstream catch-up — 23 October 2026
Merge `614cb4d5` incorporates upstream `a97a07c` without conflicts or rewritten history. The 47 new English
diff --git a/docs/PORTUGUESE-REVIEW-FOLLOWUP.md b/docs/PORTUGUESE-REVIEW-FOLLOWUP.md
index 42c53858..2fad8e96 100644
--- a/docs/PORTUGUESE-REVIEW-FOLLOWUP.md
+++ b/docs/PORTUGUESE-REVIEW-FOLLOWUP.md
@@ -2,7 +2,17 @@
The independent review examined b694dad, based on Filee 2.0.0 at 799e394. The first follow-up integrated upstream
a121a3c9e3254918f8b171bb7f675b0bdc532244 on 22 October. The current integration is
-a97a07cd2eea20dbf80f03332d2710b874eb09f9, verified on 23 October 2026. Only Blackspirits/Filee is changed.
+e3c6536ad020bfa92e0a16bca1c704554c9bbdf3, verified on 23 October 2026. Only Blackspirits/Filee is changed.
+
+## Submission integration: UI scale and PDF tables — 23 October 2026
+
+Upstream main advanced to `e3c6536a` while the full native matrix was running. This integration preserves the
+new UI-scale controls and PDF-table converter, translates their eight new source keys in pt-PT, and adds the
+nineteenth descriptive engine name (`Tabelas PDF` / `Tabelas de PDF`) under the existing fallback policy. All
+fifteen catalogs contain 1,034 keys. No existing translation value is rewritten, including the upstream Brazilian
+messages. Fifteen adjacent JSON/Theme-page conflicts retain both the upstream functionality and this
+contribution's scrolling/layout changes. The existing UI-scale Theme-page test also runs in both Portuguese
+variants and produces independent captures. Additional theme packs and Phase 2 remain separate future work.
## Final upstream catch-up — 23 October 2026
diff --git a/tests/Filee.App.Tests/RenderTests.cs b/tests/Filee.App.Tests/RenderTests.cs
index 96ca6163..cebdbab7 100644
--- a/tests/Filee.App.Tests/RenderTests.cs
+++ b/tests/Filee.App.Tests/RenderTests.cs
@@ -125,7 +125,7 @@ public class RenderTests
store.Settings.WatchFolders.Add(rule);
try
{
- var vm = new MainWindowViewModel(AppHost.Services, AppHost.Get<Filee.Core.Localization.ILocalizer>(), AppHost.Get<UpdateService>());
+ using var vm = new MainWindowViewModel(AppHost.Services, AppHost.Get<Filee.Core.Localization.ILocalizer>(), AppHost.Get<UpdateService>());
vm.Navigate("watch");
var window = new MainWindow { DataContext = vm, Width = 1080, Height = 820 };
window.Show();
@@ -178,7 +178,7 @@ public class RenderTests
};
try
{
- var vm = new MainWindowViewModel(AppHost.Services, AppHost.Get<Filee.Core.Localization.ILocalizer>(), AppHost.Get<UpdateService>());
+ using var vm = new MainWindowViewModel(AppHost.Services, AppHost.Get<Filee.Core.Localization.ILocalizer>(), AppHost.Get<UpdateService>());
vm.Navigate("watch");
var window = new MainWindow { DataContext = vm, Width = 1080, Height = 1000 };
window.Show();
@@ -235,7 +235,7 @@ public class RenderTests
store.Settings.WatchFolders.Add(rule);
try
{
- var vm = new MainWindowViewModel(AppHost.Services, AppHost.Get<Filee.Core.Localization.ILocalizer>(), AppHost.Get<UpdateService>());
+ using var vm = new MainWindowViewModel(AppHost.Services, AppHost.Get<Filee.Core.Localization.ILocalizer>(), AppHost.Get<UpdateService>());
vm.Navigate("watch");
var window = new MainWindow { DataContext = vm, Width = 1080, Height = 1500 };
window.Show();
@@ -331,7 +331,7 @@ public class RenderTests
store.AddHistory(entry);
try
{
- var vm = new MainWindowViewModel(AppHost.Services, AppHost.Get<Filee.Core.Localization.ILocalizer>(), AppHost.Get<UpdateService>());
+ using var vm = new MainWindowViewModel(AppHost.Services, AppHost.Get<Filee.Core.Localization.ILocalizer>(), AppHost.Get<UpdateService>());
vm.Navigate("home");
var window = new MainWindow { DataContext = vm, Width = 1080, Height = 820 };
window.Show();
@@ -379,7 +379,7 @@ public class RenderTests
store.History.AddRange(entries);
try
{
- var vm = new MainWindowViewModel(AppHost.Services, loc, AppHost.Get<UpdateService>());
+ using var vm = new MainWindowViewModel(AppHost.Services, loc, AppHost.Get<UpdateService>());
vm.Navigate("home");
var window = new MainWindow { DataContext = vm, Width = 1080, Height = 820 };
window.Show();
@@ -424,7 +424,7 @@ public class RenderTests
{
TestServices.EnsureInitialized("en");
var store = AppHost.Get<Filee.Core.Settings.UserDataStore>();
- var vm = new MainWindowViewModel(AppHost.Services, AppHost.Get<Filee.Core.Localization.ILocalizer>(), AppHost.Get<UpdateService>());
+ using var vm = new MainWindowViewModel(AppHost.Services, AppHost.Get<Filee.Core.Localization.ILocalizer>(), AppHost.Get<UpdateService>());
vm.Navigate("presets");
var page = (PresetsPageViewModel)vm.CurrentPage;
page.Search = "zzz";
@@ -451,7 +451,7 @@ public class RenderTests
var before = store.Settings.HistoryLimit;
try
{
- var vm = new MainWindowViewModel(AppHost.Services, AppHost.Get<Filee.Core.Localization.ILocalizer>(), AppHost.Get<UpdateService>());
+ using var vm = new MainWindowViewModel(AppHost.Services, AppHost.Get<Filee.Core.Localization.ILocalizer>(), AppHost.Get<UpdateService>());
vm.Navigate("general");
var window = new MainWindow { DataContext = vm, Width = 1080, Height = 820 };
window.Show();
@@ -492,7 +492,7 @@ public class RenderTests
package.ProgressDetail = "176 MB / 422 MB · 8.4 MB/s · 30초 남음";
try
{
- var vm = new MainWindowViewModel(AppHost.Services, AppHost.Get<Filee.Core.Localization.ILocalizer>(), AppHost.Get<UpdateService>());
+ using var vm = new MainWindowViewModel(AppHost.Services, AppHost.Get<Filee.Core.Localization.ILocalizer>(), AppHost.Get<UpdateService>());
vm.Navigate("engines");
var window = new MainWindow { DataContext = vm, Width = 1080, Height = 1400 };
window.Show();
@@ -1053,7 +1053,7 @@ public class RenderTests
try
{
service.Apply(dark, "en", custom);
- var vm = new MainWindowViewModel(AppHost.Services, AppHost.Get<Filee.Core.Localization.ILocalizer>(), AppHost.Get<UpdateService>());
+ using var vm = new MainWindowViewModel(AppHost.Services, AppHost.Get<Filee.Core.Localization.ILocalizer>(), AppHost.Get<UpdateService>());
vm.Navigate("theme");
var window = new MainWindow { DataContext = vm, Width = 1080, Height = 820 };
window.Show();
@@ -1469,7 +1469,7 @@ public class RenderTests
{
TestServices.EnsureInitialized(language);
var updates = AppHost.Get<UpdateService>();
- var vm = new MainWindowViewModel(AppHost.Services, AppHost.Get<Filee.Core.Localization.ILocalizer>(), updates);
+ using var vm = new MainWindowViewModel(AppHost.Services, AppHost.Get<Filee.Core.Localization.ILocalizer>(), updates);
var window = new MainWindow { DataContext = vm, Width = 1080, Height = 820 };
window.Show();
Pump();
diff --git a/tests/Filee.App.Tests/UiZoomTests.cs b/tests/Filee.App.Tests/UiZoomTests.cs
index de763ee9..3740aba0 100644
--- a/tests/Filee.App.Tests/UiZoomTests.cs
+++ b/tests/Filee.App.Tests/UiZoomTests.cs
@@ -281,10 +281,13 @@ public class UiZoomTests
}
}
- [AvaloniaFact]
- public void Theme_page_shows_the_window_size_and_resets_it()
+ [AvaloniaTheory]
+ [InlineData("en")]
+ [InlineData("pt-PT")]
+ [InlineData("pt-BR")]
+ public void Theme_page_shows_the_window_size_and_resets_it(string language)
{
- TestServices.EnsureInitialized("en");
+ TestServices.EnsureInitialized(language);
var directory = Directory.CreateTempSubdirectory("filee-zoom-theme-").FullName;
var store = new UserDataStore(directory);
store.Load();
@@ -314,7 +317,7 @@ public class UiZoomTests
RenderTests.Pump();
Assert.Equal("180%", text.Text);
Assert.False(zoomIn.IsEffectivelyEnabled);
- RenderTests.Save(window, "page-theme-window-size-en.png");
+ RenderTests.Save(window, $"page-theme-window-size-{language}.png");
reset.Command!.Execute(null);
RenderTests.Pump();