Skip to content

armgit / Filee

Public Imported from GitHub
0

Free, open-source file converter. Convert 263 formats offline by drag & drop — images, PDF, Word, Excel, PowerPoint, HWP/HWPX, video, audio, e-books and archives. No upload, no Office needed.

Edit pictures: plain number boxes, as the crop window's W × H

KnifeLemonf188245b940a
diff --git a/src/Filee.App/Views/ImageEditWindow.axaml b/src/Filee.App/Views/ImageEditWindow.axaml
index 49cb147c..2dff47d1 100644
--- a/src/Filee.App/Views/ImageEditWindow.axaml
+++ b/src/Filee.App/Views/ImageEditWindow.axaml
@@ -37,15 +37,15 @@
</StackPanel>
<StackPanel Grid.Column="2" IsVisible="{Binding ShowPercent}">
<TextBlock Classes="label" Text="{DynamicResource presets.percent}" />
- <NumericUpDown Value="{Binding ResizePercent}" Minimum="1" Maximum="1000" Increment="5" FormatString="0" AutomationProperties.Name="{DynamicResource presets.percent}" />
+ <NumericUpDown Value="{Binding ResizePercent}" Minimum="1" Maximum="1000" Increment="5" FormatString="0" ShowButtonSpinner="False" AutomationProperties.Name="{DynamicResource presets.percent}" />
</StackPanel>
<StackPanel Grid.Column="2" IsVisible="{Binding ShowLongEdge}">
<TextBlock Classes="label" Text="{DynamicResource presets.long_edge}" />
- <NumericUpDown Value="{Binding LongEdge}" Minimum="16" Maximum="20000" Increment="100" FormatString="0" AutomationProperties.Name="{DynamicResource presets.long_edge}" />
+ <NumericUpDown Value="{Binding LongEdge}" Minimum="16" Maximum="20000" Increment="100" FormatString="0" ShowButtonSpinner="False" AutomationProperties.Name="{DynamicResource presets.long_edge}" />
</StackPanel>
<StackPanel Grid.Column="2" IsVisible="{Binding ShowWidth}">
<TextBlock Classes="label" Text="{DynamicResource presets.width}" />
- <NumericUpDown Value="{Binding Width}" Minimum="16" Maximum="20000" Increment="100" FormatString="0" AutomationProperties.Name="{DynamicResource presets.width}" />
+ <NumericUpDown Value="{Binding Width}" Minimum="16" Maximum="20000" Increment="100" FormatString="0" ShowButtonSpinner="False" AutomationProperties.Name="{DynamicResource presets.width}" />
</StackPanel>
</Grid>
<!-- The first picture's size before and after. Each size stays "width × height" in Arabic too; the arrow and their
diff --git a/tests/Filee.App.Tests/ImageEditWindowTests.cs b/tests/Filee.App.Tests/ImageEditWindowTests.cs
index fe6456c0..073b6943 100644
--- a/tests/Filee.App.Tests/ImageEditWindowTests.cs
+++ b/tests/Filee.App.Tests/ImageEditWindowTests.cs
@@ -40,6 +40,8 @@ public class ImageEditWindowTests
vm.Rotation = vm.Rotations.Single(r => r.Value == ImageRotation.Right90);
Pump();
Assert.True(vm.ShowQuality); // the JPG keeps its format
+ // Plain number boxes as the crop window's W × H: typed, or stepped with the arrow keys.
+ Assert.All(window.GetVisualDescendants().OfType<NumericUpDown>(), box => Assert.False(box.ShowButtonSpinner));
Save(window, $"window-image-edit-{language}-{(dark ? "dark" : "light")}.png");
}, language: language, dark: dark);
}