Skip to content

FinceptTerminal is a modern finance application offering advanced market analytics, investment research, and economic data tools, designed for interactive exploration and data-driven decision-making in a user-friendly environment.

fix(finagent): migrate setup_agentic_memory callers to pass agent_id

tilakpatel222554c95d7710
diff --git a/fincept-qt/scripts/agents/finagent_core/core_agent.py b/fincept-qt/scripts/agents/finagent_core/core_agent.py
index d3f88467f..629425972 100644
--- a/fincept-qt/scripts/agents/finagent_core/core_agent.py
+++ b/fincept-qt/scripts/agents/finagent_core/core_agent.py
@@ -369,18 +369,21 @@ class CoreAgent:
def setup_agentic_memory(self, config: Dict[str, Any] = None) -> "CoreAgent":
"""Deprecated: per-persona agentic memory now lives inside PersonaRuntime.
- This shim remains for backward-compat with any direct caller that
- pre-configures a top-level module, but requires agent_id in config.
- Prefer passing memory config through CoreAgent.run() instead.
+ Shim kept for backward-compat with direct callers of store_memory /
+ recall_memories. When agent_id is missing from the config we default
+ to "default" and log a warning; prefer CoreAgent.run(..., agent_id=...)
+ which routes through PersonaRegistry for proper isolation.
"""
+ import logging
from finagent_core.modules import AgenticMemoryModule
cfg = dict(config or {})
cfg.setdefault("user_id", self.user_id or "default")
if "agent_id" not in cfg:
- raise ValueError(
- "CoreAgent.setup_agentic_memory: 'agent_id' is required in config. "
- "Prefer CoreAgent.run(..., agent_id=...) which routes through PersonaRegistry."
+ logging.getLogger(__name__).warning(
+ "CoreAgent.setup_agentic_memory called without agent_id; "
+ "defaulting to 'default'. Prefer CoreAgent.run(..., agent_id=...)."
)
+ cfg["agent_id"] = "default"
self._agentic_memory = AgenticMemoryModule.from_config(cfg)
self._modules["agentic_memory"] = self._agentic_memory
return self
diff --git a/fincept-qt/scripts/agents/finagent_core/main.py b/fincept-qt/scripts/agents/finagent_core/main.py
index 48e4cc3cc..1799e0171 100644
--- a/fincept-qt/scripts/agents/finagent_core/main.py
+++ b/fincept-qt/scripts/agents/finagent_core/main.py
@@ -112,6 +112,7 @@ def _setup_agent_modules(agent, config: Dict[str, Any], params: Dict[str, Any]):
agentic_memory_cfg = config.get("agentic_memory") or params.get("agentic_memory")
if agentic_memory_cfg:
cfg = agentic_memory_cfg if isinstance(agentic_memory_cfg, dict) else {"user_id": params.get("user_id", "default")}
+ cfg.setdefault("agent_id", config.get("id") or config.get("agent_id") or "unnamed")
agent.setup_agentic_memory(cfg)
# Compression
@@ -722,7 +723,9 @@ def dispatch_action(
if action == "store_memory":
from finagent_core.core_agent import CoreAgent
agent = CoreAgent(api_keys=api_keys, user_id=params.get("user_id"))
- agent.setup_agentic_memory(params.get("agentic_memory") or config.get("agentic_memory") or {"user_id": params.get("user_id", "default")})
+ am_cfg = dict(params.get("agentic_memory") or config.get("agentic_memory") or {"user_id": params.get("user_id", "default")})
+ am_cfg.setdefault("agent_id", params.get("agent_id") or config.get("id") or config.get("agent_id") or "unnamed")
+ agent.setup_agentic_memory(am_cfg)
content = params.get("content")
if not content:
return {"success": False, "error": "Missing 'content' in params"}
@@ -732,7 +735,9 @@ def dispatch_action(
if action == "recall_memories":
from finagent_core.core_agent import CoreAgent
agent = CoreAgent(api_keys=api_keys, user_id=params.get("user_id"))
- agent.setup_agentic_memory(params.get("agentic_memory") or config.get("agentic_memory") or {"user_id": params.get("user_id", "default")})
+ am_cfg = dict(params.get("agentic_memory") or config.get("agentic_memory") or {"user_id": params.get("user_id", "default")})
+ am_cfg.setdefault("agent_id", params.get("agent_id") or config.get("id") or config.get("agent_id") or "unnamed")
+ agent.setup_agentic_memory(am_cfg)
memories = agent.recall_memories(params.get("query"), params.get("type"), params.get("limit", 5))
return {"success": True, "memories": memories, "count": len(memories)}