Skip to content

FinceptTerminal is a modern finance application offering advanced market analytics, investment research, and economic data tools, designed for interactive exploration and data-driven decision-making in a user-friendly environment.

equity: wire positions P&L% and replace dead Exchange column with Opened

Abhi Kakadiya26e4170a9f04
diff --git a/fincept-qt/src/screens/equity_trading/EquityBottomPanel.cpp b/fincept-qt/src/screens/equity_trading/EquityBottomPanel.cpp
index 1c0a6a596..d80ecb9c8 100644
--- a/fincept-qt/src/screens/equity_trading/EquityBottomPanel.cpp
+++ b/fincept-qt/src/screens/equity_trading/EquityBottomPanel.cpp
@@ -55,7 +55,7 @@ void EquityBottomPanel::setup_positions_tab() {
positions_table_->setObjectName("eqTable");
positions_table_->setColumnCount(8);
positions_table_->setHorizontalHeaderLabels(
- {"Symbol", "Exchange", "Side", "Qty", "Avg Price", "LTP", "P&L", "P&L %"});
+ {"Symbol", "Opened", "Side", "Qty", "Avg Price", "LTP", "P&L", "P&L %"});
positions_table_->verticalHeader()->setVisible(false);
positions_table_->setSelectionBehavior(QAbstractItemView::SelectRows);
positions_table_->setEditTriggers(QAbstractItemView::NoEditTriggers);
@@ -232,16 +232,34 @@ void EquityBottomPanel::set_paper_positions(const QVector<trading::PtPosition>&
for (int i = 0; i < positions.size(); ++i) {
const auto& p = positions[i];
ensure_item(positions_table_, i, 0)->setText(p.symbol);
- ensure_item(positions_table_, i, 1)->setText("--");
+
+ // Col 1 — "Opened": format ISO timestamp; fall back to raw string on parse failure
+ {
+ const QDateTime dt = QDateTime::fromString(p.opened_at, Qt::ISODate);
+ ensure_item(positions_table_, i, 1)
+ ->setText(dt.isValid() ? dt.toString("yyyy-MM-dd HH:mm") : p.opened_at);
+ }
+
ensure_item(positions_table_, i, 2)->setText(p.side);
ensure_item(positions_table_, i, 3)->setText(QString::number(p.quantity, 'f', 0));
ensure_item(positions_table_, i, 4)->setText(QString::number(p.entry_price, 'f', 2));
ensure_item(positions_table_, i, 5)->setText(QString::number(p.current_price, 'f', 2));
+ // Col 6 — P&L
auto* pnl_item = ensure_item(positions_table_, i, 6);
pnl_item->setText(QString::number(p.unrealized_pnl, 'f', 2));
pnl_item->setForeground(p.unrealized_pnl >= 0 ? QColor(fincept::ui::colors::POSITIVE())
: QColor(fincept::ui::colors::NEGATIVE()));
+
+ // Col 7 — P&L %
+ const double pct = p.entry_price > 0
+ ? (p.unrealized_pnl / (p.entry_price * p.quantity)) * 100.0
+ : 0.0;
+ auto* pct_item = ensure_item(positions_table_, i, 7);
+ pct_item->setText(QString::number(pct, 'f', 2) + "%");
+ pct_item->setForeground(
+ pct >= 0 ? QColor(fincept::ui::colors::POSITIVE())
+ : QColor(fincept::ui::colors::NEGATIVE()));
}
}