FinceptTerminal is a modern finance application offering advanced market analytics, investment research, and economic data tools, designed for interactive exploration and data-driven decision-making in a user-friendly environment.
C++ ai-agentsalgorithmic-tradingbloomberg-terminalcppfinancefinancial-marketsfintechgood-first-issueinvestmentinvestment-researchmachine-learningopensourcepythonqtquantitative-financestock-markettrading
v4.4.1
tilakpatel224d169bd4e1a5
diff --git a/.github/scripts/macos_codesign.sh b/.github/scripts/macos_codesign.shindex 865946c28..0f30f519d 100644--- a/.github/scripts/macos_codesign.sh+++ b/.github/scripts/macos_codesign.sh@@ -103,9 +103,16 @@ codesign_retry() {if [ "${attempt}" -ge "${max}" ]; thenprintf '%s\n' "${out}" >&2+ # Fold codesign's own stderr INTO the annotation, not just the log.+ # Annotations are readable from the public check-runs API; step logs+ # need repo-admin auth. Without this the annotation said only "it+ # failed" and diagnosing meant asking a human to download the log+ # archive. Newlines collapsed because an annotation is one line.+ local detail+ detail="$(printf '%s' "${out}" | tr '\n' ' ' | tr -s ' ')"# stderr, not stdout: two call sites send this command's stdout to# /dev/null, and an annotation nobody sees is worse than none.- echo "::error::codesign failed after ${max} attempts (last exit ${rc}). Target: ${target}" >&2+ echo "::error::codesign failed after ${max} attempts (last exit ${rc}). Target: ${target} -- ${detail:0:800}" >&2return "${rc}"fidiff --git a/.github/workflows/release.yml b/.github/workflows/release.ymlindex a9ea7fcfe..af7f6af5e 100644--- a/.github/workflows/release.yml+++ b/.github/workflows/release.yml@@ -1968,14 +1968,28 @@ jobs:MACHO_COUNT=$(wc -l < "${MACHO_LIST}" | tr -d ' ')echo " found ${MACHO_COUNT} Mach-O file(s) (main executable signed separately at bundle root)"- echo "Stripping existing signatures from every Mach-O..."- while IFS= read -r f; do- codesign --remove-signature "$f" 2>/dev/null || true- done < "${MACHO_LIST}"- codesign --remove-signature "${MAIN_EXE}" 2>/dev/null || true- codesign --remove-signature "${APP_BUNDLE}" 2>/dev/null || true-- echo "Signing every Mach-O with hardened runtime + timestamp..."+ # ── NO --remove-signature pass ───────────────────────────────────+ # There used to be one here, stripping every Mach-O before re-signing.+ # It is both unnecessary and actively harmful:+ #+ # * Unnecessary — `codesign --force` (in SIGN_FLAGS) already replaces+ # any existing signature. That is Apple's documented mechanism.+ # * Harmful — `--remove-signature` rewrites the Mach-O's load commands+ # and __LINKEDIT, and is well known to leave the file in a state a+ # later `codesign` refuses ("main executable failed strict+ # validation" / "__LINKEDIT segment does not cover the end of the+ # file"). Qt's dylibs arrive from aqtinstall already ad-hoc signed,+ # so every one of them went through that rewrite. It was run with+ # `2>/dev/null || true`, so the damage was silent and only showed up+ # as an unexplained failure in the signing loop below.+ #+ # This is what broke the v4.4.1 release: signing died on+ # Contents/PlugIns/platforms/libqcocoa.dylib and retried 5 times, so it+ # was neither a bad certificate (the identity assertion passed) nor a+ # timestamp-service blip. Newer Xcode on the runner image validates+ # more strictly than it did when v4.4.0 shipped, which is why the same+ # workflow signed fine on 2026-08-11 and not on 2026-08-20.+ echo "Signing every Mach-O with hardened runtime + timestamp (--force replaces existing signatures)..."while IFS= read -r f; docodesign_retry "${SIGN_FLAGS[@]}" "$f" >/dev/nulldone < "${MACHO_LIST}"