Skip to content

FinceptTerminal is a modern finance application offering advanced market analytics, investment research, and economic data tools, designed for interactive exploration and data-driven decision-making in a user-friendly environment.

General bug fixes

tilakpatel226b87b95bdf67
diff --git a/.claude/scheduled_tasks.lock b/.claude/scheduled_tasks.lock
new file mode 100644
index 000000000..3d7a63070
--- /dev/null
+++ b/.claude/scheduled_tasks.lock
@@ -0,0 +1 @@
+{"sessionId":"15d9f9f1-b394-44ab-8c51-7ed15a86faf8","pid":24032,"acquiredAt":1776712530290}
\ No newline at end of file
diff --git a/README.md b/README.md
index daca3915f..a729db6ac 100644
--- a/README.md
+++ b/README.md
@@ -239,6 +239,17 @@ We're building the future of financial analysis — together.
---
+## Support the Project
+
+We've launched a community token on pump.fun. Holding or trading this token is purely a way to show support for Fincept Terminal's development — it has no utility inside the product, no governance rights, no revenue share, and no promised returns.
+
+- pump.fun: https://pump.fun/coin/J7Xrcq6cX4GZ3mnQXvrsCYGQyijc9gSNZT4DSUijpump
+- Solana mint address: 84zrRRB7eqF3G2zhsGsD7zk922kZw3LacxhjkSHZJXwK
+
+This token exists solely to support the project. Fincept Corporation is not responsible for any profit or loss any participant incurs from buying, selling, or holding it. Trade at your own risk and only with funds you can afford to lose.
+
+---
+
## For Universities & Educators
**Bring professional-grade financial analytics to your classroom.**
diff --git a/fincept-qt/CMakeLists.txt b/fincept-qt/CMakeLists.txt
index fdc687ec6..bfc071705 100644
--- a/fincept-qt/CMakeLists.txt
+++ b/fincept-qt/CMakeLists.txt
@@ -293,7 +293,7 @@ endif()
# Silence upstream warnings so CI's -Werror doesn't fail on third-party code.
# /WX- / -Wno-error needed in addition to /W0 / -w because CI adds -Werror (/WX)
# at the directory level, which suppression flags alone don't override.
-foreach(_md4c_tgt md4c md4c-html)
+foreach(_md4c_tgt md4c md4c-html md2html)
if(TARGET ${_md4c_tgt})
if(MSVC)
target_compile_options(${_md4c_tgt} PRIVATE /W0 /WX-)
@@ -431,6 +431,7 @@ set(CORE_SOURCES
src/core/session/SessionManager.cpp
src/core/session/ScreenStateManager.cpp
src/core/keys/KeyConfigManager.cpp
+ src/core/net/NetSpeedMeter.cpp
)
# Network
@@ -590,6 +591,9 @@ set(TRADING_SOURCES
src/trading/AccountDataStream.cpp
src/trading/DataStreamManager.cpp
src/trading/ExchangeService.cpp
+ src/trading/ExchangeSession.cpp
+ src/trading/ExchangeSessionManager.cpp
+ src/trading/ExchangeDaemonPool.cpp
src/trading/brokers/BrokerHttp.cpp
# Trading WebSocket
src/trading/websocket/ZerodhaWebSocket.cpp
@@ -733,6 +737,7 @@ set(UI_SOURCES
src/ui/widgets/WorldMapWidget.cpp
src/ui/widgets/LoadingOverlay.cpp
src/ui/widgets/ConfettiOverlay.cpp
+ src/ui/widgets/SpeedSparkline.cpp
src/ui/tables/DataTable.cpp
src/ui/charts/ChartFactory.cpp
src/ui/navigation/NavigationBar.cpp
@@ -767,6 +772,7 @@ set(SCREEN_SOURCES
src/screens/settings/McpServersSection.cpp
src/screens/settings/KeybindingsSection.cpp
src/screens/settings/PythonEnvSection.cpp
+ src/screens/settings/VoiceConfigSection.cpp
src/screens/about/AboutScreen.cpp
src/screens/support/SupportScreen.cpp
src/screens/trade_viz/TradeVizScreen.cpp
@@ -997,6 +1003,7 @@ set(SCREEN_SOURCES
src/screens/polymarket/PolymarketStatusBar.cpp
src/screens/polymarket/PredictionAccountDialog.cpp
src/screens/polymarket/ExchangePresentation.cpp
+ src/screens/polymarket/PolymarketOrderBlotter.cpp
# Alpha Arena
src/screens/alpha_arena/AlphaArenaScreen.cpp
diff --git a/fincept-qt/src/ai_chat/AiChatScreen.cpp b/fincept-qt/src/ai_chat/AiChatScreen.cpp
index 8dc3e7f10..92c59f1f1 100644
--- a/fincept-qt/src/ai_chat/AiChatScreen.cpp
+++ b/fincept-qt/src/ai_chat/AiChatScreen.cpp
@@ -910,7 +910,7 @@ void AiChatScreen::on_send() {
});
} else {
QPointer<AiChatScreen> self = this;
- QtConcurrent::run([self, text, hist_copy]() {
+ (void)QtConcurrent::run([self, text, hist_copy]() {
auto resp = ai_chat::LlmService::instance().chat(text, hist_copy);
QMetaObject::invokeMethod(
qApp,
diff --git a/fincept-qt/src/ai_chat/LlmService.cpp b/fincept-qt/src/ai_chat/LlmService.cpp
index ac202e170..71306b799 100644
--- a/fincept-qt/src/ai_chat/LlmService.cpp
+++ b/fincept-qt/src/ai_chat/LlmService.cpp
@@ -1750,7 +1750,7 @@ void LlmService::fetch_models(const QString& provider, const QString& api_key, c
auto headers = get_models_headers(provider, api_key);
QPointer<LlmService> self = this;
- QtConcurrent::run([self, provider, url, headers]() {
+ (void)QtConcurrent::run([self, provider, url, headers]() {
// Blocking GET (reuse blocking_post pattern but with GET)
QNetworkAccessManager nam;
QNetworkRequest req{QUrl(url)};
@@ -1811,7 +1811,7 @@ LlmResponse LlmService::chat(const QString& user_message, const std::vector<Conv
ensure_config();
if (provider_.isEmpty())
- return LlmResponse{.error = "No LLM provider configured"};
+ return LlmResponse{.content = {}, .error = "No LLM provider configured"};
// Take config snapshot — release lock before blocking network call
QString p = provider_, k = api_key_, b = base_url_, m = model_, sp = system_prompt_;
@@ -1865,7 +1865,7 @@ void LlmService::chat_streaming(const QString& user_message, const std::vector<C
if (p.isEmpty()) {
on_chunk("", true);
- emit finished_streaming(LlmResponse{.error = "No LLM provider configured"});
+ emit finished_streaming(LlmResponse{.content = {}, .error = "No LLM provider configured"});
return;
}
@@ -1914,7 +1914,7 @@ void LlmService::chat_streaming(const QString& user_message, const std::vector<C
hub.retire_topic(stream_topic);
}
};
- QtConcurrent::run(
+ (void)QtConcurrent::run(
[self, p, k, b, m, sp, t, mx, user_message, history_copy, guarded_chunk, use_tools, saved_tools]() {
if (!self)
return;
diff --git a/fincept-qt/src/app/MainWindow.cpp b/fincept-qt/src/app/MainWindow.cpp
index f933fe3fb..562cbf7ba 100644
--- a/fincept-qt/src/app/MainWindow.cpp
+++ b/fincept-qt/src/app/MainWindow.cpp
@@ -305,6 +305,9 @@ MainWindow::MainWindow(int window_id, QWidget* parent) : QMainWindow(parent), wi
addAction(act_focus);
connect(act_focus, &QAction::triggered, this, [this]() {
if (locked_) return;
+ // Don't let the focus-mode shortcut toggle shell visibility while
+ // the user is on an auth screen — the toolbar must stay hidden.
+ if (stack_ && stack_->currentIndex() == 0) return;
focus_mode_ = !focus_mode_;
if (dock_toolbar_)
dock_toolbar_->setVisible(!focus_mode_);
@@ -442,6 +445,8 @@ MainWindow::MainWindow(int window_id, QWidget* parent) : QMainWindow(parent), wi
else
showFullScreen();
} else if (action == "focus_mode") {
+ // Auth screens must never reveal the shell via focus-mode toggle.
+ if (stack_ && stack_->currentIndex() == 0) return;
focus_mode_ = !focus_mode_;
if (dock_toolbar_)
dock_toolbar_->setVisible(!focus_mode_);
@@ -964,37 +969,48 @@ void MainWindow::on_auth_state_changed() {
}
}
+// Centralised transition into the auth stack. Any path that shows a login /
+// register / forgot / pricing / info screen must go through here so the
+// privileged shell (menus, command bar, CHAT, LOGOUT, status ticker) cannot
+// be seen by an unauthenticated user. Title is also reset by set_shell_visible
+// so the last-visited screen name does not leak.
+void MainWindow::enter_auth_stack(int auth_index) {
+ set_shell_visible(false);
+ stack_->setCurrentIndex(0);
+ auth_stack_->setCurrentIndex(auth_index);
+}
+
void MainWindow::show_login() {
- auth_stack_->setCurrentIndex(0);
+ enter_auth_stack(0);
}
void MainWindow::show_register() {
- auth_stack_->setCurrentIndex(1);
+ enter_auth_stack(1);
}
void MainWindow::show_forgot_password() {
- auth_stack_->setCurrentIndex(2);
+ enter_auth_stack(2);
}
void MainWindow::show_pricing() {
- auth_stack_->setCurrentIndex(3);
+ enter_auth_stack(3);
}
void MainWindow::show_info_contact() {
info_stack_->setCurrentIndex(0);
- auth_stack_->setCurrentIndex(4);
+ enter_auth_stack(4);
}
void MainWindow::show_info_terms() {
info_stack_->setCurrentIndex(1);
- auth_stack_->setCurrentIndex(4);
+ enter_auth_stack(4);
}
void MainWindow::show_info_privacy() {
info_stack_->setCurrentIndex(2);
- auth_stack_->setCurrentIndex(4);
+ enter_auth_stack(4);
}
void MainWindow::show_info_trademarks() {
info_stack_->setCurrentIndex(3);
- auth_stack_->setCurrentIndex(4);
+ enter_auth_stack(4);
}
void MainWindow::show_info_help() {
info_stack_->setCurrentIndex(4);
- auth_stack_->setCurrentIndex(4);
+ enter_auth_stack(4);
}
void MainWindow::show_lock_screen() {
@@ -1083,16 +1099,22 @@ void MainWindow::update_window_title() {
if (profile != "default")
title += QString(" [%1]").arg(profile);
- if (WorkspaceManager::instance().has_current_workspace()) {
- const QString ws = WorkspaceManager::instance().current_workspace_name();
- if (!ws.isEmpty())
- title += QString(" — %1").arg(ws);
- }
+ // Workspace / screen name must never appear in the title while the user
+ // is on the auth or lock stack — that would leak the last-visited screen
+ // to an unauthenticated viewer.
+ const bool shell_visible = stack_ && stack_->currentIndex() == 1;
+ if (shell_visible) {
+ if (WorkspaceManager::instance().has_current_workspace()) {
+ const QString ws = WorkspaceManager::instance().current_workspace_name();
+ if (!ws.isEmpty())
+ title += QString(" — %1").arg(ws);
+ }
- if (dock_router_) {
- const QString id = dock_router_->current_screen_id();
- if (!id.isEmpty())
- title += QString(" — %1").arg(DockScreenRouter::title_for_id(id));
+ if (dock_router_) {
+ const QString id = dock_router_->current_screen_id();
+ if (!id.isEmpty())
+ title += QString(" — %1").arg(DockScreenRouter::title_for_id(id));
+ }
}
setWindowTitle(title);
diff --git a/fincept-qt/src/app/MainWindow.h b/fincept-qt/src/app/MainWindow.h
index a03996cf4..ee67e4c20 100644
--- a/fincept-qt/src/app/MainWindow.h
+++ b/fincept-qt/src/app/MainWindow.h
@@ -94,6 +94,9 @@ class MainWindow : public QMainWindow {
void update_window_title();
/// Show or hide the toolbar/status bar shell (hidden during auth screens).
void set_shell_visible(bool visible);
+ /// Show the auth stack at the given index and hide the privileged shell.
+ /// All login/register/forgot/pricing/info transitions go through here.
+ void enter_auth_stack(int auth_index);
// Info screens stack (Contact, Terms, Privacy, Trademarks, Help)
QStackedWidget* info_stack_ = nullptr;
diff --git a/fincept-qt/src/core/config/AppPaths.h b/fincept-qt/src/core/config/AppPaths.h
index ce0badb04..5c1e8bfc4 100644
--- a/fincept-qt/src/core/config/AppPaths.h
+++ b/fincept-qt/src/core/config/AppPaths.h
@@ -6,7 +6,7 @@ namespace fincept {
/// Central registry for all application file-system paths.
///
/// All paths live under a single root directory:
-/// Windows : %LOCALAPPDATA%\com.fincept.terminal\
+/// Windows : %LOCALAPPDATA%/com.fincept.terminal/
/// macOS : ~/Library/Application Support/com.fincept.terminal/
/// Linux : ~/.local/share/com.fincept.terminal/
///
diff --git a/fincept-qt/src/core/config/ProfileManager.h b/fincept-qt/src/core/config/ProfileManager.h
index 177687bef..d61efcd2e 100644
--- a/fincept-qt/src/core/config/ProfileManager.h
+++ b/fincept-qt/src/core/config/ProfileManager.h
@@ -12,7 +12,7 @@ namespace fincept {
/// // AppPaths::data() now returns .../profiles/work/data/
///
/// Profiles are stored under:
-/// %LOCALAPPDATA%\com.fincept.terminal\profiles\<name>\
+/// %LOCALAPPDATA%/com.fincept.terminal/profiles/<name>/
///
/// A manifest at root/profiles.json tracks the list of profiles.
/// The default profile is named "default".
diff --git a/fincept-qt/src/mcp/tools/DataSourcesTools.cpp b/fincept-qt/src/mcp/tools/DataSourcesTools.cpp
index 8264dbab0..fcebd494e 100644
--- a/fincept-qt/src/mcp/tools/DataSourcesTools.cpp
+++ b/fincept-qt/src/mcp/tools/DataSourcesTools.cpp
@@ -497,7 +497,7 @@ std::vector<ToolDef> get_data_sources_tools() {
int port = 80;
// Try explicit URL fields first
- for (const QString& key : {"url", "baseUrl", "endpoint", "wsdlUrl", "serviceRoot", "jobManagerUrl"}) {
+ for (const char* key : {"url", "baseUrl", "endpoint", "wsdlUrl", "serviceRoot", "jobManagerUrl"}) {
QString val = config_obj[key].toString().trimmed();
if (!val.isEmpty()) {
QUrl u(val);
@@ -531,7 +531,7 @@ std::vector<ToolDef> get_data_sources_tools() {
// Fallback: comma-separated host lists (kafka brokers, nats servers,
// cassandra contactPoints, etcd hosts, memcached servers)
if (host.isEmpty()) {
- for (const QString& key : {"brokers", "servers", "contactPoints", "hosts", "zkQuorum"}) {
+ for (const char* key : {"brokers", "servers", "contactPoints", "hosts", "zkQuorum"}) {
QString val = config_obj[key].toString().trimmed();
if (!val.isEmpty()) {
// Take the first entry — "host:port" or just "host"
diff --git a/fincept-qt/src/python/PythonRunner.cpp b/fincept-qt/src/python/PythonRunner.cpp
index 19a3dc144..e14865140 100644
--- a/fincept-qt/src/python/PythonRunner.cpp
+++ b/fincept-qt/src/python/PythonRunner.cpp
@@ -256,7 +256,7 @@ void PythonRunner::run_code(const QString& code, Callback cb) {
file.close();
// Queue as a special request — use the temp file path directly
- queue_.enqueue({"__code__:" + temp_path, {}, std::move(cb)});
+ queue_.enqueue({"__code__:" + temp_path, {}, std::move(cb), {}});
start_next();
}
diff --git a/fincept-qt/src/python/PythonSetupManager.cpp b/fincept-qt/src/python/PythonSetupManager.cpp
index f89d7775c..238c98a83 100644
--- a/fincept-qt/src/python/PythonSetupManager.cpp
+++ b/fincept-qt/src/python/PythonSetupManager.cpp
@@ -468,7 +468,7 @@ void PythonSetupManager::run_setup() {
LOG_INFO("PythonSetup", "=== run_setup START ===");
QPointer<PythonSetupManager> self = this;
- QtConcurrent::run([self]() {
+ (void)QtConcurrent::run([self]() {
if (!self)
return;
diff --git a/fincept-qt/src/screens/about/AboutScreen.cpp b/fincept-qt/src/screens/about/AboutScreen.cpp
index 938d44e32..8c08c3eac 100644
--- a/fincept-qt/src/screens/about/AboutScreen.cpp
+++ b/fincept-qt/src/screens/about/AboutScreen.cpp
@@ -48,10 +48,6 @@ static QString PANEL() {
.arg(ui::colors::BG_SURFACE(), ui::colors::BORDER_DIM());
}
-static QString PANEL_HEADER() {
- return QString("background: %1; border-bottom: 1px solid %2;").arg(ui::colors::BG_RAISED(), ui::colors::BORDER_DIM());
-}
-
static QString LINK_BTN() {
return QString("QPushButton { background: %1; color: %2; border: 1px solid %3; "
"border-radius: 2px; padding: 8px 12px; font-size: 12px; text-align: left; "
@@ -86,13 +82,6 @@ static QLabel* makeBullet(const QString& text) {
return lbl;
}
-static QWidget* makeSeparator() {
- auto* line = new QFrame;
- line->setFrameShape(QFrame::HLine);
- line->setStyleSheet(QString("color: %1;").arg(ui::colors::BORDER_DIM()));
- return line;
-}
-
// ── Constructor ───────────────────────────────────────────────────────────────
AboutScreen::AboutScreen(QWidget* parent) : QWidget(parent) {
diff --git a/fincept-qt/src/screens/ai_quant_lab/QuantModulePanel.cpp b/fincept-qt/src/screens/ai_quant_lab/QuantModulePanel.cpp
index 3f4f5d9e2..a5d7a4480 100644
--- a/fincept-qt/src/screens/ai_quant_lab/QuantModulePanel.cpp
+++ b/fincept-qt/src/screens/ai_quant_lab/QuantModulePanel.cpp
@@ -1559,31 +1559,30 @@ static QString format_val(const QJsonValue& val) {
// ── Backtest Result Display ───────────────────────────────────────────────────
-void QuantModulePanel::display_backtest_result(const QJsonObject& data) {
+void QuantModulePanel::display_backtest_result(const QJsonObject& payload) {
clear_results();
- if (!data["success"].toBool()) {
- display_error(data["error"].toString("Unknown error"));
+ if (!payload["success"].toBool()) {
+ display_error(payload["error"].toString("Unknown error"));
return;
}
- const QJsonObject metrics = data["metrics"].toObject();
- const QJsonArray curve = data["equity_curve"].toArray();
- const QJsonObject costs = data["execution_cost_estimate"].toObject();
+ const QJsonObject metrics = payload["metrics"].toObject();
+ const QJsonArray curve = payload["equity_curve"].toArray();
+ const QJsonObject costs = payload["execution_cost_estimate"].toObject();
const QStringList tickers = [&]() {
QStringList t;
- for (const auto& v : data["tickers"].toArray())
+ for (const auto& v : payload["tickers"].toArray())
t << v.toString();
return t;
}();
- const QString strategy = data["strategy"].toString();
- const QString start_date = data["start_date"].toString();
- const QString end_date = data["end_date"].toString();
+ const QString strategy = payload["strategy"].toString();
+ const QString start_date = payload["start_date"].toString();
+ const QString end_date = payload["end_date"].toString();
const QColor accent = module_.color;
const QString accent_hex = accent.name();
- const QColor accent_dim = accent.darker(160);
const QString green_hex = ui::colors::POSITIVE();
const QString red_hex = ui::colors::NEGATIVE();
const QString text_p = ui::colors::TEXT_PRIMARY();
@@ -1595,7 +1594,6 @@ void QuantModulePanel::display_backtest_result(const QJsonObject& data) {
const QString border_med = ui::colors::BORDER_MED();
const QString font_data = ui::fonts::DATA_FAMILY;
const int fs_sm = ui::fonts::SMALL;
- const int fs_md = ui::fonts::DATA;
const int fs_lg = ui::fonts::HEADER;
// ── 1. Header bar ──────────────────────────────────────────────────────
@@ -1865,7 +1863,7 @@ void QuantModulePanel::display_backtest_result(const QJsonObject& data) {
"QPushButton:hover { background:rgba(255,255,255,0.05); }")
.arg(accent_hex, border_dim).arg(fs_sm).arg(font_data));
- QString json_str = QJsonDocument(data).toJson(QJsonDocument::Indented);
+ QString json_str = QJsonDocument(payload).toJson(QJsonDocument::Indented);
connect(export_btn, &QPushButton::clicked, this, [this, json_str]() {
QString safe = module_.label;
safe.replace(QRegularExpression("[^a-zA-Z0-9_\\-]"), "_");
@@ -1894,7 +1892,7 @@ void QuantModulePanel::display_backtest_result(const QJsonObject& data) {
.arg(sharpe, 0, 'f', 3));
}
-void QuantModulePanel::display_result(const QJsonObject& data) {
+void QuantModulePanel::display_result(const QJsonObject& payload) {
clear_results();
auto* header = new QLabel("RESULTS");
@@ -1905,7 +1903,7 @@ void QuantModulePanel::display_result(const QJsonObject& data) {
// Key-value table for scalar fields
QStringList keys;
- for (auto it = data.begin(); it != data.end(); ++it)
+ for (auto it = payload.begin(); it != payload.end(); ++it)
if (!it.value().isObject() && !it.value().isArray())
keys.append(it.key());
@@ -1923,7 +1921,7 @@ void QuantModulePanel::display_result(const QJsonObject& data) {
auto label = keys[r];
label.replace('_', ' ');
table->setItem(r, 0, new QTableWidgetItem(label.toUpper()));
- auto* vi = new QTableWidgetItem(format_val(data[keys[r]]));
+ auto* vi = new QTableWidgetItem(format_val(payload[keys[r]]));
vi->setTextAlignment(Qt::AlignRight | Qt::AlignVCenter);
table->setItem(r, 1, vi);
}
@@ -1935,7 +1933,7 @@ void QuantModulePanel::display_result(const QJsonObject& data) {
auto* raw = new QTextEdit;
raw->setReadOnly(true);
raw->setMaximumHeight(200);
- raw->setPlainText(QJsonDocument(data).toJson(QJsonDocument::Indented));
+ raw->setPlainText(QJsonDocument(payload).toJson(QJsonDocument::Indented));
raw->setStyleSheet(output_ss());
results_layout_->addWidget(raw);
@@ -1949,7 +1947,7 @@ void QuantModulePanel::display_result(const QJsonObject& data) {
.arg(module_.color.name(), ui::colors::BORDER_DIM())
.arg(ui::fonts::SMALL)
.arg(ui::fonts::DATA_FAMILY));
- QString json_str = QJsonDocument(data).toJson(QJsonDocument::Indented);
+ QString json_str = QJsonDocument(payload).toJson(QJsonDocument::Indented);
connect(export_btn, &QPushButton::clicked, this, [this, json_str]() {
QString safe_name = module_.label;
safe_name.replace(QRegularExpression("[^a-zA-Z0-9_\\-]"), "_");
@@ -1973,7 +1971,7 @@ void QuantModulePanel::display_result(const QJsonObject& data) {
// ── Signal handlers ──────────────────────────────────────────────────────────
-void QuantModulePanel::on_result(const QString& module_id, const QString& command, const QJsonObject& data) {
+void QuantModulePanel::on_result(const QString& module_id, const QString& command, const QJsonObject& payload) {
if (module_id != module_.id)
return;
@@ -1987,24 +1985,24 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
// ── LangGraph deep analysis result ───────────────────────────────────────
if (command == "execute_task") {
- if (!data["success"].toBool()) {
- display_error(data["error"].toString("Unknown error"));
+ if (!payload["success"].toBool()) {
+ display_error(payload["error"].toString("Unknown error"));
return;
}
- auto text = data["result"].toString();
+ auto text = payload["result"].toString();
if (text.isEmpty())
- text = QJsonDocument(data).toJson(QJsonDocument::Indented);
+ text = QJsonDocument(payload).toJson(QJsonDocument::Indented);
if (agent_output_)
agent_output_->setPlainText(text);
- auto tid = data["thread_id"].toString();
+ auto tid = payload["thread_id"].toString();
status_label_->setText(tid.isEmpty() ? "Done" : QString("Done — thread: %1").arg(tid));
return;
}
// ── RD-Agent: check_status ────────────────────────────────────────────────
if (command == "check_status") {
- auto ver = data["rdagent_version"].toString("?");
- auto avail = data["availability"].toObject();
+ auto ver = payload["rdagent_version"].toString("?");
+ auto avail = payload["availability"].toObject();
QStringList flags;
for (auto it = avail.begin(); it != avail.end(); ++it)
if (it.value().toBool())
@@ -2016,12 +2014,12 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
// ── RD-Agent: task started (factor_mining / model_optimization / quant_research) ──
if (command == "start_factor_mining" || command == "start_model_optimization" ||
command == "start_quant_research") {
- if (!data["success"].toBool()) {
- display_error(data["error"].toString("Unknown error"));
+ if (!payload["success"].toBool()) {
+ display_error(payload["error"].toString("Unknown error"));
return;
}
- auto task_id = data["task_id"].toString();
- auto est = data["estimated_time"].toString();
+ auto task_id = payload["task_id"].toString();
+ auto est = payload["estimated_time"].toString();
status_label_->setText(QString("Task %1 started").arg(task_id));
if (rd_agent_output_)
rd_agent_output_->setPlainText(
@@ -2032,7 +2030,7 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
// ── RD-Agent: list_tasks ──────────────────────────────────────────────────
if (command == "list_tasks" && rd_task_table_) {
- auto tasks = data["tasks"].toArray();
+ auto tasks = payload["tasks"].toArray();
rd_task_table_->setRowCount(0);
for (const auto& t : tasks) {
auto obj = t.toObject();
@@ -2062,36 +2060,36 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
// ── RD-Agent: get_task_status ─────────────────────────────────────────────
if (command == "get_task_status") {
- if (!data["success"].toBool()) {
- display_error(data["error"].toString());
+ if (!payload["success"].toBool()) {
+ display_error(payload["error"].toString());
return;
}
- auto task_id = data["task_id"].toString();
- auto progress = data["progress"].toDouble() * 100;
- auto step = data["current_step"].toString();
- auto ic = data["best_ic"];
+ auto task_id = payload["task_id"].toString();
+ auto progress = payload["progress"].toDouble() * 100;
+ auto step = payload["current_step"].toString();
+ auto ic = payload["best_ic"];
status_label_->setText(QString("Task %1 — %2% — %3").arg(task_id).arg(progress, 0, 'f', 0).arg(step));
if (rd_agent_output_) {
rd_agent_output_->setPlainText(
QString(
"Task ID: %1\nStatus: %2\nProgress: %3%\nStep: %4\nBest IC: %5\nElapsed: %6")
- .arg(task_id, data["status"].toString())
+ .arg(task_id, payload["status"].toString())
.arg(progress, 0, 'f', 0)
.arg(step)
.arg(ic.isNull() ? "N/A" : QString::number(ic.toDouble(), 'f', 4))
- .arg(data["elapsed_time"].toString("-")));
+ .arg(payload["elapsed_time"].toString("-")));
}
return;
}
// ── RD-Agent: get_discovered_factors ──────────────────────────────────────
if (command == "get_discovered_factors" && rd_agent_output_) {
- if (!data["success"].toBool()) {
- display_error(data["error"].toString());
+ if (!payload["success"].toBool()) {
+ display_error(payload["error"].toString());
return;
}
- auto factors = data["factors"].toArray();
- auto best_ic = data["best_ic"];
+ auto factors = payload["factors"].toArray();
+ auto best_ic = payload["best_ic"];
QString out = QString("Discovered Factors: %1 | Best IC: %2\n\n")
.arg(factors.size())
.arg(best_ic.isNull() ? "N/A" : QString::number(best_ic.toDouble(), 'f', 4));
@@ -2112,11 +2110,11 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
// ── RD-Agent: get_optimized_model ─────────────────────────────────────────
if (command == "get_optimized_model" && rd_agent_output_) {
- if (!data["success"].toBool()) {
- display_error(data["error"].toString());
+ if (!payload["success"].toBool()) {
+ display_error(payload["error"].toString());
return;
}
- auto models = data["models"].toArray();
+ auto models = payload["models"].toArray();
QString out = QString("Optimized Models: %1\n\n").arg(models.size());
int idx = 1;
for (const auto& m : models) {
@@ -2133,15 +2131,15 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
// ── RD-Agent: stop_task / resume_task ────────────────────────────────────
if (command == "stop_task" || command == "resume_task") {
- status_label_->setText(data["message"].toString(command));
+ status_label_->setText(payload["message"].toString(command));
if (rd_agent_output_)
- rd_agent_output_->setPlainText(data["message"].toString());
+ rd_agent_output_->setPlainText(payload["message"].toString());
return;
}
// ── RD-Agent: start_ui ───────────────────────────────────────────────────
if (command == "start_ui") {
- auto url = data["url"].toString();
+ auto url = payload["url"].toString();
if (!url.isEmpty()) {
status_label_->setText(QString("Log viewer: %1").arg(url));
QDesktopServices::openUrl(QUrl(url));
@@ -2151,18 +2149,18 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
// ── RD-Agent: start_mcp_server ────────────────────────────────────────────
if (command == "start_mcp_server") {
- if (!data["success"].toBool()) {
+ if (!payload["success"].toBool()) {
status_label_->setText("MCP server failed");
if (rd_agent_output_)
rd_agent_output_->setPlainText(
QString("MCP server failed to start:\n%1\n\nInstall: %2")
- .arg(data["error"].toString())
- .arg(data["install"].toString("pip install 'mcp[cli]' 'pydantic-ai[mcp]' yfinance")));
+ .arg(payload["error"].toString())
+ .arg(payload["install"].toString("pip install 'mcp[cli]' 'pydantic-ai[mcp]' yfinance")));
return;
}
- auto url = data["url"].toString();
- auto port = data["port"].toInt();
- auto tools = data["tools"].toArray();
+ auto url = payload["url"].toString();
+ auto port = payload["port"].toInt();
+ auto tools = payload["tools"].toArray();
QStringList tool_names;
for (const auto& t : tools)
tool_names << t.toString();
@@ -2177,9 +2175,9 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
// ── RD-Agent: mcp_status ─────────────────────────────────────────────────
if (command == "mcp_status") {
- auto avail = data["mcp_server_available"].toBool();
- auto pai_mcp = data["pydantic_ai_mcp"].toBool();
- auto ports = data["running_ports"].toArray();
+ auto avail = payload["mcp_server_available"].toBool();
+ auto pai_mcp = payload["pydantic_ai_mcp"].toBool();
+ auto ports = payload["running_ports"].toArray();
QString info = QString("MCP server available: %1\npydantic-ai MCP: %2\nRunning ports: %3")
.arg(avail ? "yes" : "no")
.arg(pai_mcp ? "yes" : "no")
@@ -2197,27 +2195,27 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
// ── Backtesting ───────────────────────────────────────────────────────────
if (module_id == "backtesting") {
- if (!data["success"].toBool()) {
- display_error(data["error"].toString("Unknown error"));
+ if (!payload["success"].toBool()) {
+ display_error(payload["error"].toString("Unknown error"));
return;
}
if (command == "run_backtest") {
- display_backtest_result(data);
+ display_backtest_result(payload);
return;
}
- display_result(data);
+ display_result(payload);
return;
}
// ── Factor Discovery ─────────────────────────────────────────────────────
if (module_id == "factor_discovery") {
- if (!data["success"].toBool()) {
- display_error(data["error"].toString());
+ if (!payload["success"].toBool()) {
+ display_error(payload["error"].toString());
return;
}
clear_results();
if (command == "get_factor_library") {
- auto factors = data["factors"].toArray();
+ auto factors = payload["factors"].toArray();
QString out = QString("Factor Library — %1 factors\n\n").arg(factors.size());
for (const auto& f : factors) {
auto obj = f.toObject();
@@ -2232,9 +2230,9 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
return;
}
if (command == "get_data") {
- auto total = data["total_records"].toInt();
- auto range = data["date_range"].toObject();
- auto warning = data["warning"].toString();
+ auto total = payload["total_records"].toInt();
+ auto range = payload["date_range"].toObject();
+ auto warning = payload["warning"].toString();
QString summary = QString("Data fetched — %1 records | %2 → %3")
.arg(total)
.arg(range["start"].toString())
@@ -2249,7 +2247,7 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
return;
}
if (command == "get_instruments") {
- auto instruments = data["instruments"].toArray();
+ auto instruments = payload["instruments"].toArray();
QStringList names;
for (const auto& i : instruments)
names << i.toString();
@@ -2260,19 +2258,19 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
status_label_->setText(QString("%1 instruments").arg(names.size()));
return;
}
- display_result(data);
+ display_result(payload);
return;
}
// ── Model Library ────────────────────────────────────────────────────────
if (module_id == "model_library") {
- if (!data["success"].toBool()) {
- display_error(data["error"].toString());
+ if (!payload["success"].toBool()) {
+ display_error(payload["error"].toString());
return;
}
clear_results();
if (command == "list_models") {
- auto models = data["models"].toArray();
+ auto models = payload["models"].toArray();
QString out = QString("Available Models (%1)\n\n").arg(models.size());
for (const auto& m : models) {
auto obj = m.toObject();
@@ -2289,8 +2287,8 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
return;
}
if (command == "check_status") {
- auto qlib_ok = data["qlib_available"].toBool();
- auto models_avail = data["models_available"].toObject();
+ auto qlib_ok = payload["qlib_available"].toBool();
+ auto models_avail = payload["models_available"].toObject();
QStringList available, unavailable;
for (auto it = models_avail.begin(); it != models_avail.end(); ++it)
(it.value().toBool() ? available : unavailable) << it.key();
@@ -2306,8 +2304,8 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
return;
}
if (command == "train_model") {
- auto model_id = data["model_id"].toString();
- auto metrics = data["metrics"].toObject();
+ auto model_id = payload["model_id"].toString();
+ auto metrics = payload["metrics"].toObject();
QString out = QString("Model Trained: %1\n").arg(model_id);
for (auto it = metrics.begin(); it != metrics.end(); ++it)
out += QString(" %1: %2\n").arg(it.key()).arg(it.value().toDouble(), 0, 'f', 4);
@@ -2318,22 +2316,22 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
status_label_->setText(QString("Trained: %1").arg(model_id));
return;
}
- display_result(data);
+ display_result(payload);
return;
}
// ── Live Signals ─────────────────────────────────────────────────────────
if (module_id == "live_signals") {
- if (!data["success"].toBool()) {
- display_error(data["error"].toString());
+ if (!payload["success"].toBool()) {
+ display_error(payload["error"].toString());
return;
}
clear_results();
if (command == "get_data") {
- auto total = data["total_records"].toInt();
- auto range = data["date_range"].toObject();
- auto warning = data["warning"].toString();
- auto instr = data["instruments"].toArray();
+ auto total = payload["total_records"].toInt();
+ auto range = payload["date_range"].toObject();
+ auto warning = payload["warning"].toString();
+ auto instr = payload["instruments"].toArray();
QStringList names;
for (const auto& i : instr)
names << i.toString();
@@ -2352,7 +2350,7 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
return;
}
if (command == "get_factor_analysis") {
- auto factors = data["factors"].toArray();
+ auto factors = payload["factors"].toArray();
QString out = QString("Factor Analysis — %1 factors\n\n").arg(factors.size());
for (const auto& f : factors) {
auto obj = f.toObject();
@@ -2369,7 +2367,7 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
return;
}
if (command == "get_feature_importance") {
- auto features = data["feature_importance"].toObject();
+ auto features = payload["feature_importance"].toObject();
QString out = "Feature Importance\n\n";
QVector<QPair<QString, double>> sorted;
for (auto it = features.begin(); it != features.end(); ++it)
@@ -2384,20 +2382,20 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
status_label_->setText("Feature importance loaded");
return;
}
- display_result(data);
+ display_result(payload);
return;
}
// ── Online Learning ──────────────────────────────────────────────────────
if (module_id == "online_learning") {
- if (!data["success"].toBool()) {
- display_error(data["error"].toString());
+ if (!payload["success"].toBool()) {
+ display_error(payload["error"].toString());
return;
}
clear_results();
if (command == "list_models") {
- auto models = data["models"].toArray();
- auto river = data["river_available"].toBool();
+ auto models = payload["models"].toArray();
+ auto river = payload["river_available"].toBool();
QString out = QString("Online Models (%1) | River: %2\n\n")
.arg(models.size())
.arg(river ? "available" : "not installed");
@@ -2417,17 +2415,17 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
}
if (command == "create_model") {
auto* lbl = new QLabel(
- QString("Created: %1 [%2]").arg(data["model_id"].toString(), data["model_type"].toString()), this);
+ QString("Created: %1 [%2]").arg(payload["model_id"].toString(), payload["model_type"].toString()), this);
lbl->setStyleSheet(QString("color:%1;").arg(ui::colors::TEXT_PRIMARY()));
results_layout_->addWidget(lbl);
status_label_->setText("Model created");
return;
}
if (command == "train") {
- auto mae = data["current_mae"].toDouble();
- auto samples = data["samples_trained"].toInt();
- auto drift = data["drift_detected"].toBool();
- auto pred = data["prediction"];
+ auto mae = payload["current_mae"].toDouble();
+ auto samples = payload["samples_trained"].toInt();
+ auto drift = payload["drift_detected"].toBool();
+ auto pred = payload["prediction"];
QString out = QString("Trained — Samples: %1 | MAE: %2\nDrift: %3")
.arg(samples)
.arg(mae, 0, 'f', 6)
@@ -2435,8 +2433,8 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
if (!pred.isNull())
out += QString("\nPrediction: %1 → Actual: %2 | Error: %3")
.arg(pred.toDouble(), 0, 'f', 6)
- .arg(data["actual"].toDouble(), 0, 'f', 6)
- .arg(data["error"].toDouble(), 0, 'f', 6);
+ .arg(payload["actual"].toDouble(), 0, 'f', 6)
+ .arg(payload["error"].toDouble(), 0, 'f', 6);
auto* lbl = new QLabel(out, this);
lbl->setWordWrap(true);
lbl->setStyleSheet(QString("color:%1;").arg(drift ? ui::colors::NEGATIVE() : ui::colors::TEXT_PRIMARY()));
@@ -2445,7 +2443,7 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
return;
}
if (command == "predict") {
- auto pred = data["prediction"];
+ auto pred = payload["prediction"];
auto* lbl = new QLabel(
QString("Prediction: %1").arg(pred.isNull() ? "N/A" : QString::number(pred.toDouble(), 'f', 6)), this);
lbl->setStyleSheet(QString("color:%1; font-weight:700;").arg(module_.color.name()));
@@ -2454,15 +2452,15 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
return;
}
if (command == "performance") {
- auto mae = data["current_mae"].toDouble();
- auto samples = data["samples_trained"].toInt();
- auto drift = data["drift_detected"].toBool();
+ auto mae = payload["current_mae"].toDouble();
+ auto samples = payload["samples_trained"].toInt();
+ auto drift = payload["drift_detected"].toBool();
auto* lbl = new QLabel(QString("Model: %1 [%2]\nSamples: %3 | MAE: %4\nDrift: %5\nLast updated: %6")
- .arg(data["model_id"].toString(), data["model_type"].toString())
+ .arg(payload["model_id"].toString(), payload["model_type"].toString())
.arg(samples)
.arg(mae, 0, 'f', 6)
.arg(drift ? "DETECTED" : "none")
- .arg(data["last_updated"].isNull() ? "never" : data["last_updated"].toString()),
+ .arg(payload["last_updated"].isNull() ? "never" : payload["last_updated"].toString()),
this);
lbl->setWordWrap(true);
lbl->setStyleSheet(QString("color:%1;").arg(ui::colors::TEXT_PRIMARY()));
@@ -2470,19 +2468,19 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
status_label_->setText(QString("MAE: %1").arg(mae, 0, 'f', 4));
return;
}
- display_result(data);
+ display_result(payload);
return;
}
// ── Meta Learning ────────────────────────────────────────────────────────
if (module_id == "meta_learning") {
- if (!data["success"].toBool()) {
- display_error(data["error"].toString());
+ if (!payload["success"].toBool()) {
+ display_error(payload["error"].toString());
return;
}
clear_results();
if (command == "list_models") {
- auto models = data["models"].toArray();
+ auto models = payload["models"].toArray();
QString out = QString("Available Models (%1)\n\n").arg(models.size());
for (const auto& m : models) {
auto obj = m.toObject();
@@ -2498,9 +2496,9 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
return;
}
if (command == "run_selection") {
- auto best = data["best_model"].toString();
- auto trained = data["trained_count"].toInt();
- auto ranking = data["ranking"].toArray();
+ auto best = payload["best_model"].toString();
+ auto trained = payload["trained_count"].toInt();
+ auto ranking = payload["ranking"].toArray();
QString out = QString("Best Model: %1 | Trained: %2\n\nRanking:\n").arg(best).arg(trained);
int rank = 1;
for (const auto& r : ranking) {
@@ -2521,8 +2519,8 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
}
if (command == "create_ensemble") {
auto* lbl = new QLabel(QString("Ensemble: %1 [%2]\nModels: %3")
- .arg(data["ensemble_id"].toString("-"), data["method"].toString("-"))
- .arg(data["models"].toArray().size()),
+ .arg(payload["ensemble_id"].toString("-"), payload["method"].toString("-"))
+ .arg(payload["models"].toArray().size()),
this);
lbl->setWordWrap(true);
lbl->setStyleSheet(QString("color:%1;").arg(ui::colors::TEXT_PRIMARY()));
@@ -2531,8 +2529,8 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
return;
}
if (command == "tune_hyperparameters") {
- auto best_params = data["best_params"].toObject();
- auto best_score = data["best_score"].toDouble();
+ auto best_params = payload["best_params"].toObject();
+ auto best_score = payload["best_score"].toDouble();
QString out = QString("Best score: %1\nBest params:\n").arg(best_score, 0, 'f', 4);
for (auto it = best_params.begin(); it != best_params.end(); ++it)
out += QString(" %1: %2\n").arg(it.key()).arg(it.value().toVariant().toString());
@@ -2544,7 +2542,7 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
return;
}
if (command == "get_results") {
- auto results = data["results"].toObject();
+ auto results = payload["results"].toObject();
QString out = QString("All Results (%1)\n\n").arg(results.size());
for (auto it = results.begin(); it != results.end(); ++it) {
auto obj = it.value().toObject();
@@ -2561,14 +2559,14 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
status_label_->setText(QString("%1 result(s)").arg(results.size()));
return;
}
- display_result(data);
+ display_result(payload);
return;
}
// ── HFT ──────────────────────────────────────────────────────────────────
if (module_id == "hft") {
- if (!data["success"].toBool()) {
- display_error(data["error"].toString());
+ if (!payload["success"].toBool()) {
+ display_error(payload["error"].toString());
return;
}
@@ -2611,14 +2609,14 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
// ── fetch_orderbook ────────────────────────────────────────────────
if (command == "fetch_orderbook") {
- const auto bids = data["bids"].toArray();
- const auto asks = data["asks"].toArray();
- const double mid = data["mid_price"].toDouble();
- const double spread_bps = data["spread_bps"].toDouble();
- const double obi = data["obi"].toDouble();
- const QString pres = data["pressure"].toString();
- const double wmid = data["weighted_mid"].toDouble();
- const double lat = data["latency_ms"].toDouble();
+ const auto bids = payload["bids"].toArray();
+ const auto asks = payload["asks"].toArray();
+ const double mid = payload["mid_price"].toDouble();
+ const double spread_bps = payload["spread_bps"].toDouble();
+ const double obi = payload["obi"].toDouble();
+ const QString pres = payload["pressure"].toString();
+ const double wmid = payload["weighted_mid"].toDouble();
+ const double lat = payload["latency_ms"].toDouble();
// Update latency badge
if (auto* lbl = this->findChild<QLabel*>("hftLatency"))
@@ -2642,7 +2640,7 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
status_label_->setText(
QString("%1 mid: %2 spread: %3 bps OBI: %4")
- .arg(data["symbol"].toString())
+ .arg(payload["symbol"].toString())
.arg(mid, 0, 'f', 4)
.arg(spread_bps, 0, 'f', 3)
.arg(obi, 0, 'f', 4));
@@ -2651,10 +2649,10 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
// ── market_making ─────────────────────────────────────────────────
if (command == "market_making") {
- const auto mm = data["market_making"].toObject();
+ const auto mm = payload["market_making"].toObject();
// Also update book metrics if present
- if (data.contains("book_metrics")) {
- const auto bm = data["book_metrics"].toObject();
+ if (payload.contains("book_metrics")) {
+ const auto bm = payload["book_metrics"].toObject();
set_card("hft_mid_val", QString::number(bm["mid_price"].toDouble(), 'f', 4));
set_card("hft_spread_val", QString::number(bm["spread_bps"].toDouble(), 'f', 3) + " bps");
}
@@ -2679,7 +2677,7 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
// ── toxic_flow ────────────────────────────────────────────────────
if (command == "toxic_flow") {
- const auto tf = data["toxic_flow"].toObject();
+ const auto tf = payload["toxic_flow"].toObject();
const bool is_toxic = tf["is_toxic"].toBool();
const double score = tf["toxicity_score"].toDouble();
const QString cls = tf["classification"].toString();
@@ -2707,7 +2705,7 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
// ── slippage ──────────────────────────────────────────────────────
if (command == "slippage") {
- const auto sl = data; // flat: average_price, slippage_bps, fills, etc at top level
+ const auto sl = payload; // flat: average_price, slippage_bps, fills, etc at top level
const double avg_p = sl["average_price"].toDouble();
const double sl_bps = sl["slippage_bps"].toDouble();
const double cost = sl["total_cost"].toDouble();
@@ -2748,14 +2746,14 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
// ── analyze (full analysis) ───────────────────────────────────────
if (command == "analyze") {
// Dispatch sub-results to each section
- if (data.contains("bids")) {
- const auto bids = data["bids"].toArray();
- const auto asks = data["asks"].toArray();
+ if (payload.contains("bids")) {
+ const auto bids = payload["bids"].toArray();
+ const auto asks = payload["asks"].toArray();
fill_book_table("hft_bid_table", bids, true);
fill_book_table("hft_ask_table", asks, false);
}
- if (data.contains("book_metrics")) {
- const auto bm = data["book_metrics"].toObject();
+ if (payload.contains("book_metrics")) {
+ const auto bm = payload["book_metrics"].toObject();
set_card("hft_mid_val", QString::number(bm["mid_price"].toDouble(), 'f', 4));
set_card("hft_spread_val", QString::number(bm["spread_bps"].toDouble(), 'f', 3) + " bps");
const double obi = bm["obi"].toDouble();
@@ -2770,8 +2768,8 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
set_card("hft_pressure_val", pres, p_col);
set_card("hft_wmid_val", QString::number(bm["weighted_mid"].toDouble(), 'f', 4));
}
- if (data.contains("market_making")) {
- const auto mm = data["market_making"].toObject();
+ if (payload.contains("market_making")) {
+ const auto mm = payload["market_making"].toObject();
set_card("hft_mm_bid", QString::number(mm["bid_price"].toDouble(), 'f', 4),
QString(ui::colors::POSITIVE()));
set_card("hft_mm_ask", QString::number(mm["ask_price"].toDouble(), 'f', 4),
@@ -2780,8 +2778,8 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
set_card("hft_mm_edge", QString::number(mm["edge_per_side_bps"].toDouble(), 'f', 3) + " bps");
set_card("hft_mm_rec", mm["recommendation"].toString());
}
- if (data.contains("toxic_flow")) {
- const auto tf = data["toxic_flow"].toObject();
+ if (payload.contains("toxic_flow")) {
+ const auto tf = payload["toxic_flow"].toObject();
const double sc = tf["toxicity_score"].toDouble();
const QString col = sc > 60 ? QString(ui::colors::NEGATIVE())
: sc > 30 ? QString(ui::colors::WARNING())
@@ -2792,8 +2790,8 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
set_card("hft_tox_class", tf["classification"].toString());
set_card("hft_tox_action", QString(tf["action"].toString()).replace('_', ' '));
}
- if (data.contains("slippage")) {
- const auto sl = data["slippage"].toObject();
+ if (payload.contains("slippage")) {
+ const auto sl = payload["slippage"].toObject();
set_card("hft_slip_avgp", QString::number(sl["average_price"].toDouble(), 'f', 4));
set_card("hft_slip_bps", QString::number(sl["slippage_bps"].toDouble(), 'f', 4) + " bps");
set_card("hft_slip_cost", QString::number(sl["total_cost"].toDouble(), 'f', 4));
@@ -2803,73 +2801,73 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
v ? QString(ui::colors::POSITIVE()) : QString(ui::colors::NEGATIVE()));
}
if (auto* lat_lbl = this->findChild<QLabel*>("hftLatency"))
- lat_lbl->setText(QString("LATENCY %1 ms").arg(data["latency_ms"].toDouble(), 0, 'f', 1));
+ lat_lbl->setText(QString("LATENCY %1 ms").arg(payload["latency_ms"].toDouble(), 0, 'f', 1));
status_label_->setText(
QString("Full analysis complete — %1 @ %2")
- .arg(data["symbol"].toString(), data["timestamp"].toString().left(19)));
+ .arg(payload["symbol"].toString(), payload["timestamp"].toString().left(19)));
return;
}
- display_result(data);
+ display_result(payload);
return;
}
// ── Rolling Retraining ───────────────────────────────────────────────────
if (module_id == "rolling_retraining") {
// ── Streaming events from retrain command ────────────────────────────
- const QString event = data["event"].toString();
+ const QString event = payload["event"].toString();
if (!event.isEmpty()) {
auto* pb = this->findChild<QProgressBar*>("rr_progress");
auto* log = this->findChild<QTextEdit*>("rr_log");
if (event == "start") {
- const int total = data["total_windows"].toInt();
+ const int total = payload["total_windows"].toInt();
if (pb) { pb->setRange(0, total); pb->setValue(0); pb->setFormat("0 / %v windows"); }
if (log) log->append(QString("Starting retrain: %1 | %2 windows")
- .arg(data["model_id"].toString()).arg(total));
+ .arg(payload["model_id"].toString()).arg(total));
status_label_->setText(QString("Retraining %1 — 0/%2 windows")
- .arg(data["model_id"].toString()).arg(total));
+ .arg(payload["model_id"].toString()).arg(total));
} else if (event == "window") {
- const int idx = data["index"].toInt();
- const int total = data["total"].toInt();
+ const int idx = payload["index"].toInt();
+ const int total = payload["total"].toInt();
if (pb) { pb->setValue(idx); pb->setFormat(QString("%1 / %2 windows").arg(idx).arg(total)); }
if (log) log->append(QString(" Window %1/%2 train→%3 test %4→%5")
.arg(idx).arg(total)
- .arg(data["train_end"].toString().left(10))
- .arg(data["test_start"].toString().left(10))
- .arg(data["test_end"].toString().left(10)));
+ .arg(payload["train_end"].toString().left(10))
+ .arg(payload["test_start"].toString().left(10))
+ .arg(payload["test_end"].toString().left(10)));
status_label_->setText(QString("Window %1/%2").arg(idx).arg(total));
} else if (event == "ensemble") {
- if (log) log->append(QString(" %1").arg(data["message"].toString()));
+ if (log) log->append(QString(" %1").arg(payload["message"].toString()));
status_label_->setText("Combining rolling results...");
} else if (event == "done") {
- const int total = data["windows_trained"].toInt();
+ const int total = payload["windows_trained"].toInt();
if (pb) { pb->setValue(total); pb->setFormat("Complete"); }
if (log) log->append(QString("\nDone — %1 windows in %2s | Experiment: %3")
.arg(total)
- .arg(data["elapsed_sec"].toDouble(), 0, 'f', 1)
- .arg(data["exp_name"].toString()));
+ .arg(payload["elapsed_sec"].toDouble(), 0, 'f', 1)
+ .arg(payload["exp_name"].toString()));
status_label_->setText(QString("Retrain complete — %1 windows in %2s")
.arg(total)
- .arg(data["elapsed_sec"].toDouble(), 0, 'f', 1));
+ .arg(payload["elapsed_sec"].toDouble(), 0, 'f', 1));
} else if (event == "error") {
if (pb) { pb->setFormat("Failed"); }
- if (log) log->append(QString("\nError: %1").arg(data["error"].toString()));
- display_error(data["error"].toString());
+ if (log) log->append(QString("\nError: %1").arg(payload["error"].toString()));
+ display_error(payload["error"].toString());
}
return;
}
// ── Non-streaming responses ──────────────────────────────────────────
- if (!data["success"].toBool()) {
- display_error(data["error"].toString());
+ if (!payload["success"].toBool()) {
+ display_error(payload["error"].toString());
return;
}
clear_results();
if (command == "list") {
- auto schedules = data["schedules"].toObject();
+ auto schedules = payload["schedules"].toObject();
// Find the cards container and repopulate it
auto* cards_w = this->findChild<QWidget*>("rr_cards_container");
if (cards_w) {
@@ -2988,15 +2986,15 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
}
if (command == "create") {
- auto sched = data["schedule"].toObject();
- const QString tmpl = data["template_generated"].toBool()
+ auto sched = payload["schedule"].toObject();
+ const QString tmpl = payload["template_generated"].toBool()
? QString("\nBuilt-in LightGBM+Alpha158 template generated at:\n%1")
- .arg(data["conf_path"].toString())
+ .arg(payload["conf_path"].toString())
: "";
clear_results();
auto* lbl = new QLabel(
QString("Schedule created: %1\nFreq: %2 | Window: %3 days | Next: %4%5")
- .arg(data["model_id"].toString(),
+ .arg(payload["model_id"].toString(),
sched["frequency"].toString(),
QString::number(sched["window"].toInt()),
sched["next_run"].toString().left(16).replace("T", " "),
@@ -3011,12 +3009,12 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
if (command == "preview") {
clear_results();
- const int total = data["total_windows"].toInt();
- auto windows = data["windows"].toArray();
+ const int total = payload["total_windows"].toInt();
+ auto windows = payload["windows"].toArray();
auto* hdr = new QLabel(
QString("Preview: %1 rolling windows (step=%2, horizon=%3)")
- .arg(total).arg(data["step"].toInt()).arg(data["horizon"].toInt()),
+ .arg(total).arg(payload["step"].toInt()).arg(payload["horizon"].toInt()),
this);
hdr->setStyleSheet(QString("color:%1;font-weight:700;font-size:13px;")
.arg(ui::colors::TEXT_PRIMARY()));
@@ -3054,17 +3052,17 @@ void QuantModulePanel::on_result(const QString& module_id, const QString& comman
}
if (command == "delete") {
- status_label_->setText(QString("Deleted: %1").arg(data["model_id"].toString()));
+ status_label_->setText(QString("Deleted: %1").arg(payload["model_id"].toString()));
// Auto-refresh the schedule list
AIQuantLabService::instance().rolling_list_schedules();
return;
}
- display_result(data);
+ display_result(payload);
return;
}
- display_result(data);
+ display_result(payload);
}
void QuantModulePanel::on_error(const QString& module_id, const QString& message) {
diff --git a/fincept-qt/src/screens/akshare/AkShareScreen.cpp b/fincept-qt/src/screens/akshare/AkShareScreen.cpp
index 819b1ab14..fd5b52bda 100644
--- a/fincept-qt/src/screens/akshare/AkShareScreen.cpp
+++ b/fincept-qt/src/screens/akshare/AkShareScreen.cpp
@@ -713,20 +713,20 @@ void AkShareScreen::execute_query(const QString& script, const QString& endpoint
// ── Display ─────────────────────────────────────────────────────────────────
-void AkShareScreen::display_table_data(const QJsonArray& data) {
+void AkShareScreen::display_table_data(const QJsonArray& rows_json) {
data_table_->setSortingEnabled(false);
data_table_->clear();
data_table_->setRowCount(0);
data_table_->setColumnCount(0);
- if (data.isEmpty()) {
+ if (rows_json.isEmpty()) {
data_status_->setText("No data returned");
return;
}
// Extract columns from first row
QStringList columns;
- auto first = data[0].toObject();
+ auto first = rows_json[0].toObject();
for (auto it = first.begin(); it != first.end(); ++it) {
columns << it.key();
}
@@ -735,11 +735,11 @@ void AkShareScreen::display_table_data(const QJsonArray& data) {
data_table_->setHorizontalHeaderLabels(columns);
// Populate rows (cap at 5000 to avoid UI freeze)
- int max_rows = qMin(data.size(), 5000);
+ int max_rows = qMin(rows_json.size(), 5000);
data_table_->setRowCount(max_rows);
for (int row = 0; row < max_rows; ++row) {
- auto obj = data[row].toObject();
+ auto obj = rows_json[row].toObject();
for (int col = 0; col < columns.size(); ++col) {
auto val = obj.value(columns[col]);
QString text;
@@ -774,13 +774,13 @@ void AkShareScreen::display_table_data(const QJsonArray& data) {
}
data_table_->setSortingEnabled(true);
- if (data.size() > max_rows) {
- data_status_->setText(QString("Showing %1 of %2 records").arg(max_rows).arg(data.size()));
+ if (rows_json.size() > max_rows) {
+ data_status_->setText(QString("Showing %1 of %2 records").arg(max_rows).arg(rows_json.size()));
}
}
-void AkShareScreen::display_json_data(const QJsonArray& data) {
- QJsonDocument doc(data);
+void AkShareScreen::display_json_data(const QJsonArray& rows_json) {
+ QJsonDocument doc(rows_json);
json_view_->setPlainText(doc.toJson(QJsonDocument::Indented));
}
diff --git a/fincept-qt/src/screens/algo_trading/ScannerPanel.cpp b/fincept-qt/src/screens/algo_trading/ScannerPanel.cpp
index 610105a8c..27a4b9f06 100644
--- a/fincept-qt/src/screens/algo_trading/ScannerPanel.cpp
+++ b/fincept-qt/src/screens/algo_trading/ScannerPanel.cpp
@@ -89,7 +89,7 @@ using namespace fincept::services::algo;
// ── Helper: build a condition row ───────────────────────────────────────────
-static QWidget* build_condition_row(QVBoxLayout* owner_layout, QWidget* parent) {
+static QWidget* build_condition_row(QVBoxLayout* /*owner_layout*/, QWidget* parent) {
auto* row = new QWidget(parent);
row->setStyleSheet(QString("background: %1; border: 1px solid %2;")
.arg(fincept::ui::colors::BG_SURFACE(), fincept::ui::colors::BORDER_DIM()));
@@ -542,13 +542,13 @@ void ScannerPanel::on_scan() {
QString("Scan started: %1 conditions, %2 symbols").arg(conditions.size()).arg(symbols.size()));
}
-void ScannerPanel::on_scan_result(const QJsonObject& data) {
+void ScannerPanel::on_scan_result(const QJsonObject& payload) {
results_table_->setSortingEnabled(false);
results_table_->setRowCount(0);
- QJsonArray matches = data.value("matches").toArray();
- int total_scanned = data.value("total_scanned").toInt();
- int condition_count = data.value("condition_count").toInt();
+ QJsonArray matches = payload.value("matches").toArray();
+ int total_scanned = payload.value("total_scanned").toInt();
+ int condition_count = payload.value("condition_count").toInt();
status_label_->setText(
QString("Scan complete: %1 matches out of %2 symbols").arg(matches.size()).arg(total_scanned));
diff --git a/fincept-qt/src/screens/algo_trading/StrategyBuilderPanel.cpp b/fincept-qt/src/screens/algo_trading/StrategyBuilderPanel.cpp
index 9864771fb..bf5af87fa 100644
--- a/fincept-qt/src/screens/algo_trading/StrategyBuilderPanel.cpp
+++ b/fincept-qt/src/screens/algo_trading/StrategyBuilderPanel.cpp
@@ -626,17 +626,17 @@ void StrategyBuilderPanel::clear_results() {
// ── display_backtest_result — Quant Lab KPI card style ───────────────────────
-void StrategyBuilderPanel::display_backtest_result(const QJsonObject& data) {
+void StrategyBuilderPanel::display_backtest_result(const QJsonObject& payload) {
bt_empty_label_->setVisible(false);
kpi_grid_widget_->setVisible(true);
- double total_return = data.value("total_return").toDouble();
- double sharpe = data.value("sharpe_ratio").toDouble();
- double max_dd = data.value("max_drawdown").toDouble();
- int total_trades = data.value("total_trades").toInt();
- double win_rate = data.value("win_rate").toDouble();
- double profit_factor = data.value("profit_factor").toDouble();
- double final_val = data.value("final_value").toDouble();
+ double total_return = payload.value("total_return").toDouble();
+ double sharpe = payload.value("sharpe_ratio").toDouble();
+ double max_dd = payload.value("max_drawdown").toDouble();
+ int total_trades = payload.value("total_trades").toInt();
+ double win_rate = payload.value("win_rate").toDouble();
+ double profit_factor = payload.value("profit_factor").toDouble();
+ double final_val = payload.value("final_value").toDouble();
auto set_kpi = [](QLabel* lbl, const QString& text, const QString& color) {
lbl->setText(text);
@@ -684,14 +684,14 @@ void StrategyBuilderPanel::display_backtest_result(const QJsonObject& data) {
// ── on_backtest_result ───────────────────────────────────────────────────────
-void StrategyBuilderPanel::on_backtest_result(const QJsonObject& data) {
+void StrategyBuilderPanel::on_backtest_result(const QJsonObject& payload) {
status_label_->setText("Backtest complete.");
status_label_->setStyleSheet(
QString("color: %1; font-size: %2px; %3 background: transparent; border: none;")
.arg(fincept::ui::colors::POSITIVE())
.arg(fincept::ui::fonts::SMALL)
.arg(kMonoFont()));
- display_backtest_result(data);
+ display_backtest_result(payload);
LOG_INFO("AlgoTrading", "Backtest result displayed");
}
diff --git a/fincept-qt/src/screens/alt_investments/AltInvestmentsScreen.cpp b/fincept-qt/src/screens/alt_investments/AltInvestmentsScreen.cpp
index 5d51edd42..d901739b9 100644
--- a/fincept-qt/src/screens/alt_investments/AltInvestmentsScreen.cpp
+++ b/fincept-qt/src/screens/alt_investments/AltInvestmentsScreen.cpp
@@ -856,16 +856,16 @@ void AltInvestmentsScreen::on_analyze() {
// ── Form data collection ─────────────────────────────────────────────────────
QJsonObject AltInvestmentsScreen::collect_form_data() const {
- QJsonObject data;
+ QJsonObject form;
for (int i = 0; i < current_fields_.size() && i < field_widgets_.size(); ++i) {
const auto& f = current_fields_[i];
auto* w = field_widgets_[i];
if (f.type == AltField::Text) {
if (auto* le = qobject_cast<QLineEdit*>(w))
- data[f.key] = le->text();
+ form[f.key] = le->text();
} else if (f.type == AltField::Combo) {
if (auto* cb = qobject_cast<QComboBox*>(w))
- data[f.key] = cb->currentText();
+ form[f.key] = cb->currentText();
} else {
if (auto* sp = qobject_cast<QDoubleSpinBox*>(w)) {
double val = sp->value();
@@ -875,17 +875,17 @@ QJsonObject AltInvestmentsScreen::collect_form_data() const {
val *= 1e6;
else if (f.divide_100)
val /= 100.0;
- data[f.key] = val;
+ form[f.key] = val;
}
}
}
- return data;
+ return form;
}
// ── Python execution ──────────────────────────────────────────────────────────
-void AltInvestmentsScreen::run_analysis(const QString& command, const QJsonObject& data) {
- const QString data_json = QString::fromUtf8(QJsonDocument(data).toJson(QJsonDocument::Compact));
+void AltInvestmentsScreen::run_analysis(const QString& command, const QJsonObject& form) {
+ const QString data_json = QString::fromUtf8(QJsonDocument(form).toJson(QJsonDocument::Compact));
const QString cache_key = "alt_screen:" + command + ":" + data_json;
const QVariant cached = fincept::CacheManager::instance().get(cache_key);
diff --git a/fincept-qt/src/screens/asia_markets/AsiaMarketsScreen.cpp b/fincept-qt/src/screens/asia_markets/AsiaMarketsScreen.cpp
index 2ac5998ff..358c794e7 100644
--- a/fincept-qt/src/screens/asia_markets/AsiaMarketsScreen.cpp
+++ b/fincept-qt/src/screens/asia_markets/AsiaMarketsScreen.cpp
@@ -667,19 +667,19 @@ void AsiaMarketsScreen::execute_query(const QString& endpoint, const QStringList
// ── Display ─────────────────────────────────────────────────────────────────
-void AsiaMarketsScreen::display_table(const QJsonArray& data) {
- if (data.isEmpty()) {
+void AsiaMarketsScreen::display_table(const QJsonArray& rows_json) {
+ if (rows_json.isEmpty()) {
data_status_->setText("No data returned");
return;
}
// Columns from first row
QStringList columns;
- auto first = data[0].toObject();
+ auto first = rows_json[0].toObject();
for (auto it = first.begin(); it != first.end(); ++it)
columns << it.key();
- int max_rows = qMin(data.size(), 2000);
+ int max_rows = qMin(rows_json.size(), 2000);
// Block all signals + updates during population
data_table_->setSortingEnabled(false);
@@ -694,7 +694,7 @@ void AsiaMarketsScreen::display_table(const QJsonArray& data) {
const QColor col_neg(colors::NEGATIVE());
for (int row = 0; row < max_rows; ++row) {
- auto obj = data[row].toObject();
+ auto obj = rows_json[row].toObject();
for (int col = 0; col < columns.size(); ++col) {
auto val = obj.value(columns[col]);
QString text;
@@ -723,12 +723,12 @@ void AsiaMarketsScreen::display_table(const QJsonArray& data) {
data_table_->setUpdatesEnabled(true);
data_table_->setSortingEnabled(true);
- if (data.size() > max_rows)
- data_status_->setText(QString("Showing %1 of %2").arg(max_rows).arg(data.size()));
+ if (rows_json.size() > max_rows)
+ data_status_->setText(QString("Showing %1 of %2").arg(max_rows).arg(rows_json.size()));
}
-void AsiaMarketsScreen::display_json(const QJsonArray& data) {
- QJsonDocument doc(data);
+void AsiaMarketsScreen::display_json(const QJsonArray& rows_json) {
+ QJsonDocument doc(rows_json);
json_view_->setPlainText(doc.toJson(QJsonDocument::Indented));
}
diff --git a/fincept-qt/src/screens/auth/ForgotPasswordScreen.cpp b/fincept-qt/src/screens/auth/ForgotPasswordScreen.cpp
index 54e607a82..48c6acd4d 100644
--- a/fincept-qt/src/screens/auth/ForgotPasswordScreen.cpp
+++ b/fincept-qt/src/screens/auth/ForgotPasswordScreen.cpp
@@ -6,6 +6,7 @@
#include <QFrame>
#include <QHBoxLayout>
+#include <QHideEvent>
#include <QPainter>
#include <QVBoxLayout>
@@ -44,18 +45,6 @@ static QString btn_primary() {
ui::colors::BORDER_DIM());
}
-static QString btn_standard() {
- return QString("QPushButton {"
- " background: %1; color: %2;"
- " border: 1px solid %3;"
- " padding: 0 12px; font-size: 14px; font-weight: 700;"
- " font-family: 'Consolas','Courier New',monospace;"
- "}"
- "QPushButton:hover { color: %4; background: %5; }")
- .arg(ui::colors::BG_RAISED(), ui::colors::TEXT_SECONDARY(), ui::colors::BORDER_DIM(), ui::colors::TEXT_PRIMARY(),
- ui::colors::BG_HOVER());
-}
-
static QString link_style() {
return QString("QPushButton {"
" color: %1; background: transparent; border: none;"
@@ -123,6 +112,19 @@ ForgotPasswordScreen::ForgotPasswordScreen(QWidget* parent) : QWidget(parent) {
// ── Background ───────────────────────────────────────────────────────────────
+void ForgotPasswordScreen::hideEvent(QHideEvent* event) {
+ // Wipe email/OTP/new-password inputs and return to step 1 whenever the
+ // screen leaves the stack — reset state must not linger.
+ for (QLineEdit* w : {email_input_, otp_input_, new_password_, confirm_password_}) {
+ if (w) w->clear();
+ }
+ if (new_password_) new_password_->setEchoMode(QLineEdit::Password);
+ if (confirm_password_) confirm_password_->setEchoMode(QLineEdit::Password);
+ if (error_label_) error_label_->hide();
+ if (pages_) pages_->setCurrentIndex(0);
+ QWidget::hideEvent(event);
+}
+
void ForgotPasswordScreen::paintEvent(QPaintEvent* /*event*/) {
QPainter p(this);
p.fillRect(rect(), QColor(ui::colors::BG_BASE()));
diff --git a/fincept-qt/src/screens/auth/ForgotPasswordScreen.h b/fincept-qt/src/screens/auth/ForgotPasswordScreen.h
index 9e6e55a16..00cb96f85 100644
--- a/fincept-qt/src/screens/auth/ForgotPasswordScreen.h
+++ b/fincept-qt/src/screens/auth/ForgotPasswordScreen.h
@@ -18,6 +18,8 @@ class ForgotPasswordScreen : public QWidget {
protected:
void paintEvent(QPaintEvent* event) override;
+ /// Wipe email/OTP/new-password fields whenever the screen leaves the stack.
+ void hideEvent(QHideEvent* event) override;
private:
QStackedWidget* pages_ = nullptr;
diff --git a/fincept-qt/src/screens/auth/LockScreen.cpp b/fincept-qt/src/screens/auth/LockScreen.cpp
index 04f84c81b..260728774 100644
--- a/fincept-qt/src/screens/auth/LockScreen.cpp
+++ b/fincept-qt/src/screens/auth/LockScreen.cpp
@@ -19,20 +19,6 @@ static QString card_style() {
return QString("background: %1; border: 1px solid %2;").arg(ui::colors::BG_SURFACE(), ui::colors::BORDER_DIM());
}
-static QString input_style() {
- return QString("QLineEdit {"
- " background: %1; color: %2;"
- " border: 1px solid %3;"
- " padding: 6px 10px; font-size: 15px;"
- " font-family: 'Consolas','Courier New',monospace;"
- " selection-background-color: %4; selection-color: %5;"
- "}"
- "QLineEdit:focus { border: 1px solid %6; }"
- "QLineEdit::placeholder { color: %7; }")
- .arg(ui::colors::BG_SURFACE(), ui::colors::TEXT_PRIMARY(), ui::colors::BORDER_DIM(), ui::colors::AMBER(),
- ui::colors::BG_BASE(), ui::colors::BORDER_BRIGHT(), ui::colors::TEXT_DIM());
-}
-
static QString pin_input_style() {
return QString("QLineEdit {"
" background: %1; color: %2;"
@@ -93,14 +79,6 @@ static QString error_style() {
.arg(ui::colors::NEGATIVE());
}
-static QString success_style() {
- return QString("color: %1; font-size: 13px;"
- "background: rgba(22,163,74,0.08);"
- "border: 1px solid #14532d; padding: 6px 8px;"
- "font-family: 'Consolas','Courier New',monospace;")
- .arg(ui::colors::POSITIVE());
-}
-
static QFrame* make_separator() {
auto* sep = new QFrame;
sep->setFixedHeight(1);
@@ -174,6 +152,10 @@ void LockScreen::hideEvent(QHideEvent* e) {
QWidget::hideEvent(e);
if (lockout_timer_)
lockout_timer_->stop();
+ // Wipe PIN inputs so a resumed unlock attempt never starts pre-filled.
+ if (setup_pin_input_) setup_pin_input_->clear();
+ if (setup_confirm_input_) setup_confirm_input_->clear();
+ if (unlock_pin_input_) unlock_pin_input_->clear();
}
// ── PIN Setup Page ──────────────────────────────────────────────────────────
diff --git a/fincept-qt/src/screens/auth/LoginScreen.cpp b/fincept-qt/src/screens/auth/LoginScreen.cpp
index e041114c8..75a56bd35 100644
--- a/fincept-qt/src/screens/auth/LoginScreen.cpp
+++ b/fincept-qt/src/screens/auth/LoginScreen.cpp
@@ -6,6 +6,7 @@
#include <QFrame>
#include <QHBoxLayout>
+#include <QHideEvent>
#include <QPainter>
#include <QStackedWidget>
#include <QVBoxLayout>
@@ -132,6 +133,21 @@ LoginScreen::LoginScreen(QWidget* parent) : QWidget(parent) {
// ── Background Paint ─────────────────────────────────────────────────────────
+void LoginScreen::hideEvent(QHideEvent* event) {
+ // Wipe credential + MFA inputs whenever this screen leaves the stack so
+ // they can't be recovered or pre-filled after a logout/navigation.
+ if (email_input_) email_input_->clear();
+ if (password_input_) {
+ password_input_->clear();
+ password_input_->setEchoMode(QLineEdit::Password);
+ }
+ if (mfa_input_) mfa_input_->clear();
+ clear_error();
+ if (mfa_error_) mfa_error_->hide();
+ if (pages_) pages_->setCurrentIndex(0);
+ QWidget::hideEvent(event);
+}
+
void LoginScreen::paintEvent(QPaintEvent* /*event*/) {
QPainter p(this);
p.fillRect(rect(), QColor(ui::colors::BG_BASE()));
diff --git a/fincept-qt/src/screens/auth/LoginScreen.h b/fincept-qt/src/screens/auth/LoginScreen.h
index a7ece6ae4..d2da3a1f5 100644
--- a/fincept-qt/src/screens/auth/LoginScreen.h
+++ b/fincept-qt/src/screens/auth/LoginScreen.h
@@ -45,6 +45,9 @@ class LoginScreen : public QWidget {
protected:
void paintEvent(QPaintEvent* event) override;
+ /// Wipe email/password/MFA fields whenever the screen leaves the stack so
+ /// credentials do not linger across logout → login cycles.
+ void hideEvent(QHideEvent* event) override;
private slots:
void on_login();
diff --git a/fincept-qt/src/screens/auth/RegisterScreen.cpp b/fincept-qt/src/screens/auth/RegisterScreen.cpp
index 3b9f605f4..ee4c39d60 100644
--- a/fincept-qt/src/screens/auth/RegisterScreen.cpp
+++ b/fincept-qt/src/screens/auth/RegisterScreen.cpp
@@ -6,6 +6,7 @@
#include <QFrame>
#include <QHBoxLayout>
+#include <QHideEvent>
#include <QPainter>
#include <QVBoxLayout>
@@ -132,6 +133,21 @@ RegisterScreen::RegisterScreen(QWidget* parent) : QWidget(parent) {
// ── Background ───────────────────────────────────────────────────────────────
+void RegisterScreen::hideEvent(QHideEvent* event) {
+ // Wipe registration + OTP inputs and reset to the form page whenever the
+ // screen leaves the stack — entered credentials must not linger.
+ for (QLineEdit* w : {first_name_, last_name_, email_, phone_, country_code_,
+ password_, confirm_pw_, otp_input_}) {
+ if (w) w->clear();
+ }
+ if (password_) password_->setEchoMode(QLineEdit::Password);
+ if (confirm_pw_) confirm_pw_->setEchoMode(QLineEdit::Password);
+ if (error_label_) error_label_->hide();
+ if (otp_error_) otp_error_->hide();
+ if (pages_) pages_->setCurrentIndex(0);
+ QWidget::hideEvent(event);
+}
+
void RegisterScreen::paintEvent(QPaintEvent* /*event*/) {
QPainter p(this);
p.fillRect(rect(), QColor(ui::colors::BG_BASE()));
diff --git a/fincept-qt/src/screens/auth/RegisterScreen.h b/fincept-qt/src/screens/auth/RegisterScreen.h
index d5c2d8722..c6fa70223 100644
--- a/fincept-qt/src/screens/auth/RegisterScreen.h
+++ b/fincept-qt/src/screens/auth/RegisterScreen.h
@@ -18,6 +18,9 @@ class RegisterScreen : public QWidget {
protected:
void paintEvent(QPaintEvent* event) override;
+ /// Wipe registration + OTP fields whenever the screen leaves the stack so
+ /// entered credentials do not linger.
+ void hideEvent(QHideEvent* event) override;
private:
QStackedWidget* pages_ = nullptr;
diff --git a/fincept-qt/src/screens/backtesting/BacktestingScreen.cpp b/fincept-qt/src/screens/backtesting/BacktestingScreen.cpp
index 76c8e902a..a2a7c0d80 100644
--- a/fincept-qt/src/screens/backtesting/BacktestingScreen.cpp
+++ b/fincept-qt/src/screens/backtesting/BacktestingScreen.cpp
@@ -1324,7 +1324,7 @@ void BacktestingScreen::clear_results() {
raw_json_edit_->clear();
}
-void BacktestingScreen::display_result(const QJsonObject& data) {
+void BacktestingScreen::display_result(const QJsonObject& payload) {
clear_results();
auto accent = providers_[active_provider_].color.name();
@@ -1339,9 +1339,9 @@ void BacktestingScreen::display_result(const QJsonObject& data) {
summary_layout_->addWidget(header);
// Extract performance metrics (handle nested structures)
- auto perf = data.contains("performance") ? data["performance"].toObject()
- : data.contains("data") ? data["data"].toObject().value("performance").toObject()
- : data;
+ auto perf = payload.contains("performance") ? payload["performance"].toObject()
+ : payload.contains("payload") ? payload["payload"].toObject().value("performance").toObject()
+ : payload;
// Key metric cards in grid
auto* cards = new QWidget(summary_container_);
@@ -1406,8 +1406,8 @@ void BacktestingScreen::display_result(const QJsonObject& data) {
cards->deleteLater();
// If result has a status/message, show it
- if (data.contains("status")) {
- auto status = data["status"].toString();
+ if (payload.contains("status")) {
+ auto status = payload["status"].toString();
auto* status_lbl = new QLabel(QString("Status: %1").arg(status), summary_container_);
status_lbl->setStyleSheet(QString("color:%1; font-size:%2px; font-family:%3; padding:8px;")
.arg(status == "success" ? ui::colors::POSITIVE() : ui::colors::WARNING())
@@ -1441,8 +1441,8 @@ void BacktestingScreen::display_result(const QJsonObject& data) {
}
// ── TRADES tab ──
- auto trades = data.contains("trades") ? data["trades"].toArray()
- : data.contains("data") ? data["data"].toObject().value("trades").toArray()
+ auto trades = payload.contains("trades") ? payload["trades"].toArray()
+ : payload.contains("payload") ? payload["payload"].toObject().value("trades").toArray()
: QJsonArray();
if (!trades.isEmpty() && trades[0].isObject()) {
@@ -1469,7 +1469,7 @@ void BacktestingScreen::display_result(const QJsonObject& data) {
}
// ── RAW JSON tab ──
- raw_json_edit_->setPlainText(QJsonDocument(data).toJson(QJsonDocument::Indented));
+ raw_json_edit_->setPlainText(QJsonDocument(payload).toJson(QJsonDocument::Indented));
// Switch to summary tab
result_tabs_->setCurrentIndex(0);
@@ -1496,13 +1496,13 @@ void BacktestingScreen::display_error(const QString& msg) {
// ── Signal handlers ──────────────────────────────────────────────────────────
-void BacktestingScreen::on_result(const QString& provider, const QString& command, const QJsonObject& data) {
+void BacktestingScreen::on_result(const QString& provider, const QString& command, const QJsonObject& payload) {
// Route background metadata commands — don't touch run state or results UI
if (command == "get_strategies") {
// Only apply if result is for the currently-active provider
if (provider != providers_[active_provider_].slug)
return;
- strategies_ = services::backtest::strategies_from_json(data);
+ strategies_ = services::backtest::strategies_from_json(payload);
auto cats = services::backtest::categories_from_strategies(strategies_);
strategy_category_combo_->blockSignals(true);
strategy_category_combo_->clear();
@@ -1517,7 +1517,7 @@ void BacktestingScreen::on_result(const QString& provider, const QString& comman
if (provider != providers_[active_provider_].slug)
return;
// Populate both indicator combos from {indicators:{Cat:[{id,name}]}}
- auto ind_obj = data.value("indicators").toObject();
+ auto ind_obj = payload.value("indicators").toObject();
indicator_combo_->clear();
ind_signal_indicator_combo_->clear();
for (const auto& cat : ind_obj.keys()) {
@@ -1536,7 +1536,7 @@ void BacktestingScreen::on_result(const QString& provider, const QString& comman
is_running_ = false;
run_button_->setEnabled(true);
set_status_state("READY", ui::colors::POSITIVE, "rgba(22,163,74,0.08)");
- display_result(data);
+ display_result(payload);
LOG_INFO("Backtesting", QString("[%1/%2] Complete").arg(provider, command));
}
diff --git a/fincept-qt/src/screens/chat_mode/ChatModeService.cpp b/fincept-qt/src/screens/chat_mode/ChatModeService.cpp
index 3108413b2..d3c59cb27 100644
--- a/fincept-qt/src/screens/chat_mode/ChatModeService.cpp
+++ b/fincept-qt/src/screens/chat_mode/ChatModeService.cpp
@@ -352,7 +352,6 @@ void ChatModeService::optimize_prompt(const QString& prompt, const QString& mode
timer->start();
connect(reply, &QNetworkReply::finished, this, [this, reply, cb = std::move(cb)]() mutable {
- const int status = reply->attribute(QNetworkRequest::HttpStatusCodeAttribute).toInt();
const QByteArray data = reply->readAll();
const auto net_err = reply->error();
reply->deleteLater();
diff --git a/fincept-qt/src/screens/chat_mode/ChatSessionPanel.cpp b/fincept-qt/src/screens/chat_mode/ChatSessionPanel.cpp
index 7b69dc5e9..d28c10c9a 100644
--- a/fincept-qt/src/screens/chat_mode/ChatSessionPanel.cpp
+++ b/fincept-qt/src/screens/chat_mode/ChatSessionPanel.cpp
@@ -273,7 +273,7 @@ void ChatSessionPanel::on_export_clicked() {
export_btn_->setEnabled(false);
export_btn_->setText("...");
- ChatModeService::instance().export_sessions(uuids, [this, path](bool ok, QJsonArray data, QString err) {
+ ChatModeService::instance().export_sessions(uuids, [this, path](bool ok, QJsonArray payload, QString err) {
export_btn_->setEnabled(true);
export_btn_->setText("Export");
if (!ok) {
@@ -285,9 +285,9 @@ void ChatSessionPanel::on_export_clicked() {
QMessageBox::warning(this, "Export Failed", "Could not write file.");
return;
}
- file.write(QJsonDocument(data).toJson(QJsonDocument::Indented));
+ file.write(QJsonDocument(payload).toJson(QJsonDocument::Indented));
file.close();
- QMessageBox::information(this, "Export", QString("Exported %1 conversations.").arg(data.size()));
+ QMessageBox::information(this, "Export", QString("Exported %1 conversations.").arg(payload.size()));
});
}
diff --git a/fincept-qt/src/screens/chat_mode/TerminalToolBridge.cpp b/fincept-qt/src/screens/chat_mode/TerminalToolBridge.cpp
index 3c65c331a..cbc6a9417 100644
--- a/fincept-qt/src/screens/chat_mode/TerminalToolBridge.cpp
+++ b/fincept-qt/src/screens/chat_mode/TerminalToolBridge.cpp
@@ -137,7 +137,7 @@ void TerminalToolBridge::execute_call(const QString& call_id, const QString& too
// Execute on background thread to avoid blocking UI
QPointer<TerminalToolBridge> self = this;
- QtConcurrent::run([self, call_id, local_name, arguments]() {
+ (void)QtConcurrent::run([self, call_id, local_name, arguments]() {
// Call the tool via McpProvider
auto result = mcp::McpProvider::instance().call_tool(local_name, arguments);
diff --git a/fincept-qt/src/screens/crypto_trading/CryptoBottomPanel.cpp b/fincept-qt/src/screens/crypto_trading/CryptoBottomPanel.cpp
index c2c7c111f..ceb62cde3 100644
--- a/fincept-qt/src/screens/crypto_trading/CryptoBottomPanel.cpp
+++ b/fincept-qt/src/screens/crypto_trading/CryptoBottomPanel.cpp
@@ -210,7 +210,7 @@ void CryptoBottomPanel::set_positions(const QVector<trading::PtPosition>& positi
// bookkeeping flush, and only P&L + current_price actually change per
// tick. Skipping untouched cells cuts the repaint footprint sharply.
auto set = [&](int col, const QString& text, const QColor& fg = QColor(),
- int align = Qt::AlignLeft | Qt::AlignVCenter) {
+ Qt::Alignment align = Qt::AlignLeft | Qt::AlignVCenter) {
auto* it = ensure_item(positions_table_, i, col);
if (it->text() != text)
it->setText(text);
@@ -219,7 +219,7 @@ void CryptoBottomPanel::set_positions(const QVector<trading::PtPosition>& positi
it->setForeground(fg);
if (it->background().color() != bg)
it->setBackground(bg);
- if (it->textAlignment() != align)
+ if (Qt::Alignment(it->textAlignment()) != align)
it->setTextAlignment(align);
};
@@ -252,7 +252,7 @@ void CryptoBottomPanel::set_orders(const QVector<trading::PtOrder>& orders) {
const QColor bg = (i % 2 == 0) ? kRowEven() : kRowOdd();
auto set = [&](int col, const QString& text, const QColor& fg = QColor(),
- int align = Qt::AlignLeft | Qt::AlignVCenter) {
+ Qt::Alignment align = Qt::AlignLeft | Qt::AlignVCenter) {
auto* it = ensure_item(orders_table_, i, col);
it->setText(text);
if (fg.isValid())
@@ -298,7 +298,7 @@ void CryptoBottomPanel::set_trades(const QVector<trading::PtTrade>& trades) {
const QColor bg = (i % 2 == 0) ? kRowEven() : kRowOdd();
auto set = [&](int col, const QString& text, const QColor& fg = QColor(),
- int align = Qt::AlignLeft | Qt::AlignVCenter) {
+ Qt::Alignment align = Qt::AlignLeft | Qt::AlignVCenter) {
auto* it = ensure_item(trades_table_, i, col);
it->setText(text);
if (fg.isValid())
@@ -364,7 +364,7 @@ void CryptoBottomPanel::set_live_positions(const QJsonArray& positions) {
const QColor bg = (i % 2 == 0) ? kRowEven() : kRowOdd();
auto set = [&](int col, const QString& text, const QColor& fg = QColor(),
- int align = Qt::AlignLeft | Qt::AlignVCenter) {
+ Qt::Alignment align = Qt::AlignLeft | Qt::AlignVCenter) {
auto* it = ensure_item(positions_table_, i, col);
it->setText(text);
if (fg.isValid())
@@ -397,7 +397,7 @@ void CryptoBottomPanel::set_live_orders(const QJsonArray& orders) {
const QColor bg = (i % 2 == 0) ? kRowEven() : kRowOdd();
auto set = [&](int col, const QString& text, const QColor& fg = QColor(),
- int align = Qt::AlignLeft | Qt::AlignVCenter) {
+ Qt::Alignment align = Qt::AlignLeft | Qt::AlignVCenter) {
auto* it = ensure_item(orders_table_, i, col);
it->setText(text);
if (fg.isValid())
@@ -431,8 +431,8 @@ void CryptoBottomPanel::set_live_orders(const QJsonArray& orders) {
orders_table_->setUpdatesEnabled(true);
}
-void CryptoBottomPanel::update_my_trades(const QJsonObject& data) {
- const QJsonArray trades = data.value("trades").toArray();
+void CryptoBottomPanel::update_my_trades(const QJsonObject& json) {
+ const QJsonArray trades = json.value("trades").toArray();
const int n = trades.size();
my_trades_table_->setUpdatesEnabled(false);
if (my_trades_table_->rowCount() != n)
@@ -443,7 +443,7 @@ void CryptoBottomPanel::update_my_trades(const QJsonObject& data) {
const QColor bg = (i % 2 == 0) ? kRowEven() : kRowOdd();
auto set = [&](int col, const QString& text, const QColor& fg = QColor(),
- int align = Qt::AlignLeft | Qt::AlignVCenter) {
+ Qt::Alignment align = Qt::AlignLeft | Qt::AlignVCenter) {
auto* it = ensure_item(my_trades_table_, i, col);
it->setText(text);
if (fg.isValid())
@@ -468,9 +468,9 @@ void CryptoBottomPanel::update_my_trades(const QJsonObject& data) {
my_trades_table_->setUpdatesEnabled(true);
}
-void CryptoBottomPanel::update_fees(const QJsonObject& data) {
+void CryptoBottomPanel::update_fees(const QJsonObject& json) {
// Single-symbol response
- if (data.contains("symbol")) {
+ if (json.contains("symbol")) {
fees_table_->setUpdatesEnabled(false);
fees_table_->setRowCount(1);
const QColor bg = kRowEven();
@@ -484,15 +484,15 @@ void CryptoBottomPanel::update_fees(const QJsonObject& data) {
it->setTextAlignment(Qt::AlignRight | Qt::AlignVCenter);
};
- set(0, data.value("symbol").toString());
- set(1, QString::number(data.value("maker").toDouble() * 100.0, 'f', 4) + "%", kColorSec());
- set(2, QString::number(data.value("taker").toDouble() * 100.0, 'f', 4) + "%", kColorSec());
+ set(0, json.value("symbol").toString());
+ set(1, QString::number(json.value("maker").toDouble() * 100.0, 'f', 4) + "%", kColorSec());
+ set(2, QString::number(json.value("taker").toDouble() * 100.0, 'f', 4) + "%", kColorSec());
fees_table_->setUpdatesEnabled(true);
return;
}
// Multi-symbol response
- const QJsonArray fees = data.value("fees").toArray();
+ const QJsonArray fees = json.value("fees").toArray();
const int n = fees.size();
fees_table_->setUpdatesEnabled(false);
if (fees_table_->rowCount() != n)
diff --git a/fincept-qt/src/screens/crypto_trading/CryptoTradingScreen.cpp b/fincept-qt/src/screens/crypto_trading/CryptoTradingScreen.cpp
index 9e2547f17..d25a953a8 100644
--- a/fincept-qt/src/screens/crypto_trading/CryptoTradingScreen.cpp
+++ b/fincept-qt/src/screens/crypto_trading/CryptoTradingScreen.cpp
@@ -519,7 +519,7 @@ void CryptoTradingScreen::load_portfolio() {
// because watch_symbol is called under the then-current selected_symbol_.
QPointer<CryptoTradingScreen> self = this;
const QString exch = exchange_id_;
- QtConcurrent::run([self, exch]() {
+ (void)QtConcurrent::run([self, exch]() {
if (!self)
return;
trading::PtPortfolio portfolio;
@@ -561,7 +561,7 @@ void CryptoTradingScreen::async_fetch_candles(const QString& symbol, const QStri
if (candles_fetching_.exchange(true))
return;
QPointer<CryptoTradingScreen> self = this;
- QtConcurrent::run([self, symbol, timeframe]() {
+ (void)QtConcurrent::run([self, symbol, timeframe]() {
auto candles = ExchangeService::instance().fetch_ohlcv(symbol, timeframe, OHLCV_FETCH_COUNT);
if (!self)
return;
@@ -579,7 +579,7 @@ void CryptoTradingScreen::async_fetch_candles(const QString& symbol, const QStri
void CryptoTradingScreen::async_fetch_live_positions() {
QPointer<CryptoTradingScreen> self = this;
- QtConcurrent::run([self]() {
+ (void)QtConcurrent::run([self]() {
if (!self) {
// Widget destroyed before dispatch — no counter to decrement.
return;
@@ -600,7 +600,7 @@ void CryptoTradingScreen::async_fetch_live_positions() {
void CryptoTradingScreen::async_fetch_live_orders() {
QPointer<CryptoTradingScreen> self = this;
- QtConcurrent::run([self]() {
+ (void)QtConcurrent::run([self]() {
if (!self)
return;
auto result = ExchangeService::instance().fetch_open_orders_live(self->selected_symbol_);
@@ -619,7 +619,7 @@ void CryptoTradingScreen::async_fetch_live_orders() {
void CryptoTradingScreen::async_fetch_live_balance() {
QPointer<CryptoTradingScreen> self = this;
- QtConcurrent::run([self]() {
+ (void)QtConcurrent::run([self]() {
if (!self)
return;
auto result = ExchangeService::instance().fetch_balance();
@@ -802,7 +802,7 @@ void CryptoTradingScreen::on_order_submitted(const QString& side, const QString&
refresh_portfolio();
} else {
QPointer<CryptoTradingScreen> self = this;
- QtConcurrent::run([self, side, order_type, qty, price]() {
+ (void)QtConcurrent::run([self, side, order_type, qty, price]() {
if (!self)
return;
ExchangeService::instance().place_exchange_order(self->selected_symbol_, side, order_type, qty, price);
@@ -833,7 +833,7 @@ void CryptoTradingScreen::on_cancel_order(const QString& order_id) {
}
} else {
QPointer<CryptoTradingScreen> self = this;
- QtConcurrent::run([self, order_id]() {
+ (void)QtConcurrent::run([self, order_id]() {
if (!self)
return;
ExchangeService::instance().cancel_exchange_order(order_id, self->selected_symbol_);
@@ -856,7 +856,7 @@ void CryptoTradingScreen::on_ob_price_clicked(double price) {
void CryptoTradingScreen::on_search_requested(const QString& filter) {
QPointer<CryptoTradingScreen> self = this;
QString filter_copy = filter;
- QtConcurrent::run([self, filter_copy]() {
+ (void)QtConcurrent::run([self, filter_copy]() {
if (!self)
return;
auto markets = ExchangeService::instance().fetch_markets("spot", filter_copy);
@@ -965,7 +965,7 @@ void CryptoTradingScreen::flush_ws_updates() {
if (paper_bookkeeping_in_flight_.compare_exchange_strong(expected, true)) {
QPointer<CryptoTradingScreen> self = this;
const QString pid = portfolio_id_;
- QtConcurrent::run([self, pid, batch]() {
+ (void)QtConcurrent::run([self, pid, batch]() {
struct Result {
QVector<PtPosition> positions;
bool fill_occurred = false;
@@ -1051,7 +1051,7 @@ void CryptoTradingScreen::refresh_ticker() {
return;
QPointer<CryptoTradingScreen> self = this;
const QString symbol = selected_symbol_;
- QtConcurrent::run([self, symbol]() {
+ (void)QtConcurrent::run([self, symbol]() {
if (!self)
return;
auto ticker = ExchangeService::instance().fetch_ticker(symbol);
@@ -1077,7 +1077,7 @@ void CryptoTradingScreen::refresh_orderbook() {
if (!initialized_)
return;
QPointer<CryptoTradingScreen> self = this;
- QtConcurrent::run([self]() {
+ (void)QtConcurrent::run([self]() {
if (!self)
return;
auto ob = ExchangeService::instance().fetch_orderbook(self->selected_symbol_, OB_MAX_DISPLAY_LEVELS);
@@ -1103,7 +1103,7 @@ void CryptoTradingScreen::refresh_portfolio() {
// placement/cancel flushes, this was one of the loudest UI-thread stalls.
QPointer<CryptoTradingScreen> self = this;
const QString pid = portfolio_id_;
- QtConcurrent::run([self, pid]() {
+ (void)QtConcurrent::run([self, pid]() {
struct Snapshot {
PtPortfolio portfolio;
QVector<PtPosition> positions;
@@ -1143,7 +1143,7 @@ void CryptoTradingScreen::refresh_watchlist() {
if (!initialized_)
return;
QPointer<CryptoTradingScreen> self = this;
- QtConcurrent::run([self]() {
+ (void)QtConcurrent::run([self]() {
if (!self)
return;
auto tickers = ExchangeService::instance().fetch_tickers(self->watchlist_symbols_);
@@ -1170,7 +1170,7 @@ void CryptoTradingScreen::refresh_market_info() {
QPointer<CryptoTradingScreen> self = this;
const QString symbol = selected_symbol_;
- QtConcurrent::run([self, symbol]() {
+ (void)QtConcurrent::run([self, symbol]() {
if (!self)
return;
auto fr = ExchangeService::instance().fetch_funding_rate(symbol);
@@ -1192,7 +1192,7 @@ void CryptoTradingScreen::refresh_market_info() {
Qt::QueuedConnection);
});
- QtConcurrent::run([self, symbol]() {
+ (void)QtConcurrent::run([self, symbol]() {
if (!self)
return;
auto oi = ExchangeService::instance().fetch_open_interest(symbol);
@@ -1234,7 +1234,7 @@ void CryptoTradingScreen::refresh_live_data() {
void CryptoTradingScreen::async_fetch_my_trades() {
QPointer<CryptoTradingScreen> self = this;
- QtConcurrent::run([self]() {
+ (void)QtConcurrent::run([self]() {
if (!self)
return;
auto result = ExchangeService::instance().fetch_my_trades(self->selected_symbol_);
@@ -1252,7 +1252,7 @@ void CryptoTradingScreen::async_fetch_my_trades() {
void CryptoTradingScreen::async_fetch_trading_fees() {
QPointer<CryptoTradingScreen> self = this;
- QtConcurrent::run([self]() {
+ (void)QtConcurrent::run([self]() {
if (!self)
return;
auto result = ExchangeService::instance().fetch_trading_fees(self->selected_symbol_);
@@ -1269,7 +1269,7 @@ void CryptoTradingScreen::async_fetch_trading_fees() {
void CryptoTradingScreen::async_fetch_mark_price() {
QPointer<CryptoTradingScreen> self = this;
- QtConcurrent::run([self]() {
+ (void)QtConcurrent::run([self]() {
if (!self)
return;
auto mp = ExchangeService::instance().fetch_mark_price(self->selected_symbol_);
@@ -1286,13 +1286,13 @@ void CryptoTradingScreen::async_fetch_mark_price() {
void CryptoTradingScreen::async_set_leverage(int leverage) {
const QString symbol = selected_symbol_;
- QtConcurrent::run([symbol, leverage]() { ExchangeService::instance().set_leverage(symbol, leverage); });
+ (void)QtConcurrent::run([symbol, leverage]() { ExchangeService::instance().set_leverage(symbol, leverage); });
}
void CryptoTradingScreen::async_set_margin_mode(const QString& mode) {
const QString symbol = selected_symbol_;
const QString m = mode;
- QtConcurrent::run([symbol, m]() { ExchangeService::instance().set_margin_mode(symbol, m); });
+ (void)QtConcurrent::run([symbol, m]() { ExchangeService::instance().set_margin_mode(symbol, m); });
}
// ── IStatefulScreen ───────────────────────────────────────────────────────────
diff --git a/fincept-qt/src/screens/crypto_trading/CryptoWatchlist.cpp b/fincept-qt/src/screens/crypto_trading/CryptoWatchlist.cpp
index 25cd6d597..84899a1cc 100644
--- a/fincept-qt/src/screens/crypto_trading/CryptoWatchlist.cpp
+++ b/fincept-qt/src/screens/crypto_trading/CryptoWatchlist.cpp
@@ -254,7 +254,7 @@ void CryptoWatchlist::rebuild_table() {
for (int i = 0; i < n; ++i) {
const QColor bg = (i % 2 == 0) ? kRowEven() : kRowOdd();
auto ensure = [&](int col, const QString& text, const QColor& fg,
- int align = Qt::AlignLeft | Qt::AlignVCenter) {
+ Qt::Alignment align = Qt::AlignLeft | Qt::AlignVCenter) {
auto* it = table_->item(i, col);
if (!it) {
it = new QTableWidgetItem;
@@ -295,7 +295,7 @@ void CryptoWatchlist::rebuild_table() {
bg = kRowNegHint;
auto ensure = [&](int col, const QString& text, const QColor& fg,
- int align = Qt::AlignLeft | Qt::AlignVCenter) {
+ Qt::Alignment align = Qt::AlignLeft | Qt::AlignVCenter) {
auto* it = table_->item(i, col);
if (!it) {
it = new QTableWidgetItem;
diff --git a/fincept-qt/src/screens/dashboard/DashboardScreen.cpp b/fincept-qt/src/screens/dashboard/DashboardScreen.cpp
index 61ba6f0a4..2fcc66a88 100644
--- a/fincept-qt/src/screens/dashboard/DashboardScreen.cpp
+++ b/fincept-qt/src/screens/dashboard/DashboardScreen.cpp
@@ -136,7 +136,7 @@ DashboardScreen::DashboardScreen(QWidget* parent) : QWidget(parent) {
auto* dlg = new TemplatePicker(this);
connect(dlg, &TemplatePicker::template_selected, this, [this](const QString& tid) {
// Clear saved state so fresh template is used
- QtConcurrent::run([]() { fincept::SettingsRepository::instance().remove("dashboard_canvas_layout"); });
+ (void)QtConcurrent::run([]() { fincept::SettingsRepository::instance().remove("dashboard_canvas_layout"); });
canvas_->apply_template(tid);
});
dlg->exec();
@@ -317,8 +317,8 @@ void DashboardScreen::save_layout() {
GridLayout layout = canvas_->current_layout();
// Serialize: cols, row_h, margin, item count, then each item
- QByteArray data;
- QDataStream stream(&data, QIODevice::WriteOnly);
+ QByteArray buf;
+ QDataStream stream(&buf, QIODevice::WriteOnly);
stream << layout.cols << layout.row_h << layout.margin;
stream << static_cast<int>(layout.items.size());
for (const auto& item : layout.items) {
@@ -327,15 +327,15 @@ void DashboardScreen::save_layout() {
stream << item.cell.min_w << item.cell.min_h;
}
- QString encoded = data.toBase64();
+ QString encoded = buf.toBase64();
QPointer<DashboardScreen> self = this;
- QtConcurrent::run(
+ (void)QtConcurrent::run(
[encoded]() { fincept::SettingsRepository::instance().set("dashboard_canvas_layout", encoded, "dashboard"); });
}
void DashboardScreen::restore_layout() {
QPointer<DashboardScreen> self = this;
- QtConcurrent::run([self]() {
+ (void)QtConcurrent::run([self]() {
auto result = fincept::SettingsRepository::instance().get("dashboard_canvas_layout");
QMetaObject::invokeMethod(
diff --git a/fincept-qt/src/screens/dashboard/TickerBar.cpp b/fincept-qt/src/screens/dashboard/TickerBar.cpp
index 93c23ad38..eadfe1464 100644
--- a/fincept-qt/src/screens/dashboard/TickerBar.cpp
+++ b/fincept-qt/src/screens/dashboard/TickerBar.cpp
@@ -111,7 +111,7 @@ void TickerBar::load_symbols() {
symbols_ = defaults;
QPointer<TickerBar> self = this;
- QtConcurrent::run([self, defaults]() {
+ (void)QtConcurrent::run([self, defaults]() {
auto result = fincept::SettingsRepository::instance().get(kSettingsKey);
QStringList loaded;
if (result.is_ok() && !result.value().isEmpty()) {
@@ -131,7 +131,7 @@ void TickerBar::load_symbols() {
void TickerBar::save_symbols() {
const QString value = symbols_.join(",");
- QtConcurrent::run([value]() {
+ (void)QtConcurrent::run([value]() {
fincept::SettingsRepository::instance().set(kSettingsKey, value, kSettingsCategory);
});
}
diff --git a/fincept-qt/src/screens/dashboard/widgets/OrderBookMiniWidget.cpp b/fincept-qt/src/screens/dashboard/widgets/OrderBookMiniWidget.cpp
index 1f7621f54..c7fa17186 100644
--- a/fincept-qt/src/screens/dashboard/widgets/OrderBookMiniWidget.cpp
+++ b/fincept-qt/src/screens/dashboard/widgets/OrderBookMiniWidget.cpp
@@ -184,7 +184,7 @@ void OrderBookMiniWidget::cancel_order(const QString& order_id) {
// BrokerHttp blocking trap (P1) — always wrap live broker calls in QtConcurrent::run.
const QString acct_id = account_id_;
QPointer<OrderBookMiniWidget> self = this;
- QtConcurrent::run([self, acct_id, order_id]() {
+ (void)QtConcurrent::run([self, acct_id, order_id]() {
if (!self)
return;
trading::UnifiedTrading::instance().cancel_order(acct_id, order_id);
diff --git a/fincept-qt/src/screens/data_sources/DataSourcesScreen.cpp b/fincept-qt/src/screens/data_sources/DataSourcesScreen.cpp
index a6b1b32f1..ae5e48a41 100644
--- a/fincept-qt/src/screens/data_sources/DataSourcesScreen.cpp
+++ b/fincept-qt/src/screens/data_sources/DataSourcesScreen.cpp
@@ -143,13 +143,6 @@ QString field_type_label(FieldType type) {
return "Text";
}
-QString compact_value(const QString& value, int max_len = 22) {
- const QString trimmed = value.trimmed();
- if (trimmed.size() <= max_len)
- return trimmed;
- return trimmed.left(max_len - 3) + "...";
-}
-
int total_connections_for_provider(const QVector<DataSource>& rows, const QString& connector_id) {
int count = 0;
for (const auto& ds : rows)
@@ -1417,14 +1410,14 @@ void DataSourcesScreen::show_config_dialog(const ConnectorConfig& config, const
QWidget* widget = field_widgets.value(field.name, nullptr);
QString text_value;
- if (auto* edit = qobject_cast<QLineEdit*>(widget)) {
- text_value = edit->text().trimmed();
+ if (auto* line_edit = qobject_cast<QLineEdit*>(widget)) {
+ text_value = line_edit->text().trimmed();
if (field.type == FieldType::Number)
cfg_json[field.name] = text_value.toInt();
else
cfg_json[field.name] = text_value;
- } else if (auto* edit = qobject_cast<QTextEdit*>(widget)) {
- text_value = edit->toPlainText().trimmed();
+ } else if (auto* text_edit = qobject_cast<QTextEdit*>(widget)) {
+ text_value = text_edit->toPlainText().trimmed();
cfg_json[field.name] = text_value;
} else if (auto* combo = qobject_cast<QComboBox*>(widget)) {
text_value = combo->currentData().toString();
@@ -2867,9 +2860,9 @@ void DataSourcesScreen::on_import_connections() {
LOG_ERROR(TAG, QString("Import failed: cannot open %1").arg(path));
return;
}
- const QByteArray data = file.readAll();
+ const QByteArray payload = file.readAll();
QJsonParseError parse_err;
- const auto doc = QJsonDocument::fromJson(data, &parse_err);
+ const auto doc = QJsonDocument::fromJson(payload, &parse_err);
if (parse_err.error != QJsonParseError::NoError || !doc.isArray()) {
LOG_ERROR(TAG, QString("Import failed: invalid JSON — %1").arg(parse_err.errorString()));
return;
@@ -3003,7 +2996,7 @@ void DataSourcesScreen::on_poll_timer() {
const int cap_port = port;
const QString cap_probe = probe_url;
- QtConcurrent::run([self, conn_id, cap_host, cap_port, cap_probe]() {
+ (void)QtConcurrent::run([self, conn_id, cap_host, cap_port, cap_probe]() {
QTcpSocket socket;
socket.connectToHost(cap_host, static_cast<quint16>(cap_port));
const bool ok = socket.waitForConnected(3000);
diff --git a/fincept-qt/src/screens/dbnomics/DBnomicsScreen.cpp b/fincept-qt/src/screens/dbnomics/DBnomicsScreen.cpp
index 6ff1b6f6d..482f03c36 100644
--- a/fincept-qt/src/screens/dbnomics/DBnomicsScreen.cpp
+++ b/fincept-qt/src/screens/dbnomics/DBnomicsScreen.cpp
@@ -420,8 +420,8 @@ void DBnomicsScreen::on_series_loaded(const QVector<services::DbnSeriesInfo>& se
set_status(QString("Loaded %1 series").arg(series.size()));
}
-void DBnomicsScreen::on_observations_loaded(const services::DbnDataPoint& data) {
- last_loaded_data_ = data;
+void DBnomicsScreen::on_observations_loaded(const services::DbnDataPoint& point) {
+ last_loaded_data_ = point;
has_pending_data_ = true;
// Always stop loading spinners — data has arrived
@@ -430,17 +430,17 @@ void DBnomicsScreen::on_observations_loaded(const services::DbnDataPoint& data)
// Check if this series is already in single_series_
for (auto& s : single_series_) {
- if (s.series_id == data.series_id) {
- s.observations = data.observations;
- s.series_name = data.series_name;
+ if (s.series_id == point.series_id) {
+ s.observations = point.observations;
+ s.series_name = point.series_name;
render_single_view();
return;
}
}
// Not yet in view — prompt user
- set_status(QString("Loaded: %1 • Click ADD TO SINGLE VIEW").arg(data.series_name));
- LOG_INFO("DBnomicsScreen", QString("Observations loaded for: %1").arg(data.series_id));
+ set_status(QString("Loaded: %1 • Click ADD TO SINGLE VIEW").arg(point.series_name));
+ LOG_INFO("DBnomicsScreen", QString("Observations loaded for: %1").arg(point.series_id));
}
void DBnomicsScreen::on_search_results_loaded(const QVector<services::DbnSearchResult>& results,
diff --git a/fincept-qt/src/screens/docs/DocsScreen.cpp b/fincept-qt/src/screens/docs/DocsScreen.cpp
index 026b2e7f2..b0891eada 100644
--- a/fincept-qt/src/screens/docs/DocsScreen.cpp
+++ b/fincept-qt/src/screens/docs/DocsScreen.cpp
@@ -1405,11 +1405,11 @@ void DocsScreen::build_sidebar() {
add_item(ai, "Alpha Arena", "alpha_arena");
// ── Data Sources ─────────────────────────────────────────────────────────
- auto* data = add_category("DATA SOURCES");
- add_item(data, "DBnomics", "dbnomics");
- add_item(data, "Economics", "economics");
- add_item(data, "AkShare Data", "akshare");
- add_item(data, "Government Data", "gov_data");
+ auto* data_cat = add_category("DATA SOURCES");
+ add_item(data_cat, "DBnomics", "dbnomics");
+ add_item(data_cat, "Economics", "economics");
+ add_item(data_cat, "AkShare Data", "akshare");
+ add_item(data_cat, "Government Data", "gov_data");
// ── Geopolitics & Alt ────────────────────────────────────────────────────
auto* geo = add_category("GEOPOLITICS & ALT");
diff --git a/fincept-qt/src/screens/economics/panels/AdbPanel.cpp b/fincept-qt/src/screens/economics/panels/AdbPanel.cpp
index c409debc9..aa8a51c00 100644
--- a/fincept-qt/src/screens/economics/panels/AdbPanel.cpp
+++ b/fincept-qt/src/screens/economics/panels/AdbPanel.cpp
@@ -70,7 +70,7 @@ void AdbPanel::activate() {
// ── Controls ──────────────────────────────────────────────────────────────────
void AdbPanel::build_controls(QHBoxLayout* thl) {
- auto make_lbl = [this](const QString& text) {
+ auto make_lbl = [](const QString& text) {
auto* l = new QLabel(text);
l->setStyleSheet(ctrl_label_style());
return l;
diff --git a/fincept-qt/src/screens/economics/panels/BisPanel.cpp b/fincept-qt/src/screens/economics/panels/BisPanel.cpp
index 4be0f8d92..4a50caf1e 100644
--- a/fincept-qt/src/screens/economics/panels/BisPanel.cpp
+++ b/fincept-qt/src/screens/economics/panels/BisPanel.cpp
@@ -60,7 +60,7 @@ void BisPanel::activate() {
// ── Controls ──────────────────────────────────────────────────────────────────
void BisPanel::build_controls(QHBoxLayout* thl) {
- auto make_lbl = [this](const QString& text) {
+ auto make_lbl = [](const QString& text) {
auto* l = new QLabel(text);
l->setStyleSheet(ctrl_label_style());
return l;
diff --git a/fincept-qt/src/screens/economics/panels/BlsPanel.cpp b/fincept-qt/src/screens/economics/panels/BlsPanel.cpp
index f722234c1..8e9778920 100644
--- a/fincept-qt/src/screens/economics/panels/BlsPanel.cpp
+++ b/fincept-qt/src/screens/economics/panels/BlsPanel.cpp
@@ -61,7 +61,7 @@ void BlsPanel::activate() {
}
void BlsPanel::build_controls(QHBoxLayout* thl) {
- auto lbl = [this](const QString& t) {
+ auto lbl = [](const QString& t) {
auto* l = new QLabel(t);
l->setStyleSheet(ctrl_label_style());
return l;
diff --git a/fincept-qt/src/screens/economics/panels/CftcPanel.cpp b/fincept-qt/src/screens/economics/panels/CftcPanel.cpp
index 1b7714398..9b47f9d9c 100644
--- a/fincept-qt/src/screens/economics/panels/CftcPanel.cpp
+++ b/fincept-qt/src/screens/economics/panels/CftcPanel.cpp
@@ -106,7 +106,7 @@ void CftcPanel::activate() {
// ── Controls ──────────────────────────────────────────────────────────────────
void CftcPanel::build_controls(QHBoxLayout* thl) {
- auto make_lbl = [this](const QString& text) {
+ auto make_lbl = [](const QString& text) {
auto* l = new QLabel(text);
l->setStyleSheet(ctrl_label_style());
return l;
diff --git a/fincept-qt/src/screens/economics/panels/EcbPanel.cpp b/fincept-qt/src/screens/economics/panels/EcbPanel.cpp
index dc2a7076b..68a447a85 100644
--- a/fincept-qt/src/screens/economics/panels/EcbPanel.cpp
+++ b/fincept-qt/src/screens/economics/panels/EcbPanel.cpp
@@ -51,7 +51,7 @@ void EcbPanel::activate() {
}
void EcbPanel::build_controls(QHBoxLayout* thl) {
- auto lbl = [this](const QString& t) {
+ auto lbl = [](const QString& t) {
auto* l = new QLabel(t);
l->setStyleSheet(ctrl_label_style());
return l;
@@ -68,7 +68,6 @@ void EcbPanel::build_controls(QHBoxLayout* thl) {
}
void EcbPanel::on_fetch() {
- const QString data = series_combo_->currentData().toString();
const int idx = series_combo_->currentIndex();
const auto& series = kEcbSeries[idx];
diff --git a/fincept-qt/src/screens/economics/panels/EconDbPanel.cpp b/fincept-qt/src/screens/economics/panels/EconDbPanel.cpp
index a06aef209..bb5768be5 100644
--- a/fincept-qt/src/screens/economics/panels/EconDbPanel.cpp
+++ b/fincept-qt/src/screens/economics/panels/EconDbPanel.cpp
@@ -76,7 +76,7 @@ void EconDbPanel::activate() {
}
void EconDbPanel::build_controls(QHBoxLayout* thl) {
- auto lbl = [this](const QString& t) {
+ auto lbl = [](const QString& t) {
auto* l = new QLabel(t);
l->setStyleSheet(ctrl_label_style());
return l;
diff --git a/fincept-qt/src/screens/economics/panels/EconomicCalendarPanel.cpp b/fincept-qt/src/screens/economics/panels/EconomicCalendarPanel.cpp
index c80eeabec..fc3a45cdb 100644
--- a/fincept-qt/src/screens/economics/panels/EconomicCalendarPanel.cpp
+++ b/fincept-qt/src/screens/economics/panels/EconomicCalendarPanel.cpp
@@ -49,7 +49,7 @@ void EconomicCalendarPanel::activate() {
}
void EconomicCalendarPanel::build_controls(QHBoxLayout* thl) {
- auto lbl = [this](const QString& t) {
+ auto lbl = [](const QString& t) {
auto* l = new QLabel(t);
l->setStyleSheet(ctrl_label_style());
return l;
diff --git a/fincept-qt/src/screens/economics/panels/EurostatPanel.cpp b/fincept-qt/src/screens/economics/panels/EurostatPanel.cpp
index 8c33f9784..523e9eca2 100644
--- a/fincept-qt/src/screens/economics/panels/EurostatPanel.cpp
+++ b/fincept-qt/src/screens/economics/panels/EurostatPanel.cpp
@@ -119,7 +119,7 @@ void EurostatPanel::activate() {
}
void EurostatPanel::build_controls(QHBoxLayout* thl) {
- auto lbl = [this](const QString& t) {
+ auto lbl = [](const QString& t) {
auto* l = new QLabel(t);
l->setStyleSheet(ctrl_label_style());
return l;
diff --git a/fincept-qt/src/screens/economics/panels/IlostatPanel.cpp b/fincept-qt/src/screens/economics/panels/IlostatPanel.cpp
index 7b1c17e12..7fc1bfec3 100644
--- a/fincept-qt/src/screens/economics/panels/IlostatPanel.cpp
+++ b/fincept-qt/src/screens/economics/panels/IlostatPanel.cpp
@@ -46,7 +46,7 @@ void IlostatPanel::activate() {
}
void IlostatPanel::build_controls(QHBoxLayout* thl) {
- auto mk_lbl = [this](const QString& t) {
+ auto mk_lbl = [](const QString& t) {
auto* l = new QLabel(t);
l->setStyleSheet(ctrl_label_style());
return l;
diff --git a/fincept-qt/src/screens/economics/panels/OecdPanel.cpp b/fincept-qt/src/screens/economics/panels/OecdPanel.cpp
index 64a6f5b52..53c893c7d 100644
--- a/fincept-qt/src/screens/economics/panels/OecdPanel.cpp
+++ b/fincept-qt/src/screens/economics/panels/OecdPanel.cpp
@@ -41,7 +41,7 @@ void OecdPanel::activate() {
}
void OecdPanel::build_controls(QHBoxLayout* thl) {
- auto lbl = [this](const QString& t) {
+ auto lbl = [](const QString& t) {
auto* l = new QLabel(t);
l->setStyleSheet(ctrl_label_style());
return l;
diff --git a/fincept-qt/src/screens/economics/panels/OwIdPanel.cpp b/fincept-qt/src/screens/economics/panels/OwIdPanel.cpp
index eabdea341..d3ad63ac0 100644
--- a/fincept-qt/src/screens/economics/panels/OwIdPanel.cpp
+++ b/fincept-qt/src/screens/economics/panels/OwIdPanel.cpp
@@ -47,7 +47,7 @@ void OwIdPanel::activate() {
}
void OwIdPanel::build_controls(QHBoxLayout* thl) {
- auto mk_lbl = [this](const QString& t) {
+ auto mk_lbl = [](const QString& t) {
auto* l = new QLabel(t);
l->setStyleSheet(ctrl_label_style());
return l;
diff --git a/fincept-qt/src/screens/economics/panels/TradingEconomicsPanel.cpp b/fincept-qt/src/screens/economics/panels/TradingEconomicsPanel.cpp
index 8e31da28c..fea54d8e2 100644
--- a/fincept-qt/src/screens/economics/panels/TradingEconomicsPanel.cpp
+++ b/fincept-qt/src/screens/economics/panels/TradingEconomicsPanel.cpp
@@ -54,7 +54,7 @@ void TradingEconomicsPanel::activate() {
}
void TradingEconomicsPanel::build_controls(QHBoxLayout* thl) {
- auto lbl = [this](const QString& t) {
+ auto lbl = [](const QString& t) {
auto* l = new QLabel(t);
l->setStyleSheet(ctrl_label_style());
return l;
diff --git a/fincept-qt/src/screens/economics/panels/UnComtradePanel.cpp b/fincept-qt/src/screens/economics/panels/UnComtradePanel.cpp
index b73a1238a..7814b0256 100644
--- a/fincept-qt/src/screens/economics/panels/UnComtradePanel.cpp
+++ b/fincept-qt/src/screens/economics/panels/UnComtradePanel.cpp
@@ -38,7 +38,7 @@ void UnComtradePanel::activate() {
}
void UnComtradePanel::build_controls(QHBoxLayout* thl) {
- auto lbl = [this](const QString& t) {
+ auto lbl = [](const QString& t) {
auto* l = new QLabel(t);
l->setStyleSheet(ctrl_label_style());
return l;
diff --git a/fincept-qt/src/screens/economics/panels/WorldBankHealthPanel.cpp b/fincept-qt/src/screens/economics/panels/WorldBankHealthPanel.cpp
index 0f485faf0..3ae7c2841 100644
--- a/fincept-qt/src/screens/economics/panels/WorldBankHealthPanel.cpp
+++ b/fincept-qt/src/screens/economics/panels/WorldBankHealthPanel.cpp
@@ -88,7 +88,7 @@ void WorldBankHealthPanel::activate() {
}
void WorldBankHealthPanel::build_controls(QHBoxLayout* thl) {
- auto lbl = [this](const QString& t) {
+ auto lbl = [](const QString& t) {
auto* l = new QLabel(t);
l->setStyleSheet(ctrl_label_style());
return l;
diff --git a/fincept-qt/src/screens/economics/panels/WorldBankPanel.cpp b/fincept-qt/src/screens/economics/panels/WorldBankPanel.cpp
index 2ee92027b..5a0d15595 100644
--- a/fincept-qt/src/screens/economics/panels/WorldBankPanel.cpp
+++ b/fincept-qt/src/screens/economics/panels/WorldBankPanel.cpp
@@ -60,7 +60,7 @@ WorldBankPanel::WorldBankPanel(QWidget* parent) : EconPanelBase(kWorldBankSource
lvl->setContentsMargins(0, 0, 0, 0);
lvl->setSpacing(0);
- auto section_header = [this](const QString& text) {
+ auto section_header = [](const QString& text) {
auto* lbl = new QLabel(text);
lbl->setStyleSheet(section_lbl_style() + section_hdr_style());
return lbl;
diff --git a/fincept-qt/src/screens/equity_research/EquityFinancialsTab.cpp b/fincept-qt/src/screens/equity_research/EquityFinancialsTab.cpp
index e693ea4f5..35dd59eee 100644
--- a/fincept-qt/src/screens/equity_research/EquityFinancialsTab.cpp
+++ b/fincept-qt/src/screens/equity_research/EquityFinancialsTab.cpp
@@ -618,24 +618,24 @@ QWidget* EquityFinancialsTab::build_cashflow_view() {
// ── Data slot ─────────────────────────────────────────────────────────────────
-void EquityFinancialsTab::on_financials_loaded(services::equity::FinancialsData data) {
- if (data.symbol != current_symbol_)
+void EquityFinancialsTab::on_financials_loaded(services::equity::FinancialsData payload) {
+ if (payload.symbol != current_symbol_)
return;
- cached_data_ = data;
+ cached_data_ = payload;
loaded_ = true;
loading_overlay_->hide_loading();
- populate_income_view(data);
- populate_balance_view(data);
- populate_cashflow_view(data);
- populate_table(inc_table_, data.income_statement);
- populate_table(bal_table_, data.balance_sheet);
- populate_table(cf_table_, data.cash_flow);
- rebuild_revenue_chart(data);
- rebuild_margin_chart(data);
- rebuild_balance_chart(data);
- rebuild_cashflow_chart(data);
- rebuild_return_chart(data);
+ populate_income_view(payload);
+ populate_balance_view(payload);
+ populate_cashflow_view(payload);
+ populate_table(inc_table_, payload.income_statement);
+ populate_table(bal_table_, payload.balance_sheet);
+ populate_table(cf_table_, payload.cash_flow);
+ rebuild_revenue_chart(payload);
+ rebuild_margin_chart(payload);
+ rebuild_balance_chart(payload);
+ rebuild_cashflow_chart(payload);
+ rebuild_return_chart(payload);
}
// ── Populate helpers ──────────────────────────────────────────────────────────
diff --git a/fincept-qt/src/screens/equity_research/EquityResearchScreen.cpp b/fincept-qt/src/screens/equity_research/EquityResearchScreen.cpp
index c1a7558cd..537483f14 100644
--- a/fincept-qt/src/screens/equity_research/EquityResearchScreen.cpp
+++ b/fincept-qt/src/screens/equity_research/EquityResearchScreen.cpp
@@ -38,8 +38,8 @@ EquityResearchScreen::EquityResearchScreen(QWidget* parent) : QWidget(parent) {
connect(&svc, &services::equity::EquityResearchService::info_loaded, this, &EquityResearchScreen::on_info_loaded);
// Listen for navigation from CommandBar asset search
- EventBus::instance().subscribe("equity_research.load_symbol", [this](const QVariantMap& data) {
- const QString symbol = data.value("symbol").toString();
+ EventBus::instance().subscribe("equity_research.load_symbol", [this](const QVariantMap& payload) {
+ const QString symbol = payload.value("symbol").toString();
if (!symbol.isEmpty())
load_symbol(symbol);
});
diff --git a/fincept-qt/src/screens/equity_research/EquityTalippTab.cpp b/fincept-qt/src/screens/equity_research/EquityTalippTab.cpp
index 84d5bd6f7..e568120a4 100644
--- a/fincept-qt/src/screens/equity_research/EquityTalippTab.cpp
+++ b/fincept-qt/src/screens/equity_research/EquityTalippTab.cpp
@@ -423,7 +423,7 @@ void EquityTalippTab::on_compute_clicked() {
}
// ── rebuild_last_values ───────────────────────────────────────────────────────
-void EquityTalippTab::rebuild_last_values(const QString& indicator_id, const QVector<double>& values) {
+void EquityTalippTab::rebuild_last_values(const QString& /*indicator_id*/, const QVector<double>& values) {
auto* hl = qobject_cast<QHBoxLayout*>(last_values_area_->layout());
if (!hl)
return;
diff --git a/fincept-qt/src/screens/equity_research/EquityTechnicalsTab.cpp b/fincept-qt/src/screens/equity_research/EquityTechnicalsTab.cpp
index ad7c57493..ce3cacd98 100644
--- a/fincept-qt/src/screens/equity_research/EquityTechnicalsTab.cpp
+++ b/fincept-qt/src/screens/equity_research/EquityTechnicalsTab.cpp
@@ -392,20 +392,20 @@ void EquityTechnicalsTab::clear_sections() {
// ── populate ─────────────────────────────────────────────────────────────────
-void EquityTechnicalsTab::populate(const services::equity::TechnicalsData& data) {
+void EquityTechnicalsTab::populate(const services::equity::TechnicalsData& payload) {
clear_sections();
// Flatten all
QVector<services::equity::TechIndicator> all;
- all << data.trend << data.momentum << data.volatility << data.volume;
+ all << payload.trend << payload.momentum << payload.volatility << payload.volume;
// ── Rating ───────────────────────────────────────────────────────────────
- int sb = data.strong_buy, b = data.buy, n = data.neutral, s = data.sell, ss = data.strong_sell;
+ int sb = payload.strong_buy, b = payload.buy, n = payload.neutral, s = payload.sell, ss = payload.strong_sell;
int total = sb + b + n + s + ss;
const char* rec_color = GRAY;
- QString rec_text = signal_text(data.overall_signal);
- rec_color = signal_color(data.overall_signal);
+ QString rec_text = signal_text(payload.overall_signal);
+ rec_color = signal_color(payload.overall_signal);
rating_label_->setText(rec_text);
rating_label_->setStyleSheet(
@@ -502,10 +502,10 @@ void EquityTechnicalsTab::populate(const services::equity::TechnicalsData& data)
const char* color;
};
QList<CatDef> cats = {
- {"TREND INDICATORS", &data.trend, CYAN},
- {"MOMENTUM INDICATORS", &data.momentum, ui::colors::POSITIVE},
- {"VOLATILITY INDICATORS", &data.volatility, YELLOW},
- {"VOLUME INDICATORS", &data.volume, BLUE},
+ {"TREND INDICATORS", &payload.trend, CYAN},
+ {"MOMENTUM INDICATORS", &payload.momentum, ui::colors::POSITIVE},
+ {"VOLATILITY INDICATORS", &payload.volatility, YELLOW},
+ {"VOLUME INDICATORS", &payload.volume, BLUE},
};
for (const auto& cat : cats) {
@@ -671,11 +671,11 @@ void EquityTechnicalsTab::populate(const services::equity::TechnicalsData& data)
// ── on_technicals_loaded ─────────────────────────────────────────────────────
-void EquityTechnicalsTab::on_technicals_loaded(services::equity::TechnicalsData data) {
- if (data.symbol != current_symbol_)
+void EquityTechnicalsTab::on_technicals_loaded(services::equity::TechnicalsData payload) {
+ if (payload.symbol != current_symbol_)
return;
loading_overlay_->hide_loading();
- populate(data);
+ populate(payload);
}
} // namespace fincept::screens
diff --git a/fincept-qt/src/screens/equity_trading/AccountManagementDialog.cpp b/fincept-qt/src/screens/equity_trading/AccountManagementDialog.cpp
index 583abdc40..76e177492 100644
--- a/fincept-qt/src/screens/equity_trading/AccountManagementDialog.cpp
+++ b/fincept-qt/src/screens/equity_trading/AccountManagementDialog.cpp
@@ -457,7 +457,7 @@ void AccountManagementDialog::on_connect_account() {
const QString auth_code_val = auth_code;
const QString existing_additional = creds.additional_data;
- QtConcurrent::run([self, broker, account_id, api_key_val, api_secret_val, auth_code_val, existing_additional]() {
+ (void)QtConcurrent::run([self, broker, account_id, api_key_val, api_secret_val, auth_code_val, existing_additional]() {
auto result = broker->exchange_token(api_key_val, api_secret_val, auth_code_val);
QMetaObject::invokeMethod(
@@ -750,7 +750,7 @@ void AccountManagementDialog::on_connect_zerodha_totp() {
const QString acct = selected_account_id_;
QPointer<AccountManagementDialog> self = this;
- QtConcurrent::run([self, acct, user_id, password, api_key, api_secret, totp_secret]() {
+ (void)QtConcurrent::run([self, acct, user_id, password, api_key, api_secret, totp_secret]() {
trading::ZerodhaBroker broker;
auto stage_cb = [self](const QString& stage) {
QMetaObject::invokeMethod(qApp, [self, stage]() {
@@ -895,7 +895,7 @@ void AccountManagementDialog::exchange_and_store_token_async(const QString& api_
const QString acct = selected_account_id_;
QPointer<AccountManagementDialog> self = this;
- QtConcurrent::run([self, acct, api_key, api_secret, request_token]() {
+ (void)QtConcurrent::run([self, acct, api_key, api_secret, request_token]() {
trading::ZerodhaBroker broker;
auto result = broker.exchange_token(api_key, api_secret, request_token);
diff --git a/fincept-qt/src/screens/equity_trading/BroadcastOrderDialog.cpp b/fincept-qt/src/screens/equity_trading/BroadcastOrderDialog.cpp
index f363a7bd1..69db294e8 100644
--- a/fincept-qt/src/screens/equity_trading/BroadcastOrderDialog.cpp
+++ b/fincept-qt/src/screens/equity_trading/BroadcastOrderDialog.cpp
@@ -178,7 +178,7 @@ void BroadcastOrderDialog::on_place_order() {
// Run broadcast on background thread (P1: never block UI)
QPointer<BroadcastOrderDialog> self = this;
auto order_copy = order_;
- QtConcurrent::run([self, selected, order_copy]() {
+ (void)QtConcurrent::run([self, selected, order_copy]() {
auto results = UnifiedTrading::instance().broadcast_order(selected, order_copy);
QMetaObject::invokeMethod(
self,
diff --git a/fincept-qt/src/screens/equity_trading/EquityOrderBook.cpp b/fincept-qt/src/screens/equity_trading/EquityOrderBook.cpp
index 9f8b5eed7..45ee3355d 100644
--- a/fincept-qt/src/screens/equity_trading/EquityOrderBook.cpp
+++ b/fincept-qt/src/screens/equity_trading/EquityOrderBook.cpp
@@ -138,7 +138,6 @@ void EquityOrderBook::rebuild_cache() {
const int half = h / 2;
const int col_price = 4;
const int col_qty = w / 2;
- const int col_total = w * 3 / 4;
// Find max quantity for bar scaling
double max_qty = 1.0;
diff --git a/fincept-qt/src/screens/equity_trading/EquityOrderEntry.cpp b/fincept-qt/src/screens/equity_trading/EquityOrderEntry.cpp
index a5a34d674..b4c589c55 100644
--- a/fincept-qt/src/screens/equity_trading/EquityOrderEntry.cpp
+++ b/fincept-qt/src/screens/equity_trading/EquityOrderEntry.cpp
@@ -476,7 +476,7 @@ void EquityOrderEntry::fetch_margin_async() {
const QString bid = broker_id_;
QPointer<EquityOrderEntry> self = this;
- QtConcurrent::run([self, bid, order]() {
+ (void)QtConcurrent::run([self, bid, order]() {
auto* broker = trading::BrokerRegistry::instance().get(bid);
if (!broker) {
if (self)
diff --git a/fincept-qt/src/screens/equity_trading/EquityTradingScreen.cpp b/fincept-qt/src/screens/equity_trading/EquityTradingScreen.cpp
index 8ce1b60f9..3b3759a8f 100644
--- a/fincept-qt/src/screens/equity_trading/EquityTradingScreen.cpp
+++ b/fincept-qt/src/screens/equity_trading/EquityTradingScreen.cpp
@@ -947,7 +947,7 @@ void EquityTradingScreen::on_order_submitted(const UnifiedOrder& order) {
const QString acct_id = focused_account_id_;
QPointer<EquityTradingScreen> self = this;
auto order_copy = order;
- QtConcurrent::run([self, acct_id, order_copy]() {
+ (void)QtConcurrent::run([self, acct_id, order_copy]() {
if (!self)
return;
auto result = UnifiedTrading::instance().place_order(acct_id, order_copy);
@@ -997,7 +997,7 @@ void EquityTradingScreen::on_cancel_order(const QString& order_id) {
} else {
const QString acct_id = focused_account_id_;
QPointer<EquityTradingScreen> self = this;
- QtConcurrent::run([self, acct_id, order_id]() {
+ (void)QtConcurrent::run([self, acct_id, order_id]() {
if (!self)
return;
UnifiedTrading::instance().cancel_order(acct_id, order_id);
@@ -1018,7 +1018,7 @@ void EquityTradingScreen::refresh_candles() {
void EquityTradingScreen::async_modify_order(const QString& order_id, double qty, double price) {
const QString acct_id = focused_account_id_;
QPointer<EquityTradingScreen> self = this;
- QtConcurrent::run([self, acct_id, order_id, qty, price]() {
+ (void)QtConcurrent::run([self, acct_id, order_id, qty, price]() {
if (!self)
return;
QJsonObject mods;
diff --git a/fincept-qt/src/screens/excel/ExcelScreen.cpp b/fincept-qt/src/screens/excel/ExcelScreen.cpp
index 0b0ad2705..37c88c072 100644
--- a/fincept-qt/src/screens/excel/ExcelScreen.cpp
+++ b/fincept-qt/src/screens/excel/ExcelScreen.cpp
@@ -218,15 +218,15 @@ void ExcelScreen::on_import() {
auto* sheet = new SpreadsheetWidget(name, max_row, max_col, sheet_tabs_);
// Load data
- QVector<QVector<QString>> data(max_row);
+ QVector<QVector<QString>> cells(max_row);
for (int r = 0; r < max_row; ++r) {
- data[r].resize(max_col);
+ cells[r].resize(max_col);
for (int c = 0; c < max_col; ++c) {
auto cell = xlsx.read(r + 1, c + 1); // QXlsx is 1-based
- data[r][c] = cell.isValid() ? cell.toString() : "";
+ cells[r][c] = cell.isValid() ? cell.toString() : "";
}
}
- sheet->set_data(data);
+ sheet->set_data(cells);
sheet_tabs_->addTab(sheet, name);
}
@@ -276,10 +276,10 @@ void ExcelScreen::on_export() {
// Rename sheet
xlsx.renameSheet(xlsx.sheetNames().last(), sheet->sheet_name());
- auto data = sheet->get_data();
- for (int r = 0; r < data.size(); ++r) {
- for (int c = 0; c < data[r].size(); ++c) {
- const QString& val = data[r][c];
+ auto cells = sheet->get_data();
+ for (int r = 0; r < cells.size(); ++r) {
+ for (int c = 0; c < cells[r].size(); ++c) {
+ const QString& val = cells[r][c];
if (val.isEmpty())
continue;
@@ -336,14 +336,14 @@ void ExcelScreen::on_export_csv() {
return;
QTextStream out(&file);
- auto data = sheet->get_data();
+ auto cells = sheet->get_data();
// Find the last row/col with data to avoid huge trailing empty rows
int last_row = 0;
int last_col = 0;
- for (int r = 0; r < data.size(); ++r) {
- for (int c = 0; c < data[r].size(); ++c) {
- if (!data[r][c].isEmpty()) {
+ for (int r = 0; r < cells.size(); ++r) {
+ for (int c = 0; c < cells[r].size(); ++c) {
+ if (!cells[r][c].isEmpty()) {
last_row = std::max(last_row, r);
last_col = std::max(last_col, c);
}
@@ -353,7 +353,7 @@ void ExcelScreen::on_export_csv() {
for (int r = 0; r <= last_row; ++r) {
QStringList row;
for (int c = 0; c <= last_col; ++c) {
- QString val = (c < data[r].size()) ? data[r][c] : "";
+ QString val = (c < cells[r].size()) ? cells[r][c] : "";
if (val.contains(',') || val.contains('"') || val.contains('\n'))
val = "\"" + val.replace("\"", "\"\"") + "\"";
row << val;
diff --git a/fincept-qt/src/screens/excel/SpreadsheetWidget.cpp b/fincept-qt/src/screens/excel/SpreadsheetWidget.cpp
index bcc9ebd43..8208509a6 100644
--- a/fincept-qt/src/screens/excel/SpreadsheetWidget.cpp
+++ b/fincept-qt/src/screens/excel/SpreadsheetWidget.cpp
@@ -77,8 +77,8 @@ double SpreadsheetItem::resolve_cell_value(int row, int col) const {
QVariant val = item->data(Qt::DisplayRole);
bool ok = false;
- double d = val.toDouble(&ok);
- return ok ? d : 0.0;
+ double dv = val.toDouble(&ok);
+ return ok ? dv : 0.0;
}
QVector<double> SpreadsheetItem::resolve_range(const QString& from, const QString& to) const {
@@ -94,14 +94,14 @@ QVector<double> SpreadsheetItem::resolve_range(const QString& from, const QStrin
if (c1 > c2)
std::swap(c1, c2);
- QVector<double> values;
+ QVector<double> out;
for (int r = r1; r <= r2; ++r) {
for (int c = c1; c <= c2; ++c) {
double v = resolve_cell_value(r, c);
- values.append(v);
+ out.append(v);
}
}
- return values;
+ return out;
}
QVariant SpreadsheetItem::evaluate_formula() const {
@@ -115,20 +115,20 @@ QVariant SpreadsheetItem::evaluate_formula() const {
auto fm = func_re.match(expr);
if (fm.hasMatch()) {
QString func = fm.captured(1);
- auto values = resolve_range(fm.captured(2), fm.captured(3));
- if (values.isEmpty())
+ auto vals = resolve_range(fm.captured(2), fm.captured(3));
+ if (vals.isEmpty())
return 0.0;
if (func == "SUM")
- return std::accumulate(values.begin(), values.end(), 0.0);
+ return std::accumulate(vals.begin(), vals.end(), 0.0);
if (func == "AVG" || func == "AVERAGE")
- return std::accumulate(values.begin(), values.end(), 0.0) / values.size();
+ return std::accumulate(vals.begin(), vals.end(), 0.0) / vals.size();
if (func == "MIN")
- return *std::min_element(values.begin(), values.end());
+ return *std::min_element(vals.begin(), vals.end());
if (func == "MAX")
- return *std::max_element(values.begin(), values.end());
+ return *std::max_element(vals.begin(), vals.end());
if (func == "COUNT")
- return static_cast<double>(values.size());
+ return static_cast<double>(vals.size());
}
// ── Simple cell reference: =A1 ───────────────────────────────────────
@@ -380,22 +380,22 @@ QString SpreadsheetWidget::column_label(int col) {
QVector<QVector<QString>> SpreadsheetWidget::get_data() const {
int rows = table_->rowCount();
int cols = table_->columnCount();
- QVector<QVector<QString>> data(rows);
+ QVector<QVector<QString>> cells(rows);
for (int r = 0; r < rows; ++r) {
- data[r].resize(cols);
+ cells[r].resize(cols);
for (int c = 0; c < cols; ++c) {
auto* item = dynamic_cast<SpreadsheetItem*>(table_->item(r, c));
- data[r][c] = item ? item->raw_text() : "";
+ cells[r][c] = item ? item->raw_text() : "";
}
}
- return data;
+ return cells;
}
-void SpreadsheetWidget::set_data(const QVector<QVector<QString>>& data) {
+void SpreadsheetWidget::set_data(const QVector<QVector<QString>>& cells) {
table_->blockSignals(true);
- int rows = data.size();
- int cols = rows > 0 ? data[0].size() : 26;
+ int rows = cells.size();
+ int cols = rows > 0 ? cells[0].size() : 26;
// Ensure minimum size
rows = std::max(rows, 100);
@@ -408,8 +408,8 @@ void SpreadsheetWidget::set_data(const QVector<QVector<QString>>& data) {
for (int r = 0; r < rows; ++r) {
for (int c = 0; c < cols; ++c) {
QString text;
- if (r < data.size() && c < data[r].size()) {
- text = data[r][c];
+ if (r < cells.size() && c < cells[r].size()) {
+ text = cells[r][c];
}
auto* item = new SpreadsheetItem(text);
table_->setItem(r, c, item);
diff --git a/fincept-qt/src/screens/geopolitics/ConflictMonitorPanel.cpp b/fincept-qt/src/screens/geopolitics/ConflictMonitorPanel.cpp
index 09f92a7f6..94acffb3b 100644
--- a/fincept-qt/src/screens/geopolitics/ConflictMonitorPanel.cpp
+++ b/fincept-qt/src/screens/geopolitics/ConflictMonitorPanel.cpp
@@ -40,7 +40,7 @@ void ConflictMonitorPanel::build_ui() {
// ── Events Table ────────────────────────────────────────────────────────
events_table_ = new QTableWidget(left_splitter);
events_table_->setColumnCount(7);
- events_table_->setHorizontalHeaderLabels({"Category", "Country", "City", "Keywords", "Date", "Lat", "Lng"});
+ events_table_->setHorizontalHeaderLabels({"Category", "Country", "City", "Title", "Date", "Lat", "Lng"});
events_table_->setEditTriggers(QAbstractItemView::NoEditTriggers);
events_table_->setSelectionBehavior(QAbstractItemView::SelectRows);
events_table_->setAlternatingRowColors(true);
@@ -87,6 +87,8 @@ void ConflictMonitorPanel::build_ui() {
detail_city_->setText(get_text(2));
detail_keywords_->setText(get_text(3));
detail_date_->setText(get_text(4));
+ if (auto* it = events_table_->item(row, 3); it && detail_source_)
+ detail_source_->setText(it->data(Qt::UserRole).toString());
auto cat_color = category_color(get_text(0));
detail_category_->setStyleSheet(QString("color:%1; font-size:%2px; font-weight:700; font-family:%3;")
@@ -182,7 +184,7 @@ void ConflictMonitorPanel::build_ui() {
};
FieldDef fields[] = {
{"CATEGORY", &detail_category_}, {"COUNTRY", &detail_country_}, {"CITY", &detail_city_},
- {"KEYWORDS", &detail_keywords_}, {"DATE", &detail_date_}, {"SOURCE", &detail_source_},
+ {"TITLE", &detail_keywords_}, {"DATE", &detail_date_}, {"SOURCE", &detail_source_},
};
for (int r = 0; r < 6; ++r) {
@@ -217,14 +219,17 @@ void ConflictMonitorPanel::set_events(const QVector<NewsEvent>& events) {
events_table_->setItem(i, 1, new QTableWidgetItem(ev.country));
events_table_->setItem(i, 2, new QTableWidgetItem(ev.city));
- events_table_->setItem(i, 3, new QTableWidgetItem(ev.matched_keywords));
+ auto* title_item = new QTableWidgetItem(ev.title);
+ title_item->setData(Qt::UserRole, ev.source);
+ title_item->setToolTip(ev.title);
+ events_table_->setItem(i, 3, title_item);
events_table_->setItem(i, 4, new QTableWidgetItem(ev.extracted_date));
- auto* lat_item = new QTableWidgetItem(QString::number(ev.latitude, 'f', 4));
+ auto* lat_item = new QTableWidgetItem(ev.has_coords ? QString::number(ev.latitude, 'f', 4) : QString());
lat_item->setTextAlignment(Qt::AlignRight | Qt::AlignVCenter);
events_table_->setItem(i, 5, lat_item);
- auto* lng_item = new QTableWidgetItem(QString::number(ev.longitude, 'f', 4));
+ auto* lng_item = new QTableWidgetItem(ev.has_coords ? QString::number(ev.longitude, 'f', 4) : QString());
lng_item->setTextAlignment(Qt::AlignRight | Qt::AlignVCenter);
events_table_->setItem(i, 6, lng_item);
}
@@ -239,11 +244,10 @@ void ConflictMonitorPanel::update_map(const QVector<NewsEvent>& events) {
pins.reserve(events.size());
QHash<QString, int> coord_counts;
- auto* rng = QRandomGenerator::global();
int skipped = 0;
for (const auto& ev : events) {
- if (ev.latitude == 0.0 && ev.longitude == 0.0) {
+ if (!ev.has_coords) {
++skipped;
continue;
}
diff --git a/fincept-qt/src/screens/geopolitics/TradeAnalysisPanel.cpp b/fincept-qt/src/screens/geopolitics/TradeAnalysisPanel.cpp
index a7ec43689..33446513a 100644
--- a/fincept-qt/src/screens/geopolitics/TradeAnalysisPanel.cpp
+++ b/fincept-qt/src/screens/geopolitics/TradeAnalysisPanel.cpp
@@ -431,7 +431,7 @@ void TradeAnalysisPanel::build_ui() {
root->addWidget(scroll, 1);
}
-void TradeAnalysisPanel::display_result(const QJsonObject& data) {
+void TradeAnalysisPanel::display_result(const QJsonObject& payload) {
while (results_layout_->count() > 0) {
auto* item = results_layout_->takeAt(0);
if (item->widget())
@@ -474,7 +474,7 @@ void TradeAnalysisPanel::display_result(const QJsonObject& data) {
}
}
};
- flatten(data, "");
+ flatten(payload, "");
auto* table = new QTableWidget(rows.size(), 2);
table->setHorizontalHeaderLabels({"Metric", "Value"});
@@ -509,9 +509,9 @@ void TradeAnalysisPanel::display_result(const QJsonObject& data) {
status_label_->setText(QString("%1 fields").arg(rows.size()));
}
-void TradeAnalysisPanel::on_trade_result(const QString& context, const QJsonObject& data) {
+void TradeAnalysisPanel::on_trade_result(const QString& context, const QJsonObject& payload) {
if (context == "trade_benefits" || context == "trade_restrictions")
- display_result(data);
+ display_result(payload);
}
void TradeAnalysisPanel::on_error(const QString& context, const QString& message) {
diff --git a/fincept-qt/src/screens/gov_data/GovDataAustraliaPanel.cpp b/fincept-qt/src/screens/gov_data/GovDataAustraliaPanel.cpp
index fd2e2ccec..9b9addbd4 100644
--- a/fincept-qt/src/screens/gov_data/GovDataAustraliaPanel.cpp
+++ b/fincept-qt/src/screens/gov_data/GovDataAustraliaPanel.cpp
@@ -281,32 +281,32 @@ void GovDataAustraliaPanel::on_result(const QString& request_id, const services:
if (request_id == "ausgov_agencies") {
// Agencies: {data:[{id, name, title, description, created, dataset_count, ...}]}
- QJsonArray data;
+ QJsonArray payload;
const QJsonValue raw = result.data["data"];
if (raw.isArray())
- data = raw.toArray();
+ payload = raw.toArray();
- current_agencies_ = data;
- populate_agencies(data);
+ current_agencies_ = payload;
+ populate_agencies(payload);
current_view_ = Agencies;
content_stack_->setCurrentIndex(Agencies);
- LOG_INFO("GovDataAustraliaPanel", "Loaded " + QString::number(data.size()) + " agencies");
+ LOG_INFO("GovDataAustraliaPanel", "Loaded " + QString::number(payload.size()) + " agencies");
} else if (request_id.startsWith("ausgov_datasets_") || request_id.startsWith("ausgov_search_") ||
request_id == "ausgov_recent") {
int total = 0;
- const QJsonArray data = unwrap_datasets(result, total);
+ const QJsonArray payload = unwrap_datasets(result, total);
- current_datasets_ = data;
+ current_datasets_ = payload;
showing_recent_ = (request_id == "ausgov_recent");
- populate_datasets(data, total);
+ populate_datasets(payload, total);
current_view_ = Datasets;
content_stack_->setCurrentIndex(Datasets);
LOG_INFO("GovDataAustraliaPanel",
- "Loaded " + QString::number(data.size()) + " datasets" + (showing_recent_ ? " (recent)" : ""));
+ "Loaded " + QString::number(payload.size()) + " datasets" + (showing_recent_ ? " (recent)" : ""));
}
update_toolbar_state();
@@ -315,12 +315,12 @@ void GovDataAustraliaPanel::on_result(const QString& request_id, const services:
// ── Populate tables ───────────────────────────────────────────────────────────
-void GovDataAustraliaPanel::populate_agencies(const QJsonArray& data) {
+void GovDataAustraliaPanel::populate_agencies(const QJsonArray& json) {
agencies_table_->setRowCount(0);
- agencies_table_->setRowCount(data.size());
+ agencies_table_->setRowCount(json.size());
- for (int i = 0; i < data.size(); ++i) {
- const auto obj = data[i].toObject();
+ for (int i = 0; i < json.size(); ++i) {
+ const auto obj = json[i].toObject();
// Prefer display_name → title → name
QString name = obj["display_name"].toString();
@@ -354,15 +354,15 @@ void GovDataAustraliaPanel::populate_agencies(const QJsonArray& data) {
agencies_table_->setItem(i, 2, created_item);
}
- row_count_label_->setText(QString::number(data.size()) + " agencies");
+ row_count_label_->setText(QString::number(json.size()) + " agencies");
}
-void GovDataAustraliaPanel::populate_datasets(const QJsonArray& data, int total_count) {
+void GovDataAustraliaPanel::populate_datasets(const QJsonArray& json, int total_count) {
datasets_table_->setRowCount(0);
- datasets_table_->setRowCount(data.size());
+ datasets_table_->setRowCount(json.size());
- for (int i = 0; i < data.size(); ++i) {
- const auto obj = data[i].toObject();
+ for (int i = 0; i < json.size(); ++i) {
+ const auto obj = json[i].toObject();
QString title = obj["title"].toString();
if (title.isEmpty())
@@ -416,7 +416,7 @@ void GovDataAustraliaPanel::populate_datasets(const QJsonArray& data, int total_
datasets_table_->setItem(i, 4, mod_item);
}
- row_count_label_->setText(QString("Showing %1 of %2").arg(data.size()).arg(total_count));
+ row_count_label_->setText(QString("Showing %1 of %2").arg(json.size()).arg(total_count));
}
void GovDataAustraliaPanel::populate_resources(const QJsonArray& resources) {
diff --git a/fincept-qt/src/screens/gov_data/GovDataCongressPanel.cpp b/fincept-qt/src/screens/gov_data/GovDataCongressPanel.cpp
index fff070c25..85860e9ff 100644
--- a/fincept-qt/src/screens/gov_data/GovDataCongressPanel.cpp
+++ b/fincept-qt/src/screens/gov_data/GovDataCongressPanel.cpp
@@ -275,8 +275,8 @@ void GovDataCongressPanel::on_result(const QString& request_id, const services::
// ── Populate ─────────────────────────────────────────────────────────────────
-void GovDataCongressPanel::populate_bills(const QJsonObject& data) {
- const QJsonArray bills = data["bills"].toArray();
+void GovDataCongressPanel::populate_bills(const QJsonObject& json) {
+ const QJsonArray bills = json["bills"].toArray();
bills_table_->setRowCount(0);
bills_table_->setRowCount(bills.size());
@@ -310,10 +310,10 @@ void GovDataCongressPanel::populate_bills(const QJsonObject& data) {
LOG_INFO("GovCongress", QString("Loaded %1 bills").arg(bills.size()));
}
-void GovDataCongressPanel::populate_bill_detail(const QJsonObject& data) {
- QString md = data["markdown_content"].toString();
+void GovDataCongressPanel::populate_bill_detail(const QJsonObject& json) {
+ QString md = json["markdown_content"].toString();
if (md.isEmpty()) {
- auto bill = data["bill_data"].toObject();
+ auto bill = json["bill_data"].toObject();
md = "# " + bill["title"].toString() + "\n\n";
md += "**Type:** " + bill["type"].toString() + "\n\n";
md += "**Congress:** " + QString::number(bill["congress"].toInt()) + "\n\n";
@@ -337,8 +337,8 @@ void GovDataCongressPanel::populate_bill_detail(const QJsonObject& data) {
current_view_ = BillDetail;
}
-void GovDataCongressPanel::populate_summary(const QJsonObject& data) {
- auto bill_types = data["bill_types"].toObject();
+void GovDataCongressPanel::populate_summary(const QJsonObject& json) {
+ auto bill_types = json["bill_types"].toObject();
summary_table_->setRowCount(0);
summary_table_->setRowCount(bill_types.size());
diff --git a/fincept-qt/src/screens/gov_data/GovDataFrancePanel.cpp b/fincept-qt/src/screens/gov_data/GovDataFrancePanel.cpp
index ad1f4b856..4715cff4c 100644
--- a/fincept-qt/src/screens/gov_data/GovDataFrancePanel.cpp
+++ b/fincept-qt/src/screens/gov_data/GovDataFrancePanel.cpp
@@ -327,21 +327,21 @@ void GovDataFrancePanel::on_result(const QString& request_id, const services::Go
return;
}
- QJsonArray data = result.data["data"].toArray();
+ QJsonArray payload = result.data["data"].toArray();
if (request_id == "fr_services") {
- current_services_ = data;
- populate_services(data);
+ current_services_ = payload;
+ populate_services(payload);
current_view_ = Services;
services_btn_->setChecked(true);
datasets_btn_->setChecked(false);
geo_btn_->setChecked(false);
content_stack_->setCurrentIndex(Services);
update_breadcrumb("Data Services");
- row_count_label_->setText(QString::number(data.size()) + " services");
+ row_count_label_->setText(QString::number(payload.size()) + " services");
} else if (request_id == "fr_datasets") {
- current_datasets_ = data;
- populate_datasets(data);
+ current_datasets_ = payload;
+ populate_datasets(payload);
current_view_ = Datasets;
datasets_btn_->setChecked(true);
services_btn_->setChecked(false);
@@ -350,10 +350,10 @@ void GovDataFrancePanel::on_result(const QString& request_id, const services::Go
update_breadcrumb("Datasets › "
" + search_query_ + "
"");
- row_count_label_->setText(QString::number(data.size()) + " datasets");
+ row_count_label_->setText(QString::number(payload.size()) + " datasets");
} else if (request_id == "fr_geo") {
- current_geo_ = data;
- populate_geo(data);
+ current_geo_ = payload;
+ populate_geo(payload);
current_view_ = Geo;
geo_btn_->setChecked(true);
services_btn_->setChecked(false);
@@ -362,14 +362,14 @@ void GovDataFrancePanel::on_result(const QString& request_id, const services::Go
update_breadcrumb("Municipalities › "
" + search_query_ + "
"");
- row_count_label_->setText(QString::number(data.size()) + " results");
+ row_count_label_->setText(QString::number(payload.size()) + " results");
} else if (request_id == "fr_resources") {
- current_resources_ = data;
- populate_resources(data);
+ current_resources_ = payload;
+ populate_resources(payload);
current_view_ = Resources;
content_stack_->setCurrentIndex(Resources);
update_breadcrumb("Datasets › Column Schema");
- row_count_label_->setText(QString::number(data.size()) + " columns");
+ row_count_label_->setText(QString::number(payload.size()) + " columns");
}
update_toolbar_state();
@@ -377,12 +377,12 @@ void GovDataFrancePanel::on_result(const QString& request_id, const services::Go
// ── Populate tables ───────────────────────────────────────────────────────────
-void GovDataFrancePanel::populate_services(const QJsonArray& data) {
+void GovDataFrancePanel::populate_services(const QJsonArray& json) {
services_table_->setRowCount(0);
- services_table_->setRowCount(data.size());
+ services_table_->setRowCount(json.size());
- for (int i = 0; i < data.size(); ++i) {
- const auto obj = data[i].toObject();
+ for (int i = 0; i < json.size(); ++i) {
+ const auto obj = json[i].toObject();
QString name = obj["display_name"].toString();
if (name.isEmpty())
@@ -416,15 +416,15 @@ void GovDataFrancePanel::populate_services(const QJsonArray& data) {
services_table_->setItem(i, 3, dt);
}
- LOG_INFO("GovFrance", QString("Populated %1 data services").arg(data.size()));
+ LOG_INFO("GovFrance", QString("Populated %1 json services").arg(json.size()));
}
-void GovDataFrancePanel::populate_datasets(const QJsonArray& data) {
+void GovDataFrancePanel::populate_datasets(const QJsonArray& json) {
datasets_table_->setRowCount(0);
- datasets_table_->setRowCount(data.size());
+ datasets_table_->setRowCount(json.size());
- for (int i = 0; i < data.size(); ++i) {
- const auto obj = data[i].toObject();
+ for (int i = 0; i < json.size(); ++i) {
+ const auto obj = json[i].toObject();
QString title = obj["title"].toString();
if (title.isEmpty())
@@ -464,15 +464,15 @@ void GovDataFrancePanel::populate_datasets(const QJsonArray& data) {
datasets_table_->setItem(i, 4, new QTableWidgetItem(modified));
}
- LOG_INFO("GovFrance", QString("Populated %1 datasets").arg(data.size()));
+ LOG_INFO("GovFrance", QString("Populated %1 datasets").arg(json.size()));
}
-void GovDataFrancePanel::populate_geo(const QJsonArray& data) {
+void GovDataFrancePanel::populate_geo(const QJsonArray& json) {
geo_table_->setRowCount(0);
- geo_table_->setRowCount(data.size());
+ geo_table_->setRowCount(json.size());
- for (int i = 0; i < data.size(); ++i) {
- const auto obj = data[i].toObject();
+ for (int i = 0; i < json.size(); ++i) {
+ const auto obj = json[i].toObject();
auto* name_item = new QTableWidgetItem(obj["name"].toString());
name_item->setForeground(QColor(kGovDataFranceColor));
@@ -498,15 +498,15 @@ void GovDataFrancePanel::populate_geo(const QJsonArray& data) {
geo_table_->setItem(i, 5, pop_item);
}
- LOG_INFO("GovFrance", QString("Populated %1 municipalities").arg(data.size()));
+ LOG_INFO("GovFrance", QString("Populated %1 municipalities").arg(json.size()));
}
-void GovDataFrancePanel::populate_resources(const QJsonArray& data) {
+void GovDataFrancePanel::populate_resources(const QJsonArray& json) {
resources_table_->setRowCount(0);
- resources_table_->setRowCount(data.size());
+ resources_table_->setRowCount(json.size());
- for (int i = 0; i < data.size(); ++i) {
- const auto obj = data[i].toObject();
+ for (int i = 0; i < json.size(); ++i) {
+ const auto obj = json[i].toObject();
// Schema rows: name = column name, format = type
auto* col_item = new QTableWidgetItem(obj["name"].toString());
@@ -520,7 +520,7 @@ void GovDataFrancePanel::populate_resources(const QJsonArray& data) {
resources_table_->setItem(i, 1, type_item);
}
- LOG_INFO("GovFrance", QString("Populated %1 schema columns").arg(data.size()));
+ LOG_INFO("GovFrance", QString("Populated %1 schema columns").arg(json.size()));
}
// ── Status helpers ────────────────────────────────────────────────────────────
diff --git a/fincept-qt/src/screens/gov_data/GovDataHKPanel.cpp b/fincept-qt/src/screens/gov_data/GovDataHKPanel.cpp
index f4c1a8d7f..93047cd4a 100644
--- a/fincept-qt/src/screens/gov_data/GovDataHKPanel.cpp
+++ b/fincept-qt/src/screens/gov_data/GovDataHKPanel.cpp
@@ -359,20 +359,20 @@ void GovDataHKPanel::on_result(const QString& request_id, const services::GovDat
return;
}
- QJsonArray data = result.data["data"].toArray();
+ QJsonArray payload = result.data["data"].toArray();
if (request_id == "hk_categories") {
- current_categories_ = data;
- populate_categories(data);
+ current_categories_ = payload;
+ populate_categories(payload);
current_view_ = Categories;
categories_btn_->setChecked(true);
datasets_btn_->setChecked(false);
content_stack_->setCurrentIndex(Categories);
update_breadcrumb("Categories");
- row_count_label_->setText(QString::number(data.size()) + " categories");
+ row_count_label_->setText(QString::number(payload.size()) + " categories");
} else if (request_id == "hk_datasets") {
- if (data.isEmpty()) {
+ if (payload.isEmpty()) {
// HK category_datasets frequently returns empty — show note
show_status("HK DATA — Categories may have limited datasets\n\n"
"No datasets found for "
@@ -384,8 +384,8 @@ void GovDataHKPanel::on_result(const QString& request_id, const services::GovDat
" returned 0 datasets");
return;
}
- current_datasets_ = data;
- populate_datasets(data);
+ current_datasets_ = payload;
+ populate_datasets(payload);
current_view_ = Datasets;
categories_btn_->setChecked(false);
datasets_btn_->setChecked(true);
@@ -393,13 +393,13 @@ void GovDataHKPanel::on_result(const QString& request_id, const services::GovDat
int total = result.data["metadata"].toObject()["total_count"].toInt(0);
if (total == 0)
- total = data.size();
+ total = payload.size();
update_breadcrumb("Datasets › " + selected_category_name_);
- row_count_label_->setText(QString("Showing %1 of %2").arg(data.size()).arg(total));
+ row_count_label_->setText(QString("Showing %1 of %2").arg(payload.size()).arg(total));
} else if (request_id == "hk_datasets_list") {
// Full dataset name list for client-side search
- all_dataset_names_ = data;
+ all_dataset_names_ = payload;
QString query = search_input_->text().trimmed();
if (!query.isEmpty())
filter_datasets_list(query);
@@ -407,12 +407,12 @@ void GovDataHKPanel::on_result(const QString& request_id, const services::GovDat
show_status("Dataset list loaded. Type a search term and click FETCH.");
} else if (request_id == "hk_resources") {
- current_resources_ = data;
- populate_resources(data);
+ current_resources_ = payload;
+ populate_resources(payload);
current_view_ = Resources;
content_stack_->setCurrentIndex(Resources);
update_breadcrumb("Datasets › Resources");
- row_count_label_->setText(QString::number(data.size()) + " files");
+ row_count_label_->setText(QString::number(payload.size()) + " files");
}
update_toolbar_state();
@@ -420,12 +420,12 @@ void GovDataHKPanel::on_result(const QString& request_id, const services::GovDat
// ── Populate tables ───────────────────────────────────────────────────────────
-void GovDataHKPanel::populate_categories(const QJsonArray& data) {
+void GovDataHKPanel::populate_categories(const QJsonArray& json) {
categories_table_->setRowCount(0);
- categories_table_->setRowCount(data.size());
+ categories_table_->setRowCount(json.size());
- for (int i = 0; i < data.size(); ++i) {
- const auto obj = data[i].toObject();
+ for (int i = 0; i < json.size(); ++i) {
+ const auto obj = json[i].toObject();
QString name = obj["display_name"].toString();
if (name.isEmpty())
@@ -440,15 +440,15 @@ void GovDataHKPanel::populate_categories(const QJsonArray& data) {
categories_table_->setItem(i, 0, name_item);
}
- LOG_INFO("GovHK", QString("Populated %1 categories").arg(data.size()));
+ LOG_INFO("GovHK", QString("Populated %1 categories").arg(json.size()));
}
-void GovDataHKPanel::populate_datasets(const QJsonArray& data) {
+void GovDataHKPanel::populate_datasets(const QJsonArray& json) {
datasets_table_->setRowCount(0);
- datasets_table_->setRowCount(data.size());
+ datasets_table_->setRowCount(json.size());
- for (int i = 0; i < data.size(); ++i) {
- const auto obj = data[i].toObject();
+ for (int i = 0; i < json.size(); ++i) {
+ const auto obj = json[i].toObject();
QString title = obj["title"].toString();
if (title.isEmpty())
@@ -474,15 +474,15 @@ void GovDataHKPanel::populate_datasets(const QJsonArray& data) {
datasets_table_->setItem(i, 2, new QTableWidgetItem(modified));
}
- LOG_INFO("GovHK", QString("Populated %1 datasets").arg(data.size()));
+ LOG_INFO("GovHK", QString("Populated %1 datasets").arg(json.size()));
}
-void GovDataHKPanel::populate_resources(const QJsonArray& data) {
+void GovDataHKPanel::populate_resources(const QJsonArray& json) {
resources_table_->setRowCount(0);
- resources_table_->setRowCount(data.size());
+ resources_table_->setRowCount(json.size());
- for (int i = 0; i < data.size(); ++i) {
- const auto obj = data[i].toObject();
+ for (int i = 0; i < json.size(); ++i) {
+ const auto obj = json[i].toObject();
QString name = obj["name"].toString();
if (name.isEmpty())
@@ -509,7 +509,7 @@ void GovDataHKPanel::populate_resources(const QJsonArray& data) {
resources_table_->setItem(i, 2, mod_item);
}
- LOG_INFO("GovHK", QString("Populated %1 resources").arg(data.size()));
+ LOG_INFO("GovHK", QString("Populated %1 resources").arg(json.size()));
}
// ── Status helpers ────────────────────────────────────────────────────────────
diff --git a/fincept-qt/src/screens/gov_data/GovDataProviderPanel.cpp b/fincept-qt/src/screens/gov_data/GovDataProviderPanel.cpp
index 35322ee0f..a858a4dbf 100644
--- a/fincept-qt/src/screens/gov_data/GovDataProviderPanel.cpp
+++ b/fincept-qt/src/screens/gov_data/GovDataProviderPanel.cpp
@@ -372,21 +372,21 @@ void GovDataProviderPanel::on_result(const QString& request_id, const services::
// Some scripts (Australia search/org-datasets) return data as {"datasets":[...], "count":...}
// instead of a flat array. Unwrap if needed.
- QJsonArray data;
+ QJsonArray payload;
QJsonValue raw = result.data["data"];
if (raw.isArray()) {
- data = raw.toArray();
+ payload = raw.toArray();
} else if (raw.isObject()) {
QJsonObject obj = raw.toObject();
if (obj.contains("datasets"))
- data = obj["datasets"].toArray();
+ payload = obj["datasets"].toArray();
else if (obj.contains("result"))
- data = obj["result"].toArray();
+ payload = obj["result"].toArray();
}
if (request_id.startsWith("gov_orgs_")) {
- current_orgs_ = data;
- populate_orgs(data);
+ current_orgs_ = payload;
+ populate_orgs(payload);
content_stack_->setCurrentIndex(Orgs);
current_view_ = Orgs;
update_breadcrumb();
@@ -396,15 +396,15 @@ void GovDataProviderPanel::on_result(const QString& request_id, const services::
if (total == 0 && result.data["data"].isObject())
total = result.data["data"].toObject()["count"].toInt(0);
if (total == 0)
- total = data.size();
- current_datasets_ = data;
- populate_datasets(data, total);
+ total = payload.size();
+ current_datasets_ = payload;
+ populate_datasets(payload, total);
content_stack_->setCurrentIndex(Datasets);
current_view_ = Datasets;
update_breadcrumb();
} else if (request_id.startsWith("gov_resources_")) {
- current_resources_ = data;
- populate_resources(data);
+ current_resources_ = payload;
+ populate_resources(payload);
content_stack_->setCurrentIndex(Resources);
current_view_ = Resources;
update_breadcrumb();
@@ -415,12 +415,12 @@ void GovDataProviderPanel::on_result(const QString& request_id, const services::
// ── Populate tables ──────────────────────────────────────────────────────────
-void GovDataProviderPanel::populate_orgs(const QJsonArray& data) {
+void GovDataProviderPanel::populate_orgs(const QJsonArray& json) {
orgs_table_->setRowCount(0);
- orgs_table_->setRowCount(data.size());
+ orgs_table_->setRowCount(json.size());
- for (int i = 0; i < data.size(); ++i) {
- const auto obj = data[i].toObject();
+ for (int i = 0; i < json.size(); ++i) {
+ const auto obj = json[i].toObject();
QString name = obj["display_name"].toString();
if (name.isEmpty())
name = obj["title"].toString();
@@ -441,15 +441,15 @@ void GovDataProviderPanel::populate_orgs(const QJsonArray& data) {
orgs_table_->setItem(i, 1, cnt);
}
- row_count_label_->setText(QString::number(data.size()) + " " + org_label_.toLower() + "s");
+ row_count_label_->setText(QString::number(json.size()) + " " + org_label_.toLower() + "s");
}
-void GovDataProviderPanel::populate_datasets(const QJsonArray& data, int total_count) {
+void GovDataProviderPanel::populate_datasets(const QJsonArray& json, int total_count) {
datasets_table_->setRowCount(0);
- datasets_table_->setRowCount(data.size());
+ datasets_table_->setRowCount(json.size());
- for (int i = 0; i < data.size(); ++i) {
- const auto obj = data[i].toObject();
+ for (int i = 0; i < json.size(); ++i) {
+ const auto obj = json[i].toObject();
QString title = obj["title"].toString();
if (title.isEmpty())
title = obj["name"].toString();
@@ -486,15 +486,15 @@ void GovDataProviderPanel::populate_datasets(const QJsonArray& data, int total_c
datasets_table_->setItem(i, 3, tag_item);
}
- row_count_label_->setText(QString("Showing %1 of %2").arg(data.size()).arg(total_count));
+ row_count_label_->setText(QString("Showing %1 of %2").arg(json.size()).arg(total_count));
}
-void GovDataProviderPanel::populate_resources(const QJsonArray& data) {
+void GovDataProviderPanel::populate_resources(const QJsonArray& json) {
resources_table_->setRowCount(0);
- resources_table_->setRowCount(data.size());
+ resources_table_->setRowCount(json.size());
- for (int i = 0; i < data.size(); ++i) {
- const auto obj = data[i].toObject();
+ for (int i = 0; i < json.size(); ++i) {
+ const auto obj = json[i].toObject();
QString name = obj["name"].toString();
if (name.isEmpty())
name = obj["id"].toString();
@@ -546,7 +546,7 @@ void GovDataProviderPanel::populate_resources(const QJsonArray& data) {
}
}
- row_count_label_->setText(QString::number(data.size()) + " files");
+ row_count_label_->setText(QString::number(json.size()) + " files");
}
// ── View navigation ──────────────────────────────────────────────────────────
diff --git a/fincept-qt/src/screens/gov_data/GovDataTreasuryPanel.cpp b/fincept-qt/src/screens/gov_data/GovDataTreasuryPanel.cpp
index 0d4cd2db6..327a2c775 100644
--- a/fincept-qt/src/screens/gov_data/GovDataTreasuryPanel.cpp
+++ b/fincept-qt/src/screens/gov_data/GovDataTreasuryPanel.cpp
@@ -388,8 +388,8 @@ void GovDataTreasuryPanel::on_result(const QString& request_id, const services::
// ── Populate ─────────────────────────────────────────────────────────────────
-void GovDataTreasuryPanel::populate_prices(const QJsonObject& data) {
- const QJsonArray records = data["data"].toArray();
+void GovDataTreasuryPanel::populate_prices(const QJsonObject& json) {
+ const QJsonArray records = json["json"].toArray();
prices_table_->setRowCount(0);
prices_table_->setRowCount(records.size());
@@ -420,8 +420,8 @@ void GovDataTreasuryPanel::populate_prices(const QJsonObject& data) {
LOG_INFO("GovTreasury", QString("Loaded %1 price records").arg(records.size()));
}
-void GovDataTreasuryPanel::populate_auctions(const QJsonObject& data) {
- const QJsonArray records = data["data"].toArray();
+void GovDataTreasuryPanel::populate_auctions(const QJsonObject& json) {
+ const QJsonArray records = json["json"].toArray();
auctions_table_->setRowCount(0);
auctions_table_->setRowCount(records.size());
@@ -457,20 +457,20 @@ void GovDataTreasuryPanel::populate_auctions(const QJsonObject& data) {
LOG_INFO("GovTreasury", QString("Loaded %1 auction records").arg(records.size()));
}
-void GovDataTreasuryPanel::populate_summary(const QJsonObject& data) {
- total_securities_label_->setText(QString::number(data["total_securities"].toInt()));
+void GovDataTreasuryPanel::populate_summary(const QJsonObject& json) {
+ total_securities_label_->setText(QString::number(json["total_securities"].toInt()));
- auto yield = data["yield_summary"].toObject();
+ auto yield = json["yield_summary"].toObject();
min_rate_label_->setText(QString::number(yield["min_rate"].toDouble(), 'f', 3) + "%");
max_rate_label_->setText(QString::number(yield["max_rate"].toDouble(), 'f', 3) + "%");
avg_rate_label_->setText(QString::number(yield["avg_rate"].toDouble(), 'f', 3) + "%");
- auto price = data["price_summary"].toObject();
+ auto price = json["price_summary"].toObject();
min_price_label_->setText(QString::number(price["min_price"].toDouble(), 'f', 2));
max_price_label_->setText(QString::number(price["max_price"].toDouble(), 'f', 2));
avg_price_label_->setText(QString::number(price["avg_price"].toDouble(), 'f', 2));
- auto types = data["security_types"].toObject();
+ auto types = json["security_types"].toObject();
type_breakdown_table_->setRowCount(0);
type_breakdown_table_->setRowCount(types.size());
int row = 0;
diff --git a/fincept-qt/src/screens/gov_data/GovDataUKPanel.cpp b/fincept-qt/src/screens/gov_data/GovDataUKPanel.cpp
index cc8a26462..ce4b0acbe 100644
--- a/fincept-qt/src/screens/gov_data/GovDataUKPanel.cpp
+++ b/fincept-qt/src/screens/gov_data/GovDataUKPanel.cpp
@@ -28,7 +28,6 @@ using namespace fincept::ui;
GovDataUKPanel::GovDataUKPanel(QWidget* parent) : QWidget(parent) {
// UK has a unique #govPopularBtn — pass its style as extra_qss
auto uk_extra = [&]() -> QString {
- const auto& t = ThemeManager::instance().tokens();
const auto cc = QColor(kGovDataUKColor);
const QString c = kGovDataUKColor;
const QString cr = QString::number(cc.red());
@@ -256,52 +255,52 @@ void GovDataUKPanel::on_result(const QString& request_id, const services::GovDat
}
// Unwrap top-level "data" field — always an array for UK panel
- QJsonArray data;
+ QJsonArray payload;
const QJsonValue raw = result.data["data"];
if (raw.isArray()) {
- data = raw.toArray();
+ payload = raw.toArray();
} else if (raw.isObject()) {
// Defensive: in case a future command wraps in {datasets:[]}
const QJsonObject obj = raw.toObject();
if (obj.contains("datasets"))
- data = obj["datasets"].toArray();
+ payload = obj["datasets"].toArray();
else if (obj.contains("result"))
- data = obj["result"].toArray();
+ payload = obj["result"].toArray();
}
if (request_id == "ukgov_publishers" || request_id == "ukgov_popular") {
- current_publishers_ = data;
- populate_publishers(data);
+ current_publishers_ = payload;
+ populate_publishers(payload);
current_view_ = Publishers;
content_stack_->setCurrentIndex(Publishers);
- LOG_INFO("GovDataUKPanel", "Loaded " + QString::number(data.size()) + " publishers");
+ LOG_INFO("GovDataUKPanel", "Loaded " + QString::number(payload.size()) + " publishers");
} else if (request_id.startsWith("ukgov_datasets_")) {
int total = result.data["metadata"].toObject()["total_count"].toInt(0);
if (total == 0)
- total = data.size();
- current_datasets_ = data;
- populate_datasets(data, total);
+ total = payload.size();
+ current_datasets_ = payload;
+ populate_datasets(payload, total);
current_view_ = Datasets;
content_stack_->setCurrentIndex(Datasets);
- LOG_INFO("GovDataUKPanel", "Loaded " + QString::number(data.size()) + " datasets");
+ LOG_INFO("GovDataUKPanel", "Loaded " + QString::number(payload.size()) + " datasets");
} else if (request_id.startsWith("ukgov_search_")) {
int total = result.data["metadata"].toObject()["total_count"].toInt(0);
if (total == 0)
- total = data.size();
- current_datasets_ = data;
- populate_datasets(data, total);
+ total = payload.size();
+ current_datasets_ = payload;
+ populate_datasets(payload, total);
current_view_ = Datasets;
content_stack_->setCurrentIndex(Datasets);
- LOG_INFO("GovDataUKPanel", "Search returned " + QString::number(data.size()) + " datasets");
+ LOG_INFO("GovDataUKPanel", "Search returned " + QString::number(payload.size()) + " datasets");
} else if (request_id.startsWith("ukgov_resources_")) {
- current_resources_ = data;
- populate_resources(data);
+ current_resources_ = payload;
+ populate_resources(payload);
current_view_ = Resources;
content_stack_->setCurrentIndex(Resources);
- LOG_INFO("GovDataUKPanel", "Loaded " + QString::number(data.size()) + " resources");
+ LOG_INFO("GovDataUKPanel", "Loaded " + QString::number(payload.size()) + " resources");
}
update_toolbar_state();
@@ -310,12 +309,12 @@ void GovDataUKPanel::on_result(const QString& request_id, const services::GovDat
// ── Populate tables ───────────────────────────────────────────────────────────
-void GovDataUKPanel::populate_publishers(const QJsonArray& data) {
+void GovDataUKPanel::populate_publishers(const QJsonArray& json) {
publishers_table_->setRowCount(0);
- publishers_table_->setRowCount(data.size());
+ publishers_table_->setRowCount(json.size());
- for (int i = 0; i < data.size(); ++i) {
- const auto obj = data[i].toObject();
+ for (int i = 0; i < json.size(); ++i) {
+ const auto obj = json[i].toObject();
// Prefer display_name → title → name → id
QString name = obj["display_name"].toString();
@@ -336,15 +335,15 @@ void GovDataUKPanel::populate_publishers(const QJsonArray& data) {
publishers_table_->setItem(i, 0, name_item);
}
- row_count_label_->setText(QString::number(data.size()) + " publishers");
+ row_count_label_->setText(QString::number(json.size()) + " publishers");
}
-void GovDataUKPanel::populate_datasets(const QJsonArray& data, int total_count) {
+void GovDataUKPanel::populate_datasets(const QJsonArray& json, int total_count) {
datasets_table_->setRowCount(0);
- datasets_table_->setRowCount(data.size());
+ datasets_table_->setRowCount(json.size());
- for (int i = 0; i < data.size(); ++i) {
- const auto obj = data[i].toObject();
+ for (int i = 0; i < json.size(); ++i) {
+ const auto obj = json[i].toObject();
QString title = obj["title"].toString();
if (title.isEmpty())
@@ -382,15 +381,15 @@ void GovDataUKPanel::populate_datasets(const QJsonArray& data, int total_count)
datasets_table_->setItem(i, 3, tag_item);
}
- row_count_label_->setText(QString("Showing %1 of %2").arg(data.size()).arg(total_count));
+ row_count_label_->setText(QString("Showing %1 of %2").arg(json.size()).arg(total_count));
}
-void GovDataUKPanel::populate_resources(const QJsonArray& data) {
+void GovDataUKPanel::populate_resources(const QJsonArray& json) {
resources_table_->setRowCount(0);
- resources_table_->setRowCount(data.size());
+ resources_table_->setRowCount(json.size());
- for (int i = 0; i < data.size(); ++i) {
- const auto obj = data[i].toObject();
+ for (int i = 0; i < json.size(); ++i) {
+ const auto obj = json[i].toObject();
QString name = obj["name"].toString();
if (name.isEmpty())
@@ -433,7 +432,7 @@ void GovDataUKPanel::populate_resources(const QJsonArray& data) {
resources_table_->setItem(i, 4, url_item);
}
- row_count_label_->setText(QString::number(data.size()) + " files");
+ row_count_label_->setText(QString::number(json.size()) + " files");
}
// ── Navigation slots ──────────────────────────────────────────────────────────
diff --git a/fincept-qt/src/screens/ma_analytics/MAModulePanel.cpp b/fincept-qt/src/screens/ma_analytics/MAModulePanel.cpp
index 748830cac..f22104044 100644
--- a/fincept-qt/src/screens/ma_analytics/MAModulePanel.cpp
+++ b/fincept-qt/src/screens/ma_analytics/MAModulePanel.cpp
@@ -2045,7 +2045,7 @@ static QTableWidget* build_kv_table(const QJsonObject& obj, const QString& accen
return table;
}
-void MAModulePanel::display_result(const QJsonObject& data) {
+void MAModulePanel::display_result(const QJsonObject& payload) {
clear_results();
QString accent = QString("%1,%2,%3").arg(module_.color.red()).arg(module_.color.green()).arg(module_.color.blue());
@@ -2066,7 +2066,7 @@ void MAModulePanel::display_result(const QJsonObject& data) {
int col = 0, row = 0;
bool has_scalars = false;
- for (auto it = data.begin(); it != data.end(); ++it) {
+ for (auto it = payload.begin(); it != payload.end(); ++it) {
if (it.value().isObject() || it.value().isArray())
continue;
has_scalars = true;
@@ -2086,7 +2086,7 @@ void MAModulePanel::display_result(const QJsonObject& data) {
grid->deleteLater();
// 2. Tables for nested objects and arrays
- for (auto it = data.begin(); it != data.end(); ++it) {
+ for (auto it = payload.begin(); it != payload.end(); ++it) {
if (it.value().isArray()) {
auto arr = it.value().toArray();
if (arr.isEmpty())
@@ -2157,7 +2157,7 @@ void MAModulePanel::display_result(const QJsonObject& data) {
raw_text->setReadOnly(true);
raw_text->setVisible(false);
raw_text->setMaximumHeight(300);
- raw_text->setPlainText(QJsonDocument(data).toJson(QJsonDocument::Indented));
+ raw_text->setPlainText(QJsonDocument(payload).toJson(QJsonDocument::Indented));
raw_text->setStyleSheet(QString("QTextEdit { background:%1; color:%2; border:1px solid %3;"
"font-family:%4; font-size:%5px; padding:8px; }")
.arg(ui::colors::BG_RAISED(), ui::colors::TEXT_PRIMARY(), ui::colors::BORDER_DIM())
@@ -2199,10 +2199,10 @@ static const QHash<ModuleId, QStringList>& get_context_map() {
return map;
}
-void MAModulePanel::on_result_ready(const QString& context, const QJsonObject& data) {
+void MAModulePanel::on_result_ready(const QString& context, const QJsonObject& payload) {
auto it = get_context_map().find(module_.id);
if (it != get_context_map().end() && it->contains(context)) {
- display_result(data);
+ display_result(payload);
}
}
diff --git a/fincept-qt/src/screens/markets/MarketPanelStore.cpp b/fincept-qt/src/screens/markets/MarketPanelStore.cpp
index 3c4bf0644..b594aa3b6 100644
--- a/fincept-qt/src/screens/markets/MarketPanelStore.cpp
+++ b/fincept-qt/src/screens/markets/MarketPanelStore.cpp
@@ -34,8 +34,8 @@ QVector<MarketPanelConfig> MarketPanelStore::load() {
cfg.symbols << s.toString();
if (obj.contains("column_order")) {
QStringList cols;
- for (const auto& v : obj["column_order"].toArray())
- cols << v.toString();
+ for (const auto& col : obj["column_order"].toArray())
+ cols << col.toString();
if (!cols.isEmpty())
cfg.column_order = cols;
}
diff --git a/fincept-qt/src/screens/mcp_servers/McpServersScreen.cpp b/fincept-qt/src/screens/mcp_servers/McpServersScreen.cpp
index 63e73c348..78733f0b7 100644
--- a/fincept-qt/src/screens/mcp_servers/McpServersScreen.cpp
+++ b/fincept-qt/src/screens/mcp_servers/McpServersScreen.cpp
@@ -571,7 +571,7 @@ void McpServersScreen::on_start_server() {
return;
const QString id = selected_server_id_;
QPointer<McpServersScreen> self = this;
- QtConcurrent::run([id, self]() {
+ (void)QtConcurrent::run([id, self]() {
const auto result = McpManager::instance().start_server(id);
QMetaObject::invokeMethod(
self,
@@ -592,7 +592,7 @@ void McpServersScreen::on_stop_server() {
return;
const QString id = selected_server_id_;
QPointer<McpServersScreen> self = this;
- QtConcurrent::run([id, self]() {
+ (void)QtConcurrent::run([id, self]() {
McpManager::instance().stop_server(id);
QMetaObject::invokeMethod(
self,
@@ -956,7 +956,7 @@ QWidget* McpServersScreen::build_server_card(const McpServerConfig& s) {
// start_server() blocks for process launch + handshake (can take 60s+).
toggle_btn->setText("⟳ STARTING...");
toggle_btn->setEnabled(false);
- QtConcurrent::run([sid, self]() {
+ (void)QtConcurrent::run([sid, self]() {
const auto r = McpManager::instance().start_server(sid);
if (!self)
return;
@@ -1022,7 +1022,7 @@ QWidget* McpServersScreen::build_server_card(const McpServerConfig& s) {
return;
// Fetch logs off-thread so mutex never stalls UI
QPointer<QTextEdit> lv = log_view;
- QtConcurrent::run([sid, lv]() {
+ (void)QtConcurrent::run([sid, lv]() {
const QStringList lines = McpManager::instance().get_logs(sid);
QMetaObject::invokeMethod(
lv,
diff --git a/fincept-qt/src/screens/news/NewsDetailPanel.cpp b/fincept-qt/src/screens/news/NewsDetailPanel.cpp
index 6a91203c5..3a5a90897 100644
--- a/fincept-qt/src/screens/news/NewsDetailPanel.cpp
+++ b/fincept-qt/src/screens/news/NewsDetailPanel.cpp
@@ -211,7 +211,7 @@ QWidget* NewsDetailPanel::build_content_view() {
// Build a safe filename from headline
QString safe = current_article_.headline;
- safe.replace(QRegularExpression("[^a-zA-Z0-9_\\- ]"), "").simplified();
+ safe = safe.replace(QRegularExpression("[^a-zA-Z0-9_\\- ]"), "").simplified();
safe.replace(' ', '_');
if (safe.length() > 60)
safe = safe.left(60);
diff --git a/fincept-qt/src/screens/news/NewsFeedDelegate.cpp b/fincept-qt/src/screens/news/NewsFeedDelegate.cpp
index 939315902..f972ff9c9 100644
--- a/fincept-qt/src/screens/news/NewsFeedDelegate.cpp
+++ b/fincept-qt/src/screens/news/NewsFeedDelegate.cpp
@@ -51,7 +51,18 @@ void NewsFeedDelegate::paint(QPainter* painter, const QStyleOptionViewItem& opti
void NewsFeedDelegate::paint_wire_row(QPainter* painter, const QRect& rect, const QModelIndex& index, bool selected,
bool hovered) const {
+ // GCC 12 false-positive: -Warray-bounds on QVariant::value<NewsArticle>()
+ // inlined move/copy — the analyzer wrongly treats the temporary as
+ // QVariant[1]. Suppress locally; struct layout is fixed and QVariant
+ // conversion is validated by QMetaType.
+#if defined(__GNUC__) && !defined(__clang__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Warray-bounds"
+#endif
auto article = index.data(ArticleRole).value<services::NewsArticle>();
+#if defined(__GNUC__) && !defined(__clang__)
+#pragma GCC diagnostic pop
+#endif
auto monitor_color = index.data(MonitorColorRole).toString();
bool is_new = index.data(IsNewRole).toBool();
int tier = index.data(SourceTierRole).toInt();
diff --git a/fincept-qt/src/screens/news/NewsScreen.cpp b/fincept-qt/src/screens/news/NewsScreen.cpp
index 363095577..c2b4c3023 100644
--- a/fincept-qt/src/screens/news/NewsScreen.cpp
+++ b/fincept-qt/src/screens/news/NewsScreen.cpp
@@ -158,7 +158,7 @@ void NewsScreen::connect_signals() {
const QSet<QString> ids = std::move(pending_seen_ids_);
pending_seen_ids_.clear();
QPointer<NewsScreen> self = this;
- QtConcurrent::run([ids, self]() {
+ (void)QtConcurrent::run([ids, self]() {
for (const auto& id : ids)
fincept::NewsArticleRepository::instance().mark_seen(id);
if (self) {
@@ -562,7 +562,7 @@ void NewsScreen::apply_filters_async() {
}
}
- QtConcurrent::run([self, gen, articles_copy = std::move(articles_copy), category, time_range, search_lower, sort,
+ (void)QtConcurrent::run([self, gen, articles_copy = std::move(articles_copy), category, time_range, search_lower, sort,
variant, visible_count]() {
int64_t window_sec = 0;
if (time_range == "1H")
diff --git a/fincept-qt/src/screens/notes/NotesScreen.cpp b/fincept-qt/src/screens/notes/NotesScreen.cpp
index bfc0bc3eb..8b92705c5 100644
--- a/fincept-qt/src/screens/notes/NotesScreen.cpp
+++ b/fincept-qt/src/screens/notes/NotesScreen.cpp
@@ -113,14 +113,6 @@ static QString priority_color(const QString& p) {
return POSITIVE();
}
-static QString sentiment_color(const QString& s) {
- if (s == "BULLISH")
- return POSITIVE();
- if (s == "BEARISH")
- return NEGATIVE();
- return WARNING();
-}
-
// ── Constructor ──────────────────────────────────────────────────────────────
NotesScreen::NotesScreen(QWidget* parent) : QWidget(parent) {
diff --git a/fincept-qt/src/screens/polymarket/PolymarketActivityFeed.cpp b/fincept-qt/src/screens/polymarket/PolymarketActivityFeed.cpp
index a5fb70660..c834d6526 100644
--- a/fincept-qt/src/screens/polymarket/PolymarketActivityFeed.cpp
+++ b/fincept-qt/src/screens/polymarket/PolymarketActivityFeed.cpp
@@ -4,6 +4,7 @@
#include <QBrush>
#include <QDateTime>
+#include <QTimeZone>
#include <QHeaderView>
#include <QPointer>
#include <QTimer>
@@ -20,7 +21,7 @@ constexpr int kMaxRows = 200;
constexpr int kFlashMs = 600;
void apply_row(QTableWidget* table, int row, const PredictionTrade& t, int price_decimals) {
- const QString time = QDateTime::fromMSecsSinceEpoch(t.ts_ms, Qt::UTC).toString("HH:mm:ss");
+ const QString time = QDateTime::fromMSecsSinceEpoch(t.ts_ms, QTimeZone::UTC).toString("HH:mm:ss");
table->setItem(row, 0, new QTableWidgetItem(time));
table->setItem(row, 1, new QTableWidgetItem("TRADE"));
diff --git a/fincept-qt/src/screens/polymarket/PolymarketDetailPanel.cpp b/fincept-qt/src/screens/polymarket/PolymarketDetailPanel.cpp
index 94db8af2b..f40d51104 100644
--- a/fincept-qt/src/screens/polymarket/PolymarketDetailPanel.cpp
+++ b/fincept-qt/src/screens/polymarket/PolymarketDetailPanel.cpp
@@ -7,6 +7,7 @@
#include <QComboBox>
#include <QDateTime>
+#include <QTimeZone>
#include <QHBoxLayout>
#include <QHeaderView>
#include <QLineEdit>
@@ -787,7 +788,7 @@ void PolymarketDetailPanel::set_comments(const QVector<pmx::Comment>& comments)
body->setWordWrap(true);
auto* meta = new QLabel(
- QDateTime::fromSecsSinceEpoch(c.created_at, Qt::UTC).toString("yyyy-MM-dd HH:mm") +
+ QDateTime::fromSecsSinceEpoch(c.created_at, QTimeZone::UTC).toString("yyyy-MM-dd HH:mm") +
(c.likes > 0 ? QString(" · %1 likes").arg(c.likes) : ""));
meta->setStyleSheet(
QString("color: %1; font-size: 8px; background: transparent;").arg(colors::TEXT_DIM()));
diff --git a/fincept-qt/src/screens/polymarket/PolymarketMarketCard.cpp b/fincept-qt/src/screens/polymarket/PolymarketMarketCard.cpp
index cd12275de..7b811ac7e 100644
--- a/fincept-qt/src/screens/polymarket/PolymarketMarketCard.cpp
+++ b/fincept-qt/src/screens/polymarket/PolymarketMarketCard.cpp
@@ -11,10 +11,6 @@ using namespace fincept::services::prediction;
static const char* OUTCOME_BAR_COLORS[] = {"#00D66F", "#FF3B3B", "#FF8800", "#4F8EF7", "#A855F7"};
-static QChar outcome_initial(const QString& name) {
- return name.isEmpty() ? QChar('?') : name.at(0).toUpper();
-}
-
// ── Model ───────────────────────────────────────────────────────────────────
PolymarketMarketCardModel::PolymarketMarketCardModel(QObject* parent) : QAbstractListModel(parent) {}
@@ -112,7 +108,7 @@ void PolymarketMarketCardDelegate::paint(QPainter* painter, const QStyleOptionVi
if (selected) {
// Selected: deep tinted background, left accent rail
QColor sel_bg = accent;
- sel_bg.setAlphaF(0.10);
+ sel_bg.setAlphaF(0.10f);
painter->fillRect(r, sel_bg);
// Left accent rail (3px)
painter->fillRect(r.left(), r.top(), 3, r.height(), accent);
diff --git a/fincept-qt/src/screens/portfolio/PortfolioAgentPanel.cpp b/fincept-qt/src/screens/portfolio/PortfolioAgentPanel.cpp
index 1d9b017eb..514a312c5 100644
--- a/fincept-qt/src/screens/portfolio/PortfolioAgentPanel.cpp
+++ b/fincept-qt/src/screens/portfolio/PortfolioAgentPanel.cpp
@@ -217,7 +217,7 @@ void PortfolioAgentPanel::run_agent(bool force) {
QString prompt = lines.join("\n");
QPointer<PortfolioAgentPanel> self = this;
- QtConcurrent::run([self, prompt, agent_id]() {
+ (void)QtConcurrent::run([self, prompt, agent_id]() {
auto response = ai_chat::LlmService::instance().chat(prompt, {});
if (!self)
diff --git a/fincept-qt/src/screens/portfolio/PortfolioAiPanel.cpp b/fincept-qt/src/screens/portfolio/PortfolioAiPanel.cpp
index f35e7e6fa..a9fa6d824 100644
--- a/fincept-qt/src/screens/portfolio/PortfolioAiPanel.cpp
+++ b/fincept-qt/src/screens/portfolio/PortfolioAiPanel.cpp
@@ -212,7 +212,7 @@ void PortfolioAiPanel::run_analysis(bool force) {
QString type = current_type_;
QPointer<PortfolioAiPanel> self = this;
- QtConcurrent::run([self, prompt, type]() {
+ (void)QtConcurrent::run([self, prompt, type]() {
auto response = ai_chat::LlmService::instance().chat(prompt, {});
if (!self)
diff --git a/fincept-qt/src/screens/portfolio/PortfolioDetailWrapper.cpp b/fincept-qt/src/screens/portfolio/PortfolioDetailWrapper.cpp
index 5a690087d..e080e9deb 100644
--- a/fincept-qt/src/screens/portfolio/PortfolioDetailWrapper.cpp
+++ b/fincept-qt/src/screens/portfolio/PortfolioDetailWrapper.cpp
@@ -111,26 +111,26 @@ void PortfolioDetailWrapper::update_data(const portfolio::PortfolioSummary& summ
return;
// Update the active view with new data
- if (auto* v = qobject_cast<AnalyticsSectorsView*>(current)) {
- v->set_data(summary, currency);
- } else if (auto* v = qobject_cast<PerformanceRiskView*>(current)) {
- v->set_data(summary, currency);
- v->set_snapshots(current_snapshots_);
- } else if (auto* v = qobject_cast<RiskManagementView*>(current)) {
- v->set_data(summary, currency);
- v->set_metrics(current_metrics_);
- } else if (auto* v = qobject_cast<PortfolioOptimizationView*>(current)) {
- v->set_data(summary, currency);
- } else if (auto* v = qobject_cast<QuantStatsView*>(current)) {
- v->set_data(summary, currency);
- } else if (auto* v = qobject_cast<ReportsView*>(current)) {
- v->set_data(summary, currency);
- } else if (auto* v = qobject_cast<CustomIndexView*>(current)) {
- v->set_data(summary, currency);
- } else if (auto* v = qobject_cast<PlanningView*>(current)) {
- v->set_data(summary, currency);
- } else if (auto* v = qobject_cast<EconomicsView*>(current)) {
- v->set_data(summary, currency);
+ if (auto* sectors_v = qobject_cast<AnalyticsSectorsView*>(current)) {
+ sectors_v->set_data(summary, currency);
+ } else if (auto* perf_v = qobject_cast<PerformanceRiskView*>(current)) {
+ perf_v->set_data(summary, currency);
+ perf_v->set_snapshots(current_snapshots_);
+ } else if (auto* risk_v = qobject_cast<RiskManagementView*>(current)) {
+ risk_v->set_data(summary, currency);
+ risk_v->set_metrics(current_metrics_);
+ } else if (auto* opt_v = qobject_cast<PortfolioOptimizationView*>(current)) {
+ opt_v->set_data(summary, currency);
+ } else if (auto* quant_v = qobject_cast<QuantStatsView*>(current)) {
+ quant_v->set_data(summary, currency);
+ } else if (auto* reports_v = qobject_cast<ReportsView*>(current)) {
+ reports_v->set_data(summary, currency);
+ } else if (auto* idx_v = qobject_cast<CustomIndexView*>(current)) {
+ idx_v->set_data(summary, currency);
+ } else if (auto* plan_v = qobject_cast<PlanningView*>(current)) {
+ plan_v->set_data(summary, currency);
+ } else if (auto* econ_v = qobject_cast<EconomicsView*>(current)) {
+ econ_v->set_data(summary, currency);
}
}
diff --git a/fincept-qt/src/screens/portfolio/PortfolioHeatmap.cpp b/fincept-qt/src/screens/portfolio/PortfolioHeatmap.cpp
index 9d2c06b16..7c8dff9d2 100644
--- a/fincept-qt/src/screens/portfolio/PortfolioHeatmap.cpp
+++ b/fincept-qt/src/screens/portfolio/PortfolioHeatmap.cpp
@@ -342,7 +342,6 @@ void PortfolioHeatmap::update_risk_gauge() {
// Use a colored inner bar proportional to score
double pct = std::min(rs / 100.0, 1.0);
- int bar_width = static_cast<int>(pct * risk_bar_->width());
risk_bar_->setStyleSheet(
QString("background: qlineargradient(x1:0, x2:1, stop:0 %1, stop:%2 %1, stop:%3 transparent);")
.arg(rs_color)
diff --git a/fincept-qt/src/screens/portfolio/PortfolioPerfChart.cpp b/fincept-qt/src/screens/portfolio/PortfolioPerfChart.cpp
index 9d4d0ce6d..b6f0b1911 100644
--- a/fincept-qt/src/screens/portfolio/PortfolioPerfChart.cpp
+++ b/fincept-qt/src/screens/portfolio/PortfolioPerfChart.cpp
@@ -5,12 +5,14 @@
#include <QAreaSeries>
#include <QChart>
+#include <QDateTime>
#include <QDateTimeAxis>
#include <QGuiApplication>
#include <QHBoxLayout>
#include <QLineSeries>
#include <QMouseEvent>
#include <QScreen>
+#include <QTimeZone>
#include <QVBoxLayout>
#include <QValueAxis>
@@ -443,7 +445,7 @@ void PortfolioPerfChart::update_chart() {
const QDate d = QDate::fromString(spy_dates_[i], Qt::ISODate);
if (d > end_date)
break;
- const qint64 ms = QDateTime(d, QTime(), Qt::UTC).toMSecsSinceEpoch();
+ const qint64 ms = QDateTime(d, QTime(), QTimeZone::UTC).toMSecsSinceEpoch();
const double val = first_val * (spy_closes_[i] / spy_base);
spy_line->append(ms, val);
spy_min = std::min(spy_min, val);
diff --git a/fincept-qt/src/screens/portfolio/PortfolioScreen.cpp b/fincept-qt/src/screens/portfolio/PortfolioScreen.cpp
index 03cb507ee..e06269735 100644
--- a/fincept-qt/src/screens/portfolio/PortfolioScreen.cpp
+++ b/fincept-qt/src/screens/portfolio/PortfolioScreen.cpp
@@ -589,7 +589,7 @@ void PortfolioScreen::on_summary_loaded(portfolio::PortfolioSummary summary) {
services::PortfolioService::instance().fetch_risk_free_rate();
}
-void PortfolioScreen::on_summary_error(QString portfolio_id, QString error) {
+void PortfolioScreen::on_summary_error(QString portfolio_id, QString /*error*/) {
if (portfolio_id != selected_id_)
return;
// Show empty state with error — for now just revert to empty
diff --git a/fincept-qt/src/screens/portfolio/PortfolioSparkline.cpp b/fincept-qt/src/screens/portfolio/PortfolioSparkline.cpp
index 7ce74fa0f..f9884efa1 100644
--- a/fincept-qt/src/screens/portfolio/PortfolioSparkline.cpp
+++ b/fincept-qt/src/screens/portfolio/PortfolioSparkline.cpp
@@ -19,8 +19,8 @@ PortfolioSparkline::PortfolioSparkline(int w, int h, QWidget* parent) : QWidget(
});
}
-void PortfolioSparkline::set_data(const QVector<double>& data) {
- data_ = data;
+void PortfolioSparkline::set_data(const QVector<double>& values) {
+ data_ = values;
dirty_ = true;
update();
}
diff --git a/fincept-qt/src/screens/portfolio/views/PortfolioOptimizationView.cpp b/fincept-qt/src/screens/portfolio/views/PortfolioOptimizationView.cpp
index 47d34785d..86702b9e5 100644
--- a/fincept-qt/src/screens/portfolio/views/PortfolioOptimizationView.cpp
+++ b/fincept-qt/src/screens/portfolio/views/PortfolioOptimizationView.cpp
@@ -466,13 +466,13 @@ void PortfolioOptimizationView::run_optimization() {
// ── OPTIMIZE results table ────────────────────────────────
self->result_table_->setRowCount(
static_cast<int>(self->summary_.holdings.size()));
- for (int r = 0; r < static_cast<int>(self->summary_.holdings.size()); ++r) {
- const auto& h = self->summary_.holdings[r];
+ for (int row = 0; row < static_cast<int>(self->summary_.holdings.size()); ++row) {
+ const auto& h = self->summary_.holdings[row];
const double cw = h.weight;
const double ow = opt_weights.value(h.symbol).toDouble(cw / 100.0) * 100.0;
const double ch = ow - cw;
- self->result_table_->setRowHeight(r, 28);
+ self->result_table_->setRowHeight(row, 28);
auto set = [&](int col, const QString& text,
const char* color = nullptr) {
@@ -481,7 +481,7 @@ void PortfolioOptimizationView::run_optimization() {
: (Qt::AlignRight | Qt::AlignVCenter));
if (color)
item->setForeground(QColor(color));
- self->result_table_->setItem(r, col, item);
+ self->result_table_->setItem(row, col, item);
};
set(0, h.symbol, ui::colors::CYAN);
diff --git a/fincept-qt/src/screens/relationship_map/RelationshipGraphScene.cpp b/fincept-qt/src/screens/relationship_map/RelationshipGraphScene.cpp
index d9c857cdb..b9951af39 100644
--- a/fincept-qt/src/screens/relationship_map/RelationshipGraphScene.cpp
+++ b/fincept-qt/src/screens/relationship_map/RelationshipGraphScene.cpp
@@ -641,8 +641,9 @@ void RelationshipGraphView::wheelEvent(QWheelEvent* event) {
void RelationshipGraphView::mousePressEvent(QMouseEvent* event) {
if (event->button() == Qt::MiddleButton) {
setDragMode(QGraphicsView::ScrollHandDrag);
- QMouseEvent fake(event->type(), event->pos(), Qt::LeftButton,
- Qt::LeftButton, event->modifiers());
+ QMouseEvent fake(event->type(), event->position(), event->scenePosition(),
+ event->globalPosition(), Qt::LeftButton, Qt::LeftButton,
+ event->modifiers());
QGraphicsView::mousePressEvent(&fake);
} else {
QGraphicsView::mousePressEvent(event);
@@ -651,8 +652,9 @@ void RelationshipGraphView::mousePressEvent(QMouseEvent* event) {
void RelationshipGraphView::mouseReleaseEvent(QMouseEvent* event) {
if (event->button() == Qt::MiddleButton) {
- QMouseEvent fake(event->type(), event->pos(), Qt::LeftButton,
- Qt::LeftButton, event->modifiers());
+ QMouseEvent fake(event->type(), event->position(), event->scenePosition(),
+ event->globalPosition(), Qt::LeftButton, Qt::LeftButton,
+ event->modifiers());
QGraphicsView::mouseReleaseEvent(&fake);
setDragMode(QGraphicsView::ScrollHandDrag);
} else {
diff --git a/fincept-qt/src/screens/relationship_map/RelationshipMapScreen.cpp b/fincept-qt/src/screens/relationship_map/RelationshipMapScreen.cpp
index 4fafa6b57..2b8727923 100644
--- a/fincept-qt/src/screens/relationship_map/RelationshipMapScreen.cpp
+++ b/fincept-qt/src/screens/relationship_map/RelationshipMapScreen.cpp
@@ -647,10 +647,10 @@ void RelationshipMapScreen::on_progress(int percent, const QString& message) {
}
}
-void RelationshipMapScreen::on_data_ready(const RelationshipData& data) {
- current_data_ = data;
+void RelationshipMapScreen::on_data_ready(const RelationshipData& payload) {
+ current_data_ = payload;
has_data_ = true;
- loaded_ticker_ = data.company.ticker;
+ loaded_ticker_ = payload.company.ticker;
progress_bar_->hide();
progress_label_->setText("Complete");
legend_widget_->show();
diff --git a/fincept-qt/src/screens/report_builder/DocumentCanvas.cpp b/fincept-qt/src/screens/report_builder/DocumentCanvas.cpp
index 01d47d553..5b809503f 100644
--- a/fincept-qt/src/screens/report_builder/DocumentCanvas.cpp
+++ b/fincept-qt/src/screens/report_builder/DocumentCanvas.cpp
@@ -483,7 +483,7 @@ void DocumentCanvas::render(const QVector<ReportComponent>& components, const Re
bf.setBackground(QColor("#fffbe6"));
cursor.setBlockFormat(bf);
QTextCharFormat fmt;
- fmt.setFontFamily("Consolas");
+ fmt.setFontFamilies({"Consolas"});
fmt.setFontPointSize(11);
fmt.setForeground(QColor(theme.text_color));
cursor.insertText(comp.content.isEmpty() ? "// code block" : comp.content, fmt);
@@ -684,9 +684,9 @@ void DocumentCanvas::render(const QVector<ReportComponent>& components, const Re
if (!high.isEmpty() || !low.isEmpty() || !volume.isEmpty()) {
cursor.insertBlock();
cursor.setBlockFormat(bf);
- QTextCharFormat meta_fmt;
- meta_fmt.setFontPointSize(10);
- meta_fmt.setForeground(QColor(theme.meta_color));
+ QTextCharFormat detail_fmt;
+ detail_fmt.setFontPointSize(10);
+ detail_fmt.setForeground(QColor(theme.meta_color));
QString detail;
if (!high.isEmpty() && !low.isEmpty())
@@ -704,7 +704,7 @@ void DocumentCanvas::render(const QVector<ReportComponent>& components, const Re
vol_str = volume;
detail += "Vol: " + vol_str;
}
- cursor.insertText(" " + detail, meta_fmt);
+ cursor.insertText(" " + detail, detail_fmt);
}
}
cursor.insertText("\n");
diff --git a/fincept-qt/src/screens/report_builder/ReportBuilderScreen.cpp b/fincept-qt/src/screens/report_builder/ReportBuilderScreen.cpp
index b6368d647..fcf076050 100644
--- a/fincept-qt/src/screens/report_builder/ReportBuilderScreen.cpp
+++ b/fincept-qt/src/screens/report_builder/ReportBuilderScreen.cpp
@@ -210,7 +210,7 @@ ReportBuilderScreen::ReportBuilderScreen(QWidget* parent) : QWidget(parent) {
connect(comp_toolbar_, &ComponentToolbar::font_changed, this,
[this](const QString& family, int size, bool bold, bool italic) {
QTextCharFormat fmt;
- fmt.setFontFamily(family);
+ fmt.setFontFamilies({family});
fmt.setFontPointSize(size);
fmt.setFontWeight(bold ? QFont::Bold : QFont::Normal);
fmt.setFontItalic(italic);
diff --git a/fincept-qt/src/screens/settings/McpServersSection.cpp b/fincept-qt/src/screens/settings/McpServersSection.cpp
index 795a1bb8b..44304c63b 100644
--- a/fincept-qt/src/screens/settings/McpServersSection.cpp
+++ b/fincept-qt/src/screens/settings/McpServersSection.cpp
@@ -592,7 +592,7 @@ void McpServersSection::on_start_server() {
QPointer<McpServersSection> self = this;
QString id = selected_server_id_;
- QtConcurrent::run([self, id]() {
+ (void)QtConcurrent::run([self, id]() {
auto r = McpManager::instance().start_server(id);
QMetaObject::invokeMethod(
qApp,
diff --git a/fincept-qt/src/screens/setup/SetupScreen.cpp b/fincept-qt/src/screens/setup/SetupScreen.cpp
index abe144e72..e5f52f740 100644
--- a/fincept-qt/src/screens/setup/SetupScreen.cpp
+++ b/fincept-qt/src/screens/setup/SetupScreen.cpp
@@ -476,7 +476,7 @@ void SetupScreen::prefill_completed_steps() {
// check_status() slow path can spawn Python processes (up to ~15s on first run).
// Run it on a background thread and post results back to the UI thread — P1/P8.
QPointer<SetupScreen> self = this;
- QtConcurrent::run([self]() {
+ (void)QtConcurrent::run([self]() {
const auto status = python::PythonSetupManager::instance().check_status();
QMetaObject::invokeMethod(self, [self, status]() {
if (!self)
diff --git a/fincept-qt/src/screens/support/SupportScreen.cpp b/fincept-qt/src/screens/support/SupportScreen.cpp
index 79bc632ef..e9d2547cc 100644
--- a/fincept-qt/src/screens/support/SupportScreen.cpp
+++ b/fincept-qt/src/screens/support/SupportScreen.cpp
@@ -949,7 +949,7 @@ void SupportScreen::load_tickets() {
const QString body_c = obj["description"].toString();
const bool demo_c = is_demo;
- connect(btn, &QPushButton::clicked, this, [=]() {
+ connect(btn, &QPushButton::clicked, this, [=, this]() {
select_ticket_row(btn);
selected_ticket_id_ = id_int;
diff --git a/fincept-qt/src/screens/surface_analytics/Surface3DWidget.cpp b/fincept-qt/src/screens/surface_analytics/Surface3DWidget.cpp
index 8cb8f3b8b..743260b5c 100644
--- a/fincept-qt/src/screens/surface_analytics/Surface3DWidget.cpp
+++ b/fincept-qt/src/screens/surface_analytics/Surface3DWidget.cpp
@@ -200,7 +200,7 @@ void Surface3DWidget::paintEvent(QPaintEvent*) {
// Brighter lighting — ambient 0.65 + directional, never below 55%
float dx1 = x1 - x0, dy1 = y01 - y00;
- float dy2 = y10 - y00, dz2 = zz1 - zz0;
+ float dz2 = zz1 - zz0;
float nx = dy1 * dz2;
float ny = -dx1 * dz2;
float nz = 0.0f;
diff --git a/fincept-qt/src/screens/surface_analytics/SurfaceAnalyticsScreen.cpp b/fincept-qt/src/screens/surface_analytics/SurfaceAnalyticsScreen.cpp
index f5a606354..aeab230c4 100644
--- a/fincept-qt/src/screens/surface_analytics/SurfaceAnalyticsScreen.cpp
+++ b/fincept-qt/src/screens/surface_analytics/SurfaceAnalyticsScreen.cpp
@@ -79,17 +79,6 @@ static QString btn_active_amber() {
.arg(colors::BG_BASE());
}
-static QString btn_danger() {
- return QString("QPushButton { background:rgba(220,38,38,0.08); border:1px solid %1; color:%2;"
- " font-size:11px; font-weight:bold; font-family:%3;"
- " padding:0 10px; }"
- "QPushButton:hover { background:%2; color:%4; }")
- .arg(colors::NEGATIVE_DIM())
- .arg(colors::NEGATIVE())
- .arg(MONO)
- .arg(colors::TEXT_PRIMARY());
-}
-
// ── Constructor ──────────────────────────────────────────────────────────────
SurfaceAnalyticsScreen::SurfaceAnalyticsScreen(QWidget* parent) : QWidget(parent) {
srand((unsigned)time(nullptr));
diff --git a/fincept-qt/src/screens/surface_analytics/SurfaceDemoData.cpp b/fincept-qt/src/screens/surface_analytics/SurfaceDemoData.cpp
index d72c6e621..7658e834f 100644
--- a/fincept-qt/src/screens/surface_analytics/SurfaceDemoData.cpp
+++ b/fincept-qt/src/screens/surface_analytics/SurfaceDemoData.cpp
@@ -571,7 +571,7 @@ FactorExposureData generate_factor_exposure(const std::vector<std::string>& asse
FactorExposureData data;
data.factors = {"Market", "Size", "Value", "Momentum", "Low Vol", "Quality", "Yield"};
data.assets = assets;
- for (const auto& asset : assets) {
+ for ([[maybe_unused]] const auto& asset : assets) {
std::vector<float> row;
// Market factor: most equities high
row.push_back(0.8f + (randf() - 0.5f) * 0.3f);
@@ -690,7 +690,7 @@ MonetaryPolicyData generate_monetary_policy() {
for (int i = 0; i < (int)data.central_banks.size(); i++) {
std::vector<float> row;
float rate = current_rates[i];
- for (int m : data.meetings_ahead) {
+ for ([[maybe_unused]] int m : data.meetings_ahead) {
rate += expected_cuts[i] * (randf() > 0.5f ? 1.0f : 0.0f);
row.push_back(rate + (randf() - 0.5f) * 0.05f);
}
diff --git a/fincept-qt/src/services/agents/AgentService.cpp b/fincept-qt/src/services/agents/AgentService.cpp
index 4d529c8e3..1b6a85edb 100644
--- a/fincept-qt/src/services/agents/AgentService.cpp
+++ b/fincept-qt/src/services/agents/AgentService.cpp
@@ -1266,7 +1266,7 @@ void AgentService::run_portfolio_analysis(const QString& analysis_type, const QJ
// ── Plan variants ────────────────────────────────────────────────────────────
-QString AgentService::create_stock_analysis_plan(const QString& symbol, const QJsonObject& config) {
+QString AgentService::create_stock_analysis_plan(const QString& symbol, const QJsonObject& /*config*/) {
LOG_INFO("AgentService", QString("Stock analysis plan: %1").arg(symbol));
const QString req_id = QUuid::createUuid().toString(QUuid::WithoutBraces);
QJsonObject params;
@@ -1301,7 +1301,7 @@ QString AgentService::create_stock_analysis_plan(const QString& symbol, const QJ
return req_id;
}
-QString AgentService::create_portfolio_plan(const QJsonObject& goals, const QJsonObject& config) {
+QString AgentService::create_portfolio_plan(const QJsonObject& goals, const QJsonObject& /*config*/) {
LOG_INFO("AgentService", "Portfolio plan");
const QString req_id = QUuid::createUuid().toString(QUuid::WithoutBraces);
QJsonObject params;
diff --git a/fincept-qt/src/services/data_normalization/DataNormalizationService.cpp b/fincept-qt/src/services/data_normalization/DataNormalizationService.cpp
index 9d44c00f8..735a1c70f 100644
--- a/fincept-qt/src/services/data_normalization/DataNormalizationService.cpp
+++ b/fincept-qt/src/services/data_normalization/DataNormalizationService.cpp
@@ -6,6 +6,7 @@
#include <QCryptographicHash>
#include <QDateTime>
+#include <QTimeZone>
#include <QJsonArray>
#include <QJsonDocument>
#include <QJsonValue>
@@ -267,12 +268,12 @@ QJsonValue DataNormalizationService::apply_transform(const QJsonValue& val, cons
if (transform == "unix_ms_to_iso") {
qint64 ms = val.isDouble() ? static_cast<qint64>(val.toDouble()) : val.toString().toLongLong();
- return QJsonValue(QDateTime::fromMSecsSinceEpoch(ms, Qt::UTC).toString(Qt::ISODate));
+ return QJsonValue(QDateTime::fromMSecsSinceEpoch(ms, QTimeZone::UTC).toString(Qt::ISODate));
}
if (transform == "unix_s_to_iso") {
qint64 s = val.isDouble() ? static_cast<qint64>(val.toDouble()) : val.toString().toLongLong();
- return QJsonValue(QDateTime::fromSecsSinceEpoch(s, Qt::UTC).toString(Qt::ISODate));
+ return QJsonValue(QDateTime::fromSecsSinceEpoch(s, QTimeZone::UTC).toString(Qt::ISODate));
}
if (transform == "upper") {
diff --git a/fincept-qt/src/services/dbnomics/DBnomicsService.cpp b/fincept-qt/src/services/dbnomics/DBnomicsService.cpp
index e4de00a40..3909480e0 100644
--- a/fincept-qt/src/services/dbnomics/DBnomicsService.cpp
+++ b/fincept-qt/src/services/dbnomics/DBnomicsService.cpp
@@ -136,12 +136,12 @@ void DBnomicsService::fetch_datasets(const QString& provider_code, int offset) {
o["name"] = d.name;
arr.append(o);
}
- QJsonObject root;
- root["docs"] = arr;
- root["total"] = total;
+ QJsonObject cache_root;
+ cache_root["docs"] = arr;
+ cache_root["total"] = total;
fincept::CacheManager::instance().put(
"dbnomics:datasets:" + provider_code,
- QVariant(QString::fromUtf8(QJsonDocument(root).toJson(QJsonDocument::Compact))), kDatasetCacheSec,
+ QVariant(QString::fromUtf8(QJsonDocument(cache_root).toJson(QJsonDocument::Compact))), kDatasetCacheSec,
"dbnomics");
}
LOG_INFO("DBnomicsService", QString("Loaded %1 datasets (total=%2)").arg(out.size()).arg(total));
@@ -205,18 +205,18 @@ void DBnomicsService::fetch_series(const QString& provider_code, const QString&
if (first_page && no_query) {
QJsonArray arr;
- for (const auto& s : out) {
+ for (const auto& si : out) {
QJsonObject o;
- o["code"] = s.code;
- o["name"] = s.name;
+ o["code"] = si.code;
+ o["name"] = si.name;
arr.append(o);
}
- QJsonObject root;
- root["docs"] = arr;
- root["total"] = total;
+ QJsonObject cache_root;
+ cache_root["docs"] = arr;
+ cache_root["total"] = total;
fincept::CacheManager::instance().put(
"dbnomics:series:" + cache_key,
- QVariant(QString::fromUtf8(QJsonDocument(root).toJson(QJsonDocument::Compact))), kSeriesCacheSec,
+ QVariant(QString::fromUtf8(QJsonDocument(cache_root).toJson(QJsonDocument::Compact))), kSeriesCacheSec,
"dbnomics");
}
LOG_INFO("DBnomicsService", QString("Loaded %1 series (total=%2)").arg(out.size()).arg(total));
diff --git a/fincept-qt/src/services/geopolitics/GeopoliticsService.cpp b/fincept-qt/src/services/geopolitics/GeopoliticsService.cpp
index 23f21014c..60d6d6859 100644
--- a/fincept-qt/src/services/geopolitics/GeopoliticsService.cpp
+++ b/fincept-qt/src/services/geopolitics/GeopoliticsService.cpp
@@ -71,7 +71,7 @@ void GeopoliticsService::fetch_events(const QString& country, const QString& cit
return;
}
auto root = result.value().object();
- // API returns {success, data: {events: [...]}} — unwrap the data envelope
+ // API returns {success, message, data: {events: [...], pagination: {...}}}
auto obj = root.contains("data") ? root["data"].toObject() : root;
auto arr = obj["events"].toArray();
QVector<NewsEvent> events;
@@ -80,33 +80,40 @@ void GeopoliticsService::fetch_events(const QString& country, const QString& cit
auto e = v.toObject();
NewsEvent ev;
ev.url = e["url"].toString();
- ev.domain = e["domain"].toString();
+ ev.source = e["source"].toString();
ev.event_category = e["event_category"].toString();
- ev.matched_keywords = e["matched_keywords"].toString();
+ ev.title = e["title"].toString();
ev.city = e["city"].toString();
ev.country = e["country"].toString();
- ev.latitude = e["latitude"].toDouble();
- ev.longitude = e["longitude"].toDouble();
+ const auto lat_v = e["latitude"];
+ const auto lng_v = e["longitude"];
+ ev.has_coords = lat_v.isDouble() && lng_v.isDouble();
+ ev.latitude = ev.has_coords ? lat_v.toDouble() : 0.0;
+ ev.longitude = ev.has_coords ? lng_v.toDouble() : 0.0;
ev.extracted_date = e["extracted_date"].toString();
ev.created_at = e["created_at"].toString();
- // Filter out invalid coordinates
- if (std::isnan(ev.latitude) || std::isnan(ev.longitude))
- continue;
events.append(ev);
}
- int total = obj.contains("total") ? obj["total"].toInt() : events.size();
+ // Pagination envelope replaces the old flat "total" field
+ int total = events.size();
+ if (obj.contains("pagination"))
+ total = obj["pagination"].toObject()["total_events"].toInt(total);
+ else if (obj.contains("total"))
+ total = obj["total"].toInt(total);
// Serialize events to JSON for CacheManager persistence
QJsonArray cached_arr;
for (const auto& ev : events) {
QJsonObject o;
o["url"] = ev.url;
- o["domain"] = ev.domain;
+ o["source"] = ev.source;
o["event_category"] = ev.event_category;
- o["matched_keywords"] = ev.matched_keywords;
+ o["title"] = ev.title;
o["city"] = ev.city;
o["country"] = ev.country;
- o["latitude"] = ev.latitude;
- o["longitude"] = ev.longitude;
+ if (ev.has_coords) {
+ o["latitude"] = ev.latitude;
+ o["longitude"] = ev.longitude;
+ }
o["extracted_date"] = ev.extracted_date;
o["created_at"] = ev.created_at;
cached_arr.append(o);
@@ -225,19 +232,21 @@ void GeopoliticsService::fetch_unique_categories() {
void GeopoliticsService::fetch_unique_cities() {
QPointer<GeopoliticsService> self = this;
- HttpClient::instance().get(QString(kApiBase) + "/unique-cities", [self](Result<QJsonDocument> result) {
+ HttpClient::instance().get(QString(kApiBase) + "?get_unique_cities=true", [self](Result<QJsonDocument> result) {
if (!self)
return;
if (!result.is_ok()) {
emit self->error_occurred("cities", QString::fromStdString(result.error()));
return;
}
- auto arr = result.value().array();
+ // Response: {success, message, data: {unique_cities: [{city, country}, ...]}}
+ auto root = result.value().object();
+ auto data = root.contains("data") ? root["data"].toObject() : root;
+ auto arr = data["unique_cities"].toArray();
QStringList cities;
cities.reserve(arr.size());
for (const auto& v : arr) {
- auto o = v.toObject();
- auto city = o["city"].toString();
+ const auto city = v.toObject()["city"].toString();
if (!city.isEmpty())
cities.append(city);
}
@@ -292,8 +301,6 @@ static QVector<HDXDataset> parse_hdx_results(const QString& output) {
return datasets;
}
-static inline void publish_hdx(GeopoliticsService* self, const QString& context, const QVector<HDXDataset>& datasets);
-
void GeopoliticsService::search_hdx_conflicts() {
run_python("hdx_data.py", {"search_conflict", "", "20"}, "hdx_conflicts", [this](bool ok, const QString& out) {
if (!ok) {
diff --git a/fincept-qt/src/services/geopolitics/GeopoliticsTypes.h b/fincept-qt/src/services/geopolitics/GeopoliticsTypes.h
index c55da7eb4..9f5a87197 100644
--- a/fincept-qt/src/services/geopolitics/GeopoliticsTypes.h
+++ b/fincept-qt/src/services/geopolitics/GeopoliticsTypes.h
@@ -11,13 +11,14 @@ namespace fincept::services::geo {
struct NewsEvent {
QString url;
- QString domain;
+ QString source;
QString event_category;
- QString matched_keywords;
+ QString title;
QString city;
QString country;
double latitude = 0;
double longitude = 0;
+ bool has_coords = false;
QString extracted_date;
QString created_at;
};
diff --git a/fincept-qt/src/services/workflow/adapters/ServiceBridges.cpp b/fincept-qt/src/services/workflow/adapters/ServiceBridges.cpp
index 68c97eeed..82bd01cba 100644
--- a/fincept-qt/src/services/workflow/adapters/ServiceBridges.cpp
+++ b/fincept-qt/src/services/workflow/adapters/ServiceBridges.cpp
@@ -134,7 +134,7 @@ void wire_trading_bridges(NodeRegistry& registry) {
// ── Agent Bridge ───────────────────────────────────────────────────────
-void wire_agent_bridges(NodeRegistry& registry) {
+void wire_agent_bridges(NodeRegistry& /*registry*/) {
// agent.run and agent.tool_picker have real executors from AgentNodes.cpp.
// agent.single/agent.multi/agent.mediator are legacy stubs — leave their
// executors to the fallback pass-through in wire_all_bridges if still null.
diff --git a/fincept-qt/src/services/workflow/nodes/AnalyticsNodes.cpp b/fincept-qt/src/services/workflow/nodes/AnalyticsNodes.cpp
index 64891c1e3..7bc93bdc7 100644
--- a/fincept-qt/src/services/workflow/nodes/AnalyticsNodes.cpp
+++ b/fincept-qt/src/services/workflow/nodes/AnalyticsNodes.cpp
@@ -44,14 +44,6 @@ void analytics_run_python_json(const QString& script, const QStringList& args,
});
}
-// Helper: produce a clear "not yet implemented" result object.
-QJsonValue analytics_not_implemented(const QString& type_id) {
- QJsonObject obj;
- obj["error"] = "not_yet_implemented";
- obj["node"] = type_id;
- return obj;
-}
-
} // anonymous namespace
void register_analytics_nodes(NodeRegistry& registry) {
@@ -585,14 +577,13 @@ void register_analytics_nodes(NodeRegistry& registry) {
}
double peak = prices[0], max_dd = 0;
- int dd_start = 0, dd_end = 0, dd_peak_idx = 0;
+ int dd_start = 0, dd_end = 0;
int current_dd_start = 0;
int max_dd_duration = 0, current_duration = 0;
for (int i = 0; i < prices.size(); ++i) {
if (prices[i] > peak) {
peak = prices[i];
- dd_peak_idx = i;
current_dd_start = i;
current_duration = 0;
}
diff --git a/fincept-qt/src/services/workflow/nodes/MarketDataNodes.cpp b/fincept-qt/src/services/workflow/nodes/MarketDataNodes.cpp
index 9dd618c1f..72195b6f0 100644
--- a/fincept-qt/src/services/workflow/nodes/MarketDataNodes.cpp
+++ b/fincept-qt/src/services/workflow/nodes/MarketDataNodes.cpp
@@ -43,14 +43,6 @@ void run_python_json(const QString& script, const QStringList& args,
});
}
-// Helper: produce a clear "not yet implemented" result object.
-QJsonValue not_implemented(const QString& type_id) {
- QJsonObject obj;
- obj["error"] = "not_yet_implemented";
- obj["node"] = type_id;
- return obj;
-}
-
} // anonymous namespace
void register_market_data_nodes(NodeRegistry& registry) {
diff --git a/fincept-qt/src/storage/cache/CacheManager.cpp b/fincept-qt/src/storage/cache/CacheManager.cpp
index 0135b3d61..b7ae041cf 100644
--- a/fincept-qt/src/storage/cache/CacheManager.cpp
+++ b/fincept-qt/src/storage/cache/CacheManager.cpp
@@ -3,6 +3,7 @@
#include "storage/sqlite/CacheDatabase.h"
#include <QSqlQuery>
+#include <utility>
namespace fincept {
@@ -61,7 +62,7 @@ QVariant CacheManager::get(const QString& key) const {
if (r.is_err())
return {};
- QSqlQuery q = r.value();
+ QSqlQuery q = std::move(r.value());
if (!q.next())
return {};
@@ -86,7 +87,7 @@ bool CacheManager::has(const QString& key) const {
if (r.is_err())
return false;
- QSqlQuery q = r.value();
+ QSqlQuery q = std::move(r.value());
return q.next();
}
@@ -130,7 +131,7 @@ int CacheManager::entry_count() const {
if (r.is_err())
return 0;
- QSqlQuery q = r.value();
+ QSqlQuery q = std::move(r.value());
return q.next() ? q.value(0).toInt() : 0;
}
diff --git a/fincept-qt/src/storage/sqlite/migrations/v015_screen_state.cpp b/fincept-qt/src/storage/sqlite/migrations/v015_screen_state.cpp
index 548e13ca4..dc7577b6d 100644
--- a/fincept-qt/src/storage/sqlite/migrations/v015_screen_state.cpp
+++ b/fincept-qt/src/storage/sqlite/migrations/v015_screen_state.cpp
@@ -13,13 +13,6 @@
namespace fincept {
namespace {
-Result<void> sql(QSqlDatabase& db, const char* stmt) {
- QSqlQuery q(db);
- if (!q.exec(stmt))
- return Result<void>::err(q.lastError().text().toStdString());
- return Result<void>::ok();
-}
-
Result<void> apply_v015(QSqlDatabase& /*db*/) {
// This migration runs its DDL on cache.db, not fincept.db.
// The version record is still tracked in fincept.db schema_version
diff --git a/fincept-qt/src/trading/AccountDataStream.cpp b/fincept-qt/src/trading/AccountDataStream.cpp
index 3cb37ae38..4c1e674b2 100644
--- a/fincept-qt/src/trading/AccountDataStream.cpp
+++ b/fincept-qt/src/trading/AccountDataStream.cpp
@@ -175,7 +175,7 @@ void AccountDataStream::async_fetch_quote() {
const QString symbol = selected_symbol_;
QPointer<AccountDataStream> self = this;
- QtConcurrent::run([self, acct_id, bid, symbol]() {
+ (void)QtConcurrent::run([self, acct_id, bid, symbol]() {
auto* broker = BrokerRegistry::instance().get(bid);
if (!broker) {
if (self) self->quote_fetching_ = false;
@@ -209,7 +209,7 @@ void AccountDataStream::async_fetch_positions() {
const QString bid = broker_id_;
QPointer<AccountDataStream> self = this;
- QtConcurrent::run([self, acct_id, bid]() {
+ (void)QtConcurrent::run([self, acct_id, bid]() {
auto* broker = BrokerRegistry::instance().get(bid);
if (!broker) return;
auto creds = AccountManager::instance().load_credentials(acct_id);
@@ -235,7 +235,7 @@ void AccountDataStream::async_fetch_holdings() {
const QString bid = broker_id_;
QPointer<AccountDataStream> self = this;
- QtConcurrent::run([self, acct_id, bid]() {
+ (void)QtConcurrent::run([self, acct_id, bid]() {
auto* broker = BrokerRegistry::instance().get(bid);
if (!broker) return;
auto creds = AccountManager::instance().load_credentials(acct_id);
@@ -261,7 +261,7 @@ void AccountDataStream::async_fetch_orders() {
const QString bid = broker_id_;
QPointer<AccountDataStream> self = this;
- QtConcurrent::run([self, acct_id, bid]() {
+ (void)QtConcurrent::run([self, acct_id, bid]() {
auto* broker = BrokerRegistry::instance().get(bid);
if (!broker) return;
auto creds = AccountManager::instance().load_credentials(acct_id);
@@ -287,7 +287,7 @@ void AccountDataStream::async_fetch_funds() {
const QString bid = broker_id_;
QPointer<AccountDataStream> self = this;
- QtConcurrent::run([self, acct_id, bid]() {
+ (void)QtConcurrent::run([self, acct_id, bid]() {
auto* broker = BrokerRegistry::instance().get(bid);
if (!broker) return;
auto creds = AccountManager::instance().load_credentials(acct_id);
@@ -316,7 +316,7 @@ void AccountDataStream::async_fetch_watchlist_quotes() {
const QStringList symbols = watchlist_symbols_;
QPointer<AccountDataStream> self = this;
- QtConcurrent::run([self, acct_id, bid, symbols]() {
+ (void)QtConcurrent::run([self, acct_id, bid, symbols]() {
auto* broker = BrokerRegistry::instance().get(bid);
if (!broker) return;
auto creds = AccountManager::instance().load_credentials(acct_id);
@@ -341,7 +341,7 @@ void AccountDataStream::fetch_candles(const QString& symbol, const QString& time
const QString bid = broker_id_;
QPointer<AccountDataStream> self = this;
- QtConcurrent::run([self, acct_id, bid, symbol, timeframe]() {
+ (void)QtConcurrent::run([self, acct_id, bid, symbol, timeframe]() {
auto* broker = BrokerRegistry::instance().get(bid);
if (!broker) {
if (self) self->candles_fetching_ = false;
@@ -389,7 +389,7 @@ void AccountDataStream::fetch_orderbook(const QString& symbol) {
const QString bid = broker_id_;
QPointer<AccountDataStream> self = this;
- QtConcurrent::run([self, acct_id, bid, symbol]() {
+ (void)QtConcurrent::run([self, acct_id, bid, symbol]() {
auto* broker = BrokerRegistry::instance().get(bid);
if (!broker) return;
auto creds = AccountManager::instance().load_credentials(acct_id);
@@ -451,7 +451,7 @@ void AccountDataStream::fetch_time_sales(const QString& symbol) {
const QString bid = broker_id_;
QPointer<AccountDataStream> self = this;
- QtConcurrent::run([self, acct_id, bid, symbol]() {
+ (void)QtConcurrent::run([self, acct_id, bid, symbol]() {
auto* broker = BrokerRegistry::instance().get(bid);
if (!broker) return;
auto creds = AccountManager::instance().load_credentials(acct_id);
@@ -471,7 +471,7 @@ void AccountDataStream::fetch_latest_trade(const QString& symbol) {
const QString bid = broker_id_;
QPointer<AccountDataStream> self = this;
- QtConcurrent::run([self, acct_id, bid, symbol]() {
+ (void)QtConcurrent::run([self, acct_id, bid, symbol]() {
auto* broker = BrokerRegistry::instance().get(bid);
if (!broker) return;
auto creds = AccountManager::instance().load_credentials(acct_id);
@@ -490,7 +490,7 @@ void AccountDataStream::fetch_calendar() {
const QString bid = broker_id_;
QPointer<AccountDataStream> self = this;
- QtConcurrent::run([self, acct_id, bid]() {
+ (void)QtConcurrent::run([self, acct_id, bid]() {
auto* broker = BrokerRegistry::instance().get(bid);
if (!broker) return;
auto creds = AccountManager::instance().load_credentials(acct_id);
@@ -510,7 +510,7 @@ void AccountDataStream::fetch_clock() {
const QString bid = broker_id_;
QPointer<AccountDataStream> self = this;
- QtConcurrent::run([self, acct_id, bid]() {
+ (void)QtConcurrent::run([self, acct_id, bid]() {
auto* broker = BrokerRegistry::instance().get(bid);
if (!broker) return;
auto creds = AccountManager::instance().load_credentials(acct_id);
diff --git a/fincept-qt/src/trading/ExchangeService.cpp b/fincept-qt/src/trading/ExchangeService.cpp
index 53f91d63d..0984187c1 100644
--- a/fincept-qt/src/trading/ExchangeService.cpp
+++ b/fincept-qt/src/trading/ExchangeService.cpp
@@ -143,7 +143,7 @@ void ExchangeService::poll_prices() {
QPointer<ExchangeService> self = this;
QPointer<ExchangeSession> session_ptr = sess;
- QtConcurrent::run([self, session_ptr, symbols, watched]() {
+ (void)QtConcurrent::run([self, session_ptr, symbols, watched]() {
if (!self || !session_ptr)
return;
auto tickers = session_ptr->fetch_tickers(symbols);
diff --git a/fincept-qt/src/trading/brokers/GenericBroker.h b/fincept-qt/src/trading/brokers/GenericBroker.h
index 5998127ab..7487fb3fc 100644
--- a/fincept-qt/src/trading/brokers/GenericBroker.h
+++ b/fincept-qt/src/trading/brokers/GenericBroker.h
@@ -11,7 +11,7 @@ namespace fincept::trading {
class GenericBroker : public IBroker {
public:
TokenExchangeResponse exchange_token(const QString&, const QString&, const QString&) override {
- return {false, "", "", "", QString("Not implemented for %1").arg(name())};
+ return {false, "", "", "", QString("Not implemented for %1").arg(name()), ""};
}
OrderPlaceResponse place_order(const BrokerCredentials&, const UnifiedOrder&) override {
return {false, "", QString("Not implemented for %1").arg(name())};
diff --git a/fincept-qt/src/trading/brokers/aliceblue/AliceBlueBroker.cpp b/fincept-qt/src/trading/brokers/aliceblue/AliceBlueBroker.cpp
index f90e18b5d..e7e7fe81e 100644
--- a/fincept-qt/src/trading/brokers/aliceblue/AliceBlueBroker.cpp
+++ b/fincept-qt/src/trading/brokers/aliceblue/AliceBlueBroker.cpp
@@ -128,19 +128,19 @@ TokenExchangeResponse AliceBlueBroker::exchange_token(const QString& api_key, co
auto resp = BrokerHttp::instance().post_json(AUTH_URL, body, headers);
if (!resp.success)
- return {false, "", "", "", checked_error(resp, "Network error")};
+ return {false, "", "", "", checked_error(resp, "Network error"), ""};
QString stat = resp.json["stat"].toString();
if (stat != "Ok")
- return {false, "", "", "", checked_error(resp, "Authentication failed")};
+ return {false, "", "", "", checked_error(resp, "Authentication failed"), ""};
QString session = resp.json["userSession"].toString();
QString client_id = resp.json["clientId"].toString();
if (session.isEmpty())
- return {false, "", "", "", "No userSession in response"};
+ return {false, "", "", "", "No userSession in response", ""};
- return {true, session, client_id, "", ""};
+ return {true, session, client_id, "", "", ""};
}
// ============================================================================
diff --git a/fincept-qt/src/trading/brokers/angelone/AngelOneBroker.cpp b/fincept-qt/src/trading/brokers/angelone/AngelOneBroker.cpp
index 67ac16c66..11462e0ef 100644
--- a/fincept-qt/src/trading/brokers/angelone/AngelOneBroker.cpp
+++ b/fincept-qt/src/trading/brokers/angelone/AngelOneBroker.cpp
@@ -719,15 +719,6 @@ QString AngelOneBroker::checked_error(const BrokerHttpResponse& resp, const QStr
return msg;
}
-static QString margin_error(const BrokerHttpResponse& resp, const QString& fallback) {
- QString msg = resp.json.value("message").toString();
- if (msg.isEmpty())
- msg = resp.error;
- if (msg.isEmpty())
- msg = fallback;
- return msg;
-}
-
static double read_num_any(const QJsonObject& o, const QStringList& keys) {
for (const auto& k : keys) {
if (!o.contains(k))
diff --git a/fincept-qt/src/trading/brokers/fivepaisa/FivePaisaBroker.cpp b/fincept-qt/src/trading/brokers/fivepaisa/FivePaisaBroker.cpp
index 227b8b52a..ddb3f9f68 100644
--- a/fincept-qt/src/trading/brokers/fivepaisa/FivePaisaBroker.cpp
+++ b/fincept-qt/src/trading/brokers/fivepaisa/FivePaisaBroker.cpp
@@ -133,11 +133,11 @@ TokenExchangeResponse FivePaisaBroker::exchange_token(const QString& api_key, co
const QString& auth_code) {
auto kp = unpack_key(api_key);
if (kp.app_key.isEmpty())
- return {false, "", "", "", "ApiKey must be 'app_key:::user_id:::client_id'"};
+ return {false, "", "", "", "ApiKey must be 'app_key:::user_id:::client_id'", ""};
QStringList auth_parts = auth_code.split(":::");
if (auth_parts.size() < 3)
- return {false, "", "", "", "AuthCode must be 'email:::pin:::totp'"};
+ return {false, "", "", "", "AuthCode must be 'email:::pin:::totp'", ""};
QString email = auth_parts[0].trimmed();
QString pin = auth_parts[1].trimmed();
QString totp = auth_parts[2].trimmed();
@@ -163,12 +163,12 @@ TokenExchangeResponse FivePaisaBroker::exchange_token(const QString& api_key, co
BrokerHttp::instance().post_json(QString(BASE_URL) + "/VendorsAPI/Service1.svc/TOTPLogin", req, headers);
if (!resp.success)
- return {false, "", "", "", checked_error(resp, "TOTP login network error")};
+ return {false, "", "", "", checked_error(resp, "TOTP login network error"), ""};
QString req_token = resp.json["body"].toObject()["RequestToken"].toString();
if (req_token.isEmpty()) {
QString msg = resp.json["body"].toObject()["Message"].toString();
- return {false, "", "", "", msg.isEmpty() ? "No RequestToken in TOTP response" : msg};
+ return {false, "", "", "", msg.isEmpty() ? "No RequestToken in TOTP response" : msg, ""};
}
// Step 2: Get access token
@@ -186,15 +186,15 @@ TokenExchangeResponse FivePaisaBroker::exchange_token(const QString& api_key, co
req2, headers);
if (!resp2.success)
- return {false, "", "", "", checked_error(resp2, "GetAccessToken network error")};
+ return {false, "", "", "", checked_error(resp2, "GetAccessToken network error"), ""};
QString access_token = resp2.json["body"].toObject()["AccessToken"].toString();
if (access_token.isEmpty()) {
QString msg = resp2.json["body"].toObject()["Message"].toString();
- return {false, "", "", "", msg.isEmpty() ? "No AccessToken in response" : msg};
+ return {false, "", "", "", msg.isEmpty() ? "No AccessToken in response" : msg, ""};
}
- return {true, access_token, kp.client_id, "", ""};
+ return {true, access_token, kp.client_id, "", "", ""};
}
}
diff --git a/fincept-qt/src/trading/brokers/groww/GrowwBroker.cpp b/fincept-qt/src/trading/brokers/groww/GrowwBroker.cpp
index 4120d2108..d70999050 100644
--- a/fincept-qt/src/trading/brokers/groww/GrowwBroker.cpp
+++ b/fincept-qt/src/trading/brokers/groww/GrowwBroker.cpp
@@ -191,13 +191,13 @@ TokenExchangeResponse GrowwBroker::exchange_token(const QString& api_key, const
auto resp = BrokerHttp::instance().post_json("https://api.groww.in/v1/token/api/access", body, headers);
if (!resp.success)
- return {false, "", "", "", checked_error(resp, "Network error")};
+ return {false, "", "", "", checked_error(resp, "Network error"), ""};
QString token = resp.json["token"].toString();
if (token.isEmpty())
- return {false, "", "", "", checked_error(resp, "No token in response")};
+ return {false, "", "", "", checked_error(resp, "No token in response"), ""};
- return {true, token, "", "", ""};
+ return {true, token, "", "", "", ""};
}
// ============================================================================
diff --git a/fincept-qt/src/trading/brokers/ibkr/IBKRBroker.cpp b/fincept-qt/src/trading/brokers/ibkr/IBKRBroker.cpp
index 084bea9ec..6fe6f67cc 100644
--- a/fincept-qt/src/trading/brokers/ibkr/IBKRBroker.cpp
+++ b/fincept-qt/src/trading/brokers/ibkr/IBKRBroker.cpp
@@ -155,22 +155,22 @@ TokenExchangeResponse IBKRBroker::exchange_token(const QString& api_key, const Q
{{"Content-Type", "application/json"}, {"Accept", "application/json"}});
if (!resp.success)
- return {false, "", "", "", "Gateway not reachable at " + gw + ": " + resp.error};
+ return {false, "", "", "", "Gateway not reachable at " + gw + ": " + resp.error, ""};
QJsonDocument doc = QJsonDocument::fromJson(resp.raw_body.toUtf8());
if (!doc.isObject())
- return {false, "", "", "", "Gateway: invalid auth status response"};
+ return {false, "", "", "", "Gateway: invalid auth status response", ""};
QJsonObject obj = doc.object();
bool authenticated = obj.value("authenticated").toBool();
if (!authenticated) {
return {false, "", "", "",
"Gateway is running but not authenticated. "
- "Please log in via the gateway browser interface first."};
+ "Please log in via the gateway browser interface first.", ""};
}
// Store gateway URL as "access_token" — it's the only credential we need at runtime
- return {true, gw, "", api_key, ""};
+ return {true, gw, "", api_key, "", ""};
}
// ---------- place_order ----------
diff --git a/fincept-qt/src/trading/brokers/iifl/IIFLBroker.cpp b/fincept-qt/src/trading/brokers/iifl/IIFLBroker.cpp
index 93d5397aa..97b7d5df5 100644
--- a/fincept-qt/src/trading/brokers/iifl/IIFLBroker.cpp
+++ b/fincept-qt/src/trading/brokers/iifl/IIFLBroker.cpp
@@ -170,19 +170,19 @@ TokenExchangeResponse IIFLBroker::exchange_token(const QString& api_key, const Q
auto trade_resp = http.post_json(QString("%1/user/session").arg(INTERACTIVE_URL), trade_body,
{{"Content-Type", "application/json"}, {"Accept", "application/json"}});
if (!trade_resp.success)
- return {false, "", "", "", "Interactive login failed: " + trade_resp.error};
+ return {false, "", "", "", "Interactive login failed: " + trade_resp.error, ""};
QJsonDocument trade_doc = QJsonDocument::fromJson(trade_resp.raw_body.toUtf8());
if (!trade_doc.isObject())
- return {false, "", "", "", "Interactive login: invalid response"};
+ return {false, "", "", "", "Interactive login: invalid response", ""};
QJsonObject trade_obj = trade_doc.object();
if (trade_obj.value("type").toString() != "success")
- return {false, "", "", "", trade_obj.value("description").toString("Interactive login failed")};
+ return {false, "", "", "", trade_obj.value("description").toString("Interactive login failed"), ""};
QString trade_token = trade_obj.value("result").toObject().value("token").toString();
if (trade_token.isEmpty())
- return {false, "", "", "", "Interactive login: no token in response"};
+ return {false, "", "", "", "Interactive login: no token in response", ""};
// Step 2: Market data login (feed token)
QJsonObject market_body;
@@ -193,26 +193,26 @@ TokenExchangeResponse IIFLBroker::exchange_token(const QString& api_key, const Q
auto market_resp = http.post_json(QString("%1/auth/login").arg(MARKET_DATA_URL), market_body,
{{"Content-Type", "application/json"}, {"Accept", "application/json"}});
if (!market_resp.success)
- return {false, "", "", "", "Market data login failed: " + market_resp.error};
+ return {false, "", "", "", "Market data login failed: " + market_resp.error, ""};
QJsonDocument market_doc = QJsonDocument::fromJson(market_resp.raw_body.toUtf8());
if (!market_doc.isObject())
- return {false, "", "", "", "Market data login: invalid response"};
+ return {false, "", "", "", "Market data login: invalid response", ""};
QJsonObject market_obj = market_doc.object();
if (market_obj.value("type").toString() != "success")
- return {false, "", "", "", market_obj.value("description").toString("Market data login failed")};
+ return {false, "", "", "", market_obj.value("description").toString("Market data login failed"), ""};
QJsonObject market_result = market_obj.value("result").toObject();
QString feed_token = market_result.value("token").toString();
QString user_id = market_result.value("userID").toString();
if (feed_token.isEmpty())
- return {false, "", "", "", "Market data login: no token in response"};
+ return {false, "", "", "", "Market data login: no token in response", ""};
// Pack both tokens
QString packed_token = trade_token + ":::" + feed_token;
- return {true, packed_token, user_id, "", ""};
+ return {true, packed_token, user_id, "", "", ""};
}
// ---------- place_order ----------
diff --git a/fincept-qt/src/trading/brokers/motilal/MotilalBroker.cpp b/fincept-qt/src/trading/brokers/motilal/MotilalBroker.cpp
index 1265bc21d..b57f09bd3 100644
--- a/fincept-qt/src/trading/brokers/motilal/MotilalBroker.cpp
+++ b/fincept-qt/src/trading/brokers/motilal/MotilalBroker.cpp
@@ -170,21 +170,21 @@ TokenExchangeResponse MotilalBroker::exchange_token(const QString& api_key, cons
auto resp = http.post_json(QString("%1/rest/login/v3/authdirectapi").arg(BASE), body, login_headers);
if (!resp.success)
- return {false, "", "", "", "Login failed: " + resp.error};
+ return {false, "", "", "", "Login failed: " + resp.error, ""};
QJsonDocument doc = QJsonDocument::fromJson(resp.raw_body.toUtf8());
if (!doc.isObject())
- return {false, "", "", "", "Login: invalid response"};
+ return {false, "", "", "", "Login: invalid response", ""};
QJsonObject obj = doc.object();
if (obj.value("status").toString() != "SUCCESS")
- return {false, "", "", "", obj.value("message").toString("Login failed")};
+ return {false, "", "", "", obj.value("message").toString("Login failed"), ""};
QString token = obj.value("AuthToken").toString();
if (token.isEmpty())
- return {false, "", "", "", "Login: no AuthToken in response"};
+ return {false, "", "", "", "Login: no AuthToken in response", ""};
- return {true, token, "", api_key, ""};
+ return {true, token, "", api_key, "", ""};
}
// ---------- place_order ----------
@@ -383,7 +383,6 @@ ApiResponse<QVector<BrokerPosition>> MotilalBroker::get_positions(const BrokerCr
continue;
double buy_amt = o.value("buyamount").toDouble();
- double sell_amt = o.value("sellamount").toDouble();
double avg_px = (buy_qty > 0) ? (buy_amt / buy_qty) : 0.0;
BrokerPosition pos;
diff --git a/fincept-qt/src/trading/brokers/saxo/SaxoBankBroker.cpp b/fincept-qt/src/trading/brokers/saxo/SaxoBankBroker.cpp
index c8e79d3e1..b492b0fe7 100644
--- a/fincept-qt/src/trading/brokers/saxo/SaxoBankBroker.cpp
+++ b/fincept-qt/src/trading/brokers/saxo/SaxoBankBroker.cpp
@@ -3,6 +3,7 @@
#include "trading/brokers/BrokerHttp.h"
#include <QDateTime>
+#include <QTimeZone>
#include <QJsonArray>
#include <QJsonDocument>
#include <QUrlQuery>
@@ -119,7 +120,7 @@ QMap<QString, QString> SaxoBankBroker::auth_headers(const BrokerCredentials& cre
TokenExchangeResponse SaxoBankBroker::exchange_token(const QString& api_key, const QString& api_secret,
const QString& auth_code) {
if (auth_code.trimmed().isEmpty())
- return {false, "", "", "", "Authorization code is required"};
+ return {false, "", "", "", "Authorization code is required", ""};
// Try live token endpoint first; fall back to SIM if it fails
// In practice user should specify sim vs live via auth_code prefix "sim:::code"
@@ -139,18 +140,18 @@ TokenExchangeResponse SaxoBankBroker::exchange_token(const QString& api_key, con
{{"Content-Type", "application/x-www-form-urlencoded"}, {"Accept", "application/json"}});
if (!resp.success)
- return {false, "", "", "", "Token exchange failed: " + resp.error};
+ return {false, "", "", "", "Token exchange failed: " + resp.error, ""};
QJsonDocument doc = QJsonDocument::fromJson(resp.raw_body.toUtf8());
if (!doc.isObject())
- return {false, "", "", "", "Token exchange: invalid response"};
+ return {false, "", "", "", "Token exchange: invalid response", ""};
QJsonObject obj = doc.object();
QString access_token = obj.value("access_token").toString();
QString refresh_token = obj.value("refresh_token").toString();
if (access_token.isEmpty())
- return {false, "", "", "", obj.value("error_description").toString("Token exchange failed")};
+ return {false, "", "", "", obj.value("error_description").toString("Token exchange failed"), ""};
// Fetch AccountKey from /port/v1/clients/me
QString base = use_sim ? BASE_SIM : BASE_LIVE;
@@ -168,7 +169,7 @@ TokenExchangeResponse SaxoBankBroker::exchange_token(const QString& api_key, con
}
// Pack refresh_token into additional field
- return {true, access_token, refresh_token, account_key, ""};
+ return {true, access_token, refresh_token, account_key, "", ""};
}
// ---------- place_order ----------
@@ -569,7 +570,7 @@ ApiResponse<QVector<BrokerCandle>> SaxoBankBroker::get_history(const BrokerCrede
}
count = qMax(1, qMin(count, 1200)); // Saxo max is typically 1200
- QString time_str = QDateTime(to, QTime(23, 59, 59), Qt::UTC).toString(Qt::ISODate);
+ QString time_str = QDateTime(to, QTime(23, 59, 59), QTimeZone::UTC).toString(Qt::ISODate);
QString url = QString("%1/chart/v1/charts?Uic=%2&AssetType=Stock&Horizon=%3&Count=%4"
"&Mode=UpTo&Time=%5")
diff --git a/fincept-qt/src/trading/brokers/shoonya/ShoonyaBroker.cpp b/fincept-qt/src/trading/brokers/shoonya/ShoonyaBroker.cpp
index a0b54e465..95c919103 100644
--- a/fincept-qt/src/trading/brokers/shoonya/ShoonyaBroker.cpp
+++ b/fincept-qt/src/trading/brokers/shoonya/ShoonyaBroker.cpp
@@ -141,23 +141,23 @@ TokenExchangeResponse ShoonyaBroker::exchange_token(const QString& api_key, cons
{{"Content-Type", "application/x-www-form-urlencoded"}});
if (!resp.success)
- return {false, "", "", "", "Login failed: " + resp.error};
+ return {false, "", "", "", "Login failed: " + resp.error, ""};
QJsonDocument doc = QJsonDocument::fromJson(resp.raw_body.toUtf8());
if (!doc.isObject())
- return {false, "", "", "", "Login: invalid response"};
+ return {false, "", "", "", "Login: invalid response", ""};
QJsonObject obj = doc.object();
if (obj.value("stat").toString() != "Ok")
- return {false, "", "", "", obj.value("emsg").toString("Login failed")};
+ return {false, "", "", "", obj.value("emsg").toString("Login failed"), ""};
QString token = obj.value("susertoken").toString();
QString uid = obj.value("uid").toString(api_key);
if (token.isEmpty())
- return {false, "", "", "", "Login: no susertoken in response"};
+ return {false, "", "", "", "Login: no susertoken in response", ""};
- return {true, token, "", uid, ""};
+ return {true, token, "", uid, "", ""};
}
// ---------- place_order ----------
diff --git a/fincept-qt/src/trading/brokers/tradier/TradierBroker.cpp b/fincept-qt/src/trading/brokers/tradier/TradierBroker.cpp
index 36a849f4c..70a4c2eaa 100644
--- a/fincept-qt/src/trading/brokers/tradier/TradierBroker.cpp
+++ b/fincept-qt/src/trading/brokers/tradier/TradierBroker.cpp
@@ -3,6 +3,7 @@
#include "trading/brokers/BrokerHttp.h"
#include <QDateTime>
+#include <QTimeZone>
#include <QJsonArray>
#include <QJsonDocument>
#include <QUrlQuery>
@@ -86,7 +87,7 @@ QMap<QString, QString> TradierBroker::auth_headers(const BrokerCredentials& cred
TokenExchangeResponse TradierBroker::exchange_token(const QString& api_key, const QString& api_secret,
const QString& /*auth_code*/) {
if (api_key.trimmed().isEmpty())
- return {false, "", "", "", "Access token is required"};
+ return {false, "", "", "", "Access token is required", ""};
QString env_base = (api_secret.trimmed().toLower() == "sandbox" || api_secret.trimmed().toLower() == "paper")
? "https://sandbox.tradier.com"
@@ -98,17 +99,17 @@ TokenExchangeResponse TradierBroker::exchange_token(const QString& api_key, cons
if (!resp.success) {
if (resp.status_code == 401)
- return {false, "", "", "", "[TOKEN_EXPIRED] Access token is invalid or expired"};
- return {false, "", "", "", "Profile fetch failed: " + resp.error};
+ return {false, "", "", "", "[TOKEN_EXPIRED] Access token is invalid or expired", ""};
+ return {false, "", "", "", "Profile fetch failed: " + resp.error, ""};
}
QJsonDocument doc = QJsonDocument::fromJson(resp.raw_body.toUtf8());
if (!doc.isObject())
- return {false, "", "", "", "Profile: invalid response"};
+ return {false, "", "", "", "Profile: invalid response", ""};
QJsonObject profile = doc.object().value("profile").toObject();
if (profile.isEmpty())
- return {false, "", "", "", "Profile: missing profile object"};
+ return {false, "", "", "", "Profile: missing profile object", ""};
// account may be object (single) or array (multiple) — take first
QString account_id;
@@ -120,9 +121,9 @@ TokenExchangeResponse TradierBroker::exchange_token(const QString& api_key, cons
}
if (account_id.isEmpty())
- return {false, "", "", "", "Profile: could not find account_number"};
+ return {false, "", "", "", "Profile: could not find account_number", ""};
- return {true, api_key, "", account_id, ""};
+ return {true, api_key, "", account_id, "", ""};
}
// ---------- place_order ----------
@@ -568,7 +569,7 @@ ApiResponse<QVector<BrokerCandle>> TradierBroker::get_history(const BrokerCreden
// date is "YYYY-MM-DD" string — convert to epoch ms
QDate d = QDate::fromString(o.value("date").toString(), "yyyy-MM-dd");
c.timestamp = d.isValid()
- ? static_cast<int64_t>(QDateTime(d, QTime(0, 0, 0), Qt::UTC).toSecsSinceEpoch()) * 1000LL
+ ? static_cast<int64_t>(QDateTime(d, QTime(0, 0, 0), QTimeZone::UTC).toSecsSinceEpoch()) * 1000LL
: 0LL;
c.open = o.value("open").toDouble();
c.high = o.value("high").toDouble();
diff --git a/fincept-qt/src/trading/instruments/InstrumentService.cpp b/fincept-qt/src/trading/instruments/InstrumentService.cpp
index 3b01dff47..b7013b7d3 100644
--- a/fincept-qt/src/trading/instruments/InstrumentService.cpp
+++ b/fincept-qt/src/trading/instruments/InstrumentService.cpp
@@ -232,7 +232,7 @@ void InstrumentService::force_refresh(const QString& broker_id, const BrokerCred
}
emit refresh_started(broker_id);
QPointer<InstrumentService> self = this;
- QtConcurrent::run([self, broker_id, creds]() {
+ (void)QtConcurrent::run([self, broker_id, creds]() {
if (!self)
return;
self->do_refresh(broker_id, creds);
@@ -273,7 +273,7 @@ void InstrumentService::load_from_db_async(const QString& broker_id,
QPointer<InstrumentService> self = this;
QString db_path = fincept::Database::instance().path(); // read path on UI thread before going async
- QtConcurrent::run([self, broker_id, db_path, callback]() {
+ (void)QtConcurrent::run([self, broker_id, db_path, callback]() {
// Each worker thread needs its own named QSqlDatabase connection.
const QString conn_name =
"inst_async_" + broker_id + "_" + QUuid::createUuid().toString(QUuid::WithoutBraces);
diff --git a/fincept-qt/src/trading/websocket/AngelOneWebSocket.cpp b/fincept-qt/src/trading/websocket/AngelOneWebSocket.cpp
index eeb7ce48d..96c6c2ae3 100644
--- a/fincept-qt/src/trading/websocket/AngelOneWebSocket.cpp
+++ b/fincept-qt/src/trading/websocket/AngelOneWebSocket.cpp
@@ -23,6 +23,7 @@
#include <QJsonArray>
#include <QJsonDocument>
#include <QJsonObject>
+#include <QTimeZone>
namespace fincept::trading {
@@ -350,7 +351,7 @@ AoTick AngelOneWebSocket::parse_tick(const QByteArray& data) const {
return tick; // need at least to LTP
tick.sequence_number = read_i64_le(buf + 27);
- tick.exchange_timestamp = QDateTime::fromMSecsSinceEpoch(read_i64_le(buf + 35), Qt::UTC);
+ tick.exchange_timestamp = QDateTime::fromMSecsSinceEpoch(read_i64_le(buf + 35), QTimeZone::UTC);
tick.ltp = paise_to_rupees(read_i64_le(buf + 43));
if (tick.mode == AoSubMode::LTP)
diff --git a/fincept-qt/src/trading/websocket/ZerodhaWebSocket.cpp b/fincept-qt/src/trading/websocket/ZerodhaWebSocket.cpp
index 5bfd3b9ca..a9c1b0d88 100644
--- a/fincept-qt/src/trading/websocket/ZerodhaWebSocket.cpp
+++ b/fincept-qt/src/trading/websocket/ZerodhaWebSocket.cpp
@@ -8,6 +8,7 @@
#include <QJsonDocument>
#include <QJsonObject>
#include <QString>
+#include <QTimeZone>
namespace fincept::trading {
@@ -273,7 +274,7 @@ ZerodhaTick ZerodhaWebSocket::parse_full_packet(const uchar* p) const {
t.oi_day_low = read_i32(p + 56);
qint32 ex_ts = read_i32(p + 60);
- t.exchange_timestamp = QDateTime::fromSecsSinceEpoch(ex_ts, Qt::UTC);
+ t.exchange_timestamp = QDateTime::fromSecsSinceEpoch(ex_ts, QTimeZone::UTC);
// Depth: 5 bids then 5 asks, each 12 bytes
for (int i = 0; i < 5; ++i) {
diff --git a/fincept-qt/src/ui/navigation/CommandBar.cpp b/fincept-qt/src/ui/navigation/CommandBar.cpp
index c166bced7..f0ccecf56 100644
--- a/fincept-qt/src/ui/navigation/CommandBar.cpp
+++ b/fincept-qt/src/ui/navigation/CommandBar.cpp
@@ -664,12 +664,6 @@ void CommandBar::refresh_theme() {
// ── event filter (keyboard nav in input) ─────────────────────────────────────
bool CommandBar::eventFilter(QObject* obj, QEvent* event) {
- if (obj != input_ || event->type() != QEvent::KeyPress)
- return QWidget::eventFilter(obj, event);
-
- auto* ke = static_cast<QKeyEvent*>(event);
- const int count = list_->count();
-
// Navigation keys are handled via KeyConfigManager QActions (connected in setup_key_actions)
return QWidget::eventFilter(obj, event);
}
diff --git a/fincept-qt/src/ui/widgets/ConfettiOverlay.cpp b/fincept-qt/src/ui/widgets/ConfettiOverlay.cpp
index 2d917cc58..9979b6637 100644
--- a/fincept-qt/src/ui/widgets/ConfettiOverlay.cpp
+++ b/fincept-qt/src/ui/widgets/ConfettiOverlay.cpp
@@ -90,7 +90,6 @@ void ConfettiOverlay::show_confetti() {
void ConfettiOverlay::spawn_burst(int count, float origin_x, float spread, float base_vy) {
auto* rng = QRandomGenerator::global();
- int w = width();
for (int i = 0; i < count; ++i) {
Particle p;
@@ -131,7 +130,6 @@ void ConfettiOverlay::tick() {
elapsed_ms_ += timer_->interval();
int h = height();
int w = width();
- float t = elapsed_ms_ / 1000.0f; // time in seconds
// Fade out in the last 3 seconds
float fade = 1.0f;