FinceptTerminal is a modern finance application offering advanced market analytics, investment research, and economic data tools, designed for interactive exploration and data-driven decision-making in a user-friendly environment.
C++ ai-agentsalgorithmic-tradingbloomberg-terminalcppfinancefinancial-marketsfintechgood-first-issueinvestmentinvestment-researchmachine-learningopensourcepythonqtquantitative-financestock-markettrading
fix(ai_chat): capture request-time session context for correct persistence
Abhi Kakadiya7a2f442865bb
diff --git a/fincept-qt/src/screens/ai_chat/AiChatScreen.h b/fincept-qt/src/screens/ai_chat/AiChatScreen.hindex d1b803f7c..f77b1ab17 100644--- a/fincept-qt/src/screens/ai_chat/AiChatScreen.h+++ b/fincept-qt/src/screens/ai_chat/AiChatScreen.h@@ -64,6 +64,11 @@ class AiChatScreen : public QWidget, public IStatefulScreen, public fincept::IGrvoid on_rename_session();void on_stream_chunk(const QString& chunk, bool done);void on_streaming_done(ai_chat::LlmResponse response);+ // New helper that receives the LLM response together with the request snapshot+ void handle_response(const ai_chat::LlmResponse &response,+ const QString &req_session,+ const QString &req_provider,+ const QString &req_model);void on_provider_changed();void on_search_changed(const QString& text);void on_typing_indicator_tick();@@ -114,6 +119,10 @@ class AiChatScreen : public QWidget, public IStatefulScreen, public fincept::IGr// ── State ────────────────────────────────────────────────────────────QString active_session_id_;+ // Snapshot of request‑time context – used by the async response handler+ QString pending_req_session_;+ QString pending_req_provider_;+ QString pending_req_model_;QString active_session_title_;mutable QMutex history_mutex_;std::vector<ai_chat::ConversationMessage> history_;diff --git a/fincept-qt/src/screens/ai_chat/AiChatScreen_Messaging.cpp b/fincept-qt/src/screens/ai_chat/AiChatScreen_Messaging.cppindex bd6e2abec..5f4d650a4 100644--- a/fincept-qt/src/screens/ai_chat/AiChatScreen_Messaging.cpp+++ b/fincept-qt/src/screens/ai_chat/AiChatScreen_Messaging.cpp@@ -131,7 +131,14 @@ void AiChatScreen::on_send() {text);}- input_box_->clear();+// Capture request‑time context for correct persistence+ const QString req_session = active_session_id_;+ const QString req_provider = ai_chat::LlmService::instance().active_provider();+ const QString req_model = ai_chat::LlmService::instance().active_model();+ // Store in member variables so on_streaming_done can use them+ pending_req_session_ = req_session;+ pending_req_provider_ = req_provider;+ pending_req_model_ = req_model;input_box_->setFixedHeight(44);set_input_enabled(false);streaming_ = true;@@ -262,9 +269,13 @@ void AiChatScreen::on_streaming_done(ai_chat::LlmResponse response) {total_messages_++;total_tokens_ += response.total_tokens;update_stats();- ChatRepository::instance().add_message(active_session_id_, "assistant", content,- ai_chat::LlmService::instance().active_provider(),- ai_chat::LlmService::instance().active_model(), response.total_tokens);+ // Use request‑time captured context to persist the assistant message+ ChatRepository::instance().add_message(pending_req_session_, "assistant", content,+ pending_req_provider_, pending_req_model_, response.total_tokens);+ // Clear pending request context to avoid accidental reuse+ pending_req_session_.clear();+ pending_req_provider_.clear();+ pending_req_model_.clear();}scroll_to_bottom();input_box_->setFocus();