FinceptTerminal is a modern finance application offering advanced market analytics, investment research, and economic data tools, designed for interactive exploration and data-driven decision-making in a user-friendly environment.
C++ ai-agentsalgorithmic-tradingbloomberg-terminalcppfinancefinancial-marketsfintechgood-first-issueinvestmentinvestment-researchmachine-learningopensourcepythonqtquantitative-financestock-markettrading
fix(security): scope Fincept auth headers to the configured API host
aaronjmars8077134ffd2d
diff --git a/fincept-qt/src/network/http/HttpClient.cpp b/fincept-qt/src/network/http/HttpClient.cppindex f1c3af28a..a82b5732b 100644--- a/fincept-qt/src/network/http/HttpClient.cpp+++ b/fincept-qt/src/network/http/HttpClient.cpp@@ -16,16 +16,30 @@ HttpClient::HttpClient() {}QNetworkRequest HttpClient::build_request(const QString& url) const {- QString full_url = url.startsWith("http") ? url : (base_url_ + url);+ const bool is_relative = !url.startsWith("http");+ const QString full_url = is_relative ? (base_url_ + url) : url;QUrl qurl(full_url);QNetworkRequest req{qurl};req.setHeader(QNetworkRequest::ContentTypeHeader, "application/json");req.setHeader(QNetworkRequest::UserAgentHeader, "FinceptTerminal/4.0");- if (!api_key_.isEmpty()) {- req.setRawHeader("X-API-Key", api_key_.toUtf8());- }- if (!session_token_.isEmpty()) {- req.setRawHeader("X-Session-Token", session_token_.toUtf8());++ // Only attach Fincept auth headers when the request targets the configured+ // Fincept API host. Notification providers (Slack, Discord, Telegram,+ // PagerDuty, user webhooks, …) and other services pass absolute third-party+ // URLs through this same singleton — without this guard their servers would+ // receive the user's X-API-Key and X-Session-Token in every call.+ const bool same_host = is_relative || [&]() {+ const QUrl base(base_url_);+ return !base.host().isEmpty() && qurl.host().compare(base.host(), Qt::CaseInsensitive) == 0;+ }();++ if (same_host) {+ if (!api_key_.isEmpty()) {+ req.setRawHeader("X-API-Key", api_key_.toUtf8());+ }+ if (!session_token_.isEmpty()) {+ req.setRawHeader("X-Session-Token", session_token_.toUtf8());+ }}return req;}