Skip to content

FinceptTerminal is a modern finance application offering advanced market analytics, investment research, and economic data tools, designed for interactive exploration and data-driven decision-making in a user-friendly environment.

feat(finagent): route CoreAgent.run through PersonaRegistry

tilakpatel229f70fc341ac9
diff --git a/fincept-qt/scripts/agents/finagent_core/core_agent.py b/fincept-qt/scripts/agents/finagent_core/core_agent.py
index b49883e0c..d3f88467f 100644
--- a/fincept-qt/scripts/agents/finagent_core/core_agent.py
+++ b/fincept-qt/scripts/agents/finagent_core/core_agent.py
@@ -39,13 +39,16 @@ class CoreAgent:
api_keys: Optional[Dict[str, str]] = None,
user_id: Optional[str] = None
):
+ from finagent_core.persona_registry import PersonaRegistry
+
self.api_keys = api_keys or {}
self.user_id = user_id
self._agent = None
self._current_config = None
self._modules = {}
- # Advanced modules
+ # Advanced modules — kept as attrs for backward-compat with setup_* calls;
+ # actual per-persona state lives inside PersonaRuntime instances.
self._guardrails = None
self._evaluation = None
self._tracing = None
@@ -53,6 +56,9 @@ class CoreAgent:
self._hooks = None
self._agentic_memory = None
+ # Per-persona runtime cache.
+ self._registry = PersonaRegistry()
+
# ============================================================
# Core Execution Methods
# ============================================================
@@ -62,7 +68,9 @@ class CoreAgent:
query: str,
config: Dict[str, Any],
session_id: Optional[str] = None,
- stream: bool = False
+ stream: bool = False,
+ agent_id: Optional[str] = None,
+ user_id: Optional[str] = None,
) -> Any:
"""
Execute agent with given configuration.
@@ -79,32 +87,35 @@ class CoreAgent:
- markdown: Output format
session_id: Session ID for memory persistence
stream: Enable streaming response
+ agent_id: Persona identifier (falls back to config["agent_id"] or config["id"]).
+ user_id: User identifier (falls back to self.user_id or config["user_id"] or "default").
Returns:
Agent response
"""
- # Inject session_id into config for storage setup
if session_id:
config = {**config, "session_id": session_id}
- # Recreate agent if config changed
- if self._should_recreate_agent(config):
- self._agent = self._create_agent(config)
- self._current_config = config
-
- # Build run kwargs
- run_kwargs = {"input": query} # Agno uses 'input' parameter
-
- if session_id:
- run_kwargs["session_id"] = session_id
-
- if stream:
- run_kwargs["stream"] = True
- return self._agent.run(**run_kwargs)
+ resolved_user_id = (
+ user_id
+ or self.user_id
+ or config.get("user_id")
+ or "default"
+ )
+ resolved_agent_id = (
+ agent_id
+ or config.get("agent_id")
+ or config.get("id")
+ or "unnamed"
+ )
- # Non-streaming run
- response = self._agent.run(**run_kwargs)
- return response
+ runtime = self._registry.get_or_create(
+ user_id=resolved_user_id,
+ agent_id=resolved_agent_id,
+ config=config,
+ api_keys=self.api_keys,
+ )
+ return runtime.run(query, session_id=session_id, stream=stream)
def run_team(
self,
@@ -356,10 +367,21 @@ class CoreAgent:
return self
def setup_agentic_memory(self, config: Dict[str, Any] = None) -> "CoreAgent":
- """Setup agentic memory."""
+ """Deprecated: per-persona agentic memory now lives inside PersonaRuntime.
+
+ This shim remains for backward-compat with any direct caller that
+ pre-configures a top-level module, but requires agent_id in config.
+ Prefer passing memory config through CoreAgent.run() instead.
+ """
from finagent_core.modules import AgenticMemoryModule
- user_id = config.get("user_id") if config else self.user_id or "default"
- self._agentic_memory = AgenticMemoryModule.from_config({"user_id": user_id, **(config or {})})
+ cfg = dict(config or {})
+ cfg.setdefault("user_id", self.user_id or "default")
+ if "agent_id" not in cfg:
+ raise ValueError(
+ "CoreAgent.setup_agentic_memory: 'agent_id' is required in config. "
+ "Prefer CoreAgent.run(..., agent_id=...) which routes through PersonaRegistry."
+ )
+ self._agentic_memory = AgenticMemoryModule.from_config(cfg)
self._modules["agentic_memory"] = self._agentic_memory
return self
diff --git a/fincept-qt/scripts/agents/finagent_core/tests/test_core_agent_facade.py b/fincept-qt/scripts/agents/finagent_core/tests/test_core_agent_facade.py
new file mode 100644
index 000000000..b523f1424
--- /dev/null
+++ b/fincept-qt/scripts/agents/finagent_core/tests/test_core_agent_facade.py
@@ -0,0 +1,70 @@
+from unittest.mock import MagicMock, patch
+
+import pytest
+
+from finagent_core.core_agent import CoreAgent
+
+
+def _cfg(agent_id="warren_buffett_agent"):
+ return {
+ "id": agent_id,
+ "model": {"provider": "openai", "model_id": "gpt-4o", "api_key": "k"},
+ "instructions": "test",
+ }
+
+
+def test_run_routes_to_registry(monkeypatch, tmp_path):
+ monkeypatch.setenv("FINAGENT_DATA_DIR", str(tmp_path))
+ agent = CoreAgent(api_keys={})
+
+ with patch.object(agent._registry, "get_or_create") as mock_get:
+ mock_rt = MagicMock()
+ mock_rt.run.return_value = "ok"
+ mock_get.return_value = mock_rt
+
+ out = agent.run("hi", _cfg("buffett"), agent_id="buffett", user_id="alice")
+
+ assert out == "ok"
+ call = mock_get.call_args
+ assert call.kwargs["user_id"] == "alice"
+ assert call.kwargs["agent_id"] == "buffett"
+
+
+def test_run_infers_agent_id_from_config(monkeypatch, tmp_path):
+ monkeypatch.setenv("FINAGENT_DATA_DIR", str(tmp_path))
+ agent = CoreAgent(api_keys={})
+
+ with patch.object(agent._registry, "get_or_create") as mock_get:
+ mock_get.return_value = MagicMock(run=MagicMock(return_value="ok"))
+ agent.run("q", _cfg("buffett"))
+
+ assert mock_get.call_args.kwargs["agent_id"] == "buffett"
+
+
+def test_run_defaults_user_id_to_default(monkeypatch, tmp_path):
+ monkeypatch.setenv("FINAGENT_DATA_DIR", str(tmp_path))
+ agent = CoreAgent(api_keys={})
+
+ with patch.object(agent._registry, "get_or_create") as mock_get:
+ mock_get.return_value = MagicMock(run=MagicMock(return_value="ok"))
+ agent.run("q", _cfg())
+
+ assert mock_get.call_args.kwargs["user_id"] == "default"
+
+
+def test_different_personas_get_different_runtimes(monkeypatch, tmp_path):
+ monkeypatch.setenv("FINAGENT_DATA_DIR", str(tmp_path))
+ agent = CoreAgent(api_keys={})
+
+ rt1 = MagicMock(run=MagicMock(return_value="r1"))
+ rt2 = MagicMock(run=MagicMock(return_value="r2"))
+
+ def _pick(user_id, agent_id, config, api_keys):
+ return rt1 if agent_id == "buffett" else rt2
+
+ with patch.object(agent._registry, "get_or_create", side_effect=_pick):
+ r1 = agent.run("q", _cfg("buffett"))
+ r2 = agent.run("q", _cfg("ackman"))
+
+ assert r1 == "r1"
+ assert r2 == "r2"