Skip to content

FinceptTerminal is a modern finance application offering advanced market analytics, investment research, and economic data tools, designed for interactive exploration and data-driven decision-making in a user-friendly environment.

fix(algo): seed sma_series/ema_series past a NaN prefix

Ludwig J. Marxfea3d19f82cb
diff --git a/fincept-qt/src/algo_engine/IndicatorEngine.cpp b/fincept-qt/src/algo_engine/IndicatorEngine.cpp
index df70de5f3..cf454fff4 100644
--- a/fincept-qt/src/algo_engine/IndicatorEngine.cpp
+++ b/fincept-qt/src/algo_engine/IndicatorEngine.cpp
@@ -27,16 +27,31 @@ void IndicatorEngine::extract_arrays(const QVector<OhlcvCandle>& candles, QVecto
}
}
+// Both helpers emit a series whose first period-1 samples are NaN, and callers
+// feed exactly such a series straight back in (Stochastic's %D over %K, MACD's
+// signal line over the MACD line, DEMA/TEMA's EMA of an EMA). Seeding the
+// window at index 0 pulls those NaNs into the running sum, and a NaN never
+// leaves a rolling sum or an EMA recursion again, so the whole output is NaN
+// however long the input is. Seed from the first finite sample instead.
+static int first_finite(const QVector<double>& src) {
+ const int n = src.size();
+ int i = 0;
+ while (i < n && !std::isfinite(src[i]))
+ ++i;
+ return i;
+}
+
QVector<double> IndicatorEngine::sma_series(const QVector<double>& src, int period) {
const int n = src.size();
QVector<double> out(n, std::numeric_limits<double>::quiet_NaN());
- if (n < period)
+ const int start = first_finite(src);
+ if (n - start < period)
return out;
double sum = 0;
- for (int i = 0; i < period; ++i)
+ for (int i = start; i < start + period; ++i)
sum += src[i];
- out[period - 1] = sum / period;
- for (int i = period; i < n; ++i) {
+ out[start + period - 1] = sum / period;
+ for (int i = start + period; i < n; ++i) {
sum += src[i] - src[i - period];
out[i] = sum / period;
}
@@ -46,14 +61,15 @@ QVector<double> IndicatorEngine::sma_series(const QVector<double>& src, int peri
QVector<double> IndicatorEngine::ema_series(const QVector<double>& src, int period) {
const int n = src.size();
QVector<double> out(n, std::numeric_limits<double>::quiet_NaN());
- if (n < period)
+ const int start = first_finite(src);
+ if (n - start < period)
return out;
double sum = 0;
- for (int i = 0; i < period; ++i)
+ for (int i = start; i < start + period; ++i)
sum += src[i];
- out[period - 1] = sum / period;
+ out[start + period - 1] = sum / period;
double mult = 2.0 / (period + 1);
- for (int i = period; i < n; ++i)
+ for (int i = start + period; i < n; ++i)
out[i] = (src[i] - out[i - 1]) * mult + out[i - 1];
return out;
}