Fastest and only macOS Dictation app with on-device STT and custom trained AI enhancement model. Windows, iOS testflight! Android, Linux waitlist open! A local Wispr Flow alternative. Follow https://x.com/fluidvoiceapp for more
feat(typing): refuse delivery when focus is certainly not a text field
altic-dev51e62364de18
diff --git a/Sources/Fluid/Analytics/AnalyticsEvent.swift b/Sources/Fluid/Analytics/AnalyticsEvent.swiftindex 9da87570..5b623c07 100644--- a/Sources/Fluid/Analytics/AnalyticsEvent.swift+++ b/Sources/Fluid/Analytics/AnalyticsEvent.swift@@ -86,6 +86,7 @@ enum AnalyticsInsertionOutcome: String {case pasteCommandFailed = "paste_command_failed"case targetUnavailable = "target_unavailable"case targetRestoreFailed = "target_restore_failed"+ case noEditableTarget = "no_editable_target"}struct AnalyticsModelDescriptor: Equatable {diff --git a/Sources/Fluid/Services/DeliveryTargetAssessment.swift b/Sources/Fluid/Services/DeliveryTargetAssessment.swiftnew file mode 100644index 00000000..1d547412--- /dev/null+++ b/Sources/Fluid/Services/DeliveryTargetAssessment.swift@@ -0,0 +1,68 @@+import ApplicationServices+import Foundation++/// Decides, before pasting, whether the focused UI element can take text.+/// `notEditable` is only returned when the answer is certain; every ambiguous+/// case is `unknown` so delivery proceeds exactly as before.+enum DeliveryTargetAssessment: Equatable {+ case editable(role: String)+ case notEditable(role: String)+ case unknown(reason: String)++ var isCertainlyNotEditable: Bool {+ if case .notEditable = self { return true }+ return false+ }++ var logDescription: String {+ switch self {+ case let .editable(role): "editable role=\(role)"+ case let .notEditable(role): "notEditable role=\(role)"+ case let .unknown(reason): "unknown reason=\(reason)"+ }+ }++ /// Roles that never accept typed text. Containers such as AXGroup and+ /// AXWebArea are deliberately absent: web editors report those. Table+ /// roles are absent too: a selected spreadsheet cell reports AXCell or+ /// AXTable and does accept pasted text.+ private static let nonEditableRoles: Set<String> = [+ "AXButton", "AXCheckBox", "AXRadioButton", "AXPopUpButton", "AXMenuButton",+ "AXMenuItem", "AXMenu", "AXMenuBar", "AXMenuBarItem",+ "AXStaticText", "AXImage", "AXLink", "AXDisclosureTriangle",+ "AXScrollBar", "AXSlider", "AXIncrementor", "AXTabGroup", "AXToolbar",+ "AXSplitter", "AXWindow", "AXSheet", "AXDrawer", "AXApplication", "AXDockItem",+ ]++ private static let editableRoles: Set<String> = [+ "AXTextField", "AXTextArea", "AXComboBox", "AXSecureTextField",+ ]++ nonisolated static func assessFocusedElement() -> DeliveryTargetAssessment {+ guard AXIsProcessTrusted() else { return .unknown(reason: "accessibility_not_trusted") }+ var focusedRef: CFTypeRef?+ let result = AXUIElementCopyAttributeValue(+ AXUIElementCreateSystemWide(),+ kAXFocusedUIElementAttribute as CFString,+ &focusedRef+ )+ guard result == .success, let focusedRef, CFGetTypeID(focusedRef) == AXUIElementGetTypeID() else {+ return .unknown(reason: "focused_element_\(result.rawValue)")+ }+ let element = unsafeBitCast(focusedRef, to: AXUIElement.self)++ var roleRef: CFTypeRef?+ guard AXUIElementCopyAttributeValue(element, kAXRoleAttribute as CFString, &roleRef) == .success,+ let role = roleRef as? String+ else { return .unknown(reason: "role_unreadable") }++ if self.editableRoles.contains(role) { return .editable(role: role) }++ var valueSettable = DarwinBoolean(false)+ let settableResult = AXUIElementIsAttributeSettable(element, kAXValueAttribute as CFString, &valueSettable)+ if settableResult == .success, valueSettable.boolValue { return .editable(role: role) }++ guard self.nonEditableRoles.contains(role) else { return .unknown(reason: "role_\(role)") }+ return .notEditable(role: role)+ }+}diff --git a/Sources/Fluid/Services/MenuBarManager.swift b/Sources/Fluid/Services/MenuBarManager.swiftindex 87884dc9..3f97c20e 100644--- a/Sources/Fluid/Services/MenuBarManager.swift+++ b/Sources/Fluid/Services/MenuBarManager.swift@@ -385,6 +385,16 @@ final class MenuBarManager: NSObject, ObservableObject, NSMenuDelegate {)self.isProcessingActive = trueNotchOverlayManager.shared.freezeForStop()+ // Log-only: lets the focused-element assessment be audited on every+ // stop, including runs whose transcript is empty and never reach typing.+ let assessStartedAt = ProcessInfo.processInfo.systemUptime+ let assessment = DeliveryTargetAssessment.assessFocusedElement()+ DebugLogger.shared.info(+ "FOCUS_ASSESS at=stop \(assessment.logDescription) " ++ "frontApp=\(NSWorkspace.shared.frontmostApplication?.bundleIdentifier ?? "nil") " ++ "elapsedUs=\(Int((ProcessInfo.processInfo.systemUptime - assessStartedAt) * 1_000_000))",+ source: "TypingService"+ )self.pendingProcessingShowOperation?.cancel()self.pendingProcessingShowOperation = nilself.pendingHideOperation?.cancel()diff --git a/Sources/Fluid/Services/PasteDeliveryCoordinator.swift b/Sources/Fluid/Services/PasteDeliveryCoordinator.swiftindex 2a22fef4..681e034d 100644--- a/Sources/Fluid/Services/PasteDeliveryCoordinator.swift+++ b/Sources/Fluid/Services/PasteDeliveryCoordinator.swift@@ -11,11 +11,14 @@ enum TextDeliveryFailure: String, Equatable {case pasteCommandFailed = "paste_command_failed"case targetUnavailable = "target_unavailable"case targetRestoreFailed = "target_restore_failed"+ case noEditableTarget = "no_editable_target"var userFacingMessage: String? {switch self {case .accessibilityNotTrusted:"Enable Accessibility to insert text"+ case .noEditableTarget:+ "Not in a text field"case .emptyText, .clipboardSnapshotFailed, .clipboardWriteFailed,.pasteCommandFailed, .targetUnavailable, .targetRestoreFailed:nildiff --git a/Sources/Fluid/Services/TypingService.swift b/Sources/Fluid/Services/TypingService.swiftindex 3d7c5eaa..42dd4ed3 100644--- a/Sources/Fluid/Services/TypingService.swift+++ b/Sources/Fluid/Services/TypingService.swift@@ -507,6 +507,23 @@ final class TypingService {return result}+ // Refuse only when the focused element certainly cannot take text.+ let targetAssessment = DeliveryTargetAssessment.assessFocusedElement()+ DebugLogger.shared.info("FOCUS_ASSESS \(targetAssessment.logDescription)", source: "TypingService")+ if targetAssessment.isCertainlyNotEditable {+ await PasteDeliveryCoordinator.shared.copyBackup(text, enabled: preserveTranscriptOnClipboard)+ self.bench("request_return reason=no_editable_target")+ let result = TextDeliveryResult.recoverableFailure(.noEditableTarget)+ self.recordInsertionLatency(+ path: .notAttempted,+ result: result,+ requestedAt: requestedAt,+ textReadyAt: textReadyAt,+ toggleStopRequestedAt: toggleStopRequestedAt+ )+ return result+ }+let usesClipboard = mode == .reliablePaste ||self.ghosttyTargetPID(preferredTargetPID: preferredTargetPID) != nillet result: TextDeliveryResult@@ -679,6 +696,7 @@ final class TypingService {case .pasteCommandFailed: .pasteCommandFailedcase .targetUnavailable: .targetUnavailablecase .targetRestoreFailed: .targetRestoreFailed+ case .noEditableTarget: .noEditableTarget}}}