Fastest and only macOS Dictation app with on-device STT and custom trained AI enhancement model. Windows, iOS testflight! Android, Linux waitlist open! A local Wispr Flow alternative. Follow https://x.com/fluidvoiceapp for more
Restore the previous meeting language when an empty retranscription fails. Fixes #1033
ParamKataria8dd40e541b9b
diff --git a/Sources/Fluid/Services/Meeting/MeetingSessionCoordinator.swift b/Sources/Fluid/Services/Meeting/MeetingSessionCoordinator.swiftindex 055f8807..6b3d3360 100644--- a/Sources/Fluid/Services/Meeting/MeetingSessionCoordinator.swift+++ b/Sources/Fluid/Services/Meeting/MeetingSessionCoordinator.swift@@ -763,11 +763,17 @@ final class MeetingSessionCoordinator: ObservableObject {session.transcriptTimeDomain = inputSession.transcriptTimeDomain}- private func keepPreviousTranscriptVisible(_ session: inout MeetingSession) -> Bool {- guard !session.transcriptSegments.isEmpty,- let previousLanguage = session.processingAttempts.dropLast().last(where: {- $0.languageCode != nil && $0.errorCode == nil && $0.stage == .completed- })?.languageCode,+ /// The language of the transcript that is still stored, including a completed attempt that produced no text.+ private func previousCompletedLanguage(_ session: MeetingSession) -> String? {+ session.processingAttempts.dropLast().last(where: {+ $0.languageCode != nil && $0.errorCode == nil && $0.stage == .completed+ })?.languageCode+ }++ /// Puts the session language back so a failed attempt cannot reject the save or mislabel an export.+ /// Returns whether a previous completed language replaced the language that did not finish.+ private func restorePreviousCompletedLanguage(_ session: inout MeetingSession) -> Bool {+ guard let previousLanguage = self.previousCompletedLanguage(session),previousLanguage != session.languageCodeelse { return false }session.languageCode = previousLanguage@@ -1776,8 +1782,9 @@ final class MeetingSessionCoordinator: ObservableObject {session.processingAttempts[lastIndex].errorCode = "cancelled"session.processingAttempts[lastIndex].completedAt = Date()}- let keptTranscript = self.keepPreviousTranscriptVisible(&session)- session.state = keptTranscript ? .completed : .interrupted+ let restoredLanguage = self.restorePreviousCompletedLanguage(&session)+ let showCompletedTranscript = restoredLanguage && !session.transcriptSegments.isEmpty+ session.state = showCompletedTranscript ? .completed : .interruptedsession.updatedAt = Date()await self.flushQueuedPersistence()try? await self.store.save(session)@@ -1796,12 +1803,13 @@ final class MeetingSessionCoordinator: ObservableObject {session.processingAttempts[lastIndex].completedAt = Date()}session.failures.append(failure)- let keptTranscript = self.keepPreviousTranscriptVisible(&session)- session.state = keptTranscript ? .completed : .failed+ let restoredLanguage = self.restorePreviousCompletedLanguage(&session)+ let showCompletedTranscript = restoredLanguage && !session.transcriptSegments.isEmpty+ session.state = showCompletedTranscript ? .completed : .failedsession.updatedAt = Date()await self.flushQueuedPersistence()try? await self.store.save(session)- self.publishRetryOutcome(session, failure: keptTranscript ? nil : failure)+ self.publishRetryOutcome(session, failure: showCompletedTranscript ? nil : failure)await self.releaseActivityLease()throw error}diff --git a/Tests/FluidDictationIntegrationTests/MeetingRecoveryTests.swift b/Tests/FluidDictationIntegrationTests/MeetingRecoveryTests.swiftindex 21c38c20..4a95d0cb 100644--- a/Tests/FluidDictationIntegrationTests/MeetingRecoveryTests.swift+++ b/Tests/FluidDictationIntegrationTests/MeetingRecoveryTests.swift@@ -2593,6 +2593,57 @@ final class MeetingRecoveryTests: XCTestCase {XCTAssertEqual(exported?["languageCode"] as? String, "en")}+ func testFailedLanguageChangeOfEmptyTranscriptStillPersists() async throws {+ let dir = self.makeTempDirectory()+ defer { try? FileManager.default.removeItem(at: dir) }+ let store = MeetingSessionStore(rootDirectory: dir)+ let started = Date(timeIntervalSinceNow: -120)+ var session = self.makeSession(+ state: .completed,+ startedAt: started,+ endedAt: Date(),+ audioTracks: [self.makeMicrophoneTrack(chunks: [self.makeFinalizedChunk()])],+ processingAttempts: [MeetingProcessingAttempt(+ id: UUID(),+ startedAt: started,+ completedAt: started.addingTimeInterval(10),+ stage: .completed,+ pipelineVersion: MeetingProcessingPipeline.pipelineVersion,+ asrProvider: "fixture",+ asrModel: "parakeet-tdt-v2",+ languageCode: "en",+ diarizationModel: nil,+ lastCompletedTrackID: nil,+ errorCode: nil+ )]+ )+ session.languageCode = "en"+ try await store.create(session)++ let coordinator = MeetingSessionCoordinator(+ store: store,+ capture: StubCaptureController(),+ processing: DiagnosticFailingProcessingController(error: ProcessingFailure()),+ audioArbiter: StubArbiter()+ )+ await coordinator.ensureRestored()+ do {+ _ = try await coordinator.retryProcessing(sessionID: session.id, languageCode: "nl")+ XCTFail("Expected the language-changing retry to fail during transcription")+ } catch {+ XCTAssertTrue(error is ProcessingFailure)+ }++ let saved = try await store.load(id: session.id)+ let persisted = try XCTUnwrap(saved)+ XCTAssertEqual(persisted.languageCode, "en")+ XCTAssertEqual(persisted.state, .failed)+ XCTAssertTrue(persisted.transcriptSegments.isEmpty)+ XCTAssertFalse(persisted.failures.isEmpty)+ XCTAssertEqual(persisted.processingAttempts.map(\.languageCode), ["en", "nl"])+ XCTAssertNotNil(persisted.processingAttempts.last?.errorCode)+ }+func testProcessingDiagnosticsPreserveFailureAndTranscriptAcrossRetries() async throws {let dir = self.makeTempDirectory()defer { try? FileManager.default.removeItem(at: dir) }