Skip to content

A free, self-hostable news aggregator…

Fix HTML injection via decoded website attribute in feed menu (#9170)

Inverle0cf8815de1bf
diff --git a/p/scripts/main.js b/p/scripts/main.js
index 440a02114..b6b5c8458 100644
--- a/p/scripts/main.js
+++ b/p/scripts/main.js
@@ -1147,9 +1147,10 @@ function init_column_categories() {
const id = itemId.substr(2);
const feed_web = a.getAttribute('data-fweb') || '';
const template = document.getElementById(templateId)
- .innerHTML.replace(/------/g, id).replace('http://example.net/', feed_web);
+ .innerHTML.replace(/------/g, id);
div.insertAdjacentHTML('beforeend', template);
dropdownMenu = div.querySelector('.dropdown-menu');
+ dropdownMenu.querySelector('li.website > a').href = feed_web;
dropdownMenu.style.opacity = '0%'; // Hide initially to prevent dropdown flashing
if (feed_web == '') {
const website = div.querySelector('.item.link.website');