Skip to content

A free, self-hostable news aggregator…

Fix feed dropdown bugs due to hash desync (#8949)

Inverle6984c22b5c9e
diff --git a/p/scripts/main.js b/p/scripts/main.js
index dda796766..ce0df7feb 100644
--- a/p/scripts/main.js
+++ b/p/scripts/main.js
@@ -1171,11 +1171,18 @@ function init_column_categories() {
// Wait for dropdown to be closed so it can be removed
// Dropdown visibility is based on CSS :target
window.addEventListener('hashchange', () => {
- dropdownMenu?.nextElementSibling?.remove(); // dropdown close
- dropdownMenu?.remove();
+ dropdownMenu.nextElementSibling.remove(); // .dropdown-close
+ dropdownMenu.remove();
}, { once: true });
}, { once: true });
+ if (location.hash === a.getAttribute('href')) {
+ // Forcefully trigger the hashchange event listener above in order to show the dropdown
+ // This is needed because the same hash remained from a previous page load
+ // or due to use of back/forward buttons
+ window.dispatchEvent(new Event('hashchange'));
+ }
+
return true;
}
diff --git a/p/themes/base-theme/frss.css b/p/themes/base-theme/frss.css
index 8c1a135fa..7ee1a535c 100644
--- a/p/themes/base-theme/frss.css
+++ b/p/themes/base-theme/frss.css
@@ -1416,7 +1416,7 @@ input[type="search"] {
width: 2.25rem;
}
-.aside_feed .tree-folder-items .item .dropdown-target:target ~ .dropdown-toggle > .icon,
+.aside_feed .tree-folder-items .item .dropdown:has(.dropdown-menu) .dropdown-target:target ~ .dropdown-toggle > .icon,
.aside_feed .tree-folder-items .item:hover .dropdown-toggle > .icon,
.aside_feed .tree-folder-items .item.active .dropdown-toggle > .icon {
visibility: visible;
diff --git a/p/themes/base-theme/frss.rtl.css b/p/themes/base-theme/frss.rtl.css
index 97adde2cb..b526c48e9 100644
--- a/p/themes/base-theme/frss.rtl.css
+++ b/p/themes/base-theme/frss.rtl.css
@@ -1416,7 +1416,7 @@ input[type="search"] {
width: 2.25rem;
}
-.aside_feed .tree-folder-items .item .dropdown-target:target ~ .dropdown-toggle > .icon,
+.aside_feed .tree-folder-items .item .dropdown:has(.dropdown-menu) .dropdown-target:target ~ .dropdown-toggle > .icon,
.aside_feed .tree-folder-items .item:hover .dropdown-toggle > .icon,
.aside_feed .tree-folder-items .item.active .dropdown-toggle > .icon {
visibility: visible;