Skip to content

A free, self-hostable news aggregator…

chore(themes): remove loader.gif and convert remaining consumers to the CSS spinner (#8812)

polybjorn769c87cef1e6
diff --git a/docs/en/contributing.md b/docs/en/contributing.md
index 03461a6fb..001520764 100644
--- a/docs/en/contributing.md
+++ b/docs/en/contributing.md
@@ -65,7 +65,7 @@ Check the [basic information for creating a new theme](./developers/04_Frontend/
This checklist is designed to ensure high-quality system themes while minimizing maintenance efforts.
-* Essential files include: [metadata.json, loader.gif, original.png](./developers/04_Frontend/02_Design.md) (located in the `thumbs` directory).
+* Essential files include: [metadata.json, original.png](./developers/04_Frontend/02_Design.md) (located in the `thumbs` directory).
* Include _frss.css in the "files" section of [`metadata.json`](./developers/04_Frontend/02_Design.md).
* Theme-specific icons reside in the `icons` directory.
* Icons should be provided as `svg` files.
diff --git a/docs/en/developers/04_Frontend/02_Design.md b/docs/en/developers/04_Frontend/02_Design.md
index fb1496985..cc3cb0b2f 100644
--- a/docs/en/developers/04_Frontend/02_Design.md
+++ b/docs/en/developers/04_Frontend/02_Design.md
@@ -7,7 +7,6 @@
The easiest way to create a theme is by copying and modifying the base theme (or another of the pre-installed themes). The base theme can be found in [/p/themes/base-theme](https://github.com/FreshRSS/FreshRSS/tree/edge/p/themes/base-theme). Each Theme requires:
- a `metadata.json` file to describe the theme
-- a `loader.gif` file to use as a loading icon
- an (optional) `icons` folder containing .svg (for icons), .ico (for favicons), and .png (for special cases) files to override existing icons
- a `thumbs` folder containing a file, `original.png` that will be used as the preview for the theme
diff --git a/p/themes/Alternative-Dark/loader.gif b/p/themes/Alternative-Dark/loader.gif
deleted file mode 100644
index 5ff26f0e3..000000000
Binary files a/p/themes/Alternative-Dark/loader.gif and /dev/null differ
diff --git a/p/themes/Ansum/loader.gif b/p/themes/Ansum/loader.gif
deleted file mode 100644
index ce36565b3..000000000
Binary files a/p/themes/Ansum/loader.gif and /dev/null differ
diff --git a/p/themes/Dark-pink/loader.gif b/p/themes/Dark-pink/loader.gif
deleted file mode 100644
index 5ff26f0e3..000000000
Binary files a/p/themes/Dark-pink/loader.gif and /dev/null differ
diff --git a/p/themes/Dark/loader.gif b/p/themes/Dark/loader.gif
deleted file mode 100644
index 86022be71..000000000
Binary files a/p/themes/Dark/loader.gif and /dev/null differ
diff --git a/p/themes/Flat/loader.gif b/p/themes/Flat/loader.gif
deleted file mode 100644
index ce36565b3..000000000
Binary files a/p/themes/Flat/loader.gif and /dev/null differ
diff --git a/p/themes/Mapco/loader.gif b/p/themes/Mapco/loader.gif
deleted file mode 100644
index ce36565b3..000000000
Binary files a/p/themes/Mapco/loader.gif and /dev/null differ
diff --git a/p/themes/Nord/loader.gif b/p/themes/Nord/loader.gif
deleted file mode 100644
index 5ff26f0e3..000000000
Binary files a/p/themes/Nord/loader.gif and /dev/null differ
diff --git a/p/themes/Origine-compact/loader.gif b/p/themes/Origine-compact/loader.gif
deleted file mode 100644
index 5ff26f0e3..000000000
Binary files a/p/themes/Origine-compact/loader.gif and /dev/null differ
diff --git a/p/themes/Origine/loader.gif b/p/themes/Origine/loader.gif
deleted file mode 100644
index 5ff26f0e3..000000000
Binary files a/p/themes/Origine/loader.gif and /dev/null differ
diff --git a/p/themes/Pafat/loader.gif b/p/themes/Pafat/loader.gif
deleted file mode 100644
index a3d327a18..000000000
Binary files a/p/themes/Pafat/loader.gif and /dev/null differ
diff --git a/p/themes/Swage/loader.gif b/p/themes/Swage/loader.gif
deleted file mode 100644
index b7c6647cd..000000000
Binary files a/p/themes/Swage/loader.gif and /dev/null differ
diff --git a/p/themes/base-theme/frss.css b/p/themes/base-theme/frss.css
index fbdd704f2..63d871298 100644
--- a/p/themes/base-theme/frss.css
+++ b/p/themes/base-theme/frss.css
@@ -39,8 +39,6 @@
--frss-scrollbar-track: #0001;
--frss-scrollbar-track-hover: #0001;
- --frss-loading-image: url("loader.gif");
-
--frss-padding-flux-items: 0.75rem;
--frss-padding-top-bottom: 0.5rem;
@@ -619,8 +617,7 @@ button[disabled]:hover, input[disabled]:hover {
}
#button-update-loading {
- background: var(--frss-loading-image) 0.5rem center no-repeat;
- background-size: 1rem;
+ position: relative;
padding-left: 2rem;
}
@@ -1977,13 +1974,11 @@ a.website:hover .favicon {
font-size: 0;
}
-#load_more.loading::after {
+#load_more.loading::after,
+#button-update-loading::after,
+.loading::after {
content: "";
position: absolute;
- top: calc(50% - 12px);
- left: calc(50% - 12px);
- width: 24px;
- height: 24px;
border: 3px solid currentColor;
border-right-color: transparent;
border-radius: 50%;
@@ -1991,16 +1986,34 @@ a.website:hover .favicon {
animation: frss-spin 1s linear infinite;
}
+#load_more.loading::after,
+.loading::after {
+ top: calc(50% - 12px);
+ left: calc(50% - 12px);
+ width: 24px;
+ height: 24px;
+}
+
+#button-update-loading::after {
+ top: calc(50% - 0.5rem);
+ left: 0.5rem;
+ width: 1rem;
+ height: 1rem;
+ border-width: 2px;
+}
+
@keyframes frss-spin {
to { transform: rotate(360deg); }
}
@media (prefers-reduced-motion: reduce) {
- #load_more.loading::after { animation: none; }
+ #load_more.loading::after,
+ #button-update-loading::after,
+ .loading::after { animation: none; }
}
.loading {
- background: var(--frss-loading-image) center center no-repeat;
+ position: relative;
font-size: 0;
}
@@ -2137,13 +2150,6 @@ html.slider-active {
filter: grayscale(100%) brightness(2.5);
}
-#slider-content .loader {
- height: 90vh;
- background-image: url('loader.gif');
- background-repeat: no-repeat;
- background-position: center;
-}
-
/*=== Configuration pages */
.post {
padding: 1rem 2rem;
diff --git a/p/themes/base-theme/frss.rtl.css b/p/themes/base-theme/frss.rtl.css
index 0f7d8dda2..134754b4b 100644
--- a/p/themes/base-theme/frss.rtl.css
+++ b/p/themes/base-theme/frss.rtl.css
@@ -39,8 +39,6 @@
--frss-scrollbar-track: #0001;
--frss-scrollbar-track-hover: #0001;
- --frss-loading-image: url("loader.gif");
-
--frss-padding-flux-items: 0.75rem;
--frss-padding-top-bottom: 0.5rem;
@@ -619,8 +617,7 @@ button[disabled]:hover, input[disabled]:hover {
}
#button-update-loading {
- background: var(--frss-loading-image) 0.5rem center no-repeat;
- background-size: 1rem;
+ position: relative;
padding-right: 2rem;
}
@@ -1977,13 +1974,11 @@ a.website:hover .favicon {
font-size: 0;
}
-#load_more.loading::after {
+#load_more.loading::after,
+#button-update-loading::after,
+.loading::after {
content: "";
position: absolute;
- top: calc(50% - 12px);
- right: calc(50% - 12px);
- width: 24px;
- height: 24px;
border: 3px solid currentColor;
border-left-color: transparent;
border-radius: 50%;
@@ -1991,16 +1986,34 @@ a.website:hover .favicon {
animation: frss-spin 1s linear infinite;
}
+#load_more.loading::after,
+.loading::after {
+ top: calc(50% - 12px);
+ right: calc(50% - 12px);
+ width: 24px;
+ height: 24px;
+}
+
+#button-update-loading::after {
+ top: calc(50% - 0.5rem);
+ right: 0.5rem;
+ width: 1rem;
+ height: 1rem;
+ border-width: 2px;
+}
+
@keyframes frss-spin {
to { transform: rotate(-360deg); }
}
@media (prefers-reduced-motion: reduce) {
- #load_more.loading::after { animation: none; }
+ #load_more.loading::after,
+ #button-update-loading::after,
+ .loading::after { animation: none; }
}
.loading {
- background: var(--frss-loading-image) center center no-repeat;
+ position: relative;
font-size: 0;
}
@@ -2137,13 +2150,6 @@ html.slider-active {
filter: grayscale(100%) brightness(2.5);
}
-#slider-content .loader {
- height: 90vh;
- background-image: url('loader.gif');
- background-repeat: no-repeat;
- background-position: center;
-}
-
/*=== Configuration pages */
.post {
padding: 1rem 2rem;
diff --git a/p/themes/base-theme/loader.gif b/p/themes/base-theme/loader.gif
deleted file mode 100644
index 5ff26f0e3..000000000
Binary files a/p/themes/base-theme/loader.gif and /dev/null differ