Skip to content

Open-source speech recognition toolkit for training, inference, streaming ASR, VAD, punctuation, speaker diarization pipelines, and OpenAI-compatible/MCP serving.

Fix empty pending integration check status (#3068)

zhifu gao1b0d3d455300
diff --git a/scripts/collect_growth_metrics.py b/scripts/collect_growth_metrics.py
index dd310ca93..2efa11118 100755
--- a/scripts/collect_growth_metrics.py
+++ b/scripts/collect_growth_metrics.py
@@ -147,7 +147,7 @@ def summarize_commit_checks(repo: str, head_sha: str) -> Dict[str, Any]:
status_state = status.get("state")
if failed_check_runs or status_state in {"error", "failure"}:
state = "failure"
- elif pending_check_runs or status_state == "pending":
+ elif pending_check_runs:
state = "pending"
elif check_runs or status.get("statuses"):
state = "success"
@@ -562,4 +562,4 @@ def main() -> int:
if __name__ == "__main__":
- raise SystemExit(main())
\ No newline at end of file
+ raise SystemExit(main())
diff --git a/tests/test_collect_growth_metrics.py b/tests/test_collect_growth_metrics.py
index 94d712c36..f27bb299b 100644
--- a/tests/test_collect_growth_metrics.py
+++ b/tests/test_collect_growth_metrics.py
@@ -423,6 +423,40 @@ def test_collect_integration_metrics_classifies_review_bot_failure(monkeypatch):
assert integration["checks"]["failed_check_runs"][0]["name"] == "claude-review"
+def test_collect_integration_metrics_treats_empty_pending_status_as_unknown(monkeypatch):
+ module = load_growth_metrics_module()
+
+ def fake_fetch_json(url, headers=None):
+ if url == "https://api.github.com/repos/sgl-project/sglang-omni/pulls/898":
+ return {
+ "number": 898,
+ "title": "Add Fun-ASR serving support",
+ "state": "open",
+ "draft": False,
+ "mergeable": True,
+ "mergeable_state": "blocked",
+ "html_url": "https://github.com/sgl-project/sglang-omni/pull/898",
+ "updated_at": "2026-06-30T04:48:08Z",
+ "head": {"sha": "c081a79", "ref": "funasr-serving"},
+ "base": {"ref": "main"},
+ "user": {"login": "PoTaTo-Mika"},
+ }
+ if url == "https://api.github.com/repos/sgl-project/sglang-omni/commits/c081a79/status":
+ return {"state": "pending", "statuses": []}
+ if url == "https://api.github.com/repos/sgl-project/sglang-omni/commits/c081a79/check-runs?per_page=100":
+ return {"total_count": 0, "check_runs": []}
+ raise AssertionError(f"unexpected URL: {url}")
+
+ monkeypatch.setattr(module, "fetch_json", fake_fetch_json)
+
+ metrics = module.collect_integration_metrics(["sgl-project/sglang-omni#898"])
+
+ integration = metrics["integrations"][0]
+ assert integration["checks"]["state"] == "unknown"
+ assert integration["checks"]["pending_check_runs"] == []
+ assert integration["next_action"] == "inspect"
+
+
def test_format_integration_markdown_includes_update_age_and_next_action():
module = load_growth_metrics_module()
metrics = {
@@ -638,4 +672,4 @@ def test_main_outputs_integrations_json(monkeypatch):
integration = payload["integrations"][0]
assert integration["pr"] == "ray-project/ray#64053"
assert integration["checks"]["state"] == "success"
- assert integration["next_action"] == "request review"
\ No newline at end of file
+ assert integration["next_action"] == "request review"