FunASR-powered video transcription, subtitle generation, and LLM-assisted clipping tool with a local Gradio UI.
Python ai-toolsai-video-editingasrauto-subtitleschinesecontent-creationfunasrfunclipgradiollmparaformerspeech-recognitionspeech-to-textsubtitles-generatortranscriptionvideo-editingvideo-processingvideo-subtitlesvideo-transcriptionwhisper-alternative
fix: make Gradio runtime compatibility safe
zhifu gao54133848b59d
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.ymlnew file mode 100644index 0000000..480e545--- /dev/null+++ b/.github/workflows/tests.yml@@ -0,0 +1,37 @@+name: Tests++on:+ pull_request:+ push:+ branches: [main]++permissions:+ contents: read++concurrency:+ group: tests-${{ github.workflow }}-${{ github.ref }}+ cancel-in-progress: true++jobs:+ gradio-runtime:+ runs-on: ubuntu-latest+ steps:+ - name: Check out source+ uses: actions/checkout@3d3c42e5aac5ba805825da76410c181273ba90b1 # v7.0.1++ - name: Set up Python+ uses: actions/setup-python@5fda3b95a4ea91299a34e894583c3862153e4b97 # v7.0.0+ with:+ python-version: "3.12"++ - name: Install Gradio runtime test dependencies+ run: |+ python -m pip install --disable-pip-version-check \+ pytest==8.3.5 \+ "gradio==4.44.1" \+ "huggingface_hub<1.0" \+ "starlette<1.0"+ python -m pip check++ - name: Test Gradio runtime compatibility+ run: python -m pytest -q tests/test_gradio_runtime_compat.pydiff --git a/funclip/launch.py b/funclip/launch.pyindex 278ac3f..4ffdf00 100644--- a/funclip/launch.py+++ b/funclip/launch.py@@ -19,57 +19,7 @@ from llm.litellm_api import litellm_callfrom llm.twelvelabs_api import call_twelvelabs_pegasusfrom utils.trans_utils import extract_timestampsfrom introduction import top_md_1, top_md_3, top_md_4--# Workaround: Jinja2 LRU cache key becomes unhashable (dict) due to-# Starlette/FastAPI/Jinja2 version mismatch. Disabling the Jinja2 template-# cache avoids "TypeError: unhashable type: 'dict'" when rendering the-# Gradio frontend index.html template via starlette Jinja2Templates.-#-# Workaround 2: Starlette >= 1.0 changed the Jinja2Templates.TemplateResponse-# signature from (name, context) to (request, name, context). Gradio 4.44.1-# still uses the old signature, causing AttributeError: 'dict' has no-# attribute 'split'. Wrap TemplateResponse to accept both call styles.-try:- import gradio.routes as _routes- from starlette.requests import Request as _Request-- if hasattr(_routes, "templates") and hasattr(_routes.templates, "env"):- _routes.templates.env.cache = None- _routes.templates.env.cache_size = 0-- # Monkey-patch TemplateResponse to support both signatures- _original_tr = _routes.templates.TemplateResponse-- def _compatible_template_response(- *args,- **kwargs,- ):- # Try to detect call style- if len(args) >= 1 and isinstance(args[0], _Request):- # New Starlette 1.x signature: (request, name, context, ...)- return _original_tr(*args, **kwargs)- if len(args) >= 1 and isinstance(args[0], (str, bytes, os.PathLike)):- # Old Gradio signature: (name, context, ...) - extract request from context- name = args[0]- context = args[1] if len(args) > 1 else kwargs.get("context") or {}- request = context.get("request") if isinstance(context, dict) else kwargs.get("request")- status_code = kwargs.get("status_code") or (args[2] if len(args) > 2 else 200)- headers = kwargs.get("headers")- media_type = kwargs.get("media_type")- background = kwargs.get("background")- return _original_tr(- request, name, context,- status_code=status_code,- headers=headers,- media_type=media_type,- background=background,- )- # Fallback: try original- return _original_tr(*args, **kwargs)-- _routes.templates.TemplateResponse = _compatible_template_response-except Exception: # pragma: no cover - defensive, never break launch on this- pass+from launch_config import build_launch_kwargsdef create_asr_model(model_name, lang, auto_model_cls=AutoModel):@@ -117,10 +67,6 @@ if __name__ == "__main__":audio_clipper = VideoClipper(funasr_model)audio_clipper.lang = args.lang- server_name='127.0.0.1'- if args.listen:- server_name = '0.0.0.0'-def save_text_to_file(content, extension, output_dir=None):if not content:return None@@ -424,16 +370,6 @@ if __name__ == "__main__":],outputs=[video_output, audio_output, clip_message, srt_clipped])- # start gradio service in local or share- launch_kwargs = dict(share=args.share, server_port=args.port, server_name=server_name, show_error=True)- if args.listen:- launch_kwargs["inbrowser"] = False- try:- funclip_service.launch(**launch_kwargs, _frontend=False)- except ValueError as e:- if "localhost is not accessible" in str(e):- print("⚠️ Localhost is not accessible. Retrying with share=True...")- launch_kwargs["share"] = True- funclip_service.launch(**launch_kwargs)- else:- raise+ funclip_service.launch(+ **build_launch_kwargs(share=args.share, port=args.port, listen=args.listen)+ )diff --git a/funclip/launch_config.py b/funclip/launch_config.pynew file mode 100644index 0000000..bc2ef4e--- /dev/null+++ b/funclip/launch_config.py@@ -0,0 +1,16 @@+"""Launch policy for the FunClip Gradio service."""+++def build_launch_kwargs(*, share, port, listen):+ kwargs = {+ "share": share,+ "server_port": port,+ "server_name": "127.0.0.1",+ }+ if listen:+ kwargs.update(+ server_name="0.0.0.0",+ inbrowser=False,+ _frontend=False,+ )+ return kwargsdiff --git a/requirements.txt b/requirements.txtindex 27b4d7f..d479796 100644--- a/requirements.txt+++ b/requirements.txt@@ -7,6 +7,7 @@ huggingface_hub>=0.19.3,<1.0moviepy==1.0.3numpy==1.26.4gradio>=4.31.3,<5.0+starlette<1.0modelscopetorch>=1.13torchaudiodiff --git a/tests/test_gradio_runtime_compat.py b/tests/test_gradio_runtime_compat.pynew file mode 100644index 0000000..977122f--- /dev/null+++ b/tests/test_gradio_runtime_compat.py@@ -0,0 +1,84 @@+"""Regression tests for the supported Gradio/Starlette launch contract."""++import ast+from pathlib import Path++ROOT = Path(__file__).resolve().parents[1]+LAUNCH_PATH = ROOT / "funclip" / "launch.py"+++def test_gradio4_excludes_breaking_starlette_releases():+ requirements = {+ line.strip()+ for line in (ROOT / "requirements.txt").read_text(encoding="utf-8").splitlines()+ if line.strip() and not line.lstrip().startswith("#")+ }++ assert "gradio>=4.31.3,<5.0" in requirements+ assert "starlette<1.0" in requirements+++def test_supported_gradio_stack_renders_index():+ import gradio+ from starlette.testclient import TestClient++ with gradio.Blocks() as demo:+ gradio.Markdown("FunClip runtime smoke test")++ app = gradio.routes.App.create_app(demo)+ response = TestClient(app).get("/")++ assert response.status_code == 200+ assert "gradio_config" in response.text+++def test_local_launch_keeps_gradio_frontend_probe_enabled():+ from funclip.launch_config import build_launch_kwargs++ assert build_launch_kwargs(share=False, port=7860, listen=False) == {+ "share": False,+ "server_port": 7860,+ "server_name": "127.0.0.1",+ }+++def test_explicit_listen_skips_only_the_local_frontend_probe():+ from funclip.launch_config import build_launch_kwargs++ assert build_launch_kwargs(share=False, port=12235, listen=True) == {+ "share": False,+ "server_port": 12235,+ "server_name": "0.0.0.0",+ "inbrowser": False,+ "_frontend": False,+ }+++def test_explicit_share_choice_is_preserved():+ from funclip.launch_config import build_launch_kwargs++ kwargs = build_launch_kwargs(share=True, port=7860, listen=True)++ assert kwargs["share"] is True+++def test_launcher_does_not_patch_dependencies_or_retry_with_public_share():+ tree = ast.parse(LAUNCH_PATH.read_text(encoding="utf-8"))+ launch_calls = [+ node+ for node in ast.walk(tree)+ if isinstance(node, ast.Call)+ and isinstance(node.func, ast.Attribute)+ and node.func.attr == "launch"+ ]+ patched_attributes = [+ target.attr+ for node in ast.walk(tree)+ if isinstance(node, (ast.Assign, ast.AnnAssign))+ for target in (node.targets if isinstance(node, ast.Assign) else [node.target])+ if isinstance(target, ast.Attribute)+ and target.attr in {"TemplateResponse", "cache", "cache_size"}+ ]++ assert len(launch_calls) == 1+ assert patched_attributes == []