Skip to content

armgit / Handy

Public Imported from GitHub
0

A free, open source, and extensible speech-to-text application that works completely offline.

fix: refresh custom sounds when opening sound selector (#1941)

Mika Krul345caa8f3e42
diff --git a/src/components/settings/ClamshellMicrophoneSelector.tsx b/src/components/settings/ClamshellMicrophoneSelector.tsx
index c5a11011..d0d840dc 100644
--- a/src/components/settings/ClamshellMicrophoneSelector.tsx
+++ b/src/components/settings/ClamshellMicrophoneSelector.tsx
@@ -89,7 +89,7 @@ export const ClamshellMicrophoneSelector: React.FC<ClamshellMicrophoneSelectorPr
isLoading ||
audioDevices.length === 0
}
- onRefresh={refreshAudioDevices}
+ onOpen={refreshAudioDevices}
/>
<ResetButton
onClick={handleReset}
diff --git a/src/components/settings/MicrophoneSelector.tsx b/src/components/settings/MicrophoneSelector.tsx
index 0a5f4aca..a1c0296d 100644
--- a/src/components/settings/MicrophoneSelector.tsx
+++ b/src/components/settings/MicrophoneSelector.tsx
@@ -63,7 +63,7 @@ export const MicrophoneSelector: React.FC<MicrophoneSelectorProps> = React.memo(
isLoading ||
audioDevices.length === 0
}
- onRefresh={refreshAudioDevices}
+ onOpen={refreshAudioDevices}
/>
<ResetButton
onClick={handleReset}
diff --git a/src/components/settings/OutputDeviceSelector.tsx b/src/components/settings/OutputDeviceSelector.tsx
index 3df632a8..de825278 100644
--- a/src/components/settings/OutputDeviceSelector.tsx
+++ b/src/components/settings/OutputDeviceSelector.tsx
@@ -68,7 +68,7 @@ export const OutputDeviceSelector: React.FC<OutputDeviceSelectorProps> =
isLoading ||
outputDevices.length === 0
}
- onRefresh={refreshOutputDevices}
+ onOpen={refreshOutputDevices}
/>
<ResetButton
onClick={handleReset}
diff --git a/src/components/settings/SoundPicker.tsx b/src/components/settings/SoundPicker.tsx
index 3c358320..fbb5c138 100644
--- a/src/components/settings/SoundPicker.tsx
+++ b/src/components/settings/SoundPicker.tsx
@@ -1,4 +1,4 @@
-import React from "react";
+import React, { useEffect } from "react";
import { Button } from "../ui/Button";
import { Dropdown, DropdownOption } from "../ui/Dropdown";
import { PlayIcon } from "lucide-react";
@@ -18,9 +18,16 @@ export const SoundPicker: React.FC<SoundPickerProps> = ({
const { getSetting, updateSetting } = useSettings();
const playTestSound = useSettingsStore((state) => state.playTestSound);
const customSounds = useSettingsStore((state) => state.customSounds);
+ const checkCustomSounds = useSettingsStore(
+ (state) => state.checkCustomSounds,
+ );
const selectedTheme = getSetting("sound_theme") ?? "marimba";
+ useEffect(() => {
+ checkCustomSounds();
+ }, [checkCustomSounds]);
+
const options: DropdownOption[] = [
{ value: "marimba", label: "Marimba" },
{ value: "pop", label: "Pop" },
@@ -50,6 +57,7 @@ export const SoundPicker: React.FC<SoundPickerProps> = ({
updateSetting("sound_theme", value as "marimba" | "pop" | "custom")
}
options={options}
+ onOpen={checkCustomSounds}
/>
<Button
variant="ghost"
diff --git a/src/components/ui/Dropdown.tsx b/src/components/ui/Dropdown.tsx
index 4143415f..3e2f6b39 100644
--- a/src/components/ui/Dropdown.tsx
+++ b/src/components/ui/Dropdown.tsx
@@ -16,7 +16,7 @@ interface DropdownProps {
onSelect: (value: string) => void;
placeholder?: string;
disabled?: boolean;
- onRefresh?: () => void;
+ onOpen?: () => void;
}
export const Dropdown: React.FC<DropdownProps> = ({
@@ -27,7 +27,7 @@ export const Dropdown: React.FC<DropdownProps> = ({
menuClassName,
placeholder = "Select an option...",
disabled = false,
- onRefresh,
+ onOpen,
}) => {
const { t } = useTranslation();
const [isOpen, setIsOpen] = useState(false);
@@ -57,7 +57,7 @@ export const Dropdown: React.FC<DropdownProps> = ({
const handleToggle = () => {
if (disabled) return;
- if (!isOpen && onRefresh) onRefresh();
+ if (!isOpen) onOpen?.();
setIsOpen(!isOpen);
};