A free, open source, and extensible speech-to-text application that works completely offline.
fix: release late audio sources after leaving history (#2309)
daydreamer.jina1cb29d73095
diff --git a/src/components/ui/AudioPlayer.tsx b/src/components/ui/AudioPlayer.tsxindex 1aa99f55..13f0abe8 100644--- a/src/components/ui/AudioPlayer.tsx+++ b/src/components/ui/AudioPlayer.tsx@@ -10,6 +10,10 @@ import React, {import { Play, Pause } from "lucide-react";import { useTranslation } from "react-i18next";+const revokeBlobSource = (src: string | null) => {+ if (src?.startsWith("blob:")) URL.revokeObjectURL(src);+};+interface AudioPlayerProps {/** Audio source URL. If not provided, onLoadRequest must be provided. */src?: string;@@ -67,6 +71,8 @@ export const AudioPlayer: React.FC<AudioPlayerProps> = ({const [isLoading, setIsLoading] = useState(false);const audioRef = useRef<HTMLAudioElement>(null);+ // Own a resolved source immediately, before its state/effect can commit.+ const pendingSrcRef = useRef<string | null>(null);const src = loadedSrc;const animationRef = useRef<number>();const dragTimeRef = useRef<number>(0);@@ -205,13 +211,19 @@ export const AudioPlayer: React.FC<AudioPlayerProps> = ({// Cleanup blob URLs on unmountuseEffect(() => {+ if (pendingSrcRef.current === loadedSrc) pendingSrcRef.current = null;return () => {- if (loadedSrc?.startsWith("blob:")) {- URL.revokeObjectURL(loadedSrc);- }+ revokeBlobSource(loadedSrc);};}, [loadedSrc]);+ useEffect(() => {+ return () => {+ revokeBlobSource(pendingSrcRef.current);+ pendingSrcRef.current = null;+ };+ }, []);+const togglePlay = async () => {const audio = audioRef.current;if (!audio) return;@@ -224,11 +236,19 @@ export const AudioPlayer: React.FC<AudioPlayerProps> = ({// If no src loaded yet, request itif (!src && onLoadRequest) {setIsLoading(true);- const newSrc = await onLoadRequest();- setIsLoading(false);- if (newSrc) {- setLoadedSrc(newSrc);- // Playback will be triggered by the useEffect watching loadedSrc+ try {+ const newSrc = await onLoadRequest();+ if (audioRef.current !== audio) {+ revokeBlobSource(newSrc);+ return;+ }+ if (newSrc) {+ pendingSrcRef.current = newSrc;+ setLoadedSrc(newSrc);+ // Playback will be triggered by the useEffect watching loadedSrc+ }+ } finally {+ if (audioRef.current === audio) setIsLoading(false);}} else if (src) {await audio.play();