Skip to content

Open-source event management and ticket selling platform — perfect for concerts, conferences, and everything in between 🎟️ If you find this project helpful, please consider giving us a star ⭐️

validate ticket IDs belong to an order

Dave Earley0b5b2384a9ed
diff --git a/backend/app/Services/Handlers/Order/CompleteOrderHandler.php b/backend/app/Services/Handlers/Order/CompleteOrderHandler.php
index b77894fd0..116fc3803 100644
--- a/backend/app/Services/Handlers/Order/CompleteOrderHandler.php
+++ b/backend/app/Services/Handlers/Order/CompleteOrderHandler.php
@@ -96,6 +96,8 @@ readonly class CompleteOrderHandler
values: $attendees->pluck('ticket_price_id')->toArray(),
);
+ $this->validateTicketPriceIdsMatchOrder($order, $ticketsPrices);
+
foreach ($attendees as $attendee) {
$ticketId = $ticketsPrices->first(
fn(TicketPriceDomainObject $ticketPrice) => $ticketPrice->getId() === $attendee->ticket_price_id)
@@ -238,4 +240,21 @@ readonly class CompleteOrderHandler
]
);
}
+
+ /**
+ * Check if the passed ticket price IDs match what exist in the order_items table
+ *
+ * @throws ResourceConflictException
+ */
+ private function validateTicketPriceIdsMatchOrder(OrderDomainObject $order, Collection $ticketsPrices): void
+ {
+ $orderTicketPriceIds = $order->getOrderItems()
+ ?->map(fn(OrderItemDomainObject $orderItem) => $orderItem->getTicketPriceId())->toArray();
+
+ $ticketsPricesIds = $ticketsPrices->map(fn(TicketPriceDomainObject $ticketPrice) => $ticketPrice->getId());
+
+ if ($ticketsPricesIds->diff($orderTicketPriceIds)->isNotEmpty()) {
+ throw new ResourceConflictException(__('There is an unexpected ticket price ID in the order'));
+ }
+ }
}