Skip to content

Open-source event management and ticket selling platform — perfect for concerts, conferences, and everything in between 🎟️ If you find this project helpful, please consider giving us a star ⭐️

Do not allow selling more than available quantity

Dave Earley42d80a629002
diff --git a/backend/app/Repository/Eloquent/TicketRepository.php b/backend/app/Repository/Eloquent/TicketRepository.php
index 2800c3280..1a6cc9103 100644
--- a/backend/app/Repository/Eloquent/TicketRepository.php
+++ b/backend/app/Repository/Eloquent/TicketRepository.php
@@ -59,6 +59,8 @@ class TicketRepository extends BaseRepository implements TicketRepositoryInterfa
WHERE order_items.ticket_price_id = :ticketPriceId
AND orders.status in ('RESERVED')
AND current_timestamp < orders.reserved_until
+ AND orders.deleted_at IS NULL
+ AND order_items.deleted_at IS NULL
), 0)
) AS quantity_remaining,
ticket_prices.initial_quantity_available IS NULL AS unlimited_tickets_available
diff --git a/backend/app/Resources/Ticket/TicketResourcePublic.php b/backend/app/Resources/Ticket/TicketResourcePublic.php
index 38891c4fd..500f4611c 100644
--- a/backend/app/Resources/Ticket/TicketResourcePublic.php
+++ b/backend/app/Resources/Ticket/TicketResourcePublic.php
@@ -27,7 +27,7 @@ class TicketResourcePublic extends JsonResource
'is_before_sale_start_date' => $this->isBeforeSaleStartDate(),
'is_after_sale_end_date' => $this->isAfterSaleEndDate(),
'price' => $this->when(
- (bool)$this->getTicketPrices() && !$this->isTieredType(),
+ $this->getTicketPrices() && !$this->isTieredType(),
fn() => $this->getPrice(),
),
'prices' => $this->when(
@@ -40,6 +40,7 @@ class TicketResourcePublic extends JsonResource
),
$this->mergeWhen((bool)$this->getTicketPrices(), fn() => [
'is_available' => $this->isAvailable(),
+ 'is_sold_out' => $this->isSoldOut(),
]),
];
}
diff --git a/backend/app/Services/Domain/Order/OrderCreateRequestValidationService.php b/backend/app/Services/Domain/Order/OrderCreateRequestValidationService.php
index 20e3dac66..b17e57bf8 100644
--- a/backend/app/Services/Domain/Order/OrderCreateRequestValidationService.php
+++ b/backend/app/Services/Domain/Order/OrderCreateRequestValidationService.php
@@ -170,10 +170,23 @@ readonly class OrderCreateRequestValidationService
$totalQuantity = collect($ticketAndQuantities['quantities'])->sum('quantity');
$maxPerOrder = (int)$ticket->getMaxPerOrder() ?: 100; // Placeholder for config value
$minPerOrder = (int)$ticket->getMinPerOrder() ?: 1;
+ $ticketQuantityAvailable = $this->ticketRepository->getQuantityRemainingForTicketPrice(
+ ticketId: $ticket->getId(),
+ ticketPriceId: $ticketAndQuantities['quantities'][0]['price_id']
+ );
+
+ if ($totalQuantity > $ticketQuantityAvailable) {
+ throw ValidationException::withMessages([
+ "tickets.$ticketIndex" => __("The maximum number of tickets available for :ticket is :max", [
+ 'max' => $ticketQuantityAvailable,
+ 'ticket' => $ticket->getTitle(),
+ ]),
+ ]);
+ }
if ($totalQuantity > $maxPerOrder) {
throw ValidationException::withMessages([
- "tickets.$ticketIndex" => __("The maximum numbers number of tickets for :tickets is :max", [
+ "tickets.$ticketIndex" => __("The maximum number of tickets available for :tickets is :max", [
'max' => $maxPerOrder,
'ticket' => $ticket->getTitle(),
]),
diff --git a/docker/development/docker-compose.dev.yml b/docker/development/docker-compose.dev.yml
index 8792525b6..4dcf0094a 100644
--- a/docker/development/docker-compose.dev.yml
+++ b/docker/development/docker-compose.dev.yml
@@ -43,7 +43,7 @@ services:
build:
context: ./../../frontend
dockerfile: Dockerfile.ssr.dev
- container_name: frontend-ssr
+ container_name: frontend
ports:
- "5678:5678"
- "24678:24678"
diff --git a/docker/development/start-dev.sh b/docker/development/start-dev.sh
index 07c2582a4..88bd86b7b 100755
--- a/docker/development/start-dev.sh
+++ b/docker/development/start-dev.sh
@@ -75,11 +75,11 @@ done
echo -e "\n${GREEN}Database is ready. Proceeding with migrations...${NC}"
-if [ ! -f ./../backend/.env ]; then
+if [ ! -f ./../../backend/.env ]; then
$COMPOSE_CMD exec backend cp .env.example .env
fi
-if [ ! -f ./../frontend/.env ]; then
+if [ ! -f ./../../frontend/.env ]; then
$COMPOSE_CMD exec frontend cp .env.example .env
fi
diff --git a/frontend/src/components/routes/account/ManageAccount/sections/PaymentSettings/index.tsx b/frontend/src/components/routes/account/ManageAccount/sections/PaymentSettings/index.tsx
index cf61107ad..51f40bcee 100644
--- a/frontend/src/components/routes/account/ManageAccount/sections/PaymentSettings/index.tsx
+++ b/frontend/src/components/routes/account/ManageAccount/sections/PaymentSettings/index.tsx
@@ -8,11 +8,19 @@ import {Anchor, Button, Group} from "@mantine/core";
import {StripeConnectDetails} from "../../../../../../types.ts";
import paymentClasses from "./PaymentSettings.module.scss"
import classes from "../../ManageAccount.module.scss"
+import {useEffect, useState} from "react";
const ConnectStatus = (props: { stripeDetails: StripeConnectDetails }) => {
- const isReturn = window?.location.search.includes('is_return');
- const isRefresh = window?.location.search.includes('is_refresh');
- const isReturningFromStripe = isReturn || isRefresh;
+ const [isReturningFromStripe, setIsReturningFromStripe] = useState(false);
+
+ useEffect(() => {
+ if (typeof window === 'undefined') {
+ return;
+ }
+ setIsReturningFromStripe(
+ window.location.search.includes('is_return') || window.location.search.includes('is_refresh')
+ );
+ }, []);
return (
<div className={paymentClasses.stripeInfo}>
diff --git a/frontend/src/components/routes/ticket-widget/SelectTickets/index.tsx b/frontend/src/components/routes/ticket-widget/SelectTickets/index.tsx
index 33613c826..43c8df9af 100644
--- a/frontend/src/components/routes/ticket-widget/SelectTickets/index.tsx
+++ b/frontend/src/components/routes/ticket-widget/SelectTickets/index.tsx
@@ -214,6 +214,12 @@ const SelectTickets = (props: SelectTicketsProps) => {
}
}
+ const isButtonDisabled = ticketMutation.isLoading
+ || !ticketAreAvailable
+ || selectedTicketQuantitySum === 0
+ || props.widgetMode === 'preview'
+ || tickets?.every(ticket => ticket.is_sold_out);
+
return (
<div className={'hi-ticket-widget-container'}
ref={resizeRef}
@@ -326,7 +332,7 @@ const SelectTickets = (props: SelectTicketsProps) => {
__html: event.settings.ticket_page_message.replace(/\n/g, '<br/>')
}} className={'hi-ticket-page-message'}/>
)}
- <Button disabled={props.widgetMode === 'preview'} fullWidth className={'hi-continue-button'}
+ <Button disabled={isButtonDisabled} fullWidth className={'hi-continue-button'}
type={"submit"}
loading={ticketMutation.isLoading}>
{props.continueButtonText || event?.settings?.continue_button_text || t`Continue`}