Skip to content

Open-source event management and ticket selling platform — perfect for concerts, conferences, and everything in between 🎟️ If you find this project helpful, please consider giving us a star ⭐️

Remove per second email throttling (#548)

Dave Earley79ddedc74105
diff --git a/backend/app/Jobs/Event/SendEventEmailJob.php b/backend/app/Jobs/Event/SendEventEmailJob.php
index 737c885d7..af6b259ff 100644
--- a/backend/app/Jobs/Event/SendEventEmailJob.php
+++ b/backend/app/Jobs/Event/SendEventEmailJob.php
@@ -5,7 +5,6 @@ namespace HiEvents\Jobs\Event;
use HiEvents\DomainObjects\Generated\OutgoingMessageDomainObjectAbstract;
use HiEvents\DomainObjects\Status\OutgoingMessageStatus;
use HiEvents\Mail\Event\EventMessage;
-use HiEvents\Providers\AppServiceProvider;
use HiEvents\Repository\Interfaces\OutgoingMessageRepositoryInterface;
use HiEvents\Services\Application\Handlers\Message\DTO\SendMessageDTO;
use Illuminate\Bus\Queueable;
@@ -13,7 +12,6 @@ use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Foundation\Bus\Dispatchable;
use Illuminate\Mail\Mailer;
use Illuminate\Queue\InteractsWithQueue;
-use Illuminate\Queue\Middleware\RateLimited;
use Illuminate\Queue\SerializesModels;
use Throwable;
@@ -30,13 +28,6 @@ class SendEventEmailJob implements ShouldQueue
{
}
- public function middleware(): array
- {
- return [
- (new RateLimited(AppServiceProvider::MAIL_RATE_LIMIT_PER_SECOND)),
- ];
- }
-
/**
* @throws Throwable
*/
diff --git a/backend/app/Providers/AppServiceProvider.php b/backend/app/Providers/AppServiceProvider.php
index 209f87984..7073cd658 100644
--- a/backend/app/Providers/AppServiceProvider.php
+++ b/backend/app/Providers/AppServiceProvider.php
@@ -12,21 +12,16 @@ use HiEvents\Models\Organizer;
use HiEvents\Services\Infrastructure\CurrencyConversion\CurrencyConversionClientInterface;
use HiEvents\Services\Infrastructure\CurrencyConversion\NoOpCurrencyConversionClient;
use HiEvents\Services\Infrastructure\CurrencyConversion\OpenExchangeRatesCurrencyConversionClient;
-use Illuminate\Cache\RateLimiting\Limit;
-use Illuminate\Contracts\Queue\ShouldQueue;
use Illuminate\Database\Eloquent\Model;
use Illuminate\Database\Eloquent\Relations\Relation;
use Illuminate\Support\Facades\DB;
use Illuminate\Support\Facades\File;
-use Illuminate\Support\Facades\RateLimiter;
use Illuminate\Support\Facades\URL;
use Illuminate\Support\ServiceProvider;
use Stripe\StripeClient;
class AppServiceProvider extends ServiceProvider
{
- public const MAIL_RATE_LIMIT_PER_SECOND = 'mail-rate-limit-per-second';
-
public function register(): void
{
$this->bindDoctrineConnection();
@@ -46,18 +41,6 @@ class AppServiceProvider extends ServiceProvider
$this->disableLazyLoading();
$this->registerMorphMaps();
-
- $this->registerJobRateLimiters();
- }
-
- private function registerJobRateLimiters(): void
- {
- RateLimiter::for(
- name: self::MAIL_RATE_LIMIT_PER_SECOND,
- callback: static fn(ShouldQueue $job) => Limit::perMinute(
- maxAttempts: config('mail.rate_limit_per_second')
- )
- );
}
private function bindDoctrineConnection(): void