Python
fix(auth): require the local token on reader internal endpoints (#82)
u7-u70a9b10dbfc13
diff --git a/memhub/apps/core/src/one_memory/api.py b/memhub/apps/core/src/one_memory/api.pyindex 087a02a..d50c4fa 100644--- a/memhub/apps/core/src/one_memory/api.py+++ b/memhub/apps/core/src/one_memory/api.py@@ -1685,7 +1685,7 @@ def create_app(# --- Reader-only internal endpoints. Registered here, before the public# routes below; no early return, so every route after this still registers.- @app.get("/internal/semantic-ids")+ @app.get("/internal/semantic-ids", dependencies=protected)async def internal_semantic_ids(query: str = Query(min_length=1, max_length=2_000),limit: int = Query(default=12, ge=1, le=20),@@ -1697,7 +1697,7 @@ def create_app(return {"ids": []}return {"ids": [memory_id for memory_id, _score in hits]}- @app.post("/internal/call-event")+ @app.post("/internal/call-event", dependencies=protected)async def internal_call_event(request: Request) -> dict[str, bool]:"""Side effects the Reader cannot write: it opens with query_only."""try:@@ -1716,7 +1716,7 @@ def create_app(return {"recorded": False}return {"recorded": bool(recorded)}- @app.get("/internal/graph-snapshot")+ @app.get("/internal/graph-snapshot", dependencies=protected)async def internal_graph_snapshot(limit: int = Query(default=160, ge=1, le=300),) -> dict[str, object]:diff --git a/memhub/apps/core/tests/test_auth.py b/memhub/apps/core/tests/test_auth.pyindex ce45f8f..a52526f 100644--- a/memhub/apps/core/tests/test_auth.py+++ b/memhub/apps/core/tests/test_auth.py@@ -55,3 +55,44 @@ def test_browser_origin_is_checked_in_addition_to_token() -> None:)== 200)+++async def internal_request(+ path: str,+ *,+ token: str | None,+ method: str = "GET",+) -> int:+ settings = Settings(api_token=SecretStr("test-token"))+ app = create_app(settings)+ headers = {}+ if token:+ headers["Authorization"] = f"Bearer {token}"+ async with AsyncClient(+ transport=ASGITransport(app=app),+ base_url="http://test",+ ) as client:+ response = await client.request(method, path, headers=headers, json={})+ return response.status_code+++def test_reader_internal_endpoints_require_local_token() -> None:+ for path in (+ "/internal/semantic-ids?query=anything",+ "/internal/graph-snapshot",+ ):+ assert asyncio.run(internal_request(path, token=None)) == 401+ assert asyncio.run(internal_request(path, token="test-token")) == 200++ assert (+ asyncio.run(+ internal_request("/internal/call-event", token=None, method="POST")+ )+ == 401+ )+ assert (+ asyncio.run(+ internal_request("/internal/call-event", token="test-token", method="POST")+ )+ == 200+ )