Skip to content
Python

fix(memhub): stabilize language setting layout

kristinhe48a5d7002668
diff --git a/memhub/apps/web/src/LanguageSelector.test.tsx b/memhub/apps/web/src/LanguageSelector.test.tsx
index 7cd62c8..50496a3 100644
--- a/memhub/apps/web/src/LanguageSelector.test.tsx
+++ b/memhub/apps/web/src/LanguageSelector.test.tsx
@@ -58,6 +58,40 @@ it.each(["zh-CN", "en", "es"] as const)(
},
);
+it.each(["system", "zh-CN", "en", "es"] as const)(
+ "keeps one stable settings row for the %s preference",
+ (preference) => {
+ localStorage.setItem(LANGUAGE_STORAGE_KEY, preference);
+ render(
+ <LanguageProvider>
+ <LanguageSelector />
+ </LanguageProvider>,
+ );
+ const selector = screen.getByRole("combobox") as HTMLSelectElement;
+ const row = selector.closest(".r6-language-setting-row");
+ expect(selector.value).toBe(preference);
+ expect(row).toBeTruthy();
+ expect(row?.querySelector("label")?.hidden).toBe(false);
+ expect(
+ screen
+ .getByRole("option", {
+ name: /简体中文|Simplified Chinese|Chino simplificado/,
+ })
+ .getAttribute("lang"),
+ ).toBe("zh-CN");
+ expect(
+ screen
+ .getByRole("option", { name: /英语|English|Inglés/ })
+ .getAttribute("lang"),
+ ).toBe("en");
+ expect(
+ screen
+ .getByRole("option", { name: /西班牙语|Spanish|Español/ })
+ .getAttribute("lang"),
+ ).toBe("es");
+ },
+);
+
it("offers an accessible selector, persists and updates its label", async () => {
localStorage.setItem(LANGUAGE_STORAGE_KEY, "zh-CN");
render(
diff --git a/memhub/apps/web/src/LanguageSelector.tsx b/memhub/apps/web/src/LanguageSelector.tsx
index 7e524ca..3f4e5d6 100644
--- a/memhub/apps/web/src/LanguageSelector.tsx
+++ b/memhub/apps/web/src/LanguageSelector.tsx
@@ -13,8 +13,16 @@ export function LanguageSelector({ compact = false }: { compact?: boolean }) {
compact ? "r6-language-selector--compact" : "r6-language-setting"
}
>
- {!compact && <h2 id={`${id}-title`}>{t("languageTitle")}</h2>}
- <div className={compact ? "r6-language-selector-row" : "r6-setting-row"}>
+ {!compact && (
+ <h2 id={`${id}-title`} className="r6-language-setting-title">
+ {t("languageTitle")}
+ </h2>
+ )}
+ <div
+ className={
+ compact ? "r6-language-selector-row" : "r6-language-setting-row"
+ }
+ >
<label id={`${id}-label`} htmlFor={`${id}-select`} hidden={compact}>
{t(compact ? "languageTitle" : "languageLabel")}
</label>
@@ -36,18 +44,25 @@ export function LanguageSelector({ compact = false }: { compact?: boolean }) {
}}
>
<option value="system">{t("languageSystem")}</option>
- <option value="zh-CN" lang={compact ? "zh-CN" : undefined}>
+ <option value="zh-CN" lang="zh-CN">
{compact ? "简体中文" : t("languageChinese")}
</option>
- <option value="en" lang={compact ? "en" : undefined}>
+ <option value="en" lang="en">
{compact ? "English" : t("languageEnglish")}
</option>
- <option value="es" lang={compact ? "es" : undefined}>
+ <option value="es" lang="es">
{compact ? "Español" : t("languageSpanish")}
</option>
</select>
</div>
- {!compact && <p id={`${id}-description`}>{t("languageDescription")}</p>}
+ {!compact && (
+ <p
+ id={`${id}-description`}
+ className="r6-language-setting-description"
+ >
+ {t("languageDescription")}
+ </p>
+ )}
{error && (
<p role="alert" className="r6-settings-error">
{t(error)}
diff --git a/memhub/apps/web/src/r6-settings.css b/memhub/apps/web/src/r6-settings.css
index 2eaaa6f..6c488c1 100644
--- a/memhub/apps/web/src/r6-settings.css
+++ b/memhub/apps/web/src/r6-settings.css
@@ -24,14 +24,31 @@
border-radius: 16px;
background: #fff;
}
-.r6-settings .r6-language-setting h2 {
- margin: 0 0 12px;
+.r6-language-setting-title {
+ margin: 0 0 18px;
font-size: 18px;
+ line-height: 28px;
+}
+.r6-settings .r6-language-setting-row {
+ display: grid;
+ grid-template-columns: 96px minmax(0, 1fr);
+ align-items: center;
+ gap: 16px;
+ min-height: 44px;
+}
+.r6-settings .r6-language-setting-row label {
+ min-width: 0;
+ font-size: 14px;
+ line-height: 24px;
+ white-space: nowrap;
}
.r6-settings .r6-language-setting select {
+ box-sizing: border-box;
+ width: 100%;
max-width: 100%;
- min-height: 36px;
- padding: 6px 10px;
+ min-width: 0;
+ min-height: 44px;
+ padding: 8px 12px;
border: 1px solid #dce4eb;
border-radius: 8px;
color: inherit;
@@ -42,8 +59,11 @@
outline: 2px solid #225f9d;
outline-offset: 2px;
}
-.r6-settings .r6-language-setting > p {
- margin: 12px 0 0;
+.r6-language-setting-description {
+ margin: 16px 0 0;
+ color: #5e6e7a;
+ font-size: 13px;
+ line-height: 22px;
overflow-wrap: anywhere;
}
.r6-settings .r6-settings-layout {