Skip to content
Python

fix(memhub): stabilize memory detail layout

kristinheb21c929728f6
diff --git a/memhub/apps/web/src/MemoryEvidencePanel.test.tsx b/memhub/apps/web/src/MemoryEvidencePanel.test.tsx
index d5aa581..1c20784 100644
--- a/memhub/apps/web/src/MemoryEvidencePanel.test.tsx
+++ b/memhub/apps/web/src/MemoryEvidencePanel.test.tsx
@@ -82,3 +82,38 @@ it("SYS-01: reduced motion skips animation and does not require animationend", (
);
expect(screen.queryByRole("dialog")).toBeNull();
});
+
+it("starts a new or resumed detail at the top without resetting the current detail", () => {
+ vi.stubGlobal("matchMedia", () => ({
+ matches: false,
+ addEventListener() {},
+ removeEventListener() {},
+ }));
+ const content = (scrollResetKey: string, suspended = false) => (
+ <MemoryEvidencePanel
+ open
+ suspended={suspended}
+ scrollResetKey={scrollResetKey}
+ onClose={() => {}}
+ >
+ <p>{scrollResetKey}</p>
+ </MemoryEvidencePanel>
+ );
+ const view = render(content("memory-a"));
+ const panel = view.container.querySelector<HTMLElement>(".map-inspector");
+ expect(panel).toBeTruthy();
+ if (!panel) return;
+
+ panel.scrollTop = 180;
+ view.rerender(content("memory-a"));
+ expect(panel.scrollTop).toBe(180);
+
+ view.rerender(content("memory-b"));
+ expect(panel.scrollTop).toBe(0);
+
+ panel.scrollTop = 120;
+ view.rerender(content("memory-b", true));
+ expect(panel.scrollTop).toBe(120);
+ view.rerender(content("memory-b"));
+ expect(panel.scrollTop).toBe(0);
+});
diff --git a/memhub/apps/web/src/MemoryEvidencePanel.tsx b/memhub/apps/web/src/MemoryEvidencePanel.tsx
index a9e395c..e782190 100644
--- a/memhub/apps/web/src/MemoryEvidencePanel.tsx
+++ b/memhub/apps/web/src/MemoryEvidencePanel.tsx
@@ -15,11 +15,14 @@ export function MemoryEvidencePanel({
onClose,
children,
suspended = false,
+ scrollResetKey,
}: {
open: boolean;
onClose(): void;
children: ReactNode;
suspended?: boolean;
+ /** A different detail starts at the top instead of inheriting old scroll. */
+ scrollResetKey?: string | null;
}) {
const { text } = useMemoryLanguage();
const compact = useMediaPreference("(max-width: 1100px)");
@@ -37,9 +40,21 @@ export function MemoryEvidencePanel({
reduceMotion,
reduceTransparency,
});
+ const priorScrollOwner = useRef({ key: scrollResetKey, suspended });
const present = !compact || open || phase !== "closed";
const modal = compact && present && !suspended;
+ useLayoutEffect(() => {
+ const previous = priorScrollOwner.current;
+ priorScrollOwner.current = { key: scrollResetKey, suspended };
+ if (
+ !suspended &&
+ (previous.key !== scrollResetKey || previous.suspended) &&
+ panel.current
+ )
+ panel.current.scrollTop = 0;
+ }, [scrollResetKey, suspended]);
+
useLayoutEffect(() => {
const element = panel.current;
if (!element) return;
diff --git a/memhub/apps/web/src/MemoryMap.tsx b/memhub/apps/web/src/MemoryMap.tsx
index 04caf1e..3527bec 100644
--- a/memhub/apps/web/src/MemoryMap.tsx
+++ b/memhub/apps/web/src/MemoryMap.tsx
@@ -1089,6 +1089,7 @@ export function MemoryMap(props: Props) {
<MemoryEvidencePanel
open={inspectorOpen && !!(activeId || visibleGroupNode)}
suspended={overlaysSuspended}
+ scrollResetKey={activeId ?? visibleGroupNode?.node_id ?? "empty"}
onClose={closeInspector}
>
<header className="map-inspector-heading">
diff --git a/memhub/apps/web/src/selected-memory.css b/memhub/apps/web/src/selected-memory.css
index 841989a..0ddb708 100644
--- a/memhub/apps/web/src/selected-memory.css
+++ b/memhub/apps/web/src/selected-memory.css
@@ -112,6 +112,8 @@
.r6-shell .r6-memory .map-search {
height: 44px;
margin: 13px 0 21px;
+ gap: 7px;
+ padding: 0 4px 0 12px;
border: 1px solid #c6d2da;
background: rgb(255 255 255 / 50%);
border-radius: 8px;
@@ -120,6 +122,30 @@
min-height: 40px;
font-size: 13px;
}
+.r6-shell .r6-memory .map-search-submit {
+ min-height: 34px;
+ padding: 0 12px;
+ border: 1px solid rgb(64 87 103 / 18%);
+ border-radius: 6px;
+ background: #4f6373;
+ color: #fff;
+ font:
+ 500 12px / 20px "Noto Sans SC",
+ "PingFang SC",
+ sans-serif;
+ box-shadow: inset 0 1px 0 rgb(255 255 255 / 18%);
+ transition:
+ background-color var(--r6-fast),
+ border-color var(--r6-fast);
+}
+.r6-shell .r6-memory .map-search-submit:hover:not(:disabled) {
+ background: #435966;
+ border-color: rgb(48 71 87 / 28%);
+}
+.r6-shell .r6-memory .map-search-submit:focus-visible {
+ outline: 2px solid #557c93;
+ outline-offset: 2px;
+}
.r6-shell .r6-memory .map-memory-list {
margin: 0;
padding: 0;
@@ -208,6 +234,9 @@
font-weight: 500;
}
.selected-memory-detail {
+ display: flex;
+ min-width: 0;
+ flex-direction: column;
color: #384a57;
font-family: "Noto Sans SC", "PingFang SC", sans-serif;
}
@@ -228,6 +257,8 @@
}
.selected-memory-body {
display: block;
+ flex: none;
+ min-width: 0;
font-size: 17px;
line-height: 29px;
letter-spacing: normal;