Skip to content

Hypergraph is more powerful. Transform unstructured text into structured knowledge with LLMs. Graphs, hypergraphs, and spatio-temporal extractions — with one command.

fix(template): resolve multi-word llm_* merge strategies

jichao wang893542ccab5d
diff --git a/hyperextract/utils/template_engine/parsers/options.py b/hyperextract/utils/template_engine/parsers/options.py
index 314debd..869d17c 100644
--- a/hyperextract/utils/template_engine/parsers/options.py
+++ b/hyperextract/utils/template_engine/parsers/options.py
@@ -14,12 +14,12 @@ from .schemas import (
def resolve_merge_strategy(strategy_name: VALID_MERGE_STRATEGIES) -> MergeStrategy:
"""Resolve merge strategy from string to MergeStrategy enum."""
- if "llm" in strategy_name:
- parts = strategy_name.split("_")
- if len(parts) == 2 and parts[0] in ["llm"]:
- return getattr(getattr(MergeStrategy, parts[0].upper()), parts[1].upper())
- else:
- return MergeStrategy[strategy_name.upper()]
+ if strategy_name.startswith("llm_"):
+ # Map every "llm_*" variant onto the nested MergeStrategy.LLM member,
+ # e.g. "llm_balanced" -> MergeStrategy.LLM.BALANCED,
+ # "llm_prefer_incoming" -> MergeStrategy.LLM.PREFER_INCOMING.
+ return getattr(MergeStrategy.LLM, strategy_name[len("llm_") :].upper())
+ return MergeStrategy[strategy_name.upper()]
class Options(BaseModel):
diff --git a/tests/template_engine/test_parser_options.py b/tests/template_engine/test_parser_options.py
new file mode 100644
index 0000000..8a6788f
--- /dev/null
+++ b/tests/template_engine/test_parser_options.py
@@ -0,0 +1,33 @@
+"""Unit tests for template parsers - options (merge strategy resolution)."""
+
+from typing import get_args
+
+import pytest
+
+from hyperextract.utils.template_engine.parsers.options import resolve_merge_strategy
+from hyperextract.utils.template_engine.parsers.schemas.base import (
+ VALID_MERGE_STRATEGIES,
+)
+
+
+class TestResolveMergeStrategy:
+ """``resolve_merge_strategy`` must resolve every documented strategy."""
+
+ @pytest.mark.parametrize("strategy", get_args(VALID_MERGE_STRATEGIES))
+ def test_every_valid_strategy_resolves(self, strategy):
+ """No value declared in ``VALID_MERGE_STRATEGIES`` may resolve to None.
+
+ Regression test: multi-word ``llm_*`` strategies such as
+ ``llm_prefer_incoming`` / ``llm_prefer_existing`` used to fall through the
+ resolver and silently return ``None`` (their name splits into 3 parts,
+ which failed the ``len(parts) == 2`` guard).
+ """
+ assert resolve_merge_strategy(strategy) is not None
+
+ @pytest.mark.parametrize("strategy", ["llm_prefer_incoming", "llm_prefer_existing"])
+ def test_multiword_llm_strategies_map_to_llm_member(self, strategy):
+ """Multi-word ``llm_*`` strategies map onto the nested ``MergeStrategy.LLM``."""
+ from ontomem.merger import MergeStrategy
+
+ expected = getattr(MergeStrategy.LLM, strategy[len("llm_") :].upper())
+ assert resolve_merge_strategy(strategy) == expected