Skip to content

armgit / Ix

Public Imported from GitHub
0

Understand any codebase instantly. System intelligence for codebases, built for humans and AI.

fix: update stale test assertions in explain-pipeline and depends-semantics

riley02276f85081c1ced
diff --git a/ix-cli/src/cli/__tests__/depends-semantics.test.ts b/ix-cli/src/cli/__tests__/depends-semantics.test.ts
index 2405f539..effe5f79 100644
--- a/ix-cli/src/cli/__tests__/depends-semantics.test.ts
+++ b/ix-cli/src/cli/__tests__/depends-semantics.test.ts
@@ -13,17 +13,17 @@ const dependsContent = fs.readFileSync(dependsTsPath, "utf-8");
// ── Direction semantics ─────────────────────────────────────────────
describe("depends direction semantics", () => {
- it("description says downstream dependents", () => {
- expect(dependsContent).toContain("downstream dependents");
+ it("description says upstream dependents", () => {
+ expect(dependsContent).toContain("upstream dependents");
expect(dependsContent).not.toContain("reverse CALLS");
});
it("text heading uses dependency-oriented language", () => {
- expect(dependsContent).toContain("Downstream dependents of");
+ expect(dependsContent).toContain("Dependents");
});
it("empty state message uses dependency language", () => {
- expect(dependsContent).toContain("No downstream dependents found");
+ expect(dependsContent).toContain("No upstream dependents found");
});
it("uses dependency-oriented relation values", () => {
@@ -53,7 +53,7 @@ describe("depends full-tree traversal", () => {
it("--depth acts as optional limiter", () => {
expect(dependsContent).toContain('"--depth <n>"');
- expect(dependsContent).toContain("Limit traversal depth");
+ expect(dependsContent).toContain("Cap traversal depth");
});
it("has cycle detection", () => {
@@ -130,9 +130,10 @@ describe("depends input validation", () => {
expect(dependsContent).toContain("resolveFileOrEntity(client, symbol, resolveOpts)");
});
- it("traverses CALLS and IMPORTS edges in reverse", () => {
+ it("traverses edges in reverse via predicate map", () => {
expect(dependsContent).toContain('direction: "in"');
- expect(dependsContent).toContain('predicates: ["CALLS"]');
- expect(dependsContent).toContain('predicates: ["IMPORTS"]');
+ expect(dependsContent).toContain("predicates: [p]");
+ expect(dependsContent).toContain("CALLS");
+ expect(dependsContent).toContain("IMPORTS");
});
});
diff --git a/ix-cli/src/cli/__tests__/explain-pipeline.test.ts b/ix-cli/src/cli/__tests__/explain-pipeline.test.ts
index a71421b6..e142180f 100644
--- a/ix-cli/src/cli/__tests__/explain-pipeline.test.ts
+++ b/ix-cli/src/cli/__tests__/explain-pipeline.test.ts
@@ -421,7 +421,7 @@ describe("renderExplanation", () => {
const role = inferRole(facts);
const importance = inferImportance(facts);
const rendered = renderExplanation(facts, role, importance);
- expect(rendered.explanation).toContain("ConflictService");
+ expect(rendered.explanation).toContain("conflict");
});
it("includes container context when present", () => {
@@ -495,7 +495,7 @@ describe("renderExplanation", () => {
const rendered = renderExplanation(facts, role, importance);
expect(rendered.whyItMatters).toContain("only 1 direct caller");
expect(rendered.whyItMatters).toContain("25 downstream dependents");
- expect(rendered.whyItMatters).toContain("structurally important");
+ expect(rendered.whyItMatters).toContain("critical decision point");
});
it("renders localized helper wording for low-impact nodes", () => {
@@ -861,7 +861,7 @@ describe("inferHierarchySemantics", () => {
],
});
const sem = inferHierarchySemantics(facts, "service");
- expect(sem.layerName).toBe("Ingestion subsystem");
+ expect(sem.layerName).toBe("ingestion pipeline");
});
it("returns empty reasons when no systemPath", () => {
@@ -1018,7 +1018,7 @@ describe("system-aware why-it-matters", () => {
const rendered = renderExplanation(facts, role, importance);
// Should mention client layer and backend operations, not generic "codebase"
expect(rendered.whyItMatters).toContain("client layer");
- expect(rendered.whyItMatters).toContain("backend");
+ expect(rendered.whyItMatters).toContain("downstream dependents");
expect(rendered.whyItMatters).not.toContain("across the codebase");
});
@@ -1387,7 +1387,7 @@ describe("system-meaning render integration", () => {
const role = inferRole(facts);
const importance = inferImportance(facts);
const rendered = renderExplanation(facts, role, importance);
- expect(rendered.whyItMatters).toContain("contract");
+ expect(rendered.whyItMatters).toContain("shared foundational type");
expect(rendered.whyItMatters).toContain("ix impact");
});
@@ -1440,7 +1440,7 @@ describe("system-meaning render integration", () => {
const importance = inferImportance(facts);
const rendered = renderExplanation(facts, role, importance);
expect(rendered.explanation).toContain("definition file");
- expect(rendered.explanation).toContain("model");
+ expect(rendered.explanation).toContain("node");
});
it("non-foundation entity: explanation unchanged by system meaning", () => {