Understand any codebase instantly. System intelligence for codebases, built for humans and AI.
TypeScript aiai-memoryclaude-codeclicode-analysiscode-mappingcode-memorycodebase-understandingcodexdeveloper-toolsllmopenclawpersistent-memoryprogram-analysissoftware-architecturesystem-intelligencesystem-mapping
fix: fail unresolved machine-readable commands (#532)
Hiro-Chibacd34221d5303
diff --git a/ix-cli/src/cli/__tests__/unresolved-machine-output.test.ts b/ix-cli/src/cli/__tests__/unresolved-machine-output.test.tsnew file mode 100644index 00000000..f2f62357--- /dev/null+++ b/ix-cli/src/cli/__tests__/unresolved-machine-output.test.ts@@ -0,0 +1,55 @@+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";+import { Command } from "commander";++vi.mock("../../client/api.js", () => ({+ IxClient: class {+ async workspaceSystem() { return { systemId: null }; }+ async search() { return []; }+ },+}));++type Register = (program: Command) => void;++async function run(register: Register, args: string[]): Promise<{ stdout: string; stderr: string }> {+ const program = new Command();+ program.name("ix").exitOverride();+ register(program);+ const stdout: string[] = [];+ const stderr: string[] = [];+ const log = vi.spyOn(console, "log").mockImplementation((...parts) => stdout.push(parts.join(" ")));+ const error = vi.spyOn(console, "error").mockImplementation((...parts) => stderr.push(parts.join(" ")));+ try {+ await program.parseAsync(args, { from: "user" });+ } finally {+ log.mockRestore();+ error.mockRestore();+ }+ return { stdout: stdout.join("\n"), stderr: stderr.join("\n") };+}++describe("unresolved targets in machine formats", () => {+ let savedExitCode: number | string | undefined;++ beforeEach(() => {+ savedExitCode = process.exitCode;+ process.exitCode = undefined;+ });++ afterEach(() => {+ process.exitCode = savedExitCode;+ });++ it.each([+ ["context", async () => (await import("../commands/context.js")).registerContextCommand],+ ["explain", async () => (await import("../commands/explain.js")).registerExplainCommand],+ ["read", async () => (await import("../commands/read.js")).registerReadCommand],+ ] as const)("returns JSON and a non-zero status from ix %s", async (command, loadRegister) => {+ const result = await run(await loadRegister(), [command, "DefinitelyMissing", "--format", "json"]);++ expect(process.exitCode).toBe(1);+ expect(JSON.parse(result.stdout)).toEqual({+ error: "unresolved_target",+ message: 'No entity found matching "DefinitelyMissing".',+ });+ });+});diff --git a/ix-cli/src/cli/commands/context.ts b/ix-cli/src/cli/commands/context.tsindex 1667feb6..ea9f3e8c 100644--- a/ix-cli/src/cli/commands/context.ts+++ b/ix-cli/src/cli/commands/context.ts@@ -22,7 +22,7 @@ import { llmLine, printLlmLines } from "../llm.js";import { parseBudgetOption, parsePickOption, parseRevisionOption } from "../options.js";import { resolveFileOrEntity } from "../resolve.js";import { createStaleProbe, hasCompletedMapBaseline } from "../stale.js";-import { renderNote, renderSection, renderWarning, renderWarningErr, reportFailure } from "../ui.js";+import { renderNote, renderSection, renderWarning, renderWarningErr, reportFailure, reportUnresolvedTarget } from "../ui.js";/** The four `--max-*` knobs that bound a bundle. */interface BudgetSnapshot {@@ -307,7 +307,10 @@ export function registerContextCommand(program: Command): void {path: opts.path,pick: opts.pick,});- if (!resolved) return;+ if (!resolved) {+ reportUnresolvedTarget(target, opts.format);+ return;+ }const budgets = clampBudgets(opts);const asOfRev = opts.asOfRev;diff --git a/ix-cli/src/cli/commands/explain.ts b/ix-cli/src/cli/commands/explain.tsindex 16971285..a0ed4872 100644--- a/ix-cli/src/cli/commands/explain.ts+++ b/ix-cli/src/cli/commands/explain.ts@@ -11,7 +11,7 @@ import { renderExplanation } from "../explain/render.js";import { renderExplainLlm, renderExplainRawLlm } from "../explain/llm.js";import { printLlmLines } from "../llm.js";import { parsePickOption } from "../options.js";-import { renderSection, renderWarning, renderNote } from "../ui.js";+import { renderSection, renderWarning, renderNote, reportUnresolvedTarget } from "../ui.js";export function registerExplainCommand(program: Command): void {program@@ -27,7 +27,10 @@ export function registerExplainCommand(program: Command): void {const client = new IxClient(getEndpoint());const resolveOpts = { kind: opts.kind, path: opts.path, pick: opts.pick };const target = await resolveFileOrEntity(client, symbol, resolveOpts);- if (!target) return;+ if (!target) {+ reportUnresolvedTarget(symbol, opts.format);+ return;+ }if (opts.raw) {await rawExplain(client, target, opts.format);diff --git a/ix-cli/src/cli/commands/read.ts b/ix-cli/src/cli/commands/read.tsindex bb1d4f0c..4479b725 100644--- a/ix-cli/src/cli/commands/read.ts+++ b/ix-cli/src/cli/commands/read.ts@@ -10,6 +10,7 @@ import { isFileStale } from "../stale.js";import { relativePath } from "../format.js";import { llmLine, printLlmLines } from "../llm.js";import { parsePickOption } from "../options.js";+import { reportUnresolvedTarget } from "../ui.js";export interface ReadResult {targetType: "file" | "file-range" | "filename-match" | "symbol";@@ -323,7 +324,7 @@ Examples:return;}- stderr(`Could not resolve "${target}" as a file or symbol.`);+ reportUnresolvedTarget(target, opts.format);});}diff --git a/ix-cli/src/cli/ui.ts b/ix-cli/src/cli/ui.tsindex b29aaa0e..6cc33bdd 100644--- a/ix-cli/src/cli/ui.ts+++ b/ix-cli/src/cli/ui.ts@@ -131,3 +131,14 @@ export function reportFailure(code: string, message: string, format?: string): velse console.error(chalk.red("Error:"), message);process.exitCode = 1;}++/** Report a resolver miss without corrupting machine-readable stdout. */+export function reportUnresolvedTarget(target: string, format?: string): void {+ const message = `No entity found matching "${target}".`;+ if (format === "json") {+ console.log(JSON.stringify({ error: "unresolved_target", message }, null, 2));+ } else if (format === "llm") {+ console.log(llmError("unresolved_target", message));+ }+ process.exitCode = 1;+}