Skip to content

armgit / Ix

Public Imported from GitHub
0

Understand any codebase instantly. System intelligence for codebases, built for humans and AI.

fix(rank): scope candidates by path before applying the fetch limit (#632)

Hiro-Chibaebcc121046ac
diff --git a/ix-cli/src/cli/__tests__/rank-path-scope.test.ts b/ix-cli/src/cli/__tests__/rank-path-scope.test.ts
new file mode 100644
index 00000000..dc7bd144
--- /dev/null
+++ b/ix-cli/src/cli/__tests__/rank-path-scope.test.ts
@@ -0,0 +1,58 @@
+import { afterEach, beforeEach, describe, expect, it, vi } from "vitest";
+import { Command } from "commander";
+import { registerRankCommand } from "../commands/rank.js";
+
+const { listByKind, expand } = vi.hoisted(() => ({ listByKind: vi.fn(), expand: vi.fn() }));
+vi.mock("../../client/api.js", () => ({
+ IxClient: class {
+ async listByKind(...args: unknown[]) { return listByKind(...args); }
+ async expand(...args: unknown[]) { return expand(...args); }
+ },
+}));
+vi.mock("../resolve.js", () => ({
+ ensureReadScope: async () => {},
+ activeReadScope: () => ({ workspaceId: "test-workspace" }),
+}));
+
+async function run(args: string[]) {
+ const program = new Command().name("ix").exitOverride();
+ registerRankCommand(program);
+ const output: string[] = [];
+ vi.spyOn(console, "log").mockImplementation((value) => { output.push(String(value)); });
+ await program.parseAsync(["rank", "--by", "members", "--kind", "class", "--format", "json", ...args], { from: "user" });
+ return JSON.parse(output.join("\n"));
+}
+
+describe("rank path filtering before the candidate limit", () => {
+ beforeEach(() => {
+ const nodes = [
+ ...Array.from({ length: 2000 }, (_, i) => ({ id: `other-${i}`, name: `Other${i}`, kind: "class", provenance: { sourceUri: "src/other.ts" } })),
+ { id: "wanted", name: "Wanted", kind: "class", provenance: { sourceUri: "src/target.ts" } },
+ ];
+ listByKind.mockReset().mockImplementation(async (_kind, opts) =>
+ nodes.filter(n => !opts.scope || n.provenance.sourceUri.includes(opts.scope)).slice(0, opts.limit),
+ );
+ expand.mockReset().mockResolvedValue({ nodes: [{ id: "member" }], edges: [] });
+ });
+ afterEach(() => vi.restoreAllMocks());
+
+ it("ranks a matching entity beyond the first 2000 unfiltered candidates", async () => {
+ const output = await run(["--path", "src/target.ts"]);
+ expect(listByKind).toHaveBeenCalledWith("class", { limit: 2000, scope: "src/target.ts", workspaceId: "test-workspace" });
+ expect(output.results).toEqual([{ name: "Wanted", kind: "class", score: 1 }]);
+ expect(expand).toHaveBeenCalledTimes(1);
+ expect(expand).toHaveBeenCalledWith("wanted", expect.anything());
+ });
+
+ it("preserves client-side exclusions after the scoped fetch", async () => {
+ const output = await run(["--path", "src/target.ts", "--exclude-path", "target"]);
+ expect(output.results).toEqual([]);
+ expect(expand).not.toHaveBeenCalled();
+ });
+
+ it("reports a genuinely unmatched path without expanding unrelated entities", async () => {
+ const output = await run(["--path", "missing.ts"]);
+ expect(output.results).toEqual([]);
+ expect(expand).not.toHaveBeenCalled();
+ });
+});
diff --git a/ix-cli/src/cli/commands/rank.ts b/ix-cli/src/cli/commands/rank.ts
index bf1cc06a..133e04f2 100644
--- a/ix-cli/src/cli/commands/rank.ts
+++ b/ix-cli/src/cli/commands/rank.ts
@@ -173,7 +173,7 @@ export function registerRankCommand(program: Command): void {
// 1. Fetch all entities of the given kind
await ensureReadScope(client); // fold in a Path-2 stitched system (Ix#225 Half B)
- const allNodes = await client.listByKind(opts.kind, { limit: 2000, ...activeReadScope() });
+ const allNodes = await client.listByKind(opts.kind, { limit: 2000, scope: opts.path || undefined, ...activeReadScope() });
if (allNodes.length === 0) {
if (opts.format === "llm") {