[MLsys2026 Best Paper]: https://arxiv.org/abs/2506.08276. RAG on Everything with LEANN. Enjoy 97% storage savings while running a fast, accurate, and 100% private RAG application on your personal device.
Python aifaissgpt-osslangchainllama-indexllmlocalstorageoffline-firstollamaprivacypythonragretrieval-augmented-generationvector-databasevector-searchvectors
fix: compare numeric metadata strings by value (#446)
Tianlang (Jackie) Chen37795892341d
diff --git a/docs/metadata_filtering.md b/docs/metadata_filtering.mdindex 1a267e1..527270a 100644--- a/docs/metadata_filtering.md+++ b/docs/metadata_filtering.md@@ -78,6 +78,9 @@ metadata_filters = {{"word_count": {"<": 500}} # Short passages```+Numeric values stored as strings are ordered numerically (for example,+`"10" > "2"`). Other strings, including ISO dates, retain lexical ordering.+#### Membership Operators- `"in"`: Value is in list- `"not_in"`: Value is not in listdiff --git a/packages/leann-core/src/leann/metadata_filter.py b/packages/leann-core/src/leann/metadata_filter.pyindex 9baf836..57f0508 100644--- a/packages/leann-core/src/leann/metadata_filter.py+++ b/packages/leann-core/src/leann/metadata_filter.py@@ -7,6 +7,7 @@ operators for different data types including numbers, strings, booleans, and lis"""import logging+from decimal import Decimal, InvalidOperationfrom typing import Any, Optional, Unionlogger = logging.getLogger(__name__)@@ -223,7 +224,15 @@ class MetadataFilterEngine:try:# Try to convert both values to numbers for comparisonif isinstance(field_value, str) and isinstance(expected_value, str):- # String comparison if both are strings+ # Numeric metadata can also be stored as strings. Keep lexical+ # ordering for dates and other strings that are not numbers.+ try:+ field_decimal = Decimal(field_value)+ expected_decimal = Decimal(expected_value)+ if field_decimal.is_finite() and expected_decimal.is_finite():+ return compare_func(field_decimal, expected_decimal)+ except InvalidOperation:+ passreturn compare_func(field_value, expected_value)# Numeric comparison - attempt to convert to floatdiff --git a/tests/test_metadata_filter_numeric_strings.py b/tests/test_metadata_filter_numeric_strings.pynew file mode 100644index 0000000..9050f01--- /dev/null+++ b/tests/test_metadata_filter_numeric_strings.py@@ -0,0 +1,26 @@+"""Regression tests for comparisons of metadata stored as strings."""++from leann.metadata_filter import MetadataFilterEngine+++def test_numeric_strings_compare_by_value():+ results = [+ {"id": "ten", "metadata": {"chapter": "10"}},+ {"id": "two", "metadata": {"chapter": "2"}},+ {"id": "negative", "metadata": {"chapter": "-3"}},+ ]++ matched = MetadataFilterEngine().apply_filters(results, {"chapter": {">": "2"}})++ assert [result["id"] for result in matched] == ["ten"]+++def test_non_numeric_strings_keep_lexical_comparison():+ results = [+ {"id": "early", "metadata": {"date": "2024-01-01"}},+ {"id": "late", "metadata": {"date": "2025-01-01"}},+ ]++ matched = MetadataFilterEngine().apply_filters(results, {"date": {">": "2024-12-31"}})++ assert [result["id"] for result in matched] == ["late"]