Skip to content

Enhanced ChatGPT Clone: Features Agents, MCP, Skills, DeepSeek, Anthropic, AWS, OpenAI, Responses API, Azure, Groq, o1, GPT-5, Mistral, OpenRouter, Vertex AI, Gemini, Artifacts, AI model switching, message search, Code Interpreter, langchain, DALL-E-3, OpenAPI Actions, Functions, Secure Multi-User Auth, Presets, open-source for self-hosting. Active

4.6 KB
Raw Blame
import FormData from 'form-data';
import { Readable } from 'stream';
import { appendCodeEnvFile, getCodeEnvFileOptions, getCodeEnvUploadFilename } from './form';

function renderMultipartDisposition(append: (form: FormData) => void): Promise<string> {
  const form = new FormData();
  append(form);

  const chunks: Buffer[] = [];
  form.on('data', (chunk: Buffer | string) => {
    chunks.push(Buffer.isBuffer(chunk) ? chunk : Buffer.from(chunk));
  });

  return new Promise<string>((resolve, reject) => {
    form.on('end', () => {
      const body = Buffer.concat(chunks).toString('utf8');
      resolve(body.match(/Content-Disposition:.*/)?.[0] ?? '');
    });
    form.on('error', reject);
    form.resume();
  });
}

describe('code env FormData filenames', () => {
  it.each([
    ['my dir/file.csv', 'file.csv'],
    ['safe/file.csv', 'safe/file.csv'],
    ['分析/結果📊.csv', '分析/結果📊.csv'],
    ['../../file.csv', 'file.csv'],
  ])('plans the exact multipart destination for %s', async (input, expected) => {
    const destination = getCodeEnvUploadFilename(input);
    expect(destination).toBe(expected);
    expect(getCodeEnvUploadFilename(destination)).toBe(destination);
    const disposition = await renderMultipartDisposition((form) => {
      appendCodeEnvFile(form, Readable.from(['bytes']), destination);
    });
    expect(disposition).toContain(`filename="${destination}"`);
  });

  it('uses filepath for nested filenames so form-data preserves directories', async () => {
    const disposition = await renderMultipartDisposition((form) => {
      appendCodeEnvFile(form, Readable.from(['x']), 'pptx/pptx.py');
    });

    expect(disposition).toContain('filename="pptx/pptx.py"');
  });

  it('uses filepath for deeply nested safe filenames', () => {
    expect(getCodeEnvFileOptions('a/b/c/d.py')).toEqual({
      filename: 'd.py',
      filepath: 'a/b/c/d.py',
    });
  });

  it('uses filepath for nested Unicode filenames', () => {
    expect(getCodeEnvFileOptions('分析/結果📊.csv')).toEqual({
      filename: '結果📊.csv',
      filepath: '分析/結果📊.csv',
    });
  });

  it('documents the form-data string overload regression', async () => {
    const disposition = await renderMultipartDisposition((form) => {
      form.append('file', Readable.from(['x']), 'pptx/pptx.py');
    });

    expect(disposition).toContain('filename="pptx.py"');
  });

  it('keeps flat filenames as filename-only options', () => {
    expect(getCodeEnvFileOptions('script.py')).toEqual({ filename: 'script.py' });
  });

  it('normalizes Windows separators before sending path-bearing filenames', () => {
    expect(getCodeEnvFileOptions('pptx\\pptx.py')).toEqual({
      filename: 'pptx.py',
      filepath: 'pptx/pptx.py',
    });
  });

  it('does not preserve traversal paths as filepath options', async () => {
    expect(getCodeEnvFileOptions('../../evil.py')).toEqual({ filename: 'evil.py' });
    expect(getCodeEnvFileOptions('..\\..\\evil.py')).toEqual({ filename: 'evil.py' });

    const disposition = await renderMultipartDisposition((form) => {
      appendCodeEnvFile(form, Readable.from(['x']), '../../evil.py');
    });

    expect(disposition).toContain('filename="evil.py"');
    expect(disposition).not.toContain('../');
  });

  it('does not preserve absolute paths as filepath options', () => {
    expect(getCodeEnvFileOptions('/tmp/evil.py')).toEqual({ filename: 'evil.py' });
    expect(getCodeEnvFileOptions('C:\\tmp\\evil.py')).toEqual({ filename: 'evil.py' });
  });

  it('does not preserve empty or dot path segments as filepath options', () => {
    expect(getCodeEnvFileOptions('pptx//pptx.py')).toEqual({ filename: 'pptx.py' });
    expect(getCodeEnvFileOptions('pptx/./pptx.py')).toEqual({ filename: 'pptx.py' });
    expect(getCodeEnvFileOptions('pptx/..')).toEqual({ filename: 'file' });
    expect(getCodeEnvFileOptions('pptx/')).toEqual({ filename: 'pptx' });
  });

  it('uses safe fallback names for empty or degenerate filenames', () => {
    expect(getCodeEnvFileOptions('')).toEqual({ filename: 'file' });
    expect(getCodeEnvFileOptions('.')).toEqual({ filename: 'file' });
    expect(getCodeEnvFileOptions('..')).toEqual({ filename: 'file' });
  });

  it('keeps unsafe flat filenames flat instead of rewriting user-visible names', () => {
    expect(getCodeEnvFileOptions('my notes @ draft.py')).toEqual({
      filename: 'my notes @ draft.py',
    });
  });

  it('scrubs control characters from fallback filenames', () => {
    expect(getCodeEnvFileOptions('report\nContent-Disposition.py')).toEqual({
      filename: 'report_Content-Disposition.py',
    });
    expect(getCodeEnvFileOptions('../evil\r.py')).toEqual({ filename: 'evil_.py' });
  });
});